--- Log opened Thu Sep 05 00:00:43 2024
00:26 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
00:32 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Ping timeout: 248 seconds]
00:42 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
00:43 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
00:49 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Ping timeout: 260 seconds]
00:49 -!- danielabrozzoni [sid661616@id-661616.ilkley.irccloud.com] has quit [Ping timeout: 260 seconds]
00:49 -!- benwestgate [~BenWestga@2603:8080:7401:18ac:ab59:5768:d35a:5f08] has quit [Remote host closed the connection]
00:49 -!- danielabrozzoni [sid661616@id-661616.ilkley.irccloud.com] has joined #bitcoin-core-dev
00:49 -!- cm_ [~chaz@user/cm] has joined #bitcoin-core-dev
00:50 -!- PatBoy [xyz@cryption.cn] has quit [Quit: ZNC 1.8.2 - https://znc.in]
00:50 -!- Murch[m] [~murch@user/murch] has quit [Ping timeout: 260 seconds]
00:50 -!- sr_gi[m]1 [~srgimatri@2620:6e:a000:ce11::2a] has quit [Ping timeout: 260 seconds]
00:50 -!- PatBoy [xyz@cryption.cn] has joined #bitcoin-core-dev
00:50 -!- Murch[m] [~murch@2620:6e:a000:ce11::1b] has joined #bitcoin-core-dev
00:50 -!- cm [~chaz@user/cm] has quit [Ping timeout: 260 seconds]
00:50 -!- harding_ [quassel@newmail.dtrt.org] has quit [Ping timeout: 260 seconds]
00:50 -!- emzy [~quassel@user/emzy] has quit [Ping timeout: 260 seconds]
00:50 -!- cm_ is now known as cm
00:50 -!- emzy [~quassel@user/emzy] has joined #bitcoin-core-dev
00:53 -!- harding [quassel@newmail.dtrt.org] has joined #bitcoin-core-dev
01:03 -!- sr_gi[m]1 [~srgimatri@2620:6e:a000:ce11::2a] has joined #bitcoin-core-dev
01:15 -!- abubakarsadiq [uid602234@hampstead.irccloud.com] has joined #bitcoin-core-dev
01:20 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
01:20 < fanquake> Sjors: not sure why cmake would make a difference in that regard. Sounds like you're looking for something list distcc, which also worked fine with autotools
01:23 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/93e48240bfdc...f794a0d5f404
01:23 < bitcoin-git> bitcoin/master e5f7272 marcofleon: doc: fix assumeutxo design doc link
01:23 < bitcoin-git> bitcoin/master f794a0d merge-script: Merge bitcoin/bitcoin#30819: doc: fix assumeutxo design doc link
01:23 < bitcoin-git> [bitcoin] fanquake merged pull request #30819: doc: fix assumeutxo design doc link (master...2024/09/fix-assumeutxo-doc) https://github.com/bitcoin/bitcoin/pull/30819
01:26 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Ping timeout: 264 seconds]
01:31 < Sjors[m]11> fanquake: because I need it cross-compile on linux for macOS.
01:31 < Sjors[m]11> Ok, still distcc, I'll look into that again.
01:32 < fanquake> nothing has changed with CMake in that regard
01:33 < fanquake> If anything, #21778 would have simplified it somewhat, now that we are using more native/just LLVM tooling
01:33 <@gribble> https://github.com/bitcoin/bitcoin/issues/21778 | build: LLD based macOS toolchain by fanquake · Pull Request #21778 · bitcoin/bitcoin · GitHub
01:42 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
01:51 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Ping timeout: 260 seconds]
01:59 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
02:05 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
02:10 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Ping timeout: 255 seconds]
02:23 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
02:25 -!- pablomartin [~pablomart@92.118.60.248] has joined #bitcoin-core-dev
02:28 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Ping timeout: 245 seconds]
02:36 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f794a0d5f404...79772cd26ebd
02:36 < bitcoin-git> bitcoin/master 5567754 fanquake: depends: build libevent with -D_GNU_SOURCE
02:36 < bitcoin-git> bitcoin/master 79772cd merge-script: Merge bitcoin/bitcoin#30743: depends: build libevent with `-D_GNU_SOURCE`
02:36 < bitcoin-git> [bitcoin] fanquake merged pull request #30743: depends: build libevent with `-D_GNU_SOURCE` (master...libevent_non_gnu_c) https://github.com/bitcoin/bitcoin/pull/30743
02:37 -!- qxs [~qxs@gateway/tor-sasl/qxs] has quit [Ping timeout: 260 seconds]
02:39 -!- qxs [~qxs@gateway/tor-sasl/qxs] has joined #bitcoin-core-dev
02:59 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
03:05 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Ping timeout: 260 seconds]
03:10 -!- jleost [~jleost@152.248.97.244] has joined #bitcoin-core-dev
03:18 -!- pablomartin4btc [~pablomart@92.118.60.252] has joined #bitcoin-core-dev
03:18 -!- pablomartin [~pablomart@92.118.60.248] has quit [Ping timeout: 245 seconds]
03:22 < bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/79772cd26ebd...fa05ee0517d5
03:22 < bitcoin-git> bitcoin/master fe2003a Hennadii Stepanov: build: Add `COMMAND_ERROR_IS_FATAL` to every process in coverage scrips
03:22 < bitcoin-git> bitcoin/master e7cf4a6 Hennadii Stepanov: build: Add missed `-g` for "Coverage" build configuration
03:22 < bitcoin-git> bitcoin/master d9fcbfc Hennadii Stepanov: build: Add `JOBS` variable support to `CoverageFuzz.cmake` script
03:22 < bitcoin-git> [bitcoin] fanquake merged pull request #30772: build: Fix / improve coverage scripts (master...280830-coverage) https://github.com/bitcoin/bitcoin/pull/30772
03:24 -!- jirijakes [~jirijakes@118.150.148.23] has joined #bitcoin-core-dev
03:24 -!- pablomartin4btc [~pablomart@92.118.60.252] has quit [Remote host closed the connection]
03:25 -!- pablomartin4btc [~pablomart@92.118.60.252] has joined #bitcoin-core-dev
03:36 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
03:41 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Ping timeout: 260 seconds]
03:43 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
03:56 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
04:05 -!- pablomartin4btc [~pablomart@92.118.60.252] has quit [Remote host closed the connection]
04:06 -!- pablomartin4btc [~pablomart@92.118.60.252] has joined #bitcoin-core-dev
04:06 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Ping timeout: 265 seconds]
04:10 -!- pablomartin4btc [~pablomart@92.118.60.252] has quit [Client Quit]
04:20 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
04:24 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Ping timeout: 246 seconds]
04:37 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
04:42 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Ping timeout: 248 seconds]
04:42 -!- jirijakes [~jirijakes@118.150.148.23] has quit [Ping timeout: 260 seconds]
04:56 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
05:02 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Ping timeout: 272 seconds]
05:12 -!- conman [~con@180-150-21-3.b49615.mel.static.aussiebb.net] has joined #bitcoin-core-dev
05:13 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
05:18 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Ping timeout: 246 seconds]
05:31 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
05:34 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [Closing Window]
05:36 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Ping timeout: 260 seconds]
05:46 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/fa05ee0517d5...6852d1d487a7
05:46 < bitcoin-git> bitcoin/master fac9736 MarcoFalke: test: Use string_view for json_tests
05:46 < bitcoin-git> bitcoin/master faecca9 MarcoFalke: test: Use span for raw data
05:46 < bitcoin-git> bitcoin/master 6852d1d merge-script: Merge bitcoin/bitcoin#30796: test: Use std::span and std::string_view for ...
05:46 < bitcoin-git> [bitcoin] fanquake merged pull request #30796: test: Use std::span and std::string_view for raw data (master...2409-raw-data) https://github.com/bitcoin/bitcoin/pull/30796
05:50 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
05:53 < bitcoin-git> [bitcoin] glozow opened pull request #30820: TxDownloadManager refactor followups (master...2024-09-30110-followups) https://github.com/bitcoin/bitcoin/pull/30820
05:55 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Ping timeout: 246 seconds]
06:03 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
06:08 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Ping timeout: 252 seconds]
06:21 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
06:24 < bitcoin-git> [bitcoin] fanquake opened pull request #30821: build: work around issue with Boost = 1.80 and Clang = 18 (master...boost_174_clang_18) https://github.com/bitcoin/bitcoin/pull/30821
06:26 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Ping timeout: 260 seconds]
06:27 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
06:29 < bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6852d1d487a7...d6a1b94ffdd8
06:29 < bitcoin-git> bitcoin/master 7346b01 Sebastian Falbesoner: qt, build: remove unneeded `Q_IMPORT_PLUGIN` macro calls
06:29 < bitcoin-git> bitcoin/master d6a1b94 Hennadii Stepanov: Merge bitcoin-core/gui#834: qt, build: remove unneeded `Q_IMPORT_PLUGIN` m...
06:29 < bitcoin-git> [gui] hebasto merged pull request #834: qt, build: remove unneeded `Q_IMPORT_PLUGIN` macro calls (master...202409-gui-remove-unneeded-q_import_plugin) https://github.com/bitcoin-core/gui/pull/834
06:29 < glozow> question: why is `DBUILD_BENCH` false by default?
06:31 < hebasto> glozow: it was a rough consensus that running benchmarks is not a part for everyday routine for the majority of developers
06:32 < glozow> hebasto: I see, I suppose that is true!
06:32 -!- elichai2 [sid212594@id-212594.hampstead.irccloud.com] has quit [Ping timeout: 276 seconds]
06:32 -!- cncr04s [~cncr04s@ns1.afxr.net] has quit [Quit: See you real soon!]
06:32 -!- cncr04s [~cncr04s@ns1.afxr.net] has joined #bitcoin-core-dev
06:32 -!- phantomcircuit_ [~phantomci@2604:a880:1:20::f2:c001] has joined #bitcoin-core-dev
06:33 < hebasto> the same reasoning was behind disabling `BUILD_GUI` by default :)
06:33 -!- phantomcircuit [~phantomci@2604:a880:1:20::f2:c001] has quit [Read error: Connection reset by peer]
06:33 < glozow> makes sense :)
06:35 -!- elichai2 [sid212594@id-212594.hampstead.irccloud.com] has joined #bitcoin-core-dev
06:53 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d6a1b94ffdd8...d661e2b1b771
06:53 < bitcoin-git> bitcoin/master fa3a7eb MarcoFalke: lint: Check for release note snippets in the wrong folder
06:53 < bitcoin-git> bitcoin/master d661e2b merge-script: Merge bitcoin/bitcoin#30812: lint: Check for release note snippets in the ...
06:53 < bitcoin-git> [bitcoin] fanquake merged pull request #30812: lint: Check for release note snippets in the wrong folder (master...2409-lint-rel-notes) https://github.com/bitcoin/bitcoin/pull/30812
06:54 -!- kashifs [~kashifs@2603:7000:4600:500:4826:7d45:d6db:1cf7] has joined #bitcoin-core-dev
06:55 < achow101> the benchmarks were part of make check though
06:56 -!- abubakarsadiq [uid602234@hampstead.irccloud.com] has quit [Quit: Connection closed for inactivity]
06:56 < furszy> would love to see a "build-everything-was-build-on-autotools-by-default" flag on cmake :p
06:57 -!- yuvic [~yuvic@117.250.64.129] has joined #bitcoin-core-dev
06:57 -!- yuvic [~yuvic@user/yuvic] has changed host
06:57 < hebasto> ctest runs `bench_bitcoin -sanity-check -priority-level=high` if they are compiled
06:57 -!- yuvic [~yuvic@user/yuvic] has quit [Remote host closed the connection]
06:57 < hebasto> re "would love to see a "build-everything-was-build-on-autotools-by-default" flag on cmake" -- `CMakeUserPresets.json` may help
06:59 -!- Emc99 [~Emc99@212.129.72.166] has joined #bitcoin-core-dev
07:00 < furszy> k, will check it. Do we have it written in the productivity notes or somewhere in the repo?
07:00 < hebasto> I don't think so
07:00 < achow101> #startmeeting
07:00 < achow101> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard aureleoules b10c BlueMatt brunoerg cfields darosior dergoegge dongcarl fanquake fjahr furszy gleb glozow hebasto instagibbs jamesob jarolrod jonatack josibake kallewoof kanzure kouloumos kvaciral laanwj LarryRuane lightlike luke-jr MacroFake Murch phantomcircuit pinheadmz promag provoostenator ryanofsky sdaftuar S3RK stickies-v sipa sr_gi theStack TheCharlatan vasild
07:00 < hebasto> hi
07:00 < furszy> hi
07:00 < stickies-v> hi
07:00 < vasild> hi
07:00 < lightlike> hi
07:00 < achow101> There are no pre-proposed meeting topics this week. Any last minute ones to add?
07:00 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
07:01 -!- dzxzg [~dzxzg@2600:387:8:f::96] has joined #bitcoin-core-dev
07:01 < fjahr> hi
07:01 < dzxzg> hi
07:01 < kanzure> hi
07:01 < achow101> #topic Ad-hoc high priority for review
07:01 < achow101> Anything to add or remove from https://github.com/orgs/bitcoin/projects/1/views/4
07:02 < furszy> #30807 for v28
07:02 <@gribble> https://github.com/bitcoin/bitcoin/issues/30807 | Fix peers abruptly disconnecting from AssumeUTXO nodes during IBD by furszy · Pull Request #30807 · bitcoin/bitcoin · GitHub
07:02 < tdb3> hi
07:02 < sipa> hi
07:02 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Ping timeout: 252 seconds]
07:03 < willcl-ark> Hi
07:03 < josie> hi
07:03 < achow101> furszy: milestoned
07:03 < furszy> thx
07:04 < achow101> #topic 28.0 release priorities
07:04 < achow101> Anything else to add to the milestone?
07:04 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
07:04 < achow101> #30762 is the current backports pr. i would like to tag rc2 tomorrow
07:04 <@gribble> https://github.com/bitcoin/bitcoin/issues/30762 | [28.x] rc backports by fanquake · Pull Request #30762 · bitcoin/bitcoin · GitHub
07:05 < fanquake> so i guess we are doing at least an rc3 then? unless 30807 is being rushed in
07:05 < achow101> fanquake: haven't looked at 30807 yet and will make a determination after the meeting
07:06 < achow101> has the boost and clang incompatibiliy been resolved yet?
07:06 < fanquake> potential fix is in #30821
07:07 <@gribble> https://github.com/bitcoin/bitcoin/issues/30821 | build: work around issue with Boost <= 1.80 and Clang >= 18 by fanquake · Pull Request #30821 · bitcoin/bitcoin · GitHub
07:07 < achow101> ok, maybe i'll wait for that to land first
07:08 < achow101> any other topics to discuss?
07:09 < fanquake> has anyone run into any issues testing rc1? Is the review club for testing this week?
07:09 < fanquake> or is that next week
07:09 < stickies-v> it's scheduled for sept 11th
07:09 < stickies-v> https://bitcoincore.reviews/v28-rc-testing
07:11 < achow101> so far the only issue with rc1 that i've noticed is the testnet4 consensus failure
07:11 < achow101> #endmeeting
07:12 < instagibbs> which consensus failure is that
07:12 < achow101> #30786
07:12 <@gribble> https://github.com/bitcoin/bitcoin/issues/30786 | Testnet4 consensus failure due to timewarp related "softfork" · Issue #30786 · bitcoin/bitcoin · GitHub
07:12 -!- Emc99 [~Emc99@212.129.72.166] has quit [Quit: Client closed]
07:14 < achow101> looks like the reorg happend yesterday
07:14 < achow101> 400 block reorg waow
07:19 < glozow> nice, did we pull off a uasf?
07:20 -!- dzxzg [~dzxzg@2600:387:8:f::96] has quit [Quit: Ping timeout (120 seconds)]
07:20 < achow101> wouldn't have happened without some miners paying attention though and switching over
07:21 < instagibbs> I mean that's not a consensus failure, you just needed some miners to enforce the Users Will
07:21 < instagibbs> ?
07:22 -!- dzxzg [~dzxzg@mobile-107-77-230-4.mobile.att.net] has joined #bitcoin-core-dev
07:24 < lightlike> so re: bench/fuzz/gui compilation, is the intentioned "typical" workflow for devs to work on whatever you are working on with just the basics compiled, then compile everything (and maybe fix compilation failures), then open PR? I always thought previously bench/fuzz etc. was enabled by default not to run them but to make they sure they still compile.
07:26 < maflcko> lightlike: For developers it makes sense to compile as much as possible, for the reasons given by you. However, other people compiling from source (users) may not want to build some stuff by default?
07:26 < fanquake> lightlike: I'd think the typical flow should be for each dev to setup a cmake preset, which compiles exactly what they want/don't want, and to just work as normal
07:26 < sipa> i saw some earlier discussion around that, and hebasto suggested adding a preset with all dev-related things enabled?
07:27 < sipa> can we have such a preset be part of the project?
07:28 < luke-jr> I thought the current defaults were meant to be ideal for devs
07:28 < fanquake> that is also something we could do, which I assume would be basically + fuzz + bench
07:28 < hebasto> sipa: yes, we can
07:28 < fanquake> luke-jr: what's ideal depends on what you're working on
07:29 < luke-jr> IMO it would be ideal for defaults to be user-oriented
07:29 < sipa> luke-jr: i think the current cmake defaults are user-oriented (more so than the autotools defaults were)
07:29 < luke-jr> sipa: GUI disabled by default certainly isn't
07:30  * luke-jr wonders if make -C src bitcoind still works
07:30 < sipa> luke-jr: ah i was thinking in terms of artefacts, not dependencies
07:32 < sipa> fanquake, hebasto: i think it'd be useful to have a preset with "enable all the things" for development, which could be updated when new artefacts/features/... are added, because as a developer who creates a PR, you want to make sure you've compiled as much as possible you can locally before submitting (e.g. say the default is not to compile benchmarks, even if in the code you're currently working 
07:32 < sipa> on you don't care (or even know about the existence of)...
07:32 < sipa> benchmarks, it'd be annoying if you miss that you introduced a compilation error in the benchmarks by not building it)
07:33 < achow101> should "all the things" also include optional dependencies?
07:33 < fanquake> Having a minimal set of initial default things turned on, means that everyone can do exactly what they want, by opting in to whatever they want. Having a convenience preset in the repo, for "development" seems like a good idea. Outside of that, anyone who wants to setup their own compilation to suit themselves, has the flexibility of presets to do so.
07:33 < hebasto> ^ I concur
07:34 < sipa> fanquake: right, i'm happy to create a preset for myself with whatever i care about, and i assume the same is true for most regularly contributors... but for occasional contributors, a "enable as much as possible that i might not even be aware of exists" may make sense
07:34 < sipa> achow101: i guess yes
07:36 < achow101> I think we should provide a couple different presets in repo: 1) development preset, 2) everything that goes in a release preset, 3) fuzzing preset
07:36 < sipa> yeah that may make sense
07:37 < fanquake> This is also something that we need to expand the developer / productivity notes to encompass
07:37 < sipa> yeah
07:37 < achow101> one for each of the ci configs would also be useful
07:37 < fanquake> we are actually having a related discussion about that in https://github.com/bitcoin/bitcoin/pull/30755#discussion_r1743843129
07:38 < fanquake> i.e, should the CI config live in presets, or in the scripts etc
07:38 < maflcko> achow101: That'd be difficult, becusea the CI configs really test different compiler versions and packaging/depends settings, which may not exist on the dev machine?
07:38 < fanquake> as we don't want subtly changing presets, to inadvertantly change things in the ci
07:39 < luke-jr> maflcko: we could get half of it in a preset?
07:39 < fanquake> althought the CI presets could exist separately under /ci etc
07:40 < luke-jr> even if not every issue can be reproduced with a preset, it might help sometimes
07:40 < maflcko> For example, the "tidy" preset would just be equal to the "compile-all" preset. However, you would get nothing similar to the tidy CI otherwise
07:40 < achow101> ci presets could live under /ci which makes it clear that they're intended to only work on ci, but when people are trying to reproduce locally, at least the config is easily available and they just need to hunt down the right dependnencies and versions
07:41 < bitcoin-git> [bitcoin] fanquake opened pull request #30822: cmake: scope Boost Test check to `vcpkg` (master...scope_boost_test_vcpkg) https://github.com/bitcoin/bitcoin/pull/30822
07:41 < achow101> a lot of times though, when I'm debugging ci failures, the things i'm interested in that would be in a preset are which sanitizers are enabled, or which extra flags have been set, or was it gcc or clang that was used
07:45 < maflcko> You can get the flags via "git grep -W BITCOIN_CONFIG ./ci/test/00_setup_env_native_tsan.sh"
07:45 < maflcko> Though, seems fine to move them to another file, as they are not required to build the CI image file.
07:50 < bitcoin-git> [bitcoin] fanquake opened pull request #30823: cmake: add `USE_SOURCE_PERMISSIONS` to all `configure_file()` usage (master...configure_file_explicit_perms) https://github.com/bitcoin/bitcoin/pull/30823
07:50 < maflcko> Personally I have a bash alias (since autotools) with similar ones for each compiler/sanitizer: "rm -rf ./bld-cmake/ && cmake -B ./bld-cmake -DAPPEND_CXXFLAGS='-std=c++23' -DCMAKE_C_COMPILER='clang' -DCMAKE_CXX_COMPILER='clang++' -DBUILD_GUI=ON -DBUILD_FUZZ_BINARY=ON -DBUILD_BENCH=ON -DWITH_ZMQ=ON -DWITH_ZMQ=ON -DBUILD_UTIL_CHAINSTATE=ON -DBUILD_KERNEL_LIB=ON && cmake --build ./bld-cmake --parallel $( nproc ) --"
07:51 < maflcko> Personally, even typing "cmake --build ..." is too much for me, so I'll use a bash alias either way
07:52 < luke-jr> I'm building in throwaway containers these days
07:52 < sipa> maflcko: my build/configure command lines are in bash history
07:52 < luke-jr> (by typing `make` :)
07:53 < sipa> maflcko: woah c++23, such modern
07:53 < maflcko> sipa: My bash history has the default limit, so I'd cycle through it in a few days 
07:53 < sipa> maflcko: humblebrag
07:54 < luke-jr> I wish bash could just use a sqlite db instead of caching history in RAM
07:55 < maflcko> "history | grep --count git" -> 536
07:55 < maflcko> I guess I am using git sometimes
07:55 < maflcko> 536/1000
07:56 < luke-jr> 30528 for me, in my main worktree dir
07:56 < vasild> maflcko: you have -DWITH_ZMQ=ON two times
07:57 < maflcko> vasild: Heh, fixed.
07:59 < sipa> vasild: two times zero(MQ) is still zero
07:59 < luke-jr> (MQ)
07:59 < vasild> ;-D
08:00 < luke-jr> we need to add -D___=TOGGLE just for maflcko? :P jk
08:36 < bitcoin-git> [bitcoin] fanquake opened pull request #30824: cmake: decouple `FORTIFY_SOURCE` check from `Debug` build type (master...decouple_fortify_debug_mode) https://github.com/bitcoin/bitcoin/pull/30824
08:43 -!- zeropoint [~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
08:46 -!- dzxzg [~dzxzg@mobile-107-77-230-4.mobile.att.net] has quit [Quit: Client closed]
08:46 -!- bugs_ [~bugs@user/bugs/x-5128603] has joined #bitcoin-core-dev
08:51 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
08:51 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 265 seconds]
08:54 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has joined #bitcoin-core-dev
09:02 -!- achow101 [~achow101@user/achow101] has quit [Ping timeout: 260 seconds]
09:02 -!- achow101_ [~achow101@user/achow101] has joined #bitcoin-core-dev
09:03 -!- preimage [~halosghos@user/halosghost] has joined #bitcoin-core-dev
09:05 -!- zeropoint [~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net] has quit [Quit: leaving]
09:11 -!- achow101_ [~achow101@user/achow101] has quit [Ping timeout: 260 seconds]
09:11 -!- achow101 [~achow101@user/achow101] has joined #bitcoin-core-dev
09:13 -!- kashifs [~kashifs@2603:7000:4600:500:4826:7d45:d6db:1cf7] has quit [Quit: Client closed]
09:18 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Quit: bye]
09:19 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
09:21 -!- zeropoint [~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
09:34 -!- ___nick___ [~quassel@82-132-215-101.dab.02.net] has joined #bitcoin-core-dev
09:51 < jonatack> maflcko: nice bash alias! what would the flag be, por favor, to silence the leveldb warnings
09:53 < jonatack> leveldb deprecation warnings from [-Wdeprecated-declarations]
09:54 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
09:55 < jonatack> luke-jr: agree it makes sense for the GUI to be included by default for the users that build from source
10:01 < sipa> jonatack: my understanding is that it's unusual in cmake-land to base features on auto-detection
10:06 < maflcko> jonatack: To disable the warning, you can just drop the C++23 option
10:25 -!- benwestgate [~BenWestga@2603:8080:7401:18ac:41f2:fb7c:563:8486] has joined #bitcoin-core-dev
10:55 < jonatack> sipa: maflcko: ty!
10:57 -!- SpellChecker_ [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
10:57 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection]
11:03 -!- jonatack [~jonatack@user/jonatack] has quit [Remote host closed the connection]
11:04 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
11:09 -!- ___nick___ [~quassel@82-132-215-101.dab.02.net] has quit [Ping timeout: 252 seconds]
11:09 -!- ___nick___ [~quassel@82-132-215-101.dab.02.net] has joined #bitcoin-core-dev
11:21 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 246 seconds]
11:22 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
11:26 -!- jleost [~jleost@152.248.97.244] has quit [Remote host closed the connection]
11:29 -!- jleost [~jleost@152.248.97.244] has joined #bitcoin-core-dev
11:44 -!- dviola [~diego@user/dviola] has joined #bitcoin-core-dev
11:56 -!- SpellChecker_ [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection]
11:57 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
11:59 -!- Talkless [~Talkless@mail.dargis.net] has quit [Remote host closed the connection]
12:36 -!- ___nick___ [~quassel@82-132-215-101.dab.02.net] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
12:38 -!- ___nick___ [~quassel@82-132-215-101.dab.02.net] has joined #bitcoin-core-dev
12:38 -!- ___nick___ [~quassel@82-132-215-101.dab.02.net] has quit [Client Quit]
12:39 < pinheadmz> weird error from walletprocesspsbt using signet miner:  Specified sighash value does not match value stored in PSBT
12:39 < pinheadmz> im doing weird stuff here inside warnet, just need a hint why this would happen
12:40 < bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d661e2b1b771...7f472e9bcd27
12:40 < bitcoin-git> bitcoin/master cd062d6 fanquake: build: work around issue with Boost = 18
12:40 < bitcoin-git> bitcoin/master 7f472e9 Ava Chow: Merge bitcoin/bitcoin#30821: build: work around issue with Boost <= 1.80 a...
12:40 < bitcoin-git> [bitcoin] achow101 merged pull request #30821: build: work around issue with Boost = 1.80 and Clang = 18 (master...boost_174_clang_18) https://github.com/bitcoin/bitcoin/pull/30821
12:41 -!- ___nick___ [~quassel@82-132-215-101.dab.02.net] has joined #bitcoin-core-dev
12:42 < pinheadmz> fixed nm. carry on
13:04 -!- ___nick___ [~quassel@82-132-215-101.dab.02.net] has quit [Ping timeout: 246 seconds]
13:59 < bitcoin-git> [bitcoin] brunoerg opened pull request #30826: fuzz: reduce number of iterations in `crypto_aeadchacha20poly1305` target (master...2024-09-fuzz-crypto-iterations) https://github.com/bitcoin/bitcoin/pull/30826
15:08 -!- bugs_ [~bugs@user/bugs/x-5128603] has quit [Quit: Leaving]
15:12 -!- nickler [~nickler@static.219.205.69.159.clients.your-server.de] has quit [Ping timeout: 245 seconds]
15:13 -!- nickler [~nickler@static.219.205.69.159.clients.your-server.de] has joined #bitcoin-core-dev
15:16 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
15:18 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 260 seconds]
15:27 -!- SpellChecker_ [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
15:27 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection]
15:29 < bitcoin-git> [bitcoin] achow101 pushed 5 commits to 28.x: https://github.com/bitcoin/bitcoin/compare/88f0419c1ab1...fa460884406b
15:29 < bitcoin-git> bitcoin/28.x 5577d5a Sebastian Falbesoner: test: fix `TestShell` initialization (late follow-up for #30463)
15:29 < bitcoin-git> bitcoin/28.x 342baab MarcoFalke: test: Avoid intermittent timeout in p2p_headers_sync_with_minchainwork.py
15:29 < bitcoin-git> bitcoin/28.x 199bb09 Jadi: test: fixing failing system_tests/run_command under some Locales
15:29 < bitcoin-git> [bitcoin] achow101 merged pull request #30762: [28.x] rc backports (28.x...28_x_backports) https://github.com/bitcoin/bitcoin/pull/30762
15:30 < bitcoin-git> [bitcoin] achow101 opened pull request #30827: [28.x] Further backports and rc2 (28.x...rc2-backports) https://github.com/bitcoin/bitcoin/pull/30827
15:40 < bitcoin-git> [bitcoin] ismaelsadeeq opened pull request #30828: interfaces: #30697 follow ups (master...09-30697-follow-ups) https://github.com/bitcoin/bitcoin/pull/30828
15:55 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Remote host closed the connection]
16:45 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 252 seconds]
16:57 -!- TheRec [~toto@user/therec] has quit []
17:00 -!- reardencode [~reardenco@shrugged.reardencode.com] has quit [Ping timeout: 252 seconds]
17:01 -!- reardencode [~reardenco@shrugged.reardencode.com] has joined #bitcoin-core-dev
17:05 -!- Guest27 [~Guest27@2804:14d:4cbd:86d2:a134:a8e5:6a3e:e5cc] has joined #bitcoin-core-dev
17:06 -!- dzxzg [~dzxzg@209.160.254.18] has joined #bitcoin-core-dev
17:11 -!- dzxzg [~dzxzg@user/dzxzg] has changed host
17:20 -!- Guest27 [~Guest27@2804:14d:4cbd:86d2:a134:a8e5:6a3e:e5cc] has quit [Quit: Client closed]
17:23 -!- dzxzg [~dzxzg@user/dzxzg] has quit [Quit: Client closed]
17:24 -!- dzxzg [~dzxzg@user/dzxzg] has joined #bitcoin-core-dev
17:33 -!- dzxzg [~dzxzg@user/dzxzg] has quit [Quit: Client closed]
17:45 -!- dzxzg [~dzxzg@user/dzxzg] has joined #bitcoin-core-dev
17:45 -!- reardencode [~reardenco@shrugged.reardencode.com] has quit [Ping timeout: 252 seconds]
17:51 -!- reardencode [~reardenco@console.reardencode.com] has joined #bitcoin-core-dev
17:53 -!- zeropoint [~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net] has quit [Quit: leaving]
18:02 -!- TheRec [~toto@user/therec] has joined #bitcoin-core-dev
18:12 -!- dzxzg [~dzxzg@user/dzxzg] has quit [Ping timeout: 256 seconds]
18:22 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
18:27 -!- lbia [~lbia@user/lbia] has quit [Ping timeout: 248 seconds]
18:28 -!- TheRec [~toto@user/therec] has quit []
18:29 -!- lbia [~lbia@user/lbia] has joined #bitcoin-core-dev
18:30 -!- benwestgate [~BenWestga@2603:8080:7401:18ac:41f2:fb7c:563:8486] has quit [Ping timeout: 276 seconds]
18:42 -!- kevkevin [~kevkevin@2601:243:197e:8f10:64e8:32ea:7932:4bd9] has joined #bitcoin-core-dev
18:47 -!- kevkevin [~kevkevin@2601:243:197e:8f10:64e8:32ea:7932:4bd9] has quit [Ping timeout: 260 seconds]
18:54 < luke-jr> sipa: who was suggesting autodetection?
18:54 < luke-jr> I mean, if Qt is missing, fail unless it's explicitly disabled
19:00 -!- Guest77 [~Guest77@2a01:e11:5400:2c20:66a7:24cc:2ccc:5e0f] has joined #bitcoin-core-dev
19:01 -!- Guest77 [~Guest77@2a01:e11:5400:2c20:66a7:24cc:2ccc:5e0f] has quit [Client Quit]
19:01 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has quit [Quit: Connection closed for inactivity]
19:04 < bitcoin-git> [bitcoin] Tdhun opened pull request #30829: Create Satoshi Nakamoto (master...patch-1) https://github.com/bitcoin/bitcoin/pull/30829
19:08 < bitcoin-git> [bitcoin] Tdhun opened pull request #30830: Create c-cpp.yml (master...master) https://github.com/bitcoin/bitcoin/pull/30830
19:16 -!- benwestgate [~BenWestga@syn-076-184-062-115.res.spectrum.com] has joined #bitcoin-core-dev
19:16 -!- SpellChecker_ [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection]
19:23 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
19:41 < bitcoin-git> [bitcoin] achow101 closed pull request #30830: Create c-cpp.yml (master...master) https://github.com/bitcoin/bitcoin/pull/30830
19:41 < bitcoin-git> [bitcoin] achow101 closed pull request #30829: . (master...patch-1) https://github.com/bitcoin/bitcoin/pull/30829
19:45 -!- arik__ [sid402902@lymington.irccloud.com] has quit [Ping timeout: 252 seconds]
19:45 -!- runnerelektrode_ [sid517941@helmsley.irccloud.com] has quit [Ping timeout: 248 seconds]
19:46 -!- hugohn____ [sid304114@lymington.irccloud.com] has quit [Read error: Connection reset by peer]
19:46 -!- runnerelektrode_ [sid517941@id-517941.helmsley.irccloud.com] has joined #bitcoin-core-dev
19:46 -!- hugohn____ [sid304114@id-304114.lymington.irccloud.com] has joined #bitcoin-core-dev
19:46 -!- arik__ [sid402902@id-402902.lymington.irccloud.com] has joined #bitcoin-core-dev
19:50 -!- TheRec [~toto@user/therec] has joined #bitcoin-core-dev
19:54 -!- kevkevin [~kevkevin@2601:243:197e:8f10:64e8:32ea:7932:4bd9] has joined #bitcoin-core-dev
19:56 -!- bztrn [~bztrn@176.33.180.207] has joined #bitcoin-core-dev
20:03 < bitcoin-git> [bitcoin] Wbaker7702 opened pull request #30831: GUI Related (master...master) https://github.com/bitcoin/bitcoin/pull/30831
20:05 < bitcoin-git> [bitcoin] achow101 closed pull request #30831: GUI Related (master...master) https://github.com/bitcoin/bitcoin/pull/30831
20:05 < bitcoin-git> [bitcoin] Wbaker7702 opened pull request #30832: Wbaker7702/patch 753 (master...Wbaker7702/patch-753) https://github.com/bitcoin/bitcoin/pull/30832
20:07 < bitcoin-git> [bitcoin] achow101 closed pull request #30832: Wbaker7702/patch 753 (master...Wbaker7702/patch-753) https://github.com/bitcoin/bitcoin/pull/30832
20:25 -!- bztrn [~bztrn@user/bztrn] has changed host
20:31 -!- qxs [~qxs@gateway/tor-sasl/qxs] has quit [Remote host closed the connection]
20:32 -!- qxs [~qxs@gateway/tor-sasl/qxs] has joined #bitcoin-core-dev
20:33 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 246 seconds]
20:36 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
20:47 -!- jon_atack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
20:47 -!- jonatack [~jonatack@user/jonatack] has quit [Read error: Connection reset by peer]
20:51 -!- benwestgate [~BenWestga@syn-076-184-062-115.res.spectrum.com] has quit [Quit: Leaving.]
20:56 -!- kevkevin [~kevkevin@2601:243:197e:8f10:64e8:32ea:7932:4bd9] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:04 -!- kevkevin [~kevkevin@2601:243:197e:8f10:a57d:e69:d158:3eb8] has joined #bitcoin-core-dev
21:08 -!- kevkevin [~kevkevin@2601:243:197e:8f10:a57d:e69:d158:3eb8] has quit [Ping timeout: 248 seconds]
21:12 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Quit: bye]
21:12 -!- bztrn [~bztrn@user/bztrn] has quit [Ping timeout: 256 seconds]
21:14 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 252 seconds]
21:22 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
21:42 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 260 seconds]
21:43 -!- preimage [~halosghos@user/halosghost] has quit [Quit: WeeChat 4.4.1]
21:44 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
21:53 -!- benwestgate [~BenWestga@syn-076-184-062-115.res.spectrum.com] has joined #bitcoin-core-dev
22:01 -!- emcy__ [~emcy@85.255.235.25] has joined #bitcoin-core-dev
22:01 -!- mcey_ [~emcy@85.255.235.25] has quit [Remote host closed the connection]
22:09 -!- mcey_ [~emcy@85.255.237.52] has joined #bitcoin-core-dev
22:12 -!- emcy__ [~emcy@85.255.235.25] has quit [Ping timeout: 246 seconds]
22:15 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
22:59 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
22:59 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
--- Log closed Fri Sep 06 00:00:44 2024