--- Log opened Thu Sep 12 00:00:49 2024
00:14 -!- virtu [~virtu@user/virtu] has quit [Remote host closed the connection]
00:14 -!- virtu [~virtu@vmd108895.contaboserver.net] has joined #bitcoin-core-dev
00:30 -!- jarthur [~jarthur@user/jarthur] has quit [Quit: jarthur]
00:30 -!- noonien808310429 [~noonien@86.125.147.232] has quit [Ping timeout: 255 seconds]
00:43 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:8070:82cf:93bb:afb3] has quit [Read error: Connection reset by peer]
00:44 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:e48d:675b:4f3e:2a9a] has joined #bitcoin-core-dev
01:08 -!- vyHamii [~vyHamii@113.190.232.10] has joined #bitcoin-core-dev
01:17 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has joined #bitcoin-core-dev
01:19 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
01:28 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/349632e022da...c77361888695
01:28 < bitcoin-git> bitcoin/master 0037d53 Hennadii Stepanov: build: Fix `ENABLE_WALLET` option
01:28 < bitcoin-git> bitcoin/master c773618 merge-script: Merge bitcoin/bitcoin#30867: build: Fix `ENABLE_WALLET` option
01:28 < bitcoin-git> [bitcoin] fanquake merged pull request #30867: build: Fix `ENABLE_WALLET` option (master...240910-wallet-option) https://github.com/bitcoin/bitcoin/pull/30867
01:37 -!- BrandonOdiwuor [~BrandonOd@41.90.37.95] has joined #bitcoin-core-dev
01:37 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c77361888695...155963768af6
01:37 < bitcoin-git> bitcoin/master b07fe66 Hennadii Stepanov: build: Minimize I/O operations in `GenerateHeaderFrom{Json,Raw}.cmake`
01:37 < bitcoin-git> bitcoin/master 1559637 merge-script: Merge bitcoin/bitcoin#30842: build: Minimize I/O operations in `GenerateHe...
01:37 < bitcoin-git> [bitcoin] fanquake merged pull request #30842: build: Minimize I/O operations in `GenerateHeaderFrom{Json,Raw}.cmake` (master...240907-scripts) https://github.com/bitcoin/bitcoin/pull/30842
01:44 -!- BrandonOdiwuor [~BrandonOd@41.90.37.95] has quit [Quit: Client closed]
01:54 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/155963768af6...f0eb63399a8f
01:54 < bitcoin-git> bitcoin/master 6e5f33a Hennadii Stepanov: ci: Handle log files regardless of CMake's version
01:54 < bitcoin-git> bitcoin/master c45186c Hennadii Stepanov: ci: Switch from `make` to `cmake --build`
01:54 < bitcoin-git> bitcoin/master f0eb633 merge-script: Merge bitcoin/bitcoin#30841: ci: Post CMake-migration fixes and amendments
01:54 < bitcoin-git> [bitcoin] fanquake merged pull request #30841: ci: Post CMake-migration fixes and amendments (master...240907-ci-cmake) https://github.com/bitcoin/bitcoin/pull/30841
02:17 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f0eb63399a8f...a86e7a476d50
02:17 < bitcoin-git> bitcoin/master 5ba03e7 Hennadii Stepanov: build: Use CMake's default permissions in macOS `deploy` target
02:17 < bitcoin-git> bitcoin/master a86e7a4 merge-script: Merge bitcoin/bitcoin#30838: build: Use CMake's default permissions in mac...
02:17 < bitcoin-git> [bitcoin] fanquake merged pull request #30838: build: Use CMake's default permissions in macOS `deploy` target (master...240906-permissions) https://github.com/bitcoin/bitcoin/pull/30838
02:20 -!- maxfangx [~maxfangx@142.147.89.217] has quit [Ping timeout: 245 seconds]
02:21 -!- maxfangx [~maxfangx@142.147.89.217] has joined #bitcoin-core-dev
02:30 < bitcoin-git> [bitcoin] fanquake pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/a86e7a476d50...db8350b0e3f5
02:30 < bitcoin-git> bitcoin/master 6f2cb0e Hennadii Stepanov: doc: Amend comment about ZeroMQ config files
02:30 < bitcoin-git> bitcoin/master f03c942 Hennadii Stepanov: build, test: Add missed log options
02:30 < bitcoin-git> bitcoin/master 73b6185 Hennadii Stepanov: build: Print `CMAKE_CXX_COMPILER_ARG1` in summary
02:30 < bitcoin-git> [bitcoin] fanquake merged pull request #30803: build: Minor build system fixes and amendments (master...240903-cmake-amend) https://github.com/bitcoin/bitcoin/pull/30803
02:30 -!- mcey_ [~emcy@148.252.129.55] has joined #bitcoin-core-dev
02:34 -!- mcey [~emcy@148.252.147.147] has quit [Ping timeout: 276 seconds]
02:48 -!- jirijakes [~jirijakes@118.150.148.23] has joined #bitcoin-core-dev
02:58 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/db8350b0e3f5...11e2f9fff48f
02:58 < bitcoin-git> bitcoin/master 7b04fab Hennadii Stepanov: build: Introduce "Kernel" installation component
02:58 < bitcoin-git> bitcoin/master 11e2f9f merge-script: Merge bitcoin/bitcoin#30835: build: Introduce "Kernel" installation compon...
02:59 < bitcoin-git> [bitcoin] fanquake merged pull request #30835: build: Introduce "Kernel" installation component (master...240906-kernel) https://github.com/bitcoin/bitcoin/pull/30835
03:28 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/11e2f9fff48f...85833cf05fb6
03:28 < bitcoin-git> bitcoin/master 5c80192 Hennadii Stepanov: test: Drop no longer needed workarounds
03:28 < bitcoin-git> bitcoin/master 85833cf merge-script: Merge bitcoin/bitcoin#30847: test: Drop no longer needed workarounds
03:28 < bitcoin-git> [bitcoin] fanquake merged pull request #30847: test: Drop no longer needed workarounds (master...240908-tests) https://github.com/bitcoin/bitcoin/pull/30847
03:32 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/85833cf05fb6...fcb61bbc8dd7
03:32 < bitcoin-git> bitcoin/master be4f782 fanquake: contrib: test for FORTIFY_SOURCE in security-check.py
03:32 < bitcoin-git> bitcoin/master fcb61bb merge-script: Merge bitcoin/bitcoin#27038: security-check: test for `_FORTIFY_SOURCE` us...
03:32 < bitcoin-git> [bitcoin] fanquake merged pull request #27038: security-check: test for `_FORTIFY_SOURCE` usage in release binaries (master...sec_check_fortify_source) https://github.com/bitcoin/bitcoin/pull/27038
03:33 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fcb61bbc8dd7...0c1e5072781f
03:33 < bitcoin-git> bitcoin/master f15e817 Pieter Wuille: build: add more CMake presets (dev-mode, libfuzzer, libfuzzer-nosan)
03:33 < bitcoin-git> bitcoin/master 0c1e507 merge-script: Merge bitcoin/bitcoin#30871: build: Add more cmake presets
03:33 < bitcoin-git> [bitcoin] fanquake merged pull request #30871: build: Add more cmake presets (master...202409_cmake_presets) https://github.com/bitcoin/bitcoin/pull/30871
04:17 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0c1e5072781f...a5e99669ccfe
04:17 < bitcoin-git> bitcoin/master 2ad5601 Lőrinc: Remove unused src_dir param from run_tests
04:17 < bitcoin-git> bitcoin/master a5e9966 merge-script: Merge bitcoin/bitcoin#30733: test: remove unused src_dir param from run_te...
04:17 < bitcoin-git> [bitcoin] fanquake merged pull request #30733: test: remove unused src_dir param from run_tests after CMake migration (master...l0rinc/test-runner-param-cleanup) https://github.com/bitcoin/bitcoin/pull/30733
04:25 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 252 seconds]
04:31 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
05:00 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
05:22 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 265 seconds]
05:24 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
05:26 -!- jirijakes [~jirijakes@118.150.148.23] has quit [Ping timeout: 260 seconds]
05:40 -!- BrandonOdiwuor [~BrandonOd@41.90.37.95] has joined #bitcoin-core-dev
05:50 -!- gribble [~gribble@bitcoin/bot/gribble] has quit [Remote host closed the connection]
05:53 -!- gribble [~gribble@bitcoin/bot/gribble] has joined #bitcoin-core-dev
05:53 -!- mode/#bitcoin-core-dev [+o gribble] by ChanServ
05:57 < bitcoin-git> [bitcoin] theStack opened pull request #30877: code style: update .editorconfig file (master...202409-update_editorconfig) https://github.com/bitcoin/bitcoin/pull/30877
06:06 -!- BrandonOdiwuor [~BrandonOd@41.90.37.95] has quit [Ping timeout: 256 seconds]
06:20 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
06:49 -!- preimage [~halosghos@user/halosghost] has joined #bitcoin-core-dev
06:50 -!- pablomartin [~pablomart@193.160.246.74] has joined #bitcoin-core-dev
06:55 -!- Emc99 [~Emc99@212.129.87.102] has joined #bitcoin-core-dev
07:00 -!- Emc99 [~Emc99@212.129.87.102] has quit [Client Quit]
07:00 -!- dzxzg [~dzxzg@user/dzxzg] has joined #bitcoin-core-dev
07:00 < achow101> #startmeeting
07:00 < Sjors[m]11> Hi
07:00 < achow101> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard aureleoules b10c BlueMatt brunoerg cfields darosior dergoegge dongcarl fanquake fjahr furszy gleb glozow hebasto instagibbs jamesob jarolrod jonatack josibake kallewoof kanzure kouloumos kvaciral laanwj LarryRuane lightlike luke-jr MacroFake Murch phantomcircuit pinheadmz promag provoostenator ryanofsky sdaftuar S3RK stickies-v sipa sr_gi theStack TheCharlatan vasild
07:00 < Murch[m]> hi
07:00 < brunoerg> hi
07:00 < vasild> hi
07:00 < gleb> hi
07:00 < dzxzg> hi
07:00 < josie> hi
07:00 < achow101> There are no pre-proposed meeting topics this week. Any last minute ones to add?
07:00 < TheCharlatan> hi
07:00 < hebasto> hi
07:01 < laanwj> hi
07:01 < pinheadmz> hi
07:01 < lightlike> Hi
07:01 < achow101> #topic Ad-hoc high priority for review
07:01 < achow101> Anything to add or remove from https://github.com/orgs/bitcoin/projects/1/views/4
07:02 < glozow> hi
07:02 < sipa> hi
07:02 -!- Emc99 [~Emc99@212.129.87.102] has joined #bitcoin-core-dev
07:02 < Sjors[m]11> #29868 is draft now
07:02 <@gribble> https://github.com/bitcoin/bitcoin/issues/29868 | Reintroduce external signer support for Windows by hebasto · Pull Request #29868 · bitcoin/bitcoin · GitHub
07:02 < kanzure> hi
07:02 < bitcoin-git> [bitcoin] willcl-ark opened pull request #30879: test: re-bucket p2p_node_network_limited (master...ci-p2p_node_network_limited) https://github.com/bitcoin/bitcoin/pull/30879
07:02 < achow101> a bunch of those need rebasing too
07:03 < Sjors[m]11> And as muchas I like #30043 it needs laanwj 
07:03 <@gribble> https://github.com/bitcoin/bitcoin/issues/30043 | net: Replace libnatpmp with built-in PCP+NATPMP implementation by laanwj · Pull Request #30043 · bitcoin/bitcoin · GitHub
07:03 < laanwj> i'm here
07:03 < Sjors[m]11> 🎉
07:03 < achow101> removing #30043 #29868 and #30116 for now
07:03 <@gribble> https://github.com/bitcoin/bitcoin/issues/30043 | net: Replace libnatpmp with built-in PCP+NATPMP implementation by laanwj · Pull Request #30043 · bitcoin/bitcoin · GitHub
07:03 < hebasto> yes, 29868 can be removed
07:04 <@gribble> https://github.com/bitcoin/bitcoin/issues/29868 | Reintroduce external signer support for Windows by hebasto · Pull Request #29868 · bitcoin/bitcoin · GitHub
07:04 <@gribble> https://github.com/bitcoin/bitcoin/issues/30116 | p2p: Fill reconciliation sets (Erlay) attempt 2 by sr-gi · Pull Request #30116 · bitcoin/bitcoin · GitHub
07:04 < laanwj> but yes it needs rebase,  will get to it one of these dayd
07:04 < laanwj> sorry for the delay
07:04 < Sjors[m]11> Maybe add #30409
07:04 <@gribble> https://github.com/bitcoin/bitcoin/issues/30409 | Introduce waitTipChanged() mining interface, replace RPCNotifyBlockChange, drop CRPCSignals & g_best_block by Sjors · Pull Request #30409 · bitcoin/bitcoin · GitHub
07:05 < Sjors[m]11> Already has two ACKs but could use more eyes.
07:05 < achow101> Sjors[m]11: done
07:06 < achow101> #topic 28.0 release priorities
07:06 < achow101> Milestone is https://github.com/bitcoin/bitcoin/milestone/66
07:06 < achow101> Current backports pr #30827
07:06 <@gribble> https://github.com/bitcoin/bitcoin/issues/30827 | [28.x] Further backports and rc2 by achow101 · Pull Request #30827 · bitcoin/bitcoin · GitHub
07:07 < achow101> The remaining active issue is this ibd regression on Windows
07:07 < achow101> any thoughts on fixing that?
07:08 < jonatack> hi
07:08 < Sjors[m]11> xor causing a slowdown?
07:08 < dzxzg> I thought maybe it could be the size of the array that is being allocated, have not tested yet though: https://github.com/davidgumberg/bitcoin/commit/64b7313437b0cadce69678efdaacb5c03c912786
07:08 < achow101> it looks like the ibd regression is probably caused by blocksdir xor, so perhaps we should revert that?
07:08 < sipa> i don't think we have a good theory what could even cause it
07:09 < abubakarsadiq> hi
07:09 < laanwj> looking at the issue, https://github.com/bitcoin/bitcoin/issues/30833 , some people report not seeing any difference
07:09 < lightlike> maybe revert it just for windows?
07:09 < lightlike> (or disable)
07:09 < achow101> i didn't observe a difference, so it might be hardware dependent too
07:10 < laanwj> it's extremely unlikely to be an xor operation causing such a slowdown
07:10 < sipa> unfortunately, windows is probably the only platform where people might want the xoring... (due to the prevalance of virus scanners there)
07:10 < Sjors[m]11> Turning it off for Windows until it's clear what's happening seems like a safe option.
07:10 < Sjors[m]11> But also it indeed tends to flag stuff
07:10 < pablomartin> sure is it only Win? https://github.com/bitcoin/bitcoin/issues/30878#issuecomment-2346309699
07:10 < achow101> pablomartin: that's a different problem
07:10 < sipa> davidgumberg has a patch that fixes the slowdown if xoring is disabled at runtime
07:11 < pablomartin> ok
07:11 < sipa> we could combine that with defaulting it to off on windows
07:11 < laanwj> might add a flag to turn it off so that the person reporting the issue can benchmark with it on and off?
07:12 < achow101> sipa: that seems reasonable
07:12 < laanwj> until it's confirmed that it's really that which is the problem, turning it permanently off for any platform makes no sense
07:13 < achow101> laanwj: it looks like they bisected to the commit adding it
07:13 < laanwj> oh, didn't see that
07:13 < achow101> https://github.com/bitcoin/bitcoin/issues/30833#issuecomment-2335184072
07:13 < dzxzg> There is a cli flag `-blocksxor=0` for disabling but it doesn't currently stop bitcoin core from avoiding the xor path, I've a commit here: https://github.com/davidgumberg/bitcoin/commit/aa0be4031cbe5bed407bc7a1753875cc1c4ddccb
07:13 < dzxzg> And I've reproduced that on 28.x with xoring disabled the regression is gone
07:13 < laanwj> curious, why would xoring (which id assume, is one assembler instruction) cause such a slowdown
07:13 < achow101> dzxzg: can you open a pr?
07:13 < sipa> laanwj: there are different code paths in AutoFile that get used when xoring is used vs not used
07:13 < dzxzg> I suspect it's probably not the x'oring, it's something to do with the array and copying
07:13 < laanwj> it should be neglible compared to any i/o
07:14 < dzxzg> achow101: sure
07:14 < laanwj> sipa: okay, thanks
07:14 < sipa> given the situation, i think that dzxzg commit doesn't hurt
07:14 < sipa> then we can disable on enable on windows easily, and revert if fixed
07:15 < achow101> Has anyone noticed any other issues with 28.0rc1?
07:15 < achow101> There's a testing guide now: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/28.0-Release-Candidate-Testing-Guide
07:16 < achow101> or any other topics to discuss today?
07:18 < achow101> #endmeeting
07:18 < bitcoin-git> [bitcoin] fjahr opened pull request #30880: test: Wait for local services to update in feature_assumeutxo (master...2024-09-au-services-test) https://github.com/bitcoin/bitcoin/pull/30880
07:18 < laanwj> <dzxzg> "I suspect it's probably not..." <- allocation overhead can definitely explain an OS specific difference
07:19 -!- Emc99 [~Emc99@212.129.87.102] has quit [Quit: Client closed]
07:20 < laanwj> libc malloc tends to be lots faster than what mingw uses
07:22 < dzxzg> Yeah it doesn't make sense to me either that the allocation is the issue
07:22 < dzxzg> Could it be `ftell`? Either it's own overhead or preventing some optimization of writes
07:23 < sipa> The cost of an `ftell` could differ wildly between platforms.
07:23 < laanwj> yes, and file systems
07:23 < sipa> If there are are many more of those if XOR is enabled vs. not, that could explain things.
07:24 < achow101> each call to AutoFile::write() has a ftell if xoring
07:24 < achow101> while nothing if not
07:25 < dzxzg> Yep: https://github.com/bitcoin/bitcoin/blob/a5e99669ccfe0683749ce2e2b21732a359ef62d7/src/streams.cpp#L74
07:25 < achow101> if someone can figure out how to profile on windows, that'd be great
07:25 < laanwj> it could cache the current position, right?
07:26 < sipa> yeah, i was just going to suggest that
07:27 < sipa> it's possible that fwrite is cached by the libc layer, while ftell always triggers a kernel call?
07:27 < laanwj> std::fwrite is cached, yes
07:28 < laanwj> and it's likely ftell is not optimized in any way because software uses it only rarely (usually to seek once to the end to determine file size)
07:28 < maflcko> Yeah, ftell being the issue seems the most plausible explanation 
07:29 < laanwj> yeah the one-time 4096 byte allocation per write call likely isn't going to be the overhead 
07:29 < vasild> sipa: I think no, I do not think it can happen that ftell reports incorrect because it misses a recent fwrite which is cached and ftell asks the kernel directly
07:29 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a5e99669ccfe...cf786eccd7ab
07:29 < bitcoin-git> bitcoin/master 23eedc5 Hennadii Stepanov: build: Skip secp256k1 ctime tests when tests are not being built
07:29 < bitcoin-git> bitcoin/master cf786ec merge-script: Merge bitcoin/bitcoin#30865: build: Skip secp256k1 ctime tests when tests ...
07:29 < bitcoin-git> [bitcoin] fanquake merged pull request #30865: build: Skip secp256k1 ctime tests when tests are not being built (master...240910-ctime-test) https://github.com/bitcoin/bitcoin/pull/30865
07:30 < maflcko> Writing code to cache it would be trivial, but then one could no longer use fseek outside the class
07:30 < laanwj> vasild: maybe it flushes first
07:30 < laanwj> this would make sense
07:30 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cf786eccd7ab...7d43bca05220
07:30 < bitcoin-git> bitcoin/master 72b46f2 Max Edwards: test: fix exclude parsing for functional runner
07:30 < bitcoin-git> bitcoin/master 7d43bca merge-script: Merge bitcoin/bitcoin#30872: test: fix exclude parsing for functional runn...
07:30 < bitcoin-git> [bitcoin] fanquake merged pull request #30872: test: fix exclude parsing for functional runner (master...110924-fix-runner-exclude) https://github.com/bitcoin/bitcoin/pull/30872
07:30 < vasild> ftell operates on the same layer as fwrite - the libc FILE* stuff
07:31 < laanwj> maflcko: fseeking outside the class sounds like a bad idea in the first place, not encapsulating it for nothing
07:31 < sipa> vasild: yes, it does, but it's still possible that libc forwards all ftell calls to the OS
07:31 < sipa> oh!@
07:32 < sipa> laanwj: ftell triggering a flush is a better explanation
07:32 < sipa> maflcko: working on a patch
07:32 < maflcko> sipa: Thanks!
07:35 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [Closing Window]
07:35 < dzxzg> sipa: I can test the patch on my windows box that exhibits the slowdown
07:36 -!- jarthur [~jarthur@user/jarthur] has joined #bitcoin-core-dev
07:40 -!- marcofleon [~marcofleo@82.163.218.33] has joined #bitcoin-core-dev
07:41 < vasild> When CConnman prepares sockets to poll(2), it skips the sockets of some nodes: https://github.com/bitcoin/bitcoin/blob/7d43bca05220ead797e65937dc6df57bdb89defe/src/net.cpp#L2005-L2021
07:43 < vasild> It would be simpler to poll(2) all sockets and then omit nodes based on these criteria (eg pnode->fPauseRecv).
07:44 < vasild> Anybody sees or remembers a special reason to do the filtering before poll(2)?
07:46 < sipa> vasild: i think i last touched that code
07:46 < vasild> and? :)
07:46 < sipa> i don't see a problem with always polling and doing the filtering later
07:47 < vasild> \o/
07:51 < laanwj> couldn't polling connections unnecessarily have a potential performance overhead? 
07:52 < laanwj> not sure it makes much of a difference, it's one system call either way, but i suspect that's the reason to only add conditionally
07:53 < sipa> laanwj: maybe, but i sort of assume that polling many file descriptors at once is pretty well optimized in the kernel, so the marginal cost for an extra one is low
07:53 < sipa> likely more so than our own code for determining what to poll
07:54 < sipa> 1090551 pts/1    S+     0:00                   /bin/sh -c cd /home/pw/git/bitcoin/build_dev_mode/src/bench && /usr/bin/cmake -DRAW_SOURCE_PATH=/home/pw/git/bi
07:54 < sipa> 1090553 pts/1    R+     2:20                     /usr/bin/cmake -DRAW_SOURCE_PATH=/home/pw/git/bitcoin/src/bench/data/block413567.raw -DHEADER_PATH=/home/pw/g
07:54 < sipa> anyone have a clue why building block413567.raw.h seems to take forever?
07:54 < laanwj> agree, it's not like we're dealing with ten thousands of extra fds here anyway
07:54 < fanquake> sipa: probably a regression from #30842
07:54 <@gribble> https://github.com/bitcoin/bitcoin/issues/30842 | build: Minimize I/O operations in `GenerateHeaderFrom{Json,Raw}.cmake` by hebasto · Pull Request #30842 · bitcoin/bitcoin · GitHub
07:55 < fanquake> a similar issue was also reported there
07:55 < sipa> fanquake: thanks
07:55 < fanquake> ill open an issue to track
07:56 < fanquake> given it was meant to be an optimsation for native windows, which seems to be causing perf issues on linux, should probably be reverted, unless we find a quick fix
07:57 < fanquake> #30881
07:57 <@gribble> https://github.com/bitcoin/bitcoin/issues/30881 | cmake: GenerateHeaderFrom very slow · Issue #30881 · bitcoin/bitcoin · GitHub
07:58 < sipa> reverting 30842 fixes the issue
08:00 -!- jarthur [~jarthur@user/jarthur] has quit [Ping timeout: 276 seconds]
08:03 -!- jarthur_ [~jarthur@user/jarthur] has joined #bitcoin-core-dev
08:13 -!- pablomartin [~pablomart@193.160.246.74] has quit [Ping timeout: 272 seconds]
08:16 < bitcoin-git> [bitcoin] dergoegge opened pull request #30882: wip: Split fuzz binary (take 2) (master...2024-09-split-fuzz) https://github.com/bitcoin/bitcoin/pull/30882
08:19 -!- bugs_ [~bugs@user/bugs/x-5128603] has joined #bitcoin-core-dev
08:20 < dzxzg> I tried setting up windows profiling in Visual Studio but could only get the CPU profiler to work, on my system at least Visual Studio just crashes when I try to use the more sophisticated "Instrumentation" profiler that measures call counts and wall clock time taken by calls with bitcoin core. (You have to add the /PROFILE linker flag to use the
08:20 < dzxzg> instrumentation profiler)
08:24 -!- zeropoint [~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
08:29 < maflcko> PSA, if you receive the "At least one of the CI tasks failed." DrahtBot notification, it is a true issue with the pull request, and not one of the (sadly currently common) unrelated ones.
08:32 < sipa> good DrahtBot
08:38 < bitcoin-git> [bitcoin] hebasto opened pull request #30883: Revert "build: Minimize I/O operations in `GenerateHeaderFrom{Json,Raw}.cmake`" (master...240912-slow-string) https://github.com/bitcoin/bitcoin/pull/30883
08:39 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/7d43bca05220...24817e8b1510
08:39 < bitcoin-git> bitcoin/master 45be32f TheCharlatan: build: Produce a usable static kernel library
08:39 < bitcoin-git> bitcoin/master 0dd16d7 TheCharlatan: build: Add a pkg-config file for libbitcoinkernel
08:39 < bitcoin-git> bitcoin/master 24817e8 merge-script: Merge bitcoin/bitcoin#30814: kernel: Create usable static kernel library
08:39 < bitcoin-git> [bitcoin] fanquake merged pull request #30814: kernel: Create usable static kernel library (master...staticKernel) https://github.com/bitcoin/bitcoin/pull/30814
08:53 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/24817e8b1510...07c7c96022dd
08:53 < bitcoin-git> bitcoin/master fdeb717 Hennadii Stepanov: Revert "build: Minimize I/O operations in `GenerateHeaderFrom{Json,Raw}.cm...
08:53 < bitcoin-git> bitcoin/master 07c7c96 merge-script: Merge bitcoin/bitcoin#30883: build: Revert "Minimize I/O operations in `Ge...
08:53 < bitcoin-git> [bitcoin] fanquake merged pull request #30883: build: Revert "Minimize I/O operations in `GenerateHeaderFrom{Json,Raw}.cmake`" (master...240912-slow-string) https://github.com/bitcoin/bitcoin/pull/30883
08:54 -!- _flooded [flooded@gateway/vpn/protonvpn/flood/x-43489060] has joined #bitcoin-core-dev
08:55 -!- jonasschnelli_ [~jonasschn@2a01:4f9:3081:504d::2] has joined #bitcoin-core-dev
08:56 -!- he1 [hel@libera/staff/el] has joined #bitcoin-core-dev
08:57 < bitcoin-git> [bitcoin] sipa opened pull request #30884: streams: cache file position within AutoFile (master...202409_reduce_ftell_xor) https://github.com/bitcoin/bitcoin/pull/30884
08:57 < sipa> dzxzg: ^
08:58 -!- gmaxwell_ [~gmaxwell@user/gmaxwell] has joined #bitcoin-core-dev
08:58 -!- nickler_ [~nickler@static.219.205.69.159.clients.your-server.de] has joined #bitcoin-core-dev
08:58 -!- zeropoin1 [~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
08:58 -!- andytosh1 [~apoelstra@user/andytoshi] has joined #bitcoin-core-dev
09:00 -!- dzxzg [~dzxzg@user/dzxzg] has quit [Quit: Client closed]
09:01 -!- dzxzg [~dzxzg@user/dzxzg] has joined #bitcoin-core-dev
09:02 < dzxzg> sipa: thanks, testing now
09:02 < sipa> great
09:03 -!- Netsplit *.net <-> *.split quits: jetpack, zeropoint, _flood, hel, hugohn____, preimage, nickler, achow101, jonasschnelli, jarthur_,  (+5 more, use /NETSPLIT to show all of them)
09:03 -!- he1 is now known as hel
09:10 -!- Netsplit over, joins: nanotube
09:28 -!- dzxzg [~dzxzg@user/dzxzg] has quit [Quit: Client closed]
09:28 -!- dzxzg [~dzxzg@user/dzxzg] has joined #bitcoin-core-dev
09:31 < bitcoin-git> [bitcoin] davidgumberg closed pull request #29965: Lint: improve subtree exclusion (master...rustlinv2) https://github.com/bitcoin/bitcoin/pull/29965
09:36 < bitcoin-git> [bitcoin] ryanofsky pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/07c7c96022dd...be768dbd185b
09:36 < bitcoin-git> bitcoin/master 743ac30 Lőrinc: Add std::optional support to Boost's equality check
09:36 < bitcoin-git> bitcoin/master 1994786 Lőrinc: Use BOOST_CHECK_EQUAL for optional, arith_uint256, uint256, uint160
09:36 < bitcoin-git> bitcoin/master 1eac96a Lőrinc: Compare FromUserHex result against other hex validators and parsers
09:36 < bitcoin-git> [bitcoin] ryanofsky merged pull request #30618: test: support std::optional in BOOST_CHECK_* and increase FromUserHex fuzz feature coverage (master...paplorinc/uint256S-usages) https://github.com/bitcoin/bitcoin/pull/30618
09:52 -!- adiabat [~adiabat@63.209.32.102] has quit [Remote host closed the connection]
09:52 -!- adiabat [~adiabat@63.209.32.102] has joined #bitcoin-core-dev
09:54 -!- preimage [~halosghos@user/halosghost] has joined #bitcoin-core-dev
09:56 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has joined #bitcoin-core-dev
10:00 -!- dzxzg [~dzxzg@user/dzxzg] has quit [Ping timeout: 256 seconds]
10:01 -!- jarthur_ [~jarthur@user/jarthur] has joined #bitcoin-core-dev
10:01 -!- jetpack [~jetpack@2605:2700:1:100e:dc::f01d] has joined #bitcoin-core-dev
10:01 -!- kouloumos [sid539228@id-539228.tinside.irccloud.com] has joined #bitcoin-core-dev
10:01 -!- hugohn____ [sid304114@id-304114.lymington.irccloud.com] has joined #bitcoin-core-dev
10:01 -!- reardencode [~reardenco@console.reardencode.com] has joined #bitcoin-core-dev
10:01 -!- achow101 [~achow101@user/achow101] has joined #bitcoin-core-dev
10:01 -!- marcofleon [~marcofleo@82.163.218.33] has quit [Quit: Connection closed]
10:03 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has quit [Quit: PaperSword]
10:22 < bitcoin-git> [bitcoin] ryanofsky pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/be768dbd185b...e46bebb444df
10:22 < bitcoin-git> bitcoin/master fae7b83 MarcoFalke: lint: Remove forbidden functions from lint-format-strings.py
10:22 < bitcoin-git> bitcoin/master faa62c0 MarcoFalke: util: Add ConstevalFormatString
10:22 < bitcoin-git> bitcoin/master fa7087b MarcoFalke: util: Use compile-time check for FatalErrorf
10:22 < bitcoin-git> [bitcoin] ryanofsky merged pull request #30546: util: Use consteval checked format string in FatalErrorf, LogConnectFailure (master...2407-log) https://github.com/bitcoin/bitcoin/pull/30546
10:29 -!- aleggg [~aleggg@177.204.240.221.dynamic.adsl.gvt.net.br] has joined #bitcoin-core-dev
10:33 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
10:33 < bitcoin-git> [bitcoin] fjahr opened pull request #30885: scripted-diff: Modernize nLocalServices to m_local_services (master...2024-09-localservices-new) https://github.com/bitcoin/bitcoin/pull/30885
10:38 -!- dzxzg [~dzxzg@user/dzxzg] has joined #bitcoin-core-dev
10:39 < bitcoin-git> [bitcoin] instagibbs opened pull request #30886: rpc: Add support to populate PSBT input utxos via rpc (master...2024-09-updateutxo_psbt) https://github.com/bitcoin/bitcoin/pull/30886
11:00 -!- ___nick___ [~quassel@82-132-212-116.dab.02.net] has joined #bitcoin-core-dev
11:02 < bitcoin-git> [bitcoin] l0rinc opened pull request #30888: build: Minimize I/O operations in GenerateHeaderFromRaw.cmake (master...lorinc/cmake-header-optimization) https://github.com/bitcoin/bitcoin/pull/30888
11:30 -!- ___nick___ [~quassel@82-132-212-116.dab.02.net] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
11:32 -!- ___nick___ [~quassel@82-132-212-116.dab.02.net] has joined #bitcoin-core-dev
11:33 -!- ___nick___ [~quassel@82-132-212-116.dab.02.net] has quit [Client Quit]
11:35 -!- ___nick___ [~quassel@82-132-212-116.dab.02.net] has joined #bitcoin-core-dev
11:37 < bitcoin-git> [bitcoin] maflcko opened pull request #30889:  log: Use ConstevalFormatString  (master...2407-log) https://github.com/bitcoin/bitcoin/pull/30889
11:37 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has quit [Quit: Connection closed for inactivity]
11:47 -!- Talkless [~Talkless@mail.dargis.net] has quit [Remote host closed the connection]
11:52 < bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e46bebb444df...cf0120ff024a
11:52 < bitcoin-git> bitcoin/master 19f4a7c Fabian Jahr: test: Wait for local services to update in feature_assumeutxo
11:52 < bitcoin-git> bitcoin/master cf0120f Ava Chow: Merge bitcoin/bitcoin#30880: test: Wait for local services to update in fe...
11:52 < bitcoin-git> [bitcoin] achow101 merged pull request #30880: test: Wait for local services to update in feature_assumeutxo (master...2024-09-au-services-test) https://github.com/bitcoin/bitcoin/pull/30880
11:57 < bitcoin-git> [bitcoin] jonatack opened pull request #30890: doc: unit test runner help fixup (master...2024-09-unit-test-doc-fixup) https://github.com/bitcoin/bitcoin/pull/30890
11:57 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has joined #bitcoin-core-dev
11:58 -!- dzxzg [~dzxzg@user/dzxzg] has quit [Ping timeout: 256 seconds]
12:10 -!- jarthur_ is now known as jarthur
12:34 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Remote host closed the connection]
12:36 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
12:41 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Ping timeout: 260 seconds]
12:48 -!- kevkevin [~kevkevin@2607:fb90:9b3c:a418:41c8:d830:6973:dcf7] has joined #bitcoin-core-dev
13:04 -!- ___nick___ [~quassel@82-132-212-116.dab.02.net] has quit [Ping timeout: 252 seconds]
13:07 -!- Guest53 [~Guest53@2a02:908:f21:d480:bd49:327c:efe7:bbc8] has joined #bitcoin-core-dev
13:08 -!- Guest53 [~Guest53@2a02:908:f21:d480:bd49:327c:efe7:bbc8] has quit [Client Quit]
13:14 -!- Guest33 [~Guest33@2001:8a0:6df7:fe00:21da:75ae:95b4:1acc] has joined #bitcoin-core-dev
13:42 -!- Guest12 [~Guest33@2001:8a0:6df7:fe00:21da:75ae:95b4:1acc] has joined #bitcoin-core-dev
13:45 -!- Guest33 [~Guest33@2001:8a0:6df7:fe00:21da:75ae:95b4:1acc] has quit [Ping timeout: 256 seconds]
13:50 -!- kevkevin [~kevkevin@2607:fb90:9b3c:a418:41c8:d830:6973:dcf7] has quit [Remote host closed the connection]
13:53 -!- twistedline [~bitcoin@185.193.125.44] has quit [Ping timeout: 252 seconds]
13:54 -!- twistedline [~bitcoin@185.193.125.44] has joined #bitcoin-core-dev
13:58 -!- Guest12 [~Guest33@2001:8a0:6df7:fe00:21da:75ae:95b4:1acc] has quit [Ping timeout: 256 seconds]
14:22 < bitcoin-git> [bitcoin] fjahr opened pull request #30892: test: Check already deactivated network stays suspended after dumptxoutset (master...2024-09-network-inactive) https://github.com/bitcoin/bitcoin/pull/30892
14:24 -!- twistedline_ [~bitcoin@185.193.125.44] has joined #bitcoin-core-dev
14:24 -!- twistedline [~bitcoin@185.193.125.44] has quit [Ping timeout: 272 seconds]
14:36 -!- emcy__ [~emcy@85.255.237.50] has joined #bitcoin-core-dev
14:39 -!- mcey_ [~emcy@148.252.129.55] has quit [Ping timeout: 252 seconds]
14:42 < bitcoin-git> [bitcoin] fjahr opened pull request #30893: test: Introduce ensure helper (master...2024-09-shouldnt-happen) https://github.com/bitcoin/bitcoin/pull/30893
14:48 -!- preimage [~halosghos@user/halosghost] has quit [Quit: WeeChat 4.4.2]
14:51 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
14:56 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
14:57 -!- bugs_ [~bugs@user/bugs/x-5128603] has quit [Quit: Leaving]
14:58 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 260 seconds]
14:59 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
15:01 < bitcoin-git> [gui] furszy opened pull request #835: gui: fix crash when closing wallet (master...2024_gui_fix_wallet_close_crash) https://github.com/bitcoin-core/gui/pull/835
15:11 -!- pablomartin [~pablomart@193.160.246.70] has joined #bitcoin-core-dev
15:38 -!- pablomartin [~pablomart@193.160.246.70] has quit [Quit: Leaving]
16:53 -!- jarthur [~jarthur@user/jarthur] has quit [Ping timeout: 260 seconds]
16:56 -!- jarthur_ [~jarthur@user/jarthur] has joined #bitcoin-core-dev
16:57 -!- achow101 [~achow101@user/achow101] has quit [Quit: Bye]
16:57 -!- achow101 [~achow101@user/achow101] has joined #bitcoin-core-dev
18:00 -!- maxfangx [~maxfangx@142.147.89.217] has quit [Ping timeout: 245 seconds]
18:05 -!- zeropoin1 [~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net] has quit [Quit: leaving]
18:07 -!- maxfangx [~maxfangx@142.147.89.217] has joined #bitcoin-core-dev
18:11 -!- dongcarl [~dongcarl@syn-066-065-169-019.res.spectrum.com] has quit [Quit: The Lounge - https://thelounge.chat]
18:12 -!- dongcarl [~dongcarl@syn-066-065-169-019.res.spectrum.com] has joined #bitcoin-core-dev
18:12 -!- maxfangx [~maxfangx@142.147.89.217] has quit [Ping timeout: 260 seconds]
18:13 -!- maxfangx [~maxfangx@142.147.89.217] has joined #bitcoin-core-dev
18:24 -!- dongcarl [~dongcarl@syn-066-065-169-019.res.spectrum.com] has quit [Quit: The Lounge - https://thelounge.chat]
18:25 -!- dongcarl [~dongcarl@syn-066-065-169-019.res.spectrum.com] has joined #bitcoin-core-dev
18:30 -!- Guest64 [~Guest64@2600:1702:a30:cc90:b99a:b790:9bcd:6ac7] has joined #bitcoin-core-dev
18:36 -!- Guest64 [~Guest64@2600:1702:a30:cc90:b99a:b790:9bcd:6ac7] has quit [Quit: Client closed]
18:41 -!- dongcarl [~dongcarl@syn-066-065-169-019.res.spectrum.com] has quit [Quit: The Lounge - https://thelounge.chat]
18:44 -!- dongcarl [~dongcarl@syn-066-065-169-019.res.spectrum.com] has joined #bitcoin-core-dev
18:59 -!- jarthur_ [~jarthur@user/jarthur] has quit [Quit: jarthur_]
20:21 -!- Guest64 [~Guest64@2600:1702:a30:cc90:b99a:b790:9bcd:6ac7] has joined #bitcoin-core-dev
20:21 -!- Guest64 [~Guest64@2600:1702:a30:cc90:b99a:b790:9bcd:6ac7] has quit [Client Quit]
20:31 -!- mudsip [~mudsip@user/mudsip] has joined #bitcoin-core-dev
20:32 -!- mudsip [~mudsip@user/mudsip] has quit [Client Quit]
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:25 -!- jonatack [~jonatack@user/jonatack] has quit [Read error: Connection reset by peer]
21:26 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
21:59 -!- benwestgate [~BenWestga@syn-076-184-062-115.res.spectrum.com] has quit [Remote host closed the connection]
22:01 -!- emcy__ [~emcy@85.255.237.50] has quit [Remote host closed the connection]
22:01 -!- mcey [~emcy@85.255.237.50] has joined #bitcoin-core-dev
22:01 -!- Chris_Stewart_5 [~Chris_Ste@static-68-235-44-41.cust.tzulo.com] has quit [Ping timeout: 245 seconds]
22:02 -!- Chris_Stewart_5 [~Chris_Ste@static-68-235-44-41.cust.tzulo.com] has joined #bitcoin-core-dev
22:22 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Remote host closed the connection]
22:34 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
22:38 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Ping timeout: 255 seconds]
23:10 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
23:15 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Ping timeout: 260 seconds]
23:17 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has quit [Quit: Connection closed for inactivity]
23:30 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
23:35 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Ping timeout: 245 seconds]
23:50 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
23:55 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Ping timeout: 260 seconds]
--- Log closed Fri Sep 13 00:00:50 2024