--- Log opened Thu Sep 26 00:00:03 2024
00:57 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
01:02 -!- oneeyedalien [~oneeyedal@user/oneeyedalien] has quit [Quit: Leaving]
01:23 -!- ion-_ [ion-@user/ion-] has quit [Remote host closed the connection]
01:32 -!- ___nick___ [~quassel@82-132-215-132.dab.02.net] has joined #bitcoin-core-dev
01:40 -!- ion- [ion-@user/ion-] has joined #bitcoin-core-dev
01:45 < bitcoin-git> [bitcoin] fanquake opened pull request #30973: doc: fix `loadtxoutset` example (master...loadtxoutset_help) https://github.com/bitcoin/bitcoin/pull/30973
01:55 -!- Guest10 [~Guest10@176.40.247.132] has joined #bitcoin-core-dev
01:56 -!- ion- [ion-@user/ion-] has quit [Remote host closed the connection]
01:56 -!- ion- [ion-@user/ion-] has joined #bitcoin-core-dev
01:59 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/65f6e7078b17...513b7136c798
01:59 < bitcoin-git> bitcoin/master c183258 fanquake: ci: add LLVM_SYMBOLIZER_PATH to Valgrind fuzz job
01:59 < bitcoin-git> bitcoin/master 513b713 merge-script: Merge bitcoin/bitcoin#30961: ci: add `LLVM_SYMBOLIZER_PATH` to Valgrind fu...
01:59 < bitcoin-git> [bitcoin] fanquake merged pull request #30961: ci: add `LLVM_SYMBOLIZER_PATH` to Valgrind fuzz job (master...valgrind_symbolizer) https://github.com/bitcoin/bitcoin/pull/30961
02:01 -!- ion- [ion-@user/ion-] has quit [Remote host closed the connection]
02:03 -!- l0rinc [~l0rinc@94.44.108.19] has joined #bitcoin-core-dev
02:04 -!- l0rinc [~l0rinc@94.44.108.19] has quit [Client Quit]
02:05 -!- l0rinc [~l0rinc@94.44.108.19] has joined #bitcoin-core-dev
02:06 -!- ___nick___ [~quassel@82-132-215-132.dab.02.net] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
02:08 -!- ion- [ion-@user/ion-] has joined #bitcoin-core-dev
02:08 -!- ___nick___ [~quassel@82-132-215-132.dab.02.net] has joined #bitcoin-core-dev
02:11 -!- ___nick___ [~quassel@82-132-215-132.dab.02.net] has quit [Client Quit]
02:13 -!- ___nick___ [~quassel@82-132-215-132.dab.02.net] has joined #bitcoin-core-dev
02:17 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has joined #bitcoin-core-dev
02:59 -!- Guest10 [~Guest10@176.40.247.132] has quit [Ping timeout: 256 seconds]
03:05 -!- l0rinc [~l0rinc@94.44.108.19] has quit [Quit: Client closed]
03:05 -!- cold [~cold@user/cold] has quit [Ping timeout: 252 seconds]
03:06 -!- midnight [~midnight@user/midnight] has quit [Ping timeout: 248 seconds]
03:06 -!- midnight_ [~midnight@user/midnight] has joined #bitcoin-core-dev
03:06 -!- cold [~cold@user/cold] has joined #bitcoin-core-dev
03:09 < bitcoin-git> [bitcoin] maflcko opened pull request #30974: ci: Require git to be installed on workers (master...2409-ci-git) https://github.com/bitcoin/bitcoin/pull/30974
03:22 -!- ion- [ion-@user/ion-] has quit [Remote host closed the connection]
03:26 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/513b7136c798...e13da501db9e
03:26 < bitcoin-git> bitcoin/master 2867251 fanquake: doc: fix loadtxoutset example
03:26 < bitcoin-git> bitcoin/master e13da50 merge-script: Merge bitcoin/bitcoin#30973: doc: fix `loadtxoutset` example
03:27 < bitcoin-git> [bitcoin] fanquake merged pull request #30973: doc: fix `loadtxoutset` example (master...loadtxoutset_help) https://github.com/bitcoin/bitcoin/pull/30973
03:29 < bitcoin-git> [bitcoin] Sjors opened pull request #30975: guix: add multiprocess binaries (master...2024/09/multiprocess-guix) https://github.com/bitcoin/bitcoin/pull/30975
03:38 -!- ion- [ion-@user/ion-] has joined #bitcoin-core-dev
03:48 -!- __DuBPiRaTe__ [~E_bomb@2600:6c50:7f7f:d89a:2ecf:67ff:fe08:b362] has joined #bitcoin-core-dev
04:00 < bitcoin-git> [bitcoin] hebasto opened pull request #30976: depends, doc: Drop package-specific note about CMake (master...240926-mp-deps) https://github.com/bitcoin/bitcoin/pull/30976
04:01 -!- ion- [ion-@user/ion-] has quit [Remote host closed the connection]
04:02 -!- ion- [ion-@user/ion-] has joined #bitcoin-core-dev
04:21 -!- midnight_ is now known as midnight
04:23 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e13da501db9e...d5af7d28f475
04:23 < bitcoin-git> bitcoin/master 4cf84b3 Hennadii Stepanov: depends, doc: No need to specify general requirement
04:23 < bitcoin-git> bitcoin/master d5af7d2 merge-script: Merge bitcoin/bitcoin#30976: depends, doc: Drop package-specific note abou...
04:23 < bitcoin-git> [bitcoin] fanquake merged pull request #30976: depends, doc: Drop package-specific note about CMake (master...240926-mp-deps) https://github.com/bitcoin/bitcoin/pull/30976
04:24 -!- Guest7518 [~diego@186.207.245.11] has quit [Quit: WeeChat 4.4.2]
04:24 -!- dviola [~diego@user/dviola] has joined #bitcoin-core-dev
04:38 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has joined #bitcoin-core-dev
04:43 -!- ion- [ion-@user/ion-] has quit [Remote host closed the connection]
04:50 -!- ion- [ion-@user/ion-] has joined #bitcoin-core-dev
04:51 -!- ion-_ [ion-@user/ion-] has joined #bitcoin-core-dev
04:52 -!- ion-_ [ion-@user/ion-] has quit [Remote host closed the connection]
04:53 -!- aleggg [~aleggg@187.113.241.88] has quit [Ping timeout: 264 seconds]
04:54 -!- ion- [ion-@user/ion-] has quit [Ping timeout: 245 seconds]
05:09 -!- ion- [ion-@user/ion-] has joined #bitcoin-core-dev
05:12 -!- ion- [ion-@user/ion-] has quit [Remote host closed the connection]
05:12 -!- ion- [ion-@user/ion-] has joined #bitcoin-core-dev
05:21 -!- ion- [ion-@user/ion-] has quit [Remote host closed the connection]
05:22 -!- pablomartin4btc [~pablomart@91.196.223.101] has joined #bitcoin-core-dev
05:38 -!- ion- [ion-@user/ion-] has joined #bitcoin-core-dev
05:42 -!- ion- [ion-@user/ion-] has quit [Ping timeout: 255 seconds]
05:44 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [Closing Window]
05:56 -!- ion- [ion-@user/ion-] has joined #bitcoin-core-dev
06:13 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
06:25 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 252 seconds]
06:33 -!- Chris_Stewart_5 [~Chris_Ste@static-68-235-44-41.cust.tzulo.com] has joined #bitcoin-core-dev
06:37 -!- eval-exec [~Thunderbi@104.160.45.106.16clouds.com] has quit [Ping timeout: 260 seconds]
06:58 < bitcoin-git> [bitcoin] fjahr opened pull request #30979: contrib: Update asmap link in seeds readme (master...2024-09-asmap-seed-link) https://github.com/bitcoin/bitcoin/pull/30979
07:00 < achow101> #startmeeting
07:00 -!- Emc99 [~Emc99@212.129.84.59] has joined #bitcoin-core-dev
07:00 < tdb3> hi
07:00 < achow101> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard aureleoules b10c BlueMatt brunoerg cfields darosior dergoegge dongcarl fanquake fjahr furszy gleb glozow hebasto instagibbs jamesob jarolrod jonatack josibake kallewoof kanzure kouloumos kvaciral laanwj LarryRuane lightlike luke-jr MacroFake Murch phantomcircuit pinheadmz promag provoostenator ryanofsky sdaftuar S3RK stickies-v sipa sr_gi theStack TheCharlatan vasild
07:00 < pinheadmz> hi
07:00 < willcl-ark> hi
07:00 < vasild> hi
07:00 < kanzure> hi
07:00 < achow101> There are no pre-proposed meeting topics this week. Any last minute ones to add?
07:00 < bitcoin-git> [bitcoin] marcofleon opened pull request #30980: fuzz: fix bug in p2p_headers_presync harness (master...2024/09/headers-presync-fuzz-bugfix) https://github.com/bitcoin/bitcoin/pull/30980
07:01 < dergoegge> hi
07:01 < fjahr> hi
07:01 < hebasto> hi
07:01 < achow101> #topic Ad-hoc high priority for review
07:01 < achow101> Anything to add or remove from https://github.com/orgs/bitcoin/projects/1/views/4
07:03 -!- kvaciral[m] [~kvaciralx@2620:6e:a000:ce11::27] has joined #bitcoin-core-dev
07:03 < achow101> #topic 28.0
07:03 < achow101> Any new issues in 28.0rc2?
07:04 < achow101> Current backports PR is #30959. Since the 2 fixes being backported are trivial, I'm plannin on skipping rc3 and tagging final once that is merged
07:04 <@gribble> https://github.com/bitcoin/bitcoin/issues/30959 | [28.x] backports and finalize (or rc3) by achow101 · Pull Request #30959 · bitcoin/bitcoin · GitHub
07:04 < willcl-ark> That sounds reasonable :)
07:05 < achow101> Please also review the draft release notes https://github.com/bitcoin-core/bitcoin-devwiki/wiki/28.0-Release-Notes-Draft
07:06 < sipa> hi
07:06 < achow101> anything else to discuss?
07:06 < fjahr> Just a quick PSA: I have moved all my ASMap related repos to a dedicated org (https://github.com/asmap) to make collaboration easier. Old links should still work via redirect but if you see an outdated link please update because GH says they don't maintain those redirects forever.
07:06 < willcl-ark> (reading first bit of that): perhaps we should discuss macos notarization? i.e. #15774
07:06 <@gribble> https://github.com/bitcoin/bitcoin/issues/15774 | macOS App Notarization & Stapling · Issue #15774 · bitcoin/bitcoin · GitHub
07:06 < willcl-ark> is the plan to give in to Apple's requirements and fully Notarize and staple?
07:07 < pinheadmz> piggy back #29749 on that >
07:07 <@gribble> https://github.com/bitcoin/bitcoin/issues/29749 | release: ship codesigned MacOS arm64 binaries · Issue #29749 · bitcoin/bitcoin · GitHub
07:07 -!- b10c[m] [~b10cb10cm@2620:6e:a000:ce11::1c] has joined #bitcoin-core-dev
07:07 < achow101> fjahr: good to know. IIRC github does keep redirects for a long time, at least I've had a redirect that's been working for 5 years now
07:07 < achow101> #topic MacOS notarization
07:08 < achow101> willcl-ark: I don't think there's really been a plan yet?
07:08 < achow101> but it does seem like we should probably figure it out for the next release
07:08 < fjahr> achow101: yeah, that's just what I read, I guess they want to have the option to remove them at some point
07:08 < sipa> if macos is phoning home regardless of stapling/notarization, there seems to be little downside to doing it
07:08 < willcl-ark> Exactly THe current requirement is that a user must generate a codesigning cert, then codesign, and remove the quarantine bit. We can't really get around it AFAIK
07:10 < Chris_Stewart_5> Seems like a note about this in the release notes would be a good first step? I've run into this multiple times at this point and its a PITA finding the exact commands that need to be run to make bitcoind work on mac
07:11 < Chris_Stewart_5> a quick glance of the 28.0 release notes doesn't contain anything AFAICT. Seems like putting this in the 'How to upgrade' section would make sense? :man_shrugging:
07:11 < gmaxwell> If OSX phones home the software users run it might be worth a persistant note on that too in the docs for running on OSX.
07:11 < achow101> I've moved #15774 to the 29.0 milestone
07:11 <@gribble> https://github.com/bitcoin/bitcoin/issues/15774 | macOS App Notarization & Stapling · Issue #15774 · bitcoin/bitcoin · GitHub
07:11 < sipa> gmaxwell: right
07:11 < achow101> Chris_Stewart_5: if you know what the commands are, feel free to add it yourself
07:11 < Chris_Stewart_5> Can do assuming everyone is on board
07:12 < sipa> Chris_Stewart_5: does the software actually not work if you don't?
07:12 < fanquake> My understanding is that our binaries just wont work at all on the latest macos release, and there's no-longer workarounds available
07:12 < willcl-ark> It does not work at all
07:12 < sipa> oh wow
07:12 < Chris_Stewart_5> sipa: it doesn't start and gives a cryptic error
07:13 < sipa> i assumed it was just a "warning unverified software" popup or so
07:13 < fanquake> so we are basically shipping no-ops for the latest version of macos
07:13 < Chris_Stewart_5> I don't have it handy atm.... i'll dig up the commands again. I haven't done it since the 27.1 release iirc. 
07:13 < hebasto> is ad-hoc self signing no longer works as a workaround?
07:13 < Chris_Stewart_5> sipa: This also applies to bitcoind, bitcoin-cli
07:13 < willcl-ark> I had a think about adding an "auto-sign" script for macos: https://github.com/bitcoin/bitcoin/compare/master...willcl-ark:bitcoin:codesign-script but you still need a self-signed signing certificate
07:13 < achow101> sipa: it started that way
07:13 < vasild> well, if macos is phoning home and bitcoind does not work on macos, then even better. Why do we need to do anything?
07:13 < Chris_Stewart_5> hebasto: it does, but where are the commands? How are people suppose to find them? 
07:13 < emzy> AFAIK it is this: xattr -rd com.apple.quarantine /path/to/applicationname.app
07:13 < willcl-ark> fanquake: no, I'm pretty sure the self signing and removing quarantine bit still works?
07:14 < Chris_Stewart_5> to be clear, this is probably a stop gap, things should probably just work :tm: ? But giving people instructions as a workaround for now seems appropriate?
07:14 < sipa> Chris_Stewart_5: agreed
07:14 < achow101> Chris_Stewart_5: yes
07:14 < fanquake> willcl-ark: not sure, but anyone using bitcoin-qt, which is primarily what we ship on macos, isn't doing any of that
07:14 < willcl-ark> fanquake: agree
07:14 < sipa> vasild: the world would be a lot better place if all humans were reasonable, but if that were the case, we probably wouldn't need bitcoin at all?
07:15 < willcl-ark> (but I have for sure run bitcoind 28rc2 after self-signing)
07:15 < vasild> sipa: yeah, I was half-joking ;-)
07:16 < sipa> to self-sign, you need a self-signing certificate? can you do that without apple's involvement?
07:16 < achow101> Any other topics to discuss?
07:16 < sipa> are there workarounds besides that?
07:16 < achow101> sipa: there's "ad-hoc signing" which doesn't actually require a certificate
07:16 < willcl-ark> sipa: not that I'm aware of. {Perhaps disable the entire SIP mechanism?
07:16 < Chris_Stewart_5> sipa: No need to involve apple, you self sign and the cert gets stored locally iirc
07:16 < glozow> re topics, I was wondering about cluster mempool / TxGraph status? If sipa has an update on that?
07:17 < sipa> glozow: happy to give an update
07:17 < achow101> #topic cluster mempool update
07:17 < glozow> :D
07:18 < sipa> so, we're currently imagining something like 3 layers for the cluster mempool code
07:18 < Chris_Stewart_5> One last comment on the notarization problem on mac, here is a bitcoin stack exchange question detailing the problem and solution: https://bitcoin.stackexchange.com/a/117101
07:18 < gmaxwell> vasild: considering how easy it is to enumerate people running bitcoin from the p2p network the fact that it phones home isn't hard incompatible with bitcoin I think.  But perhaps it would be a very unwelcome surprise to people using bitcoin behind tor. 
07:19 < sipa> * the bottom layer (depgraph) is pretty much done, apart from 30857 (which i don't plan to change anymore barring significant review comments). It deals with individual transaction clusters in a very abstract way, but contains all the computationally-hard stuff.
07:20 < vasild> gmaxwell: yeah, and it depends on what it phones home - maybe it would automatically backup important files to the cloud (like wallet.dat). A friend of mine complained that some anti virus moved his wallet.dat (!) I wouldn't be surprised if it sent it to the anti virus company for an analysis, if it treated it as a virus.
07:20 < sipa> * the middle layer (txgraph) is sort of a barebones mempool, knowing just about all transaction fees/sizes and dependencies between them (but has no concept of txids, outputs, inputs, prioritization, ...), clusters of them, and linearizations for them...; i have been working on fleshing the design for this out, but i don't have anything to show yet, sorry
07:21 < sipa> txgraph would also have a notion of "changesets", proposed sets of transaction additions/removals/dependencies to add to the mempool, so a rbfs can be staged (create a changeset for a proposed RBF, inspect the feerate diagram changes it would make, and then decide to throw it away or commit it)
07:22 < sipa> * the top layer is the mempool/validation code, which would use txgraph but add actual transactions, policy rules, validation
07:22 < sipa> the point of txgraph is that being more abstract it can be tested in isolation much more easily
07:23 < sipa> suhas' current PR (28676) contains a prototype for txgraph, but i'm working on rewriting it as a separate PR, after which 28676 would be rebased on that
07:24 < glozow> This sounds really cool!
07:25 < glozow> Thanks for the update sipa
07:25 < tdb3> thanks sipa!
07:26 < achow101> anything else to discuss?
07:26 < Chris_Stewart_5> sipa: Perhaps cart before the horse, but what do we think the deployment story looks like? 
07:27 < Chris_Stewart_5> last I heard, the idea would be the totally replace existing mempool code with the new cluster mempool code, is that still the plan (presumably in 29.0)?
07:27 < sipa> Chris_Stewart_5: i think everything up to txgraph (which may well end up becoming multiple PRs) can be staged in, as in merged without actually changing any observable behavior, as it's just new data structures and algorithms that can be tested in isolation
07:28 < sipa> but the introduction of cluster-based mempool will be a hard switch; i don't think we realistically want both the old and new code ever simultaneously in production (it'd involve the worst of both worlds: the memory and CPU costs related to having both, plus the policy rules that are necessitated by both).
07:29 < sipa> i could imagine the introduction of cluster mempool, and the removal of the old mempool data structures to be in separate PRs only if the intent is for both to go in in the same release.
07:29 < Chris_Stewart_5> I guess I was thinking more along the lines of a -clustermempool flag in 29.0 and then assuming everything goes good, default to -clustermempool in 30.0 and remove old code in 31.0? Perhaps this a bit too conservative though?
07:30 < sipa> there is no way we can do that
07:30 < bitcoin-git> [bitcoin] willcl-ark opened pull request #30981: ci: add timestamps to cirrus jobs (master...cirrus-timestamps) https://github.com/bitcoin/bitcoin/pull/30981
07:30 < Chris_Stewart_5> Is this written about anywhere why its not possible? Or just have to read through code?
07:30 < sipa> i just told you :)
07:31 < sipa> it would involve the worst of both worlds
07:31 < Chris_Stewart_5> Yeah, and I guess I assumed only 1 of the mempool implementations would be running (-clustermempool or legacy mempool). Not both.
07:31 < sipa> they're just data structures that need to be maintained - if they're compiled in, they will be used
07:31 -!- Emc99 [~Emc99@212.129.84.59] has quit [Ping timeout: 256 seconds]
07:32 < sipa> at the very least you'd get the memory usage from both
07:32 < sipa> it's not like we're creating a completely new mempool and can decide at runtime which of the two you're using
07:32 < _aj_> if you're nervous about the new mempool code in 29.x you'd just keep running 28.x anyway?
07:33 < Chris_Stewart_5> Runtime performance and code maintenance are different topics. I agree there will be maintenance burden for awhile. Idk if i'm so convinced on runtime performance, but you have more experience than i do on the topic so i'll defer to you
07:33 < sipa> we do have simulations based on replays of all mempool data to get an idea of what would be impacted by the policy changes that cluster mempool entails
07:33 < Chris_Stewart_5> _aj_: Yeah, and then we give people another reason not to upgrade with the latest and greatest stuff and get them stuck on 28.x.
07:34 -!- Wronsk [~Wronsk@cust-west-par-46-193-0-235.cust.wifirst.net] has joined #bitcoin-core-dev
07:34 < _aj_> Chris_Stewart_5: if they don't upgrade from 28.x until 30.x is out, that's already fine and supported
07:34 < Chris_Stewart_5> Any way, perhaps i'm concern trolling at this point so i'll keep quiet. I am excited about clustermempool and think its great!
07:35 < sipa> Chris_Stewart_5: i think the biggest issue is the policy rules... the current mempool has certain policy rules that are necessitated by its implementation (primarily the ancestor and descendant set limits); cluster mempool has different policy rules (cluster size limit, which isn't exactly the same as ancestor or descendant limits, but supports higher numbers)
07:35 < sipa> if we keep the old mempool data structures, we need to keep the old policy rules
07:35 < sipa> if we introduce the new mempool data structures, we need to introduce the new policy rules
07:36 < sipa> so having a release that supports both would effectively entail having the combination of both policy rules (neither ancestor/descendant limits can be violated, nor cluster size limits).
07:36 < glozow> I imagine it would be even more invasive to add code everywhere (validation, policy, mining, etc) to have 2 mempools. And they'd have different transactions in them... sounds like a nightmare
07:37 < glozow> (And I can't think of another way to support both)
07:37 < Chris_Stewart_5> I'll think about this more. We can move on
07:37 < sipa> Chris_Stewart_5: yeah i understand the concern; it will be a nontrivial and abrubt change - but i don't think the alternative is very realistic
07:37 < vasild> "I guess I assumed only 1 of the mempool implementations would be running"
07:38 < sipa> a compile-time switch between them may be vaguely possible
07:38 < sipa> but even that is pretty hard
07:39 < achow101> anything else to discuss?
07:39 < tdb3> Sounds like the probability of bugs would be higher in a conjoined/transition implementation than with a clean update. And an end goal is minimizing bugs
07:40 -!- bugs_ [~bugs@user/bugs/x-5128603] has joined #bitcoin-core-dev
07:41 -!- b10c_ [~quassel@static.33.106.217.95.clients.your-server.de] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
07:42 < achow101> #endmeeting
07:42 -!- b10c [~quassel@user/b10c] has joined #bitcoin-core-dev
07:42 < sipa> Chris_Stewart_5: re apple... if you self-sign, do you still have the phoning home?
07:43 < b10c> would love to have a few more eyes on #25832. I've been using the connection tracepoints for >2 years now. They've helped learning out about LinkingLion and us dropping connections due to high CPU usage elsewhere
07:43 <@gribble> https://github.com/bitcoin/bitcoin/issues/25832 | tracing: network connection tracepoints by 0xB10C · Pull Request #25832 · bitcoin/bitcoin · GitHub
07:43 < b10c> I'm frequently rebasing these commits on master and e.g. RCs that I monitor - hope to run plain master at some point
07:45 -!- twistedline [~bitcoin@185.193.125.44] has quit [Ping timeout: 276 seconds]
07:47 < Chris_Stewart_5> sipa: i'm not sure what you mean by phoning home, and I'll need to investigate regardless. Do you mean contacting apple ?
07:47 < sipa> Chris_Stewart_5: yes
07:47 < Chris_Stewart_5> i don't believe so, but i'm going to go investigate now. Be back in awhile with a PR
07:47 < fanquake> by default any codesigning may involve timestamping, which i'd assume apple would use it's own servers for
07:47 < sipa> my understanding is that we've previously held off on doing these things because apple would phone home to verify the certificate in some way or so
07:48 < achow101> ad-hoc signing doesn't actually sign though
07:48 < achow101> it actually tells gatekeeper that the binary is safe to not verify
07:48 < sipa> but given recent reports that this contacting of apple servers happens regardless, it may be time to bite the bullet
07:49 < fanquake> has anyone checked if the codesigning tool actually ships on a vanilla, non-dev mac
07:49 < fanquake> or will we also need to tell people to download and install the command line tools (from apple)
07:49 < fanquake> to actually do any signing in the first place
07:50 < achow101> fanquake: i believe it does as it's part of the security utils. haven't checked on a mac though
07:50 < sipa> Chris_Stewart_5: i ask, because if somehow the phoning home can be prevented by self-signing, then perhaps self-signing should remain the primary recommendation, even if we do the stapling
07:51 -!- twistedline [~bitcoin@185.193.125.44] has joined #bitcoin-core-dev
08:01 < fanquake> Can someone share whatever command they are using for adhoc codesigning? I just downloaded bins from bitcoincore.org, ran codesign --force --options runtime -s - bitcoind, which shows, Signature=adhoc, but the bins still don't run
08:03 -!- twistedline [~bitcoin@185.193.125.44] has quit [Ping timeout: 260 seconds]
08:03 -!- twistedline [~bitcoin@185.193.125.44] has joined #bitcoin-core-dev
08:08 -!- Wronsk [~Wronsk@cust-west-par-46-193-0-235.cust.wifirst.net] has quit [Remote host closed the connection]
08:11 -!- twistedline [~bitcoin@185.193.125.44] has quit [Ping timeout: 260 seconds]
08:11 -!- twistedline [~bitcoin@185.193.125.44] has joined #bitcoin-core-dev
08:23 -!- Emc99 [~Emc99@212.129.84.59] has joined #bitcoin-core-dev
08:25 -!- Emc99 [~Emc99@212.129.84.59] has quit [Client Quit]
08:29 < bitcoin-git> [bitcoin] Christewart opened pull request #30982: docs: Add instructions on how to self-sign bitcoin-core binaries for macOS (master...2024-09-26-selfsign-mac-instructions) https://github.com/bitcoin/bitcoin/pull/30982
08:29 -!- twistedline [~bitcoin@185.193.125.44] has quit [Ping timeout: 244 seconds]
08:30 < Chris_Stewart_5> fanquake: ^ is what works for me. Give it a try. It appears that the xattr -d com.apple.quarantine is only required if you download via a web browser (rather than command line) AFAICT
08:31 -!- twistedline [~bitcoin@185.193.125.44] has joined #bitcoin-core-dev
08:32 < Chris_Stewart_5> and i don't believe it requires phoning home. I disconnected from my network connection and was still able to sign and run commands like ./bitcoin-cli --help 
08:34 < Chris_Stewart_5> fanquake: Also according to chatGPT 'codesign' ships by default on macOS ;). 
08:35 < fanquake> Chris_Stewart_5: cool. Note that we'll want to inline the instructions into the readme, rather than linking to one thing, that then links to something else
08:35 < fanquake> as far as I'm aware, it's also not required to create a cert, as claimed in the second linked post
08:36 < Chris_Stewart_5> I"ll just remove the link as I don't think it provides much value
08:36 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has quit [Quit: Connection closed for inactivity]
08:37 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d5af7d28f475...fa7c2838a5f3
08:37 < bitcoin-git> bitcoin/master fa48be6 MarcoFalke: test: Refactor fill_mempool to extract send_batch helper
08:37 < bitcoin-git> bitcoin/master faf8015 MarcoFalke: test: Add missing sync_mempools() to fill_mempool()
08:37 < bitcoin-git> bitcoin/master fa7c283 merge-script: Merge bitcoin/bitcoin#30948: test: Add missing sync_mempools() to fill_mem...
08:37 < bitcoin-git> [bitcoin] fanquake merged pull request #30948: test: Add missing sync_mempools() to fill_mempool() (master...2409-test-fix-tx-mem) https://github.com/bitcoin/bitcoin/pull/30948
08:40 -!- twistedline [~bitcoin@185.193.125.44] has quit [Ping timeout: 248 seconds]
08:40 -!- twistedline [~bitcoin@185.193.125.44] has joined #bitcoin-core-dev
08:45 -!- twistedline [~bitcoin@185.193.125.44] has quit [Ping timeout: 246 seconds]
08:45 -!- twistedline [~bitcoin@185.193.125.44] has joined #bitcoin-core-dev
08:47 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has joined #bitcoin-core-dev
08:51 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fa7c2838a5f3...36ad9516dbd6
08:51 < bitcoin-git> bitcoin/master f951f1f willcl-ark: ci: add timestamps to cirrus jobs
08:51 < bitcoin-git> bitcoin/master 36ad951 merge-script: Merge bitcoin/bitcoin#30981: ci: add timestamps to cirrus jobs
08:51 < bitcoin-git> [bitcoin] fanquake merged pull request #30981: ci: add timestamps to cirrus jobs (master...cirrus-timestamps) https://github.com/bitcoin/bitcoin/pull/30981
08:59 -!- twistedline [~bitcoin@185.193.125.44] has quit [Ping timeout: 246 seconds]
09:00 -!- twistedline [~bitcoin@185.193.125.44] has joined #bitcoin-core-dev
09:09 -!- zeropoint [~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
09:12 -!- BrandonOdiwuor [~BrandonOd@105.163.2.94] has quit [Quit: Client closed]
09:18 -!- ion- [ion-@user/ion-] has quit [Remote host closed the connection]
09:18 -!- ion- [ion-@user/ion-] has joined #bitcoin-core-dev
09:19 -!- twistedline [~bitcoin@185.193.125.44] has quit [Ping timeout: 252 seconds]
09:20 -!- twistedline [~bitcoin@185.193.125.44] has joined #bitcoin-core-dev
09:52 -!- ___nick___ [~quassel@82-132-215-132.dab.02.net] has quit [Ping timeout: 245 seconds]
09:52 -!- ion- [ion-@user/ion-] has quit [Remote host closed the connection]
10:04 -!- ___nick___ [~quassel@82-132-215-31.dab.02.net] has joined #bitcoin-core-dev
10:08 -!- ion- [ion-@user/ion-] has joined #bitcoin-core-dev
10:13 -!- emcy__ [~emcy@85.255.235.25] has joined #bitcoin-core-dev
10:16 -!- mcey_ [~emcy@148.252.145.21] has quit [Ping timeout: 246 seconds]
10:22 -!- brunoerg [~brunoerg@187.183.60.117] has joined #bitcoin-core-dev
10:47 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
11:01 < pinheadmz> does anyone still have the testnet4 block that was reorged out? 
11:01 < pinheadmz> 00000000000000263393ce5f648afd53676f13d360cc9f264b89351623bf1242
11:33 -!- ion- [ion-@user/ion-] has quit [Remote host closed the connection]
11:33 -!- ion- [ion-@user/ion-] has joined #bitcoin-core-dev
11:34 -!- dviola [~diego@user/dviola] has quit [Quit: WeeChat 4.4.2]
12:00 -!- ion- [ion-@user/ion-] has quit [Remote host closed the connection]
12:06 -!- dviola [~diego@user/dviola] has joined #bitcoin-core-dev
12:11 -!- dongcarl3 [~dongcarl@syn-066-065-169-019.res.spectrum.com] has joined #bitcoin-core-dev
12:11 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
12:12 -!- dermoth_ [~dermoth@user/dermoth] has joined #bitcoin-core-dev
12:13 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
12:16 -!- theStack_ [~theStack@95.179.145.232] has joined #bitcoin-core-dev
12:18 -!- theStack_ [~theStack@95.179.145.232] has quit [Client Quit]
12:18 -!- ion- [ion-@user/ion-] has joined #bitcoin-core-dev
12:19 -!- Netsplit *.net <-> *.split quits: ajonas, dongcarl, valwal__, dermoth, moneyball_____, Ara, Flow, robobub, shesek, theStack,  (+2 more, use /NETSPLIT to show all of them)
12:19 -!- dongcarl3 is now known as dongcarl
12:20 -!- Netsplit over, joins: shesek, dergoegge, ajonas, moneyball_____, robobub, rodarmor, valwal__, Flow, Ara
12:22 -!- dermoth_ is now known as dermoth
12:23 -!- ion- [ion-@user/ion-] has quit [Ping timeout: 244 seconds]
12:26 -!- robobub [uid248673@id-248673.uxbridge.irccloud.com] has quit [Ping timeout: 265 seconds]
12:30 -!- theStack [~theStack@95.179.145.232] has joined #bitcoin-core-dev
12:31 -!- robobub [uid248673@id-248673.uxbridge.irccloud.com] has joined #bitcoin-core-dev
12:36 -!- Talkless [~Talkless@mail.dargis.net] has quit [Remote host closed the connection]
12:38 -!- ion- [ion-@user/ion-] has joined #bitcoin-core-dev
12:41 -!- ___nick___ [~quassel@82-132-215-31.dab.02.net] has quit [Ping timeout: 248 seconds]
13:01 -!- brunoerg [~brunoerg@187.183.60.117] has quit [Remote host closed the connection]
13:02 -!- Chris_Stewart_5 [~Chris_Ste@static-68-235-44-41.cust.tzulo.com] has quit [Ping timeout: 255 seconds]
13:02 -!- Chris_Stewart_5 [~Chris_Ste@static-68-235-44-41.cust.tzulo.com] has joined #bitcoin-core-dev
13:25 -!- arminsdev [~arminsdev@2601:184:4181:ba20:71cc:1923:57a:fa69] has joined #bitcoin-core-dev
14:07 -!- ion- [ion-@user/ion-] has quit [Ping timeout: 248 seconds]
14:12 -!- VonNaturAustreVe [~natur@user/vonnaturaustreve] has joined #bitcoin-core-dev
14:21 -!- achow101 [~achow101@user/achow101] has quit [Ping timeout: 252 seconds]
14:21 -!- ion- [ion-@user/ion-] has joined #bitcoin-core-dev
14:22 -!- VonNaturAustreVe [~natur@user/vonnaturaustreve] has quit [Quit: Leaving]
14:27 -!- brunoerg [~brunoerg@2804:1600:100:1f00:9d6b:24db:99c4:546e] has joined #bitcoin-core-dev
14:32 < bitcoin-git> [bitcoin] brunoerg opened pull request #30984: p2p: rpc: add `tx_reconciliation` to `getpeerinfo` (master...2024-09-erlay-getpeerinfo) https://github.com/bitcoin/bitcoin/pull/30984
14:34 -!- achow101 [~achow101@user/achow101] has joined #bitcoin-core-dev
14:38 < bitcoin-git> [bitcoin] andremralves opened pull request #30986: contrib: skip missing binaries in gen-manpages (master...fix-gen-manpages) https://github.com/bitcoin/bitcoin/pull/30986
14:40 -!- achow101 [~achow101@user/achow101] has quit [Ping timeout: 248 seconds]
14:45 -!- achow101 [~achow101@user/achow101] has joined #bitcoin-core-dev
14:46 -!- brunoerg [~brunoerg@2804:1600:100:1f00:9d6b:24db:99c4:546e] has quit [Ping timeout: 265 seconds]
14:53 -!- bugs_ [~bugs@user/bugs/x-5128603] has quit [Quit: Leaving]
14:56 -!- brunoerg [~brunoerg@2804:1600:100:1f00:9d6b:24db:99c4:546e] has joined #bitcoin-core-dev
15:11 -!- arminsdev [~arminsdev@2601:184:4181:ba20:71cc:1923:57a:fa69] has quit [Quit: Client closed]
15:13 -!- brunoerg [~brunoerg@2804:1600:100:1f00:9d6b:24db:99c4:546e] has quit [Remote host closed the connection]
15:23 -!- brunoerg [~brunoerg@2804:1600:100:1f00:9d6b:24db:99c4:546e] has joined #bitcoin-core-dev
15:40 < bitcoin-git> [bitcoin] davidgumberg opened pull request #30987: Don't zero-after-free `DataStream`: ~25% faster IBD (master...zero_after_free_allocator_change) https://github.com/bitcoin/bitcoin/pull/30987
15:42 -!- brunoerg [~brunoerg@2804:1600:100:1f00:9d6b:24db:99c4:546e] has quit [Remote host closed the connection]
15:45 -!- brunoerg [~brunoerg@2804:1600:100:1f00:9d6b:24db:99c4:546e] has joined #bitcoin-core-dev
16:24 -!- brunoerg [~brunoerg@2804:1600:100:1f00:9d6b:24db:99c4:546e] has quit [Remote host closed the connection]
16:27 -!- brunoerg [~brunoerg@2804:1600:100:1f00:9d6b:24db:99c4:546e] has joined #bitcoin-core-dev
16:27 -!- brunoerg [~brunoerg@2804:1600:100:1f00:9d6b:24db:99c4:546e] has quit [Remote host closed the connection]
16:29 -!- brunoerg [~brunoerg@2804:1600:100:1f00:9d6b:24db:99c4:546e] has joined #bitcoin-core-dev
16:31 -!- brunoerg [~brunoerg@2804:1600:100:1f00:9d6b:24db:99c4:546e] has quit [Remote host closed the connection]
16:48 -!- zeropoint [~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net] has quit [Quit: leaving]
16:54 -!- VonNaturAustreVe [~natur@2804:14c:65d7:8f6e:d016:5a64:247c:5e04] has joined #bitcoin-core-dev
16:54 -!- VonNaturAustreVe [~natur@user/vonnaturaustreve] has changed host
17:24 -!- brunoerg [~brunoerg@2804:1600:100:1f00:9d6b:24db:99c4:546e] has joined #bitcoin-core-dev
17:28 -!- brunoerg [~brunoerg@2804:1600:100:1f00:9d6b:24db:99c4:546e] has quit [Ping timeout: 265 seconds]
17:49 -!- eval-exec [~Thunderbi@104.160.45.106.16clouds.com] has joined #bitcoin-core-dev
18:30 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
18:44 -!- __DuBPiRaTe__ [~E_bomb@2600:6c50:7f7f:d89a:2ecf:67ff:fe08:b362] has quit [Remote host closed the connection]
19:48 -!- VonNaturAustreVe [~natur@user/vonnaturaustreve] has quit [Ping timeout: 265 seconds]
20:21 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
20:24 -!- kevkevin_ [~kevkevin@209-242-39-30.rev.dls.net] has quit [Ping timeout: 272 seconds]
20:31 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has quit [Quit: Connection closed for inactivity]
20:59 -!- eval-exec [~Thunderbi@104.160.45.106.16clouds.com] has quit [Ping timeout: 265 seconds]
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:23 -!- emcy__ [~emcy@85.255.235.25] has quit [Remote host closed the connection]
21:23 -!- emcy__ [~emcy@85.255.235.25] has joined #bitcoin-core-dev
22:01 -!- mcey_ [~emcy@85.255.235.25] has joined #bitcoin-core-dev
22:04 -!- emcy__ [~emcy@85.255.235.25] has quit [Ping timeout: 265 seconds]
22:04 -!- eval-exec [~Thunderbi@104.160.45.106.16clouds.com] has joined #bitcoin-core-dev
22:10 -!- ion-_ [ion-@user/ion-] has joined #bitcoin-core-dev
22:13 -!- ion- [ion-@user/ion-] has quit [Ping timeout: 252 seconds]
22:14 -!- ion-_ [ion-@user/ion-] has quit [Remote host closed the connection]
22:14 -!- ion- [ion-@user/ion-] has joined #bitcoin-core-dev
22:17 -!- ion- [ion-@user/ion-] has quit [Remote host closed the connection]
22:30 -!- pablomartin4btc [~pablomart@91.196.223.101] has quit [Ping timeout: 252 seconds]
22:35 -!- ion- [ion-@user/ion-] has joined #bitcoin-core-dev
22:39 -!- ion- [ion-@user/ion-] has quit [Ping timeout: 260 seconds]
22:52 -!- ion- [ion-@user/ion-] has joined #bitcoin-core-dev
23:30 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Remote host closed the connection]
23:31 -!- VonNaturAustreVe [~natur@user/vonnaturaustreve] has joined #bitcoin-core-dev
23:36 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
23:36 -!- VonNaturAustreVe [~natur@user/vonnaturaustreve] has quit [Ping timeout: 248 seconds]
23:41 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Ping timeout: 276 seconds]
--- Log closed Fri Sep 27 00:00:04 2024