--- Log opened Thu Oct 03 00:00:10 2024
00:07 -!- brunoerg [~brunoerg@179.130.8.158] has joined #bitcoin-core-dev
00:12 -!- brunoerg [~brunoerg@179.130.8.158] has quit [Ping timeout: 248 seconds]
00:18 -!- ion- [~ion-@user/ion-] has quit [Remote host closed the connection]
00:18 -!- ion- [~ion-@user/ion-] has joined #bitcoin-core-dev
00:25 -!- brunoerg [~brunoerg@179.130.8.158] has joined #bitcoin-core-dev
00:31 -!- brunoerg [~brunoerg@179.130.8.158] has quit [Ping timeout: 255 seconds]
00:44 -!- brunoerg [~brunoerg@179.130.8.158] has joined #bitcoin-core-dev
00:44 -!- ion- [~ion-@user/ion-] has quit [Remote host closed the connection]
00:44 -!- ion- [~ion-@user/ion-] has joined #bitcoin-core-dev
00:49 -!- brunoerg [~brunoerg@179.130.8.158] has quit [Ping timeout: 252 seconds]
00:49 -!- ion- [~ion-@user/ion-] has quit [Ping timeout: 265 seconds]
00:53 -!- ion- [~ion-@user/ion-] has joined #bitcoin-core-dev
01:02 -!- brunoerg [~brunoerg@179.130.8.158] has joined #bitcoin-core-dev
01:10 -!- brunoerg [~brunoerg@179.130.8.158] has quit [Ping timeout: 272 seconds]
01:13 -!- ion- [~ion-@user/ion-] has quit [Remote host closed the connection]
01:14 -!- ion- [~ion-@user/ion-] has joined #bitcoin-core-dev
01:20 -!- ion- [~ion-@user/ion-] has quit [Ping timeout: 265 seconds]
01:22 -!- brunoerg [~brunoerg@179.130.8.158] has joined #bitcoin-core-dev
01:28 -!- brunoerg [~brunoerg@179.130.8.158] has quit [Ping timeout: 252 seconds]
01:32 -!- ion- [~ion-@user/ion-] has joined #bitcoin-core-dev
01:37 -!- ion-_ [~ion-@user/ion-] has joined #bitcoin-core-dev
01:39 -!- ion- [~ion-@user/ion-] has quit [Ping timeout: 252 seconds]
01:40 -!- brunoerg [~brunoerg@189.4.30.230] has joined #bitcoin-core-dev
01:42 -!- ion-_ [~ion-@user/ion-] has quit [Ping timeout: 244 seconds]
01:42 -!- ion- [~ion-@user/ion-] has joined #bitcoin-core-dev
01:43 -!- ___nick___ [~quassel@82-132-213-141.dab.02.net] has joined #bitcoin-core-dev
01:46 -!- brunoerg [~brunoerg@189.4.30.230] has quit [Ping timeout: 276 seconds]
01:47 -!- ion- [~ion-@user/ion-] has quit [Ping timeout: 244 seconds]
01:47 -!- ion- [~ion-@user/ion-] has joined #bitcoin-core-dev
01:50 -!- brunoerg [~brunoerg@189.4.30.230] has joined #bitcoin-core-dev
01:52 -!- ion- [~ion-@user/ion-] has quit [Ping timeout: 244 seconds]
01:52 -!- ion- [~ion-@user/ion-] has joined #bitcoin-core-dev
01:56 -!- brunoerg [~brunoerg@189.4.30.230] has quit [Ping timeout: 265 seconds]
01:57 -!- ion- [~ion-@user/ion-] has quit [Ping timeout: 265 seconds]
01:57 -!- ion- [~ion-@user/ion-] has joined #bitcoin-core-dev
02:00 -!- ion-_ [~ion-@user/ion-] has joined #bitcoin-core-dev
02:02 -!- ion- [~ion-@user/ion-] has quit [Ping timeout: 265 seconds]
02:02 -!- ion- [~ion-@user/ion-] has joined #bitcoin-core-dev
02:05 -!- ion-_ [~ion-@user/ion-] has quit [Ping timeout: 265 seconds]
02:08 -!- brunoerg [~brunoerg@179.130.8.158] has joined #bitcoin-core-dev
02:09 -!- ion- [~ion-@user/ion-] has quit [Ping timeout: 265 seconds]
02:13 -!- brunoerg [~brunoerg@179.130.8.158] has quit [Ping timeout: 252 seconds]
02:22 -!- ion- [~ion-@user/ion-] has joined #bitcoin-core-dev
02:26 -!- brunoerg [~brunoerg@189.4.30.230] has joined #bitcoin-core-dev
02:32 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Remote host closed the connection]
02:32 -!- brunoerg [~brunoerg@189.4.30.230] has quit [Ping timeout: 260 seconds]
02:44 -!- brunoerg [~brunoerg@179.130.8.158] has joined #bitcoin-core-dev
02:46 -!- eval-exec [~Thunderbi@104.160.46.186.16clouds.com] has quit [Ping timeout: 260 seconds]
02:49 -!- brunoerg [~brunoerg@179.130.8.158] has quit [Ping timeout: 252 seconds]
02:51 -!- brunoerg [~brunoerg@189.4.30.230] has joined #bitcoin-core-dev
02:57 -!- brunoerg [~brunoerg@189.4.30.230] has quit [Ping timeout: 260 seconds]
03:03 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
03:08 -!- brunoerg [~brunoerg@179.130.8.158] has joined #bitcoin-core-dev
03:09 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Ping timeout: 252 seconds]
03:24 -!- ion-_ [~ion-@user/ion-] has joined #bitcoin-core-dev
03:25 -!- ion- [~ion-@user/ion-] has quit [Ping timeout: 272 seconds]
03:28 -!- ion-_ [~ion-@user/ion-] has quit [Remote host closed the connection]
03:29 -!- ion- [~ion-@user/ion-] has joined #bitcoin-core-dev
03:34 -!- ion- [~ion-@user/ion-] has quit [Ping timeout: 244 seconds]
03:39 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
03:45 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Ping timeout: 260 seconds]
03:46 -!- ion- [~ion-@user/ion-] has joined #bitcoin-core-dev
03:51 -!- __DuBPiRaTe__ [~E_bomb@2600:6c50:7f7f:d89a:2ecf:67ff:fe08:b362] has joined #bitcoin-core-dev
03:54 -!- brunoerg [~brunoerg@179.130.8.158] has quit [Remote host closed the connection]
04:00 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
04:05 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Ping timeout: 265 seconds]
04:10 -!- brunoerg [~brunoerg@189.4.30.230] has joined #bitcoin-core-dev
04:17 -!- brunoerg [~brunoerg@189.4.30.230] has quit [Ping timeout: 264 seconds]
04:20 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
04:25 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Ping timeout: 252 seconds]
04:28 -!- brunoerg [~brunoerg@189.4.30.230] has joined #bitcoin-core-dev
04:31 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
04:33 -!- ion- [~ion-@user/ion-] has quit [Ping timeout: 245 seconds]
04:34 -!- brunoerg [~brunoerg@189.4.30.230] has quit [Ping timeout: 255 seconds]
04:36 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Ping timeout: 255 seconds]
04:38 < bitcoin-git> [bitcoin] Sjors opened pull request #31023: Add -pausebackgroundsync startup option (master...2024/10/pause-background-sync) https://github.com/bitcoin/bitcoin/pull/31023
04:47 -!- brunoerg [~brunoerg@179.130.8.158] has joined #bitcoin-core-dev
04:47 -!- ion- [~ion-@user/ion-] has joined #bitcoin-core-dev
04:48 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
04:52 -!- brunoerg [~brunoerg@179.130.8.158] has quit [Ping timeout: 252 seconds]
04:53 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Ping timeout: 265 seconds]
05:02 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
05:02 -!- ion- [~ion-@user/ion-] has quit [Remote host closed the connection]
05:03 -!- ion- [~ion-@user/ion-] has joined #bitcoin-core-dev
05:04 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Remote host closed the connection]
05:05 -!- brunoerg [~brunoerg@179.130.8.158] has joined #bitcoin-core-dev
05:09 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
05:11 -!- brunoerg [~brunoerg@179.130.8.158] has quit [Ping timeout: 245 seconds]
05:12 -!- trumae [~Thunderbi@170.231.88.214] has joined #bitcoin-core-dev
05:14 -!- ion- [~ion-@user/ion-] has quit [Remote host closed the connection]
05:15 -!- ion- [~ion-@user/ion-] has joined #bitcoin-core-dev
05:28 -!- brunoerg [~brunoerg@179.130.8.158] has joined #bitcoin-core-dev
05:33 -!- ion- [~ion-@user/ion-] has quit [Remote host closed the connection]
05:33 -!- ion- [~ion-@user/ion-] has joined #bitcoin-core-dev
05:38 -!- brunoerg [~brunoerg@179.130.8.158] has quit [Remote host closed the connection]
05:40 -!- ion- [~ion-@user/ion-] has quit [Ping timeout: 244 seconds]
05:42 < bitcoin-git> [bitcoin] AgusR7 opened pull request #31025: mempool_accept.py changes (master...master) https://github.com/bitcoin/bitcoin/pull/31025
05:43 -!- jirijakes [~jirijakes@118.150.148.23] has quit [Ping timeout: 265 seconds]
05:53 -!- ion- [~ion-@user/ion-] has joined #bitcoin-core-dev
05:56 -!- aleggg [~aleggg@187.113.241.163] has quit [Ping timeout: 252 seconds]
05:57 -!- aleggg [~aleggg@187.113.241.163] has joined #bitcoin-core-dev
06:00 -!- ion- [~ion-@user/ion-] has quit [Ping timeout: 260 seconds]
06:03 < bitcoin-git> [bitcoin] fanquake opened pull request #31026: ci: set a ctest test timeout of 1200 (20 minutes) (master...ctest_actually_set_timeout) https://github.com/bitcoin/bitcoin/pull/31026
06:08 -!- aleggg [~aleggg@187.113.241.163] has quit [Ping timeout: 260 seconds]
06:11 -!- ion- [~ion-@user/ion-] has joined #bitcoin-core-dev
06:16 -!- ion- [~ion-@user/ion-] has quit [Ping timeout: 272 seconds]
06:17 < bitcoin-git> [bitcoin] RandyMcMillan closed pull request #30993: doc/build-osx.md:brew relinking note (master...2001/863168/294116/d812cf1189/1e0e06f98d) https://github.com/bitcoin/bitcoin/pull/30993
06:26 < Sjors[m]> It appears some projects are experiencing issues with #27101 even though they shouldn't.
06:26 <@gribble> https://github.com/bitcoin/bitcoin/issues/27101 | Support JSON-RPC 2.0 when requested by client by pinheadmz · Pull Request #27101 · bitcoin/bitcoin · GitHub
06:27 < Sjors[m]> E.g. https://github.com/vansergen/rpc-bitcoin/pull/65
06:27 < pinheadmz> ruh roh
06:27 < Sjors[m]> In this case it seems to be that we insist the version is a string?
06:27 < Sjors[m]> Which might be a breaking change.
06:27 -!- ion- [~ion-@user/ion-] has joined #bitcoin-core-dev
06:28 < Sjors[m]> Might want to hold off on announcing v28.0 until that's more clear.
06:28 < pinheadmz> i dont think their original code `jsonrpc: 1.0` would ever have been valid. 
06:29 < pinheadmz> before 2.0 the key was "version" anyway
06:30 < Sjors[m]> pinheadmz: maybe invalid, but ignored? And now it triggers an error?
06:31 < pinheadmz> http://www.simple-is-better.org/rpc/#differences-between-1-0-and-2-0
06:31 < pinheadmz> yeah ignored before, type-checked now
06:31 < pinheadmz> what do you recco? remove the type check before release?
06:32 < Sjors[m]> I think the spirit of 27101 was to not change behavior for < 2.0 JSON. So maybe indeed skip the type check.
06:32 < Sjors[m]> Though maybe run it in case you see 2.0 in stead of "2.0".
06:33 -!- eval-exec [~Thunderbi@104.160.46.186.16clouds.com] has joined #bitcoin-core-dev
06:33 < andytoshi> i would suggest treating the string "2.0" as meaning 2.0, and literally anything else (including the number 2) as 1.0
06:33 < fanquake> I think I'm missing something. Their code was always incorrect right? jsonrpc is a 2.0 only, thing, and always needs to be a string (per the spec)
06:33 < andytoshi> maybe you could log a warning if you see the number 2, to be nice
06:33 < Sjors[m]> Right, at least do a warning otherwise I think confusion is guaranteed.
06:34 < fanquake> So why would we relax our requirements to handle someone incorrectly trying to do 2.0 ?
06:34 < fanquake> Or is that not what's happening here
06:34 -!- ion- [~ion-@user/ion-] has quit [Ping timeout: 244 seconds]
06:34 < Sjors[m]> fanquake: no there are 1.0 clients
06:34 < Sjors[m]> * these
06:34 < pinheadmz> a 1.0 client SHOULD include "version": "1.0"
06:34 < fanquake> yes but jsonrpc doesn't exist in 1.0 right?
06:34 < pinheadmz> fanquake correct AFAICT
06:35 < fanquake> so how can a 1.0 client be sending json rpc with a 2.0 int
06:35 < fanquake> *jsonrpc
06:35 < andytoshi> fanquake: they're sending a 1.0 int
06:35 < fanquake> right, so they are just sending something not even in the spec
06:36 < andytoshi> correct
06:37 < Sjors[m]> https://github.com/lightningnetwork/lnd/issues/9053
06:37 < Sjors[m]> Been open for a month, but it seems nobody pinged us.
06:38 < fanquake> Regardless of what we decide to do here. v28.0 has already been tagged, just not annouced. So if further changes want to be made, it'll be in a 28.0.1 or similar.
06:40 < Sjors[m]> Actually the Lnd issue might be a different one.
06:40 < pinheadmz> i think it is, fork observer hit that as well
06:41 < pinheadmz> https://github.com/0xB10C/fork-observer/pull/46
06:41 < andytoshi> i think the current behavior is totally reasonable. but if we were having this conversation a month ago i'd have a mild preference for just allowing random crap like this in 1.0
06:42 < andytoshi> (btw i checked my own jsonrpc impl, and i have been using the string "2.0" for years)
06:42 < sipa> andytoshi: i agree
06:43 < sipa> the fact that apparently some clients are in violation of the spec doesn't change the fact that this change made by us breaks things for them
06:43 < sipa> but indeed, 28.0 is already out; depending on how hard it is for these few projects to adapt, i could see us doing a 28.0.1
06:44 -!- ion- [~ion-@user/ion-] has joined #bitcoin-core-dev
06:47 < pinheadmz> damn sorry folks
06:47 < sipa> pinheadmz: not your fault
06:47 < pinheadmz> i blame jsonrpc
06:47 < pinheadmz> they changed "version" to "jsonrpc"
06:47 < pinheadmz> instead of just bumping the version number - who does that
06:48 < Sjors[m]> Javascript people :-)
06:48 < pinheadmz> ha!
06:48 < pinheadmz> jsonrpc: 1.00000000000003
06:48 < sipa> hahahaha
06:53 < jonatack> Sjors[m]: :D
06:54 < jonatack> (agree with andytoshi and sipa)
06:55 < Sjors[m]> I think rpc-bitcoin can fix things very quickly. But it's an NPM package, so who knows how much stuff out there uses an old version.
06:56 < Sjors[m]> Oh, by "very quickly" I mean there's a PR with enough review, but their last release is from 2020. 
06:57 < Sjors[m]> https://www.npmjs.com/package/rpc-bitcoin
06:58 < achow101> we can do a 28.1 if this is a problem that majorly affects people
06:59 < achow101> but I don't think there should be anything for us to do other than to keep an eye out for complaints
07:00 < jonatack> the zen of release management
07:00 < Sjors[m]> This library has been setting jsonrpc: 1.0 for more than 5 years. And it's being downloaded 1000+ times a week according NPM. My guess is this will break a lot of htings. 
07:00 < achow101> #startmeeting
07:00 < achow101> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard aureleoules b10c BlueMatt brunoerg cfields darosior dergoegge dongcarl fanquake fjahr furszy gleb glozow hebasto instagibbs jamesob jarolrod jonatack josibake kallewoof kanzure kouloumos kvaciral laanwj LarryRuane lightlike luke-jr MacroFake Murch phantomcircuit pinheadmz promag provoostenator ryanofsky sdaftuar S3RK stickies-v sipa sr_gi theStack TheCharlatan vasild
07:00 < Sjors[m]> hi
07:00 < josie> hiya
07:00 < hebasto> hi
07:01 < sipa> o meeting time, hi
07:01 < achow101> There are no pre-proposed meeting topics this week. Any last minute ones to add?
07:01 < b10c> hi
07:01 < stickies-v> hi
07:01 < jonatack> hi
07:02 < glozow> hi
07:02 < emzy> hi
07:02 -!- kashifs [~kashifs@2603:7000:4600:500:a57e:982a:2001:ab5b] has joined #bitcoin-core-dev
07:02 < kanzure> hi
07:02 < Sjors[m]> RPC gate topic?
07:02 < achow101> #topic Ad-hoc high priority for review
07:02 < achow101> Anything to add or remove from https://github.com/orgs/bitcoin/projects/1/views/4
07:03 < pinheadmz> Hi and
07:04 < achow101> Also 28.0 was tagged, please guix build
07:04 < pinheadmz> Shana tova
07:04 < sipa> guix build fails for me, something apparmor
07:04 < sipa> https://gist.github.com/laanwj/cddb2ec7d18e71066d21e5ee993fe971 does not help
07:04 < dergoegge> hi
07:05 < lightlike> Hi
07:05 < fjahr> hi
07:07 < achow101> #topic rpc (Sjors)
07:07 < Sjors[m]> sipa https://bugs.launchpad.net/ubuntu/+source/guix/+bug/2064115/comments/6
07:07 < Sjors[m]> (I think I did something very slighlyt different than the gist, but forgot, see that comment)
07:08 < sipa> i shall try
07:08 < Sjors[m]> From right before the meeting, we noticed that the bitcoin-rpc NPM package is broken: https://github.com/vansergen/rpc-bitcoin/pull/65
07:09 < abubakarsadiq> hi
07:09 < Sjors[m]> As an unintende side-effect of #27101
07:09 <@gribble> https://github.com/bitcoin/bitcoin/issues/27101 | Support JSON-RPC 2.0 when requested by client by pinheadmz · Pull Request #27101 · bitcoin/bitcoin · GitHub
07:09 < sipa> and apparently there are also issues due to the warnings field now being an array?
07:09 < Sjors[m]> The idea was the be strict about JSON RPC 2.0, but remain loose for earlier stuff.
07:10 < Sjors[m]> sipa: possibly, maybe that should also be 2.0 - only behavior?  
07:11 < achow101> Since 28.0 is already tagged, any changes to these would be in a 28.1
07:11 < Sjors[m]> But the binaries are not release yet, so it could be 28.0.1 release.
07:11 -!- ion- [~ion-@user/ion-] has quit [Remote host closed the connection]
07:12 < b10c> the warnings string -> array change was in #29845
07:12 <@gribble> https://github.com/bitcoin/bitcoin/issues/29845 | rpc: return warnings as an array instead of just a single one by stickies-v · Pull Request #29845 · bitcoin/bitcoin · GitHub
07:12 -!- ion- [~ion-@user/ion-] has joined #bitcoin-core-dev
07:12 -!- ion- [~ion-@user/ion-] has quit [Remote host closed the connection]
07:12 < achow101> Sjors[m]: x.0.1 releases have typically done for build issues and without release candidates. Fixing this problem seems like it might be involved enough to want to do at least one rc
07:12 < Sjors[m]> There's probably a limit to how much effort we should put into remaining backwards compatible with very old RPC clients, but these one or two things seem reasonable to fix imo.
07:13 < Sjors[m]> True, we could also ship 28.0 and warn people to be very careful about upgrading if they're using the RPC.
07:13 -!- ion- [~ion-@user/ion-] has joined #bitcoin-core-dev
07:13 < achow101> the warnings string to array was done with a deprecation cycle
07:14 < Sjors[m]> Ok, in that case I think only the 1.0 thing should be fixed.
07:14 -!- aleggg [~aleggg@187.113.241.163] has joined #bitcoin-core-dev
07:14 < sipa> it also means fewer things are affected?
07:15 < sipa> i guess we should proceed with releasing 28.0 normally, perhaps with a warning in the release notes about this issue, and then see if we get many reports
07:15 < achow101> We can add more to the release notes about the jsonrpc 2.0 issue
07:16 < achow101> actually, the warnings string to array is currently in the deprecation cycle. it's not gone yet.
07:16 < Sjors[m]> So deprecatedrpc for the warning thing is now removed?
07:16 < Chris_Stewart_5> hi
07:17 < jonatack> In current master I still see deprecatedrpc=warnings
07:17 < stickies-v> (the warnings string -> array change and -deprecatedrpc=warnings option is documented in the 28.0 release notes, btw)
07:17 < b10c> -deprecatedrpc=warnings should give the old behavior
07:17 < jonatack> so users have the option
07:18 < Sjors[m]> I'm trying to find out if people who run into the 1.0 issue also rely on -deprecatedrpc=warnings.
07:18 < achow101> we've followed our typical process for breaking rpc for that, so I think it's fine to leave alone
07:18 < sipa> agree
07:18 < Sjors[m]> Because they'll have to deal with both at some point in the near future.
07:18 < jonatack> Yes. It may be 
07:18 < jonatack> good to give it a couple releases before removing, no hurry
07:18 < sipa> we could highlight it more in the release notes, perhaps a section in the very beginning mentioning both the jsonrpc version and warning field thing
07:20 -!- ion- [~ion-@user/ion-] has quit [Ping timeout: 265 seconds]
07:20 < stickies-v> the warnings change is also documented in the rpc docs already, so that + existing docs in release notes probably feels like enough documentation to me? but of course no objection to mentioning it at the beginning of the release notes too
07:20 < achow101> sipa: ack
07:20 < stickies-v> the jsonrpc thing is probably a bit more obscure for users to figure out so i think highlighting that more seems sensible
07:22 < stickies-v> https://github.com/bitcoin/bitcoin/blob/cfb59da4b3bb34afae467691a3e901f2b5a186f3/src/rpc/net.cpp#L663-L664
07:23 < achow101> The release notes draft can still be edited: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/28.0-Release-Notes-Draft
07:23 < achow101> i'll pull in any further changes to the announce pr after the binaries are uploaded (waiting for more guix builds though)
07:23 < achow101> and open a pr to update the in repo notes
07:24 < achow101> website pr: https://github.com/bitcoin-core/bitcoincore.org/pull/1067
07:24 -!- bugs_ [~bugs@user/bugs/x-5128603] has joined #bitcoin-core-dev
07:25 < achow101> Any other topics to discuss?
07:25 < jonatack> achow101: wiki edits to the release notes during the day today worth making then? 
07:25 < achow101> jonatack: yes
07:25 < Chris_Stewart_5> can someone merge #30982 ? we discussed last week and i've edited teh release notes to add the instructions in the PR
07:25 <@gribble> https://github.com/bitcoin/bitcoin/issues/30982 | docs: Add instructions on how to self-sign bitcoin-core binaries for macOS by Christewart · Pull Request #30982 · bitcoin/bitcoin · GitHub
07:25 < jonatack> also, i had these URLs pinned for the blockers:
07:25 < jonatack> https://github.com/orgs/bitcoin/projects/1/views/1
07:26 < jonatack> https://github.com/orgs/bitcoin/projects/5/views/1
07:26 < jonatack> iiuc the current URL is now
07:26 < jonatack> https://github.com/orgs/bitcoin/projects/1/views/4
07:26 < jonatack> ?
07:26 < achow101> Chris_Stewart_5: will look
07:26 -!- willcl-ark_ [~willcl-ar@trow-07-b2-v4wan-169656-cust740.vm26.cable.virginm.net] has joined #bitcoin-core-dev
07:26 < Chris_Stewart_5> :+1:
07:27 < achow101> jonatack: first and third links are the same project, just different views. see the tabs at the top
07:27 < achow101> I think the other project board (url 2) is not being used
07:27 < jonatack> achow101: ty
07:29 < achow101> #endmeeting
07:29 -!- willcl-ark [~willcl-ar@user/willcl-ark] has quit [Ping timeout: 255 seconds]
07:32 < achow101> Chris_Stewart_5: need to get people to ack it, not just concept ack it
07:32 -!- ion- [~ion-@user/ion-] has joined #bitcoin-core-dev
07:33 -!- willcl-ark_ [~willcl-ar@trow-07-b2-v4wan-169656-cust740.vm26.cable.virginm.net] has quit [Ping timeout: 252 seconds]
07:35 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
07:39 -!- achow101 [~achow101@user/achow101] has quit [Ping timeout: 272 seconds]
07:40 -!- achow101_ [~achow101@user/achow101] has joined #bitcoin-core-dev
07:42 -!- pablomartin [~pablomart@89.37.175.232] has joined #bitcoin-core-dev
07:42 -!- willcl-ark [~willcl-ar@trow-07-b2-v4wan-169656-cust740.vm26.cable.virginm.net] has joined #bitcoin-core-dev
07:42 -!- willcl-ark [~willcl-ar@user/willcl-ark] has changed host
07:49 -!- ion- [~ion-@user/ion-] has quit [Ping timeout: 265 seconds]
07:52 -!- Robotico [~101@82.red-88-20-121.staticip.rima-tde.net] has joined #bitcoin-core-dev
07:54 -!- Robotico [~101@82.red-88-20-121.staticip.rima-tde.net] has quit [Client Quit]
07:56 -!- ___nick___ [~quassel@82-132-213-141.dab.02.net] has quit [Remote host closed the connection]
07:56 -!- ___nick___ [~quassel@82-132-213-141.dab.02.net] has joined #bitcoin-core-dev
08:00 -!- ion- [~ion-@user/ion-] has joined #bitcoin-core-dev
08:06 -!- ion- [~ion-@user/ion-] has quit [Ping timeout: 244 seconds]
08:11 -!- brunoerg [~brunoerg@189.16.46.213] has joined #bitcoin-core-dev
08:13 -!- mcey [~emcy@148.252.129.143] has quit [Read error: Connection reset by peer]
08:14 -!- mcey [~emcy@148.252.129.143] has joined #bitcoin-core-dev
08:14 -!- mcey [~emcy@148.252.129.143] has quit [Remote host closed the connection]
08:18 -!- brunoerg [~brunoerg@189.16.46.213] has quit [Ping timeout: 260 seconds]
08:19 -!- ion- [~ion-@user/ion-] has joined #bitcoin-core-dev
08:23 < sipa> Sjors[m]: can you share your /etc/apparmor.d/guix file?
08:24 -!- ion- [~ion-@user/ion-] has quit [Ping timeout: 265 seconds]
08:35 -!- Robotico [~101@82.red-88-20-121.staticip.rima-tde.net] has joined #bitcoin-core-dev
08:35 -!- Robotico [~101@82.red-88-20-121.staticip.rima-tde.net] has quit [Remote host closed the connection]
08:37 -!- ion- [~ion-@user/ion-] has joined #bitcoin-core-dev
08:42 < bitcoin-git> [bitcoin] fanquake closed pull request #31025: mempool_accept.py changes (master...master) https://github.com/bitcoin/bitcoin/pull/31025
08:48 < Sjors[m]> sipa: https://zerobin.org/?5f09e5233089ca5c#EAgrH16u2ru8vHmcwgTndncTRzge8WLm8vkrpwjL41Hc
08:51 -!- brunoerg [~brunoerg@189.2.246.37] has joined #bitcoin-core-dev
08:51 < sipa> Sjors[m]: so i did two things, i added both the ...-guix-command and /usr/bin/guix to the apparmor.d/guix file, and fixed a bug in my aa-enforce (which is what caused that error you're seeing up running aa-enforce)
08:51 < sipa> and now it works
08:51 < sipa> but i'm not sure which of the two did it
08:51 < sipa> but just putting ...-guix-command there was not enough
08:51 < Sjors[m]> I'm just as mystified. Plus I always forget what I did a few months after.
08:52 < Sjors[m]> I generally google some error, find my own issue.
08:53 -!- pablomartin [~pablomart@89.37.175.232] has quit [Remote host closed the connection]
08:54 -!- pablomartin [~pablomart@89.37.175.232] has joined #bitcoin-core-dev
08:56 < sipa> ok, the bug in aa-enforce is already fixed upstream: https://gitlab.com/apparmor/apparmor/-/merge_requests/1218
09:03 -!- preimage [~halosghos@user/halosghost] has joined #bitcoin-core-dev
09:20 < lightlike> could someone ban Theghost256 ? they're approving PRs in bulk, creating notification spam
09:22 -!- brunoerg [~brunoerg@189.2.246.37] has quit [Remote host closed the connection]
09:24 < fanquake> should be blocked now
09:41 -!- johnny9dev584508 [~johnny9de@136.54.93.132] has quit [Quit: Ping timeout (120 seconds)]
09:42 -!- johnny9dev584508 [~johnny9de@136.54.93.132] has joined #bitcoin-core-dev
09:49 -!- trumae [~Thunderbi@170.231.88.214] has quit [Ping timeout: 252 seconds]
09:52 -!- ___nick___ [~quassel@82-132-213-141.dab.02.net] has quit [Ping timeout: 252 seconds]
09:55 < bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cfb59da4b3bb...772928a13c2d
09:55 < bitcoin-git> bitcoin/master 27709f5 Chris Stewart: docs: Add instructions on how to self-sign bitcoin-core binaries for macOS
09:55 < bitcoin-git> bitcoin/master 772928a Ava Chow: Merge bitcoin/bitcoin#30982: docs: Add instructions on how to self-sign bi...
09:55 < bitcoin-git> [bitcoin] achow101 merged pull request #30982: docs: Add instructions on how to self-sign bitcoin-core binaries for macOS (master...2024-09-26-selfsign-mac-instructions) https://github.com/bitcoin/bitcoin/pull/30982
09:59 < achow101_> Updated the release notes draft to mention the rpc compatibility issue
09:59 -!- achow101_ is now known as achow101
10:09 -!- trumae [~Thunderbi@170.231.88.214] has joined #bitcoin-core-dev
10:10 -!- ion- [~ion-@user/ion-] has quit [Ping timeout: 260 seconds]
10:14 -!- ___nick___ [~quassel@82-132-212-188.dab.02.net] has joined #bitcoin-core-dev
10:14 -!- ion- [~ion-@user/ion-] has joined #bitcoin-core-dev
10:14 -!- pablomartin4btc [~pablomart@91.196.223.63] has joined #bitcoin-core-dev
10:14 -!- pablomartin [~pablomart@89.37.175.232] has quit [Ping timeout: 252 seconds]
10:18 -!- ion- [~ion-@user/ion-] has quit [Ping timeout: 264 seconds]
10:30 -!- ion- [~ion-@user/ion-] has joined #bitcoin-core-dev
10:33 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
10:34 -!- kashifs [~kashifs@2603:7000:4600:500:a57e:982a:2001:ab5b] has quit [Quit: Client closed]
10:36 -!- ion- [~ion-@user/ion-] has quit [Ping timeout: 265 seconds]
10:47 -!- ion- [~ion-@user/ion-] has joined #bitcoin-core-dev
10:54 -!- ion- [~ion-@user/ion-] has quit [Ping timeout: 264 seconds]
10:55 < bitcoin-git> [bitcoin] marcofleon opened pull request #31028: fuzz: Add fuzz-only build mode option for targets (master...2024/10/fuzzonly-build-mode-option) https://github.com/bitcoin/bitcoin/pull/31028
11:02 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has quit [Quit: Connection closed for inactivity]
11:07 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [Closing Window]
11:07 -!- ion- [~ion-@user/ion-] has joined #bitcoin-core-dev
11:17 -!- josie [~josibake@suhail.uberspace.de] has quit [Read error: Connection reset by peer]
11:19 -!- josie [~josibake@suhail.uberspace.de] has joined #bitcoin-core-dev
11:26 -!- ___nick___ [~quassel@82-132-212-188.dab.02.net] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
11:29 -!- ___nick___ [~quassel@82-132-212-188.dab.02.net] has joined #bitcoin-core-dev
11:29 -!- ___nick___ [~quassel@82-132-212-188.dab.02.net] has quit [Client Quit]
11:32 -!- ___nick___ [~quassel@82-132-212-188.dab.02.net] has joined #bitcoin-core-dev
11:51 -!- trumae [~Thunderbi@170.231.88.214] has quit [Remote host closed the connection]
11:55 -!- qxs [~qxs@gateway/tor-sasl/qxs] has quit [Remote host closed the connection]
11:55 -!- qxs [~qxs@gateway/tor-sasl/qxs] has joined #bitcoin-core-dev
12:01 -!- Talkless [~Talkless@mail.dargis.net] has quit [Remote host closed the connection]
12:13 -!- ion- [~ion-@user/ion-] has quit [Remote host closed the connection]
12:18 < laanwj> sipa: what error are you getting from apparmor? (dmesg will usually have more detailed info on what action was denied)
12:19 < bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/772928a13c2d...f117f3f74738
12:19 < bitcoin-git> bitcoin/master 9123a28 Hennadii Stepanov: qt6: Handle deprecated `QLocale::nativeCountryName`
12:19 < bitcoin-git> bitcoin/master f117f3f Hennadii Stepanov: Merge bitcoin-core/gui#838: qt6: Handle deprecated `QLocale::nativeCountry...
12:19 < bitcoin-git> [gui] hebasto merged pull request #838: qt6: Handle deprecated `QLocale::nativeCountryName` (master...240929-qt6-locale) https://github.com/bitcoin-core/gui/pull/838
12:30 -!- ion- [~ion-@user/ion-] has joined #bitcoin-core-dev
12:36 -!- ion- [~ion-@user/ion-] has quit [Ping timeout: 244 seconds]
12:47 < laanwj> i wonder if i forgot something in https://gist.github.com/laanwj/cddb2ec7d18e71066d21e5ee993fe971 , it worked for me (it allows guix to create a user namespace and otherwise keeps it unconfined) but i've heard from more people it didn't for them
12:48 -!- ion- [~ion-@user/ion-] has joined #bitcoin-core-dev
13:04 -!- ___nick___ [~quassel@82-132-212-188.dab.02.net] has quit [Ping timeout: 252 seconds]
13:07 -!- brunoerg [~brunoerg@179.191.241.5] has joined #bitcoin-core-dev
13:12 -!- brunoerg [~brunoerg@179.191.241.5] has quit [Ping timeout: 260 seconds]
13:24 < sipa> laanwj: is it normal that upon running aa-enforce, the "flags=(unconfirmed)" disappears?
13:26 < laanwj> sipa:   flags=(unconfined), you mean? and no, it shouldn't disappear IIRC, it's important that it is unconfined... how are you checking this? also: which guix are you using, is the main binary installed in /usr/bin/guix ? the absolute path needs to be correct
13:27 < sipa> ehh, now i get
13:27 < sipa> substitute: /usr/lib/x86_64-linux-gnu/guix/guile: error while loading shared libraries: libguile-3.0.so.1: cannot open shared object file: Permission denied
13:28 < sipa> guix time-machine: error: `/usr/bin/guix substitute' died unexpectedly
13:29 < sipa> laanwj: guix is installed from ubuntu repository, Ubuntu 24.04.1 LTS, version 1.4.0-6build1
13:29 < sipa> i did "guix pull" first
13:29 < laanwj> ok yes that's where the guix package installs it, same one i'm using
13:29 < sipa> there is /usr/bin/guix, but also my user has a ~/.config/guix/current/bin/guix (which is what "which guix" reports)
13:30 < sipa> which is a symlink to /home/pw/.config/guix/current/bin/guix
13:33 < sipa> aa-enforce [name], apparently really works on $(which [name])
13:34 < laanwj> looking at.the naming convention of the other guix.files, maybe  /etc/apparmor.d/guix needs to be called /etc/apparmor.d/usr.bin.guix. ... though i don't remember doing this
13:34 < sipa> i don't believe this matters
13:36 < laanwj> i don't know if it's possible to make it affect the one in your homedir too
13:36 < laanwj> maybe just a matter. of specifying the full path though
13:36 < sipa> so, i created an apparmor.d/guix file, with binary name /gnu/store/c9a2snygcp9iywbncwky5jcjp29x3hsw-guix-command
13:36 < sipa> i ran /etc/init.d/apparmor reload
13:37 < sipa> and then ran "aa-enforce /gnu/store/c9a2snygcp9iywbncwky5jcjp29x3hsw-guix-command"
13:37 < sipa> this reports: Profile for /gnu/store/c9a2snygcp9iywbncwky5jcjp29x3hsw-guix-command not found, skipping
13:37 < sipa> after which, the apparmor.d/guix file has changed; the binary name is now /home/pw/.config/guix/current/bin/guix (despite me running aa-enforce as root, not even in sudo), and the "flags=(unconfined)" is gone
13:38 < laanwj> strange
13:38 < laanwj> wait, it edits the file in /etc?!?
13:39 < laanwj> i'm really confused now, i must say i haven't tried this in a while on ubuntu
13:40 < sipa> yes, it edits the /etc/apparmor.d/guix file
13:40 < laanwj> i didn't know aa-enforce changed the configuration, i thought it just enabled the profile in the kernel
13:45 < sipa> laanwj: i'm starting to suspect that aa-enforce actually *only* changes the config file, and then tell apparmor to reload it
13:46 < sipa> (evidence being that aa-enforce failed for Sjors[m], but guix building still succeeded)
13:48 < sipa> ok, made an /etc/apparmor.d/guix file with "profile guix /gnu/store/c9a2snygcp9iywbncwky5jcjp29x3hsw-guix-command flags=(unconfined)", did /etc/init.d/apparmor reload, and guix-build works now...
13:57 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has quit [Quit: PaperSword]
14:01 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:184f:1955:1f96:f023] has joined #bitcoin-core-dev
14:01 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has joined #bitcoin-core-dev
14:01 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:184f:1955:1f96:f023] has quit [Remote host closed the connection]
14:02 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has quit [Client Quit]
14:03 -!- brunoerg [~brunoerg@187.183.60.117] has joined #bitcoin-core-dev
14:08 -!- brunoerg [~brunoerg@187.183.60.117] has quit [Ping timeout: 265 seconds]
14:10 -!- l0rinc [~l0rinc@94.44.119.53] has joined #bitcoin-core-dev
14:20 -!- l0rinc [~l0rinc@94.44.119.53] has quit [Quit: Client closed]
14:36 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:184f:1955:1f96:f023] has joined #bitcoin-core-dev
14:40 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:184f:1955:1f96:f023] has quit [Ping timeout: 265 seconds]
14:49 -!- bugs_ [~bugs@user/bugs/x-5128603] has quit [Quit: Leaving]
14:54 -!- trumae [~Thunderbi@170.231.88.214] has joined #bitcoin-core-dev
15:03 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has joined #bitcoin-core-dev
15:05 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Remote host closed the connection]
15:08 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:184f:1955:1f96:f023] has joined #bitcoin-core-dev
15:16 -!- preimage [~halosghos@user/halosghost] has quit [Quit: WeeChat 4.4.2]
15:17 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
15:35 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
15:56 -!- eval-exec [~Thunderbi@104.160.46.186.16clouds.com] has quit [Remote host closed the connection]
15:56 -!- eval-exec [~Thunderbi@n058153177120.netvigator.com] has joined #bitcoin-core-dev
16:04 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
16:06 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
16:59 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
16:59 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
17:45 -!- trumae [~Thunderbi@170.231.88.214] has quit [Ping timeout: 272 seconds]
18:12 -!- __DuBPiRaTe__ [~E_bomb@2600:6c50:7f7f:d89a:2ecf:67ff:fe08:b362] has quit [Quit: Leaving]
18:54 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Remote host closed the connection]
18:55 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
18:59 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Ping timeout: 252 seconds]
19:04 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
19:24 < bitcoin-git> [bitcoin] AgusR7 opened pull request #31030: test: use context managers and add file existence checks in feature_fee_estimation.py (master...master) https://github.com/bitcoin/bitcoin/pull/31030
19:49 < bitcoin-git> [bitcoin] dollarparity opened pull request #31031: doc: clarify 'filename' argument in 'loadwallet' RPC (master...patch-1) https://github.com/bitcoin/bitcoin/pull/31031
19:56 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has quit [Ping timeout: 245 seconds]
20:03 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has joined #bitcoin-core-dev
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:51 -!- achow101 [~achow101@user/achow101] has quit [Quit: Bye]
21:51 -!- achow101 [~achow101@user/achow101] has joined #bitcoin-core-dev
22:13 -!- ion- [~ion-@user/ion-] has quit [Remote host closed the connection]
22:13 -!- ion- [~ion-@user/ion-] has joined #bitcoin-core-dev
22:18 -!- ion- [~ion-@user/ion-] has quit []
22:24 -!- ion- [~ion-@user/ion-] has joined #bitcoin-core-dev
22:24 -!- ion- [~ion-@user/ion-] has quit [Remote host closed the connection]
22:24 -!- ion- [ion-@user/ion-] has joined #bitcoin-core-dev
22:47 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Remote host closed the connection]
23:14 < laanwj> <sipa> "ok, made an /etc/apparmor.d/guix..." <- glad to hear that, i'll remove the suggestion for aa-enforce, just making apparmor reload the configuration should be enough after manually updating it
23:18 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
23:19 < laanwj> i'm surprised the upstream launchpad issue still has had no attention, on the other hand the apparmor update broke so incredibly many things (every user-space app that used user namespaces), i wonder if they're going to revert this at some point
23:24 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Ping timeout: 252 seconds]
23:52 -!- eval-exec [~Thunderbi@n058153177120.netvigator.com] has quit [Quit: eval-exec]
23:57 -!- ion- [ion-@user/ion-] has quit [Remote host closed the connection]
23:58 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
--- Log closed Fri Oct 04 00:00:10 2024