--- Log opened Wed Oct 09 00:00:15 2024
00:12 -!- dongcarl [~dongcarl@syn-066-065-169-019.res.spectrum.com] has quit [Read error: Connection reset by peer]
00:15 -!- dongcarl [~dongcarl@syn-066-065-169-019.res.spectrum.com] has joined #bitcoin-core-dev
01:03 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has quit [Remote host closed the connection]
01:49 < hebasto> maflcko: could you please look into https://cirrus-ci.com/github/bitcoin/bitcoin/pull%2F30997? it seems like a kind of issues with depends sources cache
02:04 -!- jirijakes [~jirijakes@118.150.148.23] has joined #bitcoin-core-dev
02:09 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e569eb8d9173...5fb94550638d
02:09 < bitcoin-git> bitcoin/master ca2e4ba Cory Fields: refactor: include the proper header rather than forward-declaring RemovalR...
02:09 < bitcoin-git> bitcoin/master 5fb9455 merge-script: Merge bitcoin/bitcoin#31058: refactor: include the proper header rather th...
02:09 < bitcoin-git> [bitcoin] fanquake merged pull request #31058: refactor: include the proper header rather than forward-declaring RemovalReasonToString (master...fix-pch-forward-declare) https://github.com/bitcoin/bitcoin/pull/31058
02:14 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
02:18 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Ping timeout: 252 seconds]
02:24 -!- ppisati [~flag@81.56.89.175] has quit [Ping timeout: 252 seconds]
02:25 -!- ppisati [~flag@81.56.89.175] has joined #bitcoin-core-dev
02:35 -!- eval-exec1 [~Thunderbi@107.182.189.58.16clouds.com] has joined #bitcoin-core-dev
02:36 -!- eval-exec [~Thunderbi@107.182.189.58.16clouds.com] has quit [Remote host closed the connection]
02:36 -!- eval-exec1 is now known as eval-exec
04:04 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
04:35 < bitcoin-git> [bitcoin] maflcko opened pull request #31061:  refactor: Check original (translatable) format string at compile-time  (master...2410-trans) https://github.com/bitcoin/bitcoin/pull/31061
04:36 -!- danoprey [~danoprey@2601:8c:4b80:e110:d19c:bc7f:6b5a:4807] has quit [Quit: Client closed]
04:56 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection]
04:57 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
05:09 -!- mcey_ [~emcy@185.69.145.134] has joined #bitcoin-core-dev
05:12 -!- mcey [~emcy@85.255.237.162] has quit [Ping timeout: 264 seconds]
05:19 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
05:32 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection]
05:33 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
05:38 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection]
05:38 -!- vasild_ [~vd@user/vasild] has joined #bitcoin-core-dev
06:05 < bitcoin-git> [bitcoincore.org] dergoegge opened pull request #1074: Security advisories for vulnerabilities fixed in v25.0 (master...2024-10-october-bugs) https://github.com/bitcoin-core/bitcoincore.org/pull/1074
06:25 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:d180:8445:e492:6834] has quit [Ping timeout: 244 seconds]
06:25 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Remote host closed the connection]
06:42 -!- ___nick___ [~quassel@82-132-213-165.dab.02.net] has joined #bitcoin-core-dev
06:43 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:d180:8445:e492:6834] has joined #bitcoin-core-dev
06:43 -!- ___nick___ [~quassel@82-132-213-165.dab.02.net] has quit [Client Quit]
06:46 -!- ___nick___ [~quassel@82-132-213-165.dab.02.net] has joined #bitcoin-core-dev
06:47 -!- preimage [~halosghos@user/halosghost] has joined #bitcoin-core-dev
06:47 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
06:47 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Remote host closed the connection]
08:25 -!- jonatack [~jonatack@user/jonatack] has quit [Quit: WeeChat 4.4.2]
08:33 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
08:36 -!- bugs_ [~bugs@user/bugs/x-5128603] has joined #bitcoin-core-dev
08:47 -!- Chris_Stewart_5 [~Chris_Ste@static-68-235-44-41.cust.tzulo.com] has quit [Ping timeout: 265 seconds]
08:49 -!- Chris_Stewart_5 [~Chris_Ste@static-68-235-44-40.cust.tzulo.com] has joined #bitcoin-core-dev
09:05 < bitcoin-git> [bitcoin] maflcko opened pull request #31063: lint: commit-script-check.sh: echo to stderr (master...2410-lint-echo-stderr) https://github.com/bitcoin/bitcoin/pull/31063
09:08 -!- maxedw__ is now known as maxedw
09:20 < bitcoin-git> [bitcoin] maflcko closed pull request #29745: bench: Adds a benchmark for CheckInputScripts (master...benchCheckInputScripts) https://github.com/bitcoin/bitcoin/pull/29745
09:26 < bitcoin-git> [bitcoin] maflcko closed pull request #29540: validation: Use witness maleation flag for non-segwit blocks (master...pr29524) https://github.com/bitcoin/bitcoin/pull/29540
09:43 -!- ___nick___ [~quassel@82-132-213-165.dab.02.net] has quit [Ping timeout: 276 seconds]
09:52 -!- Artea [~Lufia@vps.artea.ovh] has quit [Quit: ZNC 1.8.2 - https://znc.in]
09:58 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [Closing Window]
10:17 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
10:32 < bitcoin-git> [bitcoincore.org] achow101 pushed 4 commits to master: https://github.com/bitcoin-core/bitcoincore.org/compare/2c96576f787c...b601352e42a7
10:32 < bitcoin-git> bitcoincore.org/master 2261f43 0xb10c: posts: disclose large inv-to-send DoS
10:32 < bitcoin-git> bitcoincore.org/master 3d6c7fb 0xb10c: posts: Disclose mutated blocks hindering propagation
10:32 < bitcoin-git> bitcoincore.org/master 47d7110 dergoegge: posts: Disclose blocktxn assert crash
10:32 < bitcoin-git> [bitcoincore.org] achow101 merged pull request #1074: Security advisories for vulnerabilities fixed in v25.0 (master...2024-10-october-bugs) https://github.com/bitcoin-core/bitcoincore.org/pull/1074
10:47 -!- Guest74 [~Guest68@2800:a4:245e:6000:c008:a3cb:8477:51a] has joined #bitcoin-core-dev
10:50 -!- Guest74 [~Guest68@2800:a4:245e:6000:c008:a3cb:8477:51a] has quit [Client Quit]
10:50 -!- Guest32 [~Guest68@2800:a4:245e:6000:c008:a3cb:8477:51a] has joined #bitcoin-core-dev
10:52 -!- Guest32 [~Guest68@2800:a4:245e:6000:c008:a3cb:8477:51a] has quit [Client Quit]
11:07 -!- emzy [~quassel@user/emzy] has quit [Remote host closed the connection]
11:07 -!- upekkha [~Advanced@2a01:4f8:1c0c:49df::1] has quit [Remote host closed the connection]
11:08 -!- emzy [~quassel@user/emzy] has joined #bitcoin-core-dev
11:08 -!- upekkha [~Advanced@2a01:4f8:1c0c:49df::1] has joined #bitcoin-core-dev
11:40 -!- metta [~Advanced@2a01:4f8:1c0c:49df::1] has joined #bitcoin-core-dev
11:42 -!- upekkha [~Advanced@2a01:4f8:1c0c:49df::1] has quit [Ping timeout: 252 seconds]
12:42 -!- Talkless [~Talkless@mail.dargis.net] has quit [Remote host closed the connection]
13:11 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
13:51 < Chris_Stewart_5> trying to upgrade to 28.0, running into issues with the behavior with failing to start when a port (18445) is already bound. I've attempted to use -listenonion=0 to get around this, but it doesn't seem to work. My understanding is -listen=0 doesn't allow any p2p connection which isnt what i want
13:52 < Chris_Stewart_5> 2024-10-09T20:41:22Z [net:error] Unable to bind to 127.0.0.1:18445 on this computer. Bitcoin Core is probably already running.
13:52 < Chris_Stewart_5> 2024-10-09T20:41:22Z [error] Unable to bind to 127.0.0.1:18445 on this computer. Bitcoin Core is probably already running.
13:52 < Chris_Stewart_5> 2024-10-09T20:41:22Z [error] Failed to listen on any port. Use -listen=0 if you want this.
13:53 < sipa> is it already bound by bitcoin core itself?
13:53 < sipa> or other software
13:53 < Chris_Stewart_5> Shouldn't listenonion=0 not attempt to bind it in the first place? Or perhaps i'm misunderstanding the setting
13:53 < sipa> i'm not familiar with the option myself
13:56 < Chris_Stewart_5> I'll see if I get a response in IRC and if i don't i'll file an issue. I believe this should be minimally reproducible by attempting to run 2 regtest nodes on the same machine with different -port settings with -listenonion=0
13:58 < Chris_Stewart_5> i.e './bitcoind -regtest -rpcport=12345 -listenonion=0 && ./bitocind -regtest -rpcport=54321 -listenonion=0'
13:58 < Chris_Stewart_5> ah, probably need different -datadir as well
14:01 < Chris_Stewart_5> './bitcoind -regtest -datadir=/tmp/random-1 -port=12345 -rpcport=12346 -listenonion=0 && ./bitcoind -regtest -datadir=/tmp/random-2 -rpcport=54321 -port=54320 -listenonion=0'
14:11 < lightlike> looks related to #22729: "Bitcoin Core will now fail to start up if any of its P2P binds fail, rather than the previous behaviour where it would only abort startup if all P2P binds had failed."
14:11 <@gribble`> https://github.com/bitcoin/bitcoin/issues/22729 | Make it possible to disable Tor binds and abort startup on bind failure by vasild · Pull Request #22729 · bitcoin/bitcoin · GitHub
14:21 < jonatack> (that change may have needed a release note)
14:23 < lightlike> sorry, i wasn't clear, it had release notes (that's how I found out about it). The quote above is from the release notes.
14:25 < jonatack> oh indeed, good: https://github.com/bitcoin/bitcoin/pull/30502
14:26 < lightlike> Chris_Stewart_5: I'm not familiar with this at all, but I see the same behavior. one workaround seems to be using -bind (instead of -port) on one of the nodes.
14:26 < bitcoin-git> [bitcoin] TheCharlatan opened pull request #31064: init: Correct coins db cache size setting (master...patchCoinsDBCacheSizeInit) https://github.com/bitcoin/bitcoin/pull/31064
14:27 < lightlike> FYI @vasild
14:30 -!- preimage [~halosghos@user/halosghost] has quit [Quit: WeeChat 4.4.2]
14:44 < jonatack> Chris_Stewart_5: how are you binding the port initially?
14:46 < jonatack> (feel free to share your config via direct message on irc)
14:59 < Chris_Stewart_5> bitcoin.conf https://pastebin.com/cfGm9hzW  debug.log https://pastebin.com/vUhnj7Rp . This has only been tested on regtest
15:00 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection]
15:00 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
15:18 -!- bugs_ [~bugs@user/bugs/x-5128603] has quit [Quit: Leaving]
15:32 -!- johnzweng [~johnzweng@zweng.at] has quit [Quit: Leaving...]
15:33 -!- johnzweng [~johnzweng@zweng.at] has joined #bitcoin-core-dev
15:46 -!- johnzweng [~johnzweng@zweng.at] has quit [Quit: Leaving...]
15:50 -!- johnzweng [~johnzweng@zweng.at] has joined #bitcoin-core-dev
16:16 -!- cman [~con@180-150-21-3.b49615.mel.static.aussiebb.net] has quit [Quit: Konversation terminated!]
16:18 -!- eval-exec [~Thunderbi@107.182.189.58.16clouds.com] has quit [Remote host closed the connection]
16:19 -!- eval-exec [~Thunderbi@104.245.102.112] has joined #bitcoin-core-dev
16:20 -!- johnzweng [~johnzweng@zweng.at] has quit [Quit: Leaving...]
16:20 -!- S3RK [~S3RK@user/s3rk] has quit [Ping timeout: 272 seconds]
16:22 -!- S3RK [~S3RK@user/s3rk] has joined #bitcoin-core-dev
16:23 -!- johnzweng [~johnzweng@zweng.at] has joined #bitcoin-core-dev
16:26 -!- eval-exec [~Thunderbi@104.245.102.112] has quit [Remote host closed the connection]
16:27 -!- eval-exec [~Thunderbi@5.34.216.98] has joined #bitcoin-core-dev
17:01 < bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5fb94550638d...9909a34d7946
17:01 < bitcoin-git> bitcoin/master 36a6d4b Mackain: doc: update IBD requirements in doc/README.md
17:01 < bitcoin-git> bitcoin/master 9909a34 Ava Chow: Merge bitcoin/bitcoin#30992: doc: update IBD requirements in doc/README.md
17:01 < bitcoin-git> [bitcoin] achow101 merged pull request #30992: doc: update IBD requirements in doc/README.md (master...docs-wording-update) https://github.com/bitcoin/bitcoin/pull/30992
17:20 < bitcoin-git> [bitcoin] achow101 pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/9909a34d7946...0c2c3bb3f5c6
17:20 < bitcoin-git> bitcoin/master 63d6ad7 Sjors Provoost: Move BlockMerkleBranch back to merkle.{h,cpp}
17:20 < bitcoin-git> bitcoin/master 47b4875 Sjors Provoost: Add getCoinbaseMerklePath() to Mining interface
17:20 < bitcoin-git> bitcoin/master 525e9dc Sjors Provoost: Add submitSolution to BlockTemplate interface
17:20 < bitcoin-git> [bitcoin] achow101 merged pull request #30955: Mining interface: getCoinbaseMerklePath() and submitSolution() (master...2024/07/merkle_path) https://github.com/bitcoin/bitcoin/pull/30955
17:32 -!- hashfunc [~user@2601:5c0:c280:7090:c055:1a2b:98ea:e133] has joined #bitcoin-core-dev
17:46 -!- Guest28 [~Guest28@65.181.17.108] has joined #bitcoin-core-dev
17:47 -!- Guest78 [~Guest28@65.181.17.108] has joined #bitcoin-core-dev
17:47 -!- Guest78 [~Guest28@65.181.17.108] has quit [Client Quit]
17:53 -!- Guest68 [~Guest28@65.181.17.108] has joined #bitcoin-core-dev
17:54 -!- Guest68 [~Guest28@65.181.17.108] has quit [Client Quit]
17:54 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Remote host closed the connection]
17:55 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
17:56 -!- Guest28 [~Guest28@65.181.17.108] has quit [Ping timeout: 256 seconds]
19:14 < bitcoin-git> [bitcoincore.org] azuchi opened pull request #1075: Add japanese translations for security advisories fixed in v25.0 (master...ja-translate-security-advisories-25.0) https://github.com/bitcoin-core/bitcoincore.org/pull/1075
19:16 -!- dermoth_ [~dermoth@user/dermoth] has joined #bitcoin-core-dev
19:17 -!- dermoth [~dermoth@user/dermoth] has quit [Remote host closed the connection]
19:21 -!- dermoth_ is now known as dermoth
21:00 < vasild_> Chris_Stewart_5: jonatack: lightlike: sipa: Using port=11222 rpcport=22333 listenonion=0 bitcoind would still try to bind on 127.0.0.1:18445 (for regtest) and listen there for incoming onion connections.
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 < vasild_> thus the conflicting port 18445 when you start more than one bitcoind on the same machine
21:01 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Read error: Connection reset by peer]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:02 < vasild_> this was the case before 28.0 as well, but there the bind error from the second bitcoind did not cause startup failure and most likely remained unnoticed
21:03 < vasild_> the functional tests all had that bind errors but they did not matter because no test is using or needs that 127.0.0.1:18445, now the functional testing framework was tweaked a bit to avoid trying to bind on conflicting ports.
21:05 < vasild_> to avoid the bind on 127.0.0.1:18445 use bind=127.0.0.1:11222 instead of port=11222 (listenonion is irrelevant, can be 0 or 1)
21:06 < vasild_> or bind=0.0.0.0:11222 if you want to listen on all interfaces, but I guess this is not the case with regtest
21:11 < vasild_> What listenonion=1 does is to automatically create the hidden service with the tor daemon, so that users don't have to manually add HiddenServiceDir and HiddenServicePort in their torrc. But it does not control where bitcoind listens, I think a name like -autotorservice would be more appropriate than -listenonion.
21:13 -!- achow101 [~achow101@user/achow101] has quit [Ping timeout: 260 seconds]
21:13 -!- achow101 [~achow101@user/achow101] has joined #bitcoin-core-dev
21:17 < vasild_> A real problem with <28.0 that could happen is this: if two bitcoinds are started on the same machine with "port=10833 rpcport=10832 listenonion=1" and "port=20833 rpcport=20832 listenonion=1", then only the first would manage to bind on 127.0.0.1:8334. The second would "think" it did because the bind error was ignored. Due to listenonion=1 both will create a tor service, telling the tor daemon 
21:17 < vasild_> to redirect incoming connections to that service to 127.0.0.1:8334. For example first.onion:8333 -> 127.0.0.1:8334 and second.onion:8333 -> 127.0.0.1:8334.
21:20 < vasild_> So all incoming tor connections for the second bitcoind would be redirected to the first bitcoind :/
21:21 -!- achow101_ [~achow101@user/achow101] has joined #bitcoin-core-dev
21:21 -!- achow101 [~achow101@user/achow101] has quit [Ping timeout: 276 seconds]
21:22 -!- vasild_ [~vd@user/vasild] has quit [Quit: leaving]
21:22 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
22:11 -!- emcy__ [~emcy@148.252.146.89] has joined #bitcoin-core-dev
22:13 -!- mcey_ [~emcy@185.69.145.134] has quit [Ping timeout: 248 seconds]
22:23 -!- PatBoy [xyz@cryption.cn] has quit [Ping timeout: 276 seconds]
22:23 -!- PatBoy [xyz@cryption.cn] has joined #bitcoin-core-dev
22:29 -!- JTL [~jtl@user/jtl] has quit [Ping timeout: 276 seconds]
22:36 -!- JTL [~jtl@user/jtl] has joined #bitcoin-core-dev
22:36 -!- JTL [~jtl@user/jtl] has quit [Excess Flood]
22:44 -!- JTL [~jtl@user/jtl] has joined #bitcoin-core-dev
22:49 < darosior> Chris_Stewart_5: i faced the same issue when upgrading Liana's functional test framework to 28.0. I fixed it by simply using `-bind` in place of `-port`: https://github.com/wizardsardine/liana/pull/1269/commits/ba553e9ddb104af454d9eff9969c0e37a1f3061a.
22:49 < darosior> Others: i initially wanted to report it here but since it had a release note and a simple fix, i figured the breakage was known and intentional.
23:00 -!- hashfunc [~user@2601:5c0:c280:7090:c055:1a2b:98ea:e133] has quit [Remote host closed the connection]
23:21 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has joined #bitcoin-core-dev
23:29 -!- emcy__ [~emcy@148.252.146.89] has quit [Quit: Leaving]
23:31 -!- mcey [~emcy@148.252.146.89] has joined #bitcoin-core-dev
23:47 -!- javi404 [~quassel@2601:582:0:2c41:91ca:6895:2072:3474] has quit [Ping timeout: 272 seconds]
--- Log closed Thu Oct 10 00:00:16 2024