--- Log opened Thu Nov 14 00:00:49 2024
00:01 -!- gf2718 [~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e] has joined #bitcoin-core-dev
00:11 < vasild> ryanofsky: wrt #31011, it says "Move util/pcp.cpp and util/netif.cpp to common/ because they depend on netaddress.cpp", does it mean anything that depends on netaddress.cpp has to be in common/ ?
00:11 <@gribble> https://github.com/bitcoin/bitcoin/issues/31011 | refactor: move util/pcp and util/netif to common/ by ryanofsky · Pull Request #31011 · bitcoin/bitcoin · GitHub
00:13 < vasild> and how to determine if something depends on netaddress.cpp? I guess "#include <netaddress.h>" is not quite the same since it may only need netaddress.h for e.g. 'enum Network'
00:21 -!- gf2718 [~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e] has quit [Ping timeout: 264 seconds]
00:22 -!- gf2718 [~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e] has joined #bitcoin-core-dev
00:41 -!- eval-exec [~Thunderbi@96.45.190.137.16clouds.com] has quit [Quit: eval-exec]
00:41 -!- eval-exec [~Thunderbi@96.45.189.92.16clouds.com] has joined #bitcoin-core-dev
00:45 -!- spynxic [~spynxic@spynxic.powered.by.lunarbnc.net] has quit [Quit: Free ZNC ~ Powered by LunarBNC: https://LunarBNC.net]
00:45 -!- spynxic [~spynxic@spynxic.powered.by.lunarbnc.net] has joined #bitcoin-core-dev
01:03 -!- l0rinc [~l0rinc@95C84685.dsl.pool.telekom.hu] has joined #bitcoin-core-dev
01:19 -!- gmaxwell [~gmaxwell@user/gmaxwell] has quit [Ping timeout: 252 seconds]
01:34 -!- gf2718 [~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e] has quit [Ping timeout: 264 seconds]
01:35 -!- gmaxwell [~gmaxwell@user/gmaxwell] has joined #bitcoin-core-dev
01:44 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/422825929437...69c031344404
01:44 < bitcoin-git> bitcoin/master e80e4c6 TheCharlatan: validation: Remove RECENT_CONSENSUS_CHANGE validation result
01:44 < bitcoin-git> bitcoin/master 69c0313 merge-script: Merge bitcoin/bitcoin#31269: validation: Remove RECENT_CONSENSUS_CHANGE va...
01:44 < bitcoin-git> [bitcoin] fanquake merged pull request #31269: validation: Remove RECENT_CONSENSUS_CHANGE validation result (master...rmRecentConsensusChange) https://github.com/bitcoin/bitcoin/pull/31269
01:47 -!- gf2718 [~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e] has joined #bitcoin-core-dev
02:07 -!- eval-exec [~Thunderbi@96.45.189.92.16clouds.com] has quit [Ping timeout: 272 seconds]
02:14 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has joined #bitcoin-core-dev
02:18 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/69c031344404...f44e39c9d0da
02:18 < bitcoin-git> bitcoin/master 184f34f Ryan Ofsky: util: Support dynamic width & precision in ConstevalFormatString
02:18 < bitcoin-git> bitcoin/master fe39acf Ryan Ofsky: tinyformat: Add compile-time checking for literal format strings
02:18 < bitcoin-git> bitcoin/master f44e39c merge-script: Merge bitcoin/bitcoin#31174: tinyformat: Add compile-time checking for lit...
02:18 < bitcoin-git> [bitcoin] fanquake merged pull request #31174: tinyformat: Add compile-time checking for literal format strings (master...pr/tcheck) https://github.com/bitcoin/bitcoin/pull/31174
02:26 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f44e39c9d0da...e546b4e1a0c5
02:26 < bitcoin-git> bitcoin/master ac286e0 secp512k2: doc: Fix grammatical errors in multisig-tutorial.md
02:26 < bitcoin-git> bitcoin/master e546b4e merge-script: Merge bitcoin/bitcoin#31225: doc: Fix grammatical errors in multisig-tutor...
02:26 < bitcoin-git> [bitcoin] fanquake merged pull request #31225: doc: Fix grammatical errors in multisig-tutorial.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/31225
03:03 -!- gf2718 [~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e] has quit [Ping timeout: 260 seconds]
03:08 -!- gf2718 [~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e] has joined #bitcoin-core-dev
03:09 < laanwj> vasild: i think any use of netaddress.h is considered "use of netaddress.cpp" in this context, we don't distinguish header versus implementation usage because it further complicates dependency tracking
03:10 < vasild> ok, easy ;)
03:29 -!- Guest82 [~Guest82@176.59.102.56] has joined #bitcoin-core-dev
03:35 -!- Guest82 [~Guest82@176.59.102.56] has quit [Quit: Client closed]
03:35 -!- Dmitri [~Dmitri@176.59.102.56] has joined #bitcoin-core-dev
03:36 -!- Dmitri [~Dmitri@176.59.102.56] has quit [Client Quit]
03:37 -!- Dmitri [~Dmitri@176.59.102.56] has joined #bitcoin-core-dev
03:39 -!- Dmitri [~Dmitri@176.59.102.56] has quit [Client Quit]
03:47 < bitcoin-git> [bitcoin] maflcko opened pull request #31287: refactor: Avoid std::string format strings (master...2411-check-fmt) https://github.com/bitcoin/bitcoin/pull/31287
04:08 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
04:18 -!- gf2718 [~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e] has quit [Ping timeout: 276 seconds]
04:23 -!- gf2718 [~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e] has joined #bitcoin-core-dev
04:30 -!- l0rinc [~l0rinc@95C84685.dsl.pool.telekom.hu] has quit [Quit: Client closed]
04:31 -!- gf2718 [~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e] has quit [Ping timeout: 248 seconds]
04:34 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [Closing Window]
04:44 -!- gf2718 [~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e] has joined #bitcoin-core-dev
05:28 -!- eval-exec [~Thunderbi@96.45.190.137.16clouds.com] has joined #bitcoin-core-dev
05:33 -!- pablomartin [~pablomart@155.133.17.140] has joined #bitcoin-core-dev
05:36 < bitcoin-git> [bitcoin] Sjors closed pull request #31003: Add waitFeesChanged() to Mining interface (master...2024/07/mining-fees-changed) https://github.com/bitcoin/bitcoin/pull/31003
05:52 < bitcoin-git> [bitcoin] Sjors opened pull request #31288: Add destroy to BlockTemplate schema (master...2024/11/destroy) https://github.com/bitcoin/bitcoin/pull/31288
05:52 < bitcoin-git> [bitcoin] hodlinator closed pull request #30737: test: Fix RANDOM_CTX_SEED use with parallel tests (master...2024-08/RANDOM_CTX_SEED_jobs_fix_alt) https://github.com/bitcoin/bitcoin/pull/30737
05:56 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
05:58 -!- gf2718 [~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e] has quit [Ping timeout: 252 seconds]
05:58 -!- sliv3r__ [~sliv3r__@user/sliv3r-:76883] has joined #bitcoin-core-dev
06:00 -!- nymius [~nymius@169.150.198.86] has joined #bitcoin-core-dev
06:00 < achow101> #startmeeting
06:00 < tdb3> hi
06:00 < abubakarsadiq> hi
06:00 < josie> hi
06:00 < achow101> #bitcoin-core-dev Meeting: abubakarsadiq achow101 _aj_ ajonas b10c brunoerg cfields darosior dergoegge fanquake fjahr furszy gleb glozow hebasto instagibbs jarolrod jonatack josibake kanzure laanwj LarryRuane lightlike luke-jr maflcko maxedw Murch pinheadmz provoostenator ryanofsky sdaftuar S3RK stickies-v sipa sr_gi tdb3 theStack TheCharlatan vasild willcl-ark
06:00 < sipa> hi
06:00 < sliv3r__> hi
06:00 < theStack> hi
06:00 < TheCharlatan> hi
06:00 < vasild> hi
06:00 < b10c> hi
06:00 < kevkevin> hi
06:00 < sdaftuar> hi
06:00 < willcl-ark> hi
06:00 < achow101> There are no pre-proposed meeting topics this week. Any last minute ones to add?
06:00 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Quit: Leaving...]
06:01 < BlueMatt[m]> Is Sjors here?
06:01 < gleb> Hi
06:01 < maxedw> hi
06:01 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
06:01 < kevkevin> hi
06:01 < achow101> BlueMatt[m]: doesn't seem like it yet
06:01 < brunoerg> hi
06:02 < achow101> #topic Erlay WG Update (sr_gi, gleb, marcofleon)
06:02 < stickies-v> hi
06:02 -!- nymius [~nymius@169.150.198.86] has quit [Client Quit]
06:02 < gleb> On erlay side I guess that’s me
06:03 < kanzure> hi
06:03 < gleb> We’re having some productive discussions on moving forward in the WG chat, especially how to think of spy nodes; and how to think of the efficiency
06:04 -!- nymius [~nymius@169.150.198.86] has joined #bitcoin-core-dev
06:04 < gleb> In-pr sergi is reviewing a lot of my comments. I know several contributors are waiting for that to resolve first
06:04 < gleb> I’m spinning up test nodes for others to connect to. Thinking Warnet or not
06:04 < gleb> That’s it!
06:05 < achow101> #topic Kernel WG Update (TheCharlatan)
06:05 < josie> gleb: feel free to reach out if you want a warnet onboarding / crash course
06:05 < TheCharlatan> Nothing new today, thank you for the quick reviews on #31269
06:05 <@gribble> https://github.com/bitcoin/bitcoin/issues/31269 | validation: Remove RECENT_CONSENSUS_CHANGE validation result by TheCharlatan · Pull Request #31269 · bitcoin/bitcoin · GitHub
06:05 < achow101> #topic Benchmarking WG Update (josie, l0rinc)
06:05 < josie> made progress on getting a mainnet assumeutxo bench running automatically when a PR is opened. the benchmark now automatically does benchcoin master vs PR branch (h/t willcl-ark)
06:05 < josie> the final results are published to a github page, with flamegraphs included (h/t davidgumberg)
06:05 < josie> Novo___ and i will be using the new setup this next week to investigate the batch validatoin PR
06:05 < josie> we are also at the stage where having extra dedicated runners would be helpful. was planning to purchase some more hetzner boxes and add them, but a few people mentioned having some resources that could be used for this, planning to follow up on that this week
06:06 < josie> thats all!
06:06 < achow101> #topic Silent Payments WG Update (josie, RubenSomsen)
06:06 < josie> slow and steady, working through all the feedback on the libsecp256k1 module
06:06 < josie> i do remember on the musig2 PR, there was a suggestion on how we type arrays of unsigned char where it is expected to be an exact size. it seemed doing this could be useful for languages like rust, when generating bindings automatically?
06:06 < josie> planning to follow up with the secp256k1 maintainers to see if this is worth doing for the silent payments module (perhaps a topic for the upcoming secp256k1 meeting this coming monday?)
06:06 < josie> thats all!
06:06 < sipa> josie: yeah, definitely worth bringing up
06:06 < achow101> #topic Cluster Mempool WG Update (sdaftuar, sipa)
06:07 < sdaftuar> hi, #31122 is still the PR to review. it seems to be getting close. 
06:07 < josie> sipa: will do! 
06:07 <@gribble> https://github.com/bitcoin/bitcoin/issues/31122 | cluster mempool: Implement changeset interface for mempool by sdaftuar · Pull Request #31122 · bitcoin/bitcoin · GitHub
06:07 < sdaftuar> i think pieter is getting closer with his txgraph implementation as well -- will let him add any additional info
06:07 < sipa> i'm close to opening the first txgraph PR (the middle layer between cluster linearization algorithms, and the mempool, which deals with dependencies/clusters/linearizations/proposed changes for the entire mempool)
06:08 < sipa> nothing else from me
06:09 < achow101> #topic MuSig2 WG Update (achow101)
06:09 < achow101> We had a discussion about breaking up #29675, so i've opened 2 refactors (#31242, #31243) and a PR for the PSBT fields (#31247)
06:09 <@gribble> https://github.com/bitcoin/bitcoin/issues/29675 | wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys by achow101 · Pull Request #29675 · bitcoin/bitcoin · GitHub
06:09 <@gribble> https://github.com/bitcoin/bitcoin/issues/31242 | wallet, desc spkm: Return SigningProvider only if we have the privkey by achow101 · Pull Request #31242 · bitcoin/bitcoin · GitHub
06:09 <@gribble> https://github.com/bitcoin/bitcoin/issues/31243 | descriptor: Move filling of keys from `DescriptorImpl::MakeScripts` to `PubkeyProvider::GetPubKey` by achow101 · Pull Request #31243 · bitcoin/bitcoin · GitHub
06:10 <@gribble> https://github.com/bitcoin/bitcoin/issues/31247 | psbt: MuSig2 Fields by achow101 · Pull Request #31247 · bitcoin/bitcoin · GitHub
06:10 < achow101> The descriptors implementation is also in a separate draft PR ##31244, and 29675 is the final that require all of the above and adds signing
06:10 <@gribble> https://github.com/bitcoin/bitcoin/issues/31244 | descriptors: MuSig2 by achow101 · Pull Request #31244 · bitcoin/bitcoin · GitHub
06:10 < achow101> #topic Legacy Wallet Removal WG Update (achow101)
06:12 -!- gf2718 [~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e] has joined #bitcoin-core-dev
06:12 < achow101> Also had a discussion about breaking up #28710, so there's now the migration test rework in #31248, and #31250 has legacy wallets disabled but not removed
06:12 <@gribble> https://github.com/bitcoin/bitcoin/issues/28710 | Remove the legacy wallet and BDB dependency by achow101 · Pull Request #28710 · bitcoin/bitcoin · GitHub
06:12 <@gribble> https://github.com/bitcoin/bitcoin/issues/31248 | test: Rework wallet_migration.py to use previous releases by achow101 · Pull Request #31248 · bitcoin/bitcoin · GitHub
06:12 <@gribble> https://github.com/bitcoin/bitcoin/issues/31250 | wallet: Disable creating and loading legacy wallets by achow101 · Pull Request #31250 · bitcoin/bitcoin · GitHub
06:13 < achow101> furszy has opened #31241 as well
06:13 <@gribble> https://github.com/bitcoin/bitcoin/issues/31241 | wallet: remove BDB dependency from wallet migration benchmark by furszy · Pull Request #31241 · bitcoin/bitcoin · GitHub
06:13 < jonatack> hi
06:13 < achow101> that's all for working groups that i see here
06:14 < achow101> Anything else to discuss?
06:14 < instagibbs> shoutout to all the ephemeral dust review, not exactly a topic
06:15 < vasild> achow101: I guess that once legacy wallet is removed (in 29?) softwares that use Bitcoin Core's wallet but don't support descriptor wallets will have to stick to v28?
06:15 < josie> instagibbs: congrats on moving that forward! 
06:15 < achow101> vasild: yes
06:15 < vasild> ok
06:16 < sipa> vasild, achow101: though there are some RPCs we could realistically implement for descriptor wallets which are legacy-only currently (see #30175
06:16 <@gribble> https://github.com/bitcoin/bitcoin/issues/30175 | Enable `importprivkey`, `addmultisigaddress` in descriptor wallets · Issue #30175 · bitcoin/bitcoin · GitHub
06:17 < jonatack> hi again (first one didn't seem to get through)
06:17 < vasild> https://github.com/JoinMarket-Org/joinmarket-clientserver/issues/1571#issuecomment-2102790757 "JoinMarket uses importmulti call, which is not available for descriptor wallets"
06:17 -!- jonatack [~jonatack@user/jonatack] has quit [Quit: WeeChat 4.4.3]
06:17 < sipa> translating importmulti is not impossible, but it'd be a nontrivial amount of work, and i don't think many things besides joinmarket use it?
06:18 < sipa> it'd be easier i expect to make joinmarket use importdescriptors instead
06:18 < achow101> presumably the problem is that they don't create descriptors
06:19 < vasild> I think it is possible to do custom gap limits
06:19 < vasild> with descriptor wallets
06:19 < achow101> yeah, they can do things manually with keypoolrefill
06:20 < achow101> i'll leave a comment on that issue
06:20 < laanwj> sipa: i don't think so either, joinmarket is the only common software that's stuck at pre-descriptor wallets, that i know of
06:20 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
06:21 < achow101> #endmeeting
06:22 -!- jon_atack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
06:23 -!- jon_atack [~jonatack@user/jonatack] has quit [Client Quit]
06:23 -!- nymius [~nymius@user/nymius] has changed host
06:23 < nymius> bye
06:24 -!- nymius [~nymius@user/nymius] has quit [Quit: nymius]
06:24 < theStack> electrum personal server is also still relying on pre-descriptor wallets, fwiw (not sure how much it is used those days though)
06:24 -!- jon_atack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
06:25 -!- jon_atack [~jonatack@user/jonatack] has quit [Client Quit]
06:25 < laanwj> theStack: do you by any chance know what RPCs it's using that are missing for descriptors wallets?
06:25 -!- jon_atack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
06:26 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 272 seconds]
06:27 < theStack> laanwj: IIRC, it was also importmulti
06:27 < theStack> (see e.g. https://github.com/chris-belcher/electrum-personal-server/issues/269 )
06:28 < achow101> I imagine that getting changes into electrum personal server may be difficult given belcher's health issues
06:28 < theStack> yeah :/
06:31 -!- nymius [~nymius@169.150.198.86] has joined #bitcoin-core-dev
06:34 -!- nymius [~nymius@169.150.198.86] has quit [Client Quit]
06:37 -!- jon_atack [~jonatack@user/jonatack] has quit [Read error: Connection reset by peer]
06:38 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
06:54 < laanwj> yea :/ doesn't look like there's an actively maintained fork, either
07:04 -!- sliv3r__ [~sliv3r__@user/sliv3r-:76883] has quit [Ping timeout: 256 seconds]
07:10 -!- dzxzg [~dzxzg@user/dzxzg] has joined #bitcoin-core-dev
07:13 -!- jonatack [~jonatack@user/jonatack] has quit [Remote host closed the connection]
07:14 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
07:16 -!- dzxzg [~dzxzg@user/dzxzg] has quit [Ping timeout: 256 seconds]
07:23 -!- gf2718 [~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e] has quit [Ping timeout: 252 seconds]
07:24 -!- gf2718 [~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e] has joined #bitcoin-core-dev
07:30 -!- gf2718 [~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e] has quit [Ping timeout: 276 seconds]
07:30 < bitcoin-git> [bitcoin] lulapainho opened pull request #31290: feati: mais moeda (master...master) https://github.com/bitcoin/bitcoin/pull/31290
07:31 < bitcoin-git> [bitcoin] fanquake closed pull request #31290: feati: mais moeda (master...master) https://github.com/bitcoin/bitcoin/pull/31290
07:33 -!- bugs_ [~bugs@user/bugs/x-5128603] has joined #bitcoin-core-dev
07:34 < instagibbs> ^ nation states like Brazil trying to stack
07:44 -!- gf2718 [~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e] has joined #bitcoin-core-dev
07:50 -!- gf2718 [~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e] has quit [Ping timeout: 260 seconds]
07:52 -!- rsantacroce [~textual@62.37.183.70] has joined #bitcoin-core-dev
07:56 < brunoerg> instagibbs: should i be proud of it?
07:59 -!- rsantacroce [~textual@62.37.183.70] has quit [Quit: Textual IRC Client: www.textualapp.com]
07:59 -!- gf2718 [~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e] has joined #bitcoin-core-dev
08:04 -!- gf2718 [~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e] has quit [Ping timeout: 265 seconds]
08:16 -!- gf2718 [~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e] has joined #bitcoin-core-dev
08:28 -!- jarthur [~jarthur@user/jarthur] has joined #bitcoin-core-dev
08:31 -!- zeropoint [~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
08:37 -!- eval-exec [~Thunderbi@96.45.190.137.16clouds.com] has quit [Ping timeout: 260 seconds]
09:47 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Remote host closed the connection]
09:48 -!- jamesob443688173 [~jamesob@108.44.248.162] has quit [Quit: The Lounge - https://thelounge.chat]
09:48 -!- jamesob15 [~jamesob@108.44.248.162] has quit [Quit: The Lounge - https://thelounge.chat]
09:52 -!- jamesob443688173 [~jamesob@108.44.248.162] has joined #bitcoin-core-dev
09:52 -!- jamesob15 [~jamesob@108.44.248.162] has joined #bitcoin-core-dev
10:00 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
10:00 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
10:04 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Ping timeout: 260 seconds]
10:09 -!- gf2718 [~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e] has quit [Ping timeout: 248 seconds]
10:29 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/e546b4e1a0c5...2d944e982c47
10:30 < bitcoin-git> bitcoin/master cdf34be fanquake: guix: remove util-linux
10:30 < bitcoin-git> bitcoin/master 4d66854 fanquake: ci: remove util-linux from centos CI
10:30 < bitcoin-git> bitcoin/master 2d944e9 merge-script: Merge bitcoin/bitcoin#31285: guix: remove `util-linux`
10:30 < bitcoin-git> [bitcoin] fanquake merged pull request #31285: guix: remove `util-linux` (master...remove_util_linux) https://github.com/bitcoin/bitcoin/pull/31285
11:50 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
11:53 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 260 seconds]
11:53 -!- qxs [~qxs@gateway/tor-sasl/qxs] has quit [Ping timeout: 260 seconds]
11:54 -!- qxs [~qxs@gateway/tor-sasl/qxs] has joined #bitcoin-core-dev
12:00 < bitcoin-git> [gui-qml] pablomartin4btc opened pull request #433: Persist proxy settings to settings.json (main...qml-proxy-settings-persistence) https://github.com/bitcoin-core/gui-qml/pull/433
12:05 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
12:05 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has quit [Quit: PaperSword]
12:06 -!- gf2718 [~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e] has joined #bitcoin-core-dev
12:11 -!- gf2718 [~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e] has quit [Ping timeout: 260 seconds]
12:11 -!- jarthur [~jarthur@user/jarthur] has quit [Read error: Connection reset by peer]
12:21 -!- Talkless [~Talkless@mail.dargis.net] has quit [Remote host closed the connection]
13:06 -!- Guest16 [~Guest16@2804:1e68:c211:b236:a58f:d5f3:117a:ae46] has joined #bitcoin-core-dev
13:06 -!- Guest16 [~Guest16@2804:1e68:c211:b236:a58f:d5f3:117a:ae46] has quit [Client Quit]
13:12 < bitcoin-git> [bitcoin] furszy opened pull request #31291: test: add global time to place exec tests within the same dir (master...2024_test_global_path) https://github.com/bitcoin/bitcoin/pull/31291
13:19 < darosior> how do i enable the debug symbols but keep an optimized build with cmake?
13:20 < darosior> what im trying to achieve: having enough information for `perf` but keeping the optimizations so the flamegraph actually reflects reality
13:20 < sipa> my understanding is that that is the default: the default built type is RelWithDebInfo
13:21 < sipa> does running cmake say "CMAKE_BUILD_TYPE ...................... RelWithDebInfo
13:22 < bitcoin-git> [bitcoin] casey opened pull request #31292: Add `contrib/justfile` containing useful development workflow commands. (master...justfile) https://github.com/bitcoin/bitcoin/pull/31292
13:22 < darosior> Yeah, so looks like the problem is elsewhere.
13:24 < darosior> readelf also says my binary has them
13:25 < darosior> Ah, i just didn't have the kernel debug symbols on this new machine. If anyone's coming back to read this: apt install linux-image-`uname -r`-dbg did the trick.
13:31 < bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2d944e982c47...1a8f51e7453c
13:31 < bitcoin-git> bitcoin/master 192dac1 TheCharlatan: [refactor] Cleanup BlockAssembler mempool usage
13:31 < bitcoin-git> bitcoin/master 1a8f51e Ava Chow: Merge bitcoin/bitcoin#28843: [refactor] Cleanup BlockAssembler mempool usa...
13:31 < bitcoin-git> [bitcoin] achow101 merged pull request #28843: [refactor] Cleanup BlockAssembler mempool usage (master...blockAssemblerRemoveMempool) https://github.com/bitcoin/bitcoin/pull/28843
13:34 < sipa> darosior: ah good to know
13:36 < bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1a8f51e7453c...380e1f44e8ed
13:36 < bitcoin-git> bitcoin/master 42066f4 Lőrinc: Refactor SipHash_32b benchmark to improve accuracy and avoid optimization ...
13:36 < bitcoin-git> bitcoin/master 380e1f4 Ava Chow: Merge bitcoin/bitcoin#30349: benchmark: Improve SipHash_32b accuracy to av...
13:36 < bitcoin-git> [bitcoin] achow101 merged pull request #30349: benchmark: Improve SipHash_32b accuracy to avoid potential optimization issues (master...paplorinc/remove_siphash_benchmark_recursion) https://github.com/bitcoin/bitcoin/pull/30349
13:45 < bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/380e1f44e8ed...2257c6d68fae
13:45 < bitcoin-git> bitcoin/master 8610bce Sjors Provoost: ci: skip Github CI on branch pushes for forks
13:45 < bitcoin-git> bitcoin/master 2257c6d Ava Chow: Merge bitcoin/bitcoin#30487: ci: skip Github CI on branch pushes for forks
13:45 < bitcoin-git> [bitcoin] achow101 merged pull request #30487: ci: skip Github CI on branch pushes for forks (master...2024/07/ci-fork-github) https://github.com/bitcoin/bitcoin/pull/30487
13:54 < bitcoin-git> [bitcoin] achow101 pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/2257c6d68fae...85bcfeea2356
13:54 < bitcoin-git> bitcoin/master a51e917 Martin Zumsande: validation: add RecalculateBestHeader() function
13:54 < bitcoin-git> bitcoin/master 9275e96 Martin Zumsande: rpc: call RecalculateBestHeader as part of reconsiderblock
13:54 < bitcoin-git> bitcoin/master 783cb73 Martin Zumsande: validation: call RecalculateBestHeader in InvalidChainFound
13:54 < bitcoin-git> [bitcoin] achow101 merged pull request #30666: validation: fix m_best_header tracking and BLOCK_FAILED_CHILD assignment (master...202404_invalidblock) https://github.com/bitcoin/bitcoin/pull/30666
14:03 -!- Guest24 [~Guest24@host-79-21-107-85.retail.telecomitalia.it] has joined #bitcoin-core-dev
14:03 -!- Guest24 [~Guest24@host-79-21-107-85.retail.telecomitalia.it] has quit [Client Quit]
14:08 -!- __DuBPiRaTe__ [~E_bomb@2600:6c50:7f7f:d89a:a9ff:a8ae:e1a0:5f48] has joined #bitcoin-core-dev
14:08 -!- gf2718 [~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e] has joined #bitcoin-core-dev
14:10 -!- conman [~con@180-150-21-3.b49615.mel.static.aussiebb.net] has quit [Read error: Connection reset by peer]
14:13 -!- gf2718 [~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e] has quit [Ping timeout: 252 seconds]
14:27 -!- bugs_ [~bugs@user/bugs/x-5128603] has quit [Quit: Leaving]
14:36 -!- __DuBPiRaTe__ [~E_bomb@2600:6c50:7f7f:d89a:a9ff:a8ae:e1a0:5f48] has quit [Remote host closed the connection]
14:38 -!- __DuBPiRaTe__ [~E_bomb@2600:6c50:7f7f:d89a:a9ff:a8ae:e1a0:5f48] has joined #bitcoin-core-dev
14:56 -!- conman [~con@180-150-21-3.b49615.mel.static.aussiebb.net] has joined #bitcoin-core-dev
15:01 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Remote host closed the connection]
15:02 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
15:06 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Ping timeout: 248 seconds]
15:28 -!- adam_ [~adam@2603:8001:6ef0:a660:1d97:ff5a:abec:3ce5] has joined #bitcoin-core-dev
15:51 -!- pablomartin [~pablomart@155.133.17.140] has quit [Ping timeout: 276 seconds]
15:57 -!- adam_ [~adam@2603:8001:6ef0:a660:1d97:ff5a:abec:3ce5] has quit [Ping timeout: 276 seconds]
16:03 -!- eval-exec [~Thunderbi@96.45.190.137.16clouds.com] has joined #bitcoin-core-dev
16:10 -!- gf2718 [~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e] has joined #bitcoin-core-dev
16:14 -!- gf2718 [~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e] has quit [Ping timeout: 260 seconds]
16:16 -!- rizzling [~rizzling@2a02:8109:b691:d400:b8ea:649d:8e51:9f5] has joined #bitcoin-core-dev
16:16 -!- pablomartin [~pablomart@155.133.17.130] has joined #bitcoin-core-dev
16:28 -!- rizzling [~rizzling@2a02:8109:b691:d400:b8ea:649d:8e51:9f5] has quit [Quit: Client closed]
16:36 -!- pablomartin [~pablomart@155.133.17.130] has quit [Ping timeout: 252 seconds]
16:36 -!- pablomartin [~pablomart@155.133.17.133] has joined #bitcoin-core-dev
16:46 -!- pablomartin [~pablomart@155.133.17.133] has quit [Ping timeout: 264 seconds]
17:13 -!- rodarmor_ is now known as rodarmor
17:14 < rodarmor> I wrote a script to build an mdbook from the markdown docs in bitcoin/bitcoin. It's a bit of a mess, and uses Rust to generate the docs, so it's not really fit to merge in its current state, but it's pretty nice.
17:14 < rodarmor> Docs here, hosted on GitHub pages: https://casey.github.io/bitcoin/
17:14 < rodarmor> PR here: https://github.com/casey/bitcoin/pull/3
17:27 -!- zeropoint [~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net] has quit [Quit: leaving]
17:37 -!- _flood [flooded@gateway/vpn/protonvpn/flood/x-43489060] has quit [Remote host closed the connection]
17:39 -!- flooded [flooded@gateway/vpn/protonvpn/flood/x-43489060] has joined #bitcoin-core-dev
17:47 -!- __DuBPiRaTe__ [~E_bomb@2600:6c50:7f7f:d89a:a9ff:a8ae:e1a0:5f48] has quit [Quit: Leaving]
17:59 -!- flooded [flooded@gateway/vpn/protonvpn/flood/x-43489060] has quit [Remote host closed the connection]
18:01 -!- flooded [flooded@gateway/vpn/protonvpn/flood/x-43489060] has joined #bitcoin-core-dev
18:03 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has joined #bitcoin-core-dev
18:03 -!- flooded [flooded@gateway/vpn/protonvpn/flood/x-43489060] has quit [Read error: Connection reset by peer]
18:04 -!- flooded [flooded@gateway/vpn/protonvpn/flood/x-43489060] has joined #bitcoin-core-dev
18:05 -!- flooded [flooded@gateway/vpn/protonvpn/flood/x-43489060] has quit [Remote host closed the connection]
19:13 -!- gf2718 [~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e] has joined #bitcoin-core-dev
19:14 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
19:17 -!- gf2718 [~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e] has quit [Ping timeout: 252 seconds]
19:19 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Ping timeout: 252 seconds]
19:39 -!- eval-exec [~Thunderbi@96.45.190.137.16clouds.com] has quit [Ping timeout: 252 seconds]
19:52 -!- adil [~Thunderbi@2402:d000:8134:2758:e505:f27d:3e1:f5d1] has joined #bitcoin-core-dev
20:16 -!- auci [~auci@user/auci] has joined #bitcoin-core-dev
20:16 -!- auci [~auci@user/auci] has quit [Client Quit]
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:19 -!- adil [~Thunderbi@2402:d000:8134:2758:e505:f27d:3e1:f5d1] has quit [Quit: adil]
21:51 -!- aleggg [~aleggg@177.204.246.39.dynamic.adsl.gvt.net.br] has quit [Ping timeout: 252 seconds]
21:52 -!- aleggg [~aleggg@189.114.69.140] has joined #bitcoin-core-dev
22:01 -!- mcey_ [~emcy@85.255.234.203] has quit [Remote host closed the connection]
22:01 -!- mcey [~emcy@85.255.234.203] has joined #bitcoin-core-dev
22:14 -!- eval-exec [~Thunderbi@96.45.190.137.16clouds.com] has joined #bitcoin-core-dev
22:19 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has quit [Quit: PaperSword]
23:18 -!- gf2718 [~gf2718@2a01:e0a:2f0:5440:b837:b5e7:19a0:d736] has joined #bitcoin-core-dev
23:22 -!- gf2718 [~gf2718@2a01:e0a:2f0:5440:b837:b5e7:19a0:d736] has quit [Ping timeout: 260 seconds]
23:23 -!- cornfeedhobo [~cornfeedh@user/cornfeedhobo] has quit [Read error: Connection reset by peer]
23:29 -!- cornfeedhobo [~cornfeedh@user/cornfeedhobo] has joined #bitcoin-core-dev
23:43 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has joined #bitcoin-core-dev
23:47 -!- kevkevin [~kevkevin@209-242-39-30.rev.dls.net] has quit [Ping timeout: 252 seconds]
--- Log closed Fri Nov 15 00:00:19 2024