--- Log opened Thu Dec 12 00:00:16 2024 00:04 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:9ac:e51b:bfe:2006] has quit [Ping timeout: 245 seconds] 00:09 -!- Guest6 [~Guest6@46.212.41.125] has quit [Quit: Client closed] 00:09 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev 00:15 -!- Guest65 [~Guest65@143.92.239.11] has joined #bitcoin-core-dev 00:21 -!- Guest65 [~Guest65@143.92.239.11] has quit [Quit: Client closed] 00:23 -!- itsarjn [~itsarjn@user/itsarjn] has quit [Remote host closed the connection] 00:29 -!- itsarjn [~itsarjn@user/itsarjn] has joined #bitcoin-core-dev 00:32 < bitcoin-git> [bitcoin] maflcko opened pull request #31477: ci: Bump centos gcc to 12 (master...2412-ci-centos-gcc) https://github.com/bitcoin/bitcoin/pull/31477 00:32 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:9ac:e51b:bfe:2006] has joined #bitcoin-core-dev 00:37 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:9ac:e51b:bfe:2006] has quit [Ping timeout: 248 seconds] 00:38 < bitcoin-git> [bitcoin] RiceChuan opened pull request #31478: docs: (master...master) https://github.com/bitcoin/bitcoin/pull/31478 01:00 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [Closing Window] 01:07 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:9ac:e51b:bfe:2006] has joined #bitcoin-core-dev 01:08 -!- Zenton [~Zenton@user/zenton] has quit [Remote host closed the connection] 01:08 -!- Zenton [~Zenton@user/zenton] has joined #bitcoin-core-dev 01:10 -!- itsarjn [~itsarjn@user/itsarjn] has quit [Remote host closed the connection] 01:14 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:9ac:e51b:bfe:2006] has quit [Ping timeout: 265 seconds] 01:18 -!- eval-exec [~Thunderbi@118.141.160.187] has quit [Remote host closed the connection] 01:18 -!- eval-exec [~Thunderbi@118.141.160.187] has joined #bitcoin-core-dev 01:18 -!- eval-exec [~Thunderbi@118.141.160.187] has quit [Remote host closed the connection] 01:28 -!- Zenton [~Zenton@user/zenton] has quit [Remote host closed the connection] 01:28 -!- Zenton [~Zenton@user/zenton] has joined #bitcoin-core-dev 01:30 -!- Cory [~Cory@user/pasha] has quit [Quit: Client closed] 01:30 -!- Cory [~Cory@user/pasha] has joined #bitcoin-core-dev 01:30 -!- Zenton [~Zenton@user/zenton] has quit [Read error: Connection reset by peer] 01:31 -!- Zenton [~Zenton@user/zenton] has joined #bitcoin-core-dev 01:34 < bitcoin-git> [bitcoin] hodlinator opened pull request #31479: lint: Disable signature output in git log (master...2024/12/lint_git_log_sig_fix) https://github.com/bitcoin/bitcoin/pull/31479 01:35 -!- jespada [~jespada@cpc121308-nmal25-2-0-cust15.19-2.cable.virginm.net] has joined #bitcoin-core-dev 01:42 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:9ac:e51b:bfe:2006] has joined #bitcoin-core-dev 01:42 -!- jespada [~jespada@cpc121308-nmal25-2-0-cust15.19-2.cable.virginm.net] has quit [Read error: Connection reset by peer] 01:51 -!- itsarjn [~itsarjn@user/itsarjn] has joined #bitcoin-core-dev 01:52 -!- jespada [~jespada@cpc121308-nmal25-2-0-cust15.19-2.cable.virginm.net] has joined #bitcoin-core-dev 01:59 -!- Zenton [~Zenton@user/zenton] has quit [Remote host closed the connection] 01:59 -!- Zenton [~Zenton@user/zenton] has joined #bitcoin-core-dev 02:06 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/62bd61de110b...29ddee1796a6 02:06 < bitcoin-git> bitcoin/master 015aad8 RiceChuan: docs: remove repetitive words 02:06 < bitcoin-git> bitcoin/master 29ddee1 merge-script: Merge bitcoin/bitcoin#31478: docs: remove repetitive words 02:06 < bitcoin-git> [bitcoin] fanquake merged pull request #31478: docs: remove repetitive words (master...master) https://github.com/bitcoin/bitcoin/pull/31478 02:08 -!- Zenton [~Zenton@user/zenton] has quit [Remote host closed the connection] 02:08 -!- Zenton [~Zenton@user/zenton] has joined #bitcoin-core-dev 02:11 -!- Zenton [~Zenton@user/zenton] has quit [Read error: Connection reset by peer] 02:11 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/29ddee1796a6...ea9e64ff3cb0 02:11 < bitcoin-git> bitcoin/master b7ec69c fanquake: depends: add -g to *BSD_debug flags 02:11 < bitcoin-git> bitcoin/master ea9e64f merge-script: Merge bitcoin/bitcoin#31461: depends: add `-g` to *BSD_debug flags 02:11 < bitcoin-git> [bitcoin] fanquake merged pull request #31461: depends: add `-g` to *BSD_debug flags (master...dash_g_bsd) https://github.com/bitcoin/bitcoin/pull/31461 02:11 -!- Zenton [~Zenton@user/zenton] has joined #bitcoin-core-dev 02:21 -!- Zenton_ [~Zenton@user/zenton] has joined #bitcoin-core-dev 02:23 -!- Zenton [~Zenton@user/zenton] has quit [Ping timeout: 260 seconds] 02:26 -!- Zenton_ is now known as Zenton 02:27 < bitcoin-git> [bitcoin] hebasto opened pull request #31480: refactor: Fix "modernize-use-starts-ends-with" clang-tidy warning (master...241212-tidy) https://github.com/bitcoin/bitcoin/pull/31480 02:28 -!- Zenton [~Zenton@user/zenton] has quit [Remote host closed the connection] 02:28 -!- Zenton [~Zenton@user/zenton] has joined #bitcoin-core-dev 02:34 -!- codingp110 [~codingp11@2401:4900:8842:fe32:ba39:89c1:298c:1f4e] has joined #bitcoin-core-dev 02:40 -!- codingp110 [~codingp11@2401:4900:8842:fe32:ba39:89c1:298c:1f4e] has quit [Quit: Client closed] 02:48 -!- Zenton [~Zenton@user/zenton] has quit [Remote host closed the connection] 02:49 -!- Zenton [~Zenton@user/zenton] has joined #bitcoin-core-dev 02:55 < bitcoin-git> [bitcoin] maflcko opened pull request #31481: fuzz: Faster leak check, and SeedRand::ZEROS before every input (master...2412-fuzz-stable-fast) https://github.com/bitcoin/bitcoin/pull/31481 03:12 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ea9e64ff3cb0...435ad572a1af 03:12 < bitcoin-git> bitcoin/master e2d3372 Hodlinator: lint: Disable signature output in git log 03:12 < bitcoin-git> bitcoin/master 435ad57 merge-script: Merge bitcoin/bitcoin#31479: lint: Disable signature output in git log 03:12 < bitcoin-git> [bitcoin] fanquake merged pull request #31479: lint: Disable signature output in git log (master...2024/12/lint_git_log_sig_fix) https://github.com/bitcoin/bitcoin/pull/31479 03:56 -!- itsarjn [~itsarjn@user/itsarjn] has quit [Remote host closed the connection] 03:57 -!- itsarjn [~itsarjn@user/itsarjn] has joined #bitcoin-core-dev 04:01 -!- itsarjn [~itsarjn@user/itsarjn] has quit [Ping timeout: 245 seconds] 04:14 -!- codingp110 [~codingp11@2401:4900:8842:fe32:572d:96af:245c:6334] has joined #bitcoin-core-dev 04:16 -!- codingp110 [~codingp11@2401:4900:8842:fe32:572d:96af:245c:6334] has quit [Client Quit] 04:18 < bitcoin-git> [bitcoin] TheCharlatan opened pull request #31483: kernel: Move kernel-related cache constants to kernel cache (master...kernel_cache_sizes) https://github.com/bitcoin/bitcoin/pull/31483 04:22 -!- itsarjn [~itsarjn@user/itsarjn] has joined #bitcoin-core-dev 05:04 -!- Zenton [~Zenton@user/zenton] has quit [Remote host closed the connection] 05:04 -!- Zenton [~Zenton@user/zenton] has joined #bitcoin-core-dev 05:06 -!- uasf_ [~uasf@2604:a880:2:d0::1bda:1001] has joined #bitcoin-core-dev 05:07 -!- kvaciral[m] [~kvaciralx@2620:6e:a000:ce11::27] has quit [Ping timeout: 276 seconds] 05:07 -!- BlueMattTest [~test-acct@2620:6e:a000:ce11::c] has quit [Ping timeout: 276 seconds] 05:07 -!- kvaciral[m] [~kvaciralx@2620:6e:a000:ce11::27] has joined #bitcoin-core-dev 05:07 -!- Zenton [~Zenton@user/zenton] has quit [Remote host closed the connection] 05:08 -!- uasf [~uasf@2604:a880:2:d0::1bda:1001] has quit [Ping timeout: 276 seconds] 05:08 -!- Zenton [~Zenton@user/zenton] has joined #bitcoin-core-dev 05:08 -!- BlueMattTest [~test-acct@2620:6e:a000:ce11::c] has joined #bitcoin-core-dev 05:13 -!- Guest79 [~Guest79@80.90.165.69] has joined #bitcoin-core-dev 05:16 -!- Guest79 [~Guest79@80.90.165.69] has quit [Client Quit] 05:17 -!- rEAL2SATOSHI [~rEAL2SATO@80.90.165.69] has joined #bitcoin-core-dev 05:19 -!- rEAL2SATOSHI [~rEAL2SATO@80.90.165.69] has quit [Client Quit] 05:20 -!- Guest6 [~Guest6@46.212.41.125] has joined #bitcoin-core-dev 05:22 -!- Guest6 [~Guest6@46.212.41.125] has quit [Client Quit] 05:30 -!- Guest96 [~Guest96@2001:fb1:76:836a:7560:649d:a534:4f08] has joined #bitcoin-core-dev 05:31 -!- Guest96 [~Guest96@2001:fb1:76:836a:7560:649d:a534:4f08] has left #bitcoin-core-dev [] 05:31 -!- moresteakpls [~moresteak@2001:fb1:76:836a:7560:649d:a534:4f08] has joined #bitcoin-core-dev 05:36 -!- moresteakpls [~moresteak@2001:fb1:76:836a:7560:649d:a534:4f08] has left #bitcoin-core-dev [] 05:42 -!- moresteakpls [~moresteak@2001:fb1:76:836a:7560:649d:a534:4f08] has joined #bitcoin-core-dev 05:54 -!- moresteakpls [~moresteak@2001:fb1:76:836a:7560:649d:a534:4f08] has quit [Quit: Client closed] 05:54 -!- MyNetAz [~MyNetAz@user/MyNetAz] has quit [Ping timeout: 252 seconds] 05:55 < sipa> i will be a few minutes late for the meeting 05:59 -!- itsarjn [~itsarjn@user/itsarjn] has quit [Read error: Connection reset by peer] 06:00 < achow101> #startmeeting 06:00 < b10c> hi 06:00 < TheCharlatan> hi 06:00 < hebasto> hi 06:00 < achow101> #bitcoin-core-dev Meeting: abubakarsadiq achow101 _aj_ ajonas b10c brunoerg cfields darosior dergoegge fanquake fjahr furszy gleb glozow hebasto instagibbs jarolrod jonatack josibake kanzure laanwj LarryRuane lightlike luke-jr maflcko marcofleon maxedw Murch pinheadmz provoostenator ryanofsky sdaftuar S3RK stickies-v sipa sr_gi tdb3 theStack TheCharlatan vasild willcl-ark 06:00 < sr_gi[m]> hi 06:00 < ryanofsky> hi 06:00 < brunoerg> hi 06:00 < kevkevin> hi 06:00 < instagibbs> hi 06:00 < cfields> hi 06:00 < furszy> hi 06:01 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has joined #bitcoin-core-dev 06:01 < achow101> There are no preproposed meeting topics this week. Any last minute ones to add? 06:01 -!- moresteakpls [~moresteak@2001:fb1:76:836a:7560:649d:a534:4f08] has joined #bitcoin-core-dev 06:02 < achow101> #topic Erlay WG Update (sr_gi, gleb, marcofleon) 06:02 < maxedw> hi 06:02 < sr_gi[m]> That's me 06:04 < sr_gi[m]> We've been compiling a list of simulations to run, writing down design decision so we can re-evaluate if needed down the line and see what has been considered. I've been updating the simulator and started to simulate some of them. The PR has also been brought up to date with the pending feedback. Gleb is working on a rebase of the whole Erlay implementation so some things can also be tested with real nodes in a warnet-like environment, 06:04 < sr_gi[m]> plus also reviving his simulator to run cross sims 06:04 -!- guest_glozow [~guest_glo@170.85.70.187] has joined #bitcoin-core-dev 06:05 < sr_gi[m]> There has also been some fuzzing by marko pointing out bugs to fix 06:05 < sr_gi[m]> I think that's it 06:05 < achow101> #topic Kernel WG Update (TheCharlatan) 06:05 < marcofleon> I'm looking to fuzz more once the rebase is done. And still wrapping my head around some of the design stuff 06:05 < TheCharlatan> Skipped the last few updates, so I'll do a drop of what I've been working on. 06:05 < TheCharlatan> I opened some more PRs for de-duplicating and simplifying logic for potential future users of the lib. 06:06 < TheCharlatan> Moving the final flush before shutdown to the ChainstateManager destructor: #31382 . This simplifies the tear-down procedure for the library significantly. 06:06 <@gribble> https://github.com/bitcoin/bitcoin/issues/31382 | kernel: Flush in ChainstateManager destructor by TheCharlatan · Pull Request #31382 · bitcoin/bitcoin · GitHub 06:06 < TheCharlatan> Make the cache size calculations easier to use for kernel users: #31483 06:06 <@gribble> https://github.com/bitcoin/bitcoin/issues/31483 | kernel: Move kernel-related cache constants to kernel cache by TheCharlatan · Pull Request #31483 · bitcoin/bitcoin · GitHub 06:06 < TheCharlatan> After seeing the recent demand for better script debuggers, I was thinking how the kernel library might be useful for this in the future. It seems like btcdeb is not really usable for external projects, or projects extending the script interpreter. 06:06 < TheCharlatan> I added a debug callback in the kernel C API that hooks into the script interpreter and can provided a trace of the execution of a script here: https://github.com/TheCharlatan/bitcoin/commit/997c2ccc920adb0d1c9d8e82dbe94374cfb3c78b 06:06 < TheCharlatan> The hooks are gated by a macro, so users would have to compile with `ENABLE_SCRIPT_DEBUG`. 06:06 < TheCharlatan> This might be more viable than btcdeb for these kind of users, since only the interpreter itself would have to be changed for supporting new functionality, leaving changing the output of the debugger entirely up to the user. It could also be used to better test some of the internals of the interpreter. 06:08 -!- MyNetAz [~MyNetAz@user/MyNetAz] has joined #bitcoin-core-dev 06:08 < sipa> hi 06:08 < TheCharlatan> Lastly, I'd like to point out the RFC PR #31425, which checks that the static libbitcoinconsensus can be compiled for 32bit riscv bare metal. 06:08 <@gribble> https://github.com/bitcoin/bitcoin/issues/31425 | RFC: Riscv bare metal CI job by TheCharlatan · Pull Request #31425 · bitcoin/bitcoin · GitHub 06:09 < TheCharlatan> that's all 06:09 < sipa> TheCharlatan: does it test anything beyond compilation? 06:09 < TheCharlatan> no, but that could be added through qemu 06:10 < sipa> i see 06:11 < cfields> neat 06:12 < achow101> #topic Cluster Mempool WG Update (sdaftuar, sipa) 06:12 < sipa> hi 06:12 -!- eval-exec [~Thunderbi@107.182.187.217.16clouds.com] has joined #bitcoin-core-dev 06:12 < sipa> #31363 remains the thing to review at this point 06:12 <@gribble> https://github.com/bitcoin/bitcoin/issues/31363 | cluster mempool: introduce TxGraph by sipa · Pull Request #31363 · bitcoin/bitcoin · GitHub 06:13 < sipa> i've also opened a successor 31444, which adds interfaces for mining, eviction, and rbf diagram comparison to the TxGraph class 06:13 < instagibbs> #31444 06:13 <@gribble> https://github.com/bitcoin/bitcoin/issues/31444 | cluster mempool: add txgraph diagrams/mining/eviction by sipa · Pull Request #31444 · bitcoin/bitcoin · GitHub 06:14 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection] 06:14 < sipa> there remains one critical piece of logic at the TxGraph layer before the full cluster mempool code can be rebased on it (#28676), namely exposing an interface to deal with (too big) reorgs, as it is possible that reorgs merge the entire mempool together into a single cluster, and we need to do *something* in that case (we can't just reject them like RBFs) 06:14 <@gribble> https://github.com/bitcoin/bitcoin/issues/28676 | [WIP] Cluster mempool implementation by sdaftuar · Pull Request #28676 · bitcoin/bitcoin · GitHub 06:15 < sipa> that said, there is enough code in 31363 and 31444 that deserves review, and it's complete with a simulation test that i think covers most if not all of the behavior we want from it 06:16 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev 06:16 < sipa> in particular, i'm quite happy with how the test simulates mempool changesets: the transactions are stored in shared_ptrs, so to start a changeset, the simulation graph is just copied, on abort it's deleted, on commit it replaces the main graph 06:17 < sipa> that's it from me, unless there are questions/comments 06:17 < instagibbs> appreciate the additional context provided by newest PR, im finding it a bit difficult to do a deep review without the whole thing 06:18 < sipa> would it help to have a writeup of what txgraph's responsibility is, and what the hard problems it solves are? 06:18 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 244 seconds] 06:18 < sipa> in order to get review in before the full thing is PRed? 06:19 < instagibbs> Hard to say, I'm having difficulty judging if the API is sensible if I don't actually see it used in anger 06:19 < instagibbs> some things are obviously correct, others im unsure 06:19 < sipa> fair point 06:20 < sipa> i guess i can't really help with that apart from getting closer to a point where 28676 can be rebased 06:20 -!- itsarjn [~itsarjn@user/itsarjn] has joined #bitcoin-core-dev 06:20 < instagibbs> will circle back after looking at newest PR 06:21 < achow101> #topic MuSig2 WG Update (achow101) 06:21 < achow101> A couple fuzz crashes were found in #31247 which have been fixed 06:21 <@gribble> https://github.com/bitcoin/bitcoin/issues/31247 | psbt: MuSig2 Fields by achow101 · Pull Request #31247 · bitcoin/bitcoin · GitHub 06:22 < achow101> Err rather #31244 06:22 <@gribble> https://github.com/bitcoin/bitcoin/issues/31244 | descriptors: MuSig2 by achow101 · Pull Request #31244 · bitcoin/bitcoin · GitHub 06:22 < achow101> The next PRs to review are still #31242 and #31243 06:22 <@gribble> https://github.com/bitcoin/bitcoin/issues/31242 | wallet, desc spkm: Return SigningProvider only if we have the privkey by achow101 · Pull Request #31242 · bitcoin/bitcoin · GitHub 06:22 <@gribble> https://github.com/bitcoin/bitcoin/issues/31243 | descriptor: Move filling of keys from `DescriptorImpl::MakeScripts` to `PubkeyProvider::GetPubKey` by achow101 · Pull Request #31243 · bitcoin/bitcoin · GitHub 06:22 < achow101> #topic Legacy Wallet Removal WG Update (achow101) 06:23 < achow101> In reviewing #30328, we've been finding some additional migration edge cases, and further edge cases in the PRs to fix those edge cases. 06:23 <@gribble> https://github.com/bitcoin/bitcoin/issues/30328 | wallet: Remove IsMine from migration code by achow101 · Pull Request #30328 · bitcoin/bitcoin · GitHub 06:23 < achow101> There's now #31423, #31451, and #31452 opened for those. Any of these PR is the thing to review. 06:23 <@gribble> https://github.com/bitcoin/bitcoin/issues/31452 | wallet: Migrate non-HD keys to combo() descriptor by achow101 · Pull Request #31452 · bitcoin/bitcoin · GitHub 06:23 <@gribble> https://github.com/bitcoin/bitcoin/issues/31451 | wallet: migration, avoid loading legacy wallet after failure when BDB isnt compiled by furszy · Pull Request #31451 · bitcoin/bitcoin · GitHub 06:23 <@gribble> https://github.com/bitcoin/bitcoin/issues/31423 | wallet: migration, dont create spendable wallet from a watch-only legacy wallet by furszy · Pull Request #31423 · bitcoin/bitcoin · GitHub 06:23 < achow101> These edge cases aren't additional scripts that should be migrated, just different wallet configurations that caused migration failures or could be migrated in a better way. 06:23 < achow101> So already migrated wallets don't need to worry 06:23 < sipa> ah good 06:23 < achow101> Lastly, #30328 has been getting review and is being updated to be clearer on why it is doing some things 06:23 <@gribble> https://github.com/bitcoin/bitcoin/issues/30328 | wallet: Remove IsMine from migration code by achow101 · Pull Request #30328 · bitcoin/bitcoin · GitHub 06:24 -!- Guest19 [~Guest19@131.161.225.53] has joined #bitcoin-core-dev 06:24 -!- Guest19 [~Guest19@131.161.225.53] has quit [Client Quit] 06:24 < achow101> IsMine has been reported to be very confusing to reviewers so I've been trying to make it clearer as to why the replacement code is correct 06:25 < achow101> #topic Multiprocess WG Update (ryanofsky) 06:25 < ryanofsky> hi 06:25 < ryanofsky> There's a backlog of PRs in #31098 that have one or two acks and could use another review to get unstuck. These are needed to get IPC mining features enabled in the next release 06:25 <@gribble> https://github.com/bitcoin/bitcoin/issues/31098 | Stratum v2 via IPC Mining Interface tracking issue · Issue #31098 · bitcoin/bitcoin · GitHub 06:26 < ryanofsky> #31318 (2 acks) #31346 (2 acks) #31196 (2 acks) #31197 (2 acks) #30437 (stale ack) #31375 (concept ack only) 06:26 <@gribble> https://github.com/bitcoin/bitcoin/issues/31318 | Drop script_pub_key arg from createNewBlock by Sjors · Pull Request #31318 · bitcoin/bitcoin · GitHub 06:26 <@gribble> https://github.com/bitcoin/bitcoin/issues/31346 | Set notifications m_tip_block in LoadChainTip() by Sjors · Pull Request #31346 · bitcoin/bitcoin · GitHub 06:26 <@gribble> https://github.com/bitcoin/bitcoin/issues/31196 | Prune mining interface by Sjors · Pull Request #31196 · bitcoin/bitcoin · GitHub 06:26 <@gribble> https://github.com/bitcoin/bitcoin/issues/31197 | refactor: mining interface 30955 followups by Sjors · Pull Request #31197 · bitcoin/bitcoin · GitHub 06:26 <@gribble> https://github.com/bitcoin/bitcoin/issues/30437 | multiprocess: add bitcoin-mine test program by ryanofsky · Pull Request #30437 · bitcoin/bitcoin · GitHub 06:26 <@gribble> https://github.com/bitcoin/bitcoin/issues/31375 | multiprocess: Add bitcoin wrapper executable by ryanofsky · Pull Request #31375 · bitcoin/bitcoin · GitHub 06:27 < ryanofsky> Another thing that happened recently darosior has written rust code to be able to call the Chain interface over IPC. Can see his comments in #29409 06:27 <@gribble> https://github.com/bitcoin/bitcoin/issues/29409 | multiprocess: Add capnp wrapper for Chain interface by ryanofsky · Pull Request #29409 · bitcoin/bitcoin · GitHub 06:27 < ryanofsky> And that's all for me 06:27 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev 06:27 < TheCharlatan> The rust wallet is very cool :) 06:28 < fanquake> I guess all the bugfix PRs in https://github.com/chaincodelabs/libmultiprocess/pulls should also be added to #31098 ? 06:28 <@gribble> https://github.com/bitcoin/bitcoin/issues/31098 | Stratum v2 via IPC Mining Interface tracking issue · Issue #31098 · bitcoin/bitcoin · GitHub 06:28 < fanquake> As well as any build failures / other issues (if the plan if to ship this on by default) i.e like #31455 06:28 <@gribble> https://github.com/bitcoin/bitcoin/issues/31455 | multiprocess: build failure on Alpine with depends & `DEBUG=1` · Issue #31455 · bitcoin/bitcoin · GitHub 06:28 < ryanofsky> Yes that's a good point I can do that 06:29 < ryanofsky> There's a lot that needs to come together 06:29 < TheCharlatan> will the release be macos and linux only? 06:30 < fanquake> Does our code-signing for macOS need any accomodations for multiprocess? i.e some entitlement to spawn other bins or similar 06:30 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:9ac:e51b:bfe:2006] has quit [Remote host closed the connection] 06:30 -!- Zenton [~Zenton@user/zenton] has quit [Remote host closed the connection] 06:30 < ryanofsky> Unless I get windows support together in time I think so. There's an issue in the libmultiprocess repo saying what needs to be done but I haven't started that yet 06:30 < TheCharlatan> ok 06:32 < ryanofsky> fanquake, pretty sure that's not true. If that's the case the wrapper executable would also have problems 06:32 < fanquake> Ok, great if that doesn't need any other changes 06:32 < achow101> It doesn't seem like there's an entitlement for that. But the other bins will also need to be codesigned 06:33 < ryanofsky> In worst case first multiprocess release would just be linux only which is probably ok 06:34 < achow101> presumably we'd ship both multiprocess and monolithic for a while 06:34 < ryanofsky> well the multiprocess release should include both sets of binaries 06:34 < ryanofsky> (long discussion about that in #30983) 06:34 <@gribble> https://github.com/bitcoin/bitcoin/issues/30983 | RFC: Multiprocess binaries and packaging options · Issue #30983 · bitcoin/bitcoin · GitHub 06:35 < sipa> i think it would be good to try to end up with just a single type eventually 06:35 -!- guest_glozow [~guest_glo@170.85.70.187] has quit [Quit: Client closed] 06:35 < sipa> if multiprocess can do everything that normal builds can, there is no need to keep supporting more configurations longer 06:36 < sipa> but not as long as there compatibility issues or other hassles with it of courde 06:36 < achow101> ok, will read through the discussion in 30983 06:36 < ryanofsky> sipa, i think biggest issue there is performance. gui and wallet interfaces are not really optimized to work well over ipc, but they could be 06:36 < sipa> ryanofsky: thanks, will rrad 06:36 < sipa> huh, that surprises me a bit 06:37 < ryanofsky> i think they are mostly just doing a lot of stupid things that add latency. if you run functional tests with ipc there is a definite slowdown 06:38 < achow101> #topic package relay WG Update (glozow) 06:39 < achow101> glozow says "We’re making steady progress on #31397, and I would like to find additional reviewers for #31385." 06:39 <@gribble> https://github.com/bitcoin/bitcoin/issues/31397 | p2p: track and use all potential peers for orphan resolution by glozow · Pull Request #31397 · bitcoin/bitcoin · GitHub 06:39 <@gribble> https://github.com/bitcoin/bitcoin/issues/31385 | package validation: relax the package-not-child-with-unconfirmed-parents rule by glozow · Pull Request #31385 · bitcoin/bitcoin · GitHub 06:39 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [Closing Window] 06:40 < achow101> Anything else to discuss today? 06:43 < achow101> #endmeeting 06:46 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 06:47 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:9ac:e51b:bfe:2006] has joined #bitcoin-core-dev 06:51 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:9ac:e51b:bfe:2006] has quit [Ping timeout: 248 seconds] 06:52 -!- moresteakpls [~moresteak@2001:fb1:76:836a:7560:649d:a534:4f08] has quit [Quit: Client closed] 06:55 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 06:58 -!- brunoerg [~brunoerg@2804:1600:100:1f00:35d4:959b:7044:a023] has joined #bitcoin-core-dev 07:02 < sipa> TheCharlatan: in general i can't say i'm a fan of adding complexity to the script interpreter just for the purpose of inspection/debugging, but i have to say this approach you have is really extremely limited in how intrusive it is 07:13 -!- mcey_ [~emcy@148.252.147.100] has joined #bitcoin-core-dev 07:16 < darosior> I agree, although i'm not really sure what's wrong with btcdeb. 07:16 -!- emcy__ [~emcy@85.255.234.164] has quit [Ping timeout: 248 seconds] 07:17 -!- brunoerg [~brunoerg@2804:1600:100:1f00:35d4:959b:7044:a023] has quit [Remote host closed the connection] 07:18 < instagibbs> https://github.com/bitcoin-inquisition/bitcoin/pull/58 maybe related 07:19 < fanquake> darosior: at least one issue is that it's going somewhat unmaintained 07:32 -!- preimage [~halosghos@user/halosghost] has joined #bitcoin-core-dev 07:33 -!- MyNetAz [~MyNetAz@user/MyNetAz] has quit [Ping timeout: 252 seconds] 07:37 -!- bugs_ [~bugs@user/bugs/x-5128603] has joined #bitcoin-core-dev 07:47 -!- MyNetAz [~MyNetAz@user/MyNetAz] has joined #bitcoin-core-dev 07:52 -!- MyNetAz [~MyNetAz@user/MyNetAz] has quit [Excess Flood] 08:09 -!- MyNetAz [~MyNetAz@user/MyNetAz] has joined #bitcoin-core-dev 08:10 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has quit [Quit: Connection closed for inactivity] 08:20 -!- Zenton [~Zenton@user/zenton] has joined #bitcoin-core-dev 08:23 -!- eval-exec [~Thunderbi@107.182.187.217.16clouds.com] has quit [Remote host closed the connection] 08:26 < darosior> ugh https://github.com/bitcoin-core/btcdeb/pull/151 08:26 -!- Zenton [~Zenton@user/zenton] has quit [Remote host closed the connection] 08:26 -!- Zenton [~Zenton@user/zenton] has joined #bitcoin-core-dev 08:30 -!- Zenton [~Zenton@user/zenton] has quit [Remote host closed the connection] 08:31 -!- Zenton [~Zenton@user/zenton] has joined #bitcoin-core-dev 08:32 < dergoegge> I suggested it in the kernel wg (maybe it came up before as well not sure) because i saw: https://github.com/taproot-wizards/bitcoin-script-hints.nvim 08:32 < dergoegge> Would be cool if projects like that could use the kernel to make sure they don't incorrectly re-implement the interpreter 08:33 < dergoegge> darosior: not sure if btcdeb could accomplish this as well? 08:36 -!- Zenton_ [~Zenton@user/zenton] has joined #bitcoin-core-dev 08:37 -!- Zenton [~Zenton@user/zenton] has quit [Read error: Connection reset by peer] 08:38 < darosior> wow, did they reimplement the Script interpreter in lua? lol 08:38 -!- Zenton_ [~Zenton@user/zenton] has quit [Remote host closed the connection] 08:39 -!- Zenton_ [~Zenton@user/zenton] has joined #bitcoin-core-dev 08:40 -!- brunoerg [~brunoerg@179.191.242.47] has joined #bitcoin-core-dev 08:42 < darosior> dergoegge: it probably could. But i was mostly replying to `btcdeb` being hard to use (i used it in the past and found it pretty helpful). But given it is unmaintained and i'm not volunteering to rebase it, TheCharlatan's patch is probably the most pragmatic approach to give people external to the project the tools to experiment with the 08:42 < darosior> interpreter. And i agree it's a worthwile goal. 08:45 -!- Zenton_ [~Zenton@user/zenton] has quit [Quit: Leaving] 08:48 < dergoegge> darosior: they did at least partially 08:53 -!- brunoerg_ [~brunoerg@179.191.242.47] has joined #bitcoin-core-dev 08:53 -!- brunoerg [~brunoerg@179.191.242.47] has quit [Read error: Connection reset by peer] 08:53 -!- Zenton [~Zenton@user/zenton] has joined #bitcoin-core-dev 09:08 -!- brunoerg_ [~brunoerg@179.191.242.47] has quit [Remote host closed the connection] 09:21 -!- zeropoint [~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 09:22 -!- kevkevin_ [~kevkevin@209.242.39.30] has joined #bitcoin-core-dev 09:25 -!- kevkevin [~kevkevin@209.242.39.30] has quit [Ping timeout: 244 seconds] 09:25 < bitcoin-git> [bitcoin] fanquake opened pull request #31484: depends: update capnproto to 1.0.2 (master...freebsd_capnproto) https://github.com/bitcoin/bitcoin/pull/31484 09:42 -!- itsarjn_ [~itsarjn@user/itsarjn] has joined #bitcoin-core-dev 09:46 -!- itsarjn [~itsarjn@user/itsarjn] has quit [Ping timeout: 248 seconds] 10:03 -!- GuestSF [~GuestSF@c-24-23-219-116.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 10:06 -!- itsarjn [~itsarjn@user/itsarjn] has joined #bitcoin-core-dev 10:10 -!- itsarjn_ [~itsarjn@user/itsarjn] has quit [Ping timeout: 265 seconds] 10:15 -!- brunoerg [~brunoerg@2804:14d:5285:84b2::1002] has joined #bitcoin-core-dev 10:16 -!- GuestSF [~GuestSF@c-24-23-219-116.hsd1.ca.comcast.net] has quit [Quit: Client closed] 10:18 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 10:21 -!- Guest14 [~Guest14@95.105.65.234] has joined #bitcoin-core-dev 10:21 -!- Talkless [~Talkless@mail.dargis.net] has quit [Remote host closed the connection] 10:22 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 10:29 -!- brunoerg [~brunoerg@2804:14d:5285:84b2::1002] has quit [Remote host closed the connection] 10:29 -!- brunoerg [~brunoerg@2804:14d:5285:84b2::1002] has joined #bitcoin-core-dev 10:35 -!- Guest14 [~Guest14@95.105.65.234] has quit [Ping timeout: 240 seconds] 10:58 -!- ___nick___ [~quassel@82-132-245-160.dab.02.net] has joined #bitcoin-core-dev 11:00 -!- jespada [~jespada@cpc121308-nmal25-2-0-cust15.19-2.cable.virginm.net] has quit [Quit: My Mac has gone to sleep. ZZZzzz…] 11:07 -!- ___nick___ [~quassel@82-132-245-160.dab.02.net] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 11:10 -!- ___nick___ [~quassel@82-132-245-160.dab.02.net] has joined #bitcoin-core-dev 11:10 -!- ___nick___ [~quassel@82-132-245-160.dab.02.net] has quit [Client Quit] 11:13 -!- cotsuka [~cotsuka@user/cotsuka] has quit [Remote host closed the connection] 11:13 -!- ___nick___ [~quassel@82-132-245-160.dab.02.net] has joined #bitcoin-core-dev 11:14 -!- cotsuka [~cotsuka@user/cotsuka] has joined #bitcoin-core-dev 11:46 -!- brunoerg [~brunoerg@2804:14d:5285:84b2::1002] has quit [Ping timeout: 246 seconds] 11:49 -!- Talkless [~Talkless@mail.dargis.net] has quit [Remote host closed the connection] 11:52 -!- brunoerg [~brunoerg@2804:14d:5285:84b2::1002] has joined #bitcoin-core-dev 12:04 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 12:11 -!- brunoerg [~brunoerg@2804:14d:5285:84b2::1002] has quit [Ping timeout: 245 seconds] 12:12 -!- brunoerg [~brunoerg@2804:14d:5285:84b2::1000] has joined #bitcoin-core-dev 12:23 -!- brunoerg [~brunoerg@2804:14d:5285:84b2::1000] has quit [Remote host closed the connection] 12:24 -!- brunoerg [~brunoerg@2804:14d:5285:84b2::1000] has joined #bitcoin-core-dev 12:28 -!- brunoerg [~brunoerg@2804:14d:5285:84b2::1000] has quit [Ping timeout: 246 seconds] 12:32 -!- itsarjn [~itsarjn@user/itsarjn] has quit [Remote host closed the connection] 12:41 -!- ___nick___ [~quassel@82-132-245-160.dab.02.net] has quit [Ping timeout: 248 seconds] 12:41 -!- ___nick___ [~quassel@194.88.100.12] has joined #bitcoin-core-dev 13:04 -!- ___nick___ [~quassel@194.88.100.12] has quit [Ping timeout: 272 seconds] 13:12 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 260 seconds] 13:23 -!- edverma [~edverma@92.119.18.232] has joined #bitcoin-core-dev 13:51 -!- edverma [~edverma@92.119.18.232] has left #bitcoin-core-dev [] 13:52 -!- brunoerg [~brunoerg@179.191.242.47] has joined #bitcoin-core-dev 13:57 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 14:04 -!- QBlock [~QBlock@2001:16a2:c0cc:a824:2143:24c1:2e07:d750] has joined #bitcoin-core-dev 14:06 -!- edverma [~edverma@92.119.18.232] has joined #bitcoin-core-dev 14:11 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has quit [Quit: Connection closed for inactivity] 14:13 < bitcoin-git> [bitcoin] ryanofsky pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/435ad572a1af...beac62e541c8 14:13 -!- QBlock [~QBlock@2001:16a2:c0cc:a824:2143:24c1:2e07:d750] has quit [Quit: Client closed] 14:13 < bitcoin-git> bitcoin/master df27ee9 Hennadii Stepanov: refactor: Fix "modernize-use-starts-ends-with" clang-tidy warning 14:13 < bitcoin-git> bitcoin/master beac62e Ryan Ofsky: Merge bitcoin/bitcoin#31480: refactor: Fix "modernize-use-starts-ends-with... 14:13 < bitcoin-git> [bitcoin] ryanofsky merged pull request #31480: refactor: Fix "modernize-use-starts-ends-with" clang-tidy warning (master...241212-tidy) https://github.com/bitcoin/bitcoin/pull/31480 14:14 -!- Guest93 [~Guest93@5.212.113.237] has joined #bitcoin-core-dev 14:20 -!- Guest93 [~Guest93@5.212.113.237] has quit [Quit: Client closed] 14:27 -!- brunoerg [~brunoerg@179.191.242.47] has quit [Remote host closed the connection] 14:29 -!- gribble [~gribble@bitcoin/bot/gribble] has quit [Remote host closed the connection] 14:30 -!- gribble [~gribble@bitcoin/bot/gribble] has joined #bitcoin-core-dev 14:30 -!- mode/#bitcoin-core-dev [+o gribble] by ChanServ 14:32 -!- Cory [~Cory@user/pasha] has quit [Quit: Client closed] 14:32 -!- Cory [~Cory@user/pasha] has joined #bitcoin-core-dev 14:48 -!- preimage [~halosghos@user/halosghost] has quit [Quit: WeeChat 4.4.4] 14:59 -!- kevkevin_ [~kevkevin@209.242.39.30] has quit [Read error: Connection reset by peer] 15:00 -!- kevkevin [~kevkevin@209.242.39.30] has joined #bitcoin-core-dev 15:09 -!- edverma [~edverma@92.119.18.232] has quit [] 15:13 -!- edverma [~edverma@92.119.18.232] has joined #bitcoin-core-dev 15:18 -!- bugs_ [~bugs@user/bugs/x-5128603] has quit [Quit: Leaving] 15:48 -!- Cory [~Cory@user/pasha] has quit [Quit: Client closed] 15:48 -!- Cory [~Cory@user/pasha] has joined #bitcoin-core-dev 16:03 -!- eval-exec [~Thunderbi@107.182.187.217.16clouds.com] has joined #bitcoin-core-dev 16:19 -!- Cory [~Cory@user/pasha] has quit [Quit: Client closed] 16:19 -!- Cory [~Cory@user/pasha] has joined #bitcoin-core-dev 16:30 -!- Guest68 [~Guest68@240a:42ba:1800:4435:302c:aff:fe17:c7bc] has joined #bitcoin-core-dev 16:30 -!- Guest68 [~Guest68@240a:42ba:1800:4435:302c:aff:fe17:c7bc] has quit [Client Quit] 16:31 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:6069:1e3e:ac8b:d538] has joined #bitcoin-core-dev 16:33 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:6069:1e3e:ac8b:d538] has quit [Remote host closed the connection] 16:33 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:6069:1e3e:ac8b:d538] has joined #bitcoin-core-dev 17:32 -!- zeropoint [~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net] has quit [Quit: leaving] 17:54 -!- eval-exec [~Thunderbi@107.182.187.217.16clouds.com] has quit [Ping timeout: 252 seconds] 18:27 -!- kevkevin [~kevkevin@209.242.39.30] has quit [Remote host closed the connection] 18:29 -!- kevkevin [~kevkevin@209.242.39.30] has joined #bitcoin-core-dev 18:38 -!- kevkevin [~kevkevin@209.242.39.30] has quit [Ping timeout: 248 seconds] 18:53 -!- Guest31 [~Guest31@2600:4041:5971:5e00:4d6e:9ad7:f792:26d9] has joined #bitcoin-core-dev 18:54 -!- Guest31 [~Guest31@2600:4041:5971:5e00:4d6e:9ad7:f792:26d9] has quit [Client Quit] 19:04 -!- kevkevin [~kevkevin@209.242.39.30] has joined #bitcoin-core-dev 19:11 -!- SpellChecker_ [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev 19:13 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Ping timeout: 264 seconds] 19:25 -!- jon_atack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 19:27 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 244 seconds] 19:27 -!- kevkevin [~kevkevin@209.242.39.30] has quit [Ping timeout: 252 seconds] 19:36 -!- greypw14 [~greypw@user/greypw] has quit [Remote host closed the connection] 19:36 -!- greypw14 [~greypw@user/greypw] has joined #bitcoin-core-dev 19:53 -!- edverma__ [~edverma@107-142-174-166.lightspeed.tukrga.sbcglobal.net] has joined #bitcoin-core-dev 19:54 -!- kevkevin [~kevkevin@209.242.39.30] has joined #bitcoin-core-dev 19:54 -!- edverm___ [~edverma@107.150.22.40] has joined #bitcoin-core-dev 19:56 -!- edverma [~edverma@92.119.18.232] has quit [Ping timeout: 276 seconds] 19:56 -!- edver____ [~edverma@45.134.140.151] has joined #bitcoin-core-dev 19:58 -!- edverma__ [~edverma@107-142-174-166.lightspeed.tukrga.sbcglobal.net] has quit [Ping timeout: 244 seconds] 20:00 -!- edverm___ [~edverma@107.150.22.40] has quit [Ping timeout: 244 seconds] 20:10 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 20:17 -!- itsarjn [~itsarjn@user/itsarjn] has joined #bitcoin-core-dev 20:27 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has quit [Quit: PaperSword] 20:37 -!- edver____ [~edverma@45.134.140.151] has quit [] 20:38 -!- edverma [~edverma@45.134.140.151] has joined #bitcoin-core-dev 20:40 -!- itsarjn [~itsarjn@user/itsarjn] has quit [Remote host closed the connection] 20:41 -!- edverma [~edverma@45.134.140.151] has quit [Client Quit] 20:42 -!- edverma [~edverma@45.134.140.151] has joined #bitcoin-core-dev 20:46 -!- itsarjn [~itsarjn@user/itsarjn] has joined #bitcoin-core-dev 20:52 < Sjors[m]> TIL about -blockreconstructionextratxn 21:00 -!- kevkevin [~kevkevin@209.242.39.30] has quit [Ping timeout: 244 seconds] 21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection] 21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev 21:49 -!- kevkevin [~kevkevin@209.242.39.30] has joined #bitcoin-core-dev 21:53 -!- kevkevin [~kevkevin@209.242.39.30] has quit [Ping timeout: 260 seconds] 22:01 -!- mcey_ [~emcy@148.252.147.100] has quit [Remote host closed the connection] 22:01 -!- mcey_ [~emcy@148.252.147.100] has joined #bitcoin-core-dev 22:13 -!- itsarjn [~itsarjn@user/itsarjn] has quit [Remote host closed the connection] 22:15 -!- itsarjn [~itsarjn@user/itsarjn] has joined #bitcoin-core-dev 22:17 -!- kevkevin [~kevkevin@209.242.39.30] has joined #bitcoin-core-dev 22:44 -!- instagibbs1 [~instagibb@pool-100-15-116-202.washdc.fios.verizon.net] has joined #bitcoin-core-dev 22:46 -!- instagibbs [~instagibb@pool-100-15-116-202.washdc.fios.verizon.net] has quit [Ping timeout: 260 seconds] 22:46 -!- instagibbs1 is now known as instagibbs 22:52 -!- kevkevin [~kevkevin@209.242.39.30] has quit [Ping timeout: 272 seconds] 23:04 -!- kevkevin [~kevkevin@209.242.39.30] has joined #bitcoin-core-dev 23:13 -!- itsarjn [~itsarjn@user/itsarjn] has quit [Remote host closed the connection] 23:18 -!- itsarjn [~itsarjn@user/itsarjn] has joined #bitcoin-core-dev 23:24 -!- kevkevin [~kevkevin@209.242.39.30] has quit [Ping timeout: 276 seconds] 23:36 -!- kevkevin [~kevkevin@209.242.39.30] has joined #bitcoin-core-dev 23:41 -!- kevkevin [~kevkevin@209.242.39.30] has quit [Ping timeout: 252 seconds] 23:46 -!- javi404 [~quassel@2601:58b:4880:48b1:3beb:fd1f:824f:3caa] has quit [Quit: No Ping reply in 180 seconds.] 23:46 -!- javi404 [~quassel@2601:58b:4880:48b1:3beb:fd1f:824f:3caa] has joined #bitcoin-core-dev --- Log closed Fri Dec 13 00:00:17 2024