--- Log opened Sat Mar 15 00:00:45 2025
00:11 -!- MyNetAz [~MyNetAz@user/MyNetAz] has quit [Remote host closed the connection]
00:12 -!- MyNetAz [~MyNetAz@user/MyNetAz] has joined #bitcoin-core-dev
00:52 -!- zeropoint [~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net] has quit [Quit: leaving]
01:07 < bitcoin-git> [bitcoin] maflcko opened pull request #32074: contrib: Make deterministic-coverage error messages more readable (master...2503-det-cov-err) https://github.com/bitcoin/bitcoin/pull/32074
01:18 -!- Christoph_ [~Christoph@2a02:810d:138e:3c00:d8df:4fd4:294f:4602] has joined #bitcoin-core-dev
01:36 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has joined #bitcoin-core-dev
01:44 -!- salvatoshi_ [~salvatosh@2a01cb08004728002aafb59aa11c7ee0.ipv6.abo.wanadoo.fr] has joined #bitcoin-core-dev
01:44 -!- bitdex_ [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
01:45 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Read error: Connection reset by peer]
01:48 -!- Christoph_ [~Christoph@2a02:810d:138e:3c00:d8df:4fd4:294f:4602] has quit [Quit: Christoph_]
02:04 -!- eval-exec [~Thunderbi@45.78.62.49.16clouds.com] has quit [Ping timeout: 244 seconds]
02:16 -!- robobub [uid248673@id-248673.uxbridge.irccloud.com] has quit [Quit: Connection closed for inactivity]
02:35 -!- Christoph_ [~Christoph@ip5f5beb53.dynamic.kabel-deutschland.de] has joined #bitcoin-core-dev
02:43 -!- Christoph_ [~Christoph@ip5f5beb53.dynamic.kabel-deutschland.de] has quit [Quit: Christoph_]
02:47 -!- salvatoshi_ [~salvatosh@2a01cb08004728002aafb59aa11c7ee0.ipv6.abo.wanadoo.fr] has quit [Remote host closed the connection]
02:47 -!- salvatoshi_ [~salvatosh@2a01cb08004728002feef4fdc6d2659f.ipv6.abo.wanadoo.fr] has joined #bitcoin-core-dev
03:05 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has quit [Quit: PaperSword]
03:17 -!- Guest5 [~Guest5@2601:245:8200:e010:b0ef:919c:6301:20ed] has joined #bitcoin-core-dev
03:19 -!- Guest5 [~Guest5@2601:245:8200:e010:b0ef:919c:6301:20ed] has quit [Client Quit]
03:38 -!- jurraca [~jurraca@lfbn-idf1-1-1967-185.w90-127.abo.wanadoo.fr] has quit [Quit: leaving]
04:20 -!- pyth [~pyth@user/pyth] has joined #bitcoin-core-dev
04:51 -!- sliv3r__ [~sliv3r__@user/sliv3r-:76883] has joined #bitcoin-core-dev
04:52 -!- eval-exec [~Thunderbi@154.201.95.126] has joined #bitcoin-core-dev
05:27 -!- jonatack [~jonatack@user/jonatack] has quit [Read error: Connection reset by peer]
06:02 < pinheadmz> darosior i tried to join that channel :-P
06:03 < pinheadmz> https://script.savingsatoshi.com/
06:06 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
06:46 -!- sliv3r__ [~sliv3r__@user/sliv3r-:76883] has quit [Ping timeout: 240 seconds]
06:48 -!- Guest13 [~Guest13@89.198.134.238] has joined #bitcoin-core-dev
06:48 -!- Guest13 [~Guest13@89.198.134.238] has quit [Client Quit]
07:03 < bitcoin-git> [bitcoin] sekomer opened pull request #32077: style: Fix spacing in script.h for OP_TRUE definition (master...master) https://github.com/bitcoin/bitcoin/pull/32077
07:17 -!- MyNetAz [~MyNetAz@user/MyNetAz] has quit [Remote host closed the connection]
07:41 -!- MyNetAz [~MyNetAz@user/MyNetAz] has joined #bitcoin-core-dev
07:44 -!- emzy [~quassel@user/emzy] has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.]
07:47 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
08:04 -!- emzy [~quassel@user/emzy] has joined #bitcoin-core-dev
08:31 -!- Christoph_ [~Christoph@2a02:810d:138e:3c00:90be:878d:2613:fee0] has joined #bitcoin-core-dev
08:34 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 245 seconds]
08:35 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
08:40 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 252 seconds]
08:42 -!- eval-exec [~Thunderbi@154.201.95.126] has quit [Remote host closed the connection]
08:43 -!- montxero [~user@27.96.222.164] has joined #bitcoin-core-dev
08:43 -!- bugs_ [~bugs@user/bugs/x-5128603] has joined #bitcoin-core-dev
08:46 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
08:52 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [Closing Window]
08:56 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
08:56 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
08:59 < darosior> nice!
09:09 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 248 seconds]
09:26 -!- jadi [~jadi@d207-81-160-78.bchsia.telus.net] has joined #bitcoin-core-dev
09:38 -!- Christoph_ [~Christoph@2a02:810d:138e:3c00:90be:878d:2613:fee0] has quit [Quit: Christoph_]
09:39 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
09:44 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 244 seconds]
09:52 -!- jespada [~jespada@2800:a4:227d:6600:1824:3b21:be45:3217] has joined #bitcoin-core-dev
09:53 -!- jespada [~jespada@2800:a4:227d:6600:1824:3b21:be45:3217] has quit [Client Quit]
09:57 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
10:03 -!- Christoph_ [~Christoph@2a02:810d:138e:3c00:90be:878d:2613:fee0] has joined #bitcoin-core-dev
10:05 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 265 seconds]
10:14 -!- Guest57 [~Guest57@2603-9001-54f0-7040-4e20-bbc6-8989-e8f5.inf6.spectrum.com] has joined #bitcoin-core-dev
10:21 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
10:37 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 265 seconds]
10:42 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
10:43 -!- jadi [~jadi@d207-81-160-78.bchsia.telus.net] has quit [Ping timeout: 272 seconds]
10:46 -!- Cory [~Cory@user/pasha] has joined #bitcoin-core-dev
10:48 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 248 seconds]
10:51 -!- jespada [~jespada@2800:a4:227d:6600:cfe:ced4:91ef:2cf8] has joined #bitcoin-core-dev
10:54 -!- jespada [~jespada@2800:a4:227d:6600:cfe:ced4:91ef:2cf8] has quit [Client Quit]
11:05 -!- Guest57 [~Guest57@2603-9001-54f0-7040-4e20-bbc6-8989-e8f5.inf6.spectrum.com] has quit [Ping timeout: 240 seconds]
11:06 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
11:10 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 244 seconds]
11:11 -!- jadi [~jadi@d207-81-160-78.bchsia.telus.net] has joined #bitcoin-core-dev
11:13 -!- andytoshi [~apoelstra@user/andytoshi] has quit [Ping timeout: 260 seconds]
11:14 -!- andytoshi [~apoelstra@user/andytoshi] has joined #bitcoin-core-dev
11:25 -!- Cory [~Cory@user/pasha] has quit [Quit: Client closed]
11:25 -!- Cory [~Cory@user/pasha] has joined #bitcoin-core-dev
11:28 -!- Cory [~Cory@user/pasha] has quit [Client Quit]
11:28 -!- Cory [~Cory@user/pasha] has joined #bitcoin-core-dev
11:37 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 264 seconds]
11:38 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
11:42 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
11:43 -!- Christoph_ [~Christoph@2a02:810d:138e:3c00:90be:878d:2613:fee0] has quit [Quit: Christoph_]
11:51 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 246 seconds]
12:16 -!- Christoph_ [~Christoph@2a02:810d:138e:3c00:a81b:9f52:f66e:a170] has joined #bitcoin-core-dev
12:22 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
12:28 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 244 seconds]
12:33 -!- Christoph__ [~Christoph@95.91.235.83] has joined #bitcoin-core-dev
12:34 -!- Christoph_ [~Christoph@2a02:810d:138e:3c00:a81b:9f52:f66e:a170] has quit [Ping timeout: 260 seconds]
12:38 < bitcoin-git> [bitcoin] maflcko closed pull request #32077: style: Fix spacing in script.h for OP_TRUE definition (master...master) https://github.com/bitcoin/bitcoin/pull/32077
12:46 -!- Christoph__ [~Christoph@95.91.235.83] has quit [Quit: Christoph__]
12:57 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
13:02 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 244 seconds]
13:11 < pinheadmz> maflcko how do you decide if a typo or other minor PR should be closed? sometimes contributors pile on ACKs even if its just changing a single word
13:12 < pinheadmz> i guess the Q is, do new contirbutors who start by fixing a word come back and add something more meaningful
13:23 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
13:31 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 246 seconds]
13:38 -!- jadi [~jadi@d207-81-160-78.bchsia.telus.net] has quit [Ping timeout: 252 seconds]
13:39 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
13:51 < darosior> https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#refactoring states "Pull requests that refactor the code should not be made by new contributors. It requires a certain level of experience to know where the code belongs to and to understand the full ramification [...]. Trivial pull requests or pull requests that refactor the code with
13:51 < darosior> no clear benefits may be immediately closed by the maintainers to reduce unnecessary workload on reviewing."
14:11 -!- Cory [~Cory@user/pasha] has quit [Quit: Client closed]
14:11 -!- Cory [~Cory@user/pasha] has joined #bitcoin-core-dev
14:35 -!- bugs_ [~bugs@user/bugs/x-5128603] has quit [Quit: Leaving]
14:43 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 265 seconds]
15:07 -!- andytoshi [~apoelstra@user/andytoshi] has quit [Ping timeout: 260 seconds]
15:08 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
15:10 -!- jadi [~jadi@d207-81-160-78.bchsia.telus.net] has joined #bitcoin-core-dev
15:17 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 244 seconds]
15:26 < fjahr> pinheadmz: I think the answer to your question is no because the contributors that make meaningful contributions and stay around for longer (the people we want) don't start out like this. At least I haven't observed any case of this. It's just demonstrating a very different mindset. Working on core requires interest in deep thinking and a lot of patience, fixing a typo is the polar opposite of that.
15:26 < fjahr> But if anyone here has started out by fixing typos please speak up, I am happy to be proven wrong :)
15:27 -!- dviola [~diego@user/dviola] has quit [Ping timeout: 248 seconds]
15:30 -!- andytoshi [~apoelstra@user/andytoshi] has joined #bitcoin-core-dev
15:32 < fjahr> And I would appeal to the contributors that pile on ACKs on such changes to get their dopamine hits from reviewing something a bit more meaningful, no offense! Review time is a very scarce resource and typo fixes, formatting etc. can be done by machines.
15:36 -!- dviola [~diego@user/dviola] has joined #bitcoin-core-dev
15:45 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
15:50 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 246 seconds]
16:05 -!- conman [~con@180-150-21-3.b49615.mel.static.aussiebb.net] has joined #bitcoin-core-dev
16:08 < glozow> +1, ACKing trivial drive-bys when there are real PRs to review is like the project scrolling tiktok. it eats up attention that could be spent elsewhere, and little bits here and there add up.
16:15 -!- zeropoint [~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
16:18 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
16:23 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 248 seconds]
16:24 < sipa> trivial PRs should just be merged instantly by a maintainer if they feel it's sufficiently obvious, or not at all
16:24 < sipa> not worth wasting time on (including discussing it...)
16:33 -!- conman [~con@180-150-21-3.b49615.mel.static.aussiebb.net] has quit [Quit: Konversation terminated!]
16:50 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
16:53 -!- jadi [~jadi@d207-81-160-78.bchsia.telus.net] has quit [Ping timeout: 244 seconds]
16:56 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 245 seconds]
17:12 -!- salvatoshi_ [~salvatosh@2a01cb08004728002feef4fdc6d2659f.ipv6.abo.wanadoo.fr] has quit [Ping timeout: 244 seconds]
17:24 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
17:28 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 244 seconds]
17:41 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
17:46 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 248 seconds]
17:50 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
17:54 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 244 seconds]
18:23 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
18:27 -!- Cory [~Cory@user/pasha] has quit [Quit: Client closed]
18:27 -!- Cory [~Cory@user/pasha] has joined #bitcoin-core-dev
18:28 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 252 seconds]
18:41 -!- conman [~con@180-150-21-3.b49615.mel.static.aussiebb.net] has joined #bitcoin-core-dev
18:48 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
18:53 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 244 seconds]
18:54 < darosior> big +1 to what fjahr and glozow said about not only opening the trivial nit PR but also the "dopamine hit" of jumping in and ACKing them, worse yet bikeshedding them.
19:05 -!- Guest49 [~Guest49@217.64.103.75] has joined #bitcoin-core-dev
19:09 -!- Guest49 [~Guest49@217.64.103.75] has quit [Client Quit]
19:15 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
19:20 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 265 seconds]
19:37 -!- eval-exec [~Thunderbi@154.201.95.128] has joined #bitcoin-core-dev
19:49 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
19:54 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 252 seconds]
20:01 -!- SpellChecker_ [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
20:01 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection]
20:16 -!- conman [~con@180-150-21-3.b49615.mel.static.aussiebb.net] has quit [Quit: Konversation terminated!]
20:22 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
20:27 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 252 seconds]
20:27 -!- zeropoint [~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net] has quit [Quit: leaving]
20:41 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
20:42 -!- joetor5 [~joetor5@syn-070-119-066-121.res.spectrum.com] has joined #bitcoin-core-dev
20:44 -!- eval-exec [~Thunderbi@154.201.95.128] has quit [Remote host closed the connection]
20:44 -!- eval-exec [~Thunderbi@45.78.57.250.16clouds.com] has joined #bitcoin-core-dev
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:07 -!- joetor5 [~joetor5@syn-070-119-066-121.res.spectrum.com] has quit [Quit: Client closed]
22:26 -!- Flow [~none@gentoo/developer/flow] has quit [Ping timeout: 245 seconds]
22:32 -!- agentcasey [~agentcase@143-42-229-181.ip.linodeusercontent.com] has quit [Read error: Connection reset by peer]
22:33 -!- agentcasey [~agentcase@143-42-229-181.ip.linodeusercontent.com] has joined #bitcoin-core-dev
22:38 -!- Flow [~none@gentoo/developer/flow] has joined #bitcoin-core-dev
23:20 -!- conman [~con@180-150-21-3.b49615.mel.static.aussiebb.net] has joined #bitcoin-core-dev
--- Log closed Sun Mar 16 00:00:47 2025