--- Log opened Sun Mar 16 00:00:47 2025 00:58 -!- greypw1495085720 [~greypw@user/greypw] has quit [Ping timeout: 264 seconds] 02:00 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/698f86964c68...51a20e56c2f9 02:00 < bitcoin-git> bitcoin/master 2819c51 Fabian Jahr: test: Use rpc_deprecated only for testing deprecation 02:00 < bitcoin-git> bitcoin/master 51a20e5 merge-script: Merge bitcoin/bitcoin#31977: test: Use rpc_deprecated only for testing dep... 02:00 < bitcoin-git> [bitcoin] fanquake merged pull request #31977: test: Use rpc_deprecated only for testing deprecation (master...2025-03-dep) https://github.com/bitcoin/bitcoin/pull/31977 02:03 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/51a20e56c2f9...ab2df1726ed1 02:03 < bitcoin-git> bitcoin/master bad1433 Lőrinc: fuzz: Always restrict base conversion input lengths 02:03 < bitcoin-git> bitcoin/master d5537c1 Lőrinc: fuzz: make sure DecodeBase58(Check) is called with valid values more often 02:03 < bitcoin-git> bitcoin/master ab2df17 merge-script: Merge bitcoin/bitcoin#31917: fuzz: provide more realistic values to the ba... 02:03 < bitcoin-git> [bitcoin] fanquake merged pull request #31917: fuzz: provide more realistic values to the base58(check) decoders (master...l0rinc/base-encoding-input-fuzz-size-reduction) https://github.com/bitcoin/bitcoin/pull/31917 02:08 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ab2df1726ed1...ca05b28710a2 02:08 < bitcoin-git> bitcoin/master fa43567 MarcoFalke: test: Prefer send_and_ping over send_message+sync_with_ping 02:08 < bitcoin-git> bitcoin/master fa9cf38 MarcoFalke: scripted-diff: test: Rename send_message to send_without_ping 02:08 < bitcoin-git> bitcoin/master ca05b28 merge-script: Merge bitcoin/bitcoin#31859: test: Rename send_message to send_without_ping 02:08 < bitcoin-git> [bitcoin] fanquake merged pull request #31859: test: Rename send_message to send_without_ping (master...2502-test-msg-sync) https://github.com/bitcoin/bitcoin/pull/31859 02:11 -!- salvatoshi_ [~salvatosh@2a01cb080047280036d5081c1b5556c4.ipv6.abo.wanadoo.fr] has joined #bitcoin-core-dev 02:13 -!- mcey_ [~emcy@148.252.146.82] has joined #bitcoin-core-dev 02:17 -!- mcey [~emcy@148.252.144.229] has quit [Ping timeout: 252 seconds] 02:22 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ca05b28710a2...83a9e55ae169 02:22 < bitcoin-git> bitcoin/master 9157d9e Sjors Provoost: build: use make < 3.82 syntax for define directive 02:22 < bitcoin-git> bitcoin/master 83a9e55 merge-script: Merge bitcoin/bitcoin#32070: build: use make < 3.82 syntax for define dire... 02:22 < bitcoin-git> [bitcoin] fanquake merged pull request #32070: build: use make 3.82 syntax for define directive (master...2025/03/capnp-make) https://github.com/bitcoin/bitcoin/pull/32070 02:22 -!- Christoph_ [~Christoph@2a02:810d:138e:3c00:d40d:afcc:a8ad:6bdf] has joined #bitcoin-core-dev 02:24 -!- Flow [~none@gentoo/developer/flow] has quit [Ping timeout: 260 seconds] 02:29 -!- Christoph_ [~Christoph@2a02:810d:138e:3c00:d40d:afcc:a8ad:6bdf] has quit [Quit: Christoph_] 02:39 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 252 seconds] 02:40 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 02:43 -!- Flow [~none@gentoo/developer/flow] has joined #bitcoin-core-dev 02:45 -!- eval-exec [~Thunderbi@45.78.57.250.16clouds.com] has quit [Ping timeout: 244 seconds] 02:52 -!- sliv3r__ [~sliv3r__@user/sliv3r-:76883] has joined #bitcoin-core-dev 02:56 -!- eval-exec [~Thunderbi@45.78.57.250.16clouds.com] has joined #bitcoin-core-dev 03:37 < Sjors[m]> In the example of #32077 we could have pointed the author to the earlier attempt to document all op codes. IIRC the decision then was to not bother, so that might justify not fixing individual typos either. 03:37 < corebot> https://github.com/bitcoin/bitcoin/issues/32077 | style: Fix spacing in script.h for OP_TRUE definition by sekomer · Pull Request #32077 · bitcoin/bitcoin · GitHub 03:38 < Sjors[m]> More generally we could encourage making a more ambitious fix, e.g. not just one typo but also the recent ones found by the linter. 03:40 < Sjors[m]> And maybe a placeholder text along the lines of what was said above about trivial changes by new contributors, which is nicer than just closing. Unless we're sure it's an AI. 03:41 < Sjors[m]> (with a link to the contributor guidelines) 03:50 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 246 seconds] 04:17 -!- MyNetAz [~MyNetAz@user/MyNetAz] has quit [Remote host closed the connection] 04:18 -!- MyNetAz [~MyNetAz@user/MyNetAz] has joined #bitcoin-core-dev 04:28 < instagibbs> I think those are slightly different cases (I felt adding a bunch of possibly misleading comments bad regardless of churn) but I think closing with a canned "this is why we don't touch consensus code for linty reasons" comment would be nice 04:31 -!- conman [~con@180-150-21-3.b49615.mel.static.aussiebb.net] has quit [Quit: Konversation terminated!] 04:43 -!- aleggg [~aleggg@177.204.160.122.dynamic.adsl.gvt.net.br] has quit [Remote host closed the connection] 05:12 -!- aleggg [~aleggg@177.204.160.122.dynamic.adsl.gvt.net.br] has joined #bitcoin-core-dev 05:17 -!- montxero [~user@27.96.222.164] has quit [Remote host closed the connection] 05:40 -!- jetpack [~jetpack@mcfly.vm.tornadovps.net] has quit [Quit: ZNC 1.8.2+deb2+deb11u1 - https://znc.in] 05:40 -!- jetpack [~jetpack@mcfly.vm.tornadovps.net] has joined #bitcoin-core-dev 05:55 -!- Guyver2 [Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev 05:58 -!- MyNetAz [~MyNetAz@user/MyNetAz] has quit [Remote host closed the connection] 05:59 -!- MyNetAz [~MyNetAz@user/MyNetAz] has joined #bitcoin-core-dev 06:00 -!- MyNetAz [~MyNetAz@user/MyNetAz] has quit [Remote host closed the connection] 06:19 -!- MyNetAz [~MyNetAz@user/MyNetAz] has joined #bitcoin-core-dev 06:20 -!- MyNetAz [~MyNetAz@user/MyNetAz] has quit [Remote host closed the connection] 06:33 -!- Cory [~Cory@user/pasha] has quit [Quit: Client closed] 06:33 -!- Cory [~Cory@user/pasha] has joined #bitcoin-core-dev 06:33 -!- MyNetAz [~MyNetAz@user/MyNetAz] has joined #bitcoin-core-dev 06:53 < bitcoin-git> [bitcoin] naiyoma opened pull request #32079: test: Add test coverage for rpcwhitelistdefault when unset (master...test/whitelistdeafult_test_followup) https://github.com/bitcoin/bitcoin/pull/32079 06:53 -!- pyth [~pyth@user/pyth] has quit [Read error: Connection reset by peer] 06:53 -!- pyth [~pyth@user/pyth] has joined #bitcoin-core-dev 07:09 -!- pyth [~pyth@user/pyth] has quit [Remote host closed the connection] 07:09 -!- pyth [~pyth@user/pyth] has joined #bitcoin-core-dev 07:27 -!- Cory [~Cory@user/pasha] has quit [Quit: Client closed] 07:27 -!- Cory [~Cory@user/pasha] has joined #bitcoin-core-dev 07:27 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/83a9e55ae169...70a0ee89c67e 07:27 < bitcoin-git> bitcoin/master 0294205 Martin Zumsande: test: fix intermittent failure in p2p_orphan_handling.py 07:27 < bitcoin-git> bitcoin/master 70a0ee8 merge-script: Merge bitcoin/bitcoin#32063: test: fix intermittent failure in p2p_orphan_... 07:27 < bitcoin-git> [bitcoin] fanquake merged pull request #32063: test: fix intermittent failure in p2p_orphan_handling.py (master...202503_test_fix_p2p_orphan) https://github.com/bitcoin/bitcoin/pull/32063 07:29 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/70a0ee89c67e...cd8089c20baa 07:29 < bitcoin-git> bitcoin/master 36b0713 furszy: test: fix intermittent failure in wallet_reorgsrestore.py 07:29 < bitcoin-git> bitcoin/master cd8089c merge-script: Merge bitcoin/bitcoin#32069: test: fix intermittent failure in wallet_reor... 07:29 < bitcoin-git> [bitcoin] fanquake merged pull request #32069: test: fix intermittent failure in wallet_reorgsrestore.py (master...2025_test_fix_wallet-reorgsrestore) https://github.com/bitcoin/bitcoin/pull/32069 07:40 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 07:42 -!- bitdex_ [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection] 07:49 -!- bugs_ [~bugs@user/bugs/x-5128603] has joined #bitcoin-core-dev 07:50 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection] 07:51 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 07:57 -!- mcey_ [~emcy@148.252.146.82] has quit [Ping timeout: 252 seconds] 07:59 -!- mcey [~emcy@148.252.146.82] has joined #bitcoin-core-dev 08:36 -!- eval-exec [~Thunderbi@45.78.57.250.16clouds.com] has quit [Ping timeout: 260 seconds] 09:05 -!- Guyver2 [Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [Closing Window] 09:22 < bitcoin-git> [gui] theStack opened pull request #858: qt: doc: adapt outdated binary paths to CMake changes (master...gui_adapt_binpaths_cmake_changes) https://github.com/bitcoin-core/gui/pull/858 09:48 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 264 seconds] 10:36 -!- antanst [~antanst@user/antanst] has quit [Read error: Connection reset by peer] 10:38 -!- antanst [~antanst@user/antanst] has joined #bitcoin-core-dev 10:41 -!- antanst [~antanst@user/antanst] has quit [Read error: Connection reset by peer] 10:43 -!- antanst [~antanst@user/antanst] has joined #bitcoin-core-dev 11:09 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 11:18 -!- adil [~Thunderbi@2402:d000:8134:2f97:c384:1f18:9ca6:4eff] has joined #bitcoin-core-dev 11:43 -!- OGU [~OGU@94.55.45.28] has joined #bitcoin-core-dev 11:48 -!- Guest78 [~Guest78@94.55.45.28] has joined #bitcoin-core-dev 11:52 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 252 seconds] 11:54 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 11:58 -!- Christoph_ [~Christoph@2a02:810d:138e:3c00:d40d:afcc:a8ad:6bdf] has joined #bitcoin-core-dev 12:01 -!- OGU [~OGU@user/OGU] has changed host 12:10 -!- Guest78 [~Guest78@94.55.45.28] has quit [Ping timeout: 240 seconds] 12:28 -!- adil [~Thunderbi@2402:d000:8134:2f97:c384:1f18:9ca6:4eff] has quit [Quit: adil] 12:40 -!- sliv3r__ [~sliv3r__@user/sliv3r-:76883] has quit [Quit: Client closed] 12:43 -!- arik__ [sid402902@id-402902.lymington.irccloud.com] has quit [Ping timeout: 244 seconds] 12:43 -!- arik__ [sid402902@id-402902.lymington.irccloud.com] has joined #bitcoin-core-dev 12:56 -!- adil [~Thunderbi@2402:d000:8134:2f97:c384:1f18:9ca6:4eff] has joined #bitcoin-core-dev 13:01 -!- Christoph_ [~Christoph@2a02:810d:138e:3c00:d40d:afcc:a8ad:6bdf] has quit [Quit: Christoph_] 13:03 -!- adil [~Thunderbi@2402:d000:8134:2f97:c384:1f18:9ca6:4eff] has quit [Quit: adil] 13:06 -!- jadi [~jadi@d207-81-160-78.bchsia.telus.net] has joined #bitcoin-core-dev 13:42 -!- Guest36 [~Guest36@nat-140-180-240-236.princeton.edu] has joined #bitcoin-core-dev 13:58 -!- Cory [~Cory@user/pasha] has quit [Quit: Client closed] 13:58 -!- Cory [~Cory@user/pasha] has joined #bitcoin-core-dev 13:58 -!- Cory [~Cory@user/pasha] has quit [Client Quit] 13:59 -!- Cory [~Cory@user/pasha] has joined #bitcoin-core-dev 14:03 -!- bugs_ [~bugs@user/bugs/x-5128603] has quit [Quit: Leaving] 14:10 -!- jadi [~jadi@d207-81-160-78.bchsia.telus.net] has quit [Ping timeout: 244 seconds] 14:11 -!- MyNetAz [~MyNetAz@user/MyNetAz] has quit [Remote host closed the connection] 14:18 -!- conman [~con@180-150-21-3.b49615.mel.static.aussiebb.net] has joined #bitcoin-core-dev 14:19 -!- Guest36 [~Guest36@nat-140-180-240-236.princeton.edu] has quit [Quit: Client closed] 14:21 -!- MyNetAz [~MyNetAz@user/MyNetAz] has joined #bitcoin-core-dev 14:22 -!- MyNetAz [~MyNetAz@user/MyNetAz] has quit [Remote host closed the connection] 14:26 -!- MyNetAz [~MyNetAz@user/MyNetAz] has joined #bitcoin-core-dev 14:27 -!- jadi [~jadi@d207-81-160-78.bchsia.telus.net] has joined #bitcoin-core-dev 15:11 -!- jadi [~jadi@d207-81-160-78.bchsia.telus.net] has quit [Ping timeout: 272 seconds] 15:30 -!- MyNetAz [~MyNetAz@user/MyNetAz] has quit [Remote host closed the connection] 15:36 -!- MyNetAz [~MyNetAz@user/MyNetAz] has joined #bitcoin-core-dev 15:36 -!- MyNetAz [~MyNetAz@user/MyNetAz] has quit [Remote host closed the connection] 15:43 -!- MyNetAz [~MyNetAz@user/MyNetAz] has joined #bitcoin-core-dev 15:43 -!- MyNetAz [~MyNetAz@user/MyNetAz] has quit [Remote host closed the connection] 15:54 -!- conman [~con@180-150-21-3.b49615.mel.static.aussiebb.net] has quit [Quit: Konversation terminated!] 16:05 -!- jadi [~jadi@d207-81-160-78.bchsia.telus.net] has joined #bitcoin-core-dev 16:09 -!- MyNetAz [~MyNetAz@user/MyNetAz] has joined #bitcoin-core-dev 16:16 -!- Cory [~Cory@user/pasha] has quit [Quit: Client closed] 16:16 -!- Cory [~Cory@user/pasha] has joined #bitcoin-core-dev 16:54 -!- salvatoshi_ [~salvatosh@2a01cb080047280036d5081c1b5556c4.ipv6.abo.wanadoo.fr] has quit [Ping timeout: 268 seconds] 18:09 -!- agentcasey [~agentcase@143-42-229-181.ip.linodeusercontent.com] has quit [Quit: ZNC 1.10.x-git-38-e8c4cda0 - https://znc.in] 18:11 -!- agentcasey [~agentcase@143-42-229-181.ip.linodeusercontent.com] has joined #bitcoin-core-dev 18:13 -!- Guest17 [~Guest17@2001:1388:80c:f794:7d17:f674:f699:ff6] has joined #bitcoin-core-dev 18:14 -!- Guest17 [~Guest17@2001:1388:80c:f794:7d17:f674:f699:ff6] has quit [Client Quit] 18:34 -!- mcey_ [~emcy@148.252.129.184] has joined #bitcoin-core-dev 18:37 -!- mcey [~emcy@148.252.146.82] has quit [Ping timeout: 252 seconds] 18:40 -!- eval-exec [~Thunderbi@154.201.95.128] has joined #bitcoin-core-dev 18:42 -!- MyNetAz [~MyNetAz@user/MyNetAz] has quit [Remote host closed the connection] 18:43 -!- MyNetAz [~MyNetAz@user/MyNetAz] has joined #bitcoin-core-dev 19:14 -!- conman [~con@180-150-21-3.b49615.mel.static.aussiebb.net] has joined #bitcoin-core-dev 19:16 -!- eval-exec [~Thunderbi@154.201.95.128] has quit [Remote host closed the connection] 19:17 -!- eval-exec [~Thunderbi@45.78.52.156.16clouds.com] has joined #bitcoin-core-dev 19:27 -!- jadi [~jadi@d207-81-160-78.bchsia.telus.net] has quit [Ping timeout: 246 seconds] 19:27 -!- MyNetAz [~MyNetAz@user/MyNetAz] has quit [Remote host closed the connection] 19:28 < bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/cd8089c20baa...5f4422d68dc3 19:28 < bitcoin-git> bitcoin/master 7ac281c Hodlinator: qa: Add missing coverage of corrupt indexes 19:28 < bitcoin-git> bitcoin/master 9bfb0d7 Hodlinator: qa: Remove unnecessary -txindex args 19:28 < bitcoin-git> bitcoin/master 3301d2c Hodlinator: qa: Wait for txindex to avoid race condition 19:28 < bitcoin-git> [bitcoin] fanquake merged pull request #32010: qa: Fix TxIndex race conditions (master...2025/02/txindex_test_race) https://github.com/bitcoin/bitcoin/pull/32010 19:29 -!- conman [~con@180-150-21-3.b49615.mel.static.aussiebb.net] has quit [Quit: Konversation terminated!] 19:29 -!- MyNetAz [~MyNetAz@user/MyNetAz] has joined #bitcoin-core-dev 19:41 -!- eval-exec [~Thunderbi@45.78.52.156.16clouds.com] has quit [Remote host closed the connection] 19:50 -!- eval-exec [~Thunderbi@45.78.52.156.16clouds.com] has joined #bitcoin-core-dev 19:57 -!- conman [~con@180-150-21-3.b49615.mel.static.aussiebb.net] has joined #bitcoin-core-dev 20:13 -!- eval-exec [~Thunderbi@45.78.52.156.16clouds.com] has quit [Remote host closed the connection] 20:14 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection] 20:14 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 20:19 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has joined #bitcoin-core-dev 20:22 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has quit [Read error: Connection reset by peer] 20:22 -!- PaperSword1 [~Thunderbi@securemail.qrsnap.io] has joined #bitcoin-core-dev 20:25 -!- PaperSword1 is now known as PaperSword 20:58 -!- kevkevin [~kevkevin@209.242.39.30] has joined #bitcoin-core-dev 21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection] 21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev 21:02 -!- adil [~Thunderbi@2402:4000:1084:23c:884d:42f0:375e:6e93] has joined #bitcoin-core-dev 21:47 -!- adil [~Thunderbi@2402:4000:1084:23c:884d:42f0:375e:6e93] has quit [Ping timeout: 260 seconds] 21:51 -!- MyNetAz [~MyNetAz@user/MyNetAz] has quit [Remote host closed the connection] 21:54 -!- jonatack [~jonatack@user/jonatack] has quit [Read error: Connection reset by peer] 21:54 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 21:55 -!- MyNetAz [~MyNetAz@user/MyNetAz] has joined #bitcoin-core-dev 21:56 -!- MyNetAz [~MyNetAz@user/MyNetAz] has quit [Remote host closed the connection] 22:10 < bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/5f4422d68dc3...a799415d84d3 22:10 < bitcoin-git> bitcoin/master 8327889 Lőrinc: scripted-diff: modernize outdated trait patterns - types 22:10 < bitcoin-git> bitcoin/master ab2b67f Lőrinc: scripted-diff: modernize outdated trait patterns - values 22:10 < bitcoin-git> bitcoin/master 4cd95a2 Lőrinc: refactor: modernize remaining outdated trait patterns 22:10 < bitcoin-git> [bitcoin] fanquake merged pull request #31904: refactor: modernize outdated trait patterns using helper aliases (C++14/C++17) (master...l0rinc/type-trait-simplifications) https://github.com/bitcoin/bitcoin/pull/31904 22:29 -!- salvatoshi_ [~salvatosh@2a01cb080047280021726fd50daed4e6.ipv6.abo.wanadoo.fr] has joined #bitcoin-core-dev 22:31 -!- agentcasey [~agentcase@143-42-229-181.ip.linodeusercontent.com] has quit [Read error: Connection reset by peer] 22:33 -!- agentcasey [agentcasey@2600:3c03::f03c:93ff:febe:5054] has joined #bitcoin-core-dev 22:34 -!- MyNetAz [~MyNetAz@user/MyNetAz] has joined #bitcoin-core-dev 22:43 -!- Christoph_ [~Christoph@2a02:810d:138e:3c00:d40d:afcc:a8ad:6bdf] has joined #bitcoin-core-dev 22:44 -!- Christoph_ [~Christoph@2a02:810d:138e:3c00:d40d:afcc:a8ad:6bdf] has quit [Client Quit] 23:01 < bitcoin-git> [bitcoin] bigspider opened pull request #32080: OP_CHECKCONTRACTVERIFY (master...ccv-core) https://github.com/bitcoin/bitcoin/pull/32080 23:05 -!- aleggg [~aleggg@177.204.160.122.dynamic.adsl.gvt.net.br] has quit [Ping timeout: 244 seconds] 23:05 -!- aleggg [~aleggg@177.18.56.31] has joined #bitcoin-core-dev 23:28 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 246 seconds] 23:28 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 23:56 -!- Guest31 [~Guest31@103.180.88.27] has joined #bitcoin-core-dev --- Log closed Mon Mar 17 00:00:47 2025