--- Log opened Mon Apr 28 00:00:29 2025
00:03 -!- letim1291 [~letim1291@102.218.210.11] has joined #bitcoin-core-dev
00:18 -!- letim1291 [~letim1291@102.218.210.11] has quit [Ping timeout: 240 seconds]
00:32 -!- Guyver2 [Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
00:59 -!- antanst4 [~antanst@user/antanst] has joined #bitcoin-core-dev
01:01 -!- antanst [~antanst@user/antanst] has quit [Ping timeout: 276 seconds]
01:01 -!- antanst4 is now known as antanst
01:37 -!- Guyver2 [Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [Closing Window]
01:41 < bitcoin-git> [bitcoin] maflcko opened pull request #32360:  test: Force named args in RPCOverloadWrapper optional args  (master...2504-named-args) https://github.com/bitcoin/bitcoin/pull/32360
02:01 -!- Christoph_ [~Christoph@host-88-217-174-126.customer.m-online.net] has quit [Quit: Christoph_]
02:02 -!- j03lliott [~j03lliott@2601:183:427d:18f0:c928:1470:854e:e374] has joined #bitcoin-core-dev
02:03 -!- j03lliott [~j03lliott@2601:183:427d:18f0:c928:1470:854e:e374] has quit [Client Quit]
02:04 -!- j03lliott [~j03lliott@2601:183:427d:18f0:c928:1470:854e:e374] has joined #bitcoin-core-dev
02:05 -!- Christoph_ [~Christoph@host-88-217-174-126.customer.m-online.net] has joined #bitcoin-core-dev
02:06 -!- j03lliott [~j03lliott@2601:183:427d:18f0:c928:1470:854e:e374] has quit [Client Quit]
02:26 -!- storopoli [~m-h2v7u5@user/storopoli] has quit [Ping timeout: 272 seconds]
02:26 -!- storopoli [~m-h2v7u5@user/storopoli] has joined #bitcoin-core-dev
02:27 -!- j03lliott [~j03lliott@2601:183:427d:18f0:c928:1470:854e:e374] has joined #bitcoin-core-dev
02:32 -!- j03lliott [~j03lliott@2601:183:427d:18f0:c928:1470:854e:e374] has quit [Ping timeout: 240 seconds]
02:44 -!- robszarka [~szarka@2603:3003:4eac:100:45f3:fb2a:cd95:1f01] has joined #bitcoin-core-dev
02:47 -!- szarka [~szarka@2603:3003:4eac:100:4c69:3dc9:7a09:5598] has quit [Ping timeout: 260 seconds]
02:52 -!- Christoph_ [~Christoph@host-88-217-174-126.customer.m-online.net] has quit [Quit: Christoph_]
02:52 -!- Christoph_ [~Christoph@host-88-217-174-126.customer.m-online.net] has joined #bitcoin-core-dev
03:01 -!- Christoph_ [~Christoph@host-88-217-174-126.customer.m-online.net] has quit [Ping timeout: 252 seconds]
03:03 -!- neutrino777 [~neutrino7@user/neutrino777] has quit [Ping timeout: 248 seconds]
03:07 -!- neutrino777 [~neutrino7@user/neutrino777] has joined #bitcoin-core-dev
03:07 -!- Christoph_ [~Christoph@host-88-217-174-126.customer.m-online.net] has joined #bitcoin-core-dev
03:12 -!- Christoph_ [~Christoph@host-88-217-174-126.customer.m-online.net] has quit [Ping timeout: 272 seconds]
03:36 -!- rkrux [~rkrux@user/rkrux] has joined #bitcoin-core-dev
03:37 -!- sliv3r__ [~sliv3r__@user/sliv3r-:76883] has quit [Ping timeout: 248 seconds]
03:38 -!- pablomartin [~pablomart@165.red-79-150-165.dynamicip.rima-tde.net] has quit [Ping timeout: 276 seconds]
03:40 < rkrux> hey, re this PR: #29124, it's just 1 functional test and had 3 ACKs previously and I have ACKed it again after it needed a rebase. I believe it's rfm but does it require the other reviewers to ACK again?
03:40 < corebot> https://github.com/bitcoin/bitcoin/issues/29124 | test: Test that migration automatically repairs corrupted metadata with doubled derivation path by achow101 · Pull Request #29124 · bitcoin/bitcoin · GitHub
03:42 -!- Cory94 [~Cory94@user/pasha] has quit [Ping timeout: 240 seconds]
03:55 -!- Cory94 [~Cory94@user/pasha] has joined #bitcoin-core-dev
04:01 -!- jespada [~jespada@r186-49-240-45.dialup.adsl.anteldata.net.uy] has joined #bitcoin-core-dev
04:10 -!- rkrux [~rkrux@user/rkrux] has quit [Quit: Client closed]
04:24 -!- flooded [~flooded@149.102.226.199] has joined #bitcoin-core-dev
04:28 -!- kevkevin [~kevkevin@47.196.62.238] has joined #bitcoin-core-dev
04:50 -!- Christoph_ [~Christoph@host-88-217-174-126.customer.m-online.net] has joined #bitcoin-core-dev
04:55 -!- Christoph_ [~Christoph@host-88-217-174-126.customer.m-online.net] has quit [Ping timeout: 276 seconds]
04:57 -!- Christoph_ [~Christoph@host-88-217-174-126.customer.m-online.net] has joined #bitcoin-core-dev
05:01 -!- Christoph_ [~Christoph@host-88-217-174-126.customer.m-online.net] has quit [Ping timeout: 248 seconds]
05:10 -!- Christoph_ [~Christoph@host-88-217-174-126.customer.m-online.net] has joined #bitcoin-core-dev
05:14 -!- Cory94 [~Cory94@user/pasha] has quit [Quit: Client closed]
05:14 -!- Cory94 [~Cory94@user/pasha] has joined #bitcoin-core-dev
05:22 -!- kevkevin [~kevkevin@47.196.62.238] has quit [Remote host closed the connection]
05:24 -!- LainIwakura [~LainIwaku@user/LainIwakura] has joined #bitcoin-core-dev
05:24 -!- leeya [~leeya@c-73-140-49-72.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
05:27 -!- LainIwakura [~LainIwaku@user/LainIwakura] has quit [Client Quit]
05:29 -!- LainIwakura [~LainIwaku@user/LainIwakura] has joined #bitcoin-core-dev
05:30 -!- LainIwakura [~LainIwaku@user/LainIwakura] has quit [Client Quit]
05:32 < bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/d62c2d82e14d...f409444d0243
05:32 < bitcoin-git> bitcoin/master f57db75 David Gumberg: build: Use `-z noseparate-code` on NetBSD < 11.0
05:32 < bitcoin-git> bitcoin/master 00ba3ba David Gumberg: build: Drop option for disabling hardening
05:32 < bitcoin-git> bitcoin/master 77e553a David Gumberg: build: refactor: hardening flags -> core_interface
05:32 < bitcoin-git> [bitcoin] fanquake merged pull request #32071: build: Drop option to disable hardening. (master...3-14-25-drop-hardening-option) https://github.com/bitcoin/bitcoin/pull/32071
05:34 -!- LainIwakura [~LainIwaku@user/LainIwakura] has joined #bitcoin-core-dev
05:34 -!- pablomartin [~pablomart@217.130.254.81] has joined #bitcoin-core-dev
05:34 -!- leeya [~leeya@c-73-140-49-72.hsd1.wa.comcast.net] has quit [Ping timeout: 240 seconds]
05:42 -!- Christoph_ [~Christoph@host-88-217-174-126.customer.m-online.net] has quit [Ping timeout: 252 seconds]
05:47 -!- Christoph_ [~Christoph@host-88-217-174-126.customer.m-online.net] has joined #bitcoin-core-dev
05:49 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
05:52 -!- jespada_ [~jespada@r179-25-42-1.dialup.adsl.anteldata.net.uy] has joined #bitcoin-core-dev
05:54 -!- Christoph_ [~Christoph@host-88-217-174-126.customer.m-online.net] has quit [Ping timeout: 276 seconds]
05:54 -!- robszarka [~szarka@2603:3003:4eac:100:45f3:fb2a:cd95:1f01] has quit [Quit: Leaving]
05:54 -!- szarka [~szarka@2603:3003:4eac:100:45f3:fb2a:cd95:1f01] has joined #bitcoin-core-dev
05:55 -!- Christoph_ [~Christoph@host-88-217-174-126.customer.m-online.net] has joined #bitcoin-core-dev
05:55 -!- jespada [~jespada@r186-49-240-45.dialup.adsl.anteldata.net.uy] has quit [Ping timeout: 260 seconds]
06:02 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
06:06 -!- sliv3r__ [~sliv3r__@user/sliv3r-:76883] has joined #bitcoin-core-dev
06:06 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev []
06:06 -!- pablomartin [~pablomart@217.130.254.81] has quit [Ping timeout: 248 seconds]
06:07 < bitcoin-git> [bitcoincore.org] darosior opened pull request #1127: Add security advisory for remaining CVE-2024-52919 issue (master...2503_CVE-2024-52919_again) https://github.com/bitcoin-core/bitcoincore.org/pull/1127
06:20 -!- Cory94 [~Cory94@user/pasha] has quit [Quit: Client closed]
06:20 -!- Cory94 [~Cory94@user/pasha] has joined #bitcoin-core-dev
06:40 -!- katsu_ [~0x0ff@user/0x0ff/x-0302470] has joined #bitcoin-core-dev
06:43 < bitcoin-git> [bitcoin] 9AeinBagheri9 opened pull request #32362: Update SECURITY.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/32362
06:43 -!- katsu [~0x0ff@user/0x0ff/x-0302470] has quit [Ping timeout: 248 seconds]
06:43 < bitcoin-git> [bitcoin] fanquake closed pull request #32362: Update SECURITY.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/32362
06:43 -!- katsu_ is now known as katsu
06:51 < bitcoin-git> [bitcoin] GarmashAlex opened pull request #32363: ci: Use previous releases in tests on Windows (master...hpp1) https://github.com/bitcoin/bitcoin/pull/32363
06:51 < bitcoin-git> [bitcoin] DrahtBot closed pull request #32363: ci: Use previous releases in tests on Windows (master...hpp1) https://github.com/bitcoin/bitcoin/pull/32363
06:53 < bitcoin-git> [bitcoin] hebasto reopened pull request #32363: ci: Use previous releases in tests on Windows (master...hpp1) https://github.com/bitcoin/bitcoin/pull/32363
06:57 -!- LainIwakura [~LainIwaku@user/LainIwakura] has quit [Quit: Client closed]
07:01 < hebasto> maflcko: that ^ PR looks legit
07:08 -!- LainIwakura [~LainIwaku@user/LainIwakura] has joined #bitcoin-core-dev
07:13 -!- bugs_ [~bugs@user/bugs/x-5128603] has joined #bitcoin-core-dev
07:18 -!- MrHAPPY [~pxq@user/MrHAPPY] has joined #bitcoin-core-dev
07:19 -!- leeya [~leeya@c-73-140-49-72.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
07:33 -!- leeya [~leeya@c-73-140-49-72.hsd1.wa.comcast.net] has quit [Ping timeout: 240 seconds]
07:37 < fanquake> hebasto: why? It's the same author who's been spamming crypto projects with AI generated garbage
07:38 < fanquake> The PR description alone is obviously AI
07:38 < fanquake> Half the code changes don't make snese
07:38 < maflcko> hebasto: thx. The rule was added, to close spam such as https://github.com/bitcoin/bitcoin/pull/32228/files. But I removed it in https://github.com/maflcko/DrahtBot/commit/d5ce5a7859709423422872daef6c43513bfd80f4 again. 
07:39 < fanquake> maflacko: it was correct here though?
07:39 < fanquake> *maflcko
07:39 < maflcko> fanquake: Yeah, I had the impression this was AI generated, but some original thought may have gone into it
07:40 < maflcko> idk, happy to wait a day how the feedback is addressed 
07:42 < maflcko> Also, could run the CI to check if its passing, as this is a ci-only change. If it isn't passing, it should be easy to reject
07:42 < fanquake> I think it's already failing multiple CIs
07:44 < maflcko> ah, yeah. It looks like a bot or "ai agent"
07:51 < bitcoin-git> [bitcoin] stickies-v opened pull request #32364: refactor: validation: mark CheckBlockIndex as const  (master...2025-04/const-checkblockindex) https://github.com/bitcoin/bitcoin/pull/32364
07:55 -!- Christoph_ [~Christoph@host-88-217-174-126.customer.m-online.net] has quit [Quit: Christoph_]
08:08 -!- eugenesiegel [~eugenesie@user/eugenesiegel] has joined #bitcoin-core-dev
08:15 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f409444d0243...3a29ba33dca6
08:15 -!- eugenesiegel [~eugenesie@user/eugenesiegel] has quit [Quit: Client closed]
08:15 < bitcoin-git> bitcoin/master 35e57fb Hennadii Stepanov: depends: Fix cross-compiling `qt` package from macOS to Windows
08:15 < bitcoin-git> bitcoin/master 3a29ba3 merge-script: Merge bitcoin/bitcoin#32357: depends: Fix cross-compiling `qt` package fro...
08:15 < bitcoin-git> [bitcoin] fanquake merged pull request #32357: depends: Fix cross-compiling `qt` package from macOS to Windows (master...250426-macos-to-windows) https://github.com/bitcoin/bitcoin/pull/32357
08:15 -!- eugenesiegel [~eugenesie@user/eugenesiegel] has joined #bitcoin-core-dev
08:15 -!- PaperSword1 [~Thunderbi@ec2-3-17-244-63.us-east-2.compute.amazonaws.com] has joined #bitcoin-core-dev
08:17 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has quit [Ping timeout: 260 seconds]
08:17 -!- PaperSword1 is now known as PaperSword
08:18 < bitcoin-git> [bitcoin] maflcko opened pull request #32365:  descriptors: Reject + sign while parsing unsigned (master...2504-int-parsing) https://github.com/bitcoin/bitcoin/pull/32365
08:24 -!- MrHAPPY [~pxq@user/MrHAPPY] has quit []
08:25 -!- Cory94 [~Cory94@user/pasha] has quit [Quit: Client closed]
08:25 -!- MrHAPPY [~pxq@user/MrHAPPY] has joined #bitcoin-core-dev
08:25 -!- Cory94 [~Cory94@user/pasha] has joined #bitcoin-core-dev
08:27 -!- eugenesiegel [~eugenesie@user/eugenesiegel] has quit [Quit: Client closed]
08:29 -!- MrHAPPY [~pxq@user/MrHAPPY] has quit [Ping timeout: 265 seconds]
08:31 -!- tinova4 [~tinova@217.160.209.135] has quit [Ping timeout: 248 seconds]
08:31 -!- tinova4 [~tinova@217.160.209.135] has joined #bitcoin-core-dev
08:32 -!- MrHAPPY [~pxq@user/MrHAPPY] has joined #bitcoin-core-dev
08:33 < bitcoin-git> [gui] D33r-Gee opened pull request #869: interface: Expose load utxo snapshot functionality (master...2025_gui_interfaces_loadsnapshot) https://github.com/bitcoin-core/gui/pull/869
08:40 -!- eugenesiegel [~eugenesie@user/eugenesiegel] has joined #bitcoin-core-dev
08:44 -!- sunyata [~sunyata@2a02:810a:1505:7400:55a3:b5f1:118c:37be] has joined #bitcoin-core-dev
08:48 -!- LainIwakura [~LainIwaku@user/LainIwakura] has quit [Quit: Client closed]
08:48 -!- eugenesiegel [~eugenesie@user/eugenesiegel] has quit [Quit: Client closed]
08:49 -!- eugenesiegel [~eugenesie@user/eugenesiegel] has joined #bitcoin-core-dev
08:55 < bitcoin-git> [bitcoin] stutxo opened pull request #32366: add ignore_incoming_blocks option to ProcessMessage and SendMessages (master...tx_only_mode) https://github.com/bitcoin/bitcoin/pull/32366
08:56 < bitcoin-git> [bitcoin] stutxo closed pull request #32366: add ignore_incoming_blocks option to ProcessMessage and SendMessages (master...tx_only_mode) https://github.com/bitcoin/bitcoin/pull/32366
08:56 -!- neutrino777 [~neutrino7@user/neutrino777] has quit [Read error: Connection reset by peer]
08:56 -!- neutrino777 [~neutrino7@user/neutrino777] has joined #bitcoin-core-dev
09:02 -!- bugs_ [~bugs@user/bugs/x-5128603] has quit [Quit: Leaving]
09:07 -!- sunyata [~sunyata@user/sunyata] has changed host
09:09 -!- LainIwakura [~LainIwaku@user/LainIwakura] has joined #bitcoin-core-dev
09:12 -!- sunyata [~sunyata@user/sunyata] has quit [Quit: sunyata]
09:13 -!- sunyata [~sunyata@2a02:810a:1505:7400:55a3:b5f1:118c:37be] has joined #bitcoin-core-dev
09:15 -!- LainIwakura [~LainIwaku@user/LainIwakura] has quit [Ping timeout: 240 seconds]
09:18 -!- sunyata [~sunyata@user/sunyata] has changed host
09:23 -!- badkat [~badkat@user/badkat] has quit [Ping timeout: 260 seconds]
09:26 -!- eugenesiegel [~eugenesie@user/eugenesiegel] has quit [Quit: Client closed]
09:26 -!- eugenesiegel [~eugenesie@user/eugenesiegel] has joined #bitcoin-core-dev
09:29 -!- LainIwakura [~LainIwaku@user/LainIwakura] has joined #bitcoin-core-dev
09:30 -!- sunyata [~sunyata@user/sunyata] has quit [Quit: sunyata]
09:35 < bitcoin-git> [bitcoin] hebasto opened pull request #32367: cmake: Check user-defined `APPEND_*FLAGS` variables early (master...250428-enable-lang) https://github.com/bitcoin/bitcoin/pull/32367
09:38 -!- cotsuka [~cotsuka@user/cotsuka] has quit [Remote host closed the connection]
09:39 -!- cotsuka [~cotsuka@user/cotsuka] has joined #bitcoin-core-dev
09:43 -!- Talkless [~Talkless@138.199.6.197] has joined #bitcoin-core-dev
09:57 -!- eugenesiegel [~eugenesie@user/eugenesiegel] has quit [Quit: Client closed]
10:04 -!- eugenesiegel [~eugenesie@user/eugenesiegel] has joined #bitcoin-core-dev
10:04 -!- hernanmarino [~hernanmar@181.85.34.115] has joined #bitcoin-core-dev
10:06 -!- hernanmarino_ [~hernanmar@181.85.34.115] has quit [Ping timeout: 245 seconds]
10:06 -!- nanotube [~nanotube@user/nanotube] has quit [Ping timeout: 276 seconds]
10:10 -!- badkat [~badkat@user/badkat] has joined #bitcoin-core-dev
10:27 -!- dermoth [~dermoth@user/dermoth] has quit [Ping timeout: 276 seconds]
10:27 -!- dermoth_ [~dermoth@user/dermoth] has joined #bitcoin-core-dev
10:30 -!- LainIwakura [~LainIwaku@user/LainIwakura] has quit [Ping timeout: 240 seconds]
10:32 < bitcoin-git> [bitcoin] tomasandroil closed pull request #32342: Fix missing error check in `set_clo_on_exec` for FD_CLOEXEC handling (master...fix/update) https://github.com/bitcoin/bitcoin/pull/32342
10:32 -!- dermoth_ is now known as dermoth
10:33 -!- eugenesiegel [~eugenesie@user/eugenesiegel] has quit [Ping timeout: 240 seconds]
10:39 -!- zeropoint [~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
10:49 -!- tinova4 [~tinova@217.160.209.135] has quit [Quit: Ping timeout (120 seconds)]
10:49 -!- tinova4 [~tinova@217.160.209.135] has joined #bitcoin-core-dev
11:02 -!- LainIwakura [~LainIwaku@user/LainIwakura] has joined #bitcoin-core-dev
11:35 -!- Cory94 [~Cory94@user/pasha] has quit [Quit: Client closed]
11:35 -!- Cory94 [~Cory94@user/pasha] has joined #bitcoin-core-dev
11:45 -!- mudsip [~mudsip@user/mudsip] has joined #bitcoin-core-dev
11:47 -!- mudsip [~mudsip@user/mudsip] has quit [Client Quit]
11:51 < bitcoin-git> [bitcoincore.org] glozow pushed 2 commits to master: https://github.com/bitcoin-core/bitcoincore.org/compare/130884f06460...6957ec9324a2
11:51 < bitcoin-git> bitcoincore.org/master 680a254 Antoine Poinsot: Add security advisory for remaining CVE-2024-52919 issue
11:51 < bitcoin-git> bitcoincore.org/master 6957ec9 merge-script: Merge bitcoin-core/bitcoincore.org#1127: Add security advisory for remaini...
11:51 < bitcoin-git> [bitcoincore.org] glozow merged pull request #1127: Add security advisory for remaining CVE-2024-52919 issue (master...2503_CVE-2024-52919_again) https://github.com/bitcoin-core/bitcoincore.org/pull/1127
11:53 -!- Cory43 [~Cory94@user/pasha] has joined #bitcoin-core-dev
11:56 -!- Cory94 [~Cory94@user/pasha] has quit [Ping timeout: 240 seconds]
12:19 -!- skr0 [~skr0@user/skr0] has joined #bitcoin-core-dev
12:28 -!- jetpack [~jetpack@mcfly.vm.tornadovps.net] has quit [Quit: ZNC 1.8.2+deb2+deb11u1 - https://znc.in]
12:29 -!- jetpack [~jetpack@mcfly.vm.tornadovps.net] has joined #bitcoin-core-dev
12:30 -!- Cory43 [~Cory94@user/pasha] has quit [Quit: Client closed]
12:30 -!- Cory43 [~Cory43@user/pasha] has joined #bitcoin-core-dev
12:39 -!- Talkless [~Talkless@138.199.6.197] has quit [Quit: Konversation terminated!]
12:41 < bitcoin-git> [bitcoin] achow101 pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/3a29ba33dca6...33e6538b3076
12:41 < bitcoin-git> bitcoin/master cccc1f4 MarcoFalke: test: Remove unused RPCOverloadWrapper is_cli field
12:41 < bitcoin-git> bitcoin/master aaaa453 MarcoFalke: test: Remove unused createwallet_passthrough
12:41 < bitcoin-git> bitcoin/master fa48be3 MarcoFalke: test: Force named args for RPCOverloadWrapper optional args
12:41 < bitcoin-git> [bitcoin] achow101 merged pull request #32360: test: Force named args for RPCOverloadWrapper optional args (master...2504-named-args) https://github.com/bitcoin/bitcoin/pull/32360
12:47 -!- LainIwakura [~LainIwaku@user/LainIwakura] has quit [Ping timeout: 240 seconds]
12:56 < bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/33e6538b3076...af6cffa36d12
12:56 < bitcoin-git> bitcoin/master fa58f40 MarcoFalke: test: Slim down previous releases bdb check
12:56 < bitcoin-git> bitcoin/master af6cffa Ava Chow: Merge bitcoin/bitcoin#32350: test: Slim down previous releases bdb check
12:56 < bitcoin-git> [bitcoin] achow101 merged pull request #32350: test: Slim down previous releases bdb check (master...2504-test-prev-rel) https://github.com/bitcoin/bitcoin/pull/32350
13:08 -!- Cory43 [~Cory43@user/pasha] has quit [Quit: Client closed]
13:09 -!- Cory43 [~Cory43@user/pasha] has joined #bitcoin-core-dev
13:09 -!- LainIwakura [~LainIwaku@user/LainIwakura] has joined #bitcoin-core-dev
13:10 < pinheadmz> run-clang-tidy locally giving me several "use starts_with instead of substr" errors in files I don't think I touched on this branch ... 
13:13 -!- Cory43 [~Cory43@user/pasha] has quit [Client Quit]
13:13 -!- Cory43 [~Cory43@user/pasha] has joined #bitcoin-core-dev
13:15 -!- Christoph_ [~Christoph@2a02:810d:1399:b700:fd45:f6a9:69a4:17c7] has joined #bitcoin-core-dev
13:20 < bitcoin-git> [bitcoin] Retropex opened pull request #32368: Catch nocive arbitrary data. (missing code for #32359) (master...data) https://github.com/bitcoin/bitcoin/pull/32368
13:43 -!- Cory43 [~Cory43@user/pasha] has quit [Quit: Client closed]
13:44 -!- Cory43 [~Cory43@user/pasha] has joined #bitcoin-core-dev
14:02 < darosior> I think it's now safe to remove the special-casing of witness-stripped error and always add the wtxid to the reject filter in case of script validation failure? It's been 4 years since wtxid relay was released and it's now ubiquitous.
14:05 < instagibbs> btcd afaik doesn't do wtxid relay, I think that's where we landed on being a concern? glozow
14:06 < darosior> I think the concern is only if a large part of the network doesn't do wtxid relay, so that shouldn
14:06 < darosior> t be an issue
14:10 -!- Christoph_ [~Christoph@2a02:810d:1399:b700:fd45:f6a9:69a4:17c7] has quit [Quit: Christoph_]
14:14 < bitcoin-git> [bitcoin] glozow pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/af6cffa36d12...a4eee6d50be0
14:14 < bitcoin-git> bitcoin/master c7e2b9e Ava Chow: tests: Test migration cleans up bad inactive chain derivation path
14:14 < bitcoin-git> bitcoin/master a4eee6d merge-script: Merge bitcoin/bitcoin#29124: test: Test that migration automatically repai...
14:14 < bitcoin-git> [bitcoin] glozow merged pull request #29124: test: Test that migration automatically repairs corrupted metadata with doubled derivation path (master...fix-double-keypath) https://github.com/bitcoin/bitcoin/pull/29124
14:21 -!- skr0 [~skr0@user/skr0] has quit [Quit: Leaving]
14:25 < sipa> The only node being protected by the "don't add wtxid to reject filter" is itself, right? It prevents a witness-stripping attacker from poisoning your cache, so that you can't receive from pre-wtxid nodes anymore.
14:26 < sipa> But this is only a concern when all your peers are pre-wtxid or non-relay nodes, or attackers.
14:36 < darosior> I think the concern is rather that an attacker poison the cache of a large chunk of the network with the honest node's witness-stripped txid. When honest nodes tries to broadcast it may find a path of honest relay toward miners but if those use txid-based relay then it wont be able to reach the miners.
14:37 < darosior> So i don't think doing this is really protecting the node itself, but rather if enough nodes on the network do it then it protects the honest broadcaster from not being able to reach the miners
14:38 < darosior> But it comes at their own expense, of course.
14:43 < bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a4eee6d50be0...65714c162c16
14:43 < bitcoin-git> bitcoin/master fadf12a MarcoFalke: test: Add missing check for empty stderr in util tester
14:43 < bitcoin-git> bitcoin/master 65714c1 Ava Chow: Merge bitcoin/bitcoin#32327: test: Add missing check for empty stderr in u...
14:44 < bitcoin-git> [bitcoin] achow101 merged pull request #32327: test: Add missing check for empty stderr in util tester (master...2504-test-util-empty-err) https://github.com/bitcoin/bitcoin/pull/32327
14:45 -!- LainIwakura [~LainIwaku@user/LainIwakura] has quit [Ping timeout: 240 seconds]
14:56 < bitcoin-git> [bitcoin] achow101 opened pull request #32369: test: Use the correct node for doubled keypath test (master...fix-double-keypath-test) https://github.com/bitcoin/bitcoin/pull/32369
15:05 < darosior> A side effect of removing the code to figure out whether validation failed because of a stripped witness, is that now a witness stripped transaction will be treated as a consensus failure and the node will be Misbehaving()'d.
15:10 -!- LainIwakura [~LainIwaku@user/LainIwakura] has joined #bitcoin-core-dev
15:18 -!- Guest49 [~Guest49@2601:601:8700:2350:3c67:3013:852c:e434] has joined #bitcoin-core-dev
15:30 -!- Guest49 [~Guest49@2601:601:8700:2350:3c67:3013:852c:e434] has quit [Ping timeout: 240 seconds]
15:44 -!- Guest49 [~Guest49@2601:601:8700:2350:3c67:3013:852c:e434] has joined #bitcoin-core-dev
15:44 -!- Guest49 [~Guest49@2601:601:8700:2350:3c67:3013:852c:e434] has quit [Client Quit]
15:49 < glozow> the attack is stopped if the btcd node manages to get it to at least 1 peer who does wtxidrelay. which… seems very reasonable
15:50 < glozow> darosior: wait that doesn’t seem good
16:18 -!- LainIwakura [~LainIwaku@user/LainIwakura] has quit [Quit: Client closed]
16:18 -!- Cory43 [~Cory43@user/pasha] has quit [Quit: Client closed]
16:18 -!- Cory43 [~Cory43@user/pasha] has joined #bitcoin-core-dev
16:20 -!- LainIwakura [~LainIwaku@user/LainIwakura] has joined #bitcoin-core-dev
16:27 -!- LainIwakura [~LainIwaku@user/LainIwakura] has quit [Quit: Client closed]
16:27 -!- jespada_ [~jespada@r179-25-42-1.dialup.adsl.anteldata.net.uy] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
16:28 < darosior> glozow: i can't think of an issue, what do you have in mind?
17:05 -!- BlueMatt[m] [~bluematt@2620:6e:a000:ce11::d] has quit [Ping timeout: 268 seconds]
17:05 -!- kvaciral[m] [~kvaciralx@2620:6e:a000:ce11::27] has quit [Ping timeout: 268 seconds]
17:06 -!- b10c[m] [~b10cb10cm@2620:6e:a000:ce11::1c] has quit [Ping timeout: 276 seconds]
17:17 -!- b10c[m] [~b10cb10cm@2620:6e:a000:ce11::1c] has joined #bitcoin-core-dev
17:18 -!- joetor5 [~Thunderbi@user/joetor5] has joined #bitcoin-core-dev
17:20 -!- kvaciral[m] [~kvaciralx@2620:6e:a000:ce11::27] has joined #bitcoin-core-dev
17:20 -!- BlueMatt[m] [~bluematt@2620:6e:a000:ce11::d] has joined #bitcoin-core-dev
17:27 -!- Cory43 [~Cory43@user/pasha] has quit [Quit: Client closed]
17:27 -!- Cory43 [~Cory43@user/pasha] has joined #bitcoin-core-dev
17:50 -!- Cory43 [~Cory43@user/pasha] has quit [Quit: Client closed]
17:50 -!- Cory43 [~Cory43@user/pasha] has joined #bitcoin-core-dev
18:03 -!- Guest50 [~Guest50@2001:d08:d1:43b8:5df7:5a83:b494:eb6f] has joined #bitcoin-core-dev
18:03 -!- Guest50 [~Guest50@2001:d08:d1:43b8:5df7:5a83:b494:eb6f] has quit [Client Quit]
18:17 < sipa> glozow: honest pre-segwit or pre-wtxid nodes will not relay witness-stripped transactions, i believe
18:17 < sipa> at least not bitcoin core ones
18:18 < sipa> so it shouldn't be possible to get a transitive failure
18:21 -!- zeropoint [~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net] has quit [Quit: leaving]
18:31 -!- joetor5 [~Thunderbi@user/joetor5] has quit [Ping timeout: 268 seconds]
18:34 -!- joetor5 [~Thunderbi@user/joetor5] has joined #bitcoin-core-dev
18:36 -!- joetor5 [~Thunderbi@user/joetor5] has quit [Client Quit]
19:13 -!- Cory43 [~Cory43@user/pasha] has quit [Quit: Client closed]
19:13 -!- Cory43 [~Cory43@user/pasha] has joined #bitcoin-core-dev
19:17 -!- kevkevin [~kevkevin@47.196.62.238] has joined #bitcoin-core-dev
19:17 -!- badkat [~badkat@user/badkat] has quit [Ping timeout: 276 seconds]
19:25 -!- Cory43 [~Cory43@user/pasha] has quit [Quit: Client closed]
19:25 -!- Cory43 [~Cory43@user/pasha] has joined #bitcoin-core-dev
19:40 -!- nanotube [~nanotube@user/nanotube] has joined #bitcoin-core-dev
19:55 < bitcoin-git> [bitcoin] LEGENDZENT opened pull request #32370: 4 million lost bitcoin (master...lost-bitcoin) https://github.com/bitcoin/bitcoin/pull/32370
19:57 < bitcoin-git> [bitcoin] achow101 closed pull request #32370: 4 million lost bitcoin (master...lost-bitcoin) https://github.com/bitcoin/bitcoin/pull/32370
19:58 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
20:15 < bitcoin-git> [bitcoincore.org] azuchi opened pull request #1128: Add japanese translation for security advisory for remaining CVE-2024-52919 issue (master...ja-translate-cve-2024-52919) https://github.com/bitcoin-core/bitcoincore.org/pull/1128
20:31 -!- PaperSword1 [~Thunderbi@securemail.qrsnap.io] has joined #bitcoin-core-dev
20:33 -!- PaperSword [~Thunderbi@ec2-3-17-244-63.us-east-2.compute.amazonaws.com] has quit [Ping timeout: 252 seconds]
20:33 -!- PaperSword1 is now known as PaperSword
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:05 -!- Cory43 [~Cory43@user/pasha] has quit [Quit: Client closed]
21:05 -!- Cory43 [~Cory43@user/pasha] has joined #bitcoin-core-dev
21:12 -!- Guest28 [~Guest28@ppp-124-122-193-67.revip2.asianet.co.th] has joined #bitcoin-core-dev
21:13 -!- Guest28 [~Guest28@ppp-124-122-193-67.revip2.asianet.co.th] has quit [Client Quit]
21:14 -!- kevkevin [~kevkevin@47.196.62.238] has quit [Remote host closed the connection]
22:10 -!- szarka [~szarka@2603:3003:4eac:100:45f3:fb2a:cd95:1f01] has quit [Quit: Leaving]
22:35 -!- PaperSword1 [~Thunderbi@ec2-3-17-244-63.us-east-2.compute.amazonaws.com] has joined #bitcoin-core-dev
22:36 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has quit [Ping timeout: 244 seconds]
22:36 -!- PaperSword1 is now known as PaperSword
22:44 -!- Christoph_ [~Christoph@host-88-217-174-126.customer.m-online.net] has joined #bitcoin-core-dev
22:57 -!- szarka [~szarka@2603:3003:4eac:100:f5df:c5dd:736b:6b81] has joined #bitcoin-core-dev
23:03 -!- jon_atack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
23:03 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 260 seconds]
23:08 -!- badkat [~badkat@user/badkat] has joined #bitcoin-core-dev
23:16 -!- Cory43 [~Cory43@user/pasha] has quit [Ping timeout: 240 seconds]
23:28 -!- Cory43 [~Cory43@user/pasha] has joined #bitcoin-core-dev
--- Log closed Tue Apr 29 00:00:29 2025