--- Log opened Tue Jun 03 00:00:02 2025
00:06 -!- kevkevin [~kevkevin@209.242.39.30] has joined #bitcoin-core-dev
00:07 -!- Christoph_ [~Christoph@host-88-217-174-126.customer.m-online.net] has quit [Quit: Christoph_]
00:15 -!- Christoph_ [~Christoph@host-88-217-174-126.customer.m-online.net] has joined #bitcoin-core-dev
00:18 -!- kevkevin [~kevkevin@209.242.39.30] has quit [Ping timeout: 260 seconds]
00:23 -!- kevkevin [~kevkevin@209.242.39.30] has joined #bitcoin-core-dev
00:34 -!- aleggg [~aleggg@201-68-135-131.dsl.telesp.net.br] has quit [Ping timeout: 272 seconds]
00:34 -!- aleggg [~aleggg@201-68-135-131.dsl.telesp.net.br] has joined #bitcoin-core-dev
00:38 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
00:40 -!- VonNaturAustreVe [~natur@user/vonnaturaustreve] has quit [Ping timeout: 265 seconds]
00:41 -!- l0rinc [~l0rinc@user/l0rinc] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
00:56 -!- gerle [~quassel@212-186-78-187.static.upcbusiness.at] has joined #bitcoin-core-dev
01:07 -!- kevkevin [~kevkevin@209.242.39.30] has quit [Ping timeout: 245 seconds]
01:10 < bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/2d819fa4dff9...e872a566f251
01:10 < bitcoin-git> bitcoin/master ee4406c fanquake: doc: update URLs
01:10 < bitcoin-git> bitcoin/master 21ee656 strmfos: doc: Remove obselete link in notificator.cpp
01:10 < bitcoin-git> bitcoin/master c797e50 fanquake: ci: update codespell to 2.4.1
01:10 < bitcoin-git> [bitcoin] fanquake merged pull request #32644: doc: miscellaneous changes (master...doc_misc) https://github.com/bitcoin/bitcoin/pull/32644
01:14 < bitcoin-git> [gui-qml] hebasto pushed 5 commits to main: https://github.com/bitcoin-core/gui-qml/compare/42f58adabcda...25a18f000374
01:14 < bitcoin-git> gui-qml/main 63e8494 goqusan: qml: Use content item on desktop wallets
01:14 < bitcoin-git> gui-qml/main 7c8a68c goqusan: qml: Fix layout in activity view
01:14 < bitcoin-git> gui-qml/main 9644ae9 goqusan: qml: Remove anchors from node settings
01:14 < bitcoin-git> [gui-qml] hebasto merged pull request #463: Fix layouts 1/n (main...layouts) https://github.com/bitcoin-core/gui-qml/pull/463
01:23 -!- Cory98 [~Cory98@user/pasha] has quit [Quit: Client closed]
01:23 -!- Cory98 [~Cory98@user/pasha] has joined #bitcoin-core-dev
01:44 -!- kevkevin [~kevkevin@209.242.39.30] has joined #bitcoin-core-dev
01:53 -!- kevkevin [~kevkevin@209.242.39.30] has quit [Ping timeout: 252 seconds]
01:55 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [Closing Window]
02:05 -!- l0rinc [~l0rinc@user/l0rinc] has joined #bitcoin-core-dev
02:12 -!- Christoph_ [~Christoph@host-88-217-174-126.customer.m-online.net] has quit [Quit: Christoph_]
02:16 -!- Christoph_ [~Christoph@host-88-217-174-126.customer.m-online.net] has joined #bitcoin-core-dev
02:21 -!- kevkevin [~kevkevin@209.242.39.30] has joined #bitcoin-core-dev
02:35 -!- kevkevin [~kevkevin@209.242.39.30] has quit [Ping timeout: 276 seconds]
02:52 -!- Christoph_ [~Christoph@host-88-217-174-126.customer.m-online.net] has quit [Quit: Christoph_]
03:02 -!- kevkevin [~kevkevin@209.242.39.30] has joined #bitcoin-core-dev
03:10 -!- kevkevin [~kevkevin@209.242.39.30] has quit [Ping timeout: 265 seconds]
03:13 -!- Cory98 [~Cory98@user/pasha] has quit [Quit: Client closed]
03:13 -!- Cory98 [~Cory98@user/pasha] has joined #bitcoin-core-dev
03:17 -!- Christoph_ [~Christoph@host-88-217-174-126.customer.m-online.net] has joined #bitcoin-core-dev
03:24 -!- kevkevin [~kevkevin@209.242.39.30] has joined #bitcoin-core-dev
03:36 -!- saturday7 [~saturday7@59.167.129.22] has quit [Read error: Connection reset by peer]
03:36 -!- saturday- [~saturday7@59.167.129.22] has joined #bitcoin-core-dev
03:41 -!- kevkevin [~kevkevin@209.242.39.30] has quit [Ping timeout: 244 seconds]
03:47 -!- b10c [~quassel@user/b10c] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
03:49 -!- b10c [~quassel@static.33.106.217.95.clients.your-server.de] has joined #bitcoin-core-dev
03:49 -!- b10c [~quassel@user/b10c] has changed host
03:56 -!- kevkevin [~kevkevin@209.242.39.30] has joined #bitcoin-core-dev
04:08 -!- Cory98 [~Cory98@user/pasha] has quit [Quit: Client closed]
04:09 -!- Cory98 [~Cory98@user/pasha] has joined #bitcoin-core-dev
04:21 -!- l0rinc [~l0rinc@user/l0rinc] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
04:37 -!- VonNaturAustreVe [~natur@2804:14c:65d7:8e6c:8c27:2fe6:a82c:ac20] has joined #bitcoin-core-dev
04:37 -!- VonNaturAustreVe [~natur@user/vonnaturaustreve] has changed host
04:42 -!- VonNaturAustreVe [~natur@user/vonnaturaustreve] has quit [Ping timeout: 272 seconds]
04:50 -!- VonNaturAustreVe [~natur@user/vonnaturaustreve] has joined #bitcoin-core-dev
04:50 -!- Christoph_ [~Christoph@host-88-217-174-126.customer.m-online.net] has quit [Quit: Christoph_]
04:52 -!- adil [~Thunderbi@2402:d000:8134:2f97:ad40:d4d:7bac:f3ee] has joined #bitcoin-core-dev
04:56 -!- adil [~Thunderbi@2402:d000:8134:2f97:ad40:d4d:7bac:f3ee] has quit [Client Quit]
04:56 -!- VonNaturAustreVe [~natur@user/vonnaturaustreve] has quit [Ping timeout: 252 seconds]
05:03 < bitcoin-git> [bitcoin] m3dwards opened pull request #32672: ci: update pwsh to use custom shell that fails-fast (master...250603-pwsh-fail-fast) https://github.com/bitcoin/bitcoin/pull/32672
05:03 -!- Christoph_ [~Christoph@host-88-217-174-126.customer.m-online.net] has joined #bitcoin-core-dev
05:08 -!- edouardparis [~m-f4c6gr@vps-24ad2e3d.vps.ovh.net] has joined #bitcoin-core-dev
05:10 -!- adil [~Thunderbi@2402:d000:8134:2f97:ad40:d4d:7bac:f3ee] has joined #bitcoin-core-dev
05:12 -!- adil [~Thunderbi@2402:d000:8134:2f97:ad40:d4d:7bac:f3ee] has quit [Client Quit]
05:23 -!- jespada [~jespada@r179-25-2-231.dialup.adsl.anteldata.net.uy] has joined #bitcoin-core-dev
05:31 -!- jespada [~jespada@r179-25-2-231.dialup.adsl.anteldata.net.uy] has quit [Read error: Connection reset by peer]
05:35 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
05:38 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
05:42 -!- jespada [~jespada@r179-25-2-231.dialup.adsl.anteldata.net.uy] has joined #bitcoin-core-dev
05:46 -!- edouardparis [~m-f4c6gr@user/edouardparis] has changed host
05:50 -!- Christoph_ [~Christoph@host-88-217-174-126.customer.m-online.net] has quit [Quit: Christoph_]
05:53 -!- Christoph_ [~Christoph@host-88-217-174-126.customer.m-online.net] has joined #bitcoin-core-dev
06:18 -!- VonNaturAustreVe [~natur@user/vonnaturaustreve] has joined #bitcoin-core-dev
06:23 < bitcoin-git> [bitcoin] maflcko opened pull request #32673:  clang-tidy: Apply modernize-deprecated-headers  (master...2506-cxx-headers-tidy) https://github.com/bitcoin/bitcoin/pull/32673
06:29 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has quit [Quit: PaperSword]
06:52 -!- Christoph_ [~Christoph@host-88-217-174-126.customer.m-online.net] has quit [Quit: Christoph_]
06:53 -!- Christoph_ [~Christoph@host-88-217-174-126.customer.m-online.net] has joined #bitcoin-core-dev
06:55 -!- bugs_ [~bugs@user/bugs/x-5128603] has joined #bitcoin-core-dev
07:24 -!- eugenesiegel [~eugenesie@user/eugenesiegel] has joined #bitcoin-core-dev
07:44 -!- robszarka [~szarka@2603:3003:4eac:100:d555:3e6d:b41c:f882] has joined #bitcoin-core-dev
07:48 -!- szarka [~szarka@2603:3003:4eac:100:2d76:3fc:28b8:bb9c] has quit [Ping timeout: 276 seconds]
07:59 -!- eugenesiegel [~eugenesie@user/eugenesiegel] has quit [Quit: Client closed]
07:59 -!- l0rinc [~l0rinc@user/l0rinc] has joined #bitcoin-core-dev
07:59 -!- eugenesiegel [~eugenesie@user/eugenesiegel] has joined #bitcoin-core-dev
08:02 -!- gmaxwell [~gmaxwell@user/gmaxwell] has quit [Ping timeout: 252 seconds]
08:07 -!- gmaxwell [~gmaxwell@user/gmaxwell] has joined #bitcoin-core-dev
08:08 -!- Cory98 [~Cory98@user/pasha] has quit [Quit: Client closed]
08:08 -!- Cory98 [~Cory98@user/pasha] has joined #bitcoin-core-dev
08:09 -!- RubenSomsen [sid301948@user/rubensomsen] has quit [Ping timeout: 268 seconds]
08:10 -!- zone117x [sid117212@id-117212.tinside.irccloud.com] has quit [Ping timeout: 272 seconds]
08:10 -!- entropyx [~blackbox@user/entropyx] has quit [Ping timeout: 248 seconds]
08:10 -!- dzxzg2 [~dzxzg@user/dzxzg] has quit [Ping timeout: 252 seconds]
08:11 -!- cmirror [~cmirror@4.53.92.114] has quit [Ping timeout: 272 seconds]
08:12 -!- entropyx [~blackbox@82.86.134.217] has joined #bitcoin-core-dev
08:12 -!- entropyx [~blackbox@user/entropyx] has changed host
08:12 -!- sugarpuff [sid92283@id-92283.lymington.irccloud.com] has quit [Ping timeout: 252 seconds]
08:12 -!- hardtotell0 [~hardtotel@user/hardtotell] has joined #bitcoin-core-dev
08:12 -!- hardtotell [~hardtotel@user/hardtotell] has quit [Ping timeout: 252 seconds]
08:12 -!- hardtotell0 is now known as hardtotell
08:13 -!- ajonas [uid385278@id-385278.helmsley.irccloud.com] has quit [Ping timeout: 268 seconds]
08:14 -!- RubenSomsen [sid301948@user/rubensomsen] has joined #bitcoin-core-dev
08:15 -!- zone117x [sid117212@tinside.irccloud.com] has joined #bitcoin-core-dev
08:15 -!- fjahr [sid374480@id-374480.uxbridge.irccloud.com] has quit [Ping timeout: 268 seconds]
08:16 -!- chjj [~chjj@user/chjj] has quit [Ping timeout: 268 seconds]
08:16 -!- dergoegge [sid453889@id-453889.lymington.irccloud.com] has quit [Ping timeout: 272 seconds]
08:16 -!- hebasto [sid449604@id-449604.uxbridge.irccloud.com] has quit [Ping timeout: 268 seconds]
08:17 -!- ajonas [uid385278@id-385278.helmsley.irccloud.com] has joined #bitcoin-core-dev
08:17 -!- dergoegge [sid453889@id-453889.lymington.irccloud.com] has joined #bitcoin-core-dev
08:17 -!- sugarpuff [sid92283@lymington.irccloud.com] has joined #bitcoin-core-dev
08:17 -!- Cory98 [~Cory98@user/pasha] has quit [Quit: Client closed]
08:17 -!- Cory98 [~Cory98@user/pasha] has joined #bitcoin-core-dev
08:18 -!- fanquake [sid369002@user/fanquake] has quit [Ping timeout: 272 seconds]
08:19 -!- fjahr [sid374480@id-374480.uxbridge.irccloud.com] has joined #bitcoin-core-dev
08:19 -!- chjj [~chjj@user/chjj] has joined #bitcoin-core-dev
08:19 -!- rszarka [~szarka@2603:3003:4eac:100:d555:3e6d:b41c:f882] has joined #bitcoin-core-dev
08:19 -!- stickies-v [sid544753@id-544753.uxbridge.irccloud.com] has quit [Ping timeout: 272 seconds]
08:20 -!- fanquake [sid369002@user/fanquake] has joined #bitcoin-core-dev
08:20 -!- moneyball______ [sid299869@id-299869.helmsley.irccloud.com] has quit [Ping timeout: 252 seconds]
08:20 -!- stickies-v [sid544753@id-544753.uxbridge.irccloud.com] has joined #bitcoin-core-dev
08:21 -!- hebasto [sid449604@id-449604.uxbridge.irccloud.com] has joined #bitcoin-core-dev
08:21 -!- szarka [~szarka@2603:3003:4eac:100:d555:3e6d:b41c:f882] has joined #bitcoin-core-dev
08:21 -!- glozow [sid453516@user/glozow] has quit [Ping timeout: 248 seconds]
08:22 -!- robszarka [~szarka@2603:3003:4eac:100:d555:3e6d:b41c:f882] has quit [Ping timeout: 248 seconds]
08:24 -!- rszarka [~szarka@2603:3003:4eac:100:d555:3e6d:b41c:f882] has quit [Ping timeout: 252 seconds]
08:24 -!- moneyball______ [sid299869@id-299869.helmsley.irccloud.com] has joined #bitcoin-core-dev
08:24 -!- glozow [sid453516@user/glozow] has joined #bitcoin-core-dev
08:27 -!- Christoph_ [~Christoph@host-88-217-174-126.customer.m-online.net] has quit [Quit: Christoph_]
08:34 -!- flooded [~flooded@37.120.219.243] has quit [Remote host closed the connection]
08:35 -!- flooded [~flooded@37.120.219.243] has joined #bitcoin-core-dev
08:52 -!- VonNaturAustreVe [~natur@user/vonnaturaustreve] has quit [Quit: Leaving]
08:56 -!- gerle [~quassel@212-186-78-187.static.upcbusiness.at] has quit [Quit: https://quassel-irc.org - Komfortabler Chat. Überall.]
08:57 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
08:58 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
08:58 -!- l0rinc [~l0rinc@user/l0rinc] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
09:14 -!- zeropoint [~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
09:15 -!- l0rinc [~l0rinc@user/l0rinc] has joined #bitcoin-core-dev
09:40 -!- johnzweng [~johnzweng@zweng.at] has quit [Quit: Leaving...]
09:44 -!- johnzweng [~johnzweng@zweng.at] has joined #bitcoin-core-dev
09:50 -!- l0rinc [~l0rinc@user/l0rinc] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
09:54 -!- szarka [~szarka@2603:3003:4eac:100:d555:3e6d:b41c:f882] has quit [Quit: Leaving]
09:54 -!- szarka [~szarka@2603:3003:4eac:100:d555:3e6d:b41c:f882] has joined #bitcoin-core-dev
09:55 -!- saturday7 [~saturday7@59.167.129.22] has joined #bitcoin-core-dev
09:56 -!- eugenesiegel [~eugenesie@user/eugenesiegel] has quit [Quit: Client closed]
09:58 -!- saturday- [~saturday7@59.167.129.22] has quit [Ping timeout: 260 seconds]
09:58 -!- Guest85 [~Guest85@102.90.101.70] has joined #bitcoin-core-dev
10:01 < bitcoin-git> [bitcoincore.org] sipa opened pull request #1139: Add statement on transaction relay (master...relay_statement) https://github.com/bitcoin-core/bitcoincore.org/pull/1139
10:03 -!- Guest85 [~Guest85@102.90.101.70] has quit [Ping timeout: 240 seconds]
10:04 < sipa> See the PR above https://github.com/bitcoin-core/bitcoincore.org/pull/1139. Please comment there if you'd like to add your name.
10:10 -!- Guest10 [~Guest10@182.2.234.226] has joined #bitcoin-core-dev
10:11 -!- Guest10 [~Guest10@182.2.234.226] has quit [Client Quit]
10:17 < bitcoin-git> [bitcoin] brunoerg opened pull request #32675: test: wallet: cover wallet passphrase with a null char (master...2025-06-test-wallet-passphrase-null) https://github.com/bitcoin/bitcoin/pull/32675
10:22 < dodo> sounds like an invitation to introduce new features through subtle bugs and inefficient hacks, which will then be made official for "efficiency" reasons
10:26 -!- Talkless [~Talkless@138.199.6.197] has joined #bitcoin-core-dev
10:28 < instagibbs> dodo additional test coverage is always welcome
10:53 < bitcoin-git> [bitcoin] mzumsande opened pull request #32676: test: apply microsecond precision to test framework logging (master...202506_test_log_micros) https://github.com/bitcoin/bitcoin/pull/32676
11:01 -!- jespada [~jespada@r179-25-2-231.dialup.adsl.anteldata.net.uy] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
11:04 -!- jespada [~jespada@r179-25-2-231.dialup.adsl.anteldata.net.uy] has joined #bitcoin-core-dev
11:04 -!- Zenton [~Zenton@user/zenton] has quit [Ping timeout: 268 seconds]
11:13 -!- Talkless [~Talkless@138.199.6.197] has quit [Quit: Konversation terminated!]
11:33 -!- dzxzg [~dzxzg@user/dzxzg] has joined #bitcoin-core-dev
11:44 -!- eugenesiegel [~eugenesie@user/eugenesiegel] has joined #bitcoin-core-dev
11:50 < bitcoin-git> [bitcoin] stringintech opened pull request #32677: test: headers sync timeout (master...2025/06/test-header-sync-timeout) https://github.com/bitcoin/bitcoin/pull/32677
11:52 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
11:55 -!- Murch[m] [~murch@user/murch] has changed host
12:13 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 268 seconds]
12:19 -!- mudsip [~mudsip@user/mudsip] has joined #bitcoin-core-dev
12:21 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e872a566f251...a980918f51d7
12:21 < bitcoin-git> bitcoin/master df9ebbf fanquake: depends: use "mkdir -p" when installing xproto
12:21 < bitcoin-git> bitcoin/master a980918 merge-script: Merge bitcoin/bitcoin#32568: depends: use "mkdir -p" when installing xproto
12:21 < bitcoin-git> [bitcoin] fanquake merged pull request #32568: depends: use "mkdir -p" when installing xproto (master...alpine_MKDIRPROG) https://github.com/bitcoin/bitcoin/pull/32568
12:24 -!- bugs_ [~bugs@user/bugs/x-5128603] has quit [Quit: Leaving]
12:27 -!- mudsip [~mudsip@user/mudsip] has quit []
13:19 -!- l0rinc [~l0rinc@user/l0rinc] has joined #bitcoin-core-dev
13:46 -!- jespada [~jespada@r179-25-2-231.dialup.adsl.anteldata.net.uy] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
13:51 -!- jespada [~jespada@r179-25-2-231.dialup.adsl.anteldata.net.uy] has joined #bitcoin-core-dev
13:56 -!- eugenesiegel [~eugenesie@user/eugenesiegel] has quit [Ping timeout: 240 seconds]
14:05 -!- wafflefrie [uid478376@id-478376.uxbridge.irccloud.com] has joined #bitcoin-core-dev
14:07 -!- jetpack [~jetpack@mcfly.vm.tornadovps.net] has quit [Quit: ZNC 1.8.2+deb2+deb11u1 - https://znc.in]
14:07 -!- jetpack [~jetpack@mcfly.vm.tornadovps.net] has joined #bitcoin-core-dev
14:12 -!- l0rinc [~l0rinc@user/l0rinc] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
14:14 -!- jespada [~jespada@r179-25-2-231.dialup.adsl.anteldata.net.uy] has quit [Ping timeout: 248 seconds]
14:17 -!- jespada [~jespada@r179-25-2-231.dialup.adsl.anteldata.net.uy] has joined #bitcoin-core-dev
14:18 -!- Cory98 [~Cory98@user/pasha] has quit [Quit: Client closed]
14:18 -!- Cory98 [~Cory98@user/pasha] has joined #bitcoin-core-dev
15:00 -!- greypw1495085720 [~greypw@user/greypw] has quit [Remote host closed the connection]
15:00 -!- greypw1495085720 [~greypw@user/greypw] has joined #bitcoin-core-dev
15:24 -!- bob_x1 [~bob_x@user/bob-x1/x-8934932] has quit [Ping timeout: 260 seconds]
15:38 -!- bob_x1 [~bob_x@user/bob-x1/x-8934932] has joined #bitcoin-core-dev
15:46 -!- Cory98 [~Cory98@user/pasha] has quit [Quit: Client closed]
15:47 -!- Cory98 [~Cory98@user/pasha] has joined #bitcoin-core-dev
16:24 -!- Cory98 [~Cory98@user/pasha] has quit [Quit: Client closed]
16:24 -!- Cory98 [~Cory98@user/pasha] has joined #bitcoin-core-dev
16:32 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has joined #bitcoin-core-dev
16:46 -!- S3RK [~S3RK@user/s3rk] has joined #bitcoin-core-dev
16:49 -!- S3RK_ [~S3RK@user/s3rk] has quit [Ping timeout: 245 seconds]
17:03 -!- jespada [~jespada@r179-25-2-231.dialup.adsl.anteldata.net.uy] has quit [Ping timeout: 252 seconds]
18:01 -!- _flood [~flooded@37.120.219.243] has joined #bitcoin-core-dev
18:01 -!- flooded [~flooded@37.120.219.243] has quit [Remote host closed the connection]
18:16 < PaperSword> How would one switch the networks of a Bitcoin node in the  function testing framework? Example I need some test vectors that are network specific.
18:20 < _aj_> PaperSword: set self.chain? see feature_signet or mining_mainnet?
18:24 -!- zeropoint [~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net] has quit [Quit: leaving]
18:34 < PaperSword> _aj_: Seems like it's good for same network, but what I need is to run a bitcoin node on mainnet, run address decoding checks, then do the same for a test network
18:37 < _aj_> PaperSword: write an add_options() that lets you use the same test case on multiple chains? (see mining_mainnet)
18:39 < PaperSword> Thanks! I see!
18:39 < sipa> PaperSword: maybe test vectors are a better fit for unit tests than functional tests?
18:40 < sipa> PaperSword: alternatively, you could have mainnet and testnet checks just in separate functional tests?
18:41 < PaperSword> This could be true. 
18:41 < PaperSword> My conundrum is that I am working on address decoding with per network errors. eg. using mainnet on signet would let the user know that they input a mainnet address on signet. So I had to modify the functional tests to now just on mainnet.
18:41 < PaperSword> The previous test vectors were a mix.
18:42 < PaperSword> essentially, I can prove the error messages work for a single net, not multiple at a functional level.
18:43 < PaperSword>  alternatively, you could have mainnet and testnet checks just in separate functional tests?
18:43 < PaperSword> 100%, but it gets sort of ugly with 2x file
18:43 < PaperSword> But that would solve this instantly.
18:44 < sipa> can't you have two functional tests in the same file? maybe you can even share thr functionality in a base class, and derive from it twice, once for each network
18:45 < sipa> unit tests seem easier though
18:53 < _aj_> hmm, i see a few 27.x and 28.x nodes connecting with v1 rather than v2; wonder if that's a fake node signal
18:54 < sipa> or they have an outdated addr record for you, which doesn't have the v2 service flag?
19:03 < _aj_> yeah could be, not seeing anything else obviously strange about them
19:21 -!- kevkevin_ [~kevkevin@209.242.39.30] has joined #bitcoin-core-dev
19:23 -!- kevkevin [~kevkevin@209.242.39.30] has quit [Ping timeout: 244 seconds]
19:38 -!- Cory98 [~Cory98@user/pasha] has quit [Quit: Client closed]
19:38 -!- Cory98 [~Cory98@user/pasha] has joined #bitcoin-core-dev
19:54 < PaperSword> sipa: https://github.com/bitcoin/bitcoin/pull/27260/commits/2f2470e844c79695df0140103c73d742371554cc
19:55 < PaperSword> Oh sorry for the tag! meant to say that I get the multi net functional testing working
19:55 < PaperSword> Even got to fix up some tests that were previously commented out :D 
20:12 -!- sliv3r__ [~sliv3r__@user/sliv3r-:76883] has quit [Read error: Connection reset by peer]
20:12 -!- sliv3r__ [~sliv3r__@user/sliv3r-:76883] has joined #bitcoin-core-dev
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:21 -!- Cory98 [~Cory98@user/pasha] has quit [Quit: Client closed]
21:22 -!- Cory98 [~Cory98@user/pasha] has joined #bitcoin-core-dev
21:30 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
21:37 < _aj_> PaperSword: probably should drop the Main from "ValidateAddressMainTest" then
21:40 -!- TallTim_ [~talltim@24-124-35-28-dynamic.midco.net] has joined #bitcoin-core-dev
21:40 -!- jimhhq_ [~jimhhq@srv779079.hstgr.cloud] has joined #bitcoin-core-dev
21:41 -!- jimhhq [~jimhhq@srv779079.hstgr.cloud] has quit [Ping timeout: 272 seconds]
21:42 -!- jetpack_ [~jetpack@mcfly.vm.tornadovps.net] has joined #bitcoin-core-dev
21:43 -!- andytoshi [~apoelstra@user/andytoshi] has quit [Ping timeout: 276 seconds]
21:43 -!- TallTim [~talltim@24-124-35-28-dynamic.midco.net] has quit [Ping timeout: 276 seconds]
21:43 -!- jetpack [~jetpack@mcfly.vm.tornadovps.net] has quit [Ping timeout: 272 seconds]
21:44 -!- andytoshi [~apoelstra@user/andytoshi] has joined #bitcoin-core-dev
21:47 -!- Christoph_ [~Christoph@2a02:810d:1399:b700:ecee:1968:d5a3:ef2f] has joined #bitcoin-core-dev
22:01 -!- Cory98 [~Cory98@user/pasha] has quit [Quit: Client closed]
22:02 -!- Cory98 [~Cory98@user/pasha] has joined #bitcoin-core-dev
22:22 -!- kevkevin_ [~kevkevin@209.242.39.30] has quit [Remote host closed the connection]
22:23 -!- kevkevin [~kevkevin@209.242.39.30] has joined #bitcoin-core-dev
22:27 -!- kevkevin [~kevkevin@209.242.39.30] has quit [Ping timeout: 252 seconds]
22:56 -!- kevkevin [~kevkevin@209.242.39.30] has joined #bitcoin-core-dev
23:06 -!- Christoph_ [~Christoph@2a02:810d:1399:b700:ecee:1968:d5a3:ef2f] has quit [Quit: Christoph_]
23:08 -!- kevkevin [~kevkevin@209.242.39.30] has quit [Ping timeout: 260 seconds]
23:08 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has quit [Quit: PaperSword]
23:13 -!- Cory61 [~Cory98@user/pasha] has joined #bitcoin-core-dev
23:16 -!- Cory98 [~Cory98@user/pasha] has quit [Quit: Client closed]
23:35 -!- kevkevin [~kevkevin@209.242.39.30] has joined #bitcoin-core-dev
23:52 -!- kevkevin [~kevkevin@209.242.39.30] has quit [Ping timeout: 252 seconds]
--- Log closed Wed Jun 04 00:00:02 2025