--- Log opened Fri Jun 27 00:00:24 2025
00:33 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has quit [Quit: Connection closed for inactivity]
00:59 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
00:59 -!- l0rinc [~l0rinc@user/l0rinc] has joined #bitcoin-core-dev
01:01 -!- mcey_ [~emcy@148.252.128.219] has quit [Quit: Leaving]
01:02 -!- mcey [~emcy@148.252.128.219] has joined #bitcoin-core-dev
01:23 -!- l0rinc [~l0rinc@user/l0rinc] has quit [Ping timeout: 260 seconds]
01:51 < bitcoin-git> [bitcoincore.org] fanquake pushed 2 commits to master: https://github.com/bitcoin-core/bitcoincore.org/compare/01479b479e64...c6371a3db345
01:51 < bitcoin-git> bitcoincore.org/master 2c596db azuchi: Apply #1147 to japanese translation
01:51 < bitcoin-git> bitcoincore.org/master c6371a3 merge-script: Merge bitcoin-core/bitcoincore.org#1152: Apply #1147 to japanese translati...
01:51 < bitcoin-git> [bitcoincore.org] fanquake merged pull request #1152: Apply #1147 to japanese translation (master...apply-#1147-to-japanese-translation) https://github.com/bitcoin-core/bitcoincore.org/pull/1152
02:27 -!- minotauro [~tauro@31.221.198.225] has joined #bitcoin-core-dev
02:28 -!- minotauro [~tauro@31.221.198.225] has quit [Client Quit]
02:42 -!- naiyoma [~ubuntu@user/naiyoma] has joined #bitcoin-core-dev
02:46 -!- naiyoma [~ubuntu@user/naiyoma] has quit [Quit: WeeChat 4.1.1]
02:55 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has joined #bitcoin-core-dev
03:33 -!- l0rinc [~l0rinc@user/l0rinc] has joined #bitcoin-core-dev
03:34 -!- l0rinc [~l0rinc@user/l0rinc] has quit [Remote host closed the connection]
03:34 -!- l0rinc [~l0rinc@user/l0rinc] has joined #bitcoin-core-dev
03:37 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [Closing Window]
04:01 -!- jespada [~jespada@179.26.250.220] has joined #bitcoin-core-dev
04:07 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c43cc48aaaaa...4a3475a43e80
04:07 < bitcoin-git> bitcoin/master 558f088 Antoine Poinsot: Add release note for #32530
04:07 < bitcoin-git> bitcoin/master 4a3475a merge-script: Merge bitcoin/bitcoin#32819: Add release note for #32530
04:07 < bitcoin-git> [bitcoin] fanquake merged pull request #32819: Add release note for #32530 (master...2506_release_note_maxmempool_cap_32bit) https://github.com/bitcoin/bitcoin/pull/32819
04:43 < bitcoin-git> [bitcoin] zaidmstrr opened pull request #32821: rpc: Handle -named argument parsing where Base64 encoding is used (master...rpc-args) https://github.com/bitcoin/bitcoin/pull/32821
05:02 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has quit [Quit: Connection closed for inactivity]
05:19 -!- jespada [~jespada@179.26.250.220] has quit [Ping timeout: 276 seconds]
05:22 -!- jespada [~jespada@r179-25-135-69.dialup.adsl.anteldata.net.uy] has joined #bitcoin-core-dev
05:26 -!- spynxic [~spynxic@spynxic.powered.by.lunarbnc.net] has quit [Read error: Connection reset by peer]
05:27 -!- spynxic [~spynxic@spynxic.powered.by.lunarbnc.net] has joined #bitcoin-core-dev
05:31 -!- szarka [~szarka@2603:3003:4eac:100:9d2b:ea82:7bf8:cecc] has quit [Quit: Leaving]
05:31 -!- szarka [~szarka@2603:3003:4eac:100:855a:5f84:27e3:a253] has joined #bitcoin-core-dev
05:33 -!- l0rinc [~l0rinc@user/l0rinc] has quit [Quit: l0rinc]
05:34 -!- jespada [~jespada@r179-25-135-69.dialup.adsl.anteldata.net.uy] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
05:40 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
05:44 -!- jespada [~jespada@r179-25-135-69.dialup.adsl.anteldata.net.uy] has joined #bitcoin-core-dev
06:16 -!- jespada [~jespada@r179-25-135-69.dialup.adsl.anteldata.net.uy] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
06:34 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
06:40 -!- jespada [~jespada@r179-25-135-69.dialup.adsl.anteldata.net.uy] has joined #bitcoin-core-dev
06:42 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 244 seconds]
06:42 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
06:44 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [Closing Window]
06:51 -!- Cory14 [~Cory14@user/pasha] has quit [Quit: Client closed]
06:52 -!- Cory14 [~Cory14@user/pasha] has joined #bitcoin-core-dev
06:54 -!- l0rinc [~l0rinc@user/l0rinc] has joined #bitcoin-core-dev
06:55 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4a3475a43e80...689318ccd9c2
06:55 < bitcoin-git> bitcoin/master 14653b8 Hennadii Stepanov: build: Find Boost in config mode
06:55 < bitcoin-git> bitcoin/master 689318c merge-script: Merge bitcoin/bitcoin#32667: build: Find Boost in config mode
06:55 < bitcoin-git> [bitcoin] fanquake merged pull request #32667: build: Find Boost in config mode (master...250602-boost-config) https://github.com/bitcoin/bitcoin/pull/32667
06:59 -!- memset [~memset@gateway/tor-sasl/memset] has quit [Remote host closed the connection]
06:59 -!- memset [~memset@gateway/tor-sasl/memset] has joined #bitcoin-core-dev
07:04 -!- Dansken [~quassel@213.204.245.6] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
07:32 -!- Guest7147 [~diego@2804:14c:5781:836f::871] has quit [Quit: WeeChat 4.6.3]
07:49 -!- Nebraskka [~Nebraskka@user/nebraskka] has quit [Ping timeout: 248 seconds]
08:04 -!- l0rinc [~l0rinc@user/l0rinc] has quit [Quit: l0rinc]
08:05 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Ping timeout: 244 seconds]
08:08 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
08:08 -!- VonNaturAustreVe [~natur@user/vonnaturaustreve] has joined #bitcoin-core-dev
08:09 -!- mudsip [~mudsip@user/mudsip] has joined #bitcoin-core-dev
08:18 -!- mudsip [~mudsip@user/mudsip] has quit []
08:40 < bitcoin-git> [bitcoin] maflcko opened pull request #32822:  fuzz: Make process_message(s) more deterministic  (master...2506-fuzz-pm) https://github.com/bitcoin/bitcoin/pull/32822
09:01 -!- jespada [~jespada@r179-25-135-69.dialup.adsl.anteldata.net.uy] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
09:04 -!- jespada [~jespada@r179-25-135-69.dialup.adsl.anteldata.net.uy] has joined #bitcoin-core-dev
09:43 -!- l0rinc [~l0rinc@user/l0rinc] has joined #bitcoin-core-dev
10:07 -!- zeropoint [~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
10:24 < bitcoin-git> [bitcoin] pablomartin4btc opened pull request #32823: test: Fix wait_for_getheaders() call in test_outbound_eviction_blocks_relay_only() (master...test_p2p_outbound_eviction_block_relay_fix) https://github.com/bitcoin/bitcoin/pull/32823
10:34 -!- l0rinc [~l0rinc@user/l0rinc] has quit [Quit: l0rinc]
11:46 -!- EIAS [~EIAS@45.229.41.49] has joined #bitcoin-core-dev
11:48 -!- EIAS [~EIAS@45.229.41.49] has quit [Client Quit]
12:05 -!- mcey_ [~emcy@85.255.232.136] has joined #bitcoin-core-dev
12:09 -!- mcey [~emcy@148.252.128.219] has quit [Ping timeout: 272 seconds]
12:38 -!- entropyx [~blackbox@user/entropyx] has quit [Ping timeout: 244 seconds]
12:39 -!- entropyx [~blackbox@82.86.129.175] has joined #bitcoin-core-dev
12:39 -!- entropyx [~blackbox@user/entropyx] has changed host
13:18 -!- Talkless [~Talkless@138.199.6.197] has joined #bitcoin-core-dev
13:28 < bitcoin-git> [bitcoin] achow101 pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/689318ccd9c2...319ff58bbd58
13:28 < bitcoin-git> bitcoin/master 5d235d5 Lőrinc: net: assert block hash in `ProcessGetBlockData` and `ProcessMessage`
13:28 < bitcoin-git> bitcoin/master 2371b9f Lőrinc: test/bench: verify hash in `ComputeFilter` reads
13:28 < bitcoin-git> bitcoin/master 9341b53 Lőrinc: blockstorage: make block read hash checks explicit
13:28 < bitcoin-git> [bitcoin] achow101 merged pull request #32638: blocks: force hash validations on disk read (master...l0rinc/read-block-hash-check) https://github.com/bitcoin/bitcoin/pull/32638
13:34 < bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/319ff58bbd58...3086c21df4a2
13:34 < bitcoin-git> bitcoin/master 95969bc kevkevinpal: test: added fuzz coverage to consensus/merkle.cpp
13:34 < bitcoin-git> bitcoin/master 3086c21 Ava Chow: Merge bitcoin/bitcoin#32243: test: added fuzz coverage for consensus/merkl...
13:34 < bitcoin-git> [bitcoin] achow101 merged pull request #32243: test: added fuzz coverage for consensus/merkle.cpp (master...fuzzMerkleCpp) https://github.com/bitcoin/bitcoin/pull/32243
14:15 < phantomcircuit> there's an issue with logging transaction id's in general, some things log txid, some log wtxid, some log both, but it's inconsistent
14:15 < phantomcircuit> i'd like to change the logginng to only log wtxid, but that would make it more annoying to share txid's with people because almost nothing (say a website to explore the block chain) uses the wtxids
14:16 < phantomcircuit> anybody have thoughts on this matter, i think the bike shed should be wtxid colored
14:25 -!- l0rinc [~l0rinc@user/l0rinc] has joined #bitcoin-core-dev
14:33 -!- VonNaturAustreVe [~natur@user/vonnaturaustreve] has quit [Remote host closed the connection]
14:33 -!- VonNaturAustreVe [~natur@user/vonnaturaustreve] has joined #bitcoin-core-dev
14:34 < achow101> phantomcircuit: log both!
14:35 < achow101> and whatever is logged, make it clear if it is a txid or wtxid
14:38 -!- VonNaturAustreVe [~natur@user/vonnaturaustreve] has quit [Remote host closed the connection]
14:38 -!- VonNaturAustreVe [~natur@user/vonnaturaustreve] has joined #bitcoin-core-dev
14:45 < bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/3086c21df4a2...b3bb4031ab32
14:45 < bitcoin-git> bitcoin/master d4e212e Roman Zeyde: rest: fetch spent transaction outputs by blockhash
14:45 < bitcoin-git> bitcoin/master c48846e Roman Zeyde: doc: add release notes for #32540
14:45 < bitcoin-git> bitcoin/master b3bb403 Ava Chow: Merge bitcoin/bitcoin#32540: rest: fetch spent transaction outputs by bloc...
14:45 < bitcoin-git> [bitcoin] achow101 merged pull request #32540: rest: fetch spent transaction outputs by blockhash (master...spent-prevouts) https://github.com/bitcoin/bitcoin/pull/32540
14:50 -!- l0rinc [~l0rinc@user/l0rinc] has quit [Quit: l0rinc]
14:54 < bitcoin-git> [bitcoincore.org] achow101 pushed 2 commits to master: https://github.com/bitcoin-core/bitcoincore.org/compare/c6371a3db345...64a780317fc6
14:54 < bitcoin-git> bitcoincore.org/master ab50ae1 fanquake: Bitcoin Core 28.2
14:54 < bitcoin-git> bitcoincore.org/master 64a7803 Ava Chow: Merge bitcoin-core/bitcoincore.org#1151: Bitcoin Core 28.2
14:54 < bitcoin-git> [bitcoincore.org] achow101 merged pull request #1151: Bitcoin Core 28.2 (master...bitcoin_core_28_2) https://github.com/bitcoin-core/bitcoincore.org/pull/1151
14:58 -!- Talkless [~Talkless@138.199.6.197] has quit [Quit: Konversation terminated!]
14:58 < bitcoin-git> [packaging] achow101 opened pull request #281: snap: Update to 28.2 (28.x...snap-28.2) https://github.com/bitcoin-core/packaging/pull/281
15:05 -!- VonNaturAustreVe [~natur@user/vonnaturaustreve] has quit [Ping timeout: 268 seconds]
15:20 < phantomcircuit> achow101: so one reason not to do that is that the transaction and block ids are basically the only things getting logged that dont commpress well
15:21 < phantomcircuit> if you're logging net and mempool/rej and txpackages it's kind of a firehose already, so doubling the uncompressible data is kinda annoying
15:21 < phantomcircuit> i guess i should have said that to start with
15:21 < phantomcircuit> iforget how to play with others my bad
15:22 < achow101> sure, but they're each useful in different contexts
15:23 < achow101> I don't think we should uniformly log one or the other
15:25 < phantomcircuit> achow101: possibly if we log them both in one place and then only log the wtxid everywhere else?
15:26 < phantomcircuit> also what's the different contexts they're useful? im definitely missing something there
15:28 < achow101> that could work but it is harder to review to make sure that both are logged for all txs
15:29 < achow101> different contexts as in what is actually being debugged. e.g. if you need to lookup a transaction, you need the txid. we don't have any wtxid lookups
15:29 < phantomcircuit> you know of any reason we dont?
15:30 < achow101> but if you're looking at some issue invovling malleability, wtxid would be helpful
15:30 < achow101> history, and txindex indexes by txid
15:30 < achow101> wallet too
15:38 < phantomcircuit> achow101: so what im looking at is transaction relay where malleability is definitely an issue, so for me the wtxid is obviously much more useful, but indeed i basically cant lookup anything with the wtxid
15:38 < phantomcircuit> which actually kinda seems like a problem
15:39 < bitcoin-git> [bitcoincore.org] dependabot[bot] opened pull request #1153: Bump webrick from 1.8.1 to 1.8.2 (master...dependabot/bundler/webrick-1.8.2) https://github.com/bitcoin-core/bitcoincore.org/pull/1153
15:41 -!- TheRec [~toto@user/therec] has quit [Remote host closed the connection]
15:42 -!- TheRec [~toto@user/therec] has joined #bitcoin-core-dev
16:07 < bitcoin-git> [packaging] achow101 merged pull request #281: snap: Update to 28.2 (28.x...snap-28.2) https://github.com/bitcoin-core/packaging/pull/281
17:03 -!- jespada [~jespada@r179-25-135-69.dialup.adsl.anteldata.net.uy] has quit [Ping timeout: 260 seconds]
17:26 -!- VonNaturAustreVe [~natur@user/vonnaturaustreve] has joined #bitcoin-core-dev
17:32 -!- VonNaturAustreVe [~natur@user/vonnaturaustreve] has quit [Ping timeout: 265 seconds]
18:52 -!- robszarka [~szarka@2603:3003:4eac:100:76ae:58ec:3559:25d0] has joined #bitcoin-core-dev
18:55 -!- szarka [~szarka@2603:3003:4eac:100:855a:5f84:27e3:a253] has quit [Ping timeout: 260 seconds]
19:23 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
19:31 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 244 seconds]
19:33 < sipa> phantomcircuit: i think it makes sense to just report both wherever relevant
19:47 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
20:05 -!- cotsuka [~cotsuka@user/cotsuka] has quit [Remote host closed the connection]
20:07 -!- cotsuka [~cotsuka@user/cotsuka] has joined #bitcoin-core-dev
20:19 -!- zeropoint [~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net] has quit [Quit: leaving]
20:37 < bitcoin-git> [bitcoin] volcano89 opened pull request #32824: #WİNDOWS11 (master...patch-1) https://github.com/bitcoin/bitcoin/pull/32824
20:56 -!- robszarka [~szarka@2603:3003:4eac:100:76ae:58ec:3559:25d0] has quit [Quit: Leaving]
20:57 -!- szarka [~szarka@2603:3003:4eac:100:76ae:58ec:3559:25d0] has joined #bitcoin-core-dev
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:14 < bitcoin-git> [bitcoin] achow101 closed pull request #32824: #WİNDOWS11 (master...patch-1) https://github.com/bitcoin/bitcoin/pull/32824
21:54 -!- conman [~con@180-150-21-3.b49615.mel.static.aussiebb.net] has quit [Remote host closed the connection]
23:18 < phantomcircuit> sipa: for consistency it seems like anywhere one is reported both should be (in logs at least)
23:18 < phantomcircuit> especially logs where we might toss the tx like orphans
23:30 < bitcoin-git> [bitcoin] romanz opened pull request #32825: rest: rename `strURIPart` - `uri_part` (master...uri-part) https://github.com/bitcoin/bitcoin/pull/32825
23:47 -!- upekkha [~Advanced@2a01:4f8:1c0c:49df::1] has quit []
23:47 -!- upekkha [~Advanced@2a01:4f8:1c0c:49df::1] has joined #bitcoin-core-dev
--- Log closed Sat Jun 28 00:00:25 2025