--- Log opened Thu Jul 03 00:00:30 2025
00:02 -!- sbddesign [~sbddesign@user/sbddesign] has quit [Ping timeout: 248 seconds]
00:08 -!- kevkevin [~kevkevin@209.242.39.30] has quit [Ping timeout: 272 seconds]
00:11 -!- sliv3r__ [~sliv3r__@user/sliv3r-:76883] has quit [Quit: ZNC 1.8.2+deb3.1+deb12u1 - https://znc.in]
00:12 -!- sliv3r__ [~sliv3r__@user/sliv3r-:76883] has joined #bitcoin-core-dev
00:19 -!- michaelfolkson [~michaelfo@138.68.143.20] has quit [Ping timeout: 272 seconds]
00:19 -!- michaelfolkson [~michaelfo@138.68.143.20] has joined #bitcoin-core-dev
00:30 -!- Guyver2 [Guyver@77-174-98-73.fixed.kpn.net] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
00:48 -!- kevkevin [~kevkevin@209.242.39.30] has joined #bitcoin-core-dev
00:49 -!- sbddesign [~sbddesign@user/sbddesign] has joined #bitcoin-core-dev
00:55 -!- kevkevin [~kevkevin@209.242.39.30] has quit [Ping timeout: 260 seconds]
00:58 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
00:58 -!- sbddesign [~sbddesign@user/sbddesign] has quit [Ping timeout: 260 seconds]
01:10 -!- kevkevin [~kevkevin@209.242.39.30] has joined #bitcoin-core-dev
01:13 -!- sbddesign [~sbddesign@user/sbddesign] has joined #bitcoin-core-dev
01:17 -!- sbddesign [~sbddesign@user/sbddesign] has quit [Ping timeout: 248 seconds]
01:25 -!- f321x [~f321x@user/f321x] has joined #bitcoin-core-dev
01:29 -!- sbddesign [~sbddesign@user/sbddesign] has joined #bitcoin-core-dev
01:32 -!- kevkevin [~kevkevin@209.242.39.30] has quit [Ping timeout: 248 seconds]
01:36 -!- sbddesign [~sbddesign@user/sbddesign] has quit [Ping timeout: 245 seconds]
01:47 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/192743235493...49d5f1f2c6d2
01:47 < bitcoin-git> bitcoin/master d6aaffc brunoerg: test: check P2SH sigop count for coinbase tx
01:47 < bitcoin-git> bitcoin/master 49d5f1f merge-script: Merge bitcoin/bitcoin#32850: test: check P2SH sigop count for coinbase tx
01:47 < bitcoin-git> [bitcoin] fanquake merged pull request #32850: test: check P2SH sigop count for coinbase tx (master...2025-07-test-p2shsigopcount-coinbase) https://github.com/bitcoin/bitcoin/pull/32850
01:51 -!- sbddesign [~sbddesign@user/sbddesign] has joined #bitcoin-core-dev
01:55 < bitcoin-git> [bitcoin] Sjors opened pull request #32861: Have createwalletdescriptor auto-detect an unused(KEY) (master...2025/07/smart-createwalletdescriptor) https://github.com/bitcoin/bitcoin/pull/32861
01:58 -!- sbddesign [~sbddesign@user/sbddesign] has quit [Ping timeout: 260 seconds]
01:59 -!- kevkevin [~kevkevin@209.242.39.30] has joined #bitcoin-core-dev
01:59 -!- memset [~memset@gateway/tor-sasl/memset] has quit [Remote host closed the connection]
01:59 -!- memset [~memset@gateway/tor-sasl/memset] has joined #bitcoin-core-dev
02:11 -!- f321x [~f321x@user/f321x] has quit [Quit: f321x]
02:11 -!- f321x [~f321x@user/f321x] has joined #bitcoin-core-dev
02:20 < bitcoin-git> [bitcoin] fanquake pushed 12 commits to master: https://github.com/bitcoin/bitcoin/compare/49d5f1f2c6d2...625194944333
02:20 < bitcoin-git> bitcoin/master 6c364e0 Martin Zumsande: test: Enable various tests for usage with cli
02:20 < bitcoin-git> bitcoin/master 7d5352a Martin Zumsande: test: use -stdin for large rpc commands
02:20 < bitcoin-git> bitcoin/master 5b08885 Martin Zumsande: test: enable functional tests with large rpc args for cli
02:20 < bitcoin-git> [bitcoin] fanquake merged pull request #32290: test: allow all functional tests to be run or skipped with --usecli (master...202505_fix_usecli) https://github.com/bitcoin/bitcoin/pull/32290
02:24 -!- l0rinc [~l0rinc@user/l0rinc] has joined #bitcoin-core-dev
02:28 -!- l0rinc [~l0rinc@user/l0rinc] has quit [Client Quit]
02:32 -!- sbddesign [~sbddesign@user/sbddesign] has joined #bitcoin-core-dev
02:35 -!- SpellChecker_ [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
02:36 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Ping timeout: 244 seconds]
02:36 -!- sbddesign [~sbddesign@user/sbddesign] has quit [Ping timeout: 248 seconds]
02:38 -!- f321x [~f321x@user/f321x] has quit [Remote host closed the connection]
02:38 -!- f321x [~f321x@user/f321x] has joined #bitcoin-core-dev
02:44 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has joined #bitcoin-core-dev
02:46 -!- SpellChecker_ [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection]
02:46 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
02:47 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/625194944333...c7fe8abb5f38
02:47 < bitcoin-git> bitcoin/master bb9157d Hennadii Stepanov: cmake, refactor: Switch to `Python3::Interpreter` imported target
02:47 < bitcoin-git> bitcoin/master 67dc752 Hennadii Stepanov: cmake, test: Disable tests instead of ignoring them
02:47 < bitcoin-git> bitcoin/master c7fe8ab merge-script: Merge bitcoin/bitcoin#31233: cmake: Improve Python robustness and test usa...
02:47 < bitcoin-git> [bitcoin] fanquake merged pull request #31233: cmake: Improve Python robustness and test usability (master...241106-python) https://github.com/bitcoin/bitcoin/pull/31233
02:51 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has quit [Quit: PaperSword]
02:53 -!- f321x_ [~f321x@user/f321x] has joined #bitcoin-core-dev
02:54 -!- sbddesign [~sbddesign@user/sbddesign] has joined #bitcoin-core-dev
02:56 -!- f321x [~f321x@user/f321x] has quit [Ping timeout: 244 seconds]
02:59 -!- sbddesign [~sbddesign@user/sbddesign] has quit [Ping timeout: 252 seconds]
03:00 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c7fe8abb5f38...927e9b220f17
03:00 < bitcoin-git> bitcoin/master 4f10a57 Hennadii Stepanov: depends: Override host compilers for FreeBSD and OpenBSD
03:00 < bitcoin-git> bitcoin/master 927e9b2 merge-script: Merge bitcoin/bitcoin#32716: depends: Override host compilers for FreeBSD ...
03:00 < bitcoin-git> [bitcoin] fanquake merged pull request #32716: depends: Override host compilers for FreeBSD and OpenBSD (master...250610-depends-bsd) https://github.com/bitcoin/bitcoin/pull/32716
03:03 -!- sbddesign [~sbddesign@user/sbddesign] has joined #bitcoin-core-dev
03:03 -!- kevkevin [~kevkevin@209.242.39.30] has quit [Ping timeout: 244 seconds]
03:08 -!- sbddesign [~sbddesign@user/sbddesign] has quit [Ping timeout: 248 seconds]
03:24 -!- sbddesign [~sbddesign@user/sbddesign] has joined #bitcoin-core-dev
03:28 -!- sbddesign [~sbddesign@user/sbddesign] has quit [Ping timeout: 276 seconds]
03:39 < sipa> phantomcircuit: yeah, i think that's what you want. But for it to be useful, you'd need the ability for net_processing to continue while ABC is running. However, you cannot process further messages from the peer that gave you the block, as that wouls violate the protocol (e.g. if they send a BLOCK followed by a PING, they only expect the PONG after the block is processed), so you need a way to mark 
03:39 < sipa> a peer in net_processing as "paused" while ABC is...
03:40 < sipa> running for it, making net_processing skip the peer
03:42 -!- f321x_ [~f321x@user/f321x] has quit [Quit: f321x_]
03:44 -!- f321x [~f321x@user/f321x] has joined #bitcoin-core-dev
03:46 < _aj_> sipa: you probably want to defer processing (and requesting?) transactions from other peers as well? probably also pause any peers that announce the same block/header at you?
03:47 < _aj_> s/probably/possibly/g
03:48 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has joined #bitcoin-core-dev
03:51 -!- kevkevin [~kevkevin@209.242.39.30] has joined #bitcoin-core-dev
03:53 < sipa> _aj_: yes, i think what we really want is validation to work as a queue of (tx, block, cmpctblk, ...) objects, each with a callback for reporting success/failure. net_processing just hands the received objects to the queue, pausing the peer that gave them. Upon completion, the callback unpauses them (and perhaps relays, punishes, ...); the nice thing is that the validation queue can then be made to 
03:53 < sipa> reorder/prioritize its objects (e.g. prioritize blocks...
03:53 < sipa> over txn), or split up processing (e.g. do an early header check first, or do things quickly if they are cached already, or even start doing transactioj validation in multiple script threads, ...)
03:54 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 268 seconds]
03:57 < bitcoin-git> [bitcoin] fanquake pushed 9 commits to 29.x: https://github.com/bitcoin/bitcoin/compare/983b268768f0...d360a6ef565f
03:57 < bitcoin-git> bitcoin/29.x e37a70b will: build: add root dir to CMAKE_PREFIX_PATH
03:57 < bitcoin-git> bitcoin/29.x 5987c1b Sebastian Falbesoner: test: fix catchup loop in outbound eviction functional test
03:57 < bitcoin-git> bitcoin/29.x a990c10 Hennadii Stepanov: cmake: Use `HINTS` instead of `PATHS` in `find_*` commands
03:57 < bitcoin-git> [bitcoin] fanquake merged pull request #32810: [29.x] More backports (29.x...even_more_29_backports) https://github.com/bitcoin/bitcoin/pull/32810
04:01 -!- jespada [~jespada@r179-25-246-58.dialup.adsl.anteldata.net.uy] has joined #bitcoin-core-dev
04:04 -!- l0rinc [~l0rinc@user/l0rinc] has joined #bitcoin-core-dev
04:06 < bitcoin-git> [bitcoin] pinheadmz opened pull request #32862: rpc: use CScheduler for HTTPRPCTimer and remove RPCTimer (master...http-scheduler-notimer) https://github.com/bitcoin/bitcoin/pull/32862
04:06 < bitcoin-git> [bitcoin] pinheadmz closed pull request #32796: rpc: use CScheduler for HTTPRPCTimer (master...http-scheduler) https://github.com/bitcoin/bitcoin/pull/32796
04:08 < bitcoin-git> [bitcoin] fanquake opened pull request #32863: [29.x] Backports (29.x...probably_final_29_backports) https://github.com/bitcoin/bitcoin/pull/32863
04:08 -!- sbddesign [~sbddesign@user/sbddesign] has joined #bitcoin-core-dev
04:11 -!- kevkevin [~kevkevin@209.242.39.30] has quit [Ping timeout: 248 seconds]
04:13 -!- sbddesign [~sbddesign@user/sbddesign] has quit [Ping timeout: 260 seconds]
04:15 < bitcoin-git> [bitcoin] kilavvy opened pull request #32864: fix typos and improve clarity in documentation (master...master) https://github.com/bitcoin/bitcoin/pull/32864
04:21 < bitcoin-git> [bitcoin] fanquake opened pull request #32865: cmake: Use `AUTHOR_WARNING` for warnings (master...use_author_warning) https://github.com/bitcoin/bitcoin/pull/32865
04:23 < bitcoin-git> [bitcoin] fanquake closed pull request #32864: fix typos and improve clarity in documentation (master...master) https://github.com/bitcoin/bitcoin/pull/32864
04:28 -!- sbddesign [~sbddesign@user/sbddesign] has joined #bitcoin-core-dev
04:28 -!- eugenesiegel [~eugenesie@user/eugenesiegel] has joined #bitcoin-core-dev
04:32 -!- sbddesign [~sbddesign@user/sbddesign] has quit [Ping timeout: 252 seconds]
04:39 -!- Guest7 [~Guest7@host-92-18-13-92.as13285.net] has joined #bitcoin-core-dev
04:42 -!- Guest7 [~Guest7@host-92-18-13-92.as13285.net] has quit [Client Quit]
04:42 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
04:48 -!- l0rinc [~l0rinc@user/l0rinc] has quit [Quit: l0rinc]
04:52 -!- l0rinc [~l0rinc@user/l0rinc] has joined #bitcoin-core-dev
04:53 -!- kevkevin [~kevkevin@209.242.39.30] has joined #bitcoin-core-dev
04:57 < bitcoin-git> [bitcoin] rkrux opened pull request #32866: doc: add note for watch-only wallet migration (master...watchonly-migration) https://github.com/bitcoin/bitcoin/pull/32866
05:00 -!- sbddesign [~sbddesign@user/sbddesign] has joined #bitcoin-core-dev
05:15 < bitcoin-git> [bitcoin] rkrux opened pull request #32867: doc: mention key removal in rpc interface modification (master...rpc-deprecation) https://github.com/bitcoin/bitcoin/pull/32867
05:15 -!- eugenesiegel [~eugenesie@user/eugenesiegel] has quit [Ping timeout: 272 seconds]
05:24 -!- f321x [~f321x@user/f321x] has quit [Quit: f321x]
05:35 -!- joetor5 [~Thunderbi@user/joetor5] has joined #bitcoin-core-dev
05:38 -!- joetor5 [~Thunderbi@user/joetor5] has quit [Remote host closed the connection]
05:39 -!- joetor5 [~Thunderbi@user/joetor5] has joined #bitcoin-core-dev
05:39 < bitcoin-git> [bitcoin] theStack opened pull request #32868: test: refactor: overhaul block hash determination for `CBlock{,Header}` objects (master...202506-test-remove_blockhash_caching) https://github.com/bitcoin/bitcoin/pull/32868
05:42 -!- jespada [~jespada@r179-25-246-58.dialup.adsl.anteldata.net.uy] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
05:45 -!- jespada [~jespada@r179-25-246-58.dialup.adsl.anteldata.net.uy] has joined #bitcoin-core-dev
06:01 -!- saturday7 [~saturday7@59.167.129.22] has quit [Quit: ZNC 1.10.0 - https://znc.in]
06:01 -!- saturday7 [~saturday7@59.167.129.22] has joined #bitcoin-core-dev
06:14 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
06:16 -!- sbddesign [~sbddesign@user/sbddesign] has quit [Ping timeout: 252 seconds]
06:23 -!- joetor5 [~Thunderbi@user/joetor5] has quit [Remote host closed the connection]
06:24 -!- bugs_ [~bugs@user/bugs/x-5128603] has joined #bitcoin-core-dev
06:24 -!- joetor5 [~Thunderbi@user/joetor5] has joined #bitcoin-core-dev
06:42 -!- sliv3r__ [~sliv3r__@user/sliv3r-:76883] has quit [Ping timeout: 276 seconds]
06:42 < bitcoin-git> [bitcoin] instagibbs opened pull request #32869: WIP p2p: Relax BlockRequestAllowed to respond to advertised blocks (master...2025-07-invalid-cb-stall) https://github.com/bitcoin/bitcoin/pull/32869
06:42 -!- sliv3r__ [~sliv3r__@user/sliv3r-:76883] has joined #bitcoin-core-dev
06:43 -!- l0rinc [~l0rinc@user/l0rinc] has quit [Quit: l0rinc]
07:04 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 244 seconds]
07:04 -!- sbddesign [~sbddesign@user/sbddesign] has joined #bitcoin-core-dev
07:05 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
07:08 -!- sbddesign [~sbddesign@user/sbddesign] has quit [Ping timeout: 260 seconds]
07:11 < bitcoin-git> [qa-assets] dergoegge pushed 3 commits to main: https://github.com/bitcoin-core/qa-assets/compare/c93ae8c8e7e3...c6cb320c0e45
07:11 < bitcoin-git> qa-assets/main f9816b7 MarcoFalke: Add fuzz inputs
07:11 < bitcoin-git> qa-assets/main 7720cbb MarcoFalke: remove crashing rpc inputs for now
07:11 < bitcoin-git> qa-assets/main c6cb320 Niklas Gögge: Merge pull request #227 from maflcko/main
07:11 < bitcoin-git> [qa-assets] dergoegge merged pull request #227:  Add fuzz inputs  (main...main) https://github.com/bitcoin-core/qa-assets/pull/227
07:18 -!- joetor5 [~Thunderbi@user/joetor5] has quit [Quit: joetor5]
07:19 -!- jespada [~jespada@r179-25-246-58.dialup.adsl.anteldata.net.uy] has quit [Ping timeout: 276 seconds]
07:22 -!- jespada [~jespada@r179-24-27-93.dialup.adsl.anteldata.net.uy] has joined #bitcoin-core-dev
07:25 -!- sbddesign [~sbddesign@user/sbddesign] has joined #bitcoin-core-dev
07:28 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
07:44 -!- kevkevin_ [~kevkevin@209.242.39.30] has joined #bitcoin-core-dev
07:47 -!- kevkevin [~kevkevin@209.242.39.30] has quit [Ping timeout: 276 seconds]
08:11 < bitcoin-git> [bitcoin] maflcko closed pull request #32615: fee estimate test: fix #31944 by handling a legitimate scenario that … (master...fix-fee-estimation-test) https://github.com/bitcoin/bitcoin/pull/32615
08:24 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/927e9b220f17...51ccc71b1bf9
08:24 < bitcoin-git> bitcoin/master 0a1af44 Hennadii Stepanov: doc: Add workaround for vcpkg issue with paths with embedded spaces
08:24 < bitcoin-git> bitcoin/master 51ccc71 merge-script: Merge bitcoin/bitcoin#32858: doc: Add workaround for vcpkg issue with path...
08:24 < bitcoin-git> [bitcoin] fanquake merged pull request #32858: doc: Add workaround for vcpkg issue with paths with embedded spaces (master...250702-vcpkg-spaces) https://github.com/bitcoin/bitcoin/pull/32858
08:49 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
08:52 -!- enochazariah [~enochazar@105.120.11.161] has joined #bitcoin-core-dev
08:59 -!- Emc99 [~Emc99@212.129.86.242] has joined #bitcoin-core-dev
09:00 < achow101> #startmeeting
09:00 < corebot> achow101: Meeting started at 2025-07-03T16:00+0000
09:00 < corebot> achow101: Current chairs: achow101
09:00 < corebot> achow101: Useful commands: #action #info #idea #link #topic #motion #vote #close #endmeeting
09:00 < corebot> achow101: See also: https://hcoop-meetbot.readthedocs.io/en/stable/
09:00 < corebot> achow101: Participants should now identify themselves with '#here' or with an alias like '#here FirstLast'
09:00 < achow101> #bitcoin-core-dev Meeting: abubakarsadiq achow101 _aj_ ajonas b10c brunoerg cfields darosior dergoegge fanquake fjahr furszy gleb glozow hebasto hodlinator instagibbs jarolrod jonatack josibake kanzure laanwj LarryRuane lightlike luke-jr maflcko marcofleon maxedw Murch pinheadmz provoostenator ryanofsky sdaftuar S3RK stickies-v sipa sr_gi tdb3 theStack TheCharlatan vasild willcl-ark
09:00 < hebasto> hi
09:00 < cfields> hi
09:00 < johnny9dev> Hi
09:00 < laanwj> hi
09:00 < abubakarsadiq> hi
09:00 < lightlike> hi
09:00 < sr_gi[m]1> hi
09:00 < pinheadmz> hi
09:00 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
09:00 < stickies-v> hi
09:00 < achow101> There are no pre-proposed meeting topics this week. Any last minute ones to add?
09:00 < janb84> hi
09:00 < danielabrozzoni> hi
09:01 < brunoerg> hi
09:01 < achow101> #topic Erlay WG Update (sr_gi, gleb)
09:01 < vasild> hi
09:02 -!- l0rinc [~l0rinc@user/l0rinc] has joined #bitcoin-core-dev
09:02 < sipa> hi
09:03 < dergoegge> hi
09:03 < instagibbs> hi
09:03 < Murch[m]> Hi
09:04 < sr_gi[m]1> It seems the propagation time issue I found last week may be what was making erlay times too good to be true. I've been re-running the simulations for small (50 nodes) and medium-size (200 nodes) networks. I'm currently re-working part of the warnet simulations so they can handle bigger networks (500 nodes is the most I've done, but the sims are a bit unreliable)
09:04 < pablomartin4btc> hi
09:04 < sr_gi[m]1> My goal is having the sims for all of them in the upcoming days so I can report back hopefully next week, and start moving forward
09:05 < sr_gi[m]1> That's it on my end
09:05 < achow101> #topic Fuzzing WG Update (dergoegge)
09:05 < dergoegge> Found 2 bugs on PRs with fuzzamoto in the last two weeks. One really shallow one in the erlay sketch deserialization code and one in the cluster mempool PR. The mempool bug specifically is a nice example for the complex inputs that fuzzamoto can generate.
09:05 < dergoegge> Also implemented a “netsplit” oracle, which already found a minor issue, fixed by instagibbs here: https://github.com/bitcoin/bitcoin/pull/32869 (would be nice to get some review on that)
09:05 < dergoegge> More updates (and links to the above): https://gist.github.com/dergoegge/0f732c440c19d02cf5eb6059ee90147c
09:06 < sipa> nice!
09:07 < dergoegge> (that's it on my end)
09:07 < achow101> #topic Cluster Mempool WG Update (sdaftuar, sipa)
09:07 -!- naiyoma [~ubuntu@user/naiyoma] has joined #bitcoin-core-dev
09:07 < sipa> hi
09:08 < sipa> i think both #31553 and #30605 are really close
09:08 < corebot> https://github.com/bitcoin/bitcoin/issues/31553 | cluster mempool: add TxGraph reorg functionality by sipa · Pull Request #31553 · bitcoin/bitcoin · GitHub
09:08 < corebot> https://github.com/bitcoin/bitcoin/issues/30605 | Cluster linearization: separate tests from tests-of-tests by sipa · Pull Request #30605 · bitcoin/bitcoin · GitHub
09:08 < sipa> the past week some extra benchmarks are tests were added, but i don't expect many further changes
09:08 < glozow> hi
09:09 < instagibbs> try not to rebase on master if possible :P
09:09 < sipa> after that, the txgraph API will be largely complete, and i think we can start focusing on getting parts of the full cluster mempool implementation (#28676) in
09:09 < corebot> https://github.com/bitcoin/bitcoin/issues/28676 | [WIP] Cluster mempool implementation by sdaftuar · Pull Request #28676 · bitcoin/bitcoin · GitHub
09:10 < glozow> sipa: would the plan be to do that PR all together?
09:10 < glozow> (all of 28676)
09:10 < sipa> unsure, i assume it contains some amount of preparatory work that can be split off
09:11 < sipa> but the bulk, adding the cluster tracking, and switching out the mempool tracking, will need to be one PR I think (or at least a sequence of PRs that are all expected to go into the same release)
09:12 < glozow> makes sense
09:12 < sipa> that's it for me, unless more questions
09:12 < achow101> #topic MuSig2 WG Update (achow101, rkrux)
09:12 < abubakarsadiq> On the process of re-reviewing  #31553,  https://github.com/bitcoin/bitcoin/pull/31553/commits/938e86f8fecd65ca90b97e6cf896f8c59fb590ba
09:12 < abubakarsadiq> I like the test one transaction forming huge cluster by spending them. and then in trim we don't just evict it alone.
09:12 < abubakarsadiq> we evict others, I think that should not be the case?
09:12 < corebot> https://github.com/bitcoin/bitcoin/issues/31553 | cluster mempool: add TxGraph reorg functionality by sipa · Pull Request #31553 · bitcoin/bitcoin · GitHub
09:13 -!- enochazariah [~enochazar@105.120.11.161] has quit [Quit: Client closed]
09:14 < sipa> abubakarsadiq: an optimal eviction algorithm could avoid that, but the trim algorithm is really just a best-effort of what we can accomplish in O(n log n)
09:14 -!- enochazariah [~enochazar@105.120.11.161] has joined #bitcoin-core-dev
09:14 < sipa> with proper linearization we could do a lot better - but the whole point of trim is that it can work with much larger numbers of transactions than what fit in a cluster
09:14 < achow101> #topic cluster mempool still
09:15 < abubakarsadiq> yep, could just throw txs in compact block reconstruction txs with a bound if thats the case.
09:16 < sipa> right
09:17 -!- enochazariah [~enochazar@105.120.11.161] has quit [Client Quit]
09:17 < abubakarsadiq> Also I think if we evict children first, we could avoid that but the current best effort algorithm is better in terms of incentive compatibility I think
09:17 < sipa> i'm not too worried about this, in practice i think the amount of oversized would-be clusters formed by reorged will be pretty small in non-attack scenarios
09:17 < instagibbs> most clusters are singletons after all
09:17 < abubakarsadiq> 👍
09:17 < sipa> and it costs creating a block to do something deliberately crazy
09:18 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [Closing Window]
09:18 -!- enochazariah [~enochazar@105.120.11.161] has joined #bitcoin-core-dev
09:18 < sipa> abubakarsadiq: we're not restricted to the current Trim algorithm too; we could experiment with better algorithms later, or even have multiple algorithms depending on the size (e.g. have a medium-size trim algorithm that works acceptably fast for say ~200 transactions, but not 5000, for which we can still fall back to the current Trim one)
09:19 < sipa> but those don't affect the API, so wouldn't block further cluster mempool progress
09:19 < abubakarsadiq> yes please
09:19 -!- memset [~memset@gateway/tor-sasl/memset] has quit [Remote host closed the connection]
09:19 < sipa> now back to your regularly scheduled MuSig2
09:19 -!- memset [~memset@gateway/tor-sasl/memset] has joined #bitcoin-core-dev
09:19 < achow101> #topic MuSig2 WG Update (achow101, rkrux)
09:20 < achow101> #31244 is probably rfm, otherwise, no updates
09:20 < corebot> https://github.com/bitcoin/bitcoin/issues/31244 | descriptors: MuSig2 by achow101 · Pull Request #31244 · bitcoin/bitcoin · GitHub
09:20 < achow101> #topic orphan resolution WG Update (glozow)
09:21 < glozow> I've been working on benchmarks for #31829, and have been chatting with sipa about potentially baking number of inputs into the dos score
09:21 < corebot> https://github.com/bitcoin/bitcoin/issues/31829 | p2p: improve TxOrphanage denial of service bounds by glozow · Pull Request #31829 · bitcoin/bitcoin · GitHub
09:21 < instagibbs> for the eraseforblock case?
09:21 < glozow> Worst case EraseForBlock times were pretty bad (if you have tons of transactions each spending hundreds of inputs all conflicting with the block)
09:21 < glozow> yeah, I'm getting 35ms on my machine
09:22 < sipa> EraseForBlock, but also EraseForPeer could trigger most (but not all) of the same work, which is potentially triggerable by non-miners
09:23 < instagibbs> due to outpoint map?
09:23 < glozow> Yes. EraseForBlock is slightly worse because it has the loop that builds the set of wtxids to erase (each of the 1750 wtxids is added ~180 times). And then it has to erase all of those entries from the outpoints map
09:23 -!- enochazariah [~enochazar@105.120.11.161] has quit [Quit: Client closed]
09:24 < instagibbs> 👍
09:24 < glozow> The current ideated formula is that "announcement count" becomes 1 + floor(vin.size() / 10) for each tx. So the first 9 inputs are "free" and this limit is hopefully not relevant to normal transactions
09:26 < sipa> the vin.size()/10 would be deduplicated across peers, while the 1 part isn't
09:26 < sipa> as each tx's inputs only appear once in the outpoint index
09:26 -!- Talkless [~Talkless@138.199.6.197] has joined #bitcoin-core-dev
09:27 < bitcoin-git> [packaging] fanquake pushed 2 commits to main: https://github.com/bitcoin-core/packaging/compare/aad8d4df0f4c...1c03d604e451
09:27 < bitcoin-git> packaging/main 577ccb0 MarcoFalke: ci: Avoid separate pull to work around snap issue
09:27 < bitcoin-git> packaging/main 1c03d60 merge-script: Merge bitcoin-core/packaging#284: ci: Avoid separate pull to work around s...
09:27 < bitcoin-git> [packaging] fanquake merged pull request #284: ci: Avoid separate pull to work around snap issue (main...2506-ci) https://github.com/bitcoin-core/packaging/pull/284
09:27 < glozow> right that part is similar to the memusage metric
09:28 < glozow> Since last week I've also added sipa's simulation fuzzer + a few small tweaks and tests
09:29 < glozow> that's all the updates
09:29 < achow101> #topic QML GUI WG Update (jarolrod, johnny9dev)
09:30 < johnny9dev> Not much this week on QML work. bitcoin-core/gui-qml#450 got merged and hebasto and pinheadmz are making good progress on  bitcoin-core/gui-qml#472.
09:30 < johnny9dev> Thats all for now
09:30 < corebot> https://github.com/bitcoin-core/gui-qml/issues/450 | Add Multiple Recipients option to the Send form by johnny9 · Pull Request #450 · bitcoin-core/gui-qml · GitHub
09:30 < corebot> https://github.com/bitcoin-core/gui-qml/issues/472 | Rebase gui-qml on bitcoin/bitcoin, include qt6 and cmake by pinheadmz · Pull Request #472 · bitcoin-core/gui-qml · GitHub
09:30 < achow101> Any other topics to discuss?
09:30 < bitcoin-git> [packaging] fanquake pushed 2 commits to main: https://github.com/bitcoin-core/packaging/compare/1c03d604e451...9ac225b7e060
09:30 < bitcoin-git> packaging/main 2357600 Hennadii Stepanov: snap: Drop `desktop-launch`
09:30 < bitcoin-git> packaging/main 9ac225b merge-script: Merge bitcoin-core/packaging#276: snap: Drop `desktop-launch`
09:30 < bitcoin-git> [packaging] fanquake merged pull request #276: snap: Drop `desktop-launch` (main...250417-desktop-launch) https://github.com/bitcoin-core/packaging/pull/276
09:31 < l0rinc> I have a mempool related question regarding https://github.com/bitcoin/bitcoin/pull/32827#issue-3186436123
09:31 < l0rinc> do we need to keep the mempool stats up-to-date when the mempool is still empty? My understanding is that when it becomes empty we definitely need to keep the fee estimation state updated, but not sure if that's necessary during IBD. And if I try skipping `MempoolTransactionsRemovedForBlock` notification for the resulting empty vector of removals, I'm getting a test failure and need some help in deciding if the test shows a representative behavior
09:31 < l0rinc>  or not - would be nice if we could avoid adding another callback into the validation queue...
09:31 < achow101> #topic mempool in ibd
09:32 -!- naiyoma [~ubuntu@user/naiyoma] has quit [Ping timeout: 252 seconds]
09:33 < glozow> Is the question whether the fee estimator needs to know about every `MempoolTransactionsRemovedForBlock`?
09:33 < l0rinc> yes, in case of no removals
09:33 < l0rinc> as is the case as far as I can tell during IBD before any mempool activity
09:33 < abubakarsadiq> l0rinc: is it the fee estimator test that is failing?
09:34 < l0rinc> it's feature_fee_estimation
09:34 < glozow> I think this is the only way the fee estimator updates `txHeight`
09:35 -!- Guest5846 [~ubuntu@197.237.117.94] has joined #bitcoin-core-dev
09:35 < glozow> Is this slowing IBD down though? Doesn't this happen on a background thread?
09:35 < bitcoin-git> [bitcoin] fanquake pushed 6 commits to 28.x: https://github.com/bitcoin/bitcoin/compare/e44d72b6480a...3c56d36bec53
09:35 < bitcoin-git> bitcoin/28.x d235d5b zaidmstrr: test: Fix list index out of range error in feature_bip68_sequence.py
09:35 < bitcoin-git> bitcoin/28.x 907772d fanquake: doc: fix transifex 404s
09:35 < bitcoin-git> bitcoin/28.x d19a8e0 Sjors Provoost: doc: taproot became always active in v24.0
09:35 < bitcoin-git> [bitcoin] fanquake merged pull request #32811: [28.x] Backports (28.x...28_more_backporting) https://github.com/bitcoin/bitcoin/pull/32811
09:35 < abubakarsadiq> shouldn't it be no-op when their is no data on mempool, is their a measurable improvement from skipping that?
09:36 < jonatack> hi
09:36 -!- sbddesign [~sbddesign@user/sbddesign] has quit [Ping timeout: 276 seconds]
09:36 < l0rinc> glozow: it's blocking the queue, as furzsy sais:
09:36 < l0rinc> > First quick glance it seems that if the mempool is empty; we could avoid calling removeForBlock entirely. Which will save us from adding another callback into the validation queue too, which will leave space for processing another block during ibd.
09:36 < l0rinc> > Yet, that was a fast check. Should check who is using the MempoolTransactionsRemovedForBlock event.
09:36 < l0rinc> https://github.com/bitcoin/bitcoin/pull/32730#discussion_r2140931183
09:38 < l0rinc> We don't have to resolve it here, if anyone has insights, please add it to the PR - otherwise I will keep the MempoolTransactionsRemovedForBlock call for empty txs_removed_for_block as well
09:38 < abubakarsadiq> glozow: yes, we update `nHeight` after we are done with ibd and update the fee estimator stats for the first time it recorded data is marked as confirmed because of a new block.
09:38 < glozow> so the fee estimator doesn't do anything during IBD?
09:40 -!- Guest5846 [~ubuntu@197.237.117.94] has quit [Ping timeout: 276 seconds]
09:40 < abubakarsadiq> yes it does not, it has to see transaction enter mempool first.
09:41 < glozow> I meant to ask if the fee estimator gated on IBD?
09:41 < glozow> if its functions are gated*
09:42 < glozow> nvm, can look at this later
09:42 < abubakarsadiq> the updates are redundant, we don't do anything and can be avoided I think.
09:42 < abubakarsadiq> I started looking at it in https://github.com/bitcoin/bitcoin/pull/32748
09:43 < l0rinc> thanks, that's it from me
09:44 < achow101> Any other topics?
09:46 < achow101> #endmeeting
09:46 < corebot> achow101: Meeting ended at 2025-07-03T16:46+0000
09:46 < corebot> achow101: Raw log: https://achow101.com/ircmeetings/2025/bitcoin-core-dev.2025-07-03_16_00.log.json
09:46 < corebot> achow101: Formatted log: https://achow101.com/ircmeetings/2025/bitcoin-core-dev.2025-07-03_16_00.log.html
09:46 < corebot> achow101: Minutes: https://achow101.com/ircmeetings/2025/bitcoin-core-dev.2025-07-03_16_00.html
09:46 -!- Emc99 [~Emc99@212.129.86.242] has quit [Quit: Client closed]
09:53 -!- Guest9863 [~ubuntu@197.237.117.94] has joined #bitcoin-core-dev
09:54 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has quit [Quit: PaperSword]
09:58 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has joined #bitcoin-core-dev
09:59 -!- l0rinc [~l0rinc@user/l0rinc] has quit [Quit: l0rinc]
10:08 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 260 seconds]
10:10 -!- Cory81 [~Cory81@user/pasha] has quit [Quit: Client closed]
10:10 -!- Cory81 [~Cory81@user/pasha] has joined #bitcoin-core-dev
10:12 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has quit [Quit: PaperSword]
10:14 -!- memset [~memset@gateway/tor-sasl/memset] has quit [Ping timeout: 244 seconds]
10:16 -!- memset [~memset@gateway/tor-sasl/memset] has joined #bitcoin-core-dev
10:20 -!- sbddesign [~sbddesign@user/sbddesign] has joined #bitcoin-core-dev
10:21 < bitcoin-git> [bitcoin] davidgumberg closed pull request #31665: build: Make config warnings fatal if -DWCONFIGURE_ERROR=ON (master...1-15-24-configure_warnings) https://github.com/bitcoin/bitcoin/pull/31665
10:25 -!- sbddesign [~sbddesign@user/sbddesign] has quit [Ping timeout: 248 seconds]
10:37 -!- Guest71 [~Guest71@2a01:e0a:a65:30d0:d80:8cf2:f07:91d] has joined #bitcoin-core-dev
10:37 -!- Guest71 [~Guest71@2a01:e0a:a65:30d0:d80:8cf2:f07:91d] has quit [Client Quit]
10:41 -!- eugenesiegel [~eugenesie@user/eugenesiegel] has joined #bitcoin-core-dev
10:51 < bitcoin-git> [qa-assets] murchandamus closed pull request #229: Add Murch’s inputs July 2025 (main...2025-07-murch-inputs) https://github.com/bitcoin-core/qa-assets/pull/229
10:52 -!- sbddesign [~sbddesign@user/sbddesign] has joined #bitcoin-core-dev
10:57 -!- sbddesign [~sbddesign@user/sbddesign] has quit [Ping timeout: 252 seconds]
10:57 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has joined #bitcoin-core-dev
11:10 -!- sbddesign [~sbddesign@user/sbddesign] has joined #bitcoin-core-dev
11:20 -!- mudsip [~mudsip@user/mudsip] has joined #bitcoin-core-dev
11:21 -!- mudsip [~mudsip@user/mudsip] has quit [Client Quit]
11:22 -!- memset [~memset@gateway/tor-sasl/memset] has quit [Remote host closed the connection]
11:23 -!- memset [~memset@gateway/tor-sasl/memset] has joined #bitcoin-core-dev
11:38 < furszy> l0rinc: I just had a quick talk with abubakarsadiq and It seems we still need to send the signal just to update the best seen height inside the fee estimation class, but we can skip some of the calculations on the event processing side (all the stats objects are initialized but contain only the default values, so we could avoid going through them while computing some mod operations). Still, not sure how much performance gain we will g
11:38 < furszy> et from this. Matter of checking it.
11:58 < abubakarsadiq> yeah working on it 👍🏾
12:11 -!- Guest9 [~Guest9@2.145.194.115] has joined #bitcoin-core-dev
12:13 -!- Cory81 [~Cory81@user/pasha] has quit [Quit: Client closed]
12:13 -!- Cory81 [~Cory81@user/pasha] has joined #bitcoin-core-dev
12:20 -!- Talkless [~Talkless@138.199.6.197] has quit [Quit: Konversation terminated!]
12:27 -!- eugenesiegel [~eugenesie@user/eugenesiegel] has quit [Ping timeout: 272 seconds]
12:28 -!- kevkevin_ [~kevkevin@209.242.39.30] has quit [Remote host closed the connection]
12:30 -!- kevkevin [~kevkevin@209.242.39.30] has joined #bitcoin-core-dev
12:34 -!- Cory81 [~Cory81@user/pasha] has quit [Quit: Client closed]
12:34 -!- Cory81 [~Cory81@user/pasha] has joined #bitcoin-core-dev
12:34 -!- kevkevin [~kevkevin@209.242.39.30] has quit [Ping timeout: 276 seconds]
12:42 -!- kevkevin [~kevkevin@142.147.59.145] has joined #bitcoin-core-dev
12:49 -!- Guest9 [~Guest9@2.145.194.115] has quit [Quit: Client closed]
13:09 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has quit [Quit: Connection closed for inactivity]
13:31 -!- aleggg [~aleggg@177.188.151.7] has joined #bitcoin-core-dev
13:35 < bitcoin-git> [bitcoin] 1BitcoinBoWP1FZ4xwTNkq6XksKidmgYYw opened pull request #32871: New SVG, Icons, PNGs and X PixMaps (master...master) https://github.com/bitcoin/bitcoin/pull/32871
13:36 -!- kevkevin [~kevkevin@142.147.59.145] has quit [Remote host closed the connection]
13:43 -!- Guest9863 [~ubuntu@197.237.117.94] has quit [Quit: WeeChat 4.1.1]
13:50 -!- wafflefrie [uid478376@id-478376.uxbridge.irccloud.com] has quit [Quit: Connection closed for inactivity]
14:06 -!- joetor5 [~Thunderbi@user/joetor5] has joined #bitcoin-core-dev
14:10 -!- eugenesiegel [~eugenesie@user/eugenesiegel] has joined #bitcoin-core-dev
14:22 -!- jespada [~jespada@r179-24-27-93.dialup.adsl.anteldata.net.uy] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
14:29 -!- memset [~memset@gateway/tor-sasl/memset] has quit [Remote host closed the connection]
14:29 -!- memset [~memset@gateway/tor-sasl/memset] has joined #bitcoin-core-dev
14:39 -!- joetor5 [~Thunderbi@user/joetor5] has quit [Ping timeout: 245 seconds]
14:45 -!- Cory81 [~Cory81@user/pasha] has quit [Quit: Client closed]
14:46 -!- Cory81 [~Cory81@user/pasha] has joined #bitcoin-core-dev
14:46 -!- joetor5 [~Thunderbi@user/joetor5] has joined #bitcoin-core-dev
14:48 -!- kevkevin [~kevkevin@209.242.39.30] has joined #bitcoin-core-dev
14:53 -!- kevkevin [~kevkevin@209.242.39.30] has quit [Ping timeout: 244 seconds]
14:59 -!- eugenesiegel [~eugenesie@user/eugenesiegel] has quit [Quit: Client closed]
15:00 -!- bugs_ [~bugs@user/bugs/x-5128603] has quit [Quit: Leaving]
15:03 -!- wafflefrie [uid478376@id-478376.uxbridge.irccloud.com] has joined #bitcoin-core-dev
15:05 -!- joetor5 [~Thunderbi@user/joetor5] has quit [Ping timeout: 248 seconds]
15:22 -!- BlueMatt [~BlueMatt@ircb.bluematt.me] has quit [Quit: Quit]
15:23 -!- BlueMatt [~BlueMatt@ircb.bluematt.me] has joined #bitcoin-core-dev
15:25 -!- joetor5 [~Thunderbi@user/joetor5] has joined #bitcoin-core-dev
15:26 -!- stratospher[m] [~stratosph@2620:6e:a000:ce11::1e] has quit [Ping timeout: 260 seconds]
15:27 -!- b10c[m] [~b10cb10cm@2620:6e:a000:ce11::1c] has quit [Ping timeout: 245 seconds]
15:27 -!- BlueMattMtrxBot [~bluemattm@2620:6e:a000:ce11::44] has quit [Ping timeout: 272 seconds]
15:27 -!- Murch[m] [~murch@user/murch] has quit [Ping timeout: 260 seconds]
15:27 -!- bitcoin-git [~bitcoin-g@2620:6e:a000:ce11::21] has quit [Ping timeout: 260 seconds]
15:27 -!- BlueMatt [~BlueMatt@ircb.bluematt.me] has quit [Ping timeout: 248 seconds]
15:27 -!- sr_gi[m]1 [~srgimatri@2620:6e:a000:ce11::2a] has quit [Ping timeout: 248 seconds]
15:28 -!- BlueMatt [~BlueMatt@ircb.bluematt.me] has joined #bitcoin-core-dev
15:29 -!- bitcoin-git [~bitcoin-g@2620:6e:a000:ce11::21] has joined #bitcoin-core-dev
15:31 -!- sr_gi[m]1 [~srgimatri@2620:6e:a000:ce11::2a] has joined #bitcoin-core-dev
15:40 -!- Murch[m] [~murch@2620:6e:a000:ce11::1b] has joined #bitcoin-core-dev
15:40 < bitcoin-git> [bitcoin] achow101 closed pull request #32788: descriptors: Allow `H` as a hardened indicator (master...desc-allow-H) https://github.com/bitcoin/bitcoin/pull/32788
15:40 < bitcoin-git> [bitcoin] achow101 pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/51ccc71b1bf9...ea4285775e61
15:40 < bitcoin-git> bitcoin/master a69c409 Hodlinator: rpc: take ownership of the file by WriteUTXOSnapshot()
15:40 < bitcoin-git> bitcoin/master 8bb34f0 Vasil Dimov: Explicitly close all AutoFiles that have been written
15:40 < bitcoin-git> bitcoin/master 4bb5dd7 Vasil Dimov: util: check that a file has been closed before ~AutoFile() is called
15:40 < bitcoin-git> [bitcoin] achow101 merged pull request #29307: util: explicitly close all AutoFiles that have been written (master...AutoFile_error_check) https://github.com/bitcoin/bitcoin/pull/29307
15:40 -!- BlueMattMtrxBot [~bluemattm@2620:6e:a000:ce11::44] has joined #bitcoin-core-dev
15:45 -!- stratospher[m] [~stratosph@2620:6e:a000:ce11::1e] has joined #bitcoin-core-dev
16:00 -!- memset [~memset@gateway/tor-sasl/memset] has quit [Ping timeout: 244 seconds]
16:02 -!- memset [~memset@gateway/tor-sasl/memset] has joined #bitcoin-core-dev
16:02 -!- jadi [~jadi@d23-16-146-102.bchsia.telus.net] has quit [Ping timeout: 276 seconds]
16:16 -!- joetor5 [~Thunderbi@user/joetor5] has quit [Ping timeout: 244 seconds]
16:17 -!- jadi [~jadi@d23-16-146-102.bchsia.telus.net] has joined #bitcoin-core-dev
16:20 -!- Guest0 [~Guest0@103.151.74.134] has joined #bitcoin-core-dev
16:20 -!- Guest0 [~Guest0@103.151.74.134] has quit [Client Quit]
16:25 -!- joetor5 [~Thunderbi@user/joetor5] has joined #bitcoin-core-dev
16:44 -!- joetor5 [~Thunderbi@user/joetor5] has quit [Ping timeout: 244 seconds]
16:44 -!- memset [~memset@gateway/tor-sasl/memset] has quit [Remote host closed the connection]
16:45 -!- memset [~memset@gateway/tor-sasl/memset] has joined #bitcoin-core-dev
16:45 < bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ea4285775e61...e3f416dbf763
16:45 < bitcoin-git> bitcoin/master 5c1236f ismaelsadeeq: test: fix incorrect subtest in `feature_fee_estimation.py`
16:45 < bitcoin-git> bitcoin/master 9b75cfd ismaelsadeeq: test: retain the intended behavior of `feature_fee_estimation.py` nodes
16:45 < bitcoin-git> bitcoin/master e3f416d Ava Chow: Merge bitcoin/bitcoin#32463: test: fix an incorrect `feature_fee_estimatio...
16:45 < bitcoin-git> [bitcoin] achow101 merged pull request #32463: test: fix an incorrect `feature_fee_estimation.py` subtest (master...05-2025-fix-incorrect-fee-estimator-test) https://github.com/bitcoin/bitcoin/pull/32463
16:48 -!- joetor5 [~Thunderbi@user/joetor5] has joined #bitcoin-core-dev
16:51 -!- kevkevin [~kevkevin@209.242.39.30] has joined #bitcoin-core-dev
17:00 -!- joetor5 [~Thunderbi@user/joetor5] has quit [Remote host closed the connection]
17:00 -!- Guest29 [~Guest29@50.201.213.226] has joined #bitcoin-core-dev
17:00 -!- joetor5 [~Thunderbi@user/joetor5] has joined #bitcoin-core-dev
17:03 -!- DJWHIT89 [~DJWHIT89@50.201.213.226] has joined #bitcoin-core-dev
17:16 -!- joetor5 [~Thunderbi@user/joetor5] has quit [Ping timeout: 268 seconds]
17:22 -!- joetor5 [~Thunderbi@user/joetor5] has joined #bitcoin-core-dev
17:23 -!- joetor5 [~Thunderbi@user/joetor5] has quit [Client Quit]
17:40 -!- pablomartin4btc [~pablomart@186.152.251.193] has quit [Ping timeout: 252 seconds]
17:58 -!- DJWHIT89 [~DJWHIT89@50.201.213.226] has quit [Quit: Client closed]
18:22 -!- Guest29 [~Guest29@50.201.213.226] has quit [Quit: Client closed]
18:22 -!- Guest29 [~Guest29@50.201.213.226] has joined #bitcoin-core-dev
18:28 -!- Guest29 [~Guest29@50.201.213.226] has quit [Quit: Client closed]
18:54 -!- Cory81 [~Cory81@user/pasha] has quit [Quit: Client closed]
18:54 -!- Cory81 [~Cory81@user/pasha] has joined #bitcoin-core-dev
19:23 -!- wafflefrie [uid478376@id-478376.uxbridge.irccloud.com] has quit [Quit: Connection closed for inactivity]
20:43 < phantomcircuit> sipa: can i just skip abc for blocks during ibd but run checkblock/acceptblock ?
20:46 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
20:51 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 252 seconds]
20:52 < phantomcircuit> a priority queue is definitely the right solution, but ... here me out... harder
20:58 < phantomcircuit> hear*
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:18 < phantomcircuit> well actually is it exactly? that's kinda a parallel issue to doing the check/accept block (which writes to disk) in parallel with activatebestchain
22:04 < _aj_> phantomcircuit: doesn't need to be a priority queue, just one queue for blocks and one queue for txs, and you always look at the block queue first?
22:20 < phantomcircuit> _aj_: well it doesn't need to be a priority queue, but it's probably more useful if it is, like certainly we want to prioritize blocks that extend the current tip over ... anything else
22:23 < phantomcircuit> sipa: so how much exactly do we *need* to process a block before handling other messages?
22:41 < _aj_> phantomcircuit: blocks that don't extend the current tip are trivial to process, so don't seem like they should need special casing?
22:44 < phantomcircuit> _aj_: that's not exactly right actually, we do the context independent sanity checks, write the block to disk, and then sometime later read the block from disk when it does extend the tip and... do all those checks again which include calcualteing the merkle root which is quite expensive
22:44 < phantomcircuit> so priority queue could potentially save us doublingg the work we do there
22:50 -!- Cory81 [~Cory81@user/pasha] has quit [Quit: Client closed]
22:51 -!- Cory81 [~Cory81@user/pasha] has joined #bitcoin-core-dev
22:56 < _aj_> phantomcircuit: i guess my thought is that AcceptBlock() would be done as-is, and ActivateBestChain() would be the part that's delegated to the thread/queue?
22:58 < phantomcircuit> _aj_: that's what im doing right now, but i think sipa was suggesting going beyond that and putting the expensive to handle messages into a queue
22:59 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has quit [Quit: PaperSword]
23:00 < _aj_> phantomcircuit: i don't think anything in AcceptBlock is "expensive", except maybe in IBD with assumevalid?
23:01 < _aj_> phantomcircuit: not sure i'm following what your goal is exactly
23:03 < phantomcircuit> _aj_: during ibd the msghand thread ends up pegged at 100% cpu usage which is (obviously) a bottleneck
23:05 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has joined #bitcoin-core-dev
23:09 < _aj_> phantomcircuit: of which a signifigant fraction is CheckBlock, ContextualCheckBlock duplication in AcceptBlock/ConnectBlock?
23:09 < _aj_> significant
23:10 < _aj_> oh, just CheckBlock, ContextualCheckBlock isn't re-invoked
23:15 < _aj_> phantomcircuit: hmm, no, CheckBlock has an fChecked cache that should early exit?
23:21 < phantomcircuit> _aj_: either way, my goal is to utilitze multiple threads
23:22 < phantomcircuit> a bunch of stuff that's not actually possible
23:27 < phantomcircuit> which isn't going to be trivial here either sinnce activatebestchain holds like... every lock basically
23:28 < phantomcircuit> _aj_: i dont think we write fChecked to disk anywhere?
23:38 -!- Cory81 [~Cory81@user/pasha] has quit [Quit: Client closed]
23:38 -!- Cory81 [~Cory81@user/pasha] has joined #bitcoin-core-dev
23:57 < _aj_> phantomcircuit: no, but should be feasible to retain the CBlock with fChecked set while it's in the queue? or to pass through an "assume_already_checked" flag, and set fChecked manually after reading it?
23:58 -!- f321x [~f321x@user/f321x] has joined #bitcoin-core-dev
--- Log closed Fri Jul 04 00:00:31 2025