--- Log opened Tue Nov 25 00:00:48 2025
00:14 -!- robszarka [~szarka@2603:3003:4eac:100:7c98:25be:4359:bc73] has joined #bitcoin-core-dev
00:15 -!- l0rinc [~l0rinc@user/l0rinc] has joined #bitcoin-core-dev
00:16 -!- f321x [~f321x@user/f321x] has joined #bitcoin-core-dev
00:17 -!- rszarka [~szarka@2603:3003:4eac:100:11d5:bb7b:7fdb:1b13] has quit [Ping timeout: 260 seconds]
00:27 -!- flooded [~flooded@45.87.214.26] has quit [Remote host closed the connection]
00:27 -!- flooded [~flooded@45.87.214.26] has joined #bitcoin-core-dev
00:28 -!- l0rinc [~l0rinc@user/l0rinc] has quit [Quit: l0rinc]
00:29 -!- Guyver2 [Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
00:35 -!- l0rinc [~l0rinc@user/l0rinc] has joined #bitcoin-core-dev
00:42 -!- kevkevin [~kevkevin@209.242.39.30] has quit [Ping timeout: 264 seconds]
00:55 -!- kevkevin [~kevkevin@209.242.39.30] has joined #bitcoin-core-dev
00:59 -!- kevkevin [~kevkevin@209.242.39.30] has quit [Ping timeout: 246 seconds]
01:12 -!- kevkevin [~kevkevin@209.242.39.30] has joined #bitcoin-core-dev
01:21 -!- afiore [~afiore@user/afiore] has quit [Remote host closed the connection]
01:30 -!- Guyver2 [Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [Closing Window]
01:37 -!- Nebraskka [~Nebraskka@user/nebraskka] has quit [Quit: Good day old chaps]
01:51 -!- SpellChecker_ [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
01:53 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Ping timeout: 272 seconds]
02:16 -!- kevkevin [~kevkevin@209.242.39.30] has quit [Ping timeout: 240 seconds]
02:36 < bitcoin-git> [bitcoin] fanquake pushed 66 commits to master: https://github.com/bitcoin/bitcoin/compare/238c1c8933b1...fa283d28e261
02:36 < bitcoin-git> bitcoin/master 5143068 Suhas Daftuar: Allow moving an Epoch::Marker
02:36 < bitcoin-git> bitcoin/master 6c73e47 Suhas Daftuar: mempool: Store iterators into mapTx in mapNextTx
02:36 < bitcoin-git> bitcoin/master 92b0079 Suhas Daftuar: Allow moving CTxMemPoolEntry objects, disallow copying
02:36 < bitcoin-git> [bitcoin] fanquake merged pull request #33629: Cluster mempool (master...2025-02-cluster-mempool) https://github.com/bitcoin/bitcoin/pull/33629
02:38 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fa283d28e261...ff8c2f37497f
02:38 < bitcoin-git> bitcoin/master fa9537c MarcoFalke: ci: Use latest Xcode that the minimum macOS version allows
02:38 < bitcoin-git> bitcoin/master ff8c2f3 merge-script: Merge bitcoin/bitcoin#33932: ci: Use latest Xcode that the minimum macOS v...
02:38 < bitcoin-git> [bitcoin] fanquake merged pull request #33932: ci: Use latest Xcode that the minimum macOS version allows (master...2511-ci-xcode-macos-min-latest) https://github.com/bitcoin/bitcoin/pull/33932
02:45 -!- kevkevin [~kevkevin@209.242.39.30] has joined #bitcoin-core-dev
02:47 < willcl-ark> 🚀
02:49 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ff8c2f37497f...5fe753b56f45
02:49 < bitcoin-git> bitcoin/master 286f3e4 fanquake: guix: sqlite wants tcl
02:49 -!- kevkevin [~kevkevin@209.242.39.30] has quit [Ping timeout: 260 seconds]
02:49 < bitcoin-git> bitcoin/master 1db7491 fanquake: depends: sqlite 3.50.4
02:49 < bitcoin-git> bitcoin/master 5fe753b merge-script: Merge bitcoin/bitcoin#32655: depends: sqlite 3.50.4; switch to autosetup
02:49 < bitcoin-git> [bitcoin] fanquake merged pull request #32655: depends: sqlite 3.50.4; switch to autosetup (master...sqlite_3_50_0) https://github.com/bitcoin/bitcoin/pull/32655
03:14 -!- l0rinc [~l0rinc@user/l0rinc] has quit [Quit: l0rinc]
03:16 -!- l0rinc [~l0rinc@user/l0rinc] has joined #bitcoin-core-dev
03:24 -!- memset_ [~memset@gateway/tor-sasl/memset] has joined #bitcoin-core-dev
03:27 -!- memset [~memset@gateway/tor-sasl/memset] has quit [Ping timeout: 272 seconds]
03:29 -!- flooded [~flooded@45.87.214.26] has quit [Remote host closed the connection]
03:29 -!- flooded [~flooded@45.87.214.26] has joined #bitcoin-core-dev
03:43 < sipa> \o/
03:44 -!- kevkevin [~kevkevin@209.242.39.30] has joined #bitcoin-core-dev
03:45 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5fe753b56f45...7e129b644ec9
03:45 < bitcoin-git> bitcoin/master 8343a9f Sebastian Falbesoner: test: add `-alertnotify` test for large work invalid chain warning
03:45 < bitcoin-git> bitcoin/master 7e129b6 merge-script: Merge bitcoin/bitcoin#33893: test: add `-alertnotify` test for large work ...
03:45 < bitcoin-git> [bitcoin] fanquake merged pull request #33893: test: add `-alertnotify` test for large work invalid chain warning (master...202511-test-trigger_alertnotify_large_work_invalid_chain) https://github.com/bitcoin/bitcoin/pull/33893
03:49 -!- kevkevin [~kevkevin@209.242.39.30] has quit [Ping timeout: 256 seconds]
04:03 -!- luke-jr_ [~luke-jr@user/luke-jr] has quit [Ping timeout: 246 seconds]
04:04 -!- kevkevin [~kevkevin@209.242.39.30] has joined #bitcoin-core-dev
04:04 -!- luke-jr_ [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev
04:15 -!- f321x [~f321x@user/f321x] has quit [Remote host closed the connection]
04:15 -!- f321x [~f321x@user/f321x] has joined #bitcoin-core-dev
04:21 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7e129b644ec9...68ab2b65bfac
04:21 < bitcoin-git> bitcoin/master fa7ea49 MarcoFalke: ci: Run GUI unit tests in cross-Windows task
04:21 < bitcoin-git> bitcoin/master 68ab2b6 merge-script: Merge bitcoin/bitcoin#33919: ci: Run GUI unit tests in cross-Windows task
04:21 < bitcoin-git> [bitcoin] fanquake merged pull request #33919: ci: Run GUI unit tests in cross-Windows task (master...2511-ci-win-cross-gui-unit-test) https://github.com/bitcoin/bitcoin/pull/33919
04:22 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/68ab2b65bfac...902717b66dc1
04:22 < bitcoin-git> bitcoin/master 50cbde3 Hennadii Stepanov: depends: Update Qt download link
04:22 < bitcoin-git> bitcoin/master 902717b merge-script: Merge bitcoin/bitcoin#33918: depends: Update Qt download link
04:22 < bitcoin-git> [bitcoin] fanquake merged pull request #33918: depends: Update Qt download link (master...251120-qt-link) https://github.com/bitcoin/bitcoin/pull/33918
04:23 -!- Nebraskka [~Nebraskka@user/nebraskka] has joined #bitcoin-core-dev
04:24 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/902717b66dc1...4f65a1c5db84
04:24 < bitcoin-git> bitcoin/master fa7e222 MarcoFalke: clang-format: Set Bitcoin Core IncludeCategories
04:24 < bitcoin-git> bitcoin/master 4f65a1c merge-script: Merge bitcoin/bitcoin#33917: clang-format: Set Bitcoin Core IncludeCategor...
04:24 < bitcoin-git> [bitcoin] fanquake merged pull request #33917: clang-format: Set Bitcoin Core IncludeCategories (master...2511-format-includes) https://github.com/bitcoin/bitcoin/pull/33917
04:31 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4f65a1c5db84...5336bcd57849
04:31 < bitcoin-git> bitcoin/master 096924d stickies-v: kernel: add btck_block_tree_entry_equals
04:31 < bitcoin-git> bitcoin/master 5336bcd merge-script: Merge bitcoin/bitcoin#33855: kernel: add btck_block_tree_entry_equals
04:31 < bitcoin-git> [bitcoin] fanquake merged pull request #33855: kernel: add btck_block_tree_entry_equals (master...2025-11/kernel-block-tree-entry-equals) https://github.com/bitcoin/bitcoin/pull/33855
04:36 < TheCharlatan> nice merge list today :)
04:38 -!- robszarka [~szarka@2603:3003:4eac:100:7c98:25be:4359:bc73] has quit [Quit: Leaving]
04:39 -!- szarka [~szarka@2603:3003:4eac:100:7c98:25be:4359:bc73] has joined #bitcoin-core-dev
04:40 < dergoegge> 🚀
04:46 < bitcoin-git> [bitcoin] maflcko closed pull request #33937: depends: Fix native_capnp to respect build_CC and build_CXX (master...fix-native-capnp-compiler) https://github.com/bitcoin/bitcoin/pull/33937
04:52 < sdaftuar> \o/
05:06 < bitcoin-git> [bitcoin] fjahr closed pull request #33631: init: Split file path handling out of -asmap option (master...202510-asmap-arg-split) https://github.com/bitcoin/bitcoin/pull/33631
05:06 -!- kevkevin [~kevkevin@209.242.39.30] has quit [Ping timeout: 246 seconds]
05:08 < instagibbs> lessgooo
05:26 -!- kevkevin [~kevkevin@209.242.39.30] has joined #bitcoin-core-dev
05:30 -!- flooded [~flooded@45.87.214.26] has quit [Remote host closed the connection]
05:31 -!- flooded [~flooded@45.87.214.26] has joined #bitcoin-core-dev
05:47 -!- l0rinc [~l0rinc@user/l0rinc] has quit [Quit: l0rinc]
06:02 -!- eugenesiegel [~eugenesie@user/eugenesiegel] has joined #bitcoin-core-dev
06:15 -!- l0rinc [~l0rinc@user/l0rinc] has joined #bitcoin-core-dev
06:27 < bitcoin-git> [bitcoin] hebasto closed pull request #32409: test: Introduce `SUPPRESS_ABORT_MESSAGE` environment variable (master...250502-fuzz-abort) https://github.com/bitcoin/bitcoin/pull/32409
06:27 < bitcoin-git> [bitcoin] hebasto reopened pull request #32409: test: Introduce `SUPPRESS_ABORT_MESSAGE` environment variable (master...250502-fuzz-abort) https://github.com/bitcoin/bitcoin/pull/32409
06:29 -!- eugenesiegel [~eugenesie@user/eugenesiegel] has quit [Quit: Client closed]
06:35 -!- memset [~memset@gateway/tor-sasl/memset] has joined #bitcoin-core-dev
06:38 -!- memset_ [~memset@gateway/tor-sasl/memset] has quit [Ping timeout: 272 seconds]
06:41 -!- memset_ [~memset@gateway/tor-sasl/memset] has joined #bitcoin-core-dev
06:45 -!- memset [~memset@gateway/tor-sasl/memset] has quit [Ping timeout: 272 seconds]
06:47 -!- bugs_ [~bugs@user/bugs/x-5128603] has joined #bitcoin-core-dev
07:08 -!- l0rinc [~l0rinc@user/l0rinc] has quit [Quit: l0rinc]
07:23 < darosior> oO
07:24 < bitcoin-git> [bitcoin] stickies-v opened pull request #33943: kernel: don't use assert to handle invalid user input (master...2025-11/kernel-less-assert) https://github.com/bitcoin/bitcoin/pull/33943
07:56 -!- f321x [~f321x@user/f321x] has quit [Quit: f321x]
07:57 -!- f321x [~f321x@user/f321x] has joined #bitcoin-core-dev
07:58 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5336bcd57849...72cb8cef9778
07:58 < bitcoin-git> bitcoin/master ade0397 Anthony Towns: txgraph: drop move assignment operator
07:58 < bitcoin-git> bitcoin/master 72cb8ce merge-script: Merge bitcoin/bitcoin#33862: txgraph: drop move assignment operator
07:58 < bitcoin-git> [bitcoin] fanquake merged pull request #33862: txgraph: drop move assignment operator (master...202511_no_move_txgraph_ref) https://github.com/bitcoin/bitcoin/pull/33862
08:09 < bitcoin-git> [bitcoin] oxyzenQ opened pull request #33944: Request: fix typos in "release-notes-0.18.0.md" and "release-notes-0.15.0.1.md" (master...master) https://github.com/bitcoin/bitcoin/pull/33944
08:09 < bitcoin-git> [bitcoin] DrahtBot closed pull request #33944: Request: fix typos in "release-notes-0.18.0.md" and "release-notes-0.15.0.1.md" (master...master) https://github.com/bitcoin/bitcoin/pull/33944
08:26 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/72cb8cef9778...1a5f1eb08067
08:26 < bitcoin-git> bitcoin/master c34bc01 dergoegge: doc: clarify and cleanup macOS fuzzing notes
08:26 < bitcoin-git> bitcoin/master 1a5f1eb merge-script: Merge bitcoin/bitcoin#33921: doc: clarify and cleanup macOS fuzzing notes
08:26 < bitcoin-git> [bitcoin] fanquake merged pull request #33921: doc: clarify and cleanup macOS fuzzing notes (master...2025-11-fuzzing-docs) https://github.com/bitcoin/bitcoin/pull/33921
08:28 < bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/1a5f1eb08067...b30262dcaa28
08:28 < bitcoin-git> bitcoin/master 2222223 MarcoFalke: doc: Remove bash -c wrapper
08:28 < bitcoin-git> bitcoin/master fa102ec MarcoFalke: doc: Shorten ci name
08:28 < bitcoin-git> bitcoin/master fa0fee4 MarcoFalke: ci: Remove redundant busybox option
08:28 < bitcoin-git> [bitcoin] fanquake merged pull request #33903: ci: Remove redundant busybox option (master...2511-ci-stip-busybox-dupe) https://github.com/bitcoin/bitcoin/pull/33903
08:28 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
08:28 -!- afiore [~afiore@user/afiore] has joined #bitcoin-core-dev
08:32 -!- flooded [~flooded@45.87.214.26] has quit [Remote host closed the connection]
08:32 -!- flooded [~flooded@45.87.214.26] has joined #bitcoin-core-dev
08:40 < bitcoin-git> [bitcoin] fanquake opened pull request #33945: depends: latest config.guess & config.sub (master...latest_configguesssub) https://github.com/bitcoin/bitcoin/pull/33945
08:49 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
08:50 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
09:01 -!- Cory51 [~Cory@user/pasha] has joined #bitcoin-core-dev
09:02 -!- Cory24 [~Cory51@user/pasha] has joined #bitcoin-core-dev
09:05 -!- Cory [~Cory@user/pasha] has quit [Ping timeout: 250 seconds]
09:06 -!- Cory25 [~Cory24@user/pasha] has joined #bitcoin-core-dev
09:06 -!- Cory51 [~Cory@user/pasha] has quit [Ping timeout: 250 seconds]
09:06 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b30262dcaa28...d5ed4ba9d862
09:07 < bitcoin-git> bitcoin/master 8558902 Hennadii Stepanov: depends: Add patch for Windows11Style plugin
09:07 < bitcoin-git> bitcoin/master d5ed4ba merge-script: Merge bitcoin/bitcoin#33906: depends: Add patch for Windows11Style plugin
09:07 < bitcoin-git> [bitcoin] fanquake merged pull request #33906: depends: Add patch for Windows11Style plugin (master...251118-patch-win11-plugin) https://github.com/bitcoin/bitcoin/pull/33906
09:07 -!- Cory93 [~Cory25@user/pasha] has joined #bitcoin-core-dev
09:10 -!- Cory24 [~Cory51@user/pasha] has quit [Ping timeout: 250 seconds]
09:11 -!- l0rinc [~l0rinc@user/l0rinc] has joined #bitcoin-core-dev
09:11 -!- Cory25 [~Cory24@user/pasha] has quit [Ping timeout: 250 seconds]
09:13 -!- Cory72 [~Cory93@user/pasha] has joined #bitcoin-core-dev
09:14 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
09:15 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
09:17 -!- Cory93 [~Cory25@user/pasha] has quit [Ping timeout: 250 seconds]
09:24 -!- f321x [~f321x@user/f321x] has quit [Quit: f321x]
09:28 < fanquake> Fetched 21.1 MB in 1min 52s (188 kB/s)
09:28 < fanquake> Ubuntu package servers highly performant, as per usual
09:32 -!- flooded [~flooded@45.87.214.26] has quit [Remote host closed the connection]
09:33 -!- flooded [~flooded@45.87.214.26] has joined #bitcoin-core-dev
09:46 < sipa> ought to be enough for anybody
10:00 -!- l0rinc [~l0rinc@user/l0rinc] has quit [Quit: l0rinc]
10:05 -!- l0rinc [~l0rinc@user/l0rinc] has joined #bitcoin-core-dev
10:13 -!- l0rinc [~l0rinc@user/l0rinc] has quit [Ping timeout: 246 seconds]
10:19 -!- Talkless [~Talkless@138.199.6.197] has joined #bitcoin-core-dev
10:39 -!- Talkless [~Talkless@138.199.6.197] has quit [Ping timeout: 264 seconds]
10:39 -!- Talkless [~Talkless@193.32.127.203] has joined #bitcoin-core-dev
10:51 < instagibbs> it's one binary fanquake, what could it cost, 10GB?
11:00 < sipa> :D
11:15 -!- ___nick___ [~quassel@82.132.184.135] has joined #bitcoin-core-dev
11:24 < bitcoin-git> [bitcoin] Fibonacci747 opened pull request #33946: fix: remove redundant mempool lock in ChainImpl::isInMempool() (master...fix/redundant-mempool-lock-isInMempool) https://github.com/bitcoin/bitcoin/pull/33946
11:28 -!- ___nick___ [~quassel@82.132.184.135] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
11:30 -!- ___nick___ [~quassel@82.132.184.135] has joined #bitcoin-core-dev
11:31 -!- ___nick___ [~quassel@82.132.184.135] has quit [Client Quit]
11:32 -!- ___nick___ [~quassel@82.132.184.135] has joined #bitcoin-core-dev
11:34 -!- flooded [~flooded@45.87.214.26] has quit [Read error: Connection reset by peer]
11:34 -!- flooded [~flooded@45.87.214.26] has joined #bitcoin-core-dev
11:44 < fanquake> instagibbs: you wouldn’t download a blockchain
12:05 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has quit [Remote host closed the connection]
12:05 -!- Talkless [~Talkless@193.32.127.203] has quit [Quit: Konversation terminated!]
12:07 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has joined #bitcoin-core-dev
12:42 -!- Guest1 [~Guest1@78.209.203.170] has joined #bitcoin-core-dev
12:46 -!- Guest1 [~Guest1@78.209.203.170] has quit [Client Quit]
12:52 -!- memset_ [~memset@gateway/tor-sasl/memset] has quit [Remote host closed the connection]
12:53 -!- memset [~memset@gateway/tor-sasl/memset] has joined #bitcoin-core-dev
13:03 -!- ___nick___ [~quassel@82.132.184.135] has quit [Ping timeout: 240 seconds]
13:12 -!- bugs_ [~bugs@user/bugs/x-5128603] has quit [Quit: Leaving]
13:17 -!- Cory72 [~Cory93@user/pasha] has quit [Quit: Ping timeout (120 seconds)]
13:17 -!- Cory72 [~Cory72@user/pasha] has joined #bitcoin-core-dev
13:52 < sipa> ain't nobody got time for that
13:59 -!- l0rinc [~l0rinc@user/l0rinc] has joined #bitcoin-core-dev
14:10 -!- Cory72 [~Cory72@user/pasha] has quit [Quit: Client closed]
14:11 -!- Cory72 [~Cory72@user/pasha] has joined #bitcoin-core-dev
14:14 -!- BlueMatt [~BlueMatt@ircb.bluematt.me] has quit [Ping timeout: 256 seconds]
14:15 -!- BlueMatt [~BlueMatt@ircb.bluematt.me] has joined #bitcoin-core-dev
14:15 -!- sr_gi[m]1 [~srgimatri@2620:6e:a000:ce11::2a] has quit [Ping timeout: 245 seconds]
14:15 -!- sr_gi[m]1 [~srgimatri@2620:6e:a000:ce11::2a] has joined #bitcoin-core-dev
14:17 -!- stringintech [~stringint@user/stringintech] has quit [Ping timeout: 256 seconds]
14:20 -!- cm_ [~chaz@user/cm] has joined #bitcoin-core-dev
14:21 -!- cm [~chaz@user/cm] has quit [Ping timeout: 246 seconds]
14:21 -!- cm_ is now known as cm
14:25 -!- stringintech [~stringint@user/stringintech] has joined #bitcoin-core-dev
14:36 -!- flooded [~flooded@45.87.214.26] has quit [Remote host closed the connection]
14:36 -!- flooded [~flooded@45.87.214.26] has joined #bitcoin-core-dev
14:51 -!- Cory8 [~Cory72@user/pasha] has joined #bitcoin-core-dev
14:54 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has quit [Quit: PaperSword]
14:55 -!- Cory72 [~Cory72@user/pasha] has quit [Ping timeout: 250 seconds]
15:10 -!- l0rinc [~l0rinc@user/l0rinc] has quit [Ping timeout: 240 seconds]
15:11 -!- memset [~memset@gateway/tor-sasl/memset] has quit [Remote host closed the connection]
15:11 -!- dzxzg [~dzxzg@user/dzxzg] has joined #bitcoin-core-dev
15:12 -!- memset [~memset@gateway/tor-sasl/memset] has joined #bitcoin-core-dev
15:24 -!- durandal_ [~durandal@94.196.68.109.threembb.co.uk] has quit [Ping timeout: 240 seconds]
15:32 -!- cotsuka [~cotsuka@user/cotsuka] has quit [Remote host closed the connection]
15:34 -!- cotsuka [~cotsuka@user/cotsuka] has joined #bitcoin-core-dev
15:37 -!- durandal_ [~durandal@94.196.79.15.threembb.co.uk] has joined #bitcoin-core-dev
16:00 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has joined #bitcoin-core-dev
16:19 -!- Cory8 [~Cory72@user/pasha] has quit [Quit: Client closed]
16:20 -!- Cory8 [~Cory8@user/pasha] has joined #bitcoin-core-dev
16:30 -!- Cory40 [~Cory8@user/pasha] has joined #bitcoin-core-dev
16:33 < dzxzg> with the PIMPL pattern for e.g. PeerMan and PeerManImpl, what is the philosophy for unit testing functions that are internal to PeerManImpl and don't need to be exposed through PeerMan? For e.g. the stale tip eviction unit test we export the internal function: https://github.com/bitcoin/bitcoin/blob/d5ed4ba9d8627f1897322ce7eb5b34e08e4f73ac/src/net_processing.h#L141-L142
16:34 < dzxzg> Is the answer to only test "public" interfaces? 
16:34 -!- Cory8 [~Cory8@user/pasha] has quit [Ping timeout: 250 seconds]
16:53 < dzxzg> It just seems like esp. for peermanagerimpl, the scope of internal functions grows from a one-off utility to something with lots of users with various subtle expectations; to make it concrete, in the case of PeerManagerImpl::BlockRequested, would anyone object to continuing the approach of exporting stuff into the interface class just for the purpose of being used in unit tests?
17:01 -!- Cory59 [~Cory40@user/pasha] has joined #bitcoin-core-dev
17:05 -!- Cory40 [~Cory8@user/pasha] has quit [Ping timeout: 250 seconds]
17:42 < dzxzg> maybe this is just an argument for breaking stuff out of PeerManImpl into smaller chunks
17:59 -!- dzxzg [~dzxzg@user/dzxzg] has quit [Remote host closed the connection]
18:38 -!- flooded [~flooded@45.87.214.26] has quit [Remote host closed the connection]
18:38 -!- flooded [~flooded@45.87.214.26] has joined #bitcoin-core-dev
18:44 < sipa> dzxzg: could make them protected, or make the test function/class a friend
18:59 -!- conman [~con@180-150-21-3.b49615.mel.static.aussiebb.net] has quit [Quit: Konversation terminated!]
19:00 -!- conman [~con@180-150-21-3.b49615.mel.static.aussiebb.net] has joined #bitcoin-core-dev
19:05 -!- Cory59 [~Cory40@user/pasha] has quit [Quit: Client closed]
19:05 -!- Cory59 [~Cory59@user/pasha] has joined #bitcoin-core-dev
19:38 -!- flooded [~flooded@45.87.214.26] has quit [Remote host closed the connection]
19:39 -!- flooded [~flooded@45.87.214.26] has joined #bitcoin-core-dev
20:00 -!- afiore [~afiore@user/afiore] has quit [Remote host closed the connection]
20:00 -!- afiore [~afiore@user/afiore] has joined #bitcoin-core-dev
20:08 -!- Cory59 [~Cory59@user/pasha] has quit [Quit: Client closed]
20:09 -!- Cory59 [~Cory59@user/pasha] has joined #bitcoin-core-dev
20:39 -!- flooded [~flooded@45.87.214.26] has quit [Remote host closed the connection]
20:39 -!- flooded [~flooded@45.87.214.26] has joined #bitcoin-core-dev
20:45 -!- saturday- [~saturday7@168.140.255.200] has joined #bitcoin-core-dev
20:45 -!- saturday7 [~saturday7@206.83.123.231] has quit [Ping timeout: 240 seconds]
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:19 -!- bcdarc [~bcdarc@4.53.92.114] has quit [Ping timeout: 244 seconds]
21:19 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
21:20 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
21:20 -!- cmirror [~cmirror@4.53.92.114] has quit [Ping timeout: 264 seconds]
22:09 -!- sdaftuar [~sdaftuar@user/sdaftuar] has quit [Ping timeout: 244 seconds]
22:10 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
22:12 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
22:13 -!- kevkevin [~kevkevin@209.242.39.30] has quit [Remote host closed the connection]
22:30 -!- kevkevin [~kevkevin@209.242.39.30] has joined #bitcoin-core-dev
22:34 -!- kevkevin [~kevkevin@209.242.39.30] has quit [Ping timeout: 240 seconds]
22:46 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
22:47 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
23:04 -!- kevkevin [~kevkevin@209.242.39.30] has joined #bitcoin-core-dev
23:08 -!- kevkevin [~kevkevin@209.242.39.30] has quit [Ping timeout: 260 seconds]
23:39 -!- kevkevin [~kevkevin@209.242.39.30] has joined #bitcoin-core-dev
--- Log closed Wed Nov 26 00:00:49 2025