--- Log opened Wed May 22 08:27:56 2019 08:27 -!- kanzure [~kanzure@unaffiliated/kanzure] has joined #bitcoin-core-pr-reviews 08:27 -!- Irssi: #bitcoin-core-pr-reviews: Total of 43 nicks [0 ops, 0 halfops, 0 voices, 43 normal] 08:27 -!- Irssi: Join to #bitcoin-core-pr-reviews was synced in 1 secs 08:31 -!- peevsie [peevsie@gateway/vpn/privateinternetaccess/peevsie] has quit [Quit: Konversation terminated!] 08:35 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-pr-reviews 08:36 -!- ccdle12 [~ccdle12@1-64-37-052.static.netvigator.com] has quit [Ping timeout: 268 seconds] 08:38 -!- peevsie [peevsie@gateway/vpn/privateinternetaccess/peevsie] has joined #bitcoin-core-pr-reviews 08:40 -!- ccdle12 [~ccdle12@1-64-37-052.static.netvigator.com] has joined #bitcoin-core-pr-reviews 08:58 -!- ccdle12 [~ccdle12@1-64-37-052.static.netvigator.com] has quit [Ping timeout: 245 seconds] 08:59 -!- ccdle12 [~ccdle12@1-64-37-052.static.netvigator.com] has joined #bitcoin-core-pr-reviews 09:05 -!- jonatack [6d0d4c36@gateway/web/freenode/ip.109.13.76.54] has joined #bitcoin-core-pr-reviews 09:09 -!- peevsie [peevsie@gateway/vpn/privateinternetaccess/peevsie] has quit [Quit: Konversation terminated!] 09:21 -!- ccdle12 [~ccdle12@1-64-37-052.static.netvigator.com] has quit [Ping timeout: 248 seconds] 09:25 -!- ccdle12 [~ccdle12@1-64-37-052.static.netvigator.com] has joined #bitcoin-core-pr-reviews 09:42 -!- michaelfolkson [~textual@82-132-232-195.dab.02.net] has quit [Ping timeout: 272 seconds] 09:44 -!- ccdle12 [~ccdle12@1-64-37-052.static.netvigator.com] has quit [Ping timeout: 272 seconds] 09:48 -!- ccdle12 [~ccdle12@1-64-37-052.static.netvigator.com] has joined #bitcoin-core-pr-reviews 09:55 < jnewbery> 5 minute warning 09:56 -!- peevsie [peevsie@gateway/vpn/privateinternetaccess/peevsie] has joined #bitcoin-core-pr-reviews 09:59 -!- michaelfolkson [~textual@85.211.233.88] has joined #bitcoin-core-pr-reviews 10:00 -!- peevsie [peevsie@gateway/vpn/privateinternetaccess/peevsie] has quit [Client Quit] 10:00 -!- peevsie [peevsie@gateway/vpn/privateinternetaccess/peevsie] has joined #bitcoin-core-pr-reviews 10:02 < jnewbery> hi! 10:02 < dmkathayat_> Hi! 10:02 < davterra> Hi! 10:02 < ariard> hi 10:03 < peevsie> yo 10:03 < jnewbery> Today's PR is https://github.com/bitcoin/bitcoin/pull/15450 10:03 < pinheadmz> buenos dias 10:03 < emzy> Hi 10:03 < michaelfolkson> What up. Head spinning trying to work out how all these PRs overlap lol 10:03 < jnewbery> I wrote my review notes here: https://bitcoin-core-review-club.github.io/15450.html to save us some time at the start of the meeting 10:03 < jonatack> hi 10:04 < jnewbery> So rather than me talking for 5 minutes now, let's just get straight into questions 10:04 -!- amiti [6bd29f36@gateway/web/freenode/ip.107.210.159.54] has joined #bitcoin-core-pr-reviews 10:04 < jonatack> is no testing for qt a thing 10:05 < jnewbery> Most qt PRs don't include tests 10:05 < jnewbery> But there are some in src/qt/test 10:06 -!- ccdle12 [~ccdle12@1-64-37-052.static.netvigator.com] has quit [Ping timeout: 258 seconds] 10:06 < MarcoFalke> Yeah, and those are more like gui unit tests, not actual gui tests 10:07 < MarcoFalke> Currently the only way to test the GUI is by running it by hand 10:08 < michaelfolkson> So to confirm I understand what is going on. You can currently create a new independent HD wallet using bitcoind but until now you couldn't using Qt. Qt can't leverage bitcoind RPC so the C++ code needs to be written afresh for Qt in addition to editing the GUI? 10:10 < jnewbery> michaelfolkson: we try to make the RPC layer as thin as possible so functionality can be shared between RPC and QT. Here's the createwallet RPC: https://github.com/bitcoin/bitcoin/blob/1c177c3a004f91eca743bb3a0dd9534a544026d5/src/wallet/rpcwallet.cpp#L2642 10:10 < jnewbery> You can see that it's mostly just parsing arguments and then calling CWallet::CreateWalletFromFile() which does the heavy lifting 10:10 -!- ccdle12 [~ccdle12@1-64-37-052.static.netvigator.com] has joined #bitcoin-core-pr-reviews 10:11 -!- lightlike [6d28808a@gateway/web/freenode/ip.109.40.128.138] has joined #bitcoin-core-pr-reviews 10:11 < jnewbery> This PR adds a new method to the node interface called createWallet() which basically does the same stuff 10:11 -!- ajonas [~ajonas@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-pr-reviews 10:11 < jnewbery> https://github.com/bitcoin/bitcoin/pull/15450/files#diff-7e7292143c1cc2b4125d85f1ae5cf046R261 10:12 < jonatack> thanks! i suppose then that units are added for any new non-qt code. seem might still be good to add e2e tests for the user flows. 10:12 < jonatack> unit tests 10:12 < jnewbery> jonatack: Yes, I think that would be valuable contribution 10:12 < jonatack> end to end functional ones? 10:12 < jnewbery> yes 10:12 < jonatack> ty 10:13 < jnewbery> I don't know anything about testing QT 10:13 < jnewbery> But I imagine there's documentation on the QT website 10:13 < MarcoFalke> Indeed, I'd welcome any progress in that direction 10:13 < jnewbery> michaelfolkson: to follow up on my comment in the review notes "This PR was opened before the born-encrypted wallets PR was merged, so potentially could be simplified now that the functionality exists within the wallet component. 10:13 < MarcoFalke> I don't know if there are existing framworks 10:14 < jnewbery> You can see here: https://github.com/bitcoin/bitcoin/pull/15450/files#diff-fef859e81d3321e85221891fd768efadR75 that there's some duplication of logic for creating an encrypted wallet 10:14 -!- merehap [~sean@206.189.214.46] has joined #bitcoin-core-pr-reviews 10:16 < jnewbery> that logic now exists in the wallet RPC: https://github.com/bitcoin/bitcoin/blob/master/src/wallet/rpcwallet.cpp#L2710 . Perhaps this could be factored out of there into wallet.cpp and then shared by the RPC and QT 10:16 < michaelfolkson> : Thanks, that's useful. I wasn't expecting to see any C++ code for this PR, I was expecting to just be looking at GUI design. But I forgot that Qt wasn't just a front end 10:16 < jnewbery> I'm not entirely sure of that though. I haven't checked whether there are subtle differences in what logic is required for QT and RPC 10:17 < jnewbery> Yep, it's all C++ 10:19 < jnewbery> Did everyone manage to build the PR and do some manual testing? 10:19 < jnewbery> Any questions about that? 10:20 < jnewbery> I guess that's it for today. Short meeting! 10:20 < jnewbery> Before we go, does anyone have requests for future PRs to cover? 10:21 < jonatack> i compiled but didn't run it yet because i didn't see it in root or source 10:21 < jonatack> any pointers ? 10:21 < jnewbery> jonatack: it should be at src/qt/bitcoin-qt 10:21 < jnewbery> if not, perhaps you're not configured to build the qt binary. Check the output from when you ran `configure` 10:22 < jnewbery> You should see: 'with gui / qt = yes' 10:22 < jonatack> all good 10:22 < emzy> I had no time to do it. Maybe I will check it later. 10:22 < michaelfolkson> For the creating blank empty wallets PR, what's the motivation for doing this? Importing a seed from elsewhere? 10:22 < jonatack> i never run qt, thanks for the tpi 10:22 < jonatack> tip 10:22 < michaelfolkson> #15226 10:23 < jnewbery> michaelfolkson: by default, a new wallet will generate an HD seed 10:23 < MarcoFalke> To follow up on the "How to test the GUI" question earlier: The only framework I am aware of is used by operating systems: OpenQA. I think it is a Open Suse in-house product. See https://openqa.opensuse.org/tests/940238#step/bootloader/3 10:23 < jnewbery> if you want to import your own seed, you can create a blank wallet and then import 10:24 < jnewbery> another motivation: when you encrypt the wallet, it'll create a new seed, so if you created a wallet that wasn't blank, you'd have a seed from before encryption and then a seed from after encryption, which perhaps you don't want 10:25 < jnewbery> #15226 also made #15006 (Add option to create an encrypted wallet) much simpler 10:25 < jonatack> thanks marco 10:25 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection] 10:25 < ariard> I had a a more general question which is on travis build process, I often get a timeout error "Error! Initial build successful, but not enough time..." What's the process to do after that ? Force-push new branch tip? 10:26 < MarcoFalke> Created an issue for that https://github.com/bitcoin/bitcoin/issues/16075 10:26 < MarcoFalke> jonatack: et al ^ 10:26 < ariard> Do this also mean things have been modified which make tests longer to run ? 10:26 < jonatack> MarcoFalke: nice 10:26 < jnewbery> ariard: Yes, I believe force-pushing the branch will trigger a rebuild on travis 10:27 < jnewbery> just run `git commit --amend` to update the timestamp and then `git force push` 10:27 < jonatack> today's pr has seen no activity since 3 months. 10:28 < ariard> jnewbery: thanks for tip! 10:28 < jonatack> does achow have too much on his plate, does he need more help 10:28 < jonatack> or is it not a priority 10:29 < jnewbery> It might just not be a priority for him. I know he has a PR for a descriptor-based wallet, which is large and more important 10:29 < jonatack> right 10:30 < jnewbery> In general, if you see PRs that haven't had attention from their author for a while, there's nothing wrong in offering to take over maintaining the PR 10:32 < jnewbery> any other questions? 10:32 < jonatack> MarcoFalke: 10:32 < jonatack> do you plan to resubmit a pr 10:32 < jonatack> for the f tests speedup 10:32 < jonatack> you had 2 10:32 < michaelfolkson> achow is overseeing the Bitcoin Core hardware wallet interface too isn't he? That is ongoing 10:33 < MarcoFalke> jonatack: Good question. Not sure if we are allowed to discuss other prs here 10:33 < MarcoFalke> jnewbery: ? ^ 10:33 < jonatack> related to ariard's q 10:33 < jnewbery> Is it directly related to this week's PR? If not, I think #bitcoin-core-dev is the better place to discuss it (so all interested parties can see it) 10:34 < jonatack> ok 10:34 -!- lightlike_ [25183b42@gateway/web/freenode/ip.37.24.59.66] has joined #bitcoin-core-pr-reviews 10:35 < jonatack> qt is now running for me ty for the help jnewbery 10:36 -!- lightlike [6d28808a@gateway/web/freenode/ip.109.40.128.138] has quit [Ping timeout: 256 seconds] 10:36 < jnewbery> michaelfolkson: yes, achow maintains HWI 10:36 < jnewbery> jonatack: great! 10:36 < jnewbery> ok, unless there are any final questions, let's wrap it up. 10:37 < jnewbery> Thanks all! See you next week 10:37 < emzy> Tnx! 10:37 < jonatack> cheers! thanks everyone 10:38 < michaelfolkson> A quick final question? :) 10:38 < jnewbery> go for it! 10:39 < jnewbery> michaelfolkson: was 'A quick final question?' the final question or is there a question after that question? 10:40 < michaelfolkson> So what are next steps for advancing this? Someone who understands the code for the GUI needs to oversee all the merge conflicts between these different PRs? 10:40 < michaelfolkson> Sorry yes 10:40 < jnewbery> Which different PRs? This one doesn't currently conflict with anything 10:40 < michaelfolkson> And there needs to be more feedback on the design. I saw Sjors gave some suggestions for what the UI should be 10:41 < michaelfolkson> I was seeing a bunch of conflicts on one of the PRs you linked to 10:42 < jnewbery> Yeah, i think it's still appropriate to give design feedback at this stage 10:42 < jonatack> michael: perhaps adding a recent review can kick the pr back into action 10:42 -!- ccdle12 [~ccdle12@1-64-37-052.static.netvigator.com] has quit [Ping timeout: 268 seconds] 10:42 < jnewbery> I agree. achow will probably be more motivated to work on it if he knows there are people keen to review 10:44 < michaelfolkson> Ok cool. It is just design considerations now right? 10:44 < jnewbery> No, the code needs review too 10:44 < jnewbery> all aspects of the PR 10:45 < michaelfolkson> Ok understood, thanks 10:45 < michaelfolkson> Ok I'll let you go, many thanks 10:46 < jnewbery> ok, thanks again. See you all next time! 10:46 -!- ccdle12 [~ccdle12@1-64-37-052.static.netvigator.com] has joined #bitcoin-core-pr-reviews 10:49 -!- lightlike_ [25183b42@gateway/web/freenode/ip.37.24.59.66] has quit [Quit: Page closed] 10:51 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 272 seconds] 10:51 -!- jonatack [6d0d4c36@gateway/web/freenode/ip.109.13.76.54] has quit [Ping timeout: 256 seconds] 10:53 < jnewbery> meeting log is here: https://bitcoin-core-review-club.github.io/15450.html 10:54 -!- watchtower [~watchtowe@pool-96-239-24-37.nycmny.fios.verizon.net] has joined #bitcoin-core-pr-reviews 11:09 -!- ccdle12 [~ccdle12@1-64-37-052.static.netvigator.com] has quit [Ping timeout: 248 seconds] 11:13 -!- ccdle12 [~ccdle12@1-64-37-052.static.netvigator.com] has joined #bitcoin-core-pr-reviews 11:16 -!- michaelfolkson [~textual@85.211.233.88] has quit [Quit: Sleep mode] 11:27 -!- ccdle12 [~ccdle12@1-64-37-052.static.netvigator.com] has quit [Ping timeout: 258 seconds] 11:31 -!- ccdle12 [~ccdle12@1-64-37-052.static.netvigator.com] has joined #bitcoin-core-pr-reviews 11:39 -!- michaelfolkson [~textual@85.211.233.88] has joined #bitcoin-core-pr-reviews 11:39 -!- csknk [~csknk@unaffiliated/csknk] has quit [Quit: leaving] 11:45 -!- michaelfolkson [~textual@85.211.233.88] has quit [Quit: Sleep mode] 11:46 -!- amiti [6bd29f36@gateway/web/freenode/ip.107.210.159.54] has quit [Quit: Page closed] 11:53 -!- ccdle12 [~ccdle12@1-64-37-052.static.netvigator.com] has quit [Ping timeout: 268 seconds] 12:16 -!- ccdle12 [~ccdle12@1-64-37-052.static.netvigator.com] has joined #bitcoin-core-pr-reviews 12:29 -!- MarcoFalke [~none@198.12.116.246] has quit [Ping timeout: 245 seconds] 12:35 -!- watchtower [~watchtowe@pool-96-239-24-37.nycmny.fios.verizon.net] has quit [Quit: Leaving] 12:43 -!- ccdle12 [~ccdle12@1-64-37-052.static.netvigator.com] has quit [Ping timeout: 258 seconds] 12:47 -!- ccdle12 [~ccdle12@1-64-37-052.static.netvigator.com] has joined #bitcoin-core-pr-reviews 12:49 -!- ajonas_ [~ajonas@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-pr-reviews 12:52 -!- ajonas [~ajonas@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Ping timeout: 272 seconds] 13:06 -!- ccdle12 [~ccdle12@1-64-37-052.static.netvigator.com] has quit [Ping timeout: 258 seconds] 13:10 -!- ccdle12 [~ccdle12@1-64-37-052.static.netvigator.com] has joined #bitcoin-core-pr-reviews 13:14 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-pr-reviews 13:26 -!- ccdle12 [~ccdle12@1-64-37-052.static.netvigator.com] has quit [Read error: Connection timed out] 13:32 -!- ccdle12 [~ccdle12@1-64-37-052.static.netvigator.com] has joined #bitcoin-core-pr-reviews 13:54 -!- ccdle12 [~ccdle12@1-64-37-052.static.netvigator.com] has quit [Ping timeout: 248 seconds] 13:59 -!- ccdle12 [~ccdle12@1-64-37-052.static.netvigator.com] has joined #bitcoin-core-pr-reviews 14:04 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-pr-reviews 14:17 -!- ccdle12 [~ccdle12@1-64-37-052.static.netvigator.com] has quit [Ping timeout: 248 seconds] 14:17 -!- ccdle12 [~ccdle12@1-64-37-052.static.netvigator.com] has joined #bitcoin-core-pr-reviews 14:32 -!- michaelfolkson [~textual@85.211.233.88] has joined #bitcoin-core-pr-reviews 14:43 -!- michaelfolkson [~textual@85.211.233.88] has quit [Quit: Textual IRC Client: www.textualapp.com] 14:43 -!- michaelfolkson [~textual@85.211.233.88] has joined #bitcoin-core-pr-reviews 14:44 -!- ccdle12 [~ccdle12@1-64-37-052.static.netvigator.com] has quit [Ping timeout: 246 seconds] 14:45 -!- michaelfolkson [~textual@85.211.233.88] has quit [Client Quit] 14:46 -!- michaelfolkson [~textual@85.211.233.88] has joined #bitcoin-core-pr-reviews 14:46 -!- michaelfolkson [~textual@85.211.233.88] has quit [Client Quit] 14:47 -!- michaelfolkson [~textual@85.211.233.88] has joined #bitcoin-core-pr-reviews 14:48 -!- ccdle12 [~ccdle12@1-64-37-052.static.netvigator.com] has joined #bitcoin-core-pr-reviews 14:49 -!- ajonas_ [~ajonas@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Ping timeout: 246 seconds] 14:55 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 14:59 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Remote host closed the connection] 15:06 -!- ccdle12 [~ccdle12@1-64-37-052.static.netvigator.com] has quit [Ping timeout: 245 seconds] 15:07 -!- ccdle12 [~ccdle12@1-64-37-052.static.netvigator.com] has joined #bitcoin-core-pr-reviews 15:10 -!- MarcoFalke [~none@198.12.116.246] has joined #bitcoin-core-pr-reviews 15:11 -!- ccdle12 [~ccdle12@1-64-37-052.static.netvigator.com] has quit [Ping timeout: 248 seconds] 15:16 -!- ccdle12 [~ccdle12@1-64-37-052.static.netvigator.com] has joined #bitcoin-core-pr-reviews 15:21 -!- michaelfolkson [~textual@85.211.233.88] has quit [Quit: Sleep mode] 15:44 -!- pinheadmz [~matthewzi@c-67-170-233-212.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 15:47 -!- ccdle12 [~ccdle12@1-64-37-052.static.netvigator.com] has quit [Ping timeout: 272 seconds] 15:51 -!- ccdle12 [~ccdle12@1-64-37-052.static.netvigator.com] has joined #bitcoin-core-pr-reviews 16:03 -!- ccdle12_ [~ccdle12@1-64-37-052.static.netvigator.com] has joined #bitcoin-core-pr-reviews 16:03 -!- ccdle12 [~ccdle12@1-64-37-052.static.netvigator.com] has quit [Remote host closed the connection] 17:12 -!- peevsie [peevsie@gateway/vpn/privateinternetaccess/peevsie] has quit [Ping timeout: 268 seconds] 18:45 -!- pinheadmz [~matthewzi@c-67-170-233-212.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 19:14 -!- ccdle12_ [~ccdle12@1-64-37-052.static.netvigator.com] has quit [Remote host closed the connection] 19:18 -!- ccdle12 [~ccdle12@1-64-37-052.static.netvigator.com] has joined #bitcoin-core-pr-reviews 19:29 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 19:41 -!- ccdle12 [~ccdle12@1-64-37-052.static.netvigator.com] has quit [Ping timeout: 258 seconds] 19:46 -!- ccdle12 [~ccdle12@1-64-37-052.static.netvigator.com] has joined #bitcoin-core-pr-reviews 19:49 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-pr-reviews 20:09 -!- ccdle12 [~ccdle12@1-64-37-052.static.netvigator.com] has quit [Ping timeout: 268 seconds] 20:12 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection] 20:12 -!- ccdle12 [~ccdle12@1-64-37-052.static.netvigator.com] has joined #bitcoin-core-pr-reviews 20:15 -!- davterra [~tralfaz@178.128.106.205] has quit [Remote host closed the connection] 20:20 -!- davterra [~tralfaz@178.128.106.205] has joined #bitcoin-core-pr-reviews 20:31 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 20:35 -!- ccdle12 [~ccdle12@1-64-37-052.static.netvigator.com] has quit [Ping timeout: 248 seconds] 20:46 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 23:48 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-pr-reviews 23:56 -!- davterra [~tralfaz@178.128.106.205] has quit [Ping timeout: 244 seconds]