--- Day changed Tue May 28 2019 00:42 -!- ccdle12 [~ccdle12@175.45.39.66] has joined #bitcoin-core-pr-reviews 00:48 -!- ccdle12 [~ccdle12@175.45.39.66] has quit [Remote host closed the connection] 00:50 -!- ccdle12 [~ccdle12@175.45.39.66] has joined #bitcoin-core-pr-reviews 01:14 -!- ccdle12 [~ccdle12@175.45.39.66] has quit [Remote host closed the connection] 02:18 -!- ccdle12 [~ccdle12@175.45.39.66] has joined #bitcoin-core-pr-reviews 02:51 -!- b10c [~b10c@2001:16b8:2e47:5300:30e8:c7fe:7952:c0e5] has joined #bitcoin-core-pr-reviews 02:52 -!- b10c [~b10c@2001:16b8:2e47:5300:30e8:c7fe:7952:c0e5] has quit [Client Quit] 02:56 -!- ccdle12 [~ccdle12@175.45.39.66] has quit [Remote host closed the connection] 02:57 -!- ccdle12 [~ccdle12@175.45.39.66] has joined #bitcoin-core-pr-reviews 03:03 -!- ccdle12 [~ccdle12@175.45.39.66] has quit [Remote host closed the connection] 03:31 -!- ccdle12 [~ccdle12@175.45.39.66] has joined #bitcoin-core-pr-reviews 03:32 -!- ccdle12 [~ccdle12@175.45.39.66] has quit [Remote host closed the connection] 04:00 -!- ccdle12 [~ccdle12@175.45.39.66] has joined #bitcoin-core-pr-reviews 04:01 -!- ccdle12_ [~ccdle12@175.45.39.66] has joined #bitcoin-core-pr-reviews 04:05 -!- ccdle12 [~ccdle12@175.45.39.66] has quit [Ping timeout: 248 seconds] 04:56 -!- ccdle12 [~ccdle12@175.45.39.66] has joined #bitcoin-core-pr-reviews 04:57 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has quit [Ping timeout: 258 seconds] 04:59 -!- ccdle12_ [~ccdle12@175.45.39.66] has quit [Ping timeout: 244 seconds] 05:46 -!- michaelfolkson [~textual@host109-156-0-155.range109-156.btcentralplus.com] has joined #bitcoin-core-pr-reviews 05:56 -!- michaelfolkson [~textual@host109-156-0-155.range109-156.btcentralplus.com] has quit [Quit: Sleep mode] 05:59 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:40f6:40c9:a5d8:162e] has joined #bitcoin-core-pr-reviews 06:24 -!- ccdle12 [~ccdle12@175.45.39.66] has quit [Remote host closed the connection] 06:32 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:40f6:40c9:a5d8:162e] has quit [Quit: Sleep mode] 06:42 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:40f6:40c9:a5d8:162e] has joined #bitcoin-core-pr-reviews 06:43 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:40f6:40c9:a5d8:162e] has quit [Client Quit] 06:47 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:40f6:40c9:a5d8:162e] has joined #bitcoin-core-pr-reviews 06:49 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:40f6:40c9:a5d8:162e] has quit [Client Quit] 06:53 -!- ajonas [~ajonas@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-pr-reviews 06:54 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:40f6:40c9:a5d8:162e] has joined #bitcoin-core-pr-reviews 07:11 -!- ajonas_ [~ajonas@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-pr-reviews 07:14 -!- ajonas [~ajonas@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Ping timeout: 248 seconds] 07:19 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:40f6:40c9:a5d8:162e] has quit [Quit: Sleep mode] 07:30 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has joined #bitcoin-core-pr-reviews 07:30 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:40f6:40c9:a5d8:162e] has joined #bitcoin-core-pr-reviews 07:46 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 07:57 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:40f6:40c9:a5d8:162e] has quit [Quit: Sleep mode] 07:59 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:40f6:40c9:a5d8:162e] has joined #bitcoin-core-pr-reviews 08:03 -!- csknk [~csknk@unaffiliated/csknk] has joined #bitcoin-core-pr-reviews 08:05 -!- csknk [~csknk@unaffiliated/csknk] has quit [Client Quit] 08:23 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:40f6:40c9:a5d8:162e] has quit [Quit: Sleep mode] 08:31 < fanquake> If anyone wants a trivial GUI PR to test, I've just opened https://github.com/bitcoin/bitcoin/pull/16113. Review can be as simple as a screenshot of the coin control dialog on your system. I have not tested on anything other than macOS. 08:35 < fanquake> https://github.com/bitcoin/bitcoin/pull/16090 falls into a similar easy to test category. I'm not seeing the "before" behavior locally (macOS), but review there can also just be a quick look at the .ui changes, confirming the fix (if you see the 'before') and maybe master/16090 screens of the peers dialog. 08:38 < fanquake> If your interested in the build system, https://github.com/bitcoin/bitcoin/pull/16089 is small & self contained. You can test depends building using the NO_ZMQ flag , ie check that the zeromq isn't downloaded or built when =1 is passed, as well as that if you build with NO_ZMQ=1, the correct options are being passed to ./configure. 08:38 < fanquake> I'm happy to help / answer questions about any of the above here/via email etc. 09:25 -!- booyah_ is now known as booyah 09:47 -!- davterra [~tralfaz@178.128.106.205] has quit [Remote host closed the connection] 09:47 -!- davterra [~tralfaz@178.128.106.205] has joined #bitcoin-core-pr-reviews 10:37 -!- ironbutt [~LiberLive@144.49.211.130.bc.googleusercontent.com] has quit [Ping timeout: 245 seconds] 10:48 -!- ironbutt [~LiberLive@82.142.166.82] has joined #bitcoin-core-pr-reviews 11:41 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection] 12:56 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has quit [Ping timeout: 246 seconds] 12:58 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has joined #bitcoin-core-pr-reviews 14:10 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:40f6:40c9:a5d8:162e] has joined #bitcoin-core-pr-reviews 14:19 -!- ajonas_ [~ajonas@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Ping timeout: 248 seconds] 14:45 -!- ajonas [~ajonas@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-pr-reviews 14:57 -!- ajonas [~ajonas@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Ping timeout: 272 seconds] 15:18 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:40f6:40c9:a5d8:162e] has quit [Quit: Sleep mode] 16:11 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 248 seconds] 16:26 -!- ccdle12 [~ccdle12@175.45.39.66] has joined #bitcoin-core-pr-reviews 18:10 -!- ccdle12 [~ccdle12@175.45.39.66] has quit [Remote host closed the connection] 18:14 -!- ccdle12 [~ccdle12@175.45.39.66] has joined #bitcoin-core-pr-reviews 18:17 -!- ccdle12 [~ccdle12@175.45.39.66] has quit [Read error: No route to host] 18:17 -!- ccdle12 [~ccdle12@175.45.39.66] has joined #bitcoin-core-pr-reviews 18:22 -!- ccdle12 [~ccdle12@175.45.39.66] has quit [Ping timeout: 248 seconds] 18:23 -!- ccdle12 [~ccdle12@175.45.39.66] has joined #bitcoin-core-pr-reviews 18:28 -!- ccdle12 [~ccdle12@175.45.39.66] has quit [Ping timeout: 272 seconds] 18:31 -!- ccdle12 [~ccdle12@175.45.39.66] has joined #bitcoin-core-pr-reviews 18:35 -!- ccdle12 [~ccdle12@175.45.39.66] has quit [Read error: Connection reset by peer] 18:35 -!- ccdle12_ [~ccdle12@175.45.39.66] has joined #bitcoin-core-pr-reviews 18:38 -!- ccdle12 [~ccdle12@175.45.39.66] has joined #bitcoin-core-pr-reviews 18:40 -!- ccdle12_ [~ccdle12@175.45.39.66] has quit [Ping timeout: 272 seconds] 18:42 -!- ccdle12 [~ccdle12@175.45.39.66] has quit [Ping timeout: 248 seconds] 18:45 -!- ccdle12 [~ccdle12@175.45.39.66] has joined #bitcoin-core-pr-reviews 18:50 -!- ccdle12 [~ccdle12@175.45.39.66] has quit [Ping timeout: 272 seconds] 19:00 -!- ccdle12 [~ccdle12@175.45.39.66] has joined #bitcoin-core-pr-reviews 19:05 -!- ccdle12 [~ccdle12@175.45.39.66] has quit [Ping timeout: 246 seconds] 19:08 -!- ccdle12 [~ccdle12@175.45.39.66] has joined #bitcoin-core-pr-reviews 19:13 -!- ccdle12 [~ccdle12@175.45.39.66] has quit [Ping timeout: 258 seconds] 19:15 -!- ccdle12 [~ccdle12@175.45.39.66] has joined #bitcoin-core-pr-reviews 19:19 -!- ccdle12 [~ccdle12@175.45.39.66] has quit [Ping timeout: 248 seconds] 19:27 -!- ccdle12 [~ccdle12@175.45.39.66] has joined #bitcoin-core-pr-reviews 19:32 -!- ccdle12 [~ccdle12@175.45.39.66] has quit [Ping timeout: 268 seconds] 19:33 -!- ccdle12 [~ccdle12@175.45.39.66] has joined #bitcoin-core-pr-reviews 19:38 -!- ccdle12 [~ccdle12@175.45.39.66] has quit [Ping timeout: 248 seconds] 19:39 -!- ccdle12 [~ccdle12@175.45.39.66] has joined #bitcoin-core-pr-reviews 19:47 -!- ccdle12 [~ccdle12@175.45.39.66] has quit [Ping timeout: 248 seconds] 19:48 -!- ccdle12 [~ccdle12@175.45.39.66] has joined #bitcoin-core-pr-reviews 19:51 -!- ccdle12_ [~ccdle12@175.45.39.66] has joined #bitcoin-core-pr-reviews 19:53 -!- ccdle12 [~ccdle12@175.45.39.66] has quit [Ping timeout: 257 seconds] 19:56 -!- ccdle12_ [~ccdle12@175.45.39.66] has quit [Ping timeout: 258 seconds] 19:57 -!- ccdle12 [~ccdle12@175.45.39.66] has joined #bitcoin-core-pr-reviews 20:01 -!- ccdle12 [~ccdle12@175.45.39.66] has quit [Ping timeout: 248 seconds] 20:03 -!- ccdle12 [~ccdle12@175.45.39.66] has joined #bitcoin-core-pr-reviews 20:08 -!- ccdle12 [~ccdle12@175.45.39.66] has quit [Ping timeout: 268 seconds] 20:09 -!- ccdle12 [~ccdle12@175.45.39.66] has joined #bitcoin-core-pr-reviews 20:14 -!- ccdle12 [~ccdle12@175.45.39.66] has quit [Ping timeout: 246 seconds] 20:37 -!- ccdle12 [~ccdle12@175.45.39.66] has joined #bitcoin-core-pr-reviews 20:41 -!- ccdle12 [~ccdle12@175.45.39.66] has quit [Remote host closed the connection] 20:47 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 20:47 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 252 seconds] 20:51 -!- lukedashjr is now known as luke-jr 21:14 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 259 seconds] 21:19 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 21:22 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 21:22 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 21:25 -!- ccdle12 [~ccdle12@14-0-226-131.static.pccw-hkt.com] has joined #bitcoin-core-pr-reviews 21:40 -!- ccdle12 [~ccdle12@14-0-226-131.static.pccw-hkt.com] has quit [Remote host closed the connection] 22:17 -!- ravbarKomanda [ravbarKoma@gateway/vpn/protonvpn/ravbarkomanda] has joined #bitcoin-core-pr-reviews 23:00 -!- ravbarKomanda [ravbarKoma@gateway/vpn/protonvpn/ravbarkomanda] has quit [Quit: (null)] 23:26 -!- ccdle12 [~ccdle12@218.189.35.1] has joined #bitcoin-core-pr-reviews 23:49 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]