--- Day changed Thu Jul 11 2019 00:03 -!- hugohn [uid304114@gateway/web/irccloud.com/x-qkoynoqrbwyiacnt] has quit [Quit: Connection closed for inactivity] 00:47 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 01:08 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-pr-reviews 01:36 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 245 seconds] 01:41 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 01:42 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-pr-reviews 01:47 -!- jonas_ [~jonas@rrcs-184-74-240-154.nyc.biz.rr.com] has joined #bitcoin-core-pr-reviews 01:51 -!- jonas_ [~jonas@rrcs-184-74-240-154.nyc.biz.rr.com] has quit [Ping timeout: 245 seconds] 02:24 -!- jonatack [56dedeb5@abayonne-654-1-79-181.w86-222.abo.wanadoo.fr] has joined #bitcoin-core-pr-reviews 02:38 < jnewbery> elichai2: there have been quite a few discussions about wallet file regression tests in the #bitcoin-core-dev channel. 02:39 -!- jonatack [56dedeb5@abayonne-654-1-79-181.w86-222.abo.wanadoo.fr] has quit [Ping timeout: 260 seconds] 02:39 < jnewbery> I don't think we care too much about the wallet file hashes matching exactly, and it might not even be possible - perhaps write operations happen in different orders or the file is not deterministic for some other reason 02:41 < jnewbery> I think we're more interested in new versions of Bitcoin Core wallet being able to read old wallet files than the other way around (although we do want people to be able to downgrade their wallet with the same wallet file it's a much less common scenario) 02:42 < jnewbery> so way to test could be to check in wallets generated by old versions of bitcoind as binary blobs, or create some way in the python framework to build and modify wallet.dat files 02:43 < jnewbery> I've got a very basic tool in python that can read and dump wallet files: https://github.com/jnewbery/bitcointools/blob/master/bitcoin-wallet-tool.py which could be modified to also write 02:44 < jnewbery> If you're interested in discussing further, let's move to #bitcoin-core-dev, since the discussion may be interesting for others 02:49 -!- jonatack82 [56dedeb5@abayonne-654-1-79-181.w86-222.abo.wanadoo.fr] has joined #bitcoin-core-pr-reviews 02:50 -!- jonatack82 [56dedeb5@abayonne-654-1-79-181.w86-222.abo.wanadoo.fr] has left #bitcoin-core-pr-reviews [] 03:38 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 03:43 -!- hugohn [uid304114@gateway/web/irccloud.com/x-ksjtvdbwlcfkosum] has joined #bitcoin-core-pr-reviews 03:44 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:d9cb:4a81:4f9e:bbf9] has joined #bitcoin-core-pr-reviews 03:46 -!- jonas___ [~jonas@rrcs-184-74-240-154.nyc.biz.rr.com] has joined #bitcoin-core-pr-reviews 03:51 -!- jonas___ [~jonas@rrcs-184-74-240-154.nyc.biz.rr.com] has quit [Ping timeout: 248 seconds] 04:23 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:d9cb:4a81:4f9e:bbf9] has quit [Quit: Sleep mode] 04:39 -!- booyah [~bb@193.25.1.157] has quit [Ping timeout: 272 seconds] 05:08 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-pr-reviews 05:13 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-pr-reviews 05:37 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-pr-reviews 05:56 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:d9cb:4a81:4f9e:bbf9] has joined #bitcoin-core-pr-reviews 06:32 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-pr-reviews 06:47 -!- nijak [~nijak@cpe-66-108-32-173.nyc.res.rr.com] has joined #bitcoin-core-pr-reviews 06:47 -!- nijak_ [~nijak@2604:2000:12c1:c8ca:fd09:ffbe:be94:4ff] has quit [Ping timeout: 250 seconds] 07:08 -!- jonas___ [~jonas@rrcs-184-74-240-154.nyc.biz.rr.com] has joined #bitcoin-core-pr-reviews 07:13 -!- jonas___ [~jonas@rrcs-184-74-240-154.nyc.biz.rr.com] has quit [Ping timeout: 246 seconds] 07:25 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:d9cb:4a81:4f9e:bbf9] has quit [Quit: Sleep mode] 07:39 -!- jonas_ [~jonas@rrcs-184-74-240-154.nyc.biz.rr.com] has joined #bitcoin-core-pr-reviews 07:58 -!- jonas_ [~jonas@rrcs-184-74-240-154.nyc.biz.rr.com] has quit [Ping timeout: 246 seconds] 08:09 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 08:20 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-pr-reviews 08:22 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:d9cb:4a81:4f9e:bbf9] has joined #bitcoin-core-pr-reviews 08:29 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 08:30 -!- jonas___ [~jonas@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-pr-reviews 08:35 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-fpeqzqhseurfgimq] has joined #bitcoin-core-pr-reviews 08:36 -!- jonas___ [~jonas@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Ping timeout: 248 seconds] 08:39 -!- jonas___ [~jonas@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-pr-reviews 08:41 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:d9cb:4a81:4f9e:bbf9] has quit [Quit: Sleep mode] 08:54 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:d9cb:4a81:4f9e:bbf9] has joined #bitcoin-core-pr-reviews 09:00 -!- csknk [~csknk@unaffiliated/csknk] has joined #bitcoin-core-pr-reviews 09:08 -!- jonas___ [~jonas@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Ping timeout: 248 seconds] 09:14 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:d9cb:4a81:4f9e:bbf9] has quit [Quit: Sleep mode] 09:21 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:d9cb:4a81:4f9e:bbf9] has joined #bitcoin-core-pr-reviews 09:34 -!- jonas___ [~jonas@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-pr-reviews 09:41 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:d9cb:4a81:4f9e:bbf9] has quit [Quit: Sleep mode] 09:44 -!- michaelfolkson [~textual@host86-170-183-132.range86-170.btcentralplus.com] has joined #bitcoin-core-pr-reviews 09:45 -!- jonas___ [~jonas@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Ping timeout: 268 seconds] 10:12 -!- michaelfolkson [~textual@host86-170-183-132.range86-170.btcentralplus.com] has quit [Read error: Connection reset by peer] 10:16 -!- jonas_ [~jonas@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-pr-reviews 10:20 -!- jonas_ [~jonas@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Ping timeout: 258 seconds] 10:35 -!- jnewbery [~john@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Ping timeout: 245 seconds] 10:35 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 260 seconds] 10:49 -!- jonas_ [~jonas@rrcs-184-74-240-154.nyc.biz.rr.com] has joined #bitcoin-core-pr-reviews 10:52 -!- jnewbery [~john@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-pr-reviews 10:52 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-pr-reviews 10:54 -!- jonas___1 [~jonas@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-pr-reviews 10:56 -!- jonas_ [~jonas@rrcs-184-74-240-154.nyc.biz.rr.com] has quit [Ping timeout: 272 seconds] 11:29 -!- jonas___1 [~jonas@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Ping timeout: 244 seconds] 11:58 -!- jonas_ [~jonas@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-pr-reviews 12:05 -!- booyah [~bb@193.25.1.157] has quit [Remote host closed the connection] 12:06 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-pr-reviews 12:40 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection] 13:02 -!- jonas_ [~jonas@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Ping timeout: 246 seconds] 13:05 -!- jonas_ [~jonas@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-pr-reviews 13:41 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-pr-reviews 13:56 -!- nijak_ [~nijak@2604:2000:12c1:e144:8070:ab78:7ea4:739d] has joined #bitcoin-core-pr-reviews 13:56 -!- nijak [~nijak@cpe-66-108-32-173.nyc.res.rr.com] has quit [Ping timeout: 248 seconds] 14:00 -!- csknk [~csknk@unaffiliated/csknk] has quit [Quit: leaving] 14:00 -!- nijak [~nijak@2604:2000:12c1:c8ca:d14e:2919:3a3:caad] has joined #bitcoin-core-pr-reviews 14:01 -!- nijak_ [~nijak@2604:2000:12c1:e144:8070:ab78:7ea4:739d] has quit [Ping timeout: 252 seconds] 14:13 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 14:17 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-pr-reviews 14:18 -!- setpill [~setpill@unaffiliated/setpill] has quit [Client Quit] 14:19 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-pr-reviews 14:19 -!- setpill [~setpill@unaffiliated/setpill] has quit [Client Quit] 14:21 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-pr-reviews 14:28 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 14:47 -!- jonas_ [~jonas@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Ping timeout: 245 seconds] 15:10 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-pr-reviews 15:18 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 244 seconds] 15:29 -!- nijak_ [nijak@gateway/vpn/mullvad/nijak] has joined #bitcoin-core-pr-reviews 15:32 -!- nijak [~nijak@2604:2000:12c1:c8ca:d14e:2919:3a3:caad] has quit [Ping timeout: 252 seconds] 16:00 -!- jonas_ [~jonas@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-pr-reviews 16:06 -!- jonas_ [~jonas@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Ping timeout: 245 seconds] 16:10 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 17:01 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 18:42 -!- booyah [~bb@193.25.1.157] has quit [Remote host closed the connection] 18:43 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-pr-reviews 19:09 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-fpeqzqhseurfgimq] has quit [Quit: Connection closed for inactivity] 19:48 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 260 seconds] 19:49 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-pr-reviews 21:12 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-pr-reviews 21:17 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection] 23:58 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews