--- Day changed Tue Oct 29 2019 00:01 -!- jkczyz [~jkczyz@c-24-130-172-130.hsd1.ca.comcast.net] has quit [Ping timeout: 240 seconds] 01:41 -!- jonatack [~jon@2a01:e35:8aba:8220:6627:dad:d967:649d] has quit [Ping timeout: 245 seconds] 01:58 -!- jkczyz [~jkczyz@c-24-130-172-130.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 02:02 -!- jkczyz [~jkczyz@c-24-130-172-130.hsd1.ca.comcast.net] has quit [Ping timeout: 240 seconds] 02:38 -!- jonatack [~jon@213.152.162.15] has joined #bitcoin-core-pr-reviews 03:57 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Quit: ZNC 1.7.4 - https://znc.in] 03:58 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-pr-reviews 03:59 -!- jkczyz [~jkczyz@c-24-130-172-130.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 04:04 -!- jkczyz [~jkczyz@c-24-130-172-130.hsd1.ca.comcast.net] has quit [Ping timeout: 268 seconds] 05:26 -!- jonatack [~jon@213.152.162.15] has quit [Ping timeout: 240 seconds] 05:57 -!- diogosergio [~diogoserg@212.36.34.126] has joined #bitcoin-core-pr-reviews 05:59 -!- jkczyz [~jkczyz@c-24-130-172-130.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 06:04 -!- jkczyz [~jkczyz@c-24-130-172-130.hsd1.ca.comcast.net] has quit [Ping timeout: 240 seconds] 06:07 -!- davterra [~none@195.242.213.120] has joined #bitcoin-core-pr-reviews 06:45 -!- diogosergio [~diogoserg@212.36.34.126] has quit [Quit: leaving] 06:46 -!- openoms [~quassel@cpc115066-stok20-2-0-cust313.1-4.cable.virginm.net] has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.] 07:29 -!- openoms [~quassel@cpc115066-stok20-2-0-cust313.1-4.cable.virginm.net] has joined #bitcoin-core-pr-reviews 08:00 -!- jkczyz [~jkczyz@c-24-130-172-130.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 08:06 -!- jkczyz [~jkczyz@c-24-130-172-130.hsd1.ca.comcast.net] has quit [Ping timeout: 265 seconds] 08:24 -!- jkczyz [~jkczyz@c-24-130-172-130.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 08:29 -!- jkczyz [~jkczyz@c-24-130-172-130.hsd1.ca.comcast.net] has quit [Ping timeout: 264 seconds] 08:31 -!- instagibbs [~instagibb@pool-100-15-121-126.washdc.fios.verizon.net] has quit [Read error: Connection reset by peer] 08:33 -!- instagibbs [~instagibb@pool-100-15-121-126.washdc.fios.verizon.net] has joined #bitcoin-core-pr-reviews 08:51 -!- jonatack [~jon@2a01:e35:8aba:8220:6627:dad:d967:649d] has joined #bitcoin-core-pr-reviews 09:07 < jonatack> PR club people, FWIW I really liked/took to heart this comment by ryanofsky yesterday from last week's PR, in case you didn't see it https://github.com/bitcoin/bitcoin/pull/15934#issuecomment-547095024 09:25 < instagibbs> yes, often I don't have a chance to really dive into a PR, but have enough time(20 minutes or so) to just read the code, and ask when something confuses me(as a hint to improve the code structure or comments) 09:29 -!- jkczyz [~jkczyz@135.84.132.56] has joined #bitcoin-core-pr-reviews 09:35 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-pr-reviews 09:40 -!- jkczyz [~jkczyz@135.84.132.56] has quit [Ping timeout: 250 seconds] 09:44 -!- jkczyz [~jkczyz@135.84.132.56] has joined #bitcoin-core-pr-reviews 11:23 -!- jkczyz [~jkczyz@135.84.132.56] has quit [Ping timeout: 240 seconds] 11:26 -!- jkczyz [~jkczyz@135.84.132.56] has joined #bitcoin-core-pr-reviews 11:43 -!- jkczyz [~jkczyz@135.84.132.56] has quit [Ping timeout: 240 seconds] 11:52 -!- jkczyz [~jkczyz@135.84.132.56] has joined #bitcoin-core-pr-reviews 12:23 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Quit: ZNC 1.7.4 - https://znc.in] 12:24 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-pr-reviews 12:44 -!- jkczyz [~jkczyz@135.84.132.56] has quit [Ping timeout: 240 seconds] 13:11 -!- jkczyz [~jkczyz@135.84.132.56] has joined #bitcoin-core-pr-reviews 13:14 -!- davterra [~none@195.242.213.120] has quit [Ping timeout: 265 seconds] 13:14 -!- davterra [~none@195.242.213.120] has joined #bitcoin-core-pr-reviews 13:26 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 13:35 -!- jkczyz [~jkczyz@135.84.132.56] has quit [Ping timeout: 268 seconds] 13:47 -!- jkczyz [~jkczyz@135.84.132.56] has joined #bitcoin-core-pr-reviews 14:09 -!- pinheadmz [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Quit: pinheadmz] 14:57 -!- pinheadmz [~matthewzi@89.187.178.28] has joined #bitcoin-core-pr-reviews 15:02 -!- pinheadmz [~matthewzi@89.187.178.28] has quit [Client Quit] 15:10 -!- Moller40 [~mr@82.103.128.151] has joined #bitcoin-core-pr-reviews 15:12 -!- Moller40 [~mr@82.103.128.151] has quit [Client Quit] 15:19 -!- pinheadmz [~matthewzi@89.187.178.28] has joined #bitcoin-core-pr-reviews 15:30 -!- pinheadmz [~matthewzi@89.187.178.28] has quit [Quit: pinheadmz] 15:47 -!- pinheadmz [~matthewzi@89.187.178.28] has joined #bitcoin-core-pr-reviews 16:14 -!- openoms [~quassel@cpc115066-stok20-2-0-cust313.1-4.cable.virginm.net] has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.] 16:15 -!- openoms [~quassel@cpc115066-stok20-2-0-cust313.1-4.cable.virginm.net] has joined #bitcoin-core-pr-reviews 16:23 -!- pinheadmz [~matthewzi@89.187.178.28] has quit [Quit: pinheadmz] 16:45 -!- davterra [~none@195.242.213.120] has quit [Remote host closed the connection] 16:48 -!- openoms [~quassel@cpc115066-stok20-2-0-cust313.1-4.cable.virginm.net] has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.] 16:48 -!- openoms [~quassel@cpc115066-stok20-2-0-cust313.1-4.cable.virginm.net] has joined #bitcoin-core-pr-reviews 16:49 -!- pinheadmz [~matthewzi@89.187.178.28] has joined #bitcoin-core-pr-reviews 16:52 -!- jkczyz [~jkczyz@135.84.132.56] has quit [Ping timeout: 265 seconds] 16:52 -!- jkczyz [~jkczyz@135.84.132.56] has joined #bitcoin-core-pr-reviews 16:53 -!- pinheadmz [~matthewzi@89.187.178.28] has quit [Client Quit] 16:54 -!- jkczyz [~jkczyz@135.84.132.56] has quit [Client Quit] 16:55 -!- jkczyz [~jkczyz@135.84.132.250] has joined #bitcoin-core-pr-reviews 16:57 -!- pinheadmz [~matthewzi@89.187.178.28] has joined #bitcoin-core-pr-reviews 17:15 -!- openoms [~quassel@cpc115066-stok20-2-0-cust313.1-4.cable.virginm.net] has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.] 17:16 -!- openoms [~quassel@cpc115066-stok20-2-0-cust313.1-4.cable.virginm.net] has joined #bitcoin-core-pr-reviews 17:43 -!- pinheadmz [~matthewzi@89.187.178.28] has quit [Quit: pinheadmz] 18:37 -!- pinheadmz [~matthewzi@89.187.178.28] has joined #bitcoin-core-pr-reviews 20:05 -!- emilengler_ [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-pr-reviews 20:08 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Ping timeout: 240 seconds] 20:20 -!- felixfoertsch23 [~felixfoer@i6DFA67F9.versanet.de] has joined #bitcoin-core-pr-reviews 20:21 -!- felixfoertsch [~felixfoer@92.117.33.81] has quit [Ping timeout: 250 seconds] 21:19 -!- soju [~soju@ip68-228-80-222.oc.oc.cox.net] has joined #bitcoin-core-pr-reviews