--- Day changed Sun Nov 10 2019 00:55 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-pr-reviews 01:24 -!- michaelfolkson [~textual@host81-153-125-21.range81-153.btcentralplus.com] has joined #bitcoin-core-pr-reviews 01:30 -!- michaelfolkson [~textual@host81-153-125-21.range81-153.btcentralplus.com] has quit [Quit: Sleep mode] 01:36 -!- openoms [~quassel@cpc115066-stok20-2-0-cust313.1-4.cable.virginm.net] has joined #bitcoin-core-pr-reviews 01:48 -!- openoms [~quassel@cpc115066-stok20-2-0-cust313.1-4.cable.virginm.net] has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.] 01:49 -!- openoms [~quassel@cpc115066-stok20-2-0-cust313.1-4.cable.virginm.net] has joined #bitcoin-core-pr-reviews 02:09 -!- michaelfolkson [~textual@2a00:23c7:688a:cc00:8ddb:18ad:8c57:36aa] has joined #bitcoin-core-pr-reviews 02:21 -!- openoms [~quassel@cpc115066-stok20-2-0-cust313.1-4.cable.virginm.net] has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.] 02:22 -!- openoms [~quassel@cpc115066-stok20-2-0-cust313.1-4.cable.virginm.net] has joined #bitcoin-core-pr-reviews 02:23 -!- michaelfolkson [~textual@2a00:23c7:688a:cc00:8ddb:18ad:8c57:36aa] has quit [Quit: Sleep mode] 02:38 -!- michaelfolkson [~textual@2a00:23c7:688a:cc00:8ddb:18ad:8c57:36aa] has joined #bitcoin-core-pr-reviews 02:57 -!- michaelfolkson [~textual@2a00:23c7:688a:cc00:8ddb:18ad:8c57:36aa] has quit [Quit: Sleep mode] 02:59 -!- hebasto [~hebasto@95.164.65.194] has quit [Quit: ZNC 1.6.6+deb1ubuntu0.2 - http://znc.in] 02:59 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-pr-reviews 03:06 -!- hebasto [~hebasto@95.164.65.194] has quit [Quit: ZNC 1.6.6+deb1ubuntu0.2 - http://znc.in] 03:08 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-pr-reviews 03:50 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Quit: ZNC 1.7.4 - https://znc.in] 03:50 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-pr-reviews 03:59 -!- nobody123 [~nobody123@139.28.219.102] has joined #bitcoin-core-pr-reviews 04:00 < nobody123> Hello, is this channel only available for questions on Wednesday ? 04:04 < molz> nobody123, i think you can ask questions anytime and if someone is here they might be able to answer your questions 04:13 < nobody123> to see the latest pr on my machine, I have to clone the forked repository of the contributor, or is the a better way? 04:14 < wumpus> github conveniently exposes the prs as branches on the upstream repository, as pull/N/head (contributor branch), and pull/N/merge (merged into master) 04:14 < wumpus> e.g. git fetch origin pull/17270/head && git checkout FETCH_HEAD 04:15 < nobody123> thanks wumpus 04:19 -!- diogosergio [~diogoserg@176.24.23.243] has joined #bitcoin-core-pr-reviews 04:37 < Talkless> wumpus: cool tip, thanks! 04:41 < wumpus> you're welcome! it's surprising how little known this is; let me see if github documents this officially anywhere. ah yes https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/checking-out-pull-requests-locally 04:44 < wumpus> but it's pretty hidden I guess 04:58 < nobody123> wumpus, I understand that you pulled the pr to your local machine but why would you want to merge it, is checkout not the better way or am I missing a crucial point 05:09 < wumpus> there's two ways to test a PR: test the contributor's branch directly, or test it merged on top of master; both are useful, and facilitated this way. testing the merged commit is useful to see if anything that has been merged into master *since* maybe breaks the changes 05:16 < wumpus> (so /pull/N/merge is the same as if you would check out master then merge pull/N/head into it) 05:17 < wumpus> AFAIK it's only there if a clean merge is possible in the first place 05:19 < nobody123> good to know, sounds that merging it is far better than testing on the contributor branch because eventually you have to test it on the latest version 05:21 < wumpus> right, I think so too 05:25 < nobody123> the latest pr you discussed on wednesday, can somebody confirm that the first commit to this topic was faf7cc8a4275270f3f54dfa9e2cfb6e336e45365, I want to start from the beginning and I am not sure whether I am missing a commit? 05:26 < nobody123> I checked out the contributor branch and used git log -p master.. 05:29 < nobody123> sry for these beginner questions 05:34 -!- michaelfolkson [~textual@2a00:23c7:688a:cc00:8ddb:18ad:8c57:36aa] has joined #bitcoin-core-pr-reviews 05:58 -!- michaelfolkson [~textual@2a00:23c7:688a:cc00:8ddb:18ad:8c57:36aa] has quit [Quit: Sleep mode] 05:59 -!- openoms [~quassel@cpc115066-stok20-2-0-cust313.1-4.cable.virginm.net] has quit [Ping timeout: 276 seconds] 06:00 -!- openoms [~quassel@cpc115066-stok20-2-0-cust313.1-4.cable.virginm.net] has joined #bitcoin-core-pr-reviews 06:09 -!- michaelfolkson [~textual@2a00:23c7:688a:cc00:8ddb:18ad:8c57:36aa] has joined #bitcoin-core-pr-reviews 06:24 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 06:25 -!- shesek [~shesek@185.3.145.80] has joined #bitcoin-core-pr-reviews 06:25 -!- shesek [~shesek@185.3.145.80] has quit [Changing host] 06:25 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-pr-reviews 06:30 < jonatack> nobody123: Talkless: molz: be sure to check out the tips in doc/productivity.md in the repo. Also, I've been compiling info from the PR review club here for the past six months: https://github.com/jonatack/bitcoin-development/blob/master/how-to-review-bitcoin-core-prs.md 06:30 < Talkless> thanks jonatack 06:31 < jonatack> Talkless: i learned some c++ tips from your recent reviews, looking forward to learning more 06:33 < Talkless> jonatack: wow, I'm glad it helps at least that :) 06:38 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-pr-reviews 06:42 < jonatack> TIL i learned about the GH feature wumpus mentioned. I've been using git refspecs as described in doc/productivity.md. Will add that info to the "How to Review PRs" doc 06:56 < nobody123> jonatack your guide is very useful ;) 06:59 < jonatack> nobody123: thanks ;) there are other docs in that repo that might be useful too, e.g. how to build, technical notes, how to open a PR, irc channels and meetings, etc. I only began a few months ago so this is all fresh :p 08:27 -!- michaelfolkson [~textual@2a00:23c7:688a:cc00:8ddb:18ad:8c57:36aa] has quit [Quit: Sleep mode] 08:42 -!- fox2p [~fox2p@cpe-66-108-32-173.nyc.res.rr.com] has joined #bitcoin-core-pr-reviews 08:43 -!- fox2p_ [~fox2p@82.102.24.187] has quit [Ping timeout: 252 seconds] 09:10 -!- openoms [~quassel@cpc115066-stok20-2-0-cust313.1-4.cable.virginm.net] has quit [Quit: No Ping reply in 180 seconds.] 09:10 -!- openoms [~quassel@cpc115066-stok20-2-0-cust313.1-4.cable.virginm.net] has joined #bitcoin-core-pr-reviews 10:29 -!- fox2p_ [fox2p@gateway/vpn/mullvad/fox2p] has joined #bitcoin-core-pr-reviews 10:31 -!- fox2p [~fox2p@cpe-66-108-32-173.nyc.res.rr.com] has quit [Ping timeout: 268 seconds] 11:24 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 11:31 -!- diogosergio [~diogoserg@176.24.23.243] has quit [Ping timeout: 240 seconds] 12:35 -!- diogosergio [~diogoserg@176.24.23.243] has joined #bitcoin-core-pr-reviews 13:02 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:c4e0:5e7b:afa3:c47f] has joined #bitcoin-core-pr-reviews 13:14 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:c4e0:5e7b:afa3:c47f] has quit [Quit: Sleep mode] 13:31 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Remote host closed the connection] 13:42 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:c4e0:5e7b:afa3:c47f] has joined #bitcoin-core-pr-reviews 13:51 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:c4e0:5e7b:afa3:c47f] has quit [Quit: Sleep mode] 14:01 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:c4e0:5e7b:afa3:c47f] has joined #bitcoin-core-pr-reviews 14:21 < molz> jonatack, oh cool, thanks for the tips 14:28 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:c4e0:5e7b:afa3:c47f] has quit [Quit: Sleep mode] 14:39 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:c4e0:5e7b:afa3:c47f] has joined #bitcoin-core-pr-reviews 14:44 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:c4e0:5e7b:afa3:c47f] has quit [Quit: Sleep mode] 14:58 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:c4e0:5e7b:afa3:c47f] has joined #bitcoin-core-pr-reviews 15:23 < molz> this is how i built the PR 15845 on WSL for windows if anyone is interested: https://privatebin.net/?74dc8371aba450bc#FtnSEq19UoK7NqzatQ5dywSfbLFDpaaVgMWk2WV8GhgV 15:50 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 265 seconds] 15:58 -!- pinheadmz [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Quit: pinheadmz] 16:11 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:c4e0:5e7b:afa3:c47f] has quit [Quit: Sleep mode] 16:29 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:c4e0:5e7b:afa3:c47f] has joined #bitcoin-core-pr-reviews 16:41 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:c4e0:5e7b:afa3:c47f] has quit [Quit: Sleep mode] 17:00 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:c4e0:5e7b:afa3:c47f] has joined #bitcoin-core-pr-reviews 17:02 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:c4e0:5e7b:afa3:c47f] has quit [Client Quit] 17:08 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:c4e0:5e7b:afa3:c47f] has joined #bitcoin-core-pr-reviews 17:15 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:c4e0:5e7b:afa3:c47f] has quit [Quit: Sleep mode] 19:09 -!- felixfoertsch23 [~felixfoer@2001:16b8:50b8:c500:81cb:f255:aa67:93f4] has joined #bitcoin-core-pr-reviews 19:09 -!- felixfoertsch [~felixfoer@2001:16b8:500b:e600:81cb:f255:aa67:93f4] has quit [Ping timeout: 246 seconds] 19:28 -!- pinheadmz [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-pr-reviews 20:57 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has quit [Remote host closed the connection] 21:12 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has joined #bitcoin-core-pr-reviews 21:18 -!- felixfoertsch23 [~felixfoer@2001:16b8:50b8:c500:81cb:f255:aa67:93f4] has quit [Quit: ZNC 1.7.3 - https://znc.in] 21:18 -!- felixfoertsch [~felixfoer@2001:16b8:50b8:c500:94cf:6a91:727e:bed] has joined #bitcoin-core-pr-reviews 22:41 -!- openoms [~quassel@cpc115066-stok20-2-0-cust313.1-4.cable.virginm.net] has quit [Quit: No Ping reply in 180 seconds.] 22:41 -!- openoms [~quassel@cpc115066-stok20-2-0-cust313.1-4.cable.virginm.net] has joined #bitcoin-core-pr-reviews 23:23 -!- openoms [~quassel@cpc115066-stok20-2-0-cust313.1-4.cable.virginm.net] has quit [Ping timeout: 268 seconds] 23:59 < jonatack> molz: np