--- Day changed Thu Jan 09 2020 00:18 -!- benk10 [8de2a259@141.226.162.89] has joined #bitcoin-core-pr-reviews 00:58 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-pr-reviews 01:37 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 01:40 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 01:48 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 248 seconds] 02:01 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Quit: This computer has gone to sleep] 02:01 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-pr-reviews 02:08 -!- slivera [slivera@gateway/vpn/privateinternetaccess/slivera] has quit [Remote host closed the connection] 02:29 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Quit: This computer has gone to sleep] 02:32 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-pr-reviews 02:42 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Quit: This computer has gone to sleep] 03:03 -!- Evie72Konopelski [~Evie72Kon@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-pr-reviews 03:07 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-pr-reviews 03:09 -!- Evie72Konopelski [~Evie72Kon@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 260 seconds] 03:32 -!- jonatack [~jon@atoulouse-656-1-807-188.w86-221.abo.wanadoo.fr] has joined #bitcoin-core-pr-reviews 03:41 -!- jonatack [~jon@atoulouse-656-1-807-188.w86-221.abo.wanadoo.fr] has quit [Ping timeout: 268 seconds] 03:42 -!- jonatack [~jon@134.19.179.179] has joined #bitcoin-core-pr-reviews 03:53 -!- benk10 [8de2a259@141.226.162.89] has quit [Remote host closed the connection] 04:55 -!- jonatack [~jon@134.19.179.179] has quit [Ping timeout: 260 seconds] 06:04 -!- takinbo [~takinbo@unaffiliated/takinbo] has quit [Quit: takinbo] 06:06 -!- takinbo [~takinbo@2a01:4f8:160:60aa::2] has joined #bitcoin-core-pr-reviews 06:06 -!- takinbo [~takinbo@2a01:4f8:160:60aa::2] has quit [Changing host] 06:06 -!- takinbo [~takinbo@unaffiliated/takinbo] has joined #bitcoin-core-pr-reviews 06:08 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-pr-reviews 06:21 -!- benk10 [8de2a259@141.226.162.89] has joined #bitcoin-core-pr-reviews 06:35 -!- benk10 [8de2a259@141.226.162.89] has quit [Remote host closed the connection] 06:42 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-pr-reviews 07:19 -!- hebasto_ [~hebasto@95.164.65.194] has joined #bitcoin-core-pr-reviews 07:19 -!- hebasto [~hebasto@95.164.65.194] has quit [Read error: Connection reset by peer] 07:30 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Quit: This computer has gone to sleep] 07:41 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 07:43 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-pr-reviews 07:53 -!- hebasto_ [~hebasto@95.164.65.194] has quit [Quit: ZNC 1.6.6+deb1ubuntu0.2 - http://znc.in] 07:55 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-pr-reviews 07:59 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 08:02 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:a430:fcab:6567:f900] has joined #bitcoin-core-pr-reviews 08:03 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-pr-reviews 08:11 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews 08:12 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 240 seconds] 08:18 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:a430:fcab:6567:f900] has quit [Quit: Sleep mode] 08:22 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews 08:24 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 240 seconds] 08:24 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:a430:fcab:6567:f900] has joined #bitcoin-core-pr-reviews 08:31 < instagibbs> I can't actually get the fuzztester to "Do anything". The readme focuses on setting up but doesn't actually give an example with expected output. 08:31 < instagibbs> ./test/fuzz/test_runner.py ${DIR_FUZZ_IN} 08:31 -!- pinheadmz [~matthewzi@wsip-98-173-108-220.lv.lv.cox.net] has joined #bitcoin-core-pr-reviews 08:32 < instagibbs> results in it just printing out a bunch of names in arrays "Fuzz targets found" and "Fuzz targets selected" then exiting 08:33 < instagibbs> I'll gladly improve the readme, if I just knew what the heck is supposed to be happening :) 08:34 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 240 seconds] 08:37 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-pr-reviews 08:50 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 08:51 -!- shesek [~shesek@5.22.135.198] has joined #bitcoin-core-pr-reviews 08:51 -!- shesek [~shesek@5.22.135.198] has quit [Changing host] 08:51 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-pr-reviews 09:08 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews 09:11 -!- avril [wha@unaffiliated/avril] has quit [Ping timeout: 260 seconds] 09:23 -!- avril [wha@cute.b.oy.hu] has joined #bitcoin-core-pr-reviews 09:23 -!- avril [wha@cute.b.oy.hu] has quit [Changing host] 09:23 -!- avril [wha@unaffiliated/avril] has joined #bitcoin-core-pr-reviews 09:50 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:a430:fcab:6567:f900] has quit [Quit: Sleep mode] 09:57 -!- michaelfolkson [~textual@host86-133-235-133.range86-133.btcentralplus.com] has joined #bitcoin-core-pr-reviews 10:38 < jonatack> instagibbs: I see output like https://github.com/bitcoin/bitcoin/pull/17229#pullrequestreview-333863703 10:39 < jonatack> or https://github.com/bitcoin/bitcoin/pull/17777#pullrequestreview-336198693 10:39 < jonatack> and it runs indefinitely until halted with C-c or C-d 10:40 < jonatack> I'm not sure what a fuzz failure looks like yet, it just runs and runs :p 10:41 < instagibbs> hmmmmm 10:41 < instagibbs> mine definitely just stops 10:41 < instagibbs> with nothing useful 10:46 < instagibbs> jonatack, it's possible the readme is super poorly written and made me think it would run something, when all its doing is telling me what tests are available and exiting 10:48 < jonatack> yup definitely, improving fuzz.md has been on my todo list since last spring 10:49 < jonatack> just stopping seems wrong 10:50 < instagibbs> ok, ive upgraded to a subprocess command error message :) 10:50 < jonatack> i asked practicalswift when reviewing one of his fuzz prs and he confirmed that it just runs ad infinitum until halted 10:50 < instagibbs> somehow 10:50 < instagibbs> if i run specific ones like you did in that PR it works fwiw 10:50 < instagibbs> it's the python script the readme has that isn't working for me 10:52 -!- michaelfolkson [~textual@host86-133-235-133.range86-133.btcentralplus.com] has quit [Quit: Sleep mode] 10:52 < jonatack> hm, i recall the readme not working for me either, only following per-pr practicalswift instructions did 11:00 < instagibbs> actually scratch that, i actually broke it more, back to "nothing" for the `./test/fuzz/test_runner.py` incantation. If I specify a particular target, it says so and exits even faster 11:00 < instagibbs> :thinking: 11:01 < instagibbs> anyways I can at least run them one at a time thanks to your link :) 12:02 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 12:37 < jonatack> instagibbs: hmmm i retried that test runner script and am seeing the same as what you report 12:37 < jonatack> list of targets found and selected with: ./test/fuzz/test_runner.py ../qa-assets/fuzz_seed_corpus hex 12:38 < jonatack> or when no target supplied, then: subprocess.CalledProcessError: Command '['/home/jon/projects/bitcoin/bitcoin/src/test/fuzz/bech32', '-runs=1', '-detect_leaks=0', '../qa-assets/fuzz_seed_corpus/bech32']' returned non-zero exit status 1. 12:50 < instagibbs> make sure the path is right, i was getting no file found error, once i fixed the path it did nothing again 12:51 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Quit: This computer has gone to sleep] 12:56 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-pr-reviews 13:29 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Quit: Leaving] 13:37 -!- pinheadmz [~matthewzi@wsip-98-173-108-220.lv.lv.cox.net] has quit [Quit: pinheadmz] 13:37 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 13:40 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 13:53 -!- felixfoertsch23 [~felixfoer@i6DFA6402.versanet.de] has quit [Ping timeout: 268 seconds] 13:56 -!- felixfoertsch [~felixfoer@2001:16b8:509d:e000:51cc:ef0a:ff5e:249a] has joined #bitcoin-core-pr-reviews 14:29 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 14:40 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:a430:fcab:6567:f900] has joined #bitcoin-core-pr-reviews 14:47 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:a430:fcab:6567:f900] has quit [Quit: Sleep mode] 14:54 -!- pinheadmz [~matthewzi@ip68-96-198-25.lv.lv.cox.net] has joined #bitcoin-core-pr-reviews 15:01 -!- slivera [slivera@gateway/vpn/privateinternetaccess/slivera] has joined #bitcoin-core-pr-reviews 15:08 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 265 seconds] 15:29 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 240 seconds] 18:26 -!- achow101 [~achow101@unaffiliated/achow101] has quit [Quit: ZNC 1.7.4+deb0+bionic0 - https://znc.in] 19:08 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 19:09 -!- shesek [~shesek@5.22.135.198] has joined #bitcoin-core-pr-reviews 19:09 -!- shesek [~shesek@5.22.135.198] has quit [Changing host] 19:09 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-pr-reviews 19:16 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 248 seconds] 19:20 -!- jonatack [~jon@88.124.242.136] has joined #bitcoin-core-pr-reviews 19:34 -!- felixfoertsch23 [~felixfoer@92.117.32.86] has joined #bitcoin-core-pr-reviews 19:35 -!- felixfoertsch [~felixfoer@2001:16b8:509d:e000:51cc:ef0a:ff5e:249a] has quit [Ping timeout: 260 seconds] 19:40 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Quit: This computer has gone to sleep] 19:57 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-pr-reviews 20:00 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection] 20:00 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 20:00 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Client Quit] 20:03 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-pr-reviews 20:20 -!- pinheadmz [~matthewzi@ip68-96-198-25.lv.lv.cox.net] has quit [Quit: pinheadmz] 20:39 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Quit: This computer has gone to sleep] 20:40 -!- pinheadmz [~matthewzi@ip68-96-198-25.lv.lv.cox.net] has joined #bitcoin-core-pr-reviews 21:23 -!- achow101 [~achow101@unaffiliated/achow101] has joined #bitcoin-core-pr-reviews 21:55 -!- slivera [slivera@gateway/vpn/privateinternetaccess/slivera] has quit [Remote host closed the connection] 21:56 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection] 21:56 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 23:38 -!- pinheadmz [~matthewzi@ip68-96-198-25.lv.lv.cox.net] has quit [Quit: pinheadmz]