--- Day changed Thu Jan 16 2020 00:00 -!- molly [~molly@unaffiliated/molly] has quit [Ping timeout: 268 seconds] 00:13 -!- amiti [sid373138@gateway/web/irccloud.com/x-gpgwtttcmjqraxjw] has joined #bitcoin-core-pr-reviews 00:20 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-pr-reviews 00:20 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds] 01:34 -!- vasild_ is now known as vasild 01:41 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 01:51 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-pr-reviews 01:53 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 01:53 < jonatack> raj_: saaame, this fuzz test is less than 1 exec/sec for me when it slows down after a few thousand iterations 01:54 < jonatack> i left it running overnight, it's at 20k iterations, and still hasn't found the CVE 01:55 < jonatack> (i removed the bad-txns-duplicate-inputs conditional in src/consensus/tx_check.cpp) 01:56 < jonatack> fwiw, removing that now causes one unit test (transaction_tests/tx_invalid) to fail 01:59 < jonatack> and several functional tests 02:09 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Quit: jonatack] 02:20 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-pr-reviews 02:52 < fjahr> I was having connection problem around halfway last night and could not re-connect until 1h ago. I read the notes, if I am missing something between the end of notes and now that might be helpful please let me know. I will try to build the fuzz tests with AFL on macOS today. 02:54 -!- illlicit_ [uid109953@gateway/web/irccloud.com/x-exnbafpamoycrmdo] has joined #bitcoin-core-pr-reviews 02:54 < fjahr> One question I was waiting to ask at the end of the meeting is: It appears that the fuzzers can't be built with `--enable-debug`. Is that just an implementation issue on core side or has something to do with the fuzz libraries? 02:54 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 245 seconds] 03:03 -!- Hayden84Dooley [~Hayden84D@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-pr-reviews 03:09 -!- Hayden84Dooley [~Hayden84D@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 268 seconds] 03:56 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-pr-reviews 04:14 -!- jonatack [~jon@37.173.53.30] has joined #bitcoin-core-pr-reviews 04:36 -!- slivera_ [slivera@gateway/vpn/privateinternetaccess/slivera] has quit [Remote host closed the connection] 05:11 -!- diogosergio [~diogoserg@212.36.34.126] has joined #bitcoin-core-pr-reviews 05:17 -!- jonatack [~jon@37.173.53.30] has quit [Ping timeout: 258 seconds] 05:38 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-pr-reviews 05:38 -!- diogosergio [~diogoserg@212.36.34.126] has quit [Quit: Lost terminal] 05:52 -!- dr-orlovsky [~dr-orlovs@194.230.155.171] has quit [Ping timeout: 268 seconds] 05:57 -!- dr-orlovsky [~dr-orlovs@194.230.155.171] has joined #bitcoin-core-pr-reviews 07:33 -!- molly [~molly@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 07:36 -!- molz_ [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 08:55 < fjahr> I was able to fuzzers to run with AFL earlier today. I opened a PR adding hints I came across to fuzzing.md, would be great if macOS users could test/review. Thanks! https://github.com/bitcoin/bitcoin/pull/17942 08:56 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-pr-reviews 09:04 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 09:05 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-pr-reviews 09:08 -!- molz_ [~molly@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 09:10 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 09:12 < raj_> fjahr: Same. got compilation error for with --enable-debug for fuzzing. 09:12 -!- molly [~molly@unaffiliated/molly] has quit [Ping timeout: 258 seconds] 09:49 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 260 seconds] 09:59 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 10:14 < brikk> fjahr: thanks for the instructions, I'll try it out in a bit 10:48 -!- molz_ [~molly@unaffiliated/molly] has quit [Read error: Connection reset by peer] 10:58 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-pr-reviews 11:35 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Quit: Leaving] 11:45 -!- slivera [slivera@gateway/vpn/privateinternetaccess/slivera] has joined #bitcoin-core-pr-reviews 12:05 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 12:26 < brikk> fjahr: I was able to get the AFL setup and running with your instructions on my first attempt at fuzzing ever, so I would say your instructions are great! I added a few comments on some steps where I stumbled a bit. 12:27 < fjahr> brikk: that's awesome! Thanks! 13:00 < jonatack> brikk: fjahr: nice! 13:37 -!- slivera_ [slivera@gateway/vpn/privateinternetaccess/slivera] has joined #bitcoin-core-pr-reviews 13:40 -!- slivera [slivera@gateway/vpn/privateinternetaccess/slivera] has quit [Ping timeout: 265 seconds] 13:40 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 13:42 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 14:28 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 268 seconds] 15:27 -!- pinheadmz [~matthewzi@45.83.89.180] has quit [Read error: Connection reset by peer] 16:22 < fanquake> Can someone post their compile log (gist) from when they experienced the compilation issues? I don't understand why adding a second -isysroot would solve that, and would like to debug. 16:22 < fanquake> In any case we shouldn't be hard coding a path into Xcode.app. Will leave some comments on the PR. 16:32 -!- tinova [~tinova@lemoncat.org] has quit [Read error: Connection reset by peer] 16:32 -!- tinova [~tinova@lemoncat.org] has joined #bitcoin-core-pr-reviews 17:26 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 18:31 -!- pinheadmz [~matthewzi@45.83.89.180] has joined #bitcoin-core-pr-reviews 18:55 -!- pinheadmz [~matthewzi@45.83.89.180] has quit [Quit: pinheadmz] 19:49 -!- pinheadmz [~matthewzi@45.83.89.180] has joined #bitcoin-core-pr-reviews 20:01 -!- felixfoertsch [~felixfoer@2001:16b8:5032:f00:b59e:afaa:3ca7:858d] has joined #bitcoin-core-pr-reviews 20:03 -!- felixfoertsch23 [~felixfoer@92.117.62.201] has quit [Ping timeout: 260 seconds] 21:44 < raj_> A noob question: how should i debug(step by step) any specific cpp file in core? I compiled with `--enable-debug`, but couldn't locate binary files for any specific cpp. The build gives me final bitcoind binary in src. Do i need to debug the bitcoind binary? Whats the right way to do this? Any reference i can follow? 21:46 < raj_> fanquake: are you talking about the compilation issue with `enable-debug` while fuzzing? 22:04 < fanquake> raj_ I'm talking about whichever issue people are seeing with Boost that is apparently solved by passing -isysroot in CXXFLAGS 22:53 -!- slivera_ [slivera@gateway/vpn/privateinternetaccess/slivera] has quit [Remote host closed the connection] 22:53 < raj_> fanquake: okay I haven't encountered that yet. 23:13 -!- ariard_ [~ariard@167.99.46.220] has joined #bitcoin-core-pr-reviews 23:16 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Quit: ZNC 1.7.5 - https://znc.in] 23:17 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-pr-reviews 23:18 -!- Netsplit *.net <-> *.split quits: jimpo, tinova, ariard, Nebraskka 23:18 -!- Nebraskka_ [~Nebraskka@178.62.130.190] has joined #bitcoin-core-pr-reviews 23:18 -!- Nebraskka_ [~Nebraskka@178.62.130.190] has quit [Remote host closed the connection] 23:20 -!- Netsplit over, joins: Nebraskka 23:30 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 23:43 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Quit: ZNC 1.7.5 - https://znc.in] 23:44 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-pr-reviews