--- Day changed Fri Jan 17 2020
00:05 -!- tinova [~tinova@lemoncat.org] has joined #bitcoin-core-pr-reviews     
00:05 -!- jimpo [~jimpo@ec2-13-57-39-52.us-west-1.compute.amazonaws.com] has joined #bitcoin-core-pr-reviews     
01:18 < jonatack> raj_: fjahr wrote a debugging gist here https://gist.github.com/fjahr/2cd23ad743a2ddfd4eed957274beca0f
01:19 < jonatack> and a youtube video https://youtu.be/6aPSCDAiqVI
01:20 < jonatack> i have some high-level suggestions here which are partly from aj towns review club comments: https://github.com/jonatack/bitcoin-development/blob/master/how-to-review-bitcoin-core-prs.md#if-youre-not-sure-where-to-start
01:22 < jonatack> and a collection of debugging notes for myself here: https://github.com/jonatack/bitcoin-development/blob/master/notes.txt
01:23 < jonatack> (don't forget doc/developer-notes.md and doc/productivity.md in the bitcoin core repository)
01:41 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]     
01:43 < jonatack> and https://www.twitch.tv/achow101 to watch achow101 coding live on bitcoin core. the best parts imo are the debugging.
01:47 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews     
01:52 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-pr-reviews     
01:59 -!- slivera_ [slivera@gateway/vpn/privateinternetaccess/slivera] has joined #bitcoin-core-pr-reviews     
02:01 -!- fengling [~qinfengli@45.32.53.207] has quit [Ping timeout: 265 seconds]     
02:06 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 272 seconds]     
02:26 -!- dr-orlovsky [~dr-orlovs@194.230.155.171] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]     
02:29 -!- fengling [~qinfengli@45.32.53.207] has joined #bitcoin-core-pr-reviews     
02:32 < raj_> Thanks jonatack. These are really good resources. Will go over them this weekend. We dont yet have a pr for next week it seems.
02:48 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-pr-reviews     
02:57 -!- jonatack [~jon@82.102.27.163] has joined #bitcoin-core-pr-reviews     
03:05 -!- Sydney60Rau [~Sydney60R@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-pr-reviews     
03:11 -!- Sydney60Rau [~Sydney60R@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 265 seconds]     
03:55 -!- slivera_ [slivera@gateway/vpn/privateinternetaccess/slivera] has quit [Remote host closed the connection]     
04:47 -!- rottensox [~rottensox@unaffiliated/rottensox] has quit [Remote host closed the connection]     
04:49 -!- rottensox [~rottensox@unaffiliated/rottensox] has joined #bitcoin-core-pr-reviews     
05:00 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-pr-reviews     
05:06 -!- dr-orlovsky [~dr-orlovs@170.204.90.212.static.wline.lns.sme.cust.swisscom.ch] has joined #bitcoin-core-pr-reviews     
05:15 -!- jonatack [~jon@82.102.27.163] has quit [Ping timeout: 265 seconds]     
05:25 -!- mol [~molly@unaffiliated/molly] has quit [Read error: Connection reset by peer]     
05:46 -!- fox2p [~fox2p@cpe-66-108-32-173.nyc.res.rr.com] has quit [Ping timeout: 260 seconds]     
05:49 -!- fox2p [~fox2p@cpe-66-108-32-173.nyc.res.rr.com] has joined #bitcoin-core-pr-reviews     
06:48 -!- jonatack [~jon@37.167.148.7] has joined #bitcoin-core-pr-reviews     
07:21 -!- jonatack [~jon@37.167.148.7] has quit [Ping timeout: 265 seconds]     
07:43 -!- rottensox_ [~rottensox@unaffiliated/rottensox] has joined #bitcoin-core-pr-reviews     
07:44 -!- rottensox [~rottensox@unaffiliated/rottensox] has quit [Read error: Connection reset by peer]     
07:49 < fjahr> jonatack: thanks for mentioning it! raj_: if you see things that need improvement please let me know, I will update the doc soon as I am preparing a workshop on the topic and there is already some feedback I have not addressed yet below the doc
08:17 -!- rottensox_ is now known as rottensox     
08:26 -!- dr-orlovsky [~dr-orlovs@170.204.90.212.static.wline.lns.sme.cust.swisscom.ch] has quit [Ping timeout: 240 seconds]     
08:29 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-pr-reviews     
08:39 -!- rottensox [~rottensox@unaffiliated/rottensox] has quit [Ping timeout: 252 seconds]     
08:40 -!- rottensox [~rottensox@unaffiliated/rottensox] has joined #bitcoin-core-pr-reviews     
08:58 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-pr-reviews     
09:13 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 260 seconds]     
09:19 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Quit: Leaving]     
09:29 -!- dr-orlovsky [~dr-orlovs@93-39-245-228.ip78.fastwebnet.it] has joined #bitcoin-core-pr-reviews     
09:34 -!- dr-orlovsky [~dr-orlovs@93-39-245-228.ip78.fastwebnet.it] has quit [Ping timeout: 268 seconds]     
09:35 < jonatack> Next week's PR review club will be on #17477 "Remove the mempool's NotifyEntryAdded and NotifyEntryRemoved signals" (validation)
09:36 < jonatack> https://github.com/bitcoin/bitcoin/pull/17477
09:36 < jonatack> Notes and questions up soon
10:15 -!- ghost43_ is now known as ghost43     
11:30 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-zaobeyyumftgxqww] has joined #bitcoin-core-pr-reviews     
11:41 -!- rottensox [~rottensox@unaffiliated/rottensox] has quit [Read error: Connection reset by peer]     
11:41 -!- rottensox [~rottensox@unaffiliated/rottensox] has joined #bitcoin-core-pr-reviews     
12:10 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-pr-reviews     
12:41 -!- slivera [slivera@gateway/vpn/privateinternetaccess/slivera] has joined #bitcoin-core-pr-reviews     
12:43 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-pr-reviews     
12:55 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!]     
12:55 -!- dr-orlovsky [~dr-orlovs@194.230.155.171] has joined #bitcoin-core-pr-reviews     
13:00 -!- dr-orlovsky [~dr-orlovs@194.230.155.171] has quit [Ping timeout: 240 seconds]     
13:12 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 265 seconds]     
13:14 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Quit: Leaving]     
13:40 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]     
13:42 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews     
13:51 -!- dr-orlovsky [~dr-orlovs@194.230.155.171] has joined #bitcoin-core-pr-reviews     
13:56 -!- dr-orlovsky [~dr-orlovs@194.230.155.171] has quit [Ping timeout: 268 seconds]     
14:08 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-zaobeyyumftgxqww] has quit [Quit: Connection closed for inactivity]     
16:10 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews     
16:18 -!- pinheadmz [~matthewzi@45.83.89.180] has quit [Read error: Connection reset by peer]     
16:19 -!- pinheadmz [~matthewzi@196.247.57.236] has joined #bitcoin-core-pr-reviews     
17:05 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]     
17:37 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-pr-reviews     
18:07 -!- dr-orlovsky [~dr-orlovs@194.230.155.171] has joined #bitcoin-core-pr-reviews     
18:12 -!- dr-orlovsky [~dr-orlovs@194.230.155.171] has quit [Ping timeout: 258 seconds]     
18:21 -!- ethzero [sid396973@gateway/web/irccloud.com/x-znsdwibjpwqwuber] has quit [Read error: Connection reset by peer]     
18:21 -!- ethzero [sid396973@gateway/web/irccloud.com/x-wnfompkmaogsobpo] has joined #bitcoin-core-pr-reviews     
18:33 -!- digi_james [sid281632@gateway/web/irccloud.com/x-ujprzhctynzlzsgm] has quit [Ping timeout: 272 seconds]     
18:35 -!- digi_james [sid281632@gateway/web/irccloud.com/x-cukzvhrxdqeboqmk] has joined #bitcoin-core-pr-reviews     
18:35 -!- nadra [uid415365@gateway/web/irccloud.com/x-ivzkxknnnsmulpho] has quit [Ping timeout: 258 seconds]     
18:38 -!- nadra [uid415365@gateway/web/irccloud.com/x-akuuqokvzuvezzmi] has joined #bitcoin-core-pr-reviews     
20:01 -!- felixfoertsch23 [~felixfoer@2001:16b8:50bb:f500:7c83:8aec:8f14:5748] has joined #bitcoin-core-pr-reviews     
20:02 -!- felixfoertsch [~felixfoer@2001:16b8:5032:f00:b59e:afaa:3ca7:858d] has quit [Ping timeout: 252 seconds]     
23:46 -!- molly [~molly@unaffiliated/molly] has joined #bitcoin-core-pr-reviews     
23:49 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds]     
23:55 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-pr-reviews