--- Day changed Sat Jan 25 2020 00:00 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 00:41 -!- dr-orlovsky [~dr-orlovs@194.230.155.171] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 01:01 -!- rottensox [~rottensox@unaffiliated/rottensox] has quit [Read error: Connection reset by peer] 01:02 -!- nadra [uid415365@gateway/web/irccloud.com/x-gbshiemqxklfakwc] has quit [Quit: Connection closed for inactivity] 01:03 -!- rottensox_ [~rottensox@unaffiliated/rottensox] has joined #bitcoin-core-pr-reviews 01:04 -!- rottensox_ [~rottensox@unaffiliated/rottensox] has quit [Remote host closed the connection] 01:04 -!- rottensox_ [~rottensox@unaffiliated/rottensox] has joined #bitcoin-core-pr-reviews 01:07 -!- rottensox_ is now known as rottensox 01:14 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-pr-reviews 01:26 -!- MasterdonX [~masterdon@45.248.79.86] has quit [Quit: ZNC 1.7.4 - https://znc.in] 01:26 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-pr-reviews 01:30 -!- MasterdonX [~masterdon@45.248.79.86] has joined #bitcoin-core-pr-reviews 02:18 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Quit: jonatack] 02:23 -!- nadra [uid415365@gateway/web/irccloud.com/x-zbdrylcnluidytwd] has joined #bitcoin-core-pr-reviews 03:03 -!- Hellen31Schoen [~Hellen31S@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-pr-reviews 03:09 -!- Hellen31Schoen [~Hellen31S@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 265 seconds] 04:09 -!- dr-orlovsky [~dr-orlovs@194.230.155.171] has joined #bitcoin-core-pr-reviews 04:32 -!- nadra [uid415365@gateway/web/irccloud.com/x-zbdrylcnluidytwd] has quit [Quit: Connection closed for inactivity] 05:54 -!- jonatack [~jon@109.232.227.149] has joined #bitcoin-core-pr-reviews 07:14 -!- molly [~molly@unaffiliated/molly] has quit [Read error: Connection reset by peer] 07:17 < jonatack> fanquake: v0.19.1rc1 is the tag you're looking for gitian contribs on, yes? 08:38 -!- dr-orlovsky [~dr-orlovs@194.230.155.171] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 08:48 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 08:56 < brikk> I should have the sigs ready tonight, I'm able to build the osx and get the same hashes as you have, but I must be missing something as I don't get any output in gitian.sigs 08:56 < jonatack> brikk: which tag are you building? 08:57 < brikk> v0.19.1rc1 08:58 < brikk> This is my first attempt on Gitian, so I'm learning as I go 08:58 -!- dr-orlovsky [~dr-orlovs@178.197.231.149] has joined #bitcoin-core-pr-reviews 08:58 < jonatack> same. unfortunately i've been stuck at the `bin/gbuild...` 08:59 < jonatack> linux step, with: "qemu-img: target-bionic-amd64.qcow2: Could not open 'base-bionic-amd64.qcow2': No such file or directory" 09:01 < brikk> jonatack: do you get that immediately or later? I'm running that step now, it's been building for a while. 09:02 < jonatack> the first time it ran for a long while... but my internet connection is slow here and i'm using a laptop 09:03 < jonatack> now i get that error immediately 09:08 -!- dr-orlovsky [~dr-orlovs@178.197.231.149] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 09:09 < jonatack> i think i've resolved it by setting docker to run on linux with needing to be root 09:09 < jonatack> without* 09:09 < jonatack> which isn't great but seems to be necessary for the script to run 09:12 < brikk> I ran into an issue with make-base-vm, I couldn't get the proxy part to work, that's probably a docker issue as well 09:12 -!- seven__ [~seven@2a00:ee2:410c:1300:39f1:b095:c767:c06b] has joined #bitcoin-core-pr-reviews 09:13 < brikk> I got around it by removing line 204 https://github.com/devrandom/gitian-builder/blob/master/bin/make-base-vm#L204 09:14 < jonatack> same, i think i solved it by running a command i found in gitian-builder/README.md: bin/make-base-vm --docker 09:16 < jonatack> i haven't used docker in a long time and had to install it and everything today 09:17 -!- seven_ [~seven@2a00:ee2:410c:1300:29e7:4daa:d06d:28e1] has quit [Ping timeout: 272 seconds] 09:23 -!- jonatack [~jon@109.232.227.149] has quit [Ping timeout: 265 seconds] 09:48 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-pr-reviews 10:04 < pinheadmz> What is everyone's approach to re-reviewing PRs after they have been updated? Do you just check that the nits from your first review have been addressed? If there was a force-push do you have to start over from the top and make sure nothing critical has been changed? For long PRs... doesnt that suck?? 10:07 -!- dr-orlovsky [~dr-orlovs@194.230.155.171] has joined #bitcoin-core-pr-reviews 10:18 -!- dr-orlovsky [~dr-orlovs@194.230.155.171] has quit [Ping timeout: 240 seconds] 10:49 < amiti> usually to re-ack you want to check out the diff between the old head & the new one 10:49 < amiti> have you seen the docs here: https://github.com/bitcoin/bitcoin/blob/master/doc/productivity.md#diff-the-diffs-with-git-range-diff 10:51 < amiti> you can also see the diff on github, if you click on the "force-pushed" part of the < reviewer force-pushed the branch x times ... > update 10:55 < pinheadmz> thanks this is helpful 11:00 < amiti> awesome 11:03 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 11:08 < gwillen> notably, github will not let you fetch the old commits after a force-push without some shenanigans 11:09 < gwillen> so the easiest way to make sure you can diff this in your local repo is to make sure you fetch whenever you review 11:09 < gwillen> (I just ran into this a few days ago) 11:10 < gwillen> (the shenanigan approach: fork the repo, go to yourcopy/commits/old_id, click the branch dropdown, create a branch, then fetch it.) 11:13 < pinheadmz> i always pull and review locally. if a remote has been force-pushed, i learned i can reset --hard locally to avoid git complaining about conflicts. but i guess i can also pull the updated remote into a NEW local, and then i can compare before/after 11:13 < pinheadmz> git-fu 11:17 < gwillen> I generally do not even use local branches, you can diff directly on the remote-tracking branches 11:17 < gwillen> so just fetch instead of pull 11:18 < pinheadmz> how do you switch to the remote branch? doesnt checkout always make a local copy that tracks remote? 11:19 < gwillen> if you checkout a remote-tracking branch directly, it won't create a local branch, it will just give you a warning that you're not on a local branch anymore ("detatched head") 11:19 < pinheadmz> git checkout remote/branch ? like, specify thre remote? 11:20 < gwillen> yeah 11:20 < pinheadmz> tnx 11:20 < gwillen> or using the fancy github PR trick, "git checkout remote/pr/123" 11:20 < gwillen> if you're using that 11:20 < pinheadmz> yeah i dont like that or oyu can fetch /pulls/ or something 11:20 < gwillen> np! 11:21 < gwillen> yeah, I usually forget to use it but I do have that set up 11:21 < pinheadmz> but so wait - if the remote has been force-pushed, how do you get it locally so you can diff the two? 11:21 < gwillen> just "git fetch remote" and it will update 11:21 < gwillen> and then "git checkout remote/pr/123" again 11:21 < pinheadmz> and then whats the diff command though 11:21 < gwillen> hmmm, I guess in that case you would just need to like, go look at the PR thread and diff the commit IDs 11:21 < gwillen> since you would no longer have any ref pointing at the old one 11:22 < pinheadmz> ahh diff by commit hashes, ok interesting 11:22 < gwillen> you would just "git diff ", or else "git diff remote/pr/123" 11:22 < gwillen> I imagine you can do the same thing with the git-range-diff thing that amiti linked to above 11:38 < jonatack> pinheadmz: here's an example of `git diff `: git diff 8c09bf9..8317bb3 in https://github.com/bitcoin/bitcoin/pull/16115#issuecomment-573830913 11:41 < jonatack> warning: depending on your case a fairly recent version of git might be needed, i cloned and built git from source because the debian distribution manager version didn't have it 11:43 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 11:45 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 11:47 -!- dr-orlovsky [~dr-orlovs@194.230.155.171] has joined #bitcoin-core-pr-reviews 12:20 -!- justinmoon_ is now known as justinmoon 12:39 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 12:39 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 12:43 -!- slivera [~slivera@116.206.228.243] has joined #bitcoin-core-pr-reviews 13:19 -!- pinheadmz [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Quit: pinheadmz] 13:19 -!- pinheadmz [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-pr-reviews 14:30 -!- slivera [~slivera@116.206.228.243] has quit [Remote host closed the connection] 14:48 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-pr-reviews 14:56 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 14:56 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 15:05 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Quit: Leaving] 15:17 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-pr-reviews 15:28 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 15:29 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-pr-reviews 15:44 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 19:52 -!- felixfoertsch [~felixfoer@2001:16b8:5057:6800:bd5c:1f5b:41c9:fffd] has quit [Ping timeout: 272 seconds] 19:53 -!- felixfoertsch [~felixfoer@2001:16b8:5003:8100:54d0:24f7:dc99:5670] has joined #bitcoin-core-pr-reviews 23:39 -!- orlovsky [~dr-orlovs@194.230.155.171] has joined #bitcoin-core-pr-reviews 23:41 -!- dr-orlovsky [~dr-orlovs@194.230.155.171] has quit [Ping timeout: 260 seconds] 23:43 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 23:45 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews