--- Day changed Mon Feb 10 2020 00:00 < jonatack> aj: see the half dozen comments starting from https://github.com/bitcoin/bitcoin/pull/15921#issuecomment-547940767 00:01 < jonatack> or at least, to merge "en connaissance de cause" e.g. knowing the was a meeting on it ;) 00:10 < jonatack> aj: an emergent aspect is that the review club notes for each PR have become a useful resource, and the label can help let people know that review notes exist for that PR 00:15 < jonatack> Good question though. I updated my comment at https://github.com/bitcoin/bitcoin/pull/18044#issuecomment-581939690 to say why. 00:46 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-pr-reviews 02:01 -!- ccdle12_ [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #bitcoin-core-pr-reviews 02:01 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #bitcoin-core-pr-reviews 02:02 -!- ccdle12_ [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Client Quit] 02:52 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 256 seconds] 03:05 -!- Hilma69Schmeler [~Hilma69Sc@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-pr-reviews 03:10 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 03:10 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-pr-reviews 03:11 -!- Hilma69Schmeler [~Hilma69Sc@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 272 seconds] 03:11 -!- dr_orlovsky [~dr-orlovs@xdsl-188-155-1-200.adslplus.ch] has joined #bitcoin-core-pr-reviews 03:11 -!- dr_orlovsky [~dr-orlovs@xdsl-188-155-1-200.adslplus.ch] has quit [Client Quit] 03:30 -!- jonatack [~jon@213.152.162.94] has joined #bitcoin-core-pr-reviews 03:55 -!- jungly [~jungly@host97-200-static.8-79-b.business.telecomitalia.it] has quit [Remote host closed the connection] 04:19 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Remote host closed the connection] 04:30 -!- jonatack [~jon@213.152.162.94] has quit [Ping timeout: 260 seconds] 04:32 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-pr-reviews 04:56 -!- vindard [~vindard@190.83.165.233] has quit [Ping timeout: 260 seconds] 04:59 -!- vindard [~vindard@190.83.165.233] has joined #bitcoin-core-pr-reviews 05:15 -!- jungly [~jungly@host243-191-dynamic.1-87-r.retail.telecomitalia.it] has joined #bitcoin-core-pr-reviews 05:29 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Quit: WeeChat 1.9.1] 06:01 -!- jungly [~jungly@host243-191-dynamic.1-87-r.retail.telecomitalia.it] has quit [Read error: Connection reset by peer] 06:04 -!- jungly [~jungly@host243-191-dynamic.1-87-r.retail.telecomitalia.it] has joined #bitcoin-core-pr-reviews 06:04 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds] 06:09 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-pr-reviews 06:22 -!- jungly [~jungly@host243-191-dynamic.1-87-r.retail.telecomitalia.it] has quit [Read error: Connection reset by peer] 06:23 -!- jungly_ [~jungly@host243-191-dynamic.1-87-r.retail.telecomitalia.it] has joined #bitcoin-core-pr-reviews 06:37 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-pr-reviews 07:53 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 07:55 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-pr-reviews 08:07 -!- jonatack [~jon@54.76.13.109.rev.sfr.net] has joined #bitcoin-core-pr-reviews 08:08 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-pr-reviews 09:10 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Remote host closed the connection] 09:27 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 09:28 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-pr-reviews 09:28 -!- jonatack [~jon@54.76.13.109.rev.sfr.net] has quit [Ping timeout: 265 seconds] 09:57 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-pr-reviews 10:02 -!- fox2p_ [~fox2p@193.32.127.153] has joined #bitcoin-core-pr-reviews 10:03 -!- fox2p [~fox2p@193.32.127.151] has quit [Ping timeout: 248 seconds] 10:19 -!- jungly_ [~jungly@host243-191-dynamic.1-87-r.retail.telecomitalia.it] has quit [Remote host closed the connection] 10:20 -!- jungly [~jungly@host243-191-dynamic.1-87-r.retail.telecomitalia.it] has joined #bitcoin-core-pr-reviews 10:30 -!- fox2p_ [~fox2p@193.32.127.153] has quit [Ping timeout: 240 seconds] 10:34 -!- fox2p [~fox2p@cpe-66-108-32-173.nyc.res.rr.com] has joined #bitcoin-core-pr-reviews 10:38 -!- rjected [~rjected@natp-128-119-202-202.wireless.umass.edu] has joined #bitcoin-core-pr-reviews 10:53 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-pr-reviews 11:06 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 11:06 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-pr-reviews 11:12 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Excess Flood] 11:13 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-pr-reviews 11:15 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Quit: Leaving] 11:15 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 11:21 -!- jungly [~jungly@host243-191-dynamic.1-87-r.retail.telecomitalia.it] has quit [Remote host closed the connection] 11:22 -!- jungly [~jungly@host243-191-dynamic.1-87-r.retail.telecomitalia.it] has joined #bitcoin-core-pr-reviews 11:23 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 11:26 -!- jungly [~jungly@host243-191-dynamic.1-87-r.retail.telecomitalia.it] has quit [Ping timeout: 240 seconds] 11:40 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 11:43 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 11:59 -!- rjected [~rjected@natp-128-119-202-202.wireless.umass.edu] has quit [Ping timeout: 260 seconds] 12:26 -!- vasild_ is now known as vasild 12:36 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds] 12:41 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-pr-reviews 12:45 -!- jungly [~jungly@host243-191-dynamic.1-87-r.retail.telecomitalia.it] has joined #bitcoin-core-pr-reviews 12:50 -!- jungly [~jungly@host243-191-dynamic.1-87-r.retail.telecomitalia.it] has quit [Read error: Connection reset by peer] 12:51 -!- jungly [~jungly@host243-191-dynamic.1-87-r.retail.telecomitalia.it] has joined #bitcoin-core-pr-reviews 13:04 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-pr-reviews 13:05 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds] 13:05 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 13:06 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-pr-reviews 13:09 -!- jungly [~jungly@host243-191-dynamic.1-87-r.retail.telecomitalia.it] has quit [Read error: Connection reset by peer] 13:09 -!- jungly_ [~jungly@host243-191-dynamic.1-87-r.retail.telecomitalia.it] has joined #bitcoin-core-pr-reviews 13:12 -!- rjected [~rjected@natp-128-119-202-105.wireless.umass.edu] has joined #bitcoin-core-pr-reviews 14:03 -!- rjected [~rjected@natp-128-119-202-105.wireless.umass.edu] has quit [Ping timeout: 268 seconds] 14:11 -!- jungly_ [~jungly@host243-191-dynamic.1-87-r.retail.telecomitalia.it] has quit [Remote host closed the connection] 14:12 -!- rjected [~rjected@natp-128-119-202-68.wireless.umass.edu] has joined #bitcoin-core-pr-reviews 14:33 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection] 14:33 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 15:36 -!- willcl_ark [~quassel@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has quit [Remote host closed the connection] 15:38 -!- willcl_ark [~quassel@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined #bitcoin-core-pr-reviews 15:55 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 15:58 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 268 seconds] 16:00 -!- lukedashjr is now known as luke-jr 16:02 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 16:03 -!- luke-jr- [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 16:04 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 240 seconds] 16:05 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 16:07 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 265 seconds] 16:08 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 16:08 -!- luke-jr- [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 240 seconds] 16:09 -!- luke-jr- [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 16:11 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 272 seconds] 16:13 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 260 seconds] 16:13 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 16:14 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 16:15 -!- luke-jr- [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 240 seconds] 16:16 -!- luke-jr- [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 16:18 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 260 seconds] 16:20 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 16:20 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 265 seconds] 16:22 -!- luke-jr- [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 265 seconds] 16:28 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 16:31 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 265 seconds] 16:33 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 16:34 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 272 seconds] 16:44 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 16:45 -!- luke-jr- [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 16:47 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 268 seconds] 16:47 -!- luke-jr| [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 16:49 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 268 seconds] 16:50 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 16:51 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 16:51 -!- luke-jr- [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 265 seconds] 16:51 -!- pkr [~pkr@158.140.254.215] has joined #bitcoin-core-pr-reviews 16:52 -!- luke-jr- [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 16:52 -!- luke-jr| [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 260 seconds] 16:54 -!- luke-jr| [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 16:55 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 260 seconds] 16:55 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 260 seconds] 16:57 -!- luke-jr- [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 265 seconds] 16:58 -!- luke-jr| is now known as luke-jr 17:03 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 17:04 -!- luke-jr- [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 17:06 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 272 seconds] 17:07 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 17:08 -!- luke-jr| [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 17:08 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 268 seconds] 17:10 -!- luke-jr- [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 272 seconds] 17:12 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 265 seconds] 17:12 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 17:13 -!- luke-jr| [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 240 seconds] 17:14 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 17:18 -!- luke-jr- [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 17:18 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 272 seconds] 17:19 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 240 seconds] 17:24 -!- luke-jr- [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 260 seconds] 17:25 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 17:28 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 17:31 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 272 seconds] 17:33 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 272 seconds] 17:34 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 17:41 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 268 seconds] 17:42 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 17:43 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 17:46 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 240 seconds] 17:49 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 272 seconds] 17:49 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 18:05 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 18:28 -!- krvopije [~krvopije@185.106.109.144] has joined #bitcoin-core-pr-reviews 18:29 -!- krvopije [~krvopije@185.106.109.144] has quit [Client Quit] 19:15 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds] 19:40 -!- felixfoertsch [~felixfoer@2001:16b8:5071:2700:f90f:a6d9:ef60:b428] has joined #bitcoin-core-pr-reviews 19:41 -!- felixfoertsch23 [~felixfoer@92.117.49.109] has quit [Ping timeout: 272 seconds] 20:12 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 20:16 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-pr-reviews 21:59 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 21:59 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-pr-reviews 22:25 -!- rjected [~rjected@natp-128-119-202-68.wireless.umass.edu] has quit [Quit: WeeChat 2.7] 23:09 -!- jungly [~jungly@host243-191-dynamic.1-87-r.retail.telecomitalia.it] has joined #bitcoin-core-pr-reviews 23:42 -!- nadra [uid415365@gateway/web/irccloud.com/x-hvefjhnvsjrdzjjf] has joined #bitcoin-core-pr-reviews 23:43 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 23:45 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews