--- Day changed Tue Apr 14 2020 00:08 -!- jungly [~jungly@host21-196-dynamic.246-95-r.retail.telecomitalia.it] has quit [Remote host closed the connection] 00:32 -!- jonasschnelli_ [~jonasschn@2a01:4f8:172:10da::2] has quit [Changing host] 00:32 -!- jonasschnelli_ [~jonasschn@unaffiliated/jonasschnelli] has joined #bitcoin-core-pr-reviews 00:32 -!- jonatack [~jon@109.202.107.147] has quit [Ping timeout: 250 seconds] 00:32 -!- jonasschnelli_ is now known as jonasschnelli 00:35 -!- jonatack [~jon@37.170.60.192] has joined #bitcoin-core-pr-reviews 00:45 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 00:45 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 01:08 -!- jungly [~jungly@host21-196-dynamic.246-95-r.retail.telecomitalia.it] has joined #bitcoin-core-pr-reviews 01:39 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-hwtfxdqfnnsfqelt] has quit [Quit: killed] 01:50 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-odacgarsbbtcwjvf] has joined #bitcoin-core-pr-reviews 01:58 -!- jungly [~jungly@host21-196-dynamic.246-95-r.retail.telecomitalia.it] has quit [Remote host closed the connection] 01:59 -!- jungly [~jungly@host21-196-dynamic.246-95-r.retail.telecomitalia.it] has joined #bitcoin-core-pr-reviews 02:40 < vasild> jnewbery: jonatack: kallewoof: Following the IRC discussion after the last review club, I propose 02:40 < vasild> https://github.com/bitcoin/bitcoin/pull/17994 validation: flush undo files after last block write 02:40 < vasild> for the review club meeting on Apr 22. The PR is already in https://github.com/bitcoin-core-review-club/website/issues/14. 02:40 < vasild> If kallewoof is unavailable at that time I can host the meeting at 17:00 UTC. 02:41 < vasild> Some preliminary notes and questions (feel free to add/remove/edit as you wish): https://github.com/vasild/bitcoin/wiki/notes-for-review-club-on-17994 02:51 < kallewoof> vasild: Great notes! I'll think about if I have any suggestions but they're very thorough already 02:53 < vasild> kallewoof: Thanks! The guidelines suggest we finalize the stuff by Friday, so there are a few days to tune it. I am not sure how github works - can everybody edit this wiki: https://github.com/vasild/bitcoin/wiki/notes-for-review-club-on-17994 ? 02:54 < kallewoof> vasild: Yep, I just edited it 02:54 < kallewoof> And removed the edit again 02:54 < vasild> I checked that at least if not logged in, its not possible to edit 02:54 < vasild> Excellent! 03:03 -!- Kyle2Lind [~Kyle2Lind@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-pr-reviews 03:09 -!- Kyle2Lind [~Kyle2Lind@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 265 seconds] 03:10 < jonatack> vasild: kallewoof: 👍 03:13 < jonatack> vasild: you'll have to check with jnewbery about the schedule but you can make a PR, see https://github.com/bitcoin-core-review-club/website/blob/master/CONTRIBUTING.md#making-a-new-post 03:15 < jonatack> vasild: git clone the repo and check out previous meetings in the /_posts dir for examples 03:18 < jonatack> to get the review club set up locally: https://github.com/bitcoin-core-review-club/website/blob/master/README.md#development 03:18 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-pr-reviews 03:19 -!- jonatack [~jon@37.170.60.192] has quit [Read error: Connection reset by peer] 03:20 -!- jonatack_ [~jon@37.170.60.192] has joined #bitcoin-core-pr-reviews 03:23 < vasild> kallewoof: would you be available to host the meeting at 17:00 UTC? I gather it is at an odd time of the day for you? 03:50 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds] 03:50 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-pr-reviews 04:14 < kallewoof> vasild: I thought it was 16:00 UTC? Anyway yes I can definitely host it! I don't know if anyone will participate though. I became busy there at one point and I don't think anyone else hosted for the last couple of weeks 04:26 < kallewoof> Oh, not 16 actually, it's 4 am.. 04:26 < kallewoof> I finally understand what you're saying -- unfortunately I can't host the main one. 04:38 < vasild> https://bitcoincore.reviews/ says 17:00 UTC 04:39 < vasild> kallewoof: ok, I will host the main one, waiting on a confirmation from jnewbery on the date before executing rake posts:new... 05:03 -!- jonatack_ [~jon@37.170.60.192] has quit [Quit: jonatack_] 05:04 -!- jonatack [~jon@213.152.161.101] has joined #bitcoin-core-pr-reviews 06:01 -!- michaelfolkson [~textual@host86-177-146-79.range86-177.btcentralplus.com] has joined #bitcoin-core-pr-reviews 06:01 -!- michaelfolkson [~textual@host86-177-146-79.range86-177.btcentralplus.com] has quit [Client Quit] 06:42 -!- jungly [~jungly@host21-196-dynamic.246-95-r.retail.telecomitalia.it] has quit [Remote host closed the connection] 06:48 -!- jungly [~jungly@host21-196-dynamic.246-95-r.retail.telecomitalia.it] has joined #bitcoin-core-pr-reviews 06:50 -!- hugohn [sid304114@gateway/web/irccloud.com/x-rmyhvbrhtjzyvzfy] has quit [Read error: Connection reset by peer] 06:50 -!- hugohn [sid304114@gateway/web/irccloud.com/x-zyhmcwlunzxsudrx] has joined #bitcoin-core-pr-reviews 06:57 < kallewoof> vasild: Yeah, sorry I was getting the meetups mixed up 06:59 < vasild> :) 07:31 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 07:31 -!- mol [~molly@unaffiliated/molly] has quit [Read error: Connection reset by peer] 07:35 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 07:56 < jnewbery> vasild: thanks for volunteering! Yes, I'd be very happy for you to host next week. Can you open a PR against bitcoin-core-review-club/website for the notes and questions? 07:58 < vasild> yes 08:23 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 08:24 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-pr-reviews 08:47 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 09:19 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 09:24 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews 09:25 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 240 seconds] 09:29 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 09:33 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 240 seconds] 09:34 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-pr-reviews 09:39 -!- lightlike [~lightlike@p200300C7EF1CB600CCE41A8C08B0A787.dip0.t-ipconnect.de] has joined #bitcoin-core-pr-reviews 09:44 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 10:24 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:b865:43b9:34cd:d980] has joined #bitcoin-core-pr-reviews 10:58 -!- jungly [~jungly@host21-196-dynamic.246-95-r.retail.telecomitalia.it] has quit [Remote host closed the connection] 10:59 -!- jungly [~jungly@host21-196-dynamic.246-95-r.retail.telecomitalia.it] has joined #bitcoin-core-pr-reviews 11:19 -!- jungly [~jungly@host21-196-dynamic.246-95-r.retail.telecomitalia.it] has quit [Remote host closed the connection] 12:14 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 12:17 -!- jungly [~jungly@host21-196-dynamic.246-95-r.retail.telecomitalia.it] has joined #bitcoin-core-pr-reviews 12:19 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 12:19 -!- corollari [sid405633@gateway/web/irccloud.com/x-dsoynfgsgdqdtfpu] has joined #bitcoin-core-pr-reviews 12:22 -!- jungly [~jungly@host21-196-dynamic.246-95-r.retail.telecomitalia.it] has quit [Ping timeout: 240 seconds] 12:32 -!- jonatack [~jon@213.152.161.101] has quit [Ping timeout: 256 seconds] 12:34 -!- jonatack [~jon@37.170.227.51] has joined #bitcoin-core-pr-reviews 12:41 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 12:44 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 12:44 -!- vasild_ is now known as vasild 12:57 -!- jungly [~jungly@host21-196-dynamic.246-95-r.retail.telecomitalia.it] has joined #bitcoin-core-pr-reviews 13:10 -!- jungly [~jungly@host21-196-dynamic.246-95-r.retail.telecomitalia.it] has quit [Remote host closed the connection] 13:11 -!- jungly [~jungly@host21-196-dynamic.246-95-r.retail.telecomitalia.it] has joined #bitcoin-core-pr-reviews 13:16 -!- jungly [~jungly@host21-196-dynamic.246-95-r.retail.telecomitalia.it] has quit [Remote host closed the connection] 13:17 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-pr-reviews 13:19 -!- jungly [~jungly@host21-196-dynamic.246-95-r.retail.telecomitalia.it] has joined #bitcoin-core-pr-reviews 13:45 -!- jungly [~jungly@host21-196-dynamic.246-95-r.retail.telecomitalia.it] has quit [Read error: Connection reset by peer] 13:45 -!- jungly_ [~jungly@host21-196-dynamic.246-95-r.retail.telecomitalia.it] has joined #bitcoin-core-pr-reviews 13:46 -!- jungly_ [~jungly@host21-196-dynamic.246-95-r.retail.telecomitalia.it] has quit [Remote host closed the connection] 14:48 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:b865:43b9:34cd:d980] has quit [Quit: Sleep mode] 15:04 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 15:04 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-pr-reviews 18:39 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 19:17 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds] 19:28 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-pr-reviews 19:39 -!- Jackielove4u_ [uid43977@gateway/web/irccloud.com/x-zobezkrytesagzue] has quit [Quit: Connection closed for inactivity] 20:41 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 20:55 -!- lightlike_ [~lightlike@p200300C7EF10B500CCE41A8C08B0A787.dip0.t-ipconnect.de] has joined #bitcoin-core-pr-reviews 20:58 -!- lightlike [~lightlike@p200300C7EF1CB600CCE41A8C08B0A787.dip0.t-ipconnect.de] has quit [Ping timeout: 256 seconds] 21:05 -!- jnewbery [~john@cpe-74-72-241-241.nyc.res.rr.com] has quit [Ping timeout: 250 seconds] 21:27 -!- jnewbery [~john@cpe-74-72-241-241.nyc.res.rr.com] has joined #bitcoin-core-pr-reviews 23:31 -!- jungly [~jungly@host21-196-dynamic.246-95-r.retail.telecomitalia.it] has joined #bitcoin-core-pr-reviews 23:59 -!- jonatack [~jon@37.170.227.51] has quit [Remote host closed the connection]