--- Day changed Mon May 11 2020 01:09 -!- tynes_ [~tynes@30.50.237.35.bc.googleusercontent.com] has joined #bitcoin-core-pr-reviews 01:10 -!- MarcoFalke_2 [~none@198.12.116.246] has joined #bitcoin-core-pr-reviews 01:10 -!- molz_ [~mol@unaffiliated/molly] has quit [Read error: Connection reset by peer] 01:10 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 01:11 -!- nehan_ [~nehan@41.213.196.104.bc.googleusercontent.com] has joined #bitcoin-core-pr-reviews 01:12 -!- Henry151_ [~bishop@ns3007530.ip-151-80-44.eu] has joined #bitcoin-core-pr-reviews 01:13 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 01:14 -!- waxwing_ [~waxwing@193.29.57.116] has joined #bitcoin-core-pr-reviews 01:15 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 272 seconds] 01:15 -!- Netsplit *.net <-> *.split quits: MarcoFalke, tynes, waxwing, nehan, Henry151 01:22 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-pr-reviews 01:23 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Client Quit] 01:31 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has joined #bitcoin-core-pr-reviews 02:13 -!- Matterlend [~Logiciant@82.102.24.131] has quit [Quit: Leaving] 03:02 -!- jesseposner [~jesseposn@c-67-188-220-154.hsd1.ca.comcast.net] has quit [Ping timeout: 256 seconds] 03:04 -!- waxwing_ is now known as waxwing 03:04 -!- waxwing [~waxwing@193.29.57.116] has quit [Changing host] 03:04 -!- waxwing [~waxwing@unaffiliated/waxwing] has joined #bitcoin-core-pr-reviews 03:10 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Read error: Connection reset by peer] 03:10 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-pr-reviews 04:02 -!- jesseposner [~jesseposn@c-67-188-220-154.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 04:24 -!- jesseposner [~jesseposn@c-67-188-220-154.hsd1.ca.comcast.net] has quit [Ping timeout: 246 seconds] 04:46 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 04:47 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-pr-reviews 05:30 -!- AlistairMann [~am@host31-52-25-35.range31-52.btcentralplus.com] has quit [Ping timeout: 260 seconds] 05:31 -!- AlistairMann [~am@host31-52-25-35.range31-52.btcentralplus.com] has joined #bitcoin-core-pr-reviews 05:35 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 05:37 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 264 seconds] 05:50 -!- fox2p [~fox2p@2804:14c:5ba3:21d::100c] has joined #bitcoin-core-pr-reviews 05:52 -!- fox2p [~fox2p@2804:14c:5ba3:21d::100c] has quit [Client Quit] 05:52 -!- foxp2 [~foxp2@2804:14c:5ba3:21d::100c] has joined #bitcoin-core-pr-reviews 06:00 -!- foxp2 [~foxp2@2804:14c:5ba3:21d::100c] has quit [Read error: No route to host] 06:15 -!- foxp2 [~foxp2@2804:14c:5ba3:21d::100c] has joined #bitcoin-core-pr-reviews 06:15 -!- foxp2 [~foxp2@2804:14c:5ba3:21d::100c] has quit [Client Quit] 06:19 -!- foxp2 [~foxp2@ec2-3-229-163-177.compute-1.amazonaws.com] has joined #bitcoin-core-pr-reviews 06:21 -!- jesseposner [~jesseposn@c-67-188-220-154.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 06:25 -!- jesseposner [~jesseposn@c-67-188-220-154.hsd1.ca.comcast.net] has quit [Ping timeout: 258 seconds] 06:37 -!- foxp2 [~foxp2@ec2-3-229-163-177.compute-1.amazonaws.com] has quit [Quit: \/\/] 06:40 -!- foxp2 [~foxp2@ec2-54-144-139-49.compute-1.amazonaws.com] has joined #bitcoin-core-pr-reviews 06:57 -!- slivera [~slivera@116.206.228.243] has joined #bitcoin-core-pr-reviews 07:08 -!- slivera [~slivera@116.206.228.243] has quit [Quit: Leaving] 07:27 -!- slivera [~slivera@116.206.228.243] has joined #bitcoin-core-pr-reviews 07:30 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 246 seconds] 08:00 -!- jesseposner [~jesseposn@c-67-188-220-154.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 08:02 -!- nothingmuch [~nothingmu@unaffiliated/nothingmuch] has joined #bitcoin-core-pr-reviews 08:02 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 08:02 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-pr-reviews 08:07 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 08:07 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-pr-reviews 08:08 -!- thomasb06 [~user@eth-west-pareq2-46-193-0-224.wb.wifirst.net] has joined #bitcoin-core-pr-reviews 08:10 -!- thomasb06 [~user@eth-west-pareq2-46-193-0-224.wb.wifirst.net] has quit [Client Quit] 08:11 -!- thomasb06 [~user@eth-west-pareq2-46-193-0-224.wb.wifirst.net] has joined #bitcoin-core-pr-reviews 08:13 < thomasb06> Hello. The three test suites went well on pr/18806, what should I do next? 08:16 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds] 08:20 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-pr-reviews 08:30 < thomasb06> Currently, I'm running the test suite on pr/18877, do I need to recompile? If so, how can I be sure that 'ccache' is running? 08:33 -!- jesseposner [~jesseposn@c-67-188-220-154.hsd1.ca.comcast.net] has quit [Ping timeout: 256 seconds] 08:35 < MarcoFalke_2> thomasb06: The output of ./configure should have a line that says something like "CXX = ccache /usr/bin/clang" 08:36 < MarcoFalke_2> or clang++ (something along the lines) 08:38 < instagibbs> "which g++" should also show it in ccache dir 08:38 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Ping timeout: 240 seconds] 08:41 -!- MarcoFalke_2 [~none@198.12.116.246] has quit [Quit: ZNC 1.7.1 - https://znc.in] 08:43 -!- MarcoFalke [~none@198.12.116.246] has joined #bitcoin-core-pr-reviews 08:56 < thomasb06> MarcoFalke: instagibbs: it does, thank you: https://x0.at/Afz% 08:58 -!- slivera [~slivera@116.206.228.243] has quit [Ping timeout: 260 seconds] 09:01 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 09:07 -!- foxp2 [~foxp2@ec2-54-144-139-49.compute-1.amazonaws.com] has quit [Quit: \/\/] 09:10 -!- foxp2 [~foxp2@ec2-54-144-139-49.compute-1.amazonaws.com] has joined #bitcoin-core-pr-reviews 09:13 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews 09:13 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 240 seconds] 09:14 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 09:16 < thomasb06> Both the unit test suite and simple functional test suite went well, how can I be sure that I didn't run the 'pr/18806' a second time? 09:18 < thomasb06> 09:18 < thomasb06> ERC> 09:18 < thomasb06> ERC> https://x0.at/Afz 09:19 < MarcoFalke> git log 09:19 < MarcoFalke> It tells you the current commit (and its history) 09:20 < MarcoFalke> With ./src/bitcoind -version you can check the commit you compiled 09:21 < thomasb06> MarcoFalke: since I'm reviewing a PR, I didn't any commit myself 09:23 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 09:24 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 09:27 -!- jesseposner [~jesseposn@c-67-188-220-154.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 09:27 < thomasb06> both PRs show exactly the same version: Bitcoin Core version v0.20.99.0-23083856a5 09:29 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Client Quit] 09:29 < thomasb06> MarcoFalke: the 'git log' shows a difference between the two PRs, thank you 09:32 < thomasb06> what happens if I type git 'checkout pr/anotherPR' but forget to recompile? 09:37 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-pr-reviews 09:48 -!- foxp2 [~foxp2@ec2-54-144-139-49.compute-1.amazonaws.com] has quit [Quit: \/\/] 10:03 -!- AlistairMann [~am@host31-52-25-35.range31-52.btcentralplus.com] has quit [Ping timeout: 272 seconds] 10:09 -!- foxp2 [~foxp2@ec2-3-229-163-177.compute-1.amazonaws.com] has joined #bitcoin-core-pr-reviews 10:13 -!- AlistairMann [~am@host86-131-87-172.range86-131.btcentralplus.com] has joined #bitcoin-core-pr-reviews 10:34 -!- AlistairMann [~am@host86-131-87-172.range86-131.btcentralplus.com] has quit [Remote host closed the connection] 11:48 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:bd0e:a77:833e:daf8] has joined #bitcoin-core-pr-reviews 11:58 -!- lightlike [~lightlike@p200300C7EF146B00116B72973E704364.dip0.t-ipconnect.de] has joined #bitcoin-core-pr-reviews 12:02 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 12:10 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:bd0e:a77:833e:daf8] has quit [Ping timeout: 272 seconds] 12:19 -!- meshcollider [meshcollid@gateway/shell/ircnow/x-rciolweqctuzmzwr] has quit [Ping timeout: 260 seconds] 12:30 -!- meshcollider [meshcollid@gateway/shell/ircnow/x-xliniymokasdrgzf] has joined #bitcoin-core-pr-reviews 12:39 -!- nehan_ [~nehan@41.213.196.104.bc.googleusercontent.com] has quit [Quit: leaving] 12:41 -!- nehan [~nehan@41.213.196.104.bc.googleusercontent.com] has joined #bitcoin-core-pr-reviews 13:13 -!- lightlike [~lightlike@p200300C7EF146B00116B72973E704364.dip0.t-ipconnect.de] has quit [Quit: Leaving] 13:26 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:9c69:4792:1c73:6a37] has joined #bitcoin-core-pr-reviews 13:32 < willcl_ark> thomasb06: then you just test against the most recently-compiled binaries (again) 13:36 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:9c69:4792:1c73:6a37] has quit [Ping timeout: 272 seconds] 13:52 -!- troygiorshev [~troy@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-pr-reviews 14:04 -!- troygiorshev [~troy@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Quit: leaving] 14:09 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 14:10 -!- foxp2 [~foxp2@ec2-3-229-163-177.compute-1.amazonaws.com] has quit [Quit: \/\/] 14:20 -!- thomasb0` [~user@eth-west-pareq2-46-193-0-224.wb.wifirst.net] has joined #bitcoin-core-pr-reviews 14:20 -!- thomasb06 [~user@eth-west-pareq2-46-193-0-224.wb.wifirst.net] has quit [Remote host closed the connection] 14:35 -!- thomasb0` [~user@eth-west-pareq2-46-193-0-224.wb.wifirst.net] has quit [Read error: Connection reset by peer] 14:36 -!- thomasb0` [~user@eth-west-pareq2-46-193-0-224.wb.wifirst.net] has joined #bitcoin-core-pr-reviews 14:40 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 14:53 -!- thomasb0` [~user@eth-west-pareq2-46-193-0-224.wb.wifirst.net] has quit [Ping timeout: 272 seconds] 15:21 -!- thomasb06 [~user@eth-west-pareq2-46-193-0-224.wb.wifirst.net] has joined #bitcoin-core-pr-reviews 15:22 -!- thomasb06 [~user@eth-west-pareq2-46-193-0-224.wb.wifirst.net] has quit [Client Quit] 15:23 -!- thomasb06 [~user@eth-west-pareq2-46-193-0-224.wb.wifirst.net] has joined #bitcoin-core-pr-reviews 15:23 < thomasb06> willcl_ark: this is what I feared... Is there any mean to check afterwards? 15:26 < thomasb06> regarding the PRs, I added a comment saying the test passed. Is there anything else to do? 15:26 < sipa> thomasb06: if.you're uncertain whether you ran tests on the right code, just run the tests again 15:28 < sipa> and of course there is more to do; actually reading the tests - or the code - and commenting on it (even if just "this is not clear to me" and asking for explanation) adds more 15:28 < sipa> tests are all run automatically on several platforms already 15:29 < sipa> if code organization is not clear after you've done some effort on trying to understand it, it's worth asking about too, but don't clutter PRs with that; bitcoin.stackexchange.com is a better platform 15:36 < thomasb06> sipa: this time I've been careful but I asked in case... So, next step is to read the tests, let's go 15:41 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection] 15:41 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 15:47 -!- foxp2 [~foxp2@ec2-3-229-163-177.compute-1.amazonaws.com] has joined #bitcoin-core-pr-reviews 16:03 < thomasb06> The Archwiki admins have not answered yet that they don't want to add a page on how to compile and test Bitcoin core, which is not a bad news... 16:11 -!- thomasb06 [~user@eth-west-pareq2-46-193-0-224.wb.wifirst.net] has quit [Remote host closed the connection] 16:23 -!- pinheadmz [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Quit: pinheadmz] 16:25 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-pr-reviews 16:30 -!- pinheadmz_ [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-pr-reviews 16:31 -!- pinheadmz_ [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Client Quit] 16:33 -!- pinheadmz_ [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-pr-reviews 16:35 -!- pinheadmz_ [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Client Quit] 16:47 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Quit: Textual IRC Client: www.textualapp.com] 16:47 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-pr-reviews 16:50 -!- foxp2 [~foxp2@ec2-3-229-163-177.compute-1.amazonaws.com] has quit [Quit: \/\/] 16:52 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Client Quit] 16:52 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-pr-reviews 16:53 -!- pinheadmz_ [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-pr-reviews 16:53 -!- pinheadmz_ [~matthewzi@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Client Quit] 16:54 -!- foxp2 [~foxp2@ec2-3-229-163-177.compute-1.amazonaws.com] has joined #bitcoin-core-pr-reviews 16:56 -!- foxp2 [~foxp2@ec2-3-229-163-177.compute-1.amazonaws.com] has quit [Client Quit] 17:21 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has quit [Read error: Connection reset by peer] 17:30 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has joined #bitcoin-core-pr-reviews 17:42 < jnewbery> thomasb06: try to test the changes manually. You may be able to do that using a regtest node and RPC commands, or by verifying that log messages were printed to debug.log. Another good way to test manually is to put a breakpoint in the functional tests, and step through line by line, issuing RPC commands or sending p2p messages to verify behaviour. 17:43 < sipa> how do you put a breakpoint in python? :o 17:44 < jnewbery> sipa: https://github.com/bitcoin/bitcoin/blob/eb2ffbb7c1347115e6a3d6fa30f909959b6170a5/test/README.md#attaching-a-debugger 17:44 < jnewbery> import pdb; pdb.set_trace() 17:46 < sipa> whoa 17:46 < sipa> 17:46 < jnewbery> :D 17:47 < jnewbery> thomasb06: at this stage, the biggest benefit from reviewing is that you'll become more familiar with the interfaces and with the codebase. As you get more experience, you'll be able to offer deeper review. 17:49 < jnewbery> As sipa says, reporting that you ran the automated tests gives little additional information, since we run all those tests in a CI for every pull. If you notice something unusual about the behaviour in the tests, or you've run more extensive manual testing, then that's much more useful for the PR author and maintainers. 18:03 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has quit [Read error: Connection reset by peer] 18:04 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-pr-reviews 18:05 -!- foxp2 [~foxp2@ec2-3-229-163-177.compute-1.amazonaws.com] has joined #bitcoin-core-pr-reviews 18:05 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds] 18:17 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 256 seconds] 18:31 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 18:40 -!- meshcollider [meshcollid@gateway/shell/ircnow/x-xliniymokasdrgzf] has quit [Ping timeout: 256 seconds] 18:41 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 18:43 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 18:46 < midnight> sipa: er. http://bitcoin.sipa.be/speed-lin-10k.png updated? 18:46 < midnight> Bunch of people are lying about hashrate and your graphs I think might be the only reliable ones left. 18:47 < sipa> should be up to date 18:47 < sipa> lup to block 60026 18:48 < sipa> eh, 630026 18:49 -!- meshcollider [meshcollid@gateway/shell/ircnow/x-bajorfnhlalrgtfx] has joined #bitcoin-core-pr-reviews 18:51 < midnight> sipa: your graphs are showing basically no drop in hashrate? Any chance you could tag the graph with the block it's included? I'd stop bugging you unnecessarily then. People are saying there's about a 20% drop in hashrate but your graphs aren't showing it. 18:52 < midnight> (Not just rando idiots but.. like gmax said that in another channel.) 18:53 < midnight> or maybe I should be looking here instead: http://bitcoin.sipa.be/speed-lin-2k.png 18:53 < sipa> my graphs are really not reliably below the 3 days average 18:53 < sipa> they're just too volatile 18:53 < sipa> so it's way too early to say something about that now 19:00 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection] 19:00 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 19:03 -!- foxp2 [~foxp2@ec2-3-229-163-177.compute-1.amazonaws.com] has quit [Quit: \/\/] 19:19 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 19:22 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 258 seconds] 19:37 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 19:38 -!- shesek [~shesek@185.3.145.28] has joined #bitcoin-core-pr-reviews 19:38 -!- shesek [~shesek@185.3.145.28] has quit [Changing host] 19:38 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-pr-reviews 19:40 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 19:59 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 260 seconds] 20:01 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 21:19 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 21:23 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 21:23 -!- vasild_ is now known as vasild 21:46 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 21:59 -!- jesseposner [~jesseposn@c-67-188-220-154.hsd1.ca.comcast.net] has quit [Ping timeout: 256 seconds] 22:01 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 22:02 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-pr-reviews 23:02 -!- jesseposner [~jesseposn@c-67-188-220-154.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 23:26 -!- jesseposner [~jesseposn@c-67-188-220-154.hsd1.ca.comcast.net] has quit [Ping timeout: 272 seconds]