--- Day changed Fri May 15 2020 00:30 -!- sr_gi [~sr_gi@183.red-83-34-186.dynamicip.rima-tde.net] has joined #bitcoin-core-pr-reviews 03:03 -!- Ruthie84Tromp [~Ruthie84T@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-pr-reviews 03:04 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has joined #bitcoin-core-pr-reviews 03:15 -!- Ruthie84Tromp [~Ruthie84T@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 260 seconds] 04:03 < raj_149> hi jnewbery: Regarding my query for debuging rpc calls. the --noshutdown flag not seem to be solving the purppose. The RPC is still getting timed out and by giving --noshutdown the test simply kept the nodes running, thats it. So any idea how can i tell the test not panic if i take time debuging the callback? 04:52 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Remote host closed the connection] 04:53 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-pr-reviews 05:25 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-pr-reviews 05:44 < raj_149> It seems there is no direct way to disable rpc_timeout in testframework. What do people use while debugging RPC callbacks? I can increase the timeout, but was wondering if theres any other way. 05:45 -!- troygiorshev [~troy@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-pr-reviews 06:19 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 06:22 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has quit [Quit: Leaving] 06:54 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 265 seconds] 06:55 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 07:00 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [Ping timeout: 265 seconds] 07:03 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-pr-reviews 07:16 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has joined #bitcoin-core-pr-reviews 07:33 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 07:37 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 264 seconds] 07:39 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 07:42 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 272 seconds] 08:05 -!- meshcollider [meshcollid@gateway/shell/ircnow/x-bajorfnhlalrgtfx] has quit [Ping timeout: 272 seconds] 08:06 -!- meshcollider [meshcollid@gateway/shell/ircnow/x-ekbwjdyjnyhvfhjb] has joined #bitcoin-core-pr-reviews 08:10 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 240 seconds] 08:11 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-pr-reviews 08:15 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 240 seconds] 08:19 -!- shesek [~shesek@185.3.145.28] has joined #bitcoin-core-pr-reviews 08:19 -!- shesek [~shesek@185.3.145.28] has quit [Changing host] 08:19 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-pr-reviews 08:24 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 265 seconds] 08:28 -!- shesek [~shesek@185.3.145.28] has joined #bitcoin-core-pr-reviews 08:28 -!- shesek [~shesek@185.3.145.28] has quit [Changing host] 08:28 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-pr-reviews 08:54 < ryanofsky> raj_149, I use 'self.rpc_timeout = 60 if not os.environ.get("NOTIME") else 999999' and 'BITCOIND_PROC_WAIT_TIMEOUT = 60 if not os.environ.get("NOTIME") else 999999' locally 08:55 < ryanofsky> it would be nice if it was disabling timeouts was supported out of the box though, especially annoying with gdb 09:13 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 260 seconds] 09:18 -!- jonatack [~jon@134.19.179.163] has joined #bitcoin-core-pr-reviews 09:23 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 09:24 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 09:43 -!- troygiorshev [~troy@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Ping timeout: 265 seconds] 09:46 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 09:48 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 09:48 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-pr-reviews 09:49 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-pr-reviews 09:51 -!- troygiorshev [~troy@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-pr-reviews 09:56 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 10:14 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-pr-reviews 11:38 < jnewbery> Also try using the new `--factor` setting that was added recently. I haven't actually attached gdb to a running functional test node for a very long time, so this isn't a problem that I've had to deal with myself. 11:47 < raj_149> I tried disabling rpc_timout optionally, but that value is being used in many other places and disabling it breaks many things, specially in the TestNode class. So probably it cant be disabled without removing those dependencies in some way. for now my purpose got solved by just increasing the timeout. good enough for small assesments. 12:00 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 12:03 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 12:06 < raj_149> ryanofsky thanks for the idea. Infact i now that i am thinking, i was doing it wrong. Instead of disabling i could have just set it to a higher value, and now the testcode works like a charm with a '--notimeout' flag. 12:09 < raj_149> jnewbery: the change is pretty small, and an addition of a new flag. Is that something should be available in core, does many people face this issue? 12:28 -!- gleb [~gleb@cpe-67-244-100-77.nyc.res.rr.com] has joined #bitcoin-core-pr-reviews 12:29 -!- troygiorshev [~troy@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Quit: leaving] 12:48 -!- seven_ [~seven@2a00:ee2:410c:1300:a8da:e0f4:e265:eaa8] has joined #bitcoin-core-pr-reviews 13:36 -!- seven_ [~seven@2a00:ee2:410c:1300:a8da:e0f4:e265:eaa8] has quit [Read error: Connection reset by peer] 13:47 < jnewbery> raj_149: seems like it may be useful to others 13:48 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-pr-reviews 13:51 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 14:00 -!- kristapsk_ is now known as kristapsk 15:10 -!- mol_ [~mol@unaffiliated/molly] has quit [Read error: Connection reset by peer] 15:37 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-pr-reviews 15:41 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has left #bitcoin-core-pr-reviews ["Leaving"] 15:57 -!- gimballock [b8a4b1b9@d-184-164-177-185.fl.cpe.atlanticbb.net] has joined #bitcoin-core-pr-reviews 15:59 -!- gimballock [b8a4b1b9@d-184-164-177-185.fl.cpe.atlanticbb.net] has left #bitcoin-core-pr-reviews [] 15:59 -!- gimballock [b8a4b1b9@d-184-164-177-185.fl.cpe.atlanticbb.net] has joined #bitcoin-core-pr-reviews 16:09 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has quit [Read error: Connection reset by peer] 16:24 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 16:50 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-lrnsjvfkedukqqhl] has quit [Quit: Connection closed for inactivity] 17:34 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 18:02 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-pr-reviews 18:02 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 18:04 -!- jonatack [~jon@134.19.179.163] has quit [Ping timeout: 264 seconds] 18:05 -!- gimballock [b8a4b1b9@d-184-164-177-185.fl.cpe.atlanticbb.net] has quit [Remote host closed the connection] 18:06 -!- jonatack [~jon@37.173.34.185] has joined #bitcoin-core-pr-reviews 19:16 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 256 seconds] 19:41 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 20:59 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 265 seconds] 21:02 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 21:20 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 21:23 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 21:23 -!- vasild_ is now known as vasild 23:41 < raj_149> jnewbery: ryanofsky went ahead and opened a PR https://github.com/bitcoin/bitcoin/pull/18986