--- Day changed Sat May 16 2020 00:10 -!- illlicit_ [uid109953@gateway/web/irccloud.com/x-ibdbevameseloudg] has quit [Quit: Connection closed for inactivity] 01:14 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-rqvyjjlwqqisisoh] has joined #bitcoin-core-pr-reviews 02:30 -!- jonatack [~jon@37.173.34.185] has quit [Ping timeout: 256 seconds] 02:32 -!- jonatack [~jon@213.152.161.239] has joined #bitcoin-core-pr-reviews 02:46 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-pr-reviews 02:56 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-pr-reviews 03:03 -!- Perry24Boyer [~Perry24Bo@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-pr-reviews 03:10 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has joined #bitcoin-core-pr-reviews 03:16 -!- Perry24Boyer [~Perry24Bo@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 246 seconds] 03:24 -!- dfmbbtc [~dfmb_@unaffiliated/dfmb/x-4009105] has joined #bitcoin-core-pr-reviews 03:28 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has quit [Ping timeout: 260 seconds] 03:49 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 03:50 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-pr-reviews 04:19 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 04:22 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 272 seconds] 06:02 -!- jonatack [~jon@213.152.161.239] has quit [Ping timeout: 240 seconds] 06:05 -!- jonatack [~jon@37.173.217.56] has joined #bitcoin-core-pr-reviews 06:07 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 265 seconds] 06:33 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 06:41 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 06:41 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 06:44 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 06:47 -!- sr_gi_ [~sr_gi@183.red-83-34-186.dynamicip.rima-tde.net] has joined #bitcoin-core-pr-reviews 06:47 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 258 seconds] 06:49 -!- sr_gi [~sr_gi@183.red-83-34-186.dynamicip.rima-tde.net] has quit [Ping timeout: 260 seconds] 06:55 -!- sr_gi [~sr_gi@183.red-83-34-186.dynamicip.rima-tde.net] has joined #bitcoin-core-pr-reviews 06:58 -!- sr_gi_ [~sr_gi@183.red-83-34-186.dynamicip.rima-tde.net] has quit [Ping timeout: 258 seconds] 07:26 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 265 seconds] 08:00 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 09:11 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 09:12 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 09:23 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 09:24 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 11:29 < raj_149> While i was looking through the testing utilities available, i found theres a bunch of spelling mistakes all over the code base which can be caught with test/lint-spelling.sh. Is there value in fixing them? 11:34 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 11:36 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 260 seconds] 11:39 < gwillen> raj_149: my assumption has been that it uses the local dictionary, so probably it gets run by the continuous build server with a different dictionary than the one on my local system, and passes there 11:39 < gwillen> so I tend to ignore the spelling mistakes that come up in lint unless I introduced them 11:39 -!- lukedashjr is now known as luke-jr 12:09 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Quit: pinheadmz] 12:48 < raj_149> gwillen: some these mistakes does looks like typos. Also i was looking into the travis build of my own PR, and it seems travis also found those as spelling bugs but decided not to throw error on them. Not sure whats happening there. 13:37 < gwillen> oh, huh, I guess Travis ignores them? Anyway I agree some of them are clearly typos, I'm not sure what the policy is on fixing them -- if you make a PR fixing all the typos at once, I expect it would probably get merged. 13:40 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-pr-reviews 15:12 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 256 seconds] 15:14 -!- dfmbbtc [~dfmb_@unaffiliated/dfmb/x-4009105] has quit [Read error: Connection reset by peer] 15:19 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 15:20 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 15:41 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 272 seconds] 15:42 -!- shesek [~shesek@185.3.145.28] has joined #bitcoin-core-pr-reviews 15:42 -!- shesek [~shesek@185.3.145.28] has quit [Changing host] 15:42 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-pr-reviews 15:46 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 15:47 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 264 seconds] 15:51 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-pr-reviews 15:52 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-pr-reviews 15:55 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 240 seconds] 15:57 -!- shesek [~shesek@185.3.145.28] has joined #bitcoin-core-pr-reviews 15:57 -!- shesek [~shesek@185.3.145.28] has quit [Changing host] 15:57 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-pr-reviews 16:01 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 256 seconds] 16:07 -!- shesek [~shesek@185.3.145.28] has joined #bitcoin-core-pr-reviews 16:07 -!- shesek [~shesek@185.3.145.28] has quit [Changing host] 16:07 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-pr-reviews 16:12 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 272 seconds] 16:16 -!- shesek [~shesek@185.3.145.28] has joined #bitcoin-core-pr-reviews 16:16 -!- shesek [~shesek@185.3.145.28] has quit [Changing host] 16:16 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-pr-reviews 16:48 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 16:51 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 258 seconds] 16:57 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 17:06 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 17:13 < jonatack> raj_149: i see them too when running the linter locally and also in the travis builds. these aren't a priority. 17:15 < jonatack> raj_149: i fix typos if i'm already touching nearby code for something else but don't give them a separate commit or pr... ymmv 17:20 -!- mol [~mol@unaffiliated/molly] has quit [Read error: Connection reset by peer] 17:21 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 17:56 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 246 seconds] 18:00 -!- jonatack_ [~jon@37.165.91.121] has joined #bitcoin-core-pr-reviews 18:04 -!- jonatack [~jon@37.173.217.56] has quit [Ping timeout: 265 seconds] 18:04 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 18:07 -!- sr_gi [~sr_gi@183.red-83-34-186.dynamicip.rima-tde.net] has quit [Read error: Connection reset by peer] 18:07 -!- sr_gi_ [~sr_gi@183.red-83-34-186.dynamicip.rima-tde.net] has joined #bitcoin-core-pr-reviews 19:31 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has quit [Ping timeout: 252 seconds] 19:43 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has joined #bitcoin-core-pr-reviews 21:16 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Remote host closed the connection] 21:20 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 21:23 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 21:23 -!- vasild_ is now known as vasild 21:32 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-pr-reviews 21:34 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 21:35 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-pr-reviews 22:34 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 22:37 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 265 seconds] 23:29 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has joined #bitcoin-core-pr-reviews 23:29 -!- dfmb__ [~dfmb_@unaffiliated/dfmb/x-4009105] has joined #bitcoin-core-pr-reviews 23:30 -!- dfmb__ [~dfmb_@unaffiliated/dfmb/x-4009105] has quit [Client Quit] 23:30 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has quit [Client Quit] 23:56 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has joined #bitcoin-core-pr-reviews