--- Day changed Sat May 23 2020 00:16 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Remote host closed the connection] 00:20 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-pr-reviews 00:55 -!- slivera [~slivera@116.206.228.203] has joined #bitcoin-core-pr-reviews 00:55 -!- slivera [~slivera@116.206.228.203] has quit [Remote host closed the connection] 01:02 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Remote host closed the connection] 02:18 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has joined #bitcoin-core-pr-reviews 03:03 -!- Samara72Bosco [~Samara72B@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-pr-reviews 03:12 -!- Samara72Bosco [~Samara72B@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 256 seconds] 03:56 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 03:59 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 258 seconds] 04:01 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 04:04 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 265 seconds] 04:57 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 258 seconds] 06:15 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-pr-reviews 07:01 -!- sr_gi_ [~sr_gi@183.red-83-34-186.dynamicip.rima-tde.net] has joined #bitcoin-core-pr-reviews 07:03 -!- sr_gi [~sr_gi@183.red-83-34-186.dynamicip.rima-tde.net] has quit [Ping timeout: 265 seconds] 07:58 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 08:01 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 08:05 < raj_149> I need some rookie help. I cant seem to log from bitcoind. I am using LogPrintf(), following the debugging doc. Passing -debug=1 in extra_args[] from functional test. Its just not logging in debug.log. been trying for hours. Any idea what i might be missing? 08:08 < jonatack> Notes and questions for next Wednesday's session are up at https://bitcoincore.reviews/19055 08:08 < jonatack> "Calculate UTXO set hash using Muhash" (utils/log/libs) by sipa / fjahr, hosted by fjahr 08:12 < jonatack> raj_149: LogPrintf doesn't have anything to do with extra_args in functional tests. To see how to use LogPrintf, run this on the command line: git grep LogPrintf 08:13 < jonatack> raj_149: don't forget that you need to re- 08:14 < jonatack> compile any parts of the codebase where you added LogPrintfs and restart bitcoind 08:14 < jonatack> from /src and not from root 08:31 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Remote host closed the connection] 08:42 < jnewbery> raj_149 are you sure you're checking the correct debug.log file? Try running combine_logs.py after the test to get a combined view of all the log files. 08:58 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 09:20 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 09:23 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 09:23 -!- vasild_ is now known as vasild 09:46 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-pr-reviews 09:55 -!- sr_gi_ [~sr_gi@183.red-83-34-186.dynamicip.rima-tde.net] has quit [Remote host closed the connection] 10:11 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 260 seconds] 10:11 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 10:18 -!- pinheadm_ [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-pr-reviews 10:22 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Ping timeout: 260 seconds] 11:01 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-pr-reviews 11:54 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Remote host closed the connection] 13:29 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-pr-reviews 13:57 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 14:04 -!- sr_gi [~sr_gi@183.red-83-34-186.dynamicip.rima-tde.net] has joined #bitcoin-core-pr-reviews 14:31 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Quit: ZNC 1.7.5 - https://znc.in] 14:33 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-pr-reviews 15:21 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has quit [Read error: Connection reset by peer] 15:42 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Remote host closed the connection] 16:21 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-pr-reviews 16:38 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 16:39 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-pr-reviews 17:21 -!- shesek [~shesek@185.3.145.28] has quit [Changing host] 17:21 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-pr-reviews 17:32 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-pr-reviews 17:33 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer] 17:36 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Remote host closed the connection] 18:06 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 18:06 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-pr-reviews 18:24 -!- tryphe_ is now known as tryphe 18:54 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 18:57 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 19:05 -!- soju [uid403160@gateway/web/irccloud.com/x-hevkxsdewzznqpza] has quit [Quit: Connection closed for inactivity] 19:37 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-pr-reviews 19:39 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 19:39 -!- shesek [~shesek@185.3.145.28] has joined #bitcoin-core-pr-reviews 19:42 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Ping timeout: 256 seconds] 19:58 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 20:38 < luke-jr> [18:13:54] Certainly there's been disagreement, but the opposition to it has changed over time. Luke originally seemed to be fine with adding BIP 157 support behind a flag: https://github.com/bitcoin/bitcoin/pull/16442#issuecomment-522805991[18:13:54] Certainly there's been disagreement, but the opposition to it has changed over time. Luke originally seemed to be fine with adding BIP 157 support behind a flag: 20:38 < luke-jr> https://github.com/bitcoin/bitcoin/pull/16442#issuecomment-522805991 <-- no, all I said was that it definitely needed a flag 20:39 < luke-jr> in answer to a question IIRC 20:40 < luke-jr> I did postpone judgement initially, but I never said I was okay with it 20:41 < luke-jr> in absence of any convincing arguments in favour of it, and in light of Neutrino proponents pushing it in very harmful ways, I came to the conclusion it shouldn't get merged 20:42 < luke-jr> I could perhaps be convinced otherwise, but that's where I stand still 21:06 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has left #bitcoin-core-pr-reviews [] 21:23 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 21:30 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 21:50 -!- rjected [~dan@pool-71-184-77-198.bstnma.fios.verizon.net] has quit [Ping timeout: 264 seconds] 22:04 -!- rjected [~dan@pool-71-184-77-198.bstnma.fios.verizon.net] has joined #bitcoin-core-pr-reviews 22:17 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-pr-reviews 22:38 -!- shesek [~shesek@185.3.145.28] has quit [Changing host] 22:38 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-pr-reviews 23:32 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Remote host closed the connection] 23:35 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Quit: ZNC 1.7.5 - https://znc.in] 23:37 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-pr-reviews 23:55 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has joined #bitcoin-core-pr-reviews 23:57 -!- tarboss [4fe5263f@gateway/web/cgi-irc/kiwiirc.com/ip.79.229.38.63] has joined #bitcoin-core-pr-reviews 23:58 -!- tarboss [4fe5263f@gateway/web/cgi-irc/kiwiirc.com/ip.79.229.38.63] has quit [Client Quit]