--- Day changed Fri May 29 2020 00:41 -!- as_pnn [~pierreirc@119.192.247.147] has quit [Quit: killed] 00:44 -!- as_pnn [~pierreirc@119.192.247.147] has joined #bitcoin-core-pr-reviews 01:21 -!- kristapsk_ is now known as kristapsk 01:55 -!- provoostenator_ [~quassel@provoostenator.sprovoost.nl] has joined #bitcoin-core-pr-reviews 01:59 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has quit [Remote host closed the connection] 02:21 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 260 seconds] 02:31 -!- provoostenator_ [~quassel@provoostenator.sprovoost.nl] has quit [Remote host closed the connection] 02:32 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has joined #bitcoin-core-pr-reviews 03:03 -!- Franz31Hermann [~Franz31He@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-pr-reviews 03:08 -!- Franz31Hermann [~Franz31He@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 256 seconds] 03:16 -!- shaunsun_ [~shaunsun@c-76-26-29-34.hsd1.fl.comcast.net] has joined #bitcoin-core-pr-reviews 03:16 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-pr-reviews 03:18 -!- shaunsun__ [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has joined #bitcoin-core-pr-reviews 03:21 -!- shaunsun_ [~shaunsun@c-76-26-29-34.hsd1.fl.comcast.net] has quit [Ping timeout: 258 seconds] 03:38 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Quit: Leaving] 03:53 -!- shaunsun__ [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has quit [Quit: Leaving] 04:12 -!- slivera_ [~slivera@110-175-83-113.static.tpgi.com.au] has joined #bitcoin-core-pr-reviews 04:15 -!- slivera [~slivera@103.231.88.27] has quit [Ping timeout: 260 seconds] 04:28 -!- slivera__ [~slivera@103.231.88.10] has joined #bitcoin-core-pr-reviews 04:31 -!- slivera_ [~slivera@110-175-83-113.static.tpgi.com.au] has quit [Ping timeout: 240 seconds] 05:15 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-pr-reviews 05:35 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has quit [Remote host closed the connection] 05:36 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has joined #bitcoin-core-pr-reviews 05:46 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has quit [Remote host closed the connection] 06:02 -!- seven_ [~seven@2a00:ee2:410c:1300:4824:f3c0:fbd4:bec] has joined #bitcoin-core-pr-reviews 06:24 -!- slivera__ [~slivera@103.231.88.10] has quit [Ping timeout: 272 seconds] 06:25 < jnewbery> One of my goals for review club was to have a cover a wide range of PRs, both in terms of components covered and complexity/difficulty of PR. 06:26 < jnewbery> I was wondering whether it might be a good idea to tag PRs with beginner/intermediate/advanced, so it's obvious what to expect ahead of the meeting. 06:26 < jnewbery> And to explicitly target how often we cover PRs at the different levels (eg 1 beginner, 2 intermediate, 1 advanced per month). 06:26 < jnewbery> The only downside I see is that people might be put off coming to meetings for PRs at a level they don't think is right for them, even though they might be able to learn/contribute. 06:26 < jnewbery> What does everyone else think? 06:28 < jnewbery> As always, if you have any other ideas about how we can improve review club or make the meetings more useful, please share them here or message me directly. 06:53 -!- waxwing_ is now known as waxwing 06:53 -!- waxwing [~waxwing@193.29.57.116] has quit [Changing host] 06:53 -!- waxwing [~waxwing@unaffiliated/waxwing] has joined #bitcoin-core-pr-reviews 07:55 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has quit [Quit: The Lounge - https://thelounge.chat] 08:12 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-pr-reviews 08:21 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has joined #bitcoin-core-pr-reviews 08:21 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has quit [Client Quit] 08:31 < brikk> jnewbery: i think it might be worth a try for a month and see if the beginner intermediate tags attract more/new people but also see if less people come for the advanced 08:32 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has joined #bitcoin-core-pr-reviews 08:32 < brikk> i think the beginner one could be a good way to onboard newcomers and lower the bar 08:44 < aj> maybe could be more "complexity" level? highly-complex wallet change, vs a simple validation change? then even experts could use it to get an idea how much time/effort it might take? 08:46 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has quit [Remote host closed the connection] 08:49 < MarcoFalke> jnewbery: When I was hosting, I tried to cover discussion points of different difficulties in the same meeting. I.e. have some beginner questions/discussion, but then go on to harder stuff. So everyone is welcome to join and can participate in the beginning, but some might turn idle as complexity grows ... 09:05 -!- MarcoFalke [~none@198.12.116.246] has quit [Ping timeout: 256 seconds] 09:08 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has joined #bitcoin-core-pr-reviews 09:09 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-pr-reviews 09:20 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 09:24 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 09:24 -!- vasild_ is now known as vasild 09:43 -!- Kane67Borer [~Kane67Bor@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-pr-reviews 09:52 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-pr-reviews 09:55 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 09:55 < sipa> fjahr: i think it would be useful to see if truncated SHA512 is still preferable over SHA256 on common platforms 09:59 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Ping timeout: 240 seconds] 10:05 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 10:06 -!- Kane67Borer [~Kane67Bor@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 265 seconds] 10:12 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Ping timeout: 258 seconds] 10:21 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-pr-reviews 10:22 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 10:24 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 258 seconds] 10:32 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-pr-reviews 10:53 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Quit: Lost terminal] 10:54 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-pr-reviews 11:18 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Ping timeout: 272 seconds] 11:33 -!- kristapsk_ is now known as kristapsk 11:38 -!- troygiorshev [~troygiors@72.139.204.106] has joined #bitcoin-core-pr-reviews 11:40 < jnewbery> MacoFalke: Yes, that should always be the case: start with basic discussion and get into more complexity/nuance through the hour 11:41 < jnewbery> However, there are some PRs where it's very difficult to even get started if you don't have some context already, and some PRs that don't offer much interest to contributors who have been involved for a while. I think ideally we'd cover both. 11:42 -!- MarcoFalke [~none@198.12.116.246] has joined #bitcoin-core-pr-reviews 11:43 < jnewbery> I'm not suggesting that we stop trying to make meetings welcoming/interesting for people of different experience levels, just that we recognise that different PRs have different complexities and explicitly target a mix of those 11:44 < jnewbery> aj: I'm not sure I follow. I think even a 'simple' validation change requires a lot of contextual knowledge. The code delta might not be complex, but the concepts required to determine whether it's a safe change definitely are 11:45 < jnewbery> brikk: yes, the idea of PR Review Club is to onboard newcomers and lower the bar :) 11:48 < sipa> jnewbery: there are also different levels of review; "does this change not affect behavior" or "is this safe" is very different from "is this a good idea" 11:48 < sipa> the latter may require far more context, and be inaccessible to people who are still interested in learning how to review for the former 11:55 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 11:55 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-pr-reviews 11:58 < jnewbery> sipa: indeed! And that's something that we should try to communicate to attendees 12:00 < jnewbery> For the difficulty scale idea, I was thinking more for being able to assess the former (is it safe/ does it change behaviour?) The latter (is it a good idea?) I think just takes experience and familiarity with the system 12:07 -!- troygiorshev [~troygiors@72.139.204.106] has quit [Ping timeout: 246 seconds] 12:09 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-pr-reviews 12:10 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Client Quit] 12:11 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-pr-reviews 12:11 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Client Quit] 12:15 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-pr-reviews 12:15 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 12:19 -!- kristapsk_ is now known as kristapsk 13:08 < aj> jnewbery: i guess i think that a beginner can find at least watching other people review a complex proposal helpful, and for experienced people going through a straight forward pr can be comparatively relaxing? some of the refactors to validation/script should be okay for beginners to review, even if they don't get all of the context that ends up mattering? 13:16 -!- shesek [~shesek@185.3.145.28] has joined #bitcoin-core-pr-reviews 13:16 -!- shesek [~shesek@185.3.145.28] has quit [Changing host] 13:16 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-pr-reviews 13:20 < jonatack> sipa: I really like that concept of different level of review. It's very true. I hope you don't mind if I try to communicate it in my continually updated article about reviewing (which is basically me taking notes for myself and anyone else who wishes to benefit from it). 13:21 < sipa> of course not 13:21 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 260 seconds] 13:22 < jonatack> 👍 13:25 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 13:26 -!- shesek [~shesek@185.3.145.28] has joined #bitcoin-core-pr-reviews 13:26 -!- shesek [~shesek@185.3.145.28] has quit [Changing host] 13:26 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-pr-reviews 13:27 < fjahr> jnewbery: I am a bit sceptical of the full scale because I think even PRs with a complex implementation can be ok for bitcoin core code base beginners to review for a concept ack and they are learning from it either way of course. But it makes sense to watch for a good balance. And I do see the appeal of a "good first review" label where the PRs are fairly simple. 13:28 < fjahr> sipa: ok, will test it 13:31 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 260 seconds] 13:33 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Ping timeout: 258 seconds] 13:34 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-pr-reviews 13:34 -!- shesek [~shesek@185.3.145.28] has joined #bitcoin-core-pr-reviews 13:34 -!- shesek [~shesek@185.3.145.28] has quit [Changing host] 13:34 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-pr-reviews 13:39 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 260 seconds] 13:42 -!- shesek [~shesek@185.3.145.28] has joined #bitcoin-core-pr-reviews 13:42 -!- shesek [~shesek@185.3.145.28] has quit [Changing host] 13:42 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-pr-reviews 13:46 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 260 seconds] 13:47 -!- shesek [~shesek@185.3.145.28] has joined #bitcoin-core-pr-reviews 13:47 -!- shesek [~shesek@185.3.145.28] has quit [Changing host] 13:47 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-pr-reviews 13:52 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 260 seconds] 13:55 -!- shesek [~shesek@185.3.145.28] has joined #bitcoin-core-pr-reviews 13:55 -!- shesek [~shesek@185.3.145.28] has quit [Changing host] 13:55 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-pr-reviews 14:00 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 260 seconds] 14:03 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-pr-reviews 14:07 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 260 seconds] 14:09 -!- shesek [~shesek@185.3.145.28] has joined #bitcoin-core-pr-reviews 14:09 -!- shesek [~shesek@185.3.145.28] has quit [Changing host] 14:09 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-pr-reviews 14:14 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 260 seconds] 14:15 -!- shesek [~shesek@185.3.145.28] has joined #bitcoin-core-pr-reviews 14:15 -!- shesek [~shesek@185.3.145.28] has quit [Changing host] 14:15 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-pr-reviews 14:19 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 260 seconds] 14:22 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-pr-reviews 14:27 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 260 seconds] 14:30 -!- shesek [~shesek@185.3.145.28] has joined #bitcoin-core-pr-reviews 14:30 -!- shesek [~shesek@185.3.145.28] has quit [Changing host] 14:30 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-pr-reviews 14:35 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 260 seconds] 14:36 -!- shesek [~shesek@185.3.145.28] has joined #bitcoin-core-pr-reviews 14:36 -!- shesek [~shesek@185.3.145.28] has quit [Changing host] 14:36 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-pr-reviews 14:40 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 260 seconds] 14:43 -!- shesek [~shesek@185.3.145.28] has joined #bitcoin-core-pr-reviews 14:43 -!- shesek [~shesek@185.3.145.28] has quit [Changing host] 14:43 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-pr-reviews 14:48 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 260 seconds] 14:51 -!- shesek [~shesek@185.3.145.28] has joined #bitcoin-core-pr-reviews 14:51 -!- shesek [~shesek@185.3.145.28] has quit [Changing host] 14:51 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-pr-reviews 14:56 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 260 seconds] 14:59 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-pr-reviews 15:03 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 260 seconds] 15:06 -!- shesek [~shesek@185.3.145.28] has joined #bitcoin-core-pr-reviews 15:06 -!- shesek [~shesek@185.3.145.28] has quit [Changing host] 15:06 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-pr-reviews 15:08 -!- slivera [~slivera@103.231.88.27] has joined #bitcoin-core-pr-reviews 15:11 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 260 seconds] 15:14 -!- shesek [~shesek@185.3.145.28] has joined #bitcoin-core-pr-reviews 15:14 -!- shesek [~shesek@185.3.145.28] has quit [Changing host] 15:14 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-pr-reviews 15:33 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 15:38 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-pr-reviews 15:44 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 264 seconds] 16:57 -!- pinheadm_ [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-pr-reviews 17:01 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Ping timeout: 272 seconds] 17:10 -!- pinheadm_ [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Ping timeout: 272 seconds] 17:16 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-pr-reviews 18:46 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-pr-reviews 18:49 -!- slivera [~slivera@103.231.88.27] has quit [Remote host closed the connection] 19:25 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Read error: Connection reset by peer] 19:28 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-pr-reviews 20:33 -!- slivera [~slivera@103.231.88.10] has joined #bitcoin-core-pr-reviews 21:20 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 21:24 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 21:24 -!- vasild_ is now known as vasild 21:38 -!- yojoots [~justin@2600:1700:19e0:4b10:d84a:bd97:7a44:67ab] has quit [Ping timeout: 260 seconds] 21:39 -!- yojoots [~justin@2600:1700:19e0:4b10:8c9:5a78:b065:b884] has joined #bitcoin-core-pr-reviews 21:41 -!- yojoots [~justin@2600:1700:19e0:4b10:8c9:5a78:b065:b884] has quit [Remote host closed the connection] 23:07 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds] 23:10 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-pr-reviews 23:11 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-pr-reviews 23:11 -!- slivera [~slivera@103.231.88.10] has quit [Remote host closed the connection]