--- Day changed Fri Jun 05 2020 00:57 -!- vindard [~vindard@190.83.165.233] has joined #bitcoin-core-pr-reviews 01:24 -!- vindard [~vindard@190.83.165.233] has quit [Quit: No Ping reply in 180 seconds.] 01:26 -!- vindard [~vindard@190.83.165.233] has joined #bitcoin-core-pr-reviews 01:35 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 02:11 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 02:21 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-pr-reviews 02:25 -!- vindard [~vindard@190.83.165.233] has quit [Ping timeout: 260 seconds] 02:27 -!- vindard [~vindard@190.83.165.233] has joined #bitcoin-core-pr-reviews 03:03 -!- Adrianna24Stolte [~Adrianna2@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-pr-reviews 03:08 -!- Adrianna24Stolte [~Adrianna2@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 246 seconds] 03:14 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has joined #bitcoin-core-pr-reviews 04:21 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Quit: jonatack] 04:39 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-pr-reviews 05:23 -!- Isadore62Daniel [~Isadore62@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-pr-reviews 05:39 -!- Isadore62Daniel [~Isadore62@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 272 seconds] 05:57 -!- slivera [~slivera@103.231.88.28] has quit [Remote host closed the connection] 07:16 -!- vindard [~vindard@190.83.165.233] has quit [Read error: Connection reset by peer] 07:20 -!- vindard [~vindard@190.83.165.233] has joined #bitcoin-core-pr-reviews 07:46 -!- davterra [~dulyNoded@104.140.18.131] has joined #bitcoin-core-pr-reviews 08:15 < pinheadmz> something that might be fun to address some time is what happens after a PR is reviewed - who decides it gets merged and when and how? and like literally - do we use the github webflow tools or do maintainers merge locally and push? etc 08:58 < jonatack> pinheadmz: PRs are merged using https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/master/github-merge.py 08:58 < jonatack> see also https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/master/README.md 09:01 < jonatack> I think one aspect of reviewing that is underappreciated is the amount of re-reviewing that is often needed. It's not unusual to re-review a PR 2-4 times. 09:02 < jonatack> We're now up to 380 open PRs and more PRs in the "High-priority for review" list than I can recall seeing before: https://github.com/bitcoin/bitcoin/projects/8 09:07 < jonatack> Last month I reviewed roughly 50 PRs in bitcoin core, including most of the high-priority ones, and opened 1 new PR... but the number to review keeps growing and the high-prio list is too long now 09:11 < jonatack> ISTM if everyone respected a ratio of 5-15 reviews per PR opened, the situation might improve and things might progress faster. 09:11 < jonatack> ;) 09:19 < michaelfolkson> Yeah I do wonder whether learning how to be maintainer is only needed once you have reviewed as many PRs as jonatack has ;) 09:20 < michaelfolkson> I certainly don't feel the need to learn how to be a maintainer at this point 09:20 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 09:21 < michaelfolkson> Maybe it would be useful for educating the community on the thought process of a maintainer. But the reality is very few of us will ever become maintainers 09:23 < jonatack> michaelfolkson: heh :) i have no pretension of being a good/great reviewer of this codebase yet; it takes time. but everyone who consistently review and test PRs, issues, release candidates, build gitian sigs is being really helpful. 09:23 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 09:23 < jonatack> all of that is scarce. 09:23 -!- vasild_ is now known as vasild 09:25 < jonatack> p2p people: #19109 looks interesting to review 09:36 -!- seven__ [~seven@2a00:ee2:410c:1300:3162:6f2d:1df9:de8b] has joined #bitcoin-core-pr-reviews 09:39 -!- seven_ [~seven@2a00:ee2:410c:1300:3162:6f2d:1df9:de8b] has quit [Ping timeout: 246 seconds] 10:00 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has quit [Quit: Leaving] 10:02 < pinheadmz> thanks guys 10:46 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Quit: leaving] 10:49 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-pr-reviews 11:20 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Quit: leaving] 11:21 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-pr-reviews 11:24 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Client Quit] 11:25 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-pr-reviews 12:09 -!- meshcoll- [meshcollid@gateway/shell/ircnow/x-jmtxdaapnvwvysok] has quit [Quit: ZNC 1.7.4 - https://znc.in] 12:10 -!- meshcollider [meshcollid@gateway/shell/ircnow/x-jaqsmospkdyaosri] has joined #bitcoin-core-pr-reviews 12:41 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has joined #bitcoin-core-pr-reviews 12:45 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-pr-reviews 13:50 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Quit: ZNC 1.7.5 - https://znc.in] 13:51 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 13:51 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-pr-reviews 14:22 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has quit [Quit: Leaving] 14:59 -!- vindard [~vindard@190.83.165.233] has quit [Read error: Connection reset by peer] 15:01 -!- vindard [~vindard@190.83.165.233] has joined #bitcoin-core-pr-reviews 15:07 -!- vindard [~vindard@190.83.165.233] has quit [Read error: Connection reset by peer] 15:11 -!- vindard [~vindard@190.83.165.233] has joined #bitcoin-core-pr-reviews 15:15 -!- takinbo [~takinbo@unaffiliated/takinbo] has quit [Ping timeout: 272 seconds] 15:17 -!- takinbo [~takinbo@merkle.akinbo.org] has joined #bitcoin-core-pr-reviews 15:17 -!- takinbo [~takinbo@merkle.akinbo.org] has quit [Changing host] 15:17 -!- takinbo [~takinbo@unaffiliated/takinbo] has joined #bitcoin-core-pr-reviews 15:29 -!- seven__ [~seven@2a00:ee2:410c:1300:3162:6f2d:1df9:de8b] has quit [Read error: Connection reset by peer] 15:29 -!- takinbo [~takinbo@unaffiliated/takinbo] has quit [Quit: No Ping reply in 180 seconds.] 15:30 -!- takinbo [~takinbo@static.88-198-91-246.clients.your-server.de] has joined #bitcoin-core-pr-reviews 15:30 -!- takinbo [~takinbo@static.88-198-91-246.clients.your-server.de] has quit [Changing host] 15:30 -!- takinbo [~takinbo@unaffiliated/takinbo] has joined #bitcoin-core-pr-reviews 17:49 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 246 seconds] 17:50 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 20:06 -!- pi [~pi@cpe-66-65-53-52.nyc.res.rr.com] has joined #bitcoin-core-pr-reviews 20:10 -!- pi [~pi@cpe-66-65-53-52.nyc.res.rr.com] has left #bitcoin-core-pr-reviews ["WeeChat 2.3"] 20:21 -!- slivera [~slivera@103.231.88.28] has joined #bitcoin-core-pr-reviews 20:33 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-pr-reviews 20:35 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 20:36 -!- shesek [~shesek@185.3.145.28] has joined #bitcoin-core-pr-reviews 20:36 -!- shesek [~shesek@185.3.145.28] has quit [Changing host] 20:36 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-pr-reviews 20:36 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 240 seconds] 21:20 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 21:23 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 21:23 -!- vasild_ is now known as vasild 23:20 -!- tryphe_ is now known as tryphe