--- Day changed Thu Jul 02 2020 00:15 -!- jungly [~jungly@host-80-117-253-7.pool80117.interbusiness.it] has quit [Read error: Connection reset by peer] 00:15 -!- jungly_ [~jungly@host-80-117-253-7.pool80117.interbusiness.it] has joined #bitcoin-core-pr-reviews 00:52 -!- jungly_ [~jungly@host-80-117-253-7.pool80117.interbusiness.it] has quit [Remote host closed the connection] 00:57 -!- jungly [~jungly@host-80-117-253-7.pool80117.interbusiness.it] has joined #bitcoin-core-pr-reviews 02:03 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 02:19 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 02:44 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has joined #bitcoin-core-pr-reviews 02:51 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has quit [Quit: Leaving] 02:54 -!- jungly [~jungly@host-80-117-253-7.pool80117.interbusiness.it] has quit [Read error: Connection reset by peer] 02:54 -!- jungly_ [~jungly@host-80-117-253-7.retail.telecomitalia.it] has joined #bitcoin-core-pr-reviews 03:03 -!- Kelli54Hudson [~Kelli54Hu@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-pr-reviews 03:08 -!- Kelli54Hudson [~Kelli54Hu@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 246 seconds] 03:51 -!- reallll [~belcher@unaffiliated/belcher] has joined #bitcoin-core-pr-reviews 03:55 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 264 seconds] 04:27 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-pr-reviews 04:33 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 04:36 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 04:52 -!- gleb1 [~gleb@159.224.16.138] has joined #bitcoin-core-pr-reviews 04:54 -!- gleb [~gleb@159.224.16.138] has quit [Ping timeout: 240 seconds] 04:54 -!- gleb1 is now known as gleb 05:41 -!- jungly_ [~jungly@host-80-117-253-7.retail.telecomitalia.it] has quit [Read error: Connection reset by peer] 05:41 -!- jungly [~jungly@host-80-117-253-7.pool80117.interbusiness.it] has joined #bitcoin-core-pr-reviews 05:52 -!- reallll is now known as belcher 06:29 -!- seven_ [~seven@2a00:ee2:410c:1300:308f:a467:1e3f:1bbe] has joined #bitcoin-core-pr-reviews 06:34 -!- Davterra [~tralfaz@104.200.129.62] has quit [Ping timeout: 260 seconds] 06:42 -!- Davterra [~tralfaz@104.200.129.57] has joined #bitcoin-core-pr-reviews 06:47 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-pr-reviews 07:00 -!- slivera [~slivera@103.231.88.30] has quit [Remote host closed the connection] 07:32 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-pr-reviews 07:34 -!- jungly [~jungly@host-80-117-253-7.pool80117.interbusiness.it] has quit [Read error: Connection reset by peer] 07:34 -!- jungly [~jungly@host-80-117-253-7.pool80117.interbusiness.it] has joined #bitcoin-core-pr-reviews 08:01 -!- vindard [~vindard@190.83.165.233] has quit [Ping timeout: 246 seconds] 08:05 -!- vindard [~vindard@200.7.91.97] has joined #bitcoin-core-pr-reviews 08:11 -!- dongcarl2 [~dongcarl@unaffiliated/dongcarl] has joined #bitcoin-core-pr-reviews 08:11 -!- dongcarl2 [~dongcarl@unaffiliated/dongcarl] has quit [Client Quit] 08:12 -!- vindard [~vindard@200.7.91.97] has quit [Read error: Connection reset by peer] 08:13 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 08:14 -!- achow101 [~achow101@unaffiliated/achow101] has quit [Ping timeout: 264 seconds] 08:14 -!- TheRec_ [~toto@84-75-225-47.dclient.hispeed.ch] has joined #bitcoin-core-pr-reviews 08:14 -!- TheRec_ [~toto@84-75-225-47.dclient.hispeed.ch] has quit [Changing host] 08:14 -!- TheRec_ [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-pr-reviews 08:14 -!- achow101 [~achow101@unaffiliated/achow101] has joined #bitcoin-core-pr-reviews 08:14 -!- dongcarl [~dongcarl@unaffiliated/dongcarl] has quit [Remote host closed the connection] 08:14 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [Ping timeout: 246 seconds] 08:15 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 264 seconds] 08:16 -!- vindard [~vindard@190.83.165.233] has joined #bitcoin-core-pr-reviews 08:20 -!- dongcarl [~dongcarl@unaffiliated/dongcarl] has joined #bitcoin-core-pr-reviews 08:39 < jonatack> Notes and questions are up for next week's review club on PR #19109 "Only allow getdata of recently announced invs" (p2p). Thanks amiti for hosting! https://bitcoincore.reviews/19109 08:58 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-pr-reviews 09:06 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection] 09:07 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 09:58 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 260 seconds] 10:08 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 10:11 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 258 seconds] 10:29 -!- jonatack [~jon@213.152.162.74] has joined #bitcoin-core-pr-reviews 10:49 -!- jonatack [~jon@213.152.162.74] has quit [Ping timeout: 244 seconds] 10:51 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-pr-reviews 10:58 < raj_> the `CheckTxInputs` inputs returns some error messages, https://github.com/bitcoin/bitcoin/blob/7027c67cac852b27c6d71489e4135fabdd624226/src/consensus/tx_verify.cpp#L174-L176, Where are these messages logged? If i run test/functional/mempool_accept.py with -debug=1 I cant see these messages logged into debug.log. If I am not mistaken memppol_accept test do hits this code path, and some errors should be 10:58 < raj_> written in case of bad tx cases. Am I missing something, or I am looking at wrong place? 11:06 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 11:07 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-pr-reviews 11:08 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Remote host closed the connection] 11:10 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-pr-reviews 11:50 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Quit: pinheadmz] 11:56 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-pr-reviews 11:57 -!- jungly [~jungly@host-80-117-253-7.pool80117.interbusiness.it] has quit [Remote host closed the connection] 12:08 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 12:10 -!- Davterra [~tralfaz@104.200.129.57] has quit [Remote host closed the connection] 12:11 -!- Davterra [~tralfaz@104.200.129.57] has joined #bitcoin-core-pr-reviews 12:50 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 244 seconds] 12:59 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 16:33 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 16:35 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 19:58 -!- slivera [~slivera@103.231.88.10] has joined #bitcoin-core-pr-reviews 20:28 < jonatack> raj_: look at validation.cpp lines 681 and 2147 20:30 < jonatack> AFAICT, from a quick look, CheckTxInputs modifies `state` which is passed by reference and used by callers in the error messages, e.g. state.ToString() 20:31 < sipa> yeah, that's generally the mechanism all validation functions use 21:15 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 21:15 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 21:42 -!- jungly [~jungly@host-80-117-253-7.pool80117.interbusiness.it] has joined #bitcoin-core-pr-reviews 22:01 -!- jungly [~jungly@host-80-117-253-7.pool80117.interbusiness.it] has quit [Remote host closed the connection] 22:01 -!- jungly [~jungly@host-80-117-253-7.pool80117.interbusiness.it] has joined #bitcoin-core-pr-reviews 22:07 -!- jungly [~jungly@host-80-117-253-7.pool80117.interbusiness.it] has quit [Remote host closed the connection]