--- Day changed Thu Aug 13 2020 00:25 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 244 seconds] 00:39 -!- Davterra [~Davterra@89.45.90.22] has quit [Ping timeout: 246 seconds] 00:40 -!- Davterra [~Davterra@89.45.90.22] has joined #bitcoin-core-pr-reviews 00:50 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds] 00:51 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-pr-reviews 01:07 -!- jonatack [~jon@213.152.162.84] has joined #bitcoin-core-pr-reviews 02:34 -!- Davterra [~Davterra@89.45.90.22] has quit [Ping timeout: 256 seconds] 02:35 -!- Davterra [~Davterra@89.45.90.22] has joined #bitcoin-core-pr-reviews 02:44 -!- jonatack [~jon@213.152.162.84] has quit [Ping timeout: 246 seconds] 02:48 -!- belcher [~belcher@unaffiliated/belcher] has quit [Read error: Connection reset by peer] 02:49 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-pr-reviews 02:49 -!- Davterra [~Davterra@89.45.90.22] has quit [Ping timeout: 260 seconds] 02:50 -!- Davterra [~Davterra@89.45.90.22] has joined #bitcoin-core-pr-reviews 03:03 -!- Geovanni19Terry [~Geovanni1@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-pr-reviews 03:08 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 03:08 -!- Geovanni19Terry [~Geovanni1@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 265 seconds] 03:10 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 03:14 -!- evanlinjin [~evanlinji@2404:4408:43ff:bb00:9cc5:84c2:8641:8dd1] has quit [Quit: Konversation terminated!] 03:40 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-pr-reviews 03:41 -!- T3 [~T3@173.231.109.130] has quit [Read error: Connection reset by peer] 03:41 -!- T3 [~T3@173.231.109.130] has joined #bitcoin-core-pr-reviews 03:54 -!- Davterra [~Davterra@89.45.90.22] has quit [Ping timeout: 240 seconds] 03:55 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 03:55 -!- Davterra [~Davterra@89.45.90.22] has joined #bitcoin-core-pr-reviews 03:58 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 03:58 -!- vasild_ is now known as vasild 04:14 -!- shesek [~shesek@164.90.217.137] has joined #bitcoin-core-pr-reviews 04:14 -!- shesek [~shesek@164.90.217.137] has quit [Changing host] 04:14 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-pr-reviews 04:26 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has joined #bitcoin-core-pr-reviews 04:55 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has quit [Quit: leaving] 04:55 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has joined #bitcoin-core-pr-reviews 05:09 -!- Davterra [~Davterra@89.45.90.22] has quit [Ping timeout: 246 seconds] 05:09 -!- Davterra [~Davterra@89.45.90.22] has joined #bitcoin-core-pr-reviews 05:24 -!- Davterra [~Davterra@89.45.90.22] has quit [Ping timeout: 265 seconds] 05:25 -!- Davterra [~Davterra@89.45.90.22] has joined #bitcoin-core-pr-reviews 05:35 -!- Davterra [~Davterra@89.45.90.22] has quit [Ping timeout: 264 seconds] 05:35 -!- Davterra [~Davterra@89.45.90.22] has joined #bitcoin-core-pr-reviews 05:44 -!- Davterra [~Davterra@89.45.90.22] has quit [Ping timeout: 246 seconds] 05:45 -!- Davterra [~Davterra@89.45.90.22] has joined #bitcoin-core-pr-reviews 06:00 -!- Davterra [~Davterra@89.45.90.22] has quit [Ping timeout: 265 seconds] 06:00 -!- Davterra [~Davterra@89.45.90.22] has joined #bitcoin-core-pr-reviews 06:18 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 06:21 -!- gzhao408 [~textual@c-73-252-251-3.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 06:37 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 06:38 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 07:33 -!- Davterra [~Davterra@89.45.90.22] has quit [Quit: Leaving] 07:51 -!- s_am [uid458593@gateway/web/irccloud.com/x-hbkjecnvuwocvnvb] has quit [Quit: Connection closed for inactivity] 09:16 -!- Davterra [~Davterra@89.45.90.22] has joined #bitcoin-core-pr-reviews 09:43 -!- PaulTroo_ [~paultroon@86.106.121.169] has quit [Remote host closed the connection] 09:46 -!- shesek [~shesek@164.90.217.137] has joined #bitcoin-core-pr-reviews 09:46 -!- shesek [~shesek@164.90.217.137] has quit [Changing host] 09:46 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-pr-reviews 09:53 -!- PaulTroo_ [~paultroon@86.106.121.169] has joined #bitcoin-core-pr-reviews 10:24 -!- dhruv [881873f9@gateway/web/cgi-irc/kiwiirc.com/ip.136.24.115.249] has joined #bitcoin-core-pr-reviews 10:24 -!- dhruv [881873f9@gateway/web/cgi-irc/kiwiirc.com/ip.136.24.115.249] has quit [Client Quit] 10:25 -!- dhruv [881873f9@gateway/web/cgi-irc/kiwiirc.com/ip.136.24.115.249] has joined #bitcoin-core-pr-reviews 10:26 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Read error: Connection reset by peer] 10:26 -!- dhruv [881873f9@gateway/web/cgi-irc/kiwiirc.com/ip.136.24.115.249] has quit [Client Quit] 10:27 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-pr-reviews 10:27 -!- dhruv [881873f9@249.115.24.136.in-addr.arpa] has joined #bitcoin-core-pr-reviews 10:33 -!- dhruv [881873f9@249.115.24.136.in-addr.arpa] has quit [Remote host closed the connection] 11:08 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 11:11 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 11:28 < pinheadmz> re: fallbackfee on regtest. Should I jsut get used to starting bitcoind -regtest with fallbackfee? or do reviewers keep it in a config file, etc 11:35 < sipa> i don't know, what are you using regtest for? 11:35 < sipa> the functional tests should set that where needed 11:50 < pinheadmz> oh today i wanted to try sending tx to witness versions > 1 12:04 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 12:04 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 12:10 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-pr-reviews 12:59 -!- gzhao408 [~textual@c-73-252-251-3.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 12:59 -!- seven_ [~seven@2a00:ee2:410c:1300:ad6e:e47f:392:2135] has joined #bitcoin-core-pr-reviews 13:01 -!- seven_ [~seven@2a00:ee2:410c:1300:ad6e:e47f:392:2135] has quit [Remote host closed the connection] 13:01 -!- seven_ [~seven@2a00:ee2:410c:1300:ad6e:e47f:392:2135] has joined #bitcoin-core-pr-reviews 13:01 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 13:08 < gwillen> pinheadmz: funny, I just ran into the same thing yesterday actually 13:09 < gwillen> it does seem like it might be nice for regtest to default to having some sensible low value for fallbackfee? 13:17 < shesek> this did break a bunch of my integration tests, I had to add fallbackfee everywhere. would be nice if this has an out-of-the-box default for regtest 13:19 < shesek> (integration tests for external software that I'm working on, charge/spark/bwt) 13:21 < shesek> this also broke rust-bitcoincore-rpc's integration tests iirc 13:32 < pinheadmz> huh ok seems like might be a good PR then! 14:36 -!- PaulTroo_ [~paultroon@86.106.121.169] has quit [Remote host closed the connection] 15:49 -!- gzhao408 [~textual@c-73-252-251-3.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 15:55 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 15:59 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 15:59 -!- vasild_ is now known as vasild 16:17 -!- gzhao408 [~textual@c-73-252-251-3.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 16:32 -!- T3 [~T3@173.231.109.130] has quit [Ping timeout: 240 seconds] 17:21 < instagibbs> well, it was changed intentionally before to be this way 17:22 < instagibbs> it's just something you should add to your conf/arg :shrug: 17:23 < instagibbs> regtest is more like mainnet in a few ways now, including standardness stuff 17:34 < pinheadmz> instagibbs ok that makes sense, i can leave the setting in a config file 17:45 < sipa> this goes back to the discussion about whether regtest is for testing bitcoind, or for doing integrations tests of other things with it 17:50 < aj> (signet!) 17:50 < sipa> yes 18:03 < gwillen> mm, that makes sense 18:05 < sipa> aj: though i don't think you can really use signet in an automated integration test 18:06 < sipa> i think signet is more of a better replacement for testnet, for testing very high-level deployments in a final test before deployment on mainnet 18:07 < sipa> but it doesn't have the level of control you want for typical integration tests i think 18:08 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-pr-reviews 18:08 < aj> well custom signets do have the degree of control if you want it 18:08 < sipa> right, sure 18:09 < sipa> but imagine we had signet, and didn't have regtest... would you write the current test/functional/* tests using signet? 18:10 < aj> signet still has some work required so it'd be painful 18:10 < aj> but you could set the block challenge to be OP_TRUE and be pretty close 18:10 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 260 seconds] 18:11 < sipa> hmm, i guess that's pretty much regtest then 18:35 < gwillen> yeah I have definitely wondered what exactly the practical difference is between signet and regtest 18:36 < gwillen> it does make sense for a large-scale test network deployment where you actually want more people than just the operator using it 18:52 < kallewoof> gwillen: try to run a public regtest and you'll find out quickly i reckon 19:53 -!- Netsplit *.net <-> *.split quits: bad_duck, darosior, thrasher, Davterra 19:54 -!- Netsplit over, joins: bad_duck 19:59 -!- Davterra [~Davterra@89.45.90.22] has joined #bitcoin-core-pr-reviews 19:59 -!- darosior [~darosior@194.36.189.246] has joined #bitcoin-core-pr-reviews 19:59 -!- thrasher [~thrasher@unaffiliated/thrasher] has joined #bitcoin-core-pr-reviews 20:17 -!- T3 [~T3@173.231.109.130] has joined #bitcoin-core-pr-reviews 21:11 -!- T3 [~T3@173.231.109.130] has quit [Read error: Connection reset by peer] 21:11 -!- T3 [~T3@173.231.109.130] has joined #bitcoin-core-pr-reviews 21:52 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has quit [Quit: leaving] 22:16 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection] 22:16 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 22:30 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-pr-reviews 22:30 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Client Quit] 22:33 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-pr-reviews 22:43 -!- instagibbs [~instagibb@pool-71-178-191-230.washdc.fios.verizon.net] has quit [Ping timeout: 240 seconds] 22:45 -!- instagibbs [~instagibb@pool-71-178-191-230.washdc.fios.verizon.net] has joined #bitcoin-core-pr-reviews 22:47 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Ping timeout: 240 seconds] 22:48 -!- MarcoFalke [~none@198.12.116.246] has quit [Quit: ZNC 1.7.1 - https://znc.in] 22:49 -!- MarcoFalke [~none@198.12.116.246] has joined #bitcoin-core-pr-reviews 22:49 -!- dongcarl [~dongcarl@unaffiliated/dongcarl] has quit [Read error: Connection reset by peer] 22:50 -!- dongcarl [~dongcarl@unaffiliated/dongcarl] has joined #bitcoin-core-pr-reviews 22:52 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #bitcoin-core-pr-reviews 23:38 -!- PaulTroo_ [~paultroon@86.106.121.169] has joined #bitcoin-core-pr-reviews 23:45 -!- seven_ [~seven@2a00:ee2:410c:1300:ad6e:e47f:392:2135] has quit [Read error: Connection reset by peer]