--- Day changed Sat Sep 05 2020 00:27 -!- reallll [~belcher@unaffiliated/belcher] has joined #bitcoin-core-pr-reviews 00:30 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds] 00:35 -!- reallll is now known as belcher 01:17 -!- jonatack [~jon@37.166.58.175] has joined #bitcoin-core-pr-reviews 02:45 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 02:46 -!- jonatack [~jon@37.166.58.175] has quit [Read error: Connection reset by peer] 02:47 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 03:18 -!- Loyce57Larkin [~Loyce57La@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-pr-reviews 03:23 -!- Loyce57Larkin [~Loyce57La@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 240 seconds] 03:59 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 04:00 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 04:02 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection] 04:05 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 04:17 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-pr-reviews 07:56 -!- waxwing [~waxwing@unaffiliated/waxwing] has quit [Ping timeout: 246 seconds] 08:15 -!- jb551 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 08:23 -!- jb551 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-pr-reviews 08:23 -!- jb551 is now known as jb55 08:35 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Quit: Leaving] 08:43 -!- raddev [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has quit [Quit: -a- Connection Timed Out] 08:47 -!- tralfaz [~dulyNoded@94.198.42.121] has quit [Ping timeout: 264 seconds] 08:48 -!- raddev [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has joined #bitcoin-core-pr-reviews 08:48 -!- tralfaz [~dulyNoded@69.4.234.77] has joined #bitcoin-core-pr-reviews 08:52 -!- raddev [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has quit [Read error: Connection reset by peer] 08:56 -!- raddev [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has joined #bitcoin-core-pr-reviews 08:58 -!- raddev [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has quit [Read error: Connection reset by peer] 09:00 -!- raddev_ [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has joined #bitcoin-core-pr-reviews 09:01 -!- tralfaz [~dulyNoded@69.4.234.77] has quit [Remote host closed the connection] 09:03 -!- tralfaz [~dulyNoded@69.4.234.77] has joined #bitcoin-core-pr-reviews 09:04 -!- tralfaz [~dulyNoded@69.4.234.77] has quit [Remote host closed the connection] 09:04 -!- tralfaz [~dulyNoded@69.4.234.77] has joined #bitcoin-core-pr-reviews 09:09 -!- tralfaz [~dulyNoded@69.4.234.77] has quit [Remote host closed the connection] 09:11 -!- kiwi_95 [2ec100e0@gateway/web/cgi-irc/kiwiirc.com/ip.46.193.0.224] has joined #bitcoin-core-pr-reviews 09:34 -!- raddev_ [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has quit [Ping timeout: 260 seconds] 09:43 -!- raddev [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has joined #bitcoin-core-pr-reviews 09:48 -!- raddev [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has quit [Ping timeout: 256 seconds] 09:53 -!- tralfaz [~dulyNoded@69.4.234.77] has joined #bitcoin-core-pr-reviews 10:02 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-pr-reviews 10:31 -!- worc3131 [~quassel@2a02:c7f:c026:9500:7d0b:65d0:38a4:4786] has joined #bitcoin-core-pr-reviews 10:47 -!- worc3131 [~quassel@2a02:c7f:c026:9500:7d0b:65d0:38a4:4786] has quit [Ping timeout: 272 seconds] 11:26 -!- worc3131 [~quassel@2a02:c7f:c026:9500:7d0b:65d0:38a4:4786] has joined #bitcoin-core-pr-reviews 11:41 -!- raddev_ [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has joined #bitcoin-core-pr-reviews 11:45 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection] 11:45 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-pr-reviews 11:50 -!- raddev_ [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has quit [Ping timeout: 258 seconds] 11:53 -!- raddev [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has joined #bitcoin-core-pr-reviews 11:57 -!- raddev [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has quit [Ping timeout: 240 seconds] 12:07 -!- raddev [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has joined #bitcoin-core-pr-reviews 12:41 -!- raddev [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has quit [Quit: -a- Connection Timed Out] 12:42 -!- raddev [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has joined #bitcoin-core-pr-reviews 12:57 -!- raddev_ [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has joined #bitcoin-core-pr-reviews 12:57 -!- raddev [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has quit [Read error: Connection reset by peer] 13:41 -!- raddev_ [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has quit [Quit: -a- Connection Timed Out] 13:42 -!- raddev [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has joined #bitcoin-core-pr-reviews 13:50 -!- kiwi_95 [2ec100e0@gateway/web/cgi-irc/kiwiirc.com/ip.46.193.0.224] has quit [Quit: Connection closed] 14:14 -!- raddev [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has quit [Ping timeout: 264 seconds] 14:52 -!- raddev [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has joined #bitcoin-core-pr-reviews 15:42 -!- raddev [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has quit [Quit: -a- Connection Timed Out] 15:42 -!- raddev [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has joined #bitcoin-core-pr-reviews 15:51 -!- shesek [~shesek@164.90.217.137] has joined #bitcoin-core-pr-reviews 15:51 -!- shesek [~shesek@164.90.217.137] has quit [Changing host] 15:51 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-pr-reviews 15:53 -!- tralfaz [~dulyNoded@69.4.234.77] has quit [Ping timeout: 264 seconds] 15:53 -!- tralfaz [~dulyNoded@69.4.234.112] has joined #bitcoin-core-pr-reviews 15:59 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 16:01 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 16:08 -!- raddev [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has quit [Ping timeout: 256 seconds] 16:27 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-gqphafrvekahiyii] has quit [Quit: Connection closed for inactivity] 16:30 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-pr-reviews 16:33 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 258 seconds] 16:41 -!- raddev [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has joined #bitcoin-core-pr-reviews 16:54 -!- tryphe__ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-pr-reviews 16:54 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer] 17:13 -!- raddev [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has quit [Ping timeout: 240 seconds] 17:19 -!- aj [aj@139.162.42.226] has quit [Ping timeout: 256 seconds] 17:20 -!- raddev [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has joined #bitcoin-core-pr-reviews 17:39 -!- aj [aj@cerulean.erisian.com.au] has joined #bitcoin-core-pr-reviews 17:41 -!- raddev [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has quit [Quit: -a- Connection Timed Out] 17:41 -!- raddev [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has joined #bitcoin-core-pr-reviews 18:17 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection] 18:42 < robot-dreams> Hi, something I've been curious about: what are the important goals of "tested ACK" given that there's already a CI system? 18:43 < robot-dreams> - Catch flaky tests? 18:43 < robot-dreams> - Run tests on different people's hardware? 18:43 < robot-dreams> - Try extra test cases manually? 19:00 < sipa> i tested ack is ideally qualified with what someone did, and what that is up to the reviewer, and depends on the change 19:01 < sipa> just a tested ack with "i ran the tests on typical hardware" isn't particularly useful 19:01 < sipa> but say a GUI change... that's not covered by tests 19:01 < sipa> or a full sync, if anything related to validation was changed, could be useful 19:02 < sipa> or you actually performed a more than trivial workflow involving receiving/sending transactions 19:04 < robot-dreams> Thanks, that makes a lot of sense! 19:04 < robot-dreams> As a follow-up, do you think "I ran the tests on typical hardware + I reviewed the code carefully" is enough to give ACK (instead of utACK)? 19:06 < sipa> if you believe, as a reviewer, that the included tests are sufficient, yes 19:06 < sipa> you don't even need to run the tests yourself for that, you can also look at CI output (of course, i'd encourage you to run tests yourself for anything nontrivial) 19:57 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-pr-reviews 19:59 -!- tryphe__ [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 240 seconds] 20:09 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 20:10 -!- pierre_rochard [sid299882@gateway/web/irccloud.com/x-qwmqhzychbvybktx] has quit [Ping timeout: 246 seconds] 20:10 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-pr-reviews 20:10 -!- pierre_rochard [sid299882@gateway/web/irccloud.com/x-blfjoxusrhpawecr] has joined #bitcoin-core-pr-reviews 20:11 -!- wullon587 [~wullon@241.243.86.88.rdns.comcable.net] has quit [Quit: Ping timeout (120 seconds)] 20:12 -!- wullon587 [~wullon@241.243.86.88.rdns.comcable.net] has joined #bitcoin-core-pr-reviews 20:58 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-pr-reviews 21:41 -!- tralfaz [~dulyNoded@69.4.234.112] has quit [Ping timeout: 264 seconds] 21:41 -!- tralfaz [~dulyNoded@69.4.234.91] has joined #bitcoin-core-pr-reviews 21:41 -!- tralfaz [~dulyNoded@69.4.234.91] has quit [Remote host closed the connection] 21:45 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-pr-reviews 22:35 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-pr-reviews 22:35 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Ping timeout: 240 seconds] 23:24 -!- gzhao408 [uid453516@gateway/web/irccloud.com/x-upikznymqymtlwmr] has quit [Quit: Connection closed for inactivity] 23:52 < jonatack> robot-dreams: you can break many things without the CI or test suite minding in the least 23:53 < jonatack> and sometimes manual testing catches things that aren't seen in code review 23:54 < jonatack> not infrequently, you might see warnings or errors when debug building PRs yourself that you might not see otherwise, either because it's buried in one of the CI job logs 23:55 < sipa> also, tests can be wromg 23:55 < jonatack> or because your compiler or configure or system is a bit different