--- Day changed Sun Sep 06 2020 00:05 < jonatack> sometimes testing a PR might mean non-CI steps like adding asserts, custom logging, sanity checks, stepping through things, changing the patch, making it break to see what/why, etc. 00:26 < jonatack> (the CI has made a lot of progress, too...it has been getting better and better over time) 00:27 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-pr-reviews 00:30 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 246 seconds] 00:38 -!- raddev [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has quit [Quit: -a- Connection Timed Out] 00:39 -!- mol [~mol@unaffiliated/molly] has quit [Read error: Connection reset by peer] 00:43 -!- raddev [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has joined #bitcoin-core-pr-reviews 00:48 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 00:51 < hebasto> robot-dreams: about "utACK" and "testedACK" please see https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#peer-review 01:04 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-pfpozdgfdlzxuabu] has joined #bitcoin-core-pr-reviews 01:04 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 272 seconds] 01:11 -!- belcher_ is now known as belcher 01:11 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 01:15 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 01:44 -!- Smod [c2e69e2d@194.230.158.45] has joined #bitcoin-core-pr-reviews 01:57 -!- jonatack [~jon@213.152.162.170] has joined #bitcoin-core-pr-reviews 02:17 -!- Smod [c2e69e2d@194.230.158.45] has quit [Ping timeout: 245 seconds] 03:20 -!- Deangelo20Kohler [~Deangelo2@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-pr-reviews 03:25 -!- Deangelo20Kohler [~Deangelo2@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 256 seconds] 03:26 -!- Netsplit *.net <-> *.split quits: worc3131, Jackielove4u, pierre_rochard, mikerah[m], corollari__, felixfoertsch 03:32 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-pfpozdgfdlzxuabu] has joined #bitcoin-core-pr-reviews 03:32 -!- pierre_rochard [sid299882@gateway/web/irccloud.com/x-blfjoxusrhpawecr] has joined #bitcoin-core-pr-reviews 03:32 -!- worc3131 [~quassel@2a02:c7f:c026:9500:7d0b:65d0:38a4:4786] has joined #bitcoin-core-pr-reviews 03:32 -!- mikerah[m] [mikerahmat@gateway/shell/matrix.org/x-syampplrjuluxcda] has joined #bitcoin-core-pr-reviews 03:32 -!- felixfoertsch [felixfoert@gateway/shell/matrix.org/x-aizyphenbqsiaoig] has joined #bitcoin-core-pr-reviews 03:32 -!- corollari__ [sid405633@gateway/web/irccloud.com/x-jferurwjzkjcmwcg] has joined #bitcoin-core-pr-reviews 03:32 -!- worc3131 [~quassel@2a02:c7f:c026:9500:7d0b:65d0:38a4:4786] has quit [Max SendQ exceeded] 03:33 -!- worc3131 [~quassel@2a02:c7f:c026:9500:7d0b:65d0:38a4:4786] has joined #bitcoin-core-pr-reviews 03:33 -!- tralfaz [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-pr-reviews 03:34 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection] 03:59 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 04:06 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 05:03 -!- jonatack [~jon@213.152.162.170] has quit [Quit: jonatack] 05:05 -!- raddev [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has quit [Quit: -a- Connection Timed Out] 05:10 -!- raddev [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has joined #bitcoin-core-pr-reviews 05:15 -!- raddev [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has quit [Ping timeout: 260 seconds] 06:25 -!- raddev [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has joined #bitcoin-core-pr-reviews 06:32 -!- raddev_ [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has joined #bitcoin-core-pr-reviews 06:33 -!- raddev [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has quit [Ping timeout: 260 seconds] 06:35 -!- tralfaz is now known as Davterrra 06:35 -!- raddev [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has joined #bitcoin-core-pr-reviews 06:36 -!- raddev_ [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has quit [Ping timeout: 260 seconds] 07:10 -!- Davterrra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection] 07:11 -!- Davterrra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-pr-reviews 07:14 -!- raddev [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has quit [Read error: Connection reset by peer] 07:25 -!- raddev [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has joined #bitcoin-core-pr-reviews 07:30 -!- raddev [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has quit [Ping timeout: 256 seconds] 07:30 -!- raddev [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has joined #bitcoin-core-pr-reviews 07:35 -!- raddev [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has quit [Ping timeout: 246 seconds] 07:51 -!- raddev [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has joined #bitcoin-core-pr-reviews 07:55 -!- raddev [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has quit [Read error: Connection reset by peer] 07:55 -!- raddev_ [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has joined #bitcoin-core-pr-reviews 08:03 -!- raddev [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has joined #bitcoin-core-pr-reviews 08:03 -!- raddev_ [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has quit [Read error: Connection reset by peer] 08:12 -!- raddev [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has quit [Ping timeout: 246 seconds] 08:55 < robot-dreams> jonatack: Thanks, that also makes a lot of sense! 08:56 < robot-dreams> hebasto: Thanks for the link, in addition to what sipa and jonatack already mentioned it's also a nice reminder that there are fuzz tests 08:58 < robot-dreams> "Tested ACK" as "I've experimentally convinced myself this change is good" makes so much more sense than "I did make; make check; `test/functional/test_runner.py --extended`, went to lunch, then came back and everything passed" 09:20 -!- raddev [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has joined #bitcoin-core-pr-reviews 09:41 -!- raddev [~Android@pool-96-240-5-223.nwrknj.fios.verizon.net] has quit [Ping timeout: 265 seconds] 10:02 -!- kristapsk___ [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-pr-reviews 10:03 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 10:17 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-pr-reviews 10:53 -!- Davterrra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection] 10:53 -!- Davterrra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-pr-reviews 11:06 -!- worc3131 [~quassel@2a02:c7f:c026:9500:7d0b:65d0:38a4:4786] has quit [Ping timeout: 260 seconds] 11:08 -!- Davterrra [~davterra@gateway/tor-sasl/tralfaz] has quit [Quit: Leaving] 11:18 -!- worc3131 [~quassel@2a02:c7f:c026:9500:7d0b:65d0:38a4:4786] has joined #bitcoin-core-pr-reviews 11:26 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-pr-reviews 11:26 -!- davterra is now known as tralfaz 11:50 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 13:09 -!- kristapsk___ [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 13:10 -!- kristapsk___ [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-pr-reviews 13:37 < jnewbery> when I started reviewing PRs, I'd manually test almost every PR that I reviewed. Partly because I wasn't as confident that I was reading the code code/understanding the diff correctly, so I'd do things like add additional debug prints, etc. Unless I'd tested it manually, I wouldn't be able to confidently give an ACK. 13:38 < jnewbery> And also it's just the best way of learning how everything fits together. 13:44 -!- seven_ [~seven@2a00:ee2:410c:1300:f49a:3d8d:2d74:48e5] has quit [Read error: Connection reset by peer] 14:05 -!- kiwi_5 [2ec100e0@gateway/web/cgi-irc/kiwiirc.com/ip.46.193.0.224] has joined #bitcoin-core-pr-reviews 14:06 < kiwi_5> Hello. Do you have the code of libsecp on GitHub? 14:07 < sipa> https://github.com/bitcoin-core/secp256k1 14:10 < kiwi_5> cheers 14:11 -!- worc3131 [~quassel@2a02:c7f:c026:9500:7d0b:65d0:38a4:4786] has quit [Remote host closed the connection] 14:59 -!- kiwi_5 [2ec100e0@gateway/web/cgi-irc/kiwiirc.com/ip.46.193.0.224] has quit [Quit: Connection closed] 15:03 -!- kristapsk___ [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 15:59 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 16:01 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 16:10 -!- tralfaz [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection] 17:11 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-pr-reviews 20:54 -!- kiwi_38 [2ec100e0@gateway/web/cgi-irc/kiwiirc.com/ip.46.193.0.224] has joined #bitcoin-core-pr-reviews 21:17 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 21:38 -!- kiwi_38 [2ec100e0@gateway/web/cgi-irc/kiwiirc.com/ip.46.193.0.224] has quit [Quit: Connection closed] 22:06 -!- wumpus [~ircclient@pdpc/supporter/professional/wumpus] has quit [Quit: need to take a break for awhile]