--- Day changed Tue Sep 08 2020 00:00 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-pr-reviews 00:15 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 00:21 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-pr-reviews 00:28 -!- reallll [~belcher@unaffiliated/belcher] has joined #bitcoin-core-pr-reviews 00:31 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Ping timeout: 265 seconds] 01:03 -!- MasterdonX [~masterdon@37.120.212.76] has quit [Ping timeout: 256 seconds] 01:05 -!- MasterdonX [~masterdon@37.120.212.76] has joined #bitcoin-core-pr-reviews 01:21 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 01:22 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-pr-reviews 02:00 -!- jonatack [~jon@192.113.14.109.rev.sfr.net] has joined #bitcoin-core-pr-reviews 02:05 -!- jonatack [~jon@192.113.14.109.rev.sfr.net] has quit [Ping timeout: 246 seconds] 02:06 -!- jonatack [~jon@37.172.68.103] has joined #bitcoin-core-pr-reviews 02:22 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-pr-reviews 03:46 -!- blpshk [863be68d@leat141.unice.fr] has joined #bitcoin-core-pr-reviews 03:56 -!- jonatack [~jon@37.172.68.103] has quit [Ping timeout: 264 seconds] 03:57 -!- jonatack [~jon@213.152.161.211] has joined #bitcoin-core-pr-reviews 03:58 < michaelfolkson> Not touching language PRs for a while. Looking forward to Signet session tomorrow though. 03:58 < michaelfolkson> Here is the transcript from the Socratic we did on Signet https://diyhpl.us/wiki/transcripts/london-bitcoin-devs/2020-08-19-socratic-seminar-signet/ 03:59 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 03:59 < michaelfolkson> And a bunch of reading links if you are interested https://pastebin.com/rAcXX9Tn 04:01 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 04:12 -!- jonatack [~jon@213.152.161.211] has quit [Ping timeout: 240 seconds] 04:29 -!- gleb [~gleb@178.150.137.228] has quit [Ping timeout: 258 seconds] 04:36 -!- gleb [~gleb@178.150.137.228] has joined #bitcoin-core-pr-reviews 04:48 -!- worc3131 [~quassel@2a02:c7f:c026:9500:7d0b:65d0:38a4:4786] has joined #bitcoin-core-pr-reviews 05:04 -!- petemyers [~petemyers@197.156.107.70] has joined #bitcoin-core-pr-reviews 05:31 -!- reallll is now known as belcher 05:46 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [] 05:47 -!- petemyers [~petemyers@197.156.107.70] has quit [Remote host closed the connection] 06:02 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds] 06:10 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has joined #bitcoin-core-pr-reviews 06:10 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has quit [Changing host] 06:10 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-pr-reviews 06:10 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-pr-reviews 06:11 -!- petemyers [~petemyers@197.156.107.70] has joined #bitcoin-core-pr-reviews 06:15 -!- petemyers [~petemyers@197.156.107.70] has quit [Client Quit] 06:16 -!- kiwi_41 [863be68d@gateway/web/cgi-irc/kiwiirc.com/ip.134.59.230.141] has joined #bitcoin-core-pr-reviews 06:16 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-pr-reviews 06:27 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 260 seconds] 07:23 < michaelfolkson> I put the robot-dreams question on testing a PR up on StackExchange. Great question and comments https://bitcoin.stackexchange.com/questions/98911/should-i-run-the-tests-every-time-i-review-an-open-bitcoin-core-pr 07:23 < michaelfolkson> Feel free to suggest edits or additions for anything I missed 07:25 < michaelfolkson> With the Signet PR it feels to me like there is room for even more creativity on testing than normal 07:26 < pinheadmz> a few commits ago, I broke signet by sending too many transactions :-) 07:28 < pinheadmz> https://github.com/bitcoin/bitcoin/pull/18267#issuecomment-676387834 07:29 < michaelfolkson> The attack (testing) surface area of consensus changes is minimal. But the general attack (testing) surface area is probably as big as it gets 07:31 < jonatack> yes, signet is a wide PR and manually testing it can be larger than most PRs... launch bitcoind and run rpc commands, do txns, check peer conns and debug log... launch the gui, check peer conns, do txns, run rpc commands from the console, etc. regular debug build and tests. fuzz build and run the changed fuzzers, etc. 07:34 < michaelfolkson> You found an inflation bug pinheadmz :) 07:34 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Read error: Connection reset by peer] 07:34 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-pr-reviews 07:34 < jonatack> ("check peer conns" for me nowadays means running cli -netinfo) 07:34 < pinheadmz> heh not really, didnt create any new coins 07:35 < michaelfolkson> The miner is getting paid more than they should for what the coinbase and the total fees should be right? Isn't that an inflation bug? 07:36 < pinheadmz> oh yeah i guess so 07:37 < michaelfolkson> Thanks for those suggestions jonatack. That's a couple days work ;) 07:40 < michaelfolkson> Why is there a GUI? I thought the GUI functionality typically came a couple of major releases after the CLI. So GUI users can play around with Taproot asap? 07:41 < jonatack> iirc it took very little code to extend signet to the gui 07:42 -!- blpshk [863be68d@leat141.unice.fr] has quit [Remote host closed the connection] 07:42 -!- kiwi_41 [863be68d@gateway/web/cgi-irc/kiwiirc.com/ip.134.59.230.141] has quit [Quit: Connection closed] 07:42 < pinheadmz> jonatack looks basically like all it takes is picking two colors 07:42 < jonatack> (i don't plan on re-doing all the manual testing, did it a couple of times since april, that's enough ;) 07:43 < pinheadmz> michaelfolkson it just means they can connect to signet with GUI, no taproot yet 07:43 < pinheadmz> same as switching to regtest/testnet 07:43 < jonatack> pinheadmz: yeah 07:46 < michaelfolkson> Right. I'm just thinking when you might be able to do Taproot transactions in the GUI 07:46 < pinheadmz> that feels like it will take a while after activation, dunno if anyones working on it ? 07:47 < pinheadmz> not to mention the UX confusion of having two completely different wallet types 07:47 < pinheadmz> or three if legacy is still usable from GUI? Funny, I havent used the GUI in ages, always forget to test it 07:50 < michaelfolkson> Yeah only mention it because it is the bonus question tomorrow ;) 08:20 -!- flip_btcmag [~textual@50-207-231-44-static.hfc.comcastbusiness.net] has joined #bitcoin-core-pr-reviews 09:23 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-pr-reviews 11:41 -!- flip_btcmag [~textual@50-207-231-44-static.hfc.comcastbusiness.net] has quit [Quit: Textual IRC Client: www.textualapp.com] 12:04 -!- vindard [~vindard@190.83.165.233] has quit [Ping timeout: 240 seconds] 12:27 -!- shesek [~shesek@164.90.217.137] has joined #bitcoin-core-pr-reviews 12:27 -!- shesek [~shesek@164.90.217.137] has quit [Changing host] 12:27 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-pr-reviews 12:31 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 12:48 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Ping timeout: 240 seconds] 13:03 -!- gzhao408 [uid453516@gateway/web/irccloud.com/x-srruwobpjzhulrgk] has quit [Quit: Connection closed for inactivity] 13:20 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Ping timeout: 265 seconds] 13:53 -!- gleb [~gleb@178.150.137.228] has quit [Ping timeout: 246 seconds] 13:58 -!- gleb [~gleb@178.150.137.228] has joined #bitcoin-core-pr-reviews 14:16 -!- vindard [~vindard@190.83.165.233] has joined #bitcoin-core-pr-reviews 14:22 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-pr-reviews 14:23 -!- sunon [~sunon@105-213-21-27.access.mtnbusiness.co.za] has joined #bitcoin-core-pr-reviews 14:29 -!- sunon [~sunon@105-213-21-27.access.mtnbusiness.co.za] has quit [Remote host closed the connection] 14:39 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection] 14:39 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-pr-reviews 15:00 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Quit: Leaving] 15:59 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 16:01 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 16:23 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-pr-reviews 16:29 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-pr-reviews 16:32 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 265 seconds] 17:00 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection] 17:00 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-pr-reviews 17:42 -!- worc3131 [~quassel@2a02:c7f:c026:9500:7d0b:65d0:38a4:4786] has quit [Ping timeout: 272 seconds] 17:46 -!- worc3131 [~quassel@2a02:c7f:c026:9500:7d0b:65d0:38a4:4786] has joined #bitcoin-core-pr-reviews 18:34 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 18:35 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-pr-reviews 19:57 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer] 19:57 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-pr-reviews 20:16 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer] 20:16 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-pr-reviews 21:53 -!- tralfaz [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-pr-reviews 21:53 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection] 22:15 -!- tralfaz [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection] 22:16 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-pr-reviews 22:24 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Ping timeout: 246 seconds] 23:28 -!- petemyers [~petemyers@197.156.95.153] has joined #bitcoin-core-pr-reviews 23:41 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 244 seconds] 23:49 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-pr-reviews 23:56 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Read error: Connection reset by peer] 23:56 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-pr-reviews