--- Day changed Fri Sep 11 2020 00:00 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds] 00:14 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-pr-reviews 00:28 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-pr-reviews 00:32 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 256 seconds] 01:06 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:edc:8931:b0c4:3f36:e776] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 01:34 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 240 seconds] 02:49 -!- jonatack [~jon@192.113.14.109.rev.sfr.net] has joined #bitcoin-core-pr-reviews 02:53 -!- gleb [~gleb@178.150.137.228] has joined #bitcoin-core-pr-reviews 03:00 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:edc:8931:b0c4:3f36:e776] has joined #bitcoin-core-pr-reviews 03:59 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 04:06 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 04:39 -!- jonatack [~jon@192.113.14.109.rev.sfr.net] has quit [Ping timeout: 240 seconds] 05:01 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds] 05:14 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-pr-reviews 05:22 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Read error: Connection reset by peer] 05:29 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-pr-reviews 05:35 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 06:11 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-pr-reviews 06:13 -!- tralfaz [~davterra@gateway/tor-sasl/tralfaz] has quit [Ping timeout: 240 seconds] 07:06 -!- reallll [~belcher@unaffiliated/belcher] has joined #bitcoin-core-pr-reviews 07:07 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:edc:8931:b0c4:3f36:e776] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 07:07 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Ping timeout: 256 seconds] 07:15 < fjahr> FWIW, I opened an issue for the good first review label, seemed like the best way to introduce such a suggestion: https://github.com/bitcoin/bitcoin/issues/19941 07:19 -!- shaunsun [~shaunsun@c-76-26-29-34.hsd1.fl.comcast.net] has joined #bitcoin-core-pr-reviews 07:20 < pinheadmz> fjahr great idea 07:21 -!- shaunsun_ [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has joined #bitcoin-core-pr-reviews 07:21 < fjahr> pinheadmz: thanks :) 07:23 -!- shaunsun [~shaunsun@c-76-26-29-34.hsd1.fl.comcast.net] has quit [Ping timeout: 240 seconds] 07:24 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:edc:8931:b0c4:3f36:e776] has joined #bitcoin-core-pr-reviews 07:29 -!- nothingmuch [~nothingmu@unaffiliated/nothingmuch] has joined #bitcoin-core-pr-reviews 08:30 < michaelfolkson> Agreed. Could eventually link to PRs with the good first review label on the Bitcoin Core PR review site too. 08:49 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:edc:8931:b0c4:3f36:e776] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 09:01 < jonatack> Next review club notes and questions PR is here: https://github.com/bitcoin-core-review-club/website/pull/253 09:02 < jonatack> If anyone has good ideas for some interesting meeting questions, lmk! 09:11 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-pr-reviews 10:00 < michaelfolkson> I like the warm up questions. Especially when there have been previous review clubs covering a topic. Sometimes need a reminder before diving into the PR 10:00 < brikk> the SetSpecial method name strikes me as odd, is there a reason for this? also the use of constants look inconsistent to me. 10:01 < brikk> L247 in particular 10:01 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 10:02 < jonatack> michaelfolkson: Thanks for having a look. Just added a 3rd warmup question and am pretty close to done, I think. Yes, idea is to hit the ground running by recapping and covering the practicals. 10:03 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-pr-reviews 10:03 < jonatack> brikk: interesting. that code was just changed this afternoon: git diff 9eb5b08 e55631e 10:04 < jonatack> when vasild added the tor v3 address parsing per sipa's review request 10:06 < jonatack> brikk: maybe the answer is partly here: https://github.com/bitcoin/bitcoin/pull/19845/files#diff-b64569708508232923e5fe3059396334L238 10:54 < jonatack> Notes and questions are up for Wednesday at https://bitcoincore.reviews/19845 10:56 -!- jeremyrubin [~jr@2601:645:c200:f539:bd31:eec8:b7c2:d5b0] has quit [Remote host closed the connection] 10:57 -!- jeremyrubin [~jr@2601:645:c200:f539:10b4:95bb:270b:b13d] has joined #bitcoin-core-pr-reviews 11:00 < brikk> jonatack: thanks I'll have a look 11:01 < brikk> for once I might be able to say yes I did review the PR come Wednesday :) 11:40 < jonatack> brikk: great! 👍 12:30 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Ping timeout: 240 seconds] 12:33 < vasild> brikk: SetSpecial() looks weird to mee too, but I am trying to minimize the amount of changes. I once slipped into doing similar improvements, not strictly related to what's necessary and the patch grew so big that I threw it away 12:33 -!- reallll is now known as belcher 13:12 -!- shaunsun_ [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has quit [Ping timeout: 240 seconds] 13:56 -!- shaunsun [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has joined #bitcoin-core-pr-reviews 14:14 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 258 seconds] 14:15 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-pr-reviews 15:24 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 15:33 -!- gzhao408 [uid453516@gateway/web/irccloud.com/x-gchlchkgfpwszyqx] has joined #bitcoin-core-pr-reviews 15:36 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Ping timeout: 240 seconds] 15:37 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-pr-reviews 15:59 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 16:01 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 16:26 -!- shaunsun [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has quit [Ping timeout: 246 seconds] 17:15 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-pr-reviews 17:15 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection] 17:16 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-pr-reviews 18:37 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 18:44 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 19:00 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:edc:8931:b0c4:3f36:e776] has joined #bitcoin-core-pr-reviews 19:05 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:edc:8931:b0c4:3f36:e776] has quit [Ping timeout: 260 seconds] 19:42 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:edc:8931:b0c4:3f36:e776] has joined #bitcoin-core-pr-reviews 20:11 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:edc:8931:b0c4:3f36:e776] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 21:53 -!- da39a3ee5e6b4b0d [~textual@171.5.26.89] has joined #bitcoin-core-pr-reviews 22:36 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-pr-reviews 22:41 < brikk> vasild: valid point! It's a slippery slope. I'm thinking about when future me returns to this for TORv4 will I once more wonder what's this mystery method doing... 22:54 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 23:04 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-pr-reviews 23:13 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 23:14 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-pr-reviews 23:24 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 23:26 -!- da39a3ee5e6b4b0d [~textual@171.5.26.89] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 23:34 -!- da39a3ee5e6b4b0d [~textual@171.5.26.89] has joined #bitcoin-core-pr-reviews