--- Day changed Sat Sep 12 2020 00:22 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 272 seconds] 00:23 -!- fjahr [sid374480@gateway/web/irccloud.com/x-vddusacsufeecjsf] has quit [Ping timeout: 240 seconds] 00:24 -!- fjahr [sid374480@gateway/web/irccloud.com/x-iivtmbwrteacwior] has joined #bitcoin-core-pr-reviews 00:24 -!- hebasto [sid449604@gateway/web/irccloud.com/x-enlpbaqgczxghrrp] has quit [Ping timeout: 240 seconds] 00:25 -!- hebasto [sid449604@gateway/web/irccloud.com/x-fyeaxskmkfbkrfcj] has joined #bitcoin-core-pr-reviews 00:25 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-rgeootbyrmmcnbgw] has quit [Ping timeout: 244 seconds] 00:25 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-uxmiuemqnuserojw] has joined #bitcoin-core-pr-reviews 00:25 -!- drbrule [sid395654@gateway/web/irccloud.com/x-nlbeknxvkdskxozj] has quit [Ping timeout: 240 seconds] 00:26 -!- illlicit_ [uid109953@gateway/web/irccloud.com/x-jeooccqibejsvstm] has quit [Ping timeout: 244 seconds] 00:28 -!- digi_james [sid281632@gateway/web/irccloud.com/x-sylyhzpfflhldnib] has quit [Ping timeout: 244 seconds] 00:28 -!- RubenSomsen_ [sid301948@gateway/web/irccloud.com/x-lgebcwdtscmlevxn] has joined #bitcoin-core-pr-reviews 00:28 -!- drbrule [sid395654@gateway/web/irccloud.com/x-tngpbubfdzzoidop] has joined #bitcoin-core-pr-reviews 00:28 -!- illlicit_ [uid109953@gateway/web/irccloud.com/x-oxpdcwzvdvxviizi] has joined #bitcoin-core-pr-reviews 00:29 -!- digi_james [sid281632@gateway/web/irccloud.com/x-nimzqushrovqmhav] has joined #bitcoin-core-pr-reviews 00:30 -!- RubenSomsen [sid301948@gateway/web/irccloud.com/x-jtzagdzztgwrkvbx] has quit [Ping timeout: 244 seconds] 00:30 -!- RubenSomsen_ is now known as RubenSomsen 01:05 -!- da39a3ee5e6b4b0d [~textual@171.5.26.89] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 01:12 -!- da39a3ee5e6b4b0d [~textual@mx-ll-171.5.26-89.dynamic.3bb.co.th] has joined #bitcoin-core-pr-reviews 01:20 -!- da39a3ee5e6b4b0d [~textual@mx-ll-171.5.26-89.dynamic.3bb.co.th] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 01:23 -!- jonatack [~jon@37.173.136.184] has joined #bitcoin-core-pr-reviews 02:11 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Ping timeout: 256 seconds] 03:20 -!- Bessie72Pfanners [~Bessie72P@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-pr-reviews 03:25 -!- Bessie72Pfanners [~Bessie72P@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 244 seconds] 03:45 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection] 03:45 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-pr-reviews 03:59 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 04:01 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 04:46 -!- jonatack [~jon@37.173.136.184] has quit [Read error: Connection reset by peer] 05:52 -!- shaunsun [~shaunsun@c-76-26-29-34.hsd1.fl.comcast.net] has joined #bitcoin-core-pr-reviews 05:53 -!- shaunsun_ [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has joined #bitcoin-core-pr-reviews 05:57 -!- shaunsun [~shaunsun@c-76-26-29-34.hsd1.fl.comcast.net] has quit [Ping timeout: 265 seconds] 05:57 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-pr-reviews 06:33 -!- shaunsun__ [~shaunsun@c-76-26-29-34.hsd1.fl.comcast.net] has joined #bitcoin-core-pr-reviews 06:35 -!- shaunsun_ [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has quit [Ping timeout: 240 seconds] 06:37 -!- shaunsun_ [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has joined #bitcoin-core-pr-reviews 06:37 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Quit: ZNC 1.7.5 - https://znc.in] 06:38 -!- da39a3ee5e6b4b0d [~textual@mx-ll-171.5.26-89.dynamic.3bb.co.th] has joined #bitcoin-core-pr-reviews 06:40 -!- shaunsun__ [~shaunsun@c-76-26-29-34.hsd1.fl.comcast.net] has quit [Ping timeout: 244 seconds] 06:41 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-pr-reviews 06:50 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-ktcafifpocehctxo] has quit [Ping timeout: 272 seconds] 06:51 -!- Aleru [sid403553@gateway/web/irccloud.com/x-yxdzsqakuuwgqset] has quit [Ping timeout: 272 seconds] 06:52 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-kakrvzdysumbeepk] has joined #bitcoin-core-pr-reviews 06:53 -!- Aleru [sid403553@gateway/web/irccloud.com/x-xqtgjdkzjabnbakl] has joined #bitcoin-core-pr-reviews 06:54 -!- robot-dreams [uid463268@gateway/web/irccloud.com/x-mmbmzvvtoffklqyn] has quit [Ping timeout: 272 seconds] 06:55 -!- robot-dreams [sid463268@gateway/web/irccloud.com/x-ftfuuhnaynlkkapv] has joined #bitcoin-core-pr-reviews 07:05 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-pr-reviews 07:06 -!- jonatack [~jon@static-176-139-55-163.ftth.abo.bbox.fr] has joined #bitcoin-core-pr-reviews 07:09 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds] 07:10 -!- jonatack [~jon@static-176-139-55-163.ftth.abo.bbox.fr] has quit [Ping timeout: 244 seconds] 07:12 -!- jonatack [~jon@109.232.227.138] has joined #bitcoin-core-pr-reviews 08:07 -!- gleb [~gleb@178.150.137.228] has quit [Ping timeout: 258 seconds] 08:12 -!- gzhao408 [uid453516@gateway/web/irccloud.com/x-gchlchkgfpwszyqx] has quit [Quit: Connection closed for inactivity] 08:26 -!- jonatack [~jon@109.232.227.138] has quit [Ping timeout: 244 seconds] 08:53 < michaelfolkson> Seems a good candidate for a "good first review" label https://github.com/bitcoin/bitcoin/pull/19947 09:00 -!- mikerah[m] [mikerahmat@gateway/shell/matrix.org/x-syampplrjuluxcda] has quit [Quit: Idle for 30+ days] 09:01 -!- belcher_ is now known as belcher 09:05 -!- shaunsun_ [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has quit [Ping timeout: 240 seconds] 09:17 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-pr-reviews 09:22 -!- da39a3ee5e6b4b0d [~textual@mx-ll-171.5.26-89.dynamic.3bb.co.th] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 09:54 -!- gleb [~gleb@178.150.137.228] has joined #bitcoin-core-pr-reviews 10:28 -!- gzhao408 [uid453516@gateway/web/irccloud.com/x-cjmubllmbbpfrloq] has joined #bitcoin-core-pr-reviews 10:38 -!- gleb [~gleb@178.150.137.228] has quit [Ping timeout: 244 seconds] 11:02 -!- shaunsun_ [~shaunsun@c-76-26-29-34.hsd1.fl.comcast.net] has joined #bitcoin-core-pr-reviews 11:04 -!- shaunsun__ [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has joined #bitcoin-core-pr-reviews 11:07 -!- shaunsun_ [~shaunsun@c-76-26-29-34.hsd1.fl.comcast.net] has quit [Ping timeout: 244 seconds] 11:12 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-pr-reviews 13:17 -!- thomasb06 [2ec100e0@gateway/web/cgi-irc/kiwiirc.com/ip.46.193.0.224] has joined #bitcoin-core-pr-reviews 13:19 < thomasb06> Hello. Would you have a link that describes how transaction validity are checked, I'm trying to verify one by hand? 13:21 < thomasb06> There are two code samples here but the link are broken: https://en.bitcoin.it/wiki/OP_CHECKSIG#Code_samples_and_raw_dumps 13:22 -!- gzhao408 [uid453516@gateway/web/irccloud.com/x-cjmubllmbbpfrloq] has quit [Quit: Connection closed for inactivity] 13:48 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 14:22 -!- molz_ [~mol@unaffiliated/molly] has quit [Read error: Connection reset by peer] 15:09 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 15:59 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 16:01 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 16:09 -!- thomasb06 [2ec100e0@gateway/web/cgi-irc/kiwiirc.com/ip.46.193.0.224] has quit [Quit: Connection closed] 16:24 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-pr-reviews 16:40 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 17:06 -!- shaunsun__ [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has quit [Quit: Leaving] 17:29 -!- da39a3ee5e6b4b0d [~textual@171.5.26.89] has joined #bitcoin-core-pr-reviews 19:01 -!- da39a3ee5e6b4b0d [~textual@171.5.26.89] has quit [Ping timeout: 240 seconds] 20:02 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:27da:5173:1af1:20b0:df33] has joined #bitcoin-core-pr-reviews 20:03 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:27da:5173:1af1:20b0:df33] has quit [Client Quit] 20:04 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:27da:5173:1af1:20b0:df33] has joined #bitcoin-core-pr-reviews 20:44 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 244 seconds] 20:46 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Ping timeout: 244 seconds] 20:50 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-pr-reviews 21:15 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 21:16 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 21:49 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:27da:5173:1af1:20b0:df33] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 21:51 -!- gleb [~gleb@178.150.137.228] has joined #bitcoin-core-pr-reviews 23:41 < jonatack> thomasb06: maybe look at class MemPoolAccept in validation.cpp: PreChecks, PolicyScriptChecks, ConsensusScriptChecks, Finalize, CheckFeeRate 23:45 < jonatack> grep the codebase for OP_CHECKSIG if that's what you are looking for, or look at the functional tests for practical examples 23:48 -!- Netsplit *.net <-> *.split quits: wumpus, paultroon, fronti 23:48 -!- Netsplit *.net <-> *.split quits: kristapsk, ghost43, vasild, jb55, davterra 23:52 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 240 seconds] 23:53 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-pr-reviews