--- Day changed Sun Sep 13 2020 00:20 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-pr-reviews 00:25 -!- wumpus [~ircclient@pdpc/supporter/professional/wumpus] has joined #bitcoin-core-pr-reviews 00:25 -!- fronti [~fronti@irc.fh-biergarten.de] has joined #bitcoin-core-pr-reviews 00:25 -!- paultroon [rich@2600:3c00::f03c:92ff:fe8e:dce6] has joined #bitcoin-core-pr-reviews 00:27 -!- Netsplit over, joins: davterra 00:28 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:27da:5173:1af1:20b0:df33] has joined #bitcoin-core-pr-reviews 00:29 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-pr-reviews 00:32 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 00:33 -!- jonatack [~jon@37.165.131.50] has joined #bitcoin-core-pr-reviews 00:37 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-pr-reviews 00:54 -!- jonatack [~jon@37.165.131.50] has quit [Ping timeout: 244 seconds] 01:08 -!- jonatack [~jon@37.165.131.50] has joined #bitcoin-core-pr-reviews 01:13 -!- jonatack [~jon@37.165.131.50] has quit [Ping timeout: 244 seconds] 01:14 -!- jonatack [~jon@109.202.107.20] has joined #bitcoin-core-pr-reviews 02:11 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:27da:5173:1af1:20b0:df33] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 03:18 -!- Maeve38Emard [~Maeve38Em@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-pr-reviews 03:23 -!- Maeve38Emard [~Maeve38Em@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 240 seconds] 03:25 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-pr-reviews 03:29 < michaelfolkson> By hand what do you mean thomasb06? You are going through the raw hex? https://www.siliconian.com/component/content/article?id=22:deconstructing-bitcoin-transactions 03:35 -!- prayank [~androirc@2409:4053:2e95:f4cc:9539:fdac:7fb5:8fbf] has joined #bitcoin-core-pr-reviews 03:35 -!- prayank [~androirc@2409:4053:2e95:f4cc:9539:fdac:7fb5:8fbf] has quit [Read error: Connection reset by peer] 03:35 < michaelfolkson> I don't think verifying the signature by hand is a good first exercise :) 03:37 < michaelfolkson> Signature verification is handled by libsecp https://github.com/bitcoin-core/secp256k1 03:56 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:27da:5173:1af1:20b0:df33] has joined #bitcoin-core-pr-reviews 03:59 < jonatack> To follow up on the recent discussion about PR-specific instructions on testing, just opened https://github.com/bitcoin/bitcoin/pull/19951 with detailed steps for reviewers on how to manually test it. 04:00 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 04:02 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 04:15 < michaelfolkson> Cool, looks good jonatack 04:51 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:27da:5173:1af1:20b0:df33] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 04:58 < jonatack> michaelfolkson: thanks 05:05 < brikk> jonatack: super! is this also suitable for a good first review label? 05:07 < jonatack> brikk: i think so 05:09 < jonatack> brikk: though I'm seeing failures only on travis xenial no wallet that pass locally when compiling without --disable-wallet and all the other CIs including bitcoin_builds are fine with it 05:09 < jonatack> i guess i have to research what is special about xenial 05:31 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Quit: pinheadmz] 06:24 -!- jonatack [~jon@109.202.107.20] has quit [Ping timeout: 244 seconds] 07:05 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-pr-reviews 07:08 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 244 seconds] 07:23 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-pr-reviews 07:35 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:2f16:b578:1b5d:3f74:84ef] has joined #bitcoin-core-pr-reviews 09:31 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 09:31 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection] 09:31 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-pr-reviews 09:31 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-pr-reviews 10:32 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 10:34 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 244 seconds] 10:38 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-pr-reviews 10:46 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Read error: Connection reset by peer] 10:52 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-pr-reviews 10:57 -!- gzhao408 [uid453516@gateway/web/irccloud.com/x-itaiibsmrcisfjzl] has joined #bitcoin-core-pr-reviews 12:09 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 12:52 -!- belcher_ is now known as belcher 13:34 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 13:36 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-pr-reviews 13:36 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 13:38 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-pr-reviews 13:51 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 13:52 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 244 seconds] 13:52 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-pr-reviews 14:18 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-pr-reviews 14:55 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 14:56 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-pr-reviews 16:00 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 16:01 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 16:39 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 16:40 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-pr-reviews 17:03 -!- seven_ [~seven@2a00:ee2:410c:1300:8802:b46b:3786:7e5a] has quit [Ping timeout: 260 seconds] 17:22 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds] 17:24 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-pr-reviews 17:30 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 17:31 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-pr-reviews 17:32 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 17:33 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-pr-reviews 17:39 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 17:40 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-pr-reviews 17:45 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds] 17:59 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-pr-reviews 19:45 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection] 23:17 < jonatack> brikk: michaelfolkson: CI issue resolved :) 23:26 < brikk> jonatack: thanks! I'm a bit confused though, was there also a macOS issue? 23:31 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 240 seconds]