--- Day changed Mon Sep 14 2020 00:17 -!- jonatack [~jon@109.232.227.133] has joined #bitcoin-core-pr-reviews 00:17 -!- jonatack [~jon@109.232.227.133] has quit [Client Quit] 00:18 -!- jonatack [~jon@109.232.227.133] has joined #bitcoin-core-pr-reviews 00:22 < jonatack> brikk: yes, the last travis ci job on macOS GUI no depends turned out to be the oddball one (macOS on https://bitcoinbuilds.org/ was passing fine all the while), some stacks handle it differently but we managed to find enough common ground for the test to work with all the different CI jobs 00:22 < jonatack> (https://github.com/bitcoin/bitcoin/pull/19951#issuecomment-691725611) 00:28 -!- seven_ [~seven@2a00:ee2:410c:1300:45e4:db77:7865:1c38] has joined #bitcoin-core-pr-reviews 01:45 -!- jeremyrubin [~jr@2601:645:c200:f539:10b4:95bb:270b:b13d] has quit [Remote host closed the connection] 01:46 -!- jeremyrubin [~jr@c-24-4-56-108.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 02:44 -!- robot-dreams [sid463268@gateway/web/irccloud.com/x-ftfuuhnaynlkkapv] has quit [Ping timeout: 244 seconds] 02:45 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-kakrvzdysumbeepk] has quit [Ping timeout: 244 seconds] 02:45 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Quit: Leaving] 02:45 -!- robot-dreams [sid463268@gateway/web/irccloud.com/x-rpqnqyqggmvfkivo] has joined #bitcoin-core-pr-reviews 02:46 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-pr-reviews 02:46 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-jkeelzewuuuzwtst] has joined #bitcoin-core-pr-reviews 02:51 -!- jonatack [~jon@109.232.227.133] has quit [Ping timeout: 256 seconds] 02:54 < brikk> huh, "test/net_tests.cpp:261: error: in "net_tests/cnetaddr_basic": check addr_str == scoped_addr || addr_str == link_local_edge_case has failed" when I test it on my mac 03:18 -!- Kari11Feeney [~Kari11Fee@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-pr-reviews 03:23 -!- Kari11Feeney [~Kari11Fee@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 264 seconds] 03:28 -!- jonatack [~jon@37.164.23.29] has joined #bitcoin-core-pr-reviews 03:42 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:2f16:b578:1b5d:3f74:84ef] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 03:43 -!- da39a3ee5e6b4b0d [~textual@171.5.28.208] has joined #bitcoin-core-pr-reviews 03:59 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 04:01 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 04:03 -!- da39a3ee5e6b4b0d [~textual@171.5.28.208] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 04:37 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:2f16:b578:1b5d:3f74:84ef] has joined #bitcoin-core-pr-reviews 04:43 -!- jonatack [~jon@37.164.23.29] has quit [Ping timeout: 260 seconds] 04:51 -!- seven__ [~seven@BSN-77-101-62.static.siol.net] has joined #bitcoin-core-pr-reviews 04:53 -!- seven_ [~seven@2a00:ee2:410c:1300:45e4:db77:7865:1c38] has quit [Ping timeout: 244 seconds] 04:56 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-pr-reviews 05:09 -!- seven_ [~seven@BSN-77-101-62.static.siol.net] has joined #bitcoin-core-pr-reviews 05:10 -!- seven__ [~seven@BSN-77-101-62.static.siol.net] has quit [Ping timeout: 258 seconds] 05:17 < vasild> brikk: actually, CNetAddr::SetSpecial() may start to make more sense when we add support for I2P - if that method is extended to also recognize i2p addresses 05:49 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [Ping timeout: 260 seconds] 05:51 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has joined #bitcoin-core-pr-reviews 05:51 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has quit [Changing host] 05:51 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-pr-reviews 06:13 < brikk> vasild: agree 06:24 < jonatack> vasild: am re-reviewing 19845 06:25 < jonatack> "New outbound peer connected: version: 70016, blocks=648258, peer=162, peeraddr=kpgvmscirrdqpekbqjsvw5teanhatztpp2gl6eee4zkowvwfxwenqaid.onion:8333 (full-relay)" 06:31 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer] 06:32 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-pr-reviews 06:32 < vasild> It works! 06:53 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:2f16:b578:1b5d:3f74:84ef] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 07:05 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-pr-reviews 07:08 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 244 seconds] 07:32 -!- shaunsun [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has joined #bitcoin-core-pr-reviews 08:36 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-pr-reviews 08:42 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 258 seconds] 08:57 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 10:42 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 10:44 -!- shaunsun [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has quit [Remote host closed the connection] 10:53 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-pr-reviews 11:53 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 12:14 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 12:23 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-pr-reviews 13:24 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 13:47 -!- shaunsun [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has joined #bitcoin-core-pr-reviews 14:01 -!- smartfox96 [6a331f44@106.51.31.68] has joined #bitcoin-core-pr-reviews 14:09 -!- smartfox96 [6a331f44@106.51.31.68] has quit [Ping timeout: 245 seconds] 15:11 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 16:00 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 16:01 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 16:11 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 16:12 < jaybny> hey - heard there is there a need for bip reviews? 16:36 -!- shaunsun [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has quit [Ping timeout: 256 seconds] 17:51 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has quit [Ping timeout: 264 seconds] 17:51 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 18:04 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:2f16:b578:1b5d:3f74:84ef] has joined #bitcoin-core-pr-reviews 18:05 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 18:06 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 18:18 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection] 18:21 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has quit [Ping timeout: 240 seconds] 18:21 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 18:22 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 18:31 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 18:45 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 19:41 -!- da39a3ee5e6b4b0d [~textual@2403:6200:8876:2f16:b578:1b5d:3f74:84ef] has quit [Ping timeout: 240 seconds] 20:16 -!- da39a3ee5e6b4b0d [~textual@171.5.25.246] has joined #bitcoin-core-pr-reviews 21:08 -!- jb551 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-pr-reviews 21:08 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds] 21:11 -!- gleb5 [~gleb@178.150.137.228] has joined #bitcoin-core-pr-reviews 21:13 -!- gleb [~gleb@178.150.137.228] has quit [Ping timeout: 244 seconds] 21:13 -!- gleb5 is now known as gleb 21:19 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 21:35 -!- jb551 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds] 21:48 -!- jb551 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-pr-reviews 21:52 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has quit [Ping timeout: 240 seconds] 21:52 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 22:12 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 23:31 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 240 seconds] 23:40 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Ping timeout: 244 seconds] 23:53 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-pr-reviews