--- Day changed Fri Sep 18 2020 00:07 -!- hugohn [sid304114@gateway/web/irccloud.com/x-lapnxcvmvfrikkev] has joined #bitcoin-core-pr-reviews 00:09 -!- jamesob [sid180710@gateway/web/irccloud.com/x-jkrjxdqaspqhedhy] has joined #bitcoin-core-pr-reviews 00:09 -!- GoldmanSats__ [sid428607@gateway/web/irccloud.com/x-wsyptzydclrzzolx] has joined #bitcoin-core-pr-reviews 00:42 -!- jonatack [~jon@37.172.86.203] has joined #bitcoin-core-pr-reviews 00:52 -!- S3RK [~s3rk@47.246.66.112] has quit [Remote host closed the connection] 00:52 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-pr-reviews 01:03 -!- da39a3ee5e6b4b0d [~textual@171.5.162.140] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 01:04 -!- jonatack [~jon@37.172.86.203] has quit [Ping timeout: 240 seconds] 01:05 -!- jonatack [~jon@213.152.161.133] has joined #bitcoin-core-pr-reviews 01:07 -!- gzhao408 [uid453516@gateway/web/irccloud.com/x-itaiibsmrcisfjzl] has quit [Quit: Connection closed for inactivity] 01:25 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has quit [Quit: The Lounge - https://thelounge.chat] 01:32 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has joined #bitcoin-core-pr-reviews 01:46 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has quit [Quit: The Lounge - https://thelounge.chat] 01:47 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has joined #bitcoin-core-pr-reviews 01:47 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has quit [Client Quit] 01:48 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has joined #bitcoin-core-pr-reviews 01:48 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has quit [Client Quit] 01:49 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has joined #bitcoin-core-pr-reviews 01:50 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has quit [Client Quit] 01:51 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has joined #bitcoin-core-pr-reviews 01:52 -!- sharknado9000[m] [sharknado9@gateway/shell/matrix.org/x-ljofwvuyghyrjbia] has quit [Quit: killed] 01:53 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-uxmiuemqnuserojw] has quit [Quit: killed] 01:58 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has quit [Quit: The Lounge - https://thelounge.chat] 01:59 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has joined #bitcoin-core-pr-reviews 02:02 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has quit [Client Quit] 02:03 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has joined #bitcoin-core-pr-reviews 02:03 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has quit [Client Quit] 02:04 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has joined #bitcoin-core-pr-reviews 02:06 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has quit [Client Quit] 02:06 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has joined #bitcoin-core-pr-reviews 02:07 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has quit [Client Quit] 02:08 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has joined #bitcoin-core-pr-reviews 02:15 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-etwcygzgunvfvtct] has joined #bitcoin-core-pr-reviews 02:19 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-etwcygzgunvfvtct] has quit [Remote host closed the connection] 02:23 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-gbvfwkusvwddsrdd] has joined #bitcoin-core-pr-reviews 02:41 -!- sharknado9000[m] [sharknado9@gateway/shell/matrix.org/x-nngucnbyobyecqag] has joined #bitcoin-core-pr-reviews 02:52 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 02:57 -!- jonatack [~jon@213.152.161.133] has quit [Ping timeout: 240 seconds] 02:57 -!- midnight [~midnight@unaffiliated/midnightmagic] has quit [Ping timeout: 240 seconds] 03:00 -!- jonatack [~jon@37.172.86.203] has joined #bitcoin-core-pr-reviews 03:02 -!- S3RK [~s3rk@47.246.66.112] has quit [Remote host closed the connection] 03:02 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-pr-reviews 03:04 -!- jonatack [~jon@37.172.86.203] has quit [Read error: Connection reset by peer] 03:07 -!- S3RK [~s3rk@47.246.66.112] has quit [Remote host closed the connection] 03:07 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-pr-reviews 03:10 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 03:11 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 03:15 -!- da39a3ee5e6b4b0d [~textual@mx-ll-171.5.162-140.dynamic.3bb.co.th] has joined #bitcoin-core-pr-reviews 03:18 -!- midnight [~midnight@unaffiliated/midnightmagic] has joined #bitcoin-core-pr-reviews 03:20 -!- Joanny57Fadel [~Joanny57F@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-pr-reviews 03:26 -!- Joanny57Fadel [~Joanny57F@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 272 seconds] 04:03 -!- da39a3ee5e6b4b0d [~textual@mx-ll-171.5.162-140.dynamic.3bb.co.th] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 04:28 -!- S3RK [~s3rk@47.246.66.112] has quit [Remote host closed the connection] 04:29 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-pr-reviews 04:44 -!- da39a3ee5e6b4b0d [~textual@mx-ll-171.5.162-140.dynamic.3bb.co.th] has joined #bitcoin-core-pr-reviews 05:34 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection] 05:34 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 05:46 -!- jonatack [~jon@37.172.22.3] has joined #bitcoin-core-pr-reviews 05:46 -!- da39a3ee5e6b4b0d [~textual@mx-ll-171.5.162-140.dynamic.3bb.co.th] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 06:25 -!- da39a3ee5e6b4b0d [~textual@mx-ll-171.5.162-140.dynamic.3bb.co.th] has joined #bitcoin-core-pr-reviews 06:57 -!- S3RK [~s3rk@47.246.66.112] has quit [Remote host closed the connection] 06:57 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-pr-reviews 07:41 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 07:50 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 07:52 -!- da39a3ee5e6b4b0d [~textual@mx-ll-171.5.162-140.dynamic.3bb.co.th] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 08:13 -!- jonatack [~jon@37.172.22.3] has quit [Read error: Connection reset by peer] 08:29 -!- gzhao408 [uid453516@gateway/web/irccloud.com/x-zhksnfwlusepcsee] has joined #bitcoin-core-pr-reviews 08:39 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-pr-reviews 08:40 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection] 08:40 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-pr-reviews 08:51 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 08:56 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 08:59 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 09:00 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 09:03 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 09:04 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 09:04 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 09:06 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 09:40 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 09:40 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 09:49 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has quit [Quit: jaybny] 09:57 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 10:00 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 11:17 < michaelfolkson> Paper from 2014 "Bitcoin over Tor isn't a good idea" https://arxiv.org/abs/1410.6079 :) 11:35 < emzy> michaelfolkson: Tor only, I think. 11:53 < jonatack> michaelfolkson: https://github.com/bitcoin-core/gui/pull/86#issuecomment-692115953 11:56 < jonatack> IIRC countermeasures include BIP324 v2 encrypted p2p in the future, and using addnode liberally in your bitcoin.conf file to ensure connection to many good onion peers (i recommend this, you can have many good peers very quickly even if, like me, you have to restart often for dev/testing needs) 11:58 < jonatack> ISTM i've read matt corallo and sipa both writing positive things about using addnode as a preventative anti-eclipse measure 11:59 < sipa> addnode is great, but i wouldn't use it for unknown peers 12:00 < sipa> use it for your own nodes, or nodes of people/entities you know 12:00 < jonatack> yes, people you know 12:00 < sipa> tor only has obvious problems because there is no cost to creating an onion address 12:01 < sipa> so an attacker who creates 500000 onion addresses all pointing to his own node will likely get ~all outgoing connections from tor-only nodes 12:01 < sipa> this isn't possible in IPv4/IPv6 without getting access to hundreds of local networks (and probably more with asmap) 12:02 < jonatack> i wonder if tor will implement light POW against this 12:02 < emzy> I have all my nodes addnode each other. 12:02 < sipa> jonatack: it's not a problem with tor itself per se - it's our usage of rumouring onion addresses 12:03 < jonatack> "our" as in bitcoin core? 12:04 < sipa> as in bitcoin P2P protocol 12:05 < sipa> arguably it's an abuse of hidden services, or at least a strange usage 12:12 -!- belcher_ is now known as belcher 12:13 < emzy> We could use tcp to ask the dnsseeds for onion addresses. 12:13 < emzy> Over DNS. 12:15 < emzy> But best is not use exit nodes at all. So forget it. :) 12:55 < brikk> I would like to improve the test coverage on PR #19845 and the changes for EncodeBase32 with test cases when padding=fale. How do I go about doing that in practise? 13:50 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-pr-reviews 14:16 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-pr-reviews 15:10 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 15:11 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 15:12 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 15:24 -!- jeremyrubin [~jr@2601:645:c200:f539:5dd1:c61b:87f5:f752] has quit [Read error: Connection reset by peer] 15:25 -!- jeremyrubin [~jr@2601:645:c200:f539:411d:67a9:6f1c:30f9] has joined #bitcoin-core-pr-reviews 16:35 -!- meshcollider [meshcollid@gateway/shell/ircnow/x-zojudcrfkwmoipwe] has quit [Ping timeout: 260 seconds] 17:32 -!- seven_ [~seven@2a00:ee2:410c:1300:2c13:5de7:f8d1:a01a] has quit [Ping timeout: 272 seconds] 17:54 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection] 17:54 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 18:19 -!- meshcollider [meshcollid@gateway/shell/ircnow/x-bxvhpqzkrscwvoog] has joined #bitcoin-core-pr-reviews 18:20 -!- emzy [~quassel@unaffiliated/emzy] has quit [Ping timeout: 272 seconds] 19:52 -!- da39a3ee5e6b4b0d [~textual@mx-ll-171.5.162-140.dynamic.3bb.co.th] has joined #bitcoin-core-pr-reviews 20:13 -!- da39a3ee5e6b4b0d [~textual@mx-ll-171.5.162-140.dynamic.3bb.co.th] has quit [Ping timeout: 258 seconds] 20:48 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 20:49 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has quit [Client Quit] 21:31 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection] 21:32 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-pr-reviews 21:51 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 22:28 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has quit [Quit: jaybny] 22:46 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 23:25 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-pr-reviews 23:40 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-pr-reviews 23:42 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 260 seconds]