--- Day changed Sat Sep 19 2020 00:32 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 00:34 -!- gzhao408 [uid453516@gateway/web/irccloud.com/x-zhksnfwlusepcsee] has quit [Quit: Connection closed for inactivity] 00:35 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 00:40 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 00:42 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 00:49 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 01:01 -!- S3RK [~s3rk@47.246.66.112] has quit [Remote host closed the connection] 01:02 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-pr-reviews 01:39 -!- seven_ [~seven@2a00:ee2:410c:1300:689b:f743:86a7:2258] has joined #bitcoin-core-pr-reviews 02:31 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 02:34 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-pr-reviews 02:35 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 02:38 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-pr-reviews 02:51 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 02:58 -!- S3RK [~s3rk@47.246.66.112] has quit [Remote host closed the connection] 02:59 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-pr-reviews 03:00 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has quit [Quit: jaybny] 03:03 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 03:10 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 03:12 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 03:12 -!- bad_duck [~arthur@62.210.66.225] has quit [Ping timeout: 258 seconds] 03:18 -!- Opal84Gusikowski [~Opal84Gus@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-pr-reviews 03:21 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has quit [Quit: jaybny] 03:23 -!- Opal84Gusikowski [~Opal84Gus@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 272 seconds] 03:28 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 03:47 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has quit [Quit: jaybny] 04:02 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 04:24 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 272 seconds] 04:42 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has quit [Quit: jaybny] 04:53 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer] 04:54 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-pr-reviews 05:11 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 05:13 -!- tralfaz [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-pr-reviews 05:14 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Ping timeout: 240 seconds] 05:35 < jaybny> where do i find tradeoffs made, and based on what assumtions in the taproot feature selection? 05:39 < jaybny> i have some outlier concerns that will probably take some more whitepaper reading to alleviate.. so do i concept ack, since i still plan on reviewing the code before merge? 05:40 < jaybny> https://github.com/bitcoin/bitcoin/pull/19953 05:48 < brikk> jaybny: maybe add your concerns on the PR and others have an opportunity to pitch in and you might get a quick validation or a reason why its not a concern? I would be happy to hear your thoughts 06:01 -!- vindard [~vindard@190.83.165.233] has quit [Ping timeout: 272 seconds] 06:02 < jaybny> will do after i read the 3 bips 06:02 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has quit [Quit: jaybny] 06:05 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 06:09 -!- vindard [~vindard@190.83.165.233] has joined #bitcoin-core-pr-reviews 07:00 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has quit [Quit: jaybny] 07:16 -!- tralfaz is now known as davterra 08:24 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-pr-reviews 09:40 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 10:01 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has quit [Ping timeout: 240 seconds] 10:01 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 10:06 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Quit: jonatack] 10:11 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-pr-reviews 10:12 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has quit [Quit: jaybny] 10:52 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection] 10:52 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 11:31 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Quit: Leaving] 11:46 < michaelfolkson> I don't think it matters jaybny. Given that there are *a lot* of review comments and it is hard to trawl through them all probably do it all in the same comment (once you have reviewed the code) 11:48 < michaelfolkson> I suspect any outlier concerns have probably been addressed by now (in which case it may be better to post them here first). But happy to be surprised 11:49 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 12:37 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has quit [Quit: jaybny] 12:39 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 12:46 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has quit [Quit: jaybny] 14:22 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 14:24 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 14:25 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 15:00 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 15:01 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-pr-reviews 15:10 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 15:17 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 15:47 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 16:00 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has quit [Quit: jaybny] 16:11 -!- dr-orlovsky [~dr-orlovs@31.14.40.19] has joined #bitcoin-core-pr-reviews 16:15 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [] 16:30 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has joined #bitcoin-core-pr-reviews 16:30 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has quit [Changing host] 16:30 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-pr-reviews 17:56 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 18:12 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 18:26 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-pr-reviews 18:28 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection] 18:29 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-pr-reviews 18:44 -!- S3RK [~s3rk@47.246.66.112] has quit [Remote host closed the connection] 18:44 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has quit [Quit: jaybny] 18:44 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-pr-reviews 18:47 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 18:50 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 18:52 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has quit [Client Quit] 18:52 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 18:53 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 18:54 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 19:03 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 19:16 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 19:23 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has quit [Quit: jaybny] 19:25 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 19:25 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has quit [Client Quit] 19:30 -!- S3RK [~s3rk@47.246.66.112] has quit [Remote host closed the connection] 19:31 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-pr-reviews 19:59 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 272 seconds] 20:00 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 20:09 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has quit [Quit: jaybny] 21:03 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 21:22 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 21:22 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has quit [Client Quit] 21:24 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 21:24 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has quit [Client Quit] 21:27 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 21:27 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 21:29 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 246 seconds] 21:43 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 21:44 -!- S3RK [~s3rk@47.246.66.112] has quit [Remote host closed the connection] 21:44 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-pr-reviews 21:44 -!- S3RK [~s3rk@47.246.66.112] has quit [Remote host closed the connection] 21:44 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-pr-reviews 21:45 -!- S3RK [~s3rk@47.246.66.112] has quit [Remote host closed the connection] 21:45 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-pr-reviews 22:25 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 265 seconds] 22:30 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 22:37 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 22:40 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 23:39 -!- reallll [~belcher@unaffiliated/belcher] has joined #bitcoin-core-pr-reviews 23:40 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-pr-reviews 23:42 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Client Quit] 23:42 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Ping timeout: 260 seconds]