--- Day changed Sun Sep 20 2020 00:04 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 00:40 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 00:41 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 02:07 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 03:10 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 03:16 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 03:17 -!- S3RK [~s3rk@47.246.66.112] has quit [Remote host closed the connection] 03:17 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-pr-reviews 03:18 -!- Audra62Boyer [~Audra62Bo@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-pr-reviews 03:23 -!- Audra62Boyer [~Audra62Bo@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 260 seconds] 03:32 -!- tryphe_ is now known as tryphe 03:44 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 265 seconds] 04:13 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 246 seconds] 04:17 -!- emzy [~quassel@2a01:4f8:192:628a::83] has joined #bitcoin-core-pr-reviews 04:17 -!- emzy [~quassel@2a01:4f8:192:628a::83] has quit [Changing host] 04:17 -!- emzy [~quassel@unaffiliated/emzy] has joined #bitcoin-core-pr-reviews 05:16 < michaelfolkson> There are no conversation logs for this channel except for the review club meetings right? 05:19 < michaelfolkson> I'm not saying there should or shouldn't be (I'm not sure) but just checking what the situation is currently 05:46 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 05:53 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 06:04 -!- vindard [~vindard@190.83.165.233] has quit [Ping timeout: 272 seconds] 06:17 -!- vindard [~vindard@190.83.165.233] has joined #bitcoin-core-pr-reviews 06:38 -!- reallll is now known as belcher 06:42 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 06:51 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 272 seconds] 07:01 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 07:02 < michaelfolkson> What do you mean by this brikk? Do you mean how to identify lines of code without tests or how to work out what should be tested on these lines or how to write those tests? Or something else? 07:02 < michaelfolkson> " I would like to improve the test coverage on PR #19845 and the changes for EncodeBase32 with test cases when padding=fale. How do I go about doing that in practise?" 07:07 < michaelfolkson> I think the best resources out there for someone interested in writing good tests are all the tests wrote jnewbery wrote when he first joined the project https://github.com/bitcoin/bitcoin/pulls?page=11&q=is%3Apr+is%3Amerged+author%3Ajnewbery 07:09 < michaelfolkson> Greg also had some good advice on writing tests here https://diyhpl.us/wiki/transcripts/greg-maxwell/greg-maxwell-bitcoin-core-testing/ 07:13 < michaelfolkson> Fabian did a great presentation on the functional test framework at Scaling too https://diyhpl.us/wiki/transcripts/scalingbitcoin/tel-aviv-2019/edgedevplusplus/bitcoin-core-functional-test-framework/ 07:37 < brikk> michaelfolkson: thanks for the links! In this case I'm thinking about the practical approach when I have a test (https://gist.github.com/eriknylund/cd2bcaf9c3b4ada8a304001c2df0bfbd) and I would like to extend PR 19845 do I fork https://github.com/vasild/bitcoin/tree/ser_addrv2_cnetaddr and open a PR into that, do I branch out from https://github.com/bitcoin/bitcoin/pull/19845 and open a separate PR for it? Or wait until it's merged and then 07:37 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 07:38 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-pr-reviews 07:39 < brikk> This time it's quite simple (three lines added) so it's probably just as easy for vasild to add them right into the PR if he touches it, but I'm trying to learn the general approach for when there would be a bigger change in code or test. 07:39 < michaelfolkson> Ah I see brikk. I think forking vasild's fork of Core and opening a PR to that PR branch is probably best approach but someone else can correct me if wrong 07:45 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 07:56 < michaelfolkson> Tests on the added PR functionality are generally added in the same PR that adds that functionality. So it needs to make its way into the PR somehow (assuming vasild is happy with the tests and wants to add them) 08:31 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 272 seconds] 08:31 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 09:16 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 09:20 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 272 seconds] 10:14 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 10:34 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 10:59 -!- worc3131 [~quassel@2a02:c7f:c026:9500:7d0b:65d0:38a4:4786] has joined #bitcoin-core-pr-reviews 11:34 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Read error: Connection reset by peer] 11:35 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 14:09 -!- shesek [~shesek@164.90.217.137] has joined #bitcoin-core-pr-reviews 14:09 -!- shesek [~shesek@164.90.217.137] has quit [Changing host] 14:09 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-pr-reviews 15:09 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 15:11 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 16:14 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Ping timeout: 240 seconds] 16:18 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 16:21 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 272 seconds] 16:29 -!- mol_ [~mol@unaffiliated/molly] has quit [Read error: No route to host] 17:08 -!- seven_ [~seven@2a00:ee2:410c:1300:689b:f743:86a7:2258] has quit [Remote host closed the connection] 17:08 -!- seven_ [~seven@2a00:ee2:410c:1300:5ccd:fc72:6c7a:3cd9] has joined #bitcoin-core-pr-reviews 17:13 -!- seven_ [~seven@2a00:ee2:410c:1300:5ccd:fc72:6c7a:3cd9] has quit [Ping timeout: 272 seconds] 17:21 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 260 seconds] 17:26 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-pr-reviews 17:36 -!- jeremyrubin [~jr@2601:645:c200:f539:411d:67a9:6f1c:30f9] has quit [Ping timeout: 244 seconds] 17:42 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 17:50 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 17:50 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 18:01 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 18:04 -!- S3RK [~s3rk@47.246.66.112] has quit [Remote host closed the connection] 18:04 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-pr-reviews 18:06 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 18:33 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 18:36 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 19:10 -!- jaybny [~jaybny@175.sub-174-194-209.myvzw.com] has joined #bitcoin-core-pr-reviews 19:24 -!- cryptowilson [dfc5cb52@223-197-203-82.static.imsbiz.com] has joined #bitcoin-core-pr-reviews 19:34 -!- jaybny [~jaybny@175.sub-174-194-209.myvzw.com] has quit [Quit: jaybny] 19:35 -!- mol [~mol@unaffiliated/molly] has quit [Read error: Connection reset by peer] 19:35 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 19:39 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 19:41 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 272 seconds] 19:43 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 20:22 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 272 seconds] 20:31 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has quit [Quit: jaybny] 20:33 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 20:50 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 20:58 -!- jeremyrubin [~jr@2607:fb90:27db:6998:7466:2d6e:7660:5d03] has joined #bitcoin-core-pr-reviews 21:02 -!- cryptowilson [dfc5cb52@223-197-203-82.static.imsbiz.com] has quit [Remote host closed the connection] 21:03 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 21:07 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has quit [Client Quit] 21:20 -!- S3RK [~s3rk@47.246.66.112] has quit [] 21:39 -!- rjected_ [~dan@pool-71-184-77-198.bstnma.fios.verizon.net] has joined #bitcoin-core-pr-reviews 21:40 -!- rjected [~dan@pool-71-184-77-198.bstnma.fios.verizon.net] has quit [Ping timeout: 256 seconds] 22:23 -!- wiz [~j@wiz.biz] has quit [Ping timeout: 240 seconds] 22:23 -!- wiz [~j@wiz.biz] has joined #bitcoin-core-pr-reviews 22:24 -!- wiz is now known as Guest39853 22:53 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 23:00 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 23:10 -!- jeremyrubin [~jr@2607:fb90:27db:6998:7466:2d6e:7660:5d03] has quit [Ping timeout: 260 seconds] 23:39 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-pr-reviews 23:43 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 256 seconds]