--- Day changed Mon Sep 21 2020 00:16 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection] 00:17 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-pr-reviews 00:19 < vasild> brikk: in this case just showing me the patch suffices, I will amend the PR with it. 00:20 < vasild> either as a ```diff in the github comments or as you have done in a link to your branch 00:20 -!- seven_ [~seven@2a00:ee2:410c:1300:175:37c1:973a:2bb3] has joined #bitcoin-core-pr-reviews 00:21 < vasild> if it is something bigger you could also have opened a PR in github.com/vasild repo, asking to merge yourfork/yourbranch -> vasild/ser_addrv2_cnetaddr. 00:23 < vasild> one difference between posting the patch in the github comments VS linking to your branch is that the former will continue to exist even after you delete your branch. Somebody may be curious to look at the patch years later. 00:24 < brikk> vasild: thanks! I added it as a comment with the link to the gist, as it was in a file not yet touched by the open PR, so I couldn't comment it easily. You'll find it in the comment related to the padding code in question: https://github.com/bitcoin/bitcoin/pull/19845#discussion_r491201418 00:25 < vasild> yes, I saw the patch during a brief look at the weekend, looks good! 00:25 < brikk> super, good point about the comment too. Would probably better to add the patch right as a comment, because it will no longer exist if I remove the gist at some point in time. 00:29 < vasild> yeah, I prefer to post patches that way. If it is too big, to avoid clutter of github UI, I sometimes surround it by
patch to do foo```diff ... ```
00:29 -!- wullon587 [~wullon@241.243.86.88.rdns.comcable.net] has quit [Ping timeout: 264 seconds] 00:30 < brikk> oh another good point, it's one of these days where I keep learning new things :) 00:31 < brikk> best of days 00:40 < jonatack> nice work brikk 01:02 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 01:04 < brikk> jonatack: thanks 01:26 -!- darosior3 [~darosior@194.36.189.246] has joined #bitcoin-core-pr-reviews 01:27 -!- darosior [~darosior@194.36.189.246] has quit [Ping timeout: 256 seconds] 01:54 -!- darosior3 [~darosior@194.36.189.246] has quit [Read error: Connection reset by peer] 01:54 -!- darosior3 [~darosior@194.36.189.246] has joined #bitcoin-core-pr-reviews 02:10 -!- worc3131 [~quassel@2a02:c7f:c026:9500:7d0b:65d0:38a4:4786] has quit [Remote host closed the connection] 02:11 -!- worc3131 [~quassel@2a02:c7f:c026:9500:7d0b:65d0:38a4:4786] has joined #bitcoin-core-pr-reviews 02:22 -!- darosior3 [~darosior@194.36.189.246] has quit [Quit: ya vps net disruption] 02:23 -!- darosior3 [~darosior@194.36.189.246] has joined #bitcoin-core-pr-reviews 02:32 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 02:51 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 02:53 -!- mol [~mol@unaffiliated/molly] has quit [Read error: Connection reset by peer] 02:53 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 02:59 -!- darosior3 [~darosior@194.36.189.246] has quit [Quit: ya vps net disruption] 02:59 -!- darosior3 [~darosior@194.36.189.246] has joined #bitcoin-core-pr-reviews 03:01 -!- darosior3 [~darosior@194.36.189.246] has quit [Client Quit] 03:01 -!- darosior3 [~darosior@194.36.189.246] has joined #bitcoin-core-pr-reviews 03:04 -!- darosior3 is now known as darosior 03:04 < michaelfolkson> Great question, great answer. Thanks both https://bitcoin.stackexchange.com/questions/99137/i-have-written-a-test-for-an-open-bitcoin-core-pr-should-i-open-a-pr-to-the-aut/99138#99138 03:10 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 03:11 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 03:18 -!- Anastasia27Walte [~Anastasia@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-pr-reviews 03:25 -!- Anastasia27Walte [~Anastasia@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 240 seconds] 03:43 < jonatack> I guess it depends. For "commit-sized" proposals, what I think I've seen done most often is a reviewer providing a link to a commit in their clone of the bitcoin core repo, and the PR author then pulling in the commit, adding it to the PR. 03:48 < jonatack> Or even a link to a branch. Example: https://github.com/bitcoin/bitcoin/pull/19610#issuecomment-670933625 03:54 -!- pinheadm_ [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-pr-reviews 03:55 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Ping timeout: 246 seconds] 03:58 -!- pinheadm_ [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Read error: Connection reset by peer] 03:58 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-pr-reviews 05:07 -!- vindard [~vindard@190.83.165.233] has quit [Remote host closed the connection] 05:08 -!- vindard [~vindard@190.83.165.233] has joined #bitcoin-core-pr-reviews 05:35 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 05:35 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 05:52 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 265 seconds] 06:13 -!- vindard [~vindard@190.83.165.233] has quit [Ping timeout: 240 seconds] 06:16 -!- vindard [~vindard@190.83.165.233] has joined #bitcoin-core-pr-reviews 06:20 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 06:27 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 06:28 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 07:23 -!- tralfaz [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-pr-reviews 07:24 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Disconnected by services] 07:24 -!- tralfaz is now known as davterra 07:38 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 08:15 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-pr-reviews 08:24 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 08:47 -!- jeremyrubin [~jr@2607:fb90:46b:abbb:999b:e43:e518:61eb] has joined #bitcoin-core-pr-reviews 09:26 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 10:30 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-pr-reviews 10:41 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 265 seconds] 10:48 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 10:54 -!- jeremyrubin [~jr@2607:fb90:46b:abbb:999b:e43:e518:61eb] has quit [Ping timeout: 244 seconds] 11:17 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 11:18 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-pr-reviews 11:29 -!- jeremyrubin [~jr@2601:645:c200:f539:84e9:990d:6461:eab6] has joined #bitcoin-core-pr-reviews 11:35 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 11:44 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Ping timeout: 240 seconds] 11:53 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 11:56 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 11:56 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-pr-reviews 12:02 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 12:03 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 12:03 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-pr-reviews 12:06 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 12:17 -!- worc3131 [~quassel@2a02:c7f:c026:9500:7d0b:65d0:38a4:4786] has quit [Ping timeout: 272 seconds] 12:25 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 12:28 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 272 seconds] 12:45 -!- kallewoof [~quassel@240d:1a:759:6000:a7b1:451a:8874:e1ac] has quit [Quit: No Ping reply in 180 seconds.] 12:47 -!- kallewoof [~quassel@240d:1a:759:6000:a7b1:451a:8874:e1ac] has joined #bitcoin-core-pr-reviews 12:51 -!- kallewoof [~quassel@240d:1a:759:6000:a7b1:451a:8874:e1ac] has quit [Client Quit] 12:53 -!- kallewoof [~quassel@240d:1a:759:6000:a7b1:451a:8874:e1ac] has joined #bitcoin-core-pr-reviews 14:01 -!- gzhao408 [uid453516@gateway/web/irccloud.com/x-nlymzppxacrwouot] has joined #bitcoin-core-pr-reviews 14:02 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has quit [Quit: jaybny] 14:02 -!- worc3131 [~quassel@2a02:c7f:c026:9500:7d0b:65d0:38a4:4786] has joined #bitcoin-core-pr-reviews 14:12 -!- worc3131 [~quassel@2a02:c7f:c026:9500:7d0b:65d0:38a4:4786] has quit [Remote host closed the connection] 14:41 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 15:10 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 15:11 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 15:17 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Ping timeout: 240 seconds] 15:42 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-pr-reviews 15:42 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has quit [Quit: jaybny] 15:44 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 15:56 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has quit [Quit: jaybny] 16:35 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 16:38 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 17:54 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 17:57 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 18:06 -!- jeremyrubin [~jr@2601:645:c200:f539:84e9:990d:6461:eab6] has quit [Ping timeout: 260 seconds] 19:27 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 19:30 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 19:56 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 20:01 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 260 seconds] 20:02 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 20:20 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 20:57 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer] 20:57 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-pr-reviews 21:07 -!- takinbo_ [~takinbo@2a01:4f8:160:60aa:fee::10] has quit [Quit: No Ping reply in 180 seconds.] 21:09 -!- takinbo [~takinbo@2a01:4f8:160:60aa:fee::10] has joined #bitcoin-core-pr-reviews 21:09 -!- takinbo [~takinbo@2a01:4f8:160:60aa:fee::10] has quit [Changing host] 21:09 -!- takinbo [~takinbo@unaffiliated/takinbo] has joined #bitcoin-core-pr-reviews 21:29 -!- seven_ [~seven@2a00:ee2:410c:1300:175:37c1:973a:2bb3] has quit [Ping timeout: 246 seconds] 21:37 -!- vindard [~vindard@190.83.165.233] has quit [Ping timeout: 272 seconds] 21:45 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 21:48 -!- vindard [~vindard@190.83.165.233] has joined #bitcoin-core-pr-reviews 22:16 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 22:33 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 23:22 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-pr-reviews 23:22 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 260 seconds] 23:37 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 23:39 -!- reallll [~belcher@unaffiliated/belcher] has joined #bitcoin-core-pr-reviews 23:43 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Ping timeout: 264 seconds] 23:59 -!- reallll is now known as belcher