--- Day changed Wed Sep 23 2020 00:05 -!- jonatack [~jon@37.164.9.222] has quit [Ping timeout: 260 seconds] 00:57 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 246 seconds] 00:58 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 01:09 -!- jonatack_ [~jon@213.152.162.181] has joined #bitcoin-core-pr-reviews 01:09 -!- jonatack_ [~jon@213.152.162.181] has quit [Client Quit] 01:20 -!- jonatack [~jon@213.152.162.181] has joined #bitcoin-core-pr-reviews 03:10 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 03:11 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 03:16 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-pr-reviews 03:20 -!- Troy39Stark [~Troy39Sta@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-pr-reviews 03:25 -!- S3RK [~s3rk@47.246.66.112] has quit [Remote host closed the connection] 03:25 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-pr-reviews 03:25 -!- Troy39Stark [~Troy39Sta@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 272 seconds] 03:43 -!- seven_ [~seven@2a00:ee2:410c:1300:78df:1a24:2eac:9b86] has quit [Ping timeout: 272 seconds] 03:46 < michaelfolkson> Today's PR is just related to uses of sed in the build system right? Not scripted-diffs. We will still use sed in scripted-diffs 03:46 < michaelfolkson> https://github.com/bitcoin/bitcoin/pull/19761 03:48 < michaelfolkson> We have problems with sed on scripted-diffs https://github.com/bitcoin/bitcoin/issues/19815 04:03 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds] 04:09 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [Read error: Connection reset by peer] 04:10 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has joined #bitcoin-core-pr-reviews 04:10 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has quit [Changing host] 04:10 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-pr-reviews 04:18 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-pr-reviews 05:08 -!- jonatack [~jon@213.152.162.181] has quit [Ping timeout: 260 seconds] 05:49 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has quit [Ping timeout: 240 seconds] 06:08 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 06:19 < michaelfolkson> I do feel the culture is moving from one of healthy vigorous discussion to one where disagreements and misunderstandings are perceived as bad faith troublemaking. It concerns me and it is disheartening 06:21 < michaelfolkson> I could be totally wrong on this but I feel you should be able to flag things when you are uncomfortable. https://github.com/bitcoin/bitcoin/pull/19725 06:22 -!- crma [bedb3996@190.219.57.150] has joined #bitcoin-core-pr-reviews 06:22 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Ping timeout: 240 seconds] 06:25 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 272 seconds] 06:25 <@jnewbery> We'll get started in just over 1.5 hours. If you haven't already done so, I recommend that you do a depends build before the meeting. Depends build can take a while, so you might want to kick it off sooner rather than later. 06:25 <@jnewbery> Instructions are here: https://github.com/bitcoin/bitcoin/blob/master/depends/README.md#usage 06:26 < michaelfolkson> Cool 06:27 <@jnewbery> wait, sorry I'm way off! 06:27 <@jnewbery> It's 3.5 hours, not 1.5 hours 06:27 <@jnewbery> but the advice to do a depends build still stands :) 06:29 <@jnewbery> oh, and make sure you run make with -j 06:29 < fanquake> πŸš€ 06:31 < fanquake> I'll be idling around here for the next 3.5 hours, so if you have issues with depends / related Qs etc. Feel free to ping me 06:33 <@jnewbery> fanquake: thanks! 06:40 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has joined #bitcoin-core-pr-reviews 06:50 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-pr-reviews 06:53 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection] 06:53 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 06:55 < michaelfolkson> So generally Core dependencies are compiled and packaged up by an external party right? Today we are "self compiling" 06:57 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 06:57 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-pr-reviews 07:05 < hebasto> re "oh, and make sure you run make with -j" also one could try to build depends with clang against `libc++` instead of `libstdc++` 07:10 < michaelfolkson> I'm assuming as we are self compiling we completely bypass the ccache? 07:11 < fanquake> michaelfolkson: no. ccache will still be used if it's available. 07:14 -!- S3RK [~s3rk@47.246.66.112] has quit [Remote host closed the connection] 07:14 -!- Nebraskka [~Nebraskka@51.83.249.56] has quit [Quit: Good day old chaps] 07:14 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-pr-reviews 07:15 -!- Nebraskka [~Nebraskka@51.83.249.56] has joined #bitcoin-core-pr-reviews 07:17 < michaelfolkson> But the contents of ccache won't generally need to change? Unless self compiling results in a different binary to doing a normal build? 07:21 < fanquake> "self compiling" is a confusing term to use here. You're always "self compiling" (as in building the binary yourself?) regardless of whether you're using dependencies which were installed via your machines package manager, or built using our depends system and given to ./configure via a --prefix. 07:21 -!- mol [~mol@unaffiliated/molly] has quit [Read error: Connection reset by peer] 07:22 < fanquake> Regardless, the bitcoind produced using your systems packages, vs using those built in depends is almost certainly always going to be different. 07:22 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 07:22 < fanquake> Different versions of the same library, different compile flags etc. 07:28 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 07:31 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 07:34 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 264 seconds] 08:17 -!- dr-orlovsky [~dr-orlovs@31.14.40.19] has quit [Ping timeout: 256 seconds] 08:26 -!- Murch [murch@2a01:4f8:141:1272::2] has joined #bitcoin-core-pr-reviews 08:27 -!- seven_ [~seven@2a00:ee2:410c:1300:7921:cf2d:bbe6:328a] has joined #bitcoin-core-pr-reviews 08:29 -!- matthewleon [~matthewle@2600:1f18:4580:e200:8ee5:8cac:cba6:a562] has joined #bitcoin-core-pr-reviews 08:29 -!- matthewleon [~matthewle@2600:1f18:4580:e200:8ee5:8cac:cba6:a562] has quit [Client Quit] 08:35 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 08:38 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 264 seconds] 08:46 <@jnewbery> Does anyone have a good way of downloading and extracting the depends sources, and leaving them in place? The default make target in depends deletes the extracted sources after building them. 08:47 <@jnewbery> I'd like to manually test that the patch and sed command are the same, and to do that I need the source files. I could manually extract each dependency, but some of them have specific extract commands 08:51 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 08:53 < fanquake> make download -C depends will grab all the sources. 08:54 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 08:54 < fanquake> You can probably do something like 'for a in *.*; do tar xf $a; done' in the sources dir to get them all extracted 09:00 <@jnewbery> it seems like at least qt and native_cctools have some different extract commands 09:00 <@jnewbery> (grepping for _extract_cmds in depends/packages) 09:02 < fanquake> tar xf should handle the qt .tar.xz fine 09:03 < fanquake> I've tested that just now and it extracts everything ok 09:11 <@jnewbery> cool. I hacked around with the funcs.mk to remove the subsequent commands, which also worked. Your way seems better! 09:13 < fanquake> Just trying to keep everything real low effort heh 09:17 < michaelfolkson> This blog post seems good for additional discussion on sed vs patch https://www.heystephenwood.com/2015/07/using-patch-instead-of-sed-in-shell.html 09:19 < michaelfolkson> Does patch offer anything over sed in addressing scripted diff problems? https://github.com/bitcoin/bitcoin/issues/19815 09:24 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-pr-reviews 09:26 < emzy> Ok build the depends and bitcoin-core with the libs. Worked. 09:48 -!- thomasb06 [~user@eth-west-pareq2-46-193-0-224.wb.wifirst.net] has joined #bitcoin-core-pr-reviews 09:57 -!- matthewleon [~matthewle@2600:1f18:4580:e200:8ee5:8cac:cba6:a562] has joined #bitcoin-core-pr-reviews 09:57 -!- punctured [~punctured@195.181.160.175.adsl.inet-telecom.org] has joined #bitcoin-core-pr-reviews 10:00 <@jnewbery> #startmeeting 10:00 < amiti> hi 10:00 -!- Paul_R [adf60e57@173-246-14-87.qc.cable.ebox.net] has joined #bitcoin-core-pr-reviews 10:00 < emzy> hi 10:00 <@jnewbery> hi all. Welcome to PR Review Club. Feel free to say hi to let everyone know you're here 10:00 < jonatack> ohai 10:00 < punctured> hi 10:00 <@jnewbery> Anyone here for the first time? 10:01 < Paul_R> hi 10:01 < michaelfolkson> hi 10:01 < Paul_R> 2nd time 10:01 <@jnewbery> welcome back Paul_R. Glad we didn't scare you off :) 10:01 < nehan> hi 10:01 < Paul_R> I was here on september 2, for bip 340...haha no i'm glad to be back :) 10:01 <@jnewbery> This week we're going to look at part of the repo that I know very little about - the build system! 10:02 <@jnewbery> (Sorry, I didn't prepare an ASCII art BUILD SYSTEM) 10:02 <@jnewbery> I'm really excited to get stuck in and learn more about our depends build, and fanquake has very kindly stayed up late in his timezone to teach us all. Thanks fanquake 10:02 <@jnewbery> I'll pass over to you now 10:02 < punctured> meaning a ascii art diagram of the build system? 10:03 < jonatack> [[[((((*=== build system ===*))))]]] 10:03 < punctured> of a build system for ascii art *scratches head* 10:03 < punctured> or a* 10:03 < michaelfolkson> Inside joke 10:03 < fanquake> jnewbery: cool 10:03 < punctured> got it 10:03 < michaelfolkson> Past PR review club session on Signet punctured 10:03 <@jnewbery> punctured: pinheadmz reasied the bar considerably with some art a couple of weeks ago 10:03 < fanquake> Prepare for me to drop is back down to whereever it was 10:04 < fanquake> The PR we're going to be looking at is #19761. 10:04 < jonatack> punctured: (see https://bitcoincore.reviews/18267) 10:04 < fanquake> https://github.com/bitcoin/bitcoin/pull/19761 10:04 < fanquake> I put these changes together about a month ago to hack some sed usage out of a our build system, and try and better document what the commands had been doing. 10:05 < fanquake> Has anyone had a look over/review the PR? 10:05 < michaelfolkson> y 10:05 < emzy> y 10:05 <@jnewbery> y 10:05 < jonatack> y, a little 10:05 < Paul_R> y, a little. i became aware of the sed tool today. 10:06 < matthewleon> y, a little 10:06 < nehan> y, some 10:06 < amiti> y, have taken a look, but its all very new to me ! 10:06 < fanquake> Ok. Let just jump into some Qs. 10:06 < pinheadmz> hi! sorry late, just lurking today 10:06 < fanquake> Why might we want to replace the usage of sed in our dependency builder with patches? 10:06 < pinheadmz> but got that ping :-) nice job jonatack 10:06 < Paul_R> to fail loudly? very small rocks? 10:06 < Paul_R> (monty python) 10:07 < crma> Improve documentation 10:07 < michaelfolkson> So Carl said sed calls fail silently 10:07 < emzy> To get errors if a patch is not working. With sed there is no error. 10:07 < fanquake> failing loudly is one reason, yes. sed has a tendency to fail silently, which isn't great. Where as patches that fail will kill that build. 10:07 < jonatack> maintainability, robustness, not fail silently, per PR description 10:08 < amiti> sed seems to have a lot of operating-system-specific behaviors and a tendency to fail silently, where as patch seems to be more explicit about expectations and errors 10:08 < punctured> sed's just a functional mapping which doesn't seem like a robust way to handle the desired functionality 10:08 < michaelfolkson> Generally sed leads to "enigmatic behavior" 10:08 < fanquake> Improving documentation is another. It's nice to be able to bundle documentation / info with the changes themselves, rather than comments in the depends makefiles. 10:09 < michaelfolkson> It was initially investigated how to use exit status with sed but presumably patches is a better approach 10:09 < fanquake> A lot of our remaining sed commands are still undocumented, and I'm hoping to improve that in #19867. 10:09 < michaelfolkson> https://askubuntu.com/questions/1036912/how-do-i-get-the-exit-status-when-using-the-sed-command/1036918#1036918 10:09 < fanquake> and as amiti mentioned. sed can behave different per-platform, which is annoying / can be confusing. 10:09 < fanquake> i.e: https://unix.stackexchange.com/questions/401905/bsd-sed-vs-gnu-sed-and-i 10:10 < amiti> can confirm. very confusing πŸ˜› 10:10 < michaelfolkson> https://github.com/bitcoin/bitcoin/issues/19815 10:10 < emzy> Additionaly there are different sed versions that behalf slightly different. 10:10 < fanquake> You're likely to run into this behavior on macOS, which uses BSD sed. I'd advise installing and using GNU sed. 10:10 < fanquake> Cool. So Q 2 10:11 < fanquake> What makes patches any better than sed? Are there any potential downsides? 10:11 < fanquake> There's a bit of cross-over in the answers here but 🀷 10:11 < michaelfolkson> I'm not sure if patches solve *everything* 10:11 < crma> You need to know what the output, must be 10:12 < michaelfolkson> But on some things they do. More context, rollback etc 10:12 < Paul_R> fanquake is changing the default on macos GNU sed a complicated process? 10:12 < nehan> patches require reviewing more of a raw change 10:12 < emzy> I think sed may work even if you chenge the upsteam version as the patch needs to be changed. 10:12 <@jnewbery> Something that might seem like a downside, but could also be considered a benefit is that the patch expects an exact input file 10:12 <@jnewbery> so if you update the version of the library, the patch will start failing, whereas the sed command might keep working 10:12 < fanquake> crma: correct, and we'll expand on that in the next Q. 10:13 < matthewleon> that sounds like more of a benefit 10:13 < matthewleon> keep "working" silently can have serious unintended consequences 10:13 <@jnewbery> matthweleon: +1 10:13 < fanquake> nehan: yes. Patches can be a bit less convenient to generate than a simple sed command. 10:13 < Paul_R> it does feel like more of a benefit. explicitness is good. 10:13 < jonatack> in some cases, looking at PR 19761, patch seem more explicit but also more verbose 10:14 < crma> Haven't tested, but guess sed is faster.. 10:14 < michaelfolkson> What did sed with a sed exit status solve? Just silently failing presumably 10:14 < fanquake> jonatack: It certainly is more verbose, however for our build system, I see that as a positive. I'm happy for us to be as explicit as possible in most cases. 10:14 < jonatack> the documentation looks like a real win 10:14 < jonatack> fanquake: agreed! 10:15 < fanquake> crma: that may be true, however as a proportion of total build time, any difference between patch and sed should be insignificant. 10:15 < fanquake> i.e compared to extracting sources and actually compiling. 10:15 < fanquake> Lets move on 10:15 < fanquake> After this PR, there are 9 usages of sed left. Why can’t we replace all of them? 10:16 < fanquake> This was also mentioned earlier. 10:16 < michaelfolkson> Using build time variables 10:17 < jonatack> OS compat? 10:17 * jonatack stabs in the dark 10:17 < Paul_R> haha 10:17 < emzy> you could use sed on the patch file und than use patch. Just joking. 10:17 < fanquake> Correct. Some of the sed commands are substituting values that we can't know ahead of time. 10:18 < fanquake> So we obviously can't generate a patch to replace them. 10:18 < nehan> how does one calculate the number of sed usages left? a simple grep gives me way more than 9 10:18 < fanquake> This values include things that might be set in depends, or come from the environment. 10:18 < michaelfolkson> Impossible > non-trivial :) At least with patches 10:18 < fanquake> i.e the compiler being used, or some C or CXXFLAGS. some examples: 10:18 < fanquake> https://github.com/bitcoin/bitcoin/blob/8235dca6210dab8e9657c0b592ab928554155082/depends/packages/miniupnpc.mk#L17 10:19 < fanquake> https://github.com/bitcoin/bitcoin/blob/7f609f68d835bece8b01da1b09b127c67769ae7d/depends/packages/qt.mk#L220 10:19 < punctured> Paul_R add gnu sed on mac with `brew install gnu-sed` 10:19 < fanquake> In these cases we're looking at any values like $() 10:19 < Paul_R> punctured thx 10:19 < matthewleon> fanquake: is there any possibility of generating the patch files from a template using environment variable substitution? 10:19 < punctured> Paul_R then it'll be available as gsed 10:20 < fanquake> nehan: grep sed depends/packages should do it 10:20 < fanquake> I see 7 in qt, 1 in miniupnpc and 1 in libxcb 10:20 < matthewleon> fanquake: for example, using GNU envsubst 10:21 < fanquake> So you are correct that there are more than 9 left. I missed libxcb before. 10:21 < jonatack> git grep sed ./depends/packages 10:21 < nehan> fanquake: i see 8 in qt :) 10:21 <@jnewbery> I see 12 total, including 8 in qt 10:21 < nehan> but i was looking at sed usage in everything. why is it important to get rid of sed in depends but not everywhere? 10:22 < fanquake> jnewbery: are you counting the 2 in boost that aren't actually seds? 10:22 <@jnewbery> yes :( 10:22 < jonatack> i c 10 lines, first saw 12 as well 10:22 < fanquake> matthewleon: possibly, however I haven't looked at that tool before. So probably can't give you a good answer right now. 10:22 < punctured> nehan proper question +1 10:22 < matthewleon> that might be worth looking at in a successor PR 10:23 < punctured> nehan I was wondering the same 10:23 < fanquake> nehan: I'd probably advocate for removing sed from most places, where possible (and we are suffering from all the issues mentioned), however I've started in the build system as that's what I know best. 10:24 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 10:24 < fanquake> There's also the potential for failing sed commands to cause determinism or security issues, which I'm very keen to avoid. 10:24 < fanquake> *in our dependencies. 10:25 < fanquake> The PTHREAD sed in cctools is a good example of a subtle determinism issue. 10:25 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-pr-reviews 10:25 < jonatack> there seems to be a fair number in /depends outside of /depends/packages 10:26 <@jnewbery> I had a question about native_cctools which might be a bit tangential at this point, but I'll ask anyway. Is that just used for building on macos? 10:26 <@jnewbery> or building for a macos target? 10:26 < fanquake> jonatack: can you link to some? afiak we don't use sed elsewhere in the dependency builder. 10:27 < jonatack> where are the cctools seds? 10:27 <@jnewbery> there was only one, which was removed by this PR 10:27 < fanquake> jnewbery: it's only used on linux to build for macos 10:27 < fanquake> https://github.com/bitcoin/bitcoin/pull/19761/commits/cc107a3af17d821f66de9357efe73214a628803b 10:28 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds] 10:28 < fanquake> Should we move on to Q4, or do we want to discuss this further? 10:28 < jonatack> fanquake: in depends/config.guess 10:28 < jonatack> idk if it's relevant 10:29 < jonatack> (or just some cruft i have) 10:29 < fanquake> jonatack: right, config.guess/sub aren't files we maintain, and they are only used to determine system information. 10:29 < jonatack> πŸ‘Œ 10:29 <@jnewbery> fanquake: keep on moving. People can always ask questions about previous questions 10:30 < fanquake> Q4. How would you test this PR? 10:31 < emzy> Maybe make a diff of the sed/patched files? Not sure. 10:31 < emzy> Compare the by sed changed files with the ones changed by patch. 10:32 < nehan> i'd love to learn more about this. i got worried when i saw jnewbery manually un-tar'ing things 10:32 < jonatack> This is an obstacle for me to reviewing these kinds of PRs... I don't know how to test. 10:32 <@jnewbery> I went about it in a rather convoluted way... 10:32 * fanquake needs to type faster 10:32 <@jnewbery> the Makefile in /depends does a lot of things: download, compare hashes, extract, build, ... 10:33 <@jnewbery> I wanted to extract and stop before it did any of the preprocessing and building (because that changes the source files, and then they get deleted afterwards) 10:33 < fanquake> So there are multiple things you could test / check here. emzy has outlined one, which is testing that when you run the sed comamnds over the source, you end up with the same patches I've got in the PR. 10:33 <@jnewbery> I hacked the funcs.mk file to remove all steps after extract, but fanquake pointed out that I could just extract manually 10:33 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 10:34 < fanquake> One way to do that (and it's the same way I generated them), is to just extra the source for a package, init a new git repo, commit the files, and then run the sed(s). Then check the diff. 10:34 <@jnewbery> then I went into work/build/x86_64-pc-linux-gnu , turned it into a git repo, made the sed changes and ran `git diff` 10:34 < jonatack> jnewbery: (re cctools, thanks!) 10:35 <@jnewbery> fanquake: snap! 10:35 < punctured> ginx 10:35 < fanquake> However, you also want to check that the patches are being applied correctly before building, and the end result is what we want . 10:35 < fanquake> So now we can actually do something practical. 10:36 < fanquake> Has everyone here actually build depends before? 10:36 < fanquake> If not it doesn't matter. 10:36 < Paul_R> i haven't 10:36 <@jnewbery> Before I did that, I just ran the sed commands and did a diff of the .old file and the new file, but that didn't work in some cases (eg here: https://github.com/bitcoin/bitcoin/pull/19761/files#diff-12c0a1e69780189a7700996b933eeb26L17-L18) Can you see why? 10:37 < emzy> First time I build the depends. Except maybe from the deterministic builds I do. 10:37 < fanquake> emzy: yep if you've gitian built before. building depends is part of that 10:37 < emzy> figured that. 10:38 < fanquake> One thing I forgot to mention re "testing" a PR like this, is sanity checking the documentation. 10:38 < fanquake> Especially given that one of the supposed benefits is better docs, I need to know that any docs I'm adding are actually useful / make sense / link to the right places etc. 10:39 -!- belcher_ is now known as belcher 10:39 < fanquake> Q5 How could we verify that the patches are being applied correctly? 10:40 < fanquake> If you've got the repo cloned, and want to run some commands, now would be the time to navigate to bitcoin/depends/ 10:40 < emzy> There will be a error if the patch can't be applied. 10:41 < fanquake> You might also want to kick off a build like 'make NO_WALLET=1 NO_QT=1 NO_ZMQ=1 -j6' 10:41 <@jnewbery> fanquake: i think it'd be really helpful if there were make targets (or a flag) that didn't clean up the work directory after it was done 10:41 <@jnewbery> that'd make it very easy to verify these things 10:42 < fanquake> jnewbery: so that you could inspect the patched source? 10:42 <@jnewbery> fanquake: exactly 10:42 <@jnewbery> and the pre-patched source 10:42 < fanquake> You can run make "lib_name"_configured and the build will stop after the configure step 10:42 < fanquake> which would include the patching 10:43 < fanquake> *preprocessed 10:43 < michaelfolkson> What do you mean by applied correctly? Applied at all? Equivalent to sed command? Applied consistently across different environments? 10:43 < fanquake> I'll write that out again. 10:43 < fanquake> You can run something like 'make zeromq_preprocessed' and that will only build up to the end of the preprocessing stage, which should include all patching. 10:44 < fanquake> At that point you could inspect the patched source. 10:44 < jonatack> One nuance for people: you need to run invocations like "make NO_WALLET=1 NO_QT=1 NO_ZMQ=1 -j6" from inside /depends and not root 10:44 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Read error: Connection reset by peer] 10:44 <@jnewbery> fanquake: cool! thanks 10:44 < fanquake> i.e https://gist.github.com/fanquake/c6e0c4129a1741702cb91a1e0b39b7f2 10:45 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #bitcoin-core-pr-reviews 10:45 < Paul_R> curious what the -j6 flag does? 10:45 < fanquake> jonatack: correct. If you're running from src/ you can pass -C depends OTHER=1 ARGS=1 ETC=1 10:46 < sipa> Paul_R: run up to 6 compilation steps in parallel 10:46 < fanquake> Paul_R: it's the number of make jobs to run in parallel. 10:46 < jonatack> Paul_R: if you have multiple CPU cores, which is the usual case nowadays, you can tell make to use all of them and reduce compile time by passing -j 10:46 <@jnewbery> toto answer my questions earlier about why comparing the original file and the .old file there didn't work: the second sed command overwrites the .old file from the first sed command, so the .old file isn't actually the file from before sed was run. 10:46 < Paul_R> a wild sipa appears 10:47 <@jnewbery> fanquake: I have some more general questions about the depends builds and this PR 10:47 < jonatack> on linux you could do something like make -j "$(($(nproc)+1))", on mac (untested): make -j "$(($(sysctl -n hw.physicalcpu)+1))" 10:47 < fanquake> jnewbery: sure. I did want to get to one example of inspecting changes in a lib we built, but fire away. 10:48 <@jnewbery> in the fontconfig change, the sed command was previously being run in the build step, but the patch is being run in the preprocess step: https://github.com/bitcoin/bitcoin/pull/19761/commits/865cb23a485d88be603c1d6bf8c32ef7a5edeaa2 10:48 <@jnewbery> The gperf_header_regen.patch didn't work for me because the makefile didn't exist. That might have just been a quirk of the way I extracted the source files though 10:49 <@jnewbery> is it definitely ok to run a patch on the Makefile in the preprocess step? 10:49 < fanquake> That's correct. I think there's a comment on the PR in regards to that. Basically it makes more sense to keep patching in preprocessing, so we moved it there. 10:50 < fanquake> We actually also modified the patch to edit Makefile.in, rather than Makefile 10:50 < fanquake> https://github.com/bitcoin/bitcoin/pull/19761#discussion_r475511755 10:50 <@jnewbery> Ah! 10:50 <@jnewbery> that makes so much more sense 10:51 <@jnewbery> because the Makefile doesn't exist in the preprocess step. Thanks! 10:51 < Paul_R> i'd like to learn more about the pre-process & build stages. are there any links that could introduce me to what happens in pre-process vs build steps and why? 10:51 < nehan> Paul_R: +1 10:52 < nehan> actually, could you just quickly overview the stages? 10:52 <@jnewbery> Paul_R: as it happens, https://github.com/bitcoin/bitcoin/blob/8235dca6210dab8e9657c0b592ab928554155082/depends/packages.md#build-commands 10:52 < fanquake> Thanks, that'll probably save me some furious typing. 10:53 < nehan> jnewbery: thanks! 10:53 <@jnewbery> fetch, extract, preprocess, configure, build, stage. Most should be self-evident 10:53 < Paul_R> thx 10:53 < fanquake> btw. Did anyone manage to complete a depends build? 10:53 <@jnewbery> I guess preprocess and stage are the only two that might not be immediately obvious? 10:54 < Paul_R> fetch - get the zip 10:54 <@jnewbery> preprocess is exactly what we've talked about today. Making small tweaks to the source files before building 10:54 < Paul_R> woops sent prematurely 10:54 < michaelfolkson> Not Core specific but may be of interest too Paul_R https://codingnest.com/the-little-things-speeding-up-c-compilation/ 10:54 < Paul_R> thanks michaelfolkson 10:55 < fanquake> jnewbery: correct 10:55 < Paul_R> jnewbery these tweaks are mostly for versionning? i'm still confused why the values are unknown at runtime, which is why we can't use patch on everything 10:55 < nehan> fanquake: i thought i did but it went relatively quickly so now i'm not sure. i followed the instructions of making in depends and then configuring with the prefix 10:57 < jonatack> fanquake: is https://github.com/fanquake/core-review/blob/master/diffoscope.md what you use for comparing/diffing builds? 10:57 <@jnewbery> nehan: how relatively is quickly? I think the thing that takes the most time in a depends build is qt 10:57 < fanquake> nehan: cool. We are running our of time, but want to try running 'strings depends/x86_64-pc-linux-gnu/lib/libminiupnpc.a | grep User-Agent' 10:58 < jonatack> User-Agent: x86_64-pc-linux-gnu, UPnP/1.1, MiniUPnPc/2.0.20180203 10:58 < nehan> User-Agent: x86_64-pc-linux-gnu, UPnP/1.1, MiniUPnPc/2.0.20180203 10:58 < jonatack> πŸ† 10:59 -!- matthewl_ [~matthewle@pool-173-68-83-200.nycmny.fios.verizon.net] has joined #bitcoin-core-pr-reviews 10:59 < fanquake> So the reason I bring that up is it's an example of where we are substituting in build time values using sed 10:59 < fanquake> https://github.com/bitcoin/bitcoin/blob/8235dca6210dab8e9657c0b592ab928554155082/depends/packages/miniupnpc.mk#L17 10:59 < fanquake> You can see that the miniupnpc version (2.0.20180203) and the host (x86_64-pc-linux-gnu) end up embeded in the user agent string in the miniupnpc lib 11:00 < fanquake> I was going to suggest editing miniupnpc.mk to remove line 17, and then rebuilding depends, and checking that same user agent string after rebuilding. 11:00 < fanquake> However I think we are out of time. 11:00 <@jnewbery> sounds like a good assignment :) 11:01 -!- matthewl_ [~matthewle@pool-173-68-83-200.nycmny.fios.verizon.net] has quit [Remote host closed the connection] 11:01 -!- matthewleon [~matthewle@2600:1f18:4580:e200:8ee5:8cac:cba6:a562] has quit [Read error: Connection reset by peer] 11:01 < fanquake> Apologies that we didn't get to much interactive stuff like thatt. 11:01 < fanquake> jnewbery: how do we wrap up? 11:01 <@jnewbery> #endmeeting 11:01 < jonatack> thanks fanquake! 11:01 <@jnewbery> ^ like dat 11:02 < nehan> User-Agent: Ubuntu/18.04, UPnP/1.1, MiniUPnPc/2.0 11:02 < emzy> Tnx fanquake for hosting and staying up all night. :) 11:02 < fanquake> Cool. Thanks everyone. 11:02 < nehan> thanks! 11:02 <@jnewbery> thanks fanquake. That was really interesting. It was fun to dig into something new 11:02 < Paul_R> thx fanquake 11:02 < crma> thank you for your time and your insights 11:02 < fanquake> nehan: great. 11:03 <@jnewbery> No need to apologize. People can make the changes you suggested and try rebuilding. I assume they can reach you here (probably tomorrow at this point)? 11:03 < fanquake> So now you've ended up with the values that miniupnpc tries to put into the useragent: https://github.com/miniupnp/miniupnp/blob/master/miniupnpc/miniupnpcstrings.h.in 11:04 <@jnewbery> oh, one last question. Do you have suggestions for other PRs to look at now that we're all experts in the depends builds? 11:04 < fanquake> jnewbery: yea I'm around if people want to ping me. 11:04 < jonatack> User-Agent: Debian/testing, UPnP/1.1, MiniUPnPc/2.0 11:04 -!- crma [bedb3996@190.219.57.150] has quit [Remote host closed the connection] 11:04 < fanquake> Sure. I'm looking for some review on: https://github.com/bitcoin/bitcoin/pull/19522 11:05 < fanquake> https://github.com/bitcoin/bitcoin/pull/19867 is also related to the changes we discussed today, and adds some more documentation. 11:07 < jonatack> πŸ‘ 11:08 -!- matthewleon [~matthewle@pool-173-68-83-200.nycmny.fios.verizon.net] has joined #bitcoin-core-pr-reviews 11:09 -!- matthewleon [~matthewle@pool-173-68-83-200.nycmny.fios.verizon.net] has quit [Client Quit] 11:11 -!- Paul_R [adf60e57@173-246-14-87.qc.cable.ebox.net] has quit [Remote host closed the connection] 11:17 < punctured> thanks fanquake 11:59 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Remote host closed the connection] 11:59 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-pr-reviews 12:10 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 12:44 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-pr-reviews 12:50 -!- dr-orlovsky [~dr-orlovs@31.14.40.19] has joined #bitcoin-core-pr-reviews 13:05 -!- vindard [~vindard@190.83.165.233] has quit [Remote host closed the connection] 13:06 -!- vindard [~vindard@190.83.165.233] has joined #bitcoin-core-pr-reviews 13:12 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 13:29 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Ping timeout: 260 seconds] 13:49 -!- corollari__ [sid405633@gateway/web/irccloud.com/x-jferurwjzkjcmwcg] has quit [Ping timeout: 246 seconds] 13:49 -!- ethzero_ [sid396973@gateway/web/irccloud.com/x-wvjenqobpqmqcrvw] has quit [Ping timeout: 244 seconds] 13:49 -!- GoldmanSats__ [sid428607@gateway/web/irccloud.com/x-wsyptzydclrzzolx] has quit [Ping timeout: 240 seconds] 13:49 -!- hugohn [sid304114@gateway/web/irccloud.com/x-lapnxcvmvfrikkev] has quit [Ping timeout: 240 seconds] 13:50 -!- hebasto [sid449604@gateway/web/irccloud.com/x-inkbofgpoucfhdwo] has quit [Ping timeout: 244 seconds] 13:50 -!- fjahr [sid374480@gateway/web/irccloud.com/x-iivtmbwrteacwior] has quit [Ping timeout: 260 seconds] 13:50 -!- ajonas [sid385278@gateway/web/irccloud.com/x-mlutywotlnjlafij] has quit [Ping timeout: 244 seconds] 13:51 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-wnueoswdnvefglqa] has quit [Ping timeout: 260 seconds] 13:51 -!- RubenSomsen [sid301948@gateway/web/irccloud.com/x-ocdalhxrivpycxzh] has quit [Ping timeout: 260 seconds] 13:51 -!- dergoegge [sid453889@gateway/web/irccloud.com/x-qcyhrfrvemkspetz] has quit [Ping timeout: 260 seconds] 13:51 -!- fanquake [sid369002@gateway/web/irccloud.com/x-zgkshntuzwgmxpna] has quit [Ping timeout: 260 seconds] 13:51 -!- schmidty [sid297174@gateway/web/irccloud.com/x-vndlzyxlrfxusond] has quit [Ping timeout: 260 seconds] 13:51 -!- ethzero_ [sid396973@gateway/web/irccloud.com/x-ictuekwclcloysjj] has joined #bitcoin-core-pr-reviews 13:51 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-xlvlfnqcloecnoox] has quit [Ping timeout: 244 seconds] 13:51 -!- corollari__ [sid405633@gateway/web/irccloud.com/x-dvrdckbjkiosvizr] has joined #bitcoin-core-pr-reviews 13:51 -!- hugohn [sid304114@gateway/web/irccloud.com/x-ppgcterfmqohuynp] has joined #bitcoin-core-pr-reviews 13:51 -!- GoldmanSats__ [sid428607@gateway/web/irccloud.com/x-xovyljecjiorysif] has joined #bitcoin-core-pr-reviews 13:51 -!- wallet42__ [sid154231@gateway/web/irccloud.com/x-kmodawzjplmhfcoq] has quit [Ping timeout: 260 seconds] 13:51 -!- hebasto [sid449604@gateway/web/irccloud.com/x-nmyxppcrtsegfhzd] has joined #bitcoin-core-pr-reviews 13:52 -!- jkczyz [sid419941@gateway/web/irccloud.com/x-rebgtlkvrvslbhur] has quit [Ping timeout: 260 seconds] 13:52 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-lcbrjrhmdourgpbv] has joined #bitcoin-core-pr-reviews 13:52 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-yjzhntzazsrvnsic] has joined #bitcoin-core-pr-reviews 13:52 -!- schmidty [sid297174@gateway/web/irccloud.com/x-wtlquklqywhsmnee] has joined #bitcoin-core-pr-reviews 13:52 -!- ajonas [sid385278@gateway/web/irccloud.com/x-blhtyvkkpughnfdg] has joined #bitcoin-core-pr-reviews 13:52 -!- RubenSomsen [sid301948@gateway/web/irccloud.com/x-lynikbyizhcluhrt] has joined #bitcoin-core-pr-reviews 13:52 -!- jkczyz [sid419941@gateway/web/irccloud.com/x-zenthftorqfsiqbx] has joined #bitcoin-core-pr-reviews 13:53 -!- wallet42__ [sid154231@gateway/web/irccloud.com/x-bhhwaubtuqwzpkpo] has joined #bitcoin-core-pr-reviews 13:53 -!- fjahr [sid374480@gateway/web/irccloud.com/x-jpyhlxsbrpmdqpct] has joined #bitcoin-core-pr-reviews 13:53 -!- fanquake [sid369002@gateway/web/irccloud.com/x-eksnczgmxnivlsca] has joined #bitcoin-core-pr-reviews 13:54 -!- dergoegge [sid453889@gateway/web/irccloud.com/x-tpmykjnomyazgkuv] has joined #bitcoin-core-pr-reviews 14:06 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection] 14:06 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-pr-reviews 14:07 -!- thomasb06 [~user@eth-west-pareq2-46-193-0-224.wb.wifirst.net] has quit [Remote host closed the connection] 14:13 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 14:16 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-pr-reviews 14:30 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has quit [Ping timeout: 264 seconds] 14:45 -!- ATHallin [~Winter@unaffiliated/athallin] has quit [Quit: q] 14:47 -!- ATHallin [~Winter@unaffiliated/athallin] has joined #bitcoin-core-pr-reviews 14:52 -!- ATHallin [~Winter@unaffiliated/athallin] has quit [Quit: q] 14:53 -!- ATHallin [~Winter@unaffiliated/athallin] has joined #bitcoin-core-pr-reviews 15:10 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 15:12 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 15:12 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 264 seconds] 15:12 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-pr-reviews 15:12 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 15:35 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-pr-reviews 15:41 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #bitcoin-core-pr-reviews 15:50 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-lcbrjrhmdourgpbv] has quit [Ping timeout: 240 seconds] 15:50 -!- drbrule [sid395654@gateway/web/irccloud.com/x-iplpgvawjbrmytpt] has quit [Ping timeout: 244 seconds] 15:50 -!- felixweis [sid154231@gateway/web/irccloud.com/x-ssguchidvcelwjsp] has quit [Ping timeout: 244 seconds] 15:50 -!- dburkett [sid411344@gateway/web/irccloud.com/x-cdapfbharqmwkpvr] has quit [Ping timeout: 244 seconds] 15:50 -!- RubenSomsen [sid301948@gateway/web/irccloud.com/x-lynikbyizhcluhrt] has quit [Ping timeout: 260 seconds] 15:50 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-yjzhntzazsrvnsic] has quit [Ping timeout: 260 seconds] 15:50 -!- ethzero_ [sid396973@gateway/web/irccloud.com/x-ictuekwclcloysjj] has quit [Ping timeout: 240 seconds] 15:50 -!- pierre_rochard [sid299882@gateway/web/irccloud.com/x-blfjoxusrhpawecr] has quit [Ping timeout: 246 seconds] 15:50 -!- GoldmanSats__ [sid428607@gateway/web/irccloud.com/x-xovyljecjiorysif] has quit [Read error: Connection reset by peer] 15:50 -!- ajonas [sid385278@gateway/web/irccloud.com/x-blhtyvkkpughnfdg] has quit [Read error: Connection reset by peer] 15:50 -!- dergoegge [sid453889@gateway/web/irccloud.com/x-tpmykjnomyazgkuv] has quit [Read error: Connection reset by peer] 15:50 -!- hebasto [sid449604@gateway/web/irccloud.com/x-nmyxppcrtsegfhzd] has quit [Read error: Connection reset by peer] 15:50 -!- jakesyl [sid56879@gateway/web/irccloud.com/x-oefffcmvqxljcnys] has quit [Ping timeout: 240 seconds] 15:50 -!- robot-dreams [sid463268@gateway/web/irccloud.com/x-rpqnqyqggmvfkivo] has quit [Ping timeout: 240 seconds] 15:50 -!- schmidty [sid297174@gateway/web/irccloud.com/x-wtlquklqywhsmnee] has quit [Ping timeout: 260 seconds] 15:52 -!- jkczyz [sid419941@gateway/web/irccloud.com/x-zenthftorqfsiqbx] has quit [Ping timeout: 260 seconds] 15:52 -!- GoldmanSats__ [sid428607@gateway/web/irccloud.com/x-kpdvjymxhonijrzi] has joined #bitcoin-core-pr-reviews 15:52 -!- hebasto [sid449604@gateway/web/irccloud.com/x-quytyjemkudizcwx] has joined #bitcoin-core-pr-reviews 15:52 -!- wallet42__ [sid154231@gateway/web/irccloud.com/x-bhhwaubtuqwzpkpo] has quit [Ping timeout: 272 seconds] 15:52 -!- schmidty [sid297174@gateway/web/irccloud.com/x-bmbajaexrxbnkati] has joined #bitcoin-core-pr-reviews 15:52 -!- robot-dreams [sid463268@gateway/web/irccloud.com/x-bfidmlipaqyrhoha] has joined #bitcoin-core-pr-reviews 15:53 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-pr-reviews 15:53 -!- ethzero_ [sid396973@gateway/web/irccloud.com/x-ihurhebhbbpzhejc] has joined #bitcoin-core-pr-reviews 15:53 -!- dergoegge [sid453889@gateway/web/irccloud.com/x-sswuueloqcmejcew] has joined #bitcoin-core-pr-reviews 15:53 -!- pierre_rochard [sid299882@gateway/web/irccloud.com/x-ofdvvlddimyjsrwj] has joined #bitcoin-core-pr-reviews 15:54 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-pxrxxwvvwcicqstf] has joined #bitcoin-core-pr-reviews 15:54 -!- felixweis [sid154231@gateway/web/irccloud.com/x-epboyqvosgbrdlkk] has joined #bitcoin-core-pr-reviews 15:54 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-orjtvsxyrbvwkkno] has joined #bitcoin-core-pr-reviews 15:54 -!- jakesyl [sid56879@gateway/web/irccloud.com/x-wosvtnolrypjpate] has joined #bitcoin-core-pr-reviews 15:55 -!- ajonas [sid385278@gateway/web/irccloud.com/x-rvvemjovccufccmc] has joined #bitcoin-core-pr-reviews 15:55 -!- jkczyz [sid419941@gateway/web/irccloud.com/x-chhwdxnrzsjrcqfx] has joined #bitcoin-core-pr-reviews 15:55 -!- fjahr [sid374480@gateway/web/irccloud.com/x-jpyhlxsbrpmdqpct] has quit [Ping timeout: 258 seconds] 15:55 -!- drbrule [sid395654@gateway/web/irccloud.com/x-ogdudpwfmbcjqaew] has joined #bitcoin-core-pr-reviews 15:56 -!- dburkett [sid411344@gateway/web/irccloud.com/x-xcwpgfnojiydssfg] has joined #bitcoin-core-pr-reviews 15:56 -!- wallet42__ [sid154231@gateway/web/irccloud.com/x-dgvryhwztdjphrwc] has joined #bitcoin-core-pr-reviews 15:56 -!- ATHallin [~Winter@unaffiliated/athallin] has left #bitcoin-core-pr-reviews ["Bye"] 15:56 -!- fjahr [sid374480@gateway/web/irccloud.com/x-xxhgfjymcdjzupvi] has joined #bitcoin-core-pr-reviews 15:58 -!- ethzero_ [sid396973@gateway/web/irccloud.com/x-ihurhebhbbpzhejc] has quit [Ping timeout: 258 seconds] 15:58 -!- pierre_rochard [sid299882@gateway/web/irccloud.com/x-ofdvvlddimyjsrwj] has quit [Ping timeout: 256 seconds] 16:01 -!- ethzero_ [sid396973@gateway/web/irccloud.com/x-dueukzxiozujrcsa] has joined #bitcoin-core-pr-reviews 16:07 -!- pinheadm_ [~pinheadmz@104.140.52.123] has joined #bitcoin-core-pr-reviews 16:10 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Ping timeout: 256 seconds] 16:11 -!- tralfaz [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-pr-reviews 16:11 -!- RubenSomsen [sid301948@gateway/web/irccloud.com/x-lrokbsurnqtoyeht] has joined #bitcoin-core-pr-reviews 16:11 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Disconnected by services] 16:11 -!- tralfaz is now known as davterra 16:12 -!- pierre_rochard [sid299882@gateway/web/irccloud.com/x-ddjuquxerbxnlpyu] has joined #bitcoin-core-pr-reviews 16:13 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 16:49 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-pr-reviews 16:55 -!- meshcollider [meshcollid@gateway/shell/ircnow/x-bxvhpqzkrscwvoog] has quit [Ping timeout: 260 seconds] 17:02 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 17:03 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-pr-reviews 17:12 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection] 17:12 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-pr-reviews 17:13 -!- pinheadm_ [~pinheadmz@104.140.52.123] has quit [Ping timeout: 272 seconds] 17:15 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-pr-reviews 17:29 -!- seven_ [~seven@2a00:ee2:410c:1300:7921:cf2d:bbe6:328a] has quit [Read error: Connection reset by peer] 17:35 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 17:35 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-pr-reviews 17:43 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 17:47 -!- S3RK [~s3rk@47.246.66.112] has quit [Remote host closed the connection] 17:48 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-pr-reviews 17:54 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [Ping timeout: 260 seconds] 17:54 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-pr-reviews 19:29 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 19:30 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-pr-reviews 19:32 -!- meshcollider [meshcollid@gateway/shell/ircnow/x-btdjauxcaymhdeld] has joined #bitcoin-core-pr-reviews 21:43 -!- tralfaz [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-pr-reviews 21:47 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection] 22:13 -!- S3RK [~s3rk@47.246.66.112] has quit [Remote host closed the connection] 22:14 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-pr-reviews 22:17 -!- punctured [~punctured@195.181.160.175.adsl.inet-telecom.org] has quit [Ping timeout: 264 seconds] 22:32 -!- tralfaz is now known as davterra 23:11 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 260 seconds] 23:12 -!- jonatack [~jon@82.102.27.171] has joined #bitcoin-core-pr-reviews 23:28 -!- gloriazhao [uid453516@gateway/web/irccloud.com/x-ffjydwauyyunhkvq] has quit [Quit: Connection closed for inactivity]