--- Day changed Thu Oct 01 2020 00:15 -!- S3RK [~s3rk@47.246.66.116] has joined #bitcoin-core-pr-reviews 00:24 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 00:25 -!- cloudhead [~cloudhead@li1811-8.members.linode.com] has quit [Quit: WeeChat 2.8] 00:46 -!- jonatack [~jon@37.164.132.126] has joined #bitcoin-core-pr-reviews 01:07 -!- Aleru [sid403553@gateway/web/irccloud.com/x-yujxdzfveoxjwazt] has joined #bitcoin-core-pr-reviews 01:07 -!- felixweis [sid154231@gateway/web/irccloud.com/x-krefugjevbfmhthz] has joined #bitcoin-core-pr-reviews 01:07 -!- fjahr [sid374480@gateway/web/irccloud.com/x-rbbwbtbigjvdlmkh] has joined #bitcoin-core-pr-reviews 01:07 -!- sharknado9000[m] [sharknado9@gateway/shell/matrix.org/x-liykrfvtvyxpweih] has joined #bitcoin-core-pr-reviews 01:07 -!- djinni` [~djinni@static.38.6.217.95.clients.your-server.de] has joined #bitcoin-core-pr-reviews 01:32 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Read error: Connection reset by peer] 01:34 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #bitcoin-core-pr-reviews 01:51 -!- S3RK [~s3rk@47.246.66.116] has quit [Remote host closed the connection] 01:52 -!- Netsplit *.net <-> *.split quits: Aleru, fjahr, felixweis, sharknado9000[m], djinni` 02:10 -!- Netsplit over, joins: Aleru, felixweis, fjahr, djinni`, sharknado9000[m] 02:12 < wumpus> emzy: I had to wait for the chain to sync a bit as it's a recent block, but I was able to reproduce it 02:30 -!- S3RK [~s3rk@47.246.66.116] has joined #bitcoin-core-pr-reviews 02:42 -!- S3RK [~s3rk@47.246.66.116] has quit [Ping timeout: 260 seconds] 02:47 -!- musdom [~Thunderbi@202.185.34.14] has joined #bitcoin-core-pr-reviews 02:55 -!- S3RK [~s3rk@47.246.66.116] has joined #bitcoin-core-pr-reviews 03:04 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds] 03:06 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-pr-reviews 03:10 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 03:15 -!- jonatack [~jon@37.164.132.126] has quit [Ping timeout: 260 seconds] 03:17 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 03:20 -!- Hubert80Frami [~Hubert80F@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-pr-reviews 03:22 -!- wullon587 [~wullon@241.243.86.88.rdns.comcable.net] has quit [Ping timeout: 265 seconds] 03:25 -!- musdom [~Thunderbi@202.185.34.14] has quit [Ping timeout: 240 seconds] 03:25 -!- Hubert80Frami [~Hubert80F@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 265 seconds] 03:33 -!- jaybny [~jaybny@c-73-162-160-252.hsd1.ca.comcast.net] has quit [Quit: jaybny] 03:51 -!- S3RK [~s3rk@47.246.66.116] has quit [Remote host closed the connection] 03:51 -!- S3RK [~s3rk@47.246.66.116] has joined #bitcoin-core-pr-reviews 03:53 -!- S3RK [~s3rk@47.246.66.116] has quit [Remote host closed the connection] 03:53 -!- S3RK [~s3rk@47.246.66.116] has joined #bitcoin-core-pr-reviews 04:20 -!- S3RK [~s3rk@47.246.66.116] has quit [Remote host closed the connection] 04:20 -!- S3RK [~s3rk@47.246.66.116] has joined #bitcoin-core-pr-reviews 04:24 -!- S3RK [~s3rk@47.246.66.116] has quit [Ping timeout: 246 seconds] 04:38 -!- vindard [~vindard@190.83.165.233] has joined #bitcoin-core-pr-reviews 04:48 -!- gleb [~gleb@178.150.137.228] has quit [Ping timeout: 258 seconds] 04:50 -!- gleb [~gleb@178.150.137.228] has joined #bitcoin-core-pr-reviews 05:00 -!- S3RK [~s3rk@47.246.66.116] has joined #bitcoin-core-pr-reviews 05:04 -!- S3RK [~s3rk@47.246.66.116] has quit [Ping timeout: 256 seconds] 05:21 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-pr-reviews 05:37 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 05:39 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 07:07 -!- S3RK [~s3rk@47.246.66.116] has joined #bitcoin-core-pr-reviews 07:12 -!- S3RK [~s3rk@47.246.66.116] has quit [Ping timeout: 272 seconds] 08:46 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-pr-reviews 09:06 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Quit: jonatack] 09:15 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-pr-reviews 10:20 -!- seven_ [~seven@cpe-90-157-197-248.static.amis.net] has quit [Ping timeout: 256 seconds] 10:22 -!- S3RK [~s3rk@47.246.66.116] has joined #bitcoin-core-pr-reviews 10:27 -!- S3RK [~s3rk@47.246.66.116] has quit [Ping timeout: 256 seconds] 11:01 -!- Netsplit *.net <-> *.split quits: Aleru, fjahr, felixweis, sharknado9000[m], djinni` 11:47 -!- Aleru [sid403553@gateway/web/irccloud.com/x-yujxdzfveoxjwazt] has joined #bitcoin-core-pr-reviews 11:47 -!- felixweis [sid154231@gateway/web/irccloud.com/x-krefugjevbfmhthz] has joined #bitcoin-core-pr-reviews 11:47 -!- fjahr [sid374480@gateway/web/irccloud.com/x-rbbwbtbigjvdlmkh] has joined #bitcoin-core-pr-reviews 11:47 -!- sharknado9000[m] [sharknado9@gateway/shell/matrix.org/x-liykrfvtvyxpweih] has joined #bitcoin-core-pr-reviews 11:47 -!- djinni` [~djinni@static.38.6.217.95.clients.your-server.de] has joined #bitcoin-core-pr-reviews 12:08 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 12:37 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Ping timeout: 240 seconds] 12:39 < robot-dreams> emzy: Thanks again for finding that issue. I managed to reproduce in a functional test, and I'm looking into it now. 12:39 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-pr-reviews 12:45 < robot-dreams> I think the issue is that we only added the value to `amt_total_in` if `!tx.vin[i].scriptWitness.IsNull()` 13:35 -!- seven_ [~seven@cpe-90-157-197-248.static.amis.net] has joined #bitcoin-core-pr-reviews 14:38 < robot-dreams> emzy: do you still get the failure with the updated PR branch? 14:49 < wumpus> robot-dreams: FWIW no longer getting the error for block 0000000000000000000266073e5fef7d4071192fd69d340cd4f23073b0f86f61 here 14:51 < robot-dreams> Woo, thanks for trying it! 15:11 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 15:12 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 15:15 -!- S3RK [~s3rk@47.246.66.116] has joined #bitcoin-core-pr-reviews 15:19 -!- S3RK [~s3rk@47.246.66.116] has quit [Ping timeout: 240 seconds] 16:55 -!- Netsplit *.net <-> *.split quits: Aleru, fjahr, felixweis, sharknado9000[m], djinni` 16:55 -!- seven_ [~seven@cpe-90-157-197-248.static.amis.net] has quit [Remote host closed the connection] 16:55 -!- seven_ [~seven@cpe-90-157-197-248.static.amis.net] has joined #bitcoin-core-pr-reviews 17:05 -!- Netsplit over, joins: Aleru, felixweis, fjahr, djinni`, sharknado9000[m] 17:40 -!- S3RK [~s3rk@47.246.66.116] has joined #bitcoin-core-pr-reviews 17:44 -!- S3RK [~s3rk@47.246.66.116] has quit [Ping timeout: 240 seconds] 17:56 -!- S3RK [~s3rk@47.246.66.116] has joined #bitcoin-core-pr-reviews 18:08 -!- seven_ [~seven@cpe-90-157-197-248.static.amis.net] has quit [Read error: Connection reset by peer] 18:51 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 18:52 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 19:23 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 19:24 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-pr-reviews 19:33 -!- shesek [~shesek@164.90.217.137] has joined #bitcoin-core-pr-reviews 19:33 -!- shesek [~shesek@164.90.217.137] has quit [Changing host] 19:33 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-pr-reviews 20:21 -!- Netsplit *.net <-> *.split quits: Aleru, fjahr, felixweis, sharknado9000[m], djinni` 20:49 -!- Aleru [sid403553@gateway/web/irccloud.com/x-yujxdzfveoxjwazt] has joined #bitcoin-core-pr-reviews 20:49 -!- felixweis [sid154231@gateway/web/irccloud.com/x-krefugjevbfmhthz] has joined #bitcoin-core-pr-reviews 20:49 -!- fjahr [sid374480@gateway/web/irccloud.com/x-rbbwbtbigjvdlmkh] has joined #bitcoin-core-pr-reviews 20:49 -!- sharknado9000[m] [sharknado9@gateway/shell/matrix.org/x-liykrfvtvyxpweih] has joined #bitcoin-core-pr-reviews 20:49 -!- djinni` [~djinni@static.38.6.217.95.clients.your-server.de] has joined #bitcoin-core-pr-reviews 21:19 -!- S3RK [~s3rk@47.246.66.116] has quit [Remote host closed the connection] 21:20 -!- S3RK [~s3rk@47.246.66.116] has joined #bitcoin-core-pr-reviews 21:23 -!- hugohn [sid304114@gateway/web/irccloud.com/x-wnvicsfksfayqswb] has quit [Ping timeout: 256 seconds] 21:24 -!- hugohn [sid304114@gateway/web/irccloud.com/x-wigsyrnczlzuvegj] has joined #bitcoin-core-pr-reviews 21:24 -!- S3RK [~s3rk@47.246.66.116] has quit [Ping timeout: 260 seconds] 21:29 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 21:29 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-pr-reviews 21:42 -!- S3RK [~s3rk@47.246.66.116] has joined #bitcoin-core-pr-reviews 22:00 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds] 22:01 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-pr-reviews 22:54 -!- S3RK [~s3rk@47.246.66.116] has quit [Remote host closed the connection] 23:49 -!- S3RK [~s3rk@47.246.66.116] has joined #bitcoin-core-pr-reviews 23:54 -!- S3RK [~s3rk@47.246.66.116] has quit [Ping timeout: 265 seconds] 23:58 -!- S3RK [~s3rk@47.246.66.116] has joined #bitcoin-core-pr-reviews