--- Day changed Fri Oct 09 2020 00:17 -!- musdom [~Thunderbi@202.185.34.14] has joined #bitcoin-core-pr-reviews 00:35 -!- jonatack [~jon@213.152.162.99] has joined #bitcoin-core-pr-reviews 00:54 -!- S3RK [~s3rk@47.246.66.115] has quit [Remote host closed the connection] 01:04 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-pr-reviews 01:32 -!- worc3131 [~quassel@2a02:c7f:c026:9500:7d0b:65d0:38a4:4786] has joined #bitcoin-core-pr-reviews 01:43 -!- worc3131 [~quassel@2a02:c7f:c026:9500:7d0b:65d0:38a4:4786] has quit [Remote host closed the connection] 01:50 < ares_> is it okay to ask questions about the last PR after the meeting? I mostly lurked through the event because it was my first one 01:53 < ares_> I was wondering whether the timestamp in an addr message is part of the net_addr or not because the wiki is a bit contradictory there 02:36 -!- musdom [~Thunderbi@202.185.34.14] has quit [Read error: Connection reset by peer] 02:37 -!- musdom [~Thunderbi@202.185.172.32] has joined #bitcoin-core-pr-reviews 02:47 -!- musdom1 [~Thunderbi@202.185.172.32] has joined #bitcoin-core-pr-reviews 02:48 -!- musdom [~Thunderbi@202.185.172.32] has quit [Ping timeout: 260 seconds] 02:50 -!- musdom [~Thunderbi@202.184.174.75] has joined #bitcoin-core-pr-reviews 02:51 -!- musdom1 [~Thunderbi@202.185.172.32] has quit [Ping timeout: 240 seconds] 03:05 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-pr-reviews 03:08 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds] 03:09 < Murch> ares_: Questions are certainly welcome. I am not sure about the timestamp, but the wiki is extremely outdated or inaccurate in a lot of articles. 03:10 < Murch> Can you link to what you are looking at? 03:10 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 03:12 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 03:13 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 03:20 -!- Allan24Jacobs [~Allan24Ja@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-pr-reviews 03:25 -!- Allan24Jacobs [~Allan24Ja@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 256 seconds] 03:26 <@jnewbery> ares_: addresses inside an `addr` message have a timestamp. Addresses inside the `version` message don't. It's a little confusing. 03:26 <@jnewbery> There's a code comment about how we serialize CAddress objects here: https://github.com/bitcoin/bitcoin/blob/380705ef4f007463dc7951376c7bedef1f01a169/src/protocol.h#L365-L370 04:02 -!- sharknado9000[m] [sharknado9@gateway/shell/matrix.org/x-llwrxglwyjvtzzrk] has quit [Quit: killed] 04:09 -!- sharknado9000[m] [sharknado9@gateway/shell/matrix.org/x-zswuisswxitzfcko] has joined #bitcoin-core-pr-reviews 04:09 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-pr-reviews 04:30 -!- jonatack [~jon@213.152.162.99] has quit [Ping timeout: 258 seconds] 04:34 -!- Netsplit *.net <-> *.split quits: jeremyrubin, dergoegge 04:40 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 04:40 -!- dergoegge [sid453889@gateway/web/irccloud.com/x-jzdktyxxskljzfdk] has joined #bitcoin-core-pr-reviews 04:40 -!- S3RK [~s3rk@47.246.66.115] has quit [Remote host closed the connection] 04:41 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-pr-reviews 04:46 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 240 seconds] 05:02 < ares_> Murch: I was using the link provided in jon's notes (https://en.bitcoin.it/wiki/Protocol_documentation#addr). the addr description says addresses are prefixed with a timestamp, but the net_addr entry specified the timestamp was part of the address 05:02 < ares_> jnewbery: thanks for clearing that up 05:21 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-pr-reviews 05:26 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-pr-reviews 05:33 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-pr-reviews 05:45 -!- gloriazhao [uid453516@gateway/web/irccloud.com/x-tiwtubynovndgvvr] has quit [Quit: Connection closed for inactivity] 05:49 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-pr-reviews 05:53 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 240 seconds] 06:07 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 06:18 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 06:30 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-pr-reviews 06:35 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 272 seconds] 07:01 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 07:01 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 07:05 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 07:06 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 07:07 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 07:09 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 246 seconds] 07:11 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 272 seconds] 07:37 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 260 seconds] 07:39 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 08:06 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Quit: jonatack] 08:07 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-pr-reviews 08:10 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 08:11 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-pr-reviews 08:12 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 08:19 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 08:25 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 08:26 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 08:43 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 08:44 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-pr-reviews 09:03 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Read error: Connection reset by peer] 09:03 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 09:06 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 09:06 < Murch> Is there a git commit standard for Bitcoin Core contributions? 09:09 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 09:09 < sipa> Murch: hmm? 09:10 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 272 seconds] 09:14 < Murch> I was surprised that a few of the commits I looked at had minimal information in the commit message 09:19 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Read error: Connection reset by peer] 09:20 < wumpus> it's fairly common to have general information in the PR message (which gets included in the merge commit) instead and have only minimal individual commit messages 09:21 < sipa> the PR description gets included in the merge commit fwiw 09:24 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-pr-reviews 09:25 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 09:28 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 246 seconds] 09:36 -!- shesek [~shesek@164.90.217.137] has joined #bitcoin-core-pr-reviews 09:36 -!- shesek [~shesek@164.90.217.137] has quit [Changing host] 09:36 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-pr-reviews 10:29 <@jnewbery> Murch: I always point new contributors to this because I think they're generally good practice: https://chris.beams.io/posts/git-commit/ 10:30 <@jnewbery> they even cite some guy called Pieter Wuille, so you know they're 😗👌 https://chris.beams.io/posts/git-commit/#why-not-how 10:37 < sipa> lol 10:44 -!- musdom [~Thunderbi@202.184.174.75] has quit [Ping timeout: 272 seconds] 11:04 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 240 seconds] 11:05 -!- jonatack [~jon@213.152.162.15] has joined #bitcoin-core-pr-reviews 11:12 < michaelfolkson> A 2014 commit too. This Chris Beams guy was citing him before it was cool 11:14 < sipa> jnewbery: it's funny because a while ago Murch messaged me that he had been using that blog post to explain good commit messages for a while, but never realized it was using one of mine as an example 11:20 < michaelfolkson> Chris is a Bisq co-founder apparently. That'll explain him being on sipa trail before the cool kids 11:33 < Murch> jnewbery: Yeah, that's what we based our commit standard on as well at my last place of employ. 11:36 < Murch> sipa, wumpus: I see, I didn't know that the PR description would make it into the commit as well. 11:36 < sipa> Murch: i believe it's generally easier to enforce coding styles in private repositories where everyone is paid by the same entity :) 11:41 < Murch> Indubitably. 11:42 < sipa> there is https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md, but in practice it's hard to consistently follow that 11:42 < wumpus> I generally try to avoid telling people to change their commit messages (unless it's really bad) because it requires a rebase to change them so will invalidate all reviews 11:43 < sipa> https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#committing-patches has some suggestions 11:43 < sipa> which links to the chris beams post 11:45 < Murch> great 11:47 -!- ares_ [~ares@gateway/tor-sasl/virtu] has quit [Remote host closed the connection] 12:07 -!- ares_ [~ares@gateway/tor-sasl/virtu] has joined #bitcoin-core-pr-reviews 13:25 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-pr-reviews 13:25 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-pr-reviews 13:30 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 240 seconds] 14:24 < robot-dreams> On commits and commit messages, I like the guidelines at https://zulip.readthedocs.io/en/latest/contributing/version-control.html 14:54 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-pr-reviews 15:10 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 15:12 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 15:20 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer] 15:20 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-pr-reviews 15:56 < michaelfolkson> Nice addition, looks good 15:59 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-pr-reviews 16:04 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 258 seconds] 16:05 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 16:09 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 16:23 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 16:34 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 246 seconds] 16:47 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 16:47 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Quit: pinheadmz] 16:52 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-pr-reviews 16:58 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Quit: pinheadmz] 17:36 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection] 17:36 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-pr-reviews 17:36 -!- meshcollider [meshcollid@gateway/shell/ircnow/x-btdjauxcaymhdeld] has quit [Ping timeout: 260 seconds] 17:36 -!- meshcollider [meshcollid@gateway/shell/ircnow/x-ymbjzimilbdxsocu] has joined #bitcoin-core-pr-reviews 18:21 -!- wiz [~j@wiz.biz] has quit [Quit: That's it for today] 18:27 -!- gloriazhao [uid453516@gateway/web/irccloud.com/x-buutjriyeafbzadq] has joined #bitcoin-core-pr-reviews 18:28 -!- gloriazhao is now known as glozow 18:30 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-pr-reviews 18:32 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Client Quit] 18:37 -!- tralfaz [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-pr-reviews 18:37 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Disconnected by services] 18:37 -!- tralfaz is now known as davterra 19:03 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 19:04 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-pr-reviews 20:01 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-pr-reviews 20:05 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 258 seconds] 20:09 -!- musdom [~Thunderbi@202.184.174.75] has joined #bitcoin-core-pr-reviews 20:40 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Read error: Connection reset by peer] 20:42 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-pr-reviews 21:07 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 21:49 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-pr-reviews 21:54 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 265 seconds] 22:14 -!- neo_1 [~neo@2a01:e35:2efd:9150:3d84:11f2:ecb6:fe24] has joined #bitcoin-core-pr-reviews 22:19 -!- neo_1 [~neo@2a01:e35:2efd:9150:3d84:11f2:ecb6:fe24] has quit [Ping timeout: 272 seconds] 22:19 -!- neo_1 [~neo@lun34-1-82-239-217-21.fbx.proxad.net] has joined #bitcoin-core-pr-reviews 23:17 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-pr-reviews 23:29 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 240 seconds] 23:48 -!- b10c_ [~b10c@2a01:4f8:192:612a:216:3eff:fef3:dc6a] has quit [Quit: leaving] 23:48 -!- b10c [~b10c@2a01:4f8:192:612a:216:3eff:fef3:dc6a] has joined #bitcoin-core-pr-reviews 23:49 -!- b10c [~b10c@2a01:4f8:192:612a:216:3eff:fef3:dc6a] has quit [Client Quit]