--- Day changed Thu Oct 29 2020
00:25 -!- ares_ [~ares@gateway/tor-sasl/virtu] has quit [Quit: leaving]     
00:28 -!- virtu [~virtu@gateway/tor-sasl/virtu] has joined #bitcoin-core-pr-reviews     
00:33 -!- jesseposner [~jesse@98.37.146.62] has quit [Ping timeout: 272 seconds]     
00:44 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Ping timeout: 240 seconds]     
00:52 -!- seven_ [~seven@cpe-90-157-197-248.static.amis.net] has joined #bitcoin-core-pr-reviews     
01:03 -!- jesseposner [~jesse@98.37.146.62] has joined #bitcoin-core-pr-reviews     
01:10 -!- jesseposner [~jesse@98.37.146.62] has quit [Ping timeout: 256 seconds]     
01:16 < jnewbery_> #proposedmeetingtopic Disable S390X travis build
01:27 -!- daniel__ [~daniel@88-117-109-129.adsl.highway.telekom.at] has joined #bitcoin-core-pr-reviews     
01:30 -!- S3RK [~S3RK@116.118.83.69] has quit [Quit: Lost terminal]     
01:32 < jnewbery_> oops wrong channel
01:40 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-pr-reviews     
01:45 -!- jesseposner [~jesse@98.37.146.62] has joined #bitcoin-core-pr-reviews     
01:50 -!- jesseposner [~jesse@98.37.146.62] has quit [Ping timeout: 258 seconds]     
01:54 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Ping timeout: 240 seconds]     
01:59 -!- S3RK [~S3RK@116.118.83.69] has joined #bitcoin-core-pr-reviews     
02:05 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has quit [Ping timeout: 265 seconds]     
02:25 -!- jesseposner [~jesse@98.37.146.62] has joined #bitcoin-core-pr-reviews     
02:30 -!- jesseposner [~jesse@98.37.146.62] has quit [Ping timeout: 240 seconds]     
02:53 -!- S3RK [~S3RK@116.118.83.69] has quit [Ping timeout: 260 seconds]     
02:59 -!- jnewbery_ is now known as jnewbery     
03:08 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews     
03:11 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]     
03:11 -!- vasild_ is now known as vasild     
03:13 -!- S3RK [~S3RK@116.118.83.69] has joined #bitcoin-core-pr-reviews     
03:23 -!- daniel [~daniel@91.114.24.1] has joined #bitcoin-core-pr-reviews     
03:23 -!- daniel is now known as Guest21363     
03:24 -!- daniel__ [~daniel@88-117-109-129.adsl.highway.telekom.at] has quit [Ping timeout: 268 seconds]     
03:28 -!- Guest21363 [~daniel@91.114.24.1] has quit [Quit: Konversation terminated!]     
03:47 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-pr-reviews     
04:13 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection]     
04:18 -!- Cassie25Wintheis [~Cassie25W@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-pr-reviews     
04:26 -!- jesseposner [~jesse@98.37.146.62] has joined #bitcoin-core-pr-reviews     
04:31 -!- jesseposner [~jesse@98.37.146.62] has quit [Ping timeout: 246 seconds]     
04:51 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-pr-reviews     
04:53 -!- Cassie25Wintheis [~Cassie25W@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 268 seconds]     
04:54 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 264 seconds]     
05:01 -!- rav3n [92732bd1@146.115.43.209] has quit [Remote host closed the connection]     
05:56 -!- virtu [~virtu@gateway/tor-sasl/virtu] has quit [Ping timeout: 240 seconds]     
05:58 -!- virtu [~virtu@gateway/tor-sasl/virtu] has joined #bitcoin-core-pr-reviews     
06:13 -!- varioust [~varioust@rrcs-76-79-47-154.west.biz.rr.com] has joined #bitcoin-core-pr-reviews     
06:27 -!- jesseposner [~jesse@98.37.146.62] has joined #bitcoin-core-pr-reviews     
06:28 -!- varioust [~varioust@rrcs-76-79-47-154.west.biz.rr.com] has quit [Ping timeout: 256 seconds]     
06:32 -!- jesseposner [~jesse@98.37.146.62] has quit [Ping timeout: 272 seconds]     
06:41 -!- varioust [~varioust@rrcs-76-79-47-154.west.biz.rr.com] has joined #bitcoin-core-pr-reviews     
06:46 -!- varioust [~varioust@rrcs-76-79-47-154.west.biz.rr.com] has quit [Ping timeout: 264 seconds]     
06:47 -!- varioust [~varioust@72-46-56-102.lnk.ne.static.allophone.net] has joined #bitcoin-core-pr-reviews     
07:06 -!- varioust [~varioust@72-46-56-102.lnk.ne.static.allophone.net] has quit [Ping timeout: 268 seconds]     
07:17 -!- varioust [~varioust@rrcs-76-79-47-154.west.biz.rr.com] has joined #bitcoin-core-pr-reviews     
07:22 -!- murch [murch@2a01:4f8:141:1272::2] has joined #bitcoin-core-pr-reviews     
07:34 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]     
07:34 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-pr-reviews     
08:14 -!- varioust [~varioust@rrcs-76-79-47-154.west.biz.rr.com] has quit [Ping timeout: 264 seconds]     
08:29 -!- jesseposner [~jesse@98.37.146.62] has joined #bitcoin-core-pr-reviews     
08:31 -!- varioust [~varioust@rrcs-76-79-47-154.west.biz.rr.com] has joined #bitcoin-core-pr-reviews     
08:39 -!- jesseposner [~jesse@98.37.146.62] has quit [Ping timeout: 240 seconds]     
08:50 < michaelfolkson> Getting a couple of functional test failures on #20220 jonatack
08:51 < michaelfolkson> wallet_labels.py --descriptors and wallet_keypool_topup.py --descriptors
08:51 < michaelfolkson> Looking into it
09:06 -!- varioust [~varioust@rrcs-76-79-47-154.west.biz.rr.com] has quit [Ping timeout: 268 seconds]     
09:39 -!- illlicit_ [uid109953@gateway/web/irccloud.com/x-lcoyskbtceygjmqr] has quit [Read error: Connection reset by peer]     
09:40 -!- illlicit_ [uid109953@gateway/web/irccloud.com/x-ovusytfnzhwjncmz] has joined #bitcoin-core-pr-reviews     
09:40 -!- fjahr [sid374480@gateway/web/irccloud.com/x-mndsjluvnskfolcs] has quit [Ping timeout: 240 seconds]     
09:40 -!- digi_james [sid281632@gateway/web/irccloud.com/x-naztjsjdxirpmkbb] has quit [Ping timeout: 260 seconds]     
09:41 -!- fjahr [sid374480@gateway/web/irccloud.com/x-kcxsrwowfbyaekxq] has joined #bitcoin-core-pr-reviews     
09:41 -!- digi_james [sid281632@gateway/web/irccloud.com/x-hproigixxjvgxexh] has joined #bitcoin-core-pr-reviews     
09:46 -!- varioust [~varioust@rrcs-76-79-47-154.west.biz.rr.com] has joined #bitcoin-core-pr-reviews     
09:55 -!- Aleru [sid403553@gateway/web/irccloud.com/x-keznkmdiyphtgnhl] has quit [Read error: Connection reset by peer]     
09:55 -!- Aleru [sid403553@gateway/web/irccloud.com/x-ymoqgtfigncuwejr] has joined #bitcoin-core-pr-reviews     
10:28 -!- jesseposner [~jesse@98.37.146.62] has joined #bitcoin-core-pr-reviews     
10:35 -!- jesseposner [~jesse@98.37.146.62] has quit [Ping timeout: 258 seconds]     
10:43 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]     
10:43 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-pr-reviews     
10:44 -!- carlakc [uid471474@gateway/web/irccloud.com/x-gfetboweryyjenbv] has joined #bitcoin-core-pr-reviews     
11:00 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-pr-reviews     
11:01 -!- jesseposner [~jesse@98.37.146.62] has joined #bitcoin-core-pr-reviews     
11:07 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews     
11:09 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds]     
12:35 -!- masterdonx2 [~masterdon@titan.pathogen.is] has quit [Ping timeout: 256 seconds]     
13:02 < jonatack> michaelfolkson: thanks for looking at the PR! it does not touch those tests, so the failures are unrelated
13:03 < jonatack> and the CI is green
13:04 < michaelfolkson> Maybe it was this https://github.com/bitcoin/bitcoin/pull/20262
13:05 < michaelfolkson> Would I have compiled your PR branch without sqlite? I guess I wouldn't unless I passed the ----without-sqlite flag (which I didn't)
13:06 < emzy> I had to install sqlite if I remember it right.
13:07 < emzy> I think it was anoter PR. Ignore me :)
13:11 < jonatack> yep since the sqlite wallet PR was merged a week ago, on master and for recent PRs based on it best to have sqlite installed, e.g. brew install sqlite (macOS), apt install libsqlite3-dev (linux), etc.
13:13 < michaelfolkson> I already had sqlite installed. That wouldn't have explained building it without sqlite
13:21 < jonatack> michaelfolkson: hm, maybe make distclean (or make clean) to start off with a clean plate
13:23 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]     
13:24 < michaelfolkson> Do you typically always run `make clean` between building different PR branches?
13:24 < sipa> when you change configuration
13:25 < sipa> with ccache enabled, make clean is no big deal
13:25 < MarcoFalke> Though ccache doesn't cache ld, so building the fuzzers is always slow
13:26 < michaelfolkson> You mean when you change the configuration flags? Or when you configure a new branch (regardless of configuration flags)?
13:26 < michaelfolkson> I have ccache installed
13:26 < jonatack> michaelfolkson: i usually don't change config, but at the slightest weirdness (or if switching to fuzz build or back), then yes make clean
13:27 < sipa> michaelfolkson: well, whenever the configuration changes - that can be because you run ./configure with different flags, or it could be because there are substantial changes to the autoconf/automake scripts when changing branches
13:27 < jonatack> this
13:27 < michaelfolkson> Gotcha, thanks
13:27 < sipa> just changing branches isn't material to the discussion - the build system doesn't even know or care you're using git
13:27 < sipa> it just sees some code and/or configure scripts changed, and re-runs them as necessary
13:30 < sipa> but without "make clean", it'll just see existing .o files, not realizing that the rules used to build them have changed
13:30 < jonatack> right. you could make clean every time, it's just slower. or do it when there's a reason to.
13:30 < sipa> it'll only re-build them if the source code changed
13:31 < sipa> i usually don't make clean, and only run it when the build fails
13:32 < sipa> if it still fails after that, git clean -dfx ;) [warning: that deletes everything, and resets your work dir to just a fresh checkout, you'll need autogen.sh again etc)
13:36 < jonatack> (yes, iirc git clean -dfx requires re-installing bdb 4.8 if you installed it inside root)
13:37 < jonatack> (e.g. using /contrib/install_db4.sh)
13:37 < sipa> --with-incompatible-bdb lalalaa
13:37 < jonatack> hehe yes
14:05 -!- varioust [~varioust@rrcs-76-79-47-154.west.biz.rr.com] has quit [Ping timeout: 264 seconds]     
14:10 < gwillen> I suggest -dfX instead of -dfx (capitalize the x) when doing git clean, it may save your bacon someday
14:10 < gwillen> X only removes ignored files, x also removes locally added non-ignored files, including e.g. new code you did not yet call 'git add' on
14:13 -!- MasterdonX [~masterdon@193.148.18.54] has joined #bitcoin-core-pr-reviews     
14:15 < sipa> gwillen: i should remember that
14:15 < sipa> clean -dfx has definitely bitten me
14:23 < jonatack> gwillen: thanks
14:24 < gwillen> very welcome, I switched when I got bitten myself
14:24 < gwillen> fortunately I still had everything open in my editor, or it would have been really bad
14:24 < sipa> frequently making commits, even WIP ones that you update, is also a good idea :)
14:25 < michaelfolkson> Thanks all for answers https://bitcoin.stackexchange.com/questions/99726/should-i-always-run-make-clean-between-building-different-pr-branches-of-bitco/
14:29 < jonatack> michaelfolkson: thanks. will update my doc to be more explicit on when it's worth running make clean.
14:33 -!- masterdonx2 [~masterdon@45.9.249.246] has joined #bitcoin-core-pr-reviews     
14:36 -!- MasterdonX [~masterdon@193.148.18.54] has quit [Ping timeout: 264 seconds]     
14:38 -!- masterdonx2 is now known as MasterdonX     
14:53 -!- varioust [~varioust@cpe-108-167-11-88.neb.res.rr.com] has joined #bitcoin-core-pr-reviews     
15:08 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews     
15:11 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]     
15:11 -!- vasild_ is now known as vasild     
15:40 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]     
15:40 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-pr-reviews     
16:04 -!- varioust [~varioust@cpe-108-167-11-88.neb.res.rr.com] has quit [Ping timeout: 268 seconds]     
18:07 -!- pinheadm_ [~pinheadmz@172.98.75.205] has joined #bitcoin-core-pr-reviews     
18:10 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Ping timeout: 264 seconds]     
18:38 -!- varioust [~varioust@cpe-108-167-11-88.neb.res.rr.com] has joined #bitcoin-core-pr-reviews     
18:49 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-irdcinsacsmbwsbs] has quit [Ping timeout: 260 seconds]     
18:51 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-cdozfxriapgckafr] has joined #bitcoin-core-pr-reviews     
18:51 -!- wallet42__ [sid154231@gateway/web/irccloud.com/x-ddsrglszoalcxslt] has quit [Ping timeout: 272 seconds]     
18:53 -!- wallet42__ [sid154231@gateway/web/irccloud.com/x-mqxlouvlewbgfsxl] has joined #bitcoin-core-pr-reviews     
19:38 -!- seven_ [~seven@cpe-90-157-197-248.static.amis.net] has quit [Ping timeout: 240 seconds]     
19:38 -!- seven_ [~seven@cpe-90-157-197-248.static.amis.net] has joined #bitcoin-core-pr-reviews     
19:56 -!- S3RK [~S3RK@116.118.83.69] has quit [Remote host closed the connection]     
20:08 -!- seven__ [~seven@cpe-90-157-197-248.static.amis.net] has joined #bitcoin-core-pr-reviews     
20:09 -!- seven_ [~seven@cpe-90-157-197-248.static.amis.net] has quit [Ping timeout: 260 seconds]     
20:26 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 260 seconds]     
20:29 -!- varioust [~varioust@cpe-108-167-11-88.neb.res.rr.com] has quit [Ping timeout: 240 seconds]     
20:36 -!- varioust [~varioust@cpe-108-167-11-88.neb.res.rr.com] has joined #bitcoin-core-pr-reviews     
20:53 -!- musdom [~Thunderbi@2001:f40:904:d841:17:3c79:c45d:aa36] has joined #bitcoin-core-pr-reviews     
21:05 -!- varioust [~varioust@cpe-108-167-11-88.neb.res.rr.com] has quit [Ping timeout: 256 seconds]     
21:27 -!- seven_ [~seven@cpe-90-157-197-248.static.amis.net] has joined #bitcoin-core-pr-reviews     
21:30 -!- seven__ [~seven@cpe-90-157-197-248.static.amis.net] has quit [Ping timeout: 260 seconds]     
21:48 -!- musdom [~Thunderbi@2001:f40:904:d841:17:3c79:c45d:aa36] has quit [Ping timeout: 268 seconds]     
21:50 -!- seven_ [~seven@cpe-90-157-197-248.static.amis.net] has quit [Ping timeout: 240 seconds]     
22:12 -!- jesseposner [~jesse@98.37.146.62] has quit [Ping timeout: 268 seconds]     
22:44 -!- jesseposner [~jesse@98.37.146.62] has joined #bitcoin-core-pr-reviews     
22:48 -!- jesseposner [~jesse@98.37.146.62] has quit [Ping timeout: 246 seconds]     
23:21 -!- jesseposner [~jesse@98.37.146.62] has joined #bitcoin-core-pr-reviews     
23:28 -!- jesseposner [~jesse@98.37.146.62] has quit [Ping timeout: 260 seconds]     
23:53 -!- musdom [~Thunderbi@175.138.73.250] has joined #bitcoin-core-pr-reviews