--- Day changed Fri Nov 27 2020 01:04 -!- wallet42__ [sid154231@gateway/web/irccloud.com/x-knpprhnzjdzupiko] has quit [Ping timeout: 260 seconds] 01:06 -!- wallet42__ [sid154231@gateway/web/irccloud.com/x-qugxujcnhfaqwroa] has joined #bitcoin-core-pr-reviews 03:10 < jnewbery> willcl_ark: that's a great tip. I'm frequently annoyed by how long `./configure` takes! 03:11 < jnewbery> the output is also much easier on the eye 03:17 * hebasto adding `--quite` to bash `configure` aliases 03:19 -!- Alycia62Stroman [~Alycia62S@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-pr-reviews 03:24 -!- Alycia62Stroman [~Alycia62S@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 264 seconds] 03:33 < jonatack> I used to use -q (quiet) but sometimes I like to check the output...crazy, huh 03:33 < jonatack> didn't know about -C 03:40 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 03:46 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has quit [Quit: Leaving] 03:51 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Remote host closed the connection] 03:52 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-pr-reviews 04:45 -!- reallll is now known as belcher 04:47 -!- thomasb06 [863be68d@leat141.unice.fr] has joined #bitcoin-core-pr-reviews 04:49 < thomasb06> By curiosity, the first construction of a non-commutative field other than quaternions (January 1914): https://www.ams.org/journals/tran/1914-015-01/S0002-9947-1914-1500963-8/S0002-9947-1914-1500963-8.pdf 04:49 < thomasb06> The number `j` is abstract, it doesn't exists, like `i` in complex numbers 05:02 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-pr-reviews 05:24 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:7ef3:407f:c35a:de9b:b845] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 05:25 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 246 seconds] 05:29 < michaelfolkson> Had to look up what a quaternion is. A vector and a float apparently 05:30 < michaelfolkson> 1914 paper. A century old, impressive 05:31 < michaelfolkson> Added to StackExchange willcl_ark. Thanks https://bitcoin.stackexchange.com/questions/100224/are-there-any-other-ways-of-speeding-up-the-building-of-bitcoin-core-prs-other-t/ 05:35 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 05:39 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 05:39 -!- vasild_ is now known as vasild 05:43 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-pr-reviews 05:56 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 06:00 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:7ef3:407f:c35a:de9b:b845] has joined #bitcoin-core-pr-reviews 06:04 < thomasb06> michaelfolkson the goal is for you to feel confident with F_p fields, they bite but not as much as more sophisticated ones 06:04 < thomasb06> From Dickson paper, if you pick kappa(x)=x^2-1 06:07 < thomasb06> then `i` is the usual complex number i 06:10 < thomasb06> and from there, you take K the field of real numbers and you get the quaternion field precisely 06:11 < thomasb06> a basis of the quaternion field is thus: 1, i, j, ij 06:11 < thomasb06> and ij is usually writen k 06:12 < thomasb06> anyway... You won't need it but it's to fear F_p fields less... 06:36 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 06:40 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 06:54 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:7ef3:407f:c35a:de9b:b845] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 06:57 -!- joelklabo [~textual@157-131-101-185.fiber.dynamic.sonic.net] has joined #bitcoin-core-pr-reviews 07:05 < sdaftuar> dhruvm: i don't understand the "addrman 100% poisoned" reference -- a peer can be eclipsed regardless of how "poisoned" its addrman is, it's just a question of likelihood/cost 07:06 < sdaftuar> dhruvm: an adversary with 10 (diverse) ip addresses can (with very low probability) eclipse new nodes coming online, today 07:06 -!- davterra [~davterra@68.235.43.94] has quit [Quit: Leaving] 07:07 < sdaftuar> because aside from the stale-tip-detection logic, we don't make any attempt to rotate our outbound peers 07:08 < sdaftuar> and it's possible to bypass that logic by feeding blocks (slowly) to the target peer, which opens up certain kinds of attacks (either by mining a bogus/less work chain, or even just keeping a peer lagged behind the network for the purposes of attacks on eg layer 2 systems like lightning) 07:10 < sdaftuar> anyway i do agree with the statement that this PR is not just an incremental change to our peering/network topology -- it would be a step-up in costs to an attacker to sustain a partitioning attack against a node, because after this pr we should always eventually find the honest chain, as long as we have at least 1 honest peer in our addrman. 07:11 < sdaftuar> (of course, if our addrman is taken over, then things are pretty hopeless) 07:13 < sdaftuar> but your point is right that if we're a listening node and our addrman is taken over, then theoretically honest peers could still connect in to us and keep us connected to the honest network. that seems an unlikely situation however, as if we're taking connections from honest peers, we should also have a not-completely-overrun addrman 07:26 -!- davterra [~davterra@68.235.43.102] has joined #bitcoin-core-pr-reviews 07:46 -!- thomasb06 [863be68d@leat141.unice.fr] has quit [Remote host closed the connection] 08:20 -!- joelklabo [~textual@157-131-101-185.fiber.dynamic.sonic.net] has quit [Quit: My iMac has gone to sleep. ZZZzzz…] 09:43 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 09:46 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 09:55 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 09:58 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 10:09 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 264 seconds] 10:47 < jnewbery> Notes and questions for next week's meeting are up: https://bitcoincore.reviews/19698 10:47 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 10:51 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 11:47 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 11:51 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 265 seconds] 12:35 -!- joelklabo [~textual@157-131-101-185.fiber.dynamic.sonic.net] has joined #bitcoin-core-pr-reviews 12:47 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 12:51 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 264 seconds] 13:21 -!- tinova [~tinova@lemoncat.org] has quit [Ping timeout: 256 seconds] 13:21 -!- raj_ [~quassel@ec2-18-217-191-36.us-east-2.compute.amazonaws.com] has quit [Ping timeout: 256 seconds] 13:22 -!- raj_149 [~quassel@ec2-18-217-191-36.us-east-2.compute.amazonaws.com] has joined #bitcoin-core-pr-reviews 13:22 -!- tinova [~tinova@lemoncat.org] has joined #bitcoin-core-pr-reviews 13:23 -!- jonatack [~jon@82.102.27.171] has quit [Ping timeout: 256 seconds] 13:24 -!- jonatack [~jon@82.102.27.171] has joined #bitcoin-core-pr-reviews 13:25 -!- justinmoon [~quassel@157.245.122.126] has quit [Ping timeout: 256 seconds] 13:26 -!- justinmoon [~quassel@157.245.122.126] has joined #bitcoin-core-pr-reviews 13:28 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 256 seconds] 13:47 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 13:51 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 265 seconds] 14:01 -!- seven__ [~seven@cpe-90-157-197-248.static.amis.net] has joined #bitcoin-core-pr-reviews 14:04 -!- seven_ [~seven@cpe-90-157-197-248.static.amis.net] has quit [Ping timeout: 240 seconds] 14:04 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-pr-reviews 14:05 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-pr-reviews 14:30 -!- tylerchambers [~tylercham@155.138.202.203] has joined #bitcoin-core-pr-reviews 14:39 -!- joelklabo [~textual@157-131-101-185.fiber.dynamic.sonic.net] has quit [Quit: My iMac has gone to sleep. ZZZzzz…] 14:48 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 14:52 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 272 seconds] 15:21 -!- joelklabo [~textual@157-131-101-185.fiber.dynamic.sonic.net] has joined #bitcoin-core-pr-reviews 15:48 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 15:49 -!- glozow [uid453516@gateway/web/irccloud.com/x-wgwavzwbrixyodio] has quit [Quit: Connection closed for inactivity] 15:52 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 272 seconds] 15:52 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 15:54 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 15:55 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 16:04 -!- abitcoinperson [b1e78434@177.231.132.52] has joined #bitcoin-core-pr-reviews 16:04 -!- abitcoinperson [b1e78434@177.231.132.52] has left #bitcoin-core-pr-reviews [] 16:05 -!- abitcoin_ [~abitcoinp@177.231.132.52] has joined #bitcoin-core-pr-reviews 16:06 -!- abitcoin_ [~abitcoinp@177.231.132.52] has quit [Client Quit] 16:20 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Quit: pinheadmz] 16:22 -!- joelklabo [~textual@157-131-101-185.fiber.dynamic.sonic.net] has quit [Quit: My iMac has gone to sleep. ZZZzzz…] 16:26 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:7ef3:407f:c35a:de9b:b845] has joined #bitcoin-core-pr-reviews 16:27 -!- glozow [uid453516@gateway/web/irccloud.com/x-ipsfkttnncmlxwsi] has joined #bitcoin-core-pr-reviews 16:28 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-pr-reviews 16:48 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 16:50 < dhruvm> sdaftuar: Thank you, that helps me understand. If an incoming block-relay connection reveals we are behind by more than 1 block, and is a listening peer, are there downsides to evicting an outbound peer to open a slot for the more up-to-date peer? 16:51 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 16:56 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:7ef3:407f:c35a:de9b:b845] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 17:03 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:7ef3:407f:c35a:de9b:b845] has joined #bitcoin-core-pr-reviews 17:14 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has quit [Ping timeout: 240 seconds] 17:16 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has joined #bitcoin-core-pr-reviews 17:19 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:7ef3:407f:c35a:de9b:b845] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 17:35 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 17:39 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 17:39 -!- vasild_ is now known as vasild 17:48 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 17:52 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 18:03 -!- seven__ [~seven@cpe-90-157-197-248.static.amis.net] has quit [Ping timeout: 256 seconds] 18:38 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Quit: pinheadmz] 18:48 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 18:52 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 264 seconds] 19:36 -!- dhruvm [~noreply@c-73-158-59-66.hsd1.ca.comcast.net] has quit [Ping timeout: 264 seconds] 19:48 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 19:52 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 272 seconds] 19:55 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-pr-reviews 19:58 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 272 seconds] 20:28 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-pr-reviews 20:29 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 240 seconds] 20:34 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.161-165.dynamic.3bb.co.th] has joined #bitcoin-core-pr-reviews 20:48 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 20:52 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 272 seconds] 20:59 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 20:59 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-pr-reviews 21:19 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.161-165.dynamic.3bb.co.th] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 21:23 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.161.165] has joined #bitcoin-core-pr-reviews 21:48 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 21:51 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 22:12 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.161.165] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 22:48 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 22:53 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 265 seconds] 23:27 -!- prayank [8ba7ca3e@139.167.202.62] has joined #bitcoin-core-pr-reviews 23:33 < prayank> If I add these lines: https://pastebin.com/N96V6jF7 after Line 2728(https://github.com/bitcoin/bitcoin/blob/e2ff5e7b35d71195278d2a2ed9485f141de33d7a/src/wallet/rpcwallet.cpp#L2728) should this give error when I use RPC command "createwallet" and wallet name is "../TestWallet" ? If yes, why is it not working for me? If no, whats wrong in the code or 23:33 < prayank> the place where its added? 23:34 < prayank> Sorry if this is a noob question. I want to learn and contribute. 23:48 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 23:53 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 265 seconds]