--- Day changed Sat Nov 28 2020 00:41 -!- prayank [8ba7ca3e@139.167.202.62] has quit [Ping timeout: 245 seconds] 00:49 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 00:52 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 01:01 -!- prayank [8ba7ca3e@139.167.202.62] has joined #bitcoin-core-pr-reviews 01:10 -!- seven__ [~seven@cpe-90-157-197-248.static.amis.net] has joined #bitcoin-core-pr-reviews 01:28 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:7ef3:407f:c35a:de9b:b845] has joined #bitcoin-core-pr-reviews 02:06 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 02:11 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 272 seconds] 02:28 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:7ef3:407f:c35a:de9b:b845] has quit [Read error: Connection reset by peer] 02:29 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:7ef3:407f:c35a:de9b:b845] has joined #bitcoin-core-pr-reviews 02:34 < jonatack> prayank: maybe LogPrintf request.params[0] and first_char, do you have a test case (e.g. wallet_createwallet.py), did you try other cases like "../.TestWallet" 02:48 < jonatack> prayank: oh, also have a look at usage of ::front https://en.cppreference.com/w/cpp/string/basic_string/front 02:52 < prayank> jonatack: Thanks. Will try LogPrintf. No test case yet. Yes tried different names with first character being invalid according to IF statement. 02:52 < jonatack> maybe https://en.cppreference.com/w/cpp/string/basic_string/find_first_of 02:52 < prayank> Usage of ::front ? 02:53 < prayank> Its working in this test code 02:53 < prayank> https://i.imgur.com/ix2U0gn.png 02:54 < prayank> > maybe https://en.cppreference.com/w/cpp/string/basic_string/find_first_of 02:54 < prayank> Yup luke-jr suggested the same 02:55 < prayank> Will try 02:55 < jonatack> prayank: these aren't answers, just ideas :) 03:01 < prayank> (y) 03:06 < jonatack> yes in isolation seems ok https://godbolt.org/z/jdYET4 03:06 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 03:10 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 03:15 -!- prayank1 [8ba7ca3e@139.167.202.62] has joined #bitcoin-core-pr-reviews 03:16 -!- prayank1 [8ba7ca3e@139.167.202.62] has left #bitcoin-core-pr-reviews [] 03:17 -!- prayank [8ba7ca3e@139.167.202.62] has quit [Ping timeout: 245 seconds] 03:18 -!- Chloe78Kling [~Chloe78Kl@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-pr-reviews 03:23 -!- Chloe78Kling [~Chloe78Kl@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 256 seconds] 04:07 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 04:10 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 04:17 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-pr-reviews 04:51 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:7ef3:407f:c35a:de9b:b845] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 05:07 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 05:10 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 05:15 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.161-165.dynamic.3bb.co.th] has joined #bitcoin-core-pr-reviews 05:21 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 05:23 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 05:26 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 05:35 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 05:35 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection] 05:38 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 05:40 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 06:37 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 06:42 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.161-165.dynamic.3bb.co.th] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 07:30 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 07:30 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-pr-reviews 08:04 -!- joelklabo [~textual@157-131-101-185.fiber.dynamic.sonic.net] has joined #bitcoin-core-pr-reviews 08:50 -!- shesek [~shesek@164.90.217.137] has joined #bitcoin-core-pr-reviews 08:50 -!- shesek [~shesek@164.90.217.137] has quit [Changing host] 08:50 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-pr-reviews 09:27 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 240 seconds] 09:27 -!- joelklabo [~textual@157-131-101-185.fiber.dynamic.sonic.net] has quit [Quit: My iMac has gone to sleep. ZZZzzz…] 10:13 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds] 10:14 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-pr-reviews 10:27 -!- dhruvm [~noreply@c-73-158-59-66.hsd1.ca.comcast.net] has joined #bitcoin-core-pr-reviews 10:59 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.161-165.dynamic.3bb.co.th] has joined #bitcoin-core-pr-reviews 11:03 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.161-165.dynamic.3bb.co.th] has quit [Ping timeout: 240 seconds] 11:26 -!- joelklabo [~textual@157-131-101-185.fiber.dynamic.sonic.net] has joined #bitcoin-core-pr-reviews 12:04 -!- seven__ [~seven@cpe-90-157-197-248.static.amis.net] has quit [Read error: Connection reset by peer] 12:06 -!- seven_ [~seven@cpe-90-157-197-248.static.amis.net] has joined #bitcoin-core-pr-reviews 12:58 -!- joelklabo [~textual@157-131-101-185.fiber.dynamic.sonic.net] has quit [Quit: My iMac has gone to sleep. ZZZzzz…] 14:00 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 14:09 -!- belcher_ is now known as belcher 14:20 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 14:23 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 14:55 -!- Netsplit *.net <-> *.split quits: @ChanServ 15:01 -!- Netsplit over, joins: @ChanServ 15:10 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 15:13 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 15:20 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 15:20 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 16:05 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 16:05 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-pr-reviews 17:35 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-pr-reviews 17:37 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 17:38 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 17:38 -!- vasild_ is now known as vasild 17:40 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 19:04 -!- joelklabo [~textual@157-131-101-185.fiber.dynamic.sonic.net] has joined #bitcoin-core-pr-reviews 19:13 -!- windsok [~windsok@unaffiliated/windsok] has joined #bitcoin-core-pr-reviews 19:39 -!- seven_ [~seven@cpe-90-157-197-248.static.amis.net] has quit [Ping timeout: 256 seconds] 19:47 -!- jesseposner [~jp@2601:643:8980:bfd2:29df:a2cb:6f55:8d6d] has quit [Ping timeout: 260 seconds] 19:50 -!- mol_ [~mol@unaffiliated/molly] has quit [Read error: Connection reset by peer] 19:50 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-pr-reviews 19:55 -!- reallll [~belcher@unaffiliated/belcher] has joined #bitcoin-core-pr-reviews 19:57 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds] 21:13 -!- reallll [~belcher@unaffiliated/belcher] has quit [Ping timeout: 256 seconds] 21:14 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-pr-reviews 23:03 -!- joelklabo [~textual@157-131-101-185.fiber.dynamic.sonic.net] has quit [Quit: My iMac has gone to sleep. ZZZzzz…] 23:17 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 264 seconds] 23:35 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-pr-reviews 23:36 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds]